gsd-pi 2.77.0-dev.eaa4973bc → 2.78.0-dev.aeeb2ca00

package/packages/pi-tui/dist/components/image.test.js

@@ -7,12 +7,13 @@ import assert from "node:assert/strict";
 import { Image } from "./image.js";
 describe("Image component (#3455)", () => {
     const theme = { fallbackColor: (s) => s };
-    test("getDimensions returns undefined before resolution", () => {
-        // Pass explicit dimensions to avoid async parsing
+    test("getDimensions returns undefined when constructed without explicit dims", () => {
+        // Previously this test was titled "returns undefined before resolution"
+        // but only asserted `typeof getDimensions === 'function'`. The title
+        // and the assertion had nothing to do with each other (#4794).
+        // Now actually assert the undefined return.
         const img = new Image("base64data", "image/png", theme, {});
-        // Without explicit dims, getDimensions should be undefined until async resolve
-        // But we can't easily test async here, so verify the method exists
-        assert.equal(typeof img.getDimensions, "function");
+        assert.equal(img.getDimensions(), undefined, "without pre-resolved dims, getDimensions must return undefined until async resolve");
     });
     test("getDimensions returns dimensions when provided at construction", () => {
         const dims = { widthPx: 100, heightPx: 200 };

package/packages/pi-tui/dist/components/image.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"image.test.js","sourceRoot":"","sources":["../../src/components/image.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC3C,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AAEnC,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACxC,MAAM,KAAK,GAAG,EAAE,aAAa,EAAE,CAAC,CAAS,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC;IAElD,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC9D,kDAAkD;QAClD,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;QAC5D,+EAA+E;QAC/E,mEAAmE;QACnE,MAAM,CAAC,KAAK,CAAC,OAAO,GAAG,CAAC,aAAa,EAAE,UAAU,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;QAC3E,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,MAAM,MAAM,GAAG,GAAG,CAAC,aAAa,EAAE,CAAC;QACnC,MAAM,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,mCAAmC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,sEAAsE,EAAE,GAAG,EAAE;QACjF,IAAI,SAAS,GAAG,CAAC,CAAC;QAClB,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,GAAG,CAAC,uBAAuB,CAAC,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,6DAA6D;QAC7D,MAAM,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC,EAAE,sDAAsD,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Regression test for #3455: Image component must not trigger infinite\n * re-render loop when dimensions resolve in cmux sessions.\n */\n\nimport { describe, test } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Image } from \"./image.js\";\n\ndescribe(\"Image component (#3455)\", () => {\n\tconst theme = { fallbackColor: (s: string) => s };\n\n\ttest(\"getDimensions returns undefined before resolution\", () => {\n\t\t// Pass explicit dimensions to avoid async parsing\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {});\n\t\t// Without explicit dims, getDimensions should be undefined until async resolve\n\t\t// But we can't easily test async here, so verify the method exists\n\t\tassert.equal(typeof img.getDimensions, \"function\");\n\t});\n\n\ttest(\"getDimensions returns dimensions when provided at construction\", () => {\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\tconst result = img.getDimensions();\n\t\tassert.deepEqual(result, dims, \"Should return provided dimensions\");\n\t});\n\n\ttest(\"onDimensionsResolved callback is not called when dimensions provided\", () => {\n\t\tlet callCount = 0;\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\timg.setOnDimensionsResolved(() => { callCount++; });\n\t\t// With pre-resolved dims, the async path is skipped entirely\n\t\tassert.equal(callCount, 0, \"Callback should not fire for pre-resolved dimensions\");\n\t});\n});\n"]}
+{"version":3,"file":"image.test.js","sourceRoot":"","sources":["../../src/components/image.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC3C,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,KAAK,EAAE,MAAM,YAAY,CAAC;AAEnC,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACxC,MAAM,KAAK,GAAG,EAAE,aAAa,EAAE,CAAC,CAAS,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC;IAElD,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;QACnF,wEAAwE;QACxE,qEAAqE;QACrE,+DAA+D;QAC/D,4CAA4C;QAC5C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;QAC5D,MAAM,CAAC,KAAK,CACX,GAAG,CAAC,aAAa,EAAE,EACnB,SAAS,EACT,oFAAoF,CACpF,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;QAC3E,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,MAAM,MAAM,GAAG,GAAG,CAAC,aAAa,EAAE,CAAC;QACnC,MAAM,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,mCAAmC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,sEAAsE,EAAE,GAAG,EAAE;QACjF,IAAI,SAAS,GAAG,CAAC,CAAC;QAClB,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;QAC7C,MAAM,GAAG,GAAG,IAAI,KAAK,CAAC,YAAY,EAAE,WAAW,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QAClE,GAAG,CAAC,uBAAuB,CAAC,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QACpD,6DAA6D;QAC7D,MAAM,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC,EAAE,sDAAsD,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Regression test for #3455: Image component must not trigger infinite\n * re-render loop when dimensions resolve in cmux sessions.\n */\n\nimport { describe, test } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Image } from \"./image.js\";\n\ndescribe(\"Image component (#3455)\", () => {\n\tconst theme = { fallbackColor: (s: string) => s };\n\n\ttest(\"getDimensions returns undefined when constructed without explicit dims\", () => {\n\t\t// Previously this test was titled \"returns undefined before resolution\"\n\t\t// but only asserted `typeof getDimensions === 'function'`. The title\n\t\t// and the assertion had nothing to do with each other (#4794).\n\t\t// Now actually assert the undefined return.\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {});\n\t\tassert.equal(\n\t\t\timg.getDimensions(),\n\t\t\tundefined,\n\t\t\t\"without pre-resolved dims, getDimensions must return undefined until async resolve\",\n\t\t);\n\t});\n\n\ttest(\"getDimensions returns dimensions when provided at construction\", () => {\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\tconst result = img.getDimensions();\n\t\tassert.deepEqual(result, dims, \"Should return provided dimensions\");\n\t});\n\n\ttest(\"onDimensionsResolved callback is not called when dimensions provided\", () => {\n\t\tlet callCount = 0;\n\t\tconst dims = { widthPx: 100, heightPx: 200 };\n\t\tconst img = new Image(\"base64data\", \"image/png\", theme, {}, dims);\n\t\timg.setOnDimensionsResolved(() => { callCount++; });\n\t\t// With pre-resolved dims, the async path is skipped entirely\n\t\tassert.equal(callCount, 0, \"Callback should not fire for pre-resolved dimensions\");\n\t});\n});\n"]}

package/packages/pi-tui/dist/editor-component.d.ts

@@ -18,6 +18,8 @@ export interface EditorComponent extends Component {
     onSubmit?: (text: string) => void;
     /** Called when text changes */
     onChange?: (text: string) => void;
+    /** Called when an image file path is pasted via terminal emulator */
+    onPasteImagePath?: (filePath: string) => void;
     /** Add text to history for up/down navigation */
     addToHistory?(text: string): void;
     /** Insert text at current cursor position */

package/packages/pi-tui/dist/editor-component.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"editor-component.d.ts","sourceRoot":"","sources":["../src/editor-component.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,mBAAmB,CAAC;AAC9D,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,UAAU,CAAC;AAE1C;;;;;;GAMG;AACH,MAAM,WAAW,eAAgB,SAAQ,SAAS;IAKjD,mCAAmC;IACnC,OAAO,IAAI,MAAM,CAAC;IAElB,2BAA2B;IAC3B,OAAO,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAE5B,qEAAqE;IACrE,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAMhC,iDAAiD;IACjD,QAAQ,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAElC,+BAA+B;IAC/B,QAAQ,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAMlC,iDAAiD;IACjD,YAAY,CAAC,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAMlC,6CAA6C;IAC7C,kBAAkB,CAAC,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAExC;;;OAGG;IACH,eAAe,CAAC,IAAI,MAAM,CAAC;IAM3B,oCAAoC;IACpC,uBAAuB,CAAC,CAAC,QAAQ,EAAE,oBAAoB,GAAG,IAAI,CAAC;IAM/D,4BAA4B;IAC5B,WAAW,CAAC,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,MAAM,CAAC;IAEtC,6BAA6B;IAC7B,WAAW,CAAC,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI,CAAC;IAEpC,qDAAqD;IACrD,yBAAyB,CAAC,CAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CACrD"}
+{"version":3,"file":"editor-component.d.ts","sourceRoot":"","sources":["../src/editor-component.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,mBAAmB,CAAC;AAC9D,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,UAAU,CAAC;AAE1C;;;;;;GAMG;AACH,MAAM,WAAW,eAAgB,SAAQ,SAAS;IAKjD,mCAAmC;IACnC,OAAO,IAAI,MAAM,CAAC;IAElB,2BAA2B;IAC3B,OAAO,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAE5B,qEAAqE;IACrE,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAMhC,iDAAiD;IACjD,QAAQ,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAElC,+BAA+B;IAC/B,QAAQ,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IAElC,qEAAqE;IACrE,gBAAgB,CAAC,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,IAAI,CAAC;IAM9C,iDAAiD;IACjD,YAAY,CAAC,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAMlC,6CAA6C;IAC7C,kBAAkB,CAAC,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IAExC;;;OAGG;IACH,eAAe,CAAC,IAAI,MAAM,CAAC;IAM3B,oCAAoC;IACpC,uBAAuB,CAAC,CAAC,QAAQ,EAAE,oBAAoB,GAAG,IAAI,CAAC;IAM/D,4BAA4B;IAC5B,WAAW,CAAC,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,MAAM,CAAC;IAEtC,6BAA6B;IAC7B,WAAW,CAAC,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI,CAAC;IAEpC,qDAAqD;IACrD,yBAAyB,CAAC,CAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CACrD"}

package/packages/pi-tui/dist/editor-component.js.map

@@ -1 +1 @@
-{"version":3,"file":"editor-component.js","sourceRoot":"","sources":["../src/editor-component.ts"],"names":[],"mappings":"","sourcesContent":["import type { AutocompleteProvider } from \"./autocomplete.js\";\nimport type { Component } from \"./tui.js\";\n\n/**\n * Interface for custom editor components.\n *\n * This allows extensions to provide their own editor implementation\n * (e.g., vim mode, emacs mode, custom keybindings) while maintaining\n * compatibility with the core application.\n */\nexport interface EditorComponent extends Component {\n\t// =========================================================================\n\t// Core text access (required)\n\t// =========================================================================\n\n\t/** Get the current text content */\n\tgetText(): string;\n\n\t/** Set the text content */\n\tsetText(text: string): void;\n\n\t/** Handle raw terminal input (key presses, paste sequences, etc.) */\n\thandleInput(data: string): void;\n\n\t// =========================================================================\n\t// Callbacks (required)\n\t// =========================================================================\n\n\t/** Called when user submits (e.g., Enter key) */\n\tonSubmit?: (text: string) => void;\n\n\t/** Called when text changes */\n\tonChange?: (text: string) => void;\n\n\t// =========================================================================\n\t// History support (optional)\n\t// =========================================================================\n\n\t/** Add text to history for up/down navigation */\n\taddToHistory?(text: string): void;\n\n\t// =========================================================================\n\t// Advanced text manipulation (optional)\n\t// =========================================================================\n\n\t/** Insert text at current cursor position */\n\tinsertTextAtCursor?(text: string): void;\n\n\t/**\n\t * Get text with any markers expanded (e.g., paste markers).\n\t * Falls back to getText() if not implemented.\n\t */\n\tgetExpandedText?(): string;\n\n\t// =========================================================================\n\t// Autocomplete support (optional)\n\t// =========================================================================\n\n\t/** Set the autocomplete provider */\n\tsetAutocompleteProvider?(provider: AutocompleteProvider): void;\n\n\t// =========================================================================\n\t// Appearance (optional)\n\t// =========================================================================\n\n\t/** Border color function */\n\tborderColor?: (str: string) => string;\n\n\t/** Set horizontal padding */\n\tsetPaddingX?(padding: number): void;\n\n\t/** Set max visible items in autocomplete dropdown */\n\tsetAutocompleteMaxVisible?(maxVisible: number): void;\n}\n"]}
+{"version":3,"file":"editor-component.js","sourceRoot":"","sources":["../src/editor-component.ts"],"names":[],"mappings":"","sourcesContent":["import type { AutocompleteProvider } from \"./autocomplete.js\";\nimport type { Component } from \"./tui.js\";\n\n/**\n * Interface for custom editor components.\n *\n * This allows extensions to provide their own editor implementation\n * (e.g., vim mode, emacs mode, custom keybindings) while maintaining\n * compatibility with the core application.\n */\nexport interface EditorComponent extends Component {\n\t// =========================================================================\n\t// Core text access (required)\n\t// =========================================================================\n\n\t/** Get the current text content */\n\tgetText(): string;\n\n\t/** Set the text content */\n\tsetText(text: string): void;\n\n\t/** Handle raw terminal input (key presses, paste sequences, etc.) */\n\thandleInput(data: string): void;\n\n\t// =========================================================================\n\t// Callbacks (required)\n\t// =========================================================================\n\n\t/** Called when user submits (e.g., Enter key) */\n\tonSubmit?: (text: string) => void;\n\n\t/** Called when text changes */\n\tonChange?: (text: string) => void;\n\n\t/** Called when an image file path is pasted via terminal emulator */\n\tonPasteImagePath?: (filePath: string) => void;\n\n\t// =========================================================================\n\t// History support (optional)\n\t// =========================================================================\n\n\t/** Add text to history for up/down navigation */\n\taddToHistory?(text: string): void;\n\n\t// =========================================================================\n\t// Advanced text manipulation (optional)\n\t// =========================================================================\n\n\t/** Insert text at current cursor position */\n\tinsertTextAtCursor?(text: string): void;\n\n\t/**\n\t * Get text with any markers expanded (e.g., paste markers).\n\t * Falls back to getText() if not implemented.\n\t */\n\tgetExpandedText?(): string;\n\n\t// =========================================================================\n\t// Autocomplete support (optional)\n\t// =========================================================================\n\n\t/** Set the autocomplete provider */\n\tsetAutocompleteProvider?(provider: AutocompleteProvider): void;\n\n\t// =========================================================================\n\t// Appearance (optional)\n\t// =========================================================================\n\n\t/** Border color function */\n\tborderColor?: (str: string) => string;\n\n\t/** Set horizontal padding */\n\tsetPaddingX?(padding: number): void;\n\n\t/** Set max visible items in autocomplete dropdown */\n\tsetAutocompleteMaxVisible?(maxVisible: number): void;\n}\n"]}

package/packages/pi-tui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gsd/pi-tui",
-  "version": "2.77.0",
+  "version": "2.78.0",
   "description": "Terminal User Interface library (vendored from pi-mono)",
   "type": "module",
   "gsd": {

package/packages/pi-tui/src/__tests__/autocomplete.test.ts

@@ -127,20 +127,36 @@ describe("CombinedAutocompleteProvider — argument completions", () => {
 });
 
 describe("CombinedAutocompleteProvider — @ file prefix extraction", () => {
-	it("detects @ at start of line", () => {
+	it("detects @ at start of line and returns a valid suggestion shape", () => {
 		const provider = makeProvider();
-		// @ triggers fuzzy file search — we can't test the actual file results
-		// but we can test that getSuggestions returns null (no files in /tmp matching)
-		// rather than crashing
 		const result = provider.getSuggestions(["@nonexistent_xyz"], 0, 16);
-		// May return null or empty — the key thing is it doesn't crash
-		assert.ok(result === null || result.items.length >= 0);
+		// Either null (nothing matched) or a well-formed {items: Array, prefix: string}
+		// shape. Previous version's `result.items.length >= 0` was a tautology —
+		// array length is always ≥ 0; the whole expression could never fail.
+		if (result !== null) {
+			assert.ok(Array.isArray(result.items), "result.items must be an array");
+			// The @-prefix extraction strips the leading @ — prefix should be
+			// the raw text without the trigger character.
+			assert.equal(typeof result.prefix, "string", "prefix must be a string");
+			assert.ok(
+				!result.prefix.startsWith("@"),
+				`prefix must have the @ trigger stripped, got: ${JSON.stringify(result.prefix)}`,
+			);
+		}
 	});
 
-	it("detects @ after space", () => {
+	it("detects @ after space and returns a valid suggestion shape", () => {
 		const provider = makeProvider();
 		const result = provider.getSuggestions(["check @nonexistent_xyz"], 0, 22);
-		assert.ok(result === null || result.items.length >= 0);
+		if (result !== null) {
+			assert.ok(Array.isArray(result.items), "result.items must be an array");
+			assert.equal(typeof result.prefix, "string", "prefix must be a string");
+			// The prefix must NOT include the word "check" that came before the @.
+			assert.ok(
+				!result.prefix.includes("check"),
+				`prefix must not include text before the @, got: ${JSON.stringify(result.prefix)}`,
+			);
+		}
 	});
 
 	it("returns null for bare @ with no query to avoid full tree walk (#1824)", () => {

package/packages/pi-tui/src/__tests__/overlay-layout.test.ts

@@ -1,4 +1,16 @@
 // pi-tui — Overlay Layout Tests (backdrop dimming)
+//
+// These tests previously coupled to literal ANSI escape bytes
+// (`\x1b[2m`, `\x1b[38;5;240m`) and would break if the palette index or
+// SGR spelling changed despite identical rendered output — Goodhart's law:
+// the test measures escape codes, not dimming.
+//
+// We now parse the SGR escape codes into a semantic style state and assert
+// on the visible contract: the covered-but-outside-overlay region is dim,
+// has a non-default foreground (so the eye can distinguish foreground from
+// background), and does not paint the terminal background (so user themes
+// are preserved). The overlay content itself is reachable via plain-text
+// lookup after stripping ANSI.
 
 import { describe, it } from "node:test";
 import assert from "node:assert/strict";
@@ -16,8 +28,107 @@ function makeEntry(
 	};
 }
 
+/**
+ * Parse a line's ANSI SGR state immediately before the first occurrence of a
+ * target substring in the rendered (ANSI-stripped) text. Walks `\x1b[...m`
+ * sequences left-to-right, maintaining a running state so we can ask what
+ * the terminal is doing when it reaches the target glyphs.
+ *
+ * Semantic fields:
+ *   - dim:    SGR 2 active and not reset by SGR 22 / 0
+ *   - fg:     foreground: "default" | "set" | the raw numeric parameters
+ *   - bg:     background: "default" | "set"
+ */
+type SgrState = { dim: boolean; fg: "default" | "set"; bg: "default" | "set" };
+
+function sgrStateAtGlyph(line: string, targetGlyph: string): SgrState {
+	const state: SgrState = { dim: false, fg: "default", bg: "default" };
+	// Walk codes and visible chars, tracking visible-glyph position.
+	let visibleSeen = "";
+	let i = 0;
+	while (i < line.length) {
+		if (line[i] === "\x1b" && line[i + 1] === "[") {
+			// Read until final byte in 0x40-0x7E
+			let j = i + 2;
+			while (j < line.length) {
+				const c = line.charCodeAt(j);
+				if (c >= 0x40 && c <= 0x7e) break;
+				j++;
+			}
+			const final = line[j];
+			if (final === "m") {
+				const paramString = line.slice(i + 2, j);
+				applySgr(state, paramString);
+			}
+			i = j + 1;
+			continue;
+		}
+		// Skip other escape sequences (OSC hyperlinks etc) conservatively:
+		// if we ever hit a non-SGR escape, just step past the ESC.
+		if (line[i] === "\x1b") {
+			i++;
+			continue;
+		}
+		visibleSeen += line[i];
+		if (visibleSeen.endsWith(targetGlyph)) {
+			// We've just consumed the last char of targetGlyph — return the
+			// state that was in effect for the whole match.
+			return state;
+		}
+		i++;
+	}
+	throw new Error(`Target glyph ${JSON.stringify(targetGlyph)} not found in line`);
+}
+
+function applySgr(state: SgrState, paramString: string): void {
+	// Empty params == reset
+	const parts = paramString === "" ? ["0"] : paramString.split(";");
+	let k = 0;
+	while (k < parts.length) {
+		const n = parts[k] === "" ? 0 : Number(parts[k]);
+		if (n === 0) {
+			state.dim = false;
+			state.fg = "default";
+			state.bg = "default";
+		} else if (n === 2) {
+			state.dim = true;
+		} else if (n === 22) {
+			state.dim = false;
+		} else if (n === 39) {
+			state.fg = "default";
+		} else if (n === 49) {
+			state.bg = "default";
+		} else if ((n >= 30 && n <= 37) || (n >= 90 && n <= 97)) {
+			state.fg = "set";
+		} else if ((n >= 40 && n <= 47) || (n >= 100 && n <= 107)) {
+			state.bg = "set";
+		} else if (n === 38) {
+			state.fg = "set";
+			// Skip colour-model parameters: 38;5;N or 38;2;R;G;B
+			if (parts[k + 1] === "5") {
+				k += 2;
+			} else if (parts[k + 1] === "2") {
+				k += 4;
+			}
+		} else if (n === 48) {
+			state.bg = "set";
+			if (parts[k + 1] === "5") {
+				k += 2;
+			} else if (parts[k + 1] === "2") {
+				k += 4;
+			}
+		}
+		k++;
+	}
+}
+
+function stripAnsi(line: string): string {
+	// Remove CSI sequences. Good enough for these tests.
+	return line.replace(/\x1b\[[0-?]*[ -/]*[@-~]/g, "");
+}
+
 describe("compositeOverlays — backdrop", () => {
-	it("dims base lines when backdrop is true", () => {
+	it("dims base lines outside the overlay when backdrop is true", () => {
 		const base = ["hello world", "second line"];
 		const overlay = makeEntry(["OVERLAY"], {
 			width: 7,
@@ -27,14 +138,17 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// All base lines in viewport should contain dim escape (\x1b[2m)
-		// The overlay line itself is composited on top, but underlying lines get dimmed
-		const dimmedLine = result.find((l) => l.includes("second line"));
-		assert.ok(dimmedLine, "should have a line containing 'second line'");
-		assert.ok(dimmedLine.includes("\x1b[2m"), "base line should be dimmed");
+		// "second line" is below the overlay (which is anchored top-left with
+		// a single visible row), so every glyph of that text should be
+		// rendered with the dim attribute active.
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
+		assert.ok(line, "should have a line containing 'second line'");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.dim, true, "base line should be dimmed (SGR 2)");
 	});
 
-	it("backdrop uses gray foreground for dimming", () => {
+	it("backdrop applies a non-default foreground colour and leaves background untouched", () => {
 		const base = ["hello world", "second line"];
 		const overlay = makeEntry(["OV"], {
 			width: 2,
@@ -44,11 +158,16 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// Check a non-overlay line for backdrop codes (dim + gray fg, no bg)
-		const line = result.find((l) => l.includes("second line"));
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
 		assert.ok(line, "should have a line containing 'second line'");
-		assert.ok(line.includes("\x1b[38;5;240m"), "backdrop should set gray foreground");
-		assert.ok(!line.includes("\x1b[48;"), "backdrop should not set background color");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.fg, "set", "backdrop must set a foreground colour");
+		assert.equal(
+			state.bg,
+			"default",
+			"backdrop must not paint a background (preserves user's terminal theme)",
+		);
 	});
 
 	it("does not dim when backdrop is false/absent", () => {
@@ -60,10 +179,11 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 20, 20, 2);
 
-		// Lines not covered by overlay should remain undimmed
-		const secondLine = result.find((l) => l.includes("second line"));
-		assert.ok(secondLine, "should have a line containing 'second line'");
-		assert.ok(!secondLine.includes("\x1b[2m"), "base line should not be dimmed");
+		const line = result.find((l) => stripAnsi(l).includes("second line"));
+		assert.ok(line, "should have a line containing 'second line'");
+
+		const state = sgrStateAtGlyph(line, "second line");
+		assert.equal(state.dim, false, "base line should not be dimmed when no backdrop");
 	});
 
 	it("overlay content renders on top of dimmed background", () => {
@@ -76,7 +196,10 @@ describe("compositeOverlays — backdrop", () => {
 
 		const result = compositeOverlays(base, [overlay], 10, 10, 1);
 
-		// The first line should contain the overlay text
-		assert.ok(result[0].includes("XX"), "overlay text should be composited");
+		// Find the row that (after stripping styling) contains the overlay
+		// text. We don't use positional `result[0]` so the test survives if
+		// the row ordering changes.
+		const overlayRow = result.find((l) => stripAnsi(l).includes("XX"));
+		assert.ok(overlayRow, "overlay text should be composited into some rendered row");
 	});
 });

package/packages/pi-tui/src/__tests__/stdin-buffer.test.ts

@@ -1,29 +1,49 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
-import { setTimeout as delay } from "node:timers/promises";
 
 import { StdinBuffer } from "../stdin-buffer.js";
 
+// These tests use node:test's mock.timers to advance virtual time.
+// They previously relied on wall-clock delays (delay(20), delay(150))
+// racing the OS scheduler. On Windows the default setTimeout resolution is
+// ~15.6ms, so a real-time delay of 20ms sometimes fired only one of two
+// pending timers — hence the flake referenced in issue #4795.
+//
+// By mocking setTimeout/clearTimeout we control exactly when the buffer's
+// sequence timeout and stale timeout fire, eliminating scheduler-induced
+// flake and making the tests deterministic on every platform.
+
 describe("StdinBuffer", () => {
-	it("flushes a lone Escape keypress", async () => {
+	it("flushes a lone Escape keypress after the sequence timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b");
-		await delay(20);
+
+		// Before the timeout fires the lone ESC is still buffered.
+		assert.deepEqual(received, []);
+		assert.equal(buffer.getBuffer(), "\x1b");
+
+		// Advance past the sequence timeout.
+		t.mock.timers.tick(5);
 
 		assert.deepEqual(received, ["\x1b"]);
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("keeps split CSI focus and mouse sequences buffered until completion", async () => {
+	it("keeps split CSI focus and mouse sequences buffered until completion", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(20);
+		// Even after the normal timeout elapses, an incomplete CSI prefix must
+		// remain buffered (not emitted as literal text) so split escape
+		// sequences stay intact.
+		t.mock.timers.tick(5);
 		assert.deepEqual(received, []);
 		assert.equal(buffer.getBuffer(), "\x1b[");
 
@@ -32,7 +52,7 @@ describe("StdinBuffer", () => {
 		assert.equal(buffer.getBuffer(), "");
 
 		buffer.process("\x1b[<35;20;");
-		await delay(20);
+		t.mock.timers.tick(5);
 		assert.deepEqual(received, ["\x1b[I"]);
 		assert.equal(buffer.getBuffer(), "\x1b[<35;20;");
 
@@ -41,25 +61,36 @@ describe("StdinBuffer", () => {
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("flushes a stale incomplete escape prefix after the stale timeout", async () => {
-		const buffer = new StdinBuffer({ timeout: 5, staleTimeout: 10 });
+	it("flushes a stale incomplete escape prefix after the stale timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
+		const buffer = new StdinBuffer({ timeout: 20, staleTimeout: 40 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(50);
+
+		// Sequence timeout: keeps the incomplete prefix buffered and starts
+		// the stale timer.
+		t.mock.timers.tick(20);
+		assert.deepEqual(received, []);
+		assert.equal(buffer.getBuffer(), "\x1b[");
+
+		// Stale timer fires — prefix is emitted as-is.
+		t.mock.timers.tick(40);
 
 		assert.deepEqual(received, ["\x1b["]);
 		assert.equal(buffer.getBuffer(), "");
 	});
 
-	it("still allows an incomplete escape prefix to complete before the stale timeout", async () => {
+	it("still allows an incomplete escape prefix to complete before the stale timeout", (t) => {
+		t.mock.timers.enable({ apis: ["setTimeout"] });
 		const buffer = new StdinBuffer({ timeout: 5, staleTimeout: 30 });
 		const received: string[] = [];
 		buffer.on("data", (sequence) => received.push(sequence));
 
 		buffer.process("\x1b[");
-		await delay(10);
+		// Advance past the sequence timeout (but not the stale timeout).
+		t.mock.timers.tick(10);
 		buffer.process("I");
 
 		assert.deepEqual(received, ["\x1b[I"]);

package/packages/pi-tui/src/__tests__/tui.test.ts

@@ -25,43 +25,24 @@ function makeTerminal(): Terminal {
 	};
 }
 
-describe("TUI clearOnShrink debounce", () => {
-	it("defers full redraw on first shrink and commits on second", () => {
-		const tui = new TUI(makeTerminal());
-		const anyTui = tui as any;
-
-		// Enable clearOnShrink and simulate prior rendering state
-		anyTui.clearOnShrink = true;
-		anyTui.maxLinesRendered = 10;
-		anyTui._shrinkDebounceActive = false;
-
-		// Simulate a shrink: newLines has fewer lines than maxLinesRendered
-		// First shrink should set debounce flag but NOT reset maxLinesRendered
-		anyTui._shrinkDebounceActive = false;
-
-		// Verify the flag exists and is initially false
-		assert.equal(anyTui._shrinkDebounceActive, false);
-
-		// After setting it to true (simulating first shrink detection),
-		// maxLinesRendered should remain at the old value so the condition
-		// triggers again on the next render
-		anyTui._shrinkDebounceActive = true;
-		assert.equal(anyTui.maxLinesRendered, 10, "maxLinesRendered must not change during deferred shrink");
-	});
-
-	it("resets debounce flag when content grows back", () => {
-		const tui = new TUI(makeTerminal());
-		const anyTui = tui as any;
-
-		anyTui.clearOnShrink = true;
-		anyTui._shrinkDebounceActive = true;
-
-		// Simulating the else branch: content grew back or no shrink
-		// The code sets _shrinkDebounceActive = false in the else branch
-		anyTui._shrinkDebounceActive = false;
-		assert.equal(anyTui._shrinkDebounceActive, false);
-	});
-});
+// TUI clearOnShrink debounce — tests removed in #4794 (ref #4784).
+//
+// The previous tests mutated private fields (`_shrinkDebounceActive`,
+// `maxLinesRendered`) and then asserted the values they just wrote —
+// pure tautologies that never exercised the real debounce path in
+// `renderNow()` (tui.ts:734-754). A regression that narrowed the
+// condition, reversed the flag flip, or dropped the "keep
+// maxLinesRendered" rule would have passed all of them.
+//
+// A proper test would (a) render a component that produces N lines to
+// establish `maxLinesRendered`, (b) swap in a component that produces
+// N-k lines to trigger the shrink branch, and (c) observe terminal
+// writes to confirm the debounce defers/commits the full redraw on the
+// expected render call.
+//
+// That test setup requires exposing enough of the render path (or
+// extracting the debounce decision into a pure helper) — deferred to a
+// separate refactor PR rather than shipping a tautology. See #4794.
 
 describe("TUI", () => {
 	it("does not swallow a bare Escape keypress while waiting for the cell-size response", () => {

package/packages/pi-tui/src/components/__tests__/input.test.ts

@@ -37,11 +37,27 @@ describe("Input", () => {
 		const input = new Input();
 		input.secure = true;
 		input.focused = true;
-		input.handleInput("secret123");
+		const SECRET = "secret123";
+		input.handleInput(SECRET);
 
 		const line = input.render(40)[0] ?? "";
-		assert.ok(!line.includes("secret123"), "rendered line must not expose raw secret text");
-		assert.ok(line.includes("*********"), "rendered line should include masked characters");
+		// Previous assertion was `line.includes("*********")` — a literal
+		// 9-star string that silently goes stale if SECRET is renamed to
+		// a different length (#4796). Match any run of asterisks and
+		// assert its length covers the secret.
+		assert.ok(
+			!line.includes(SECRET),
+			"rendered line must not expose raw secret text",
+		);
+		const maskMatch = line.match(/\*+/);
+		assert.ok(
+			maskMatch,
+			`rendered line must include masked characters, got: ${JSON.stringify(line)}`,
+		);
+		assert.ok(
+			maskMatch[0].length >= SECRET.length,
+			`mask must cover at least the secret length (${SECRET.length}), got ${maskMatch[0].length} asterisks`,
+		);
 	});
 
 	it("maps kitty keypad digits to text instead of inserting private-use glyphs", () => {