gsd-pi 2.77.0-dev.538325aea → 2.77.0

package/src/resources/extensions/gsd/tests/auto-recovery.test.ts

@@ -706,79 +706,6 @@ test("verifyExpectedArtifact complete-milestone passes with impl files (#1703)",
   }
 });
 
-test("verifyExpectedArtifact complete-milestone fails when DB milestone is not complete (#4658)", () => {
-  const base = makeGitBase();
-  try {
-    execFileSync("git", ["checkout", "-b", "feat/ms-db-active"], { cwd: base, stdio: "ignore" });
-    mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-    writeFileSync(join(base, ".gsd", "milestones", "M001", "M001-SUMMARY.md"), "# Milestone Summary\nverification FAILED — not complete.");
-    mkdirSync(join(base, "src"), { recursive: true });
-    writeFileSync(join(base, "src", "app.ts"), "console.log('hello');");
-    execFileSync("git", ["add", "."], { cwd: base, stdio: "ignore" });
-    execFileSync("git", ["commit", "-m", "feat: implementation with failed summary"], { cwd: base, stdio: "ignore" });
-
-    openDatabase(join(base, ".gsd", "gsd.db"));
-    insertMilestone({ id: "M001", title: "Milestone One", status: "active" });
-
-    const result = verifyExpectedArtifact("complete-milestone", "M001", base);
-    assert.equal(result, false, "complete-milestone must fail when DB status is not complete");
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("verifyExpectedArtifact complete-milestone passes when DB milestone is complete (#4658)", () => {
-  const base = makeGitBase();
-  try {
-    execFileSync("git", ["checkout", "-b", "feat/ms-db-complete"], { cwd: base, stdio: "ignore" });
-    mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-    writeFileSync(join(base, ".gsd", "milestones", "M001", "M001-SUMMARY.md"), "# Milestone Summary\nDone.");
-    mkdirSync(join(base, "src"), { recursive: true });
-    writeFileSync(join(base, "src", "app.ts"), "console.log('hello');");
-    execFileSync("git", ["add", "."], { cwd: base, stdio: "ignore" });
-    execFileSync("git", ["commit", "-m", "feat: implementation complete"], { cwd: base, stdio: "ignore" });
-
-    openDatabase(join(base, ".gsd", "gsd.db"));
-    insertMilestone({ id: "M001", title: "Milestone One", status: "complete" });
-
-    const result = verifyExpectedArtifact("complete-milestone", "M001", base);
-    assert.equal(result, true, "complete-milestone should pass when DB status is complete");
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("verifyExpectedArtifact complete-milestone tolerates transient DB lag when SUMMARY is canonical success (#4658)", () => {
-  const base = makeGitBase();
-  try {
-    execFileSync("git", ["checkout", "-b", "feat/ms-db-lag-success"], { cwd: base, stdio: "ignore" });
-    mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-    writeFileSync(
-      join(base, ".gsd", "milestones", "M001", "M001-SUMMARY.md"),
-      [
-        "---",
-        "id: M001",
-        "status: complete",
-        "---",
-        "",
-        "# M001: Success",
-      ].join("\n"),
-    );
-    mkdirSync(join(base, "src"), { recursive: true });
-    writeFileSync(join(base, "src", "app.ts"), "console.log('hello');");
-    execFileSync("git", ["add", "."], { cwd: base, stdio: "ignore" });
-    execFileSync("git", ["commit", "-m", "feat: implementation with stale db"], { cwd: base, stdio: "ignore" });
-
-    openDatabase(join(base, ".gsd", "gsd.db"));
-    insertMilestone({ id: "M001", title: "Milestone One", status: "active" });
-
-    const result = verifyExpectedArtifact("complete-milestone", "M001", base);
-    assert.equal(result, true, "canonical success SUMMARY should pass verification during transient DB lag");
-  } finally {
-    cleanup(base);
-  }
-});
-
 test("verifyExpectedArtifact checks pending gate-evaluate artifacts without ESM require failures", () => {
   const base = makeTmpProject();
 

package/src/resources/extensions/gsd/tests/complete-milestone-false-merge.test.ts

@@ -105,21 +105,6 @@ test("#4175: postUnitPreVerification pauses complete-milestone after retries exh
   );
 });
 
-test("#4658: postUnitPreVerification waits briefly for DB-close on complete-milestone before retrying", () => {
-  assert.ok(
-    /async function waitForMilestoneDbClose/.test(postUnitSrc),
-    "auto-post-unit should define a DB settle helper for complete-milestone",
-  );
-  assert.ok(
-    /setTimeout\(resolve,\s*COMPLETE_MILESTONE_DB_SETTLE_POLL_MS\)/.test(postUnitSrc),
-    "DB settle helper should poll with a bounded timeout window",
-  );
-  assert.ok(
-    /s\.currentUnit\.type\s*===\s*"complete-milestone"[\s\S]*waitForMilestoneDbClose/.test(postUnitSrc),
-    "complete-milestone path should invoke DB settle check before retry flow",
-  );
-});
-
 test("#4175: recoverTimedOutUnit pauses complete-milestone instead of writing a blocker placeholder", () => {
   // The complete-milestone pause branch must sit immediately above the
   // "retries exhausted" writeBlockerPlaceholder call so a failed

package/src/resources/extensions/gsd/tests/dispatch-complete-milestone-guard.test.ts

@@ -47,21 +47,21 @@ describe("completing-milestone dispatch guard (#4324)", () => {
     assert.ok(dispatchIdx > -1, "complete-milestone dispatch should exist after the skip guard");
   });
 
-  test("classifies SUMMARY outcome and conditionally reconciles DB (#4658)", () => {
+  test("imports updateMilestoneStatus for DB reconciliation", () => {
+    assert.match(source, /import\s*\{[^}]*updateMilestoneStatus[^}]*\}\s*from\s*["']\.\/gsd-db/);
+  });
+
+  test("reconciles DB when SUMMARY exists on disk but DB is out of sync", () => {
     const phaseCheck = source.indexOf('phase !== "completing-milestone"');
     // The SUMMARY-exists reconciliation guard must appear in this rule
     const summaryGuard = source.indexOf('resolveMilestoneFile(basePath, mid, "SUMMARY")', phaseCheck);
     assert.ok(summaryGuard > -1, "SUMMARY file check should exist in the completing-milestone rule");
 
-    const classifyCall = source.indexOf("classifyMilestoneSummaryContent", summaryGuard);
-    assert.ok(classifyCall > -1, "SUMMARY mismatch handling should classify summary content");
-
     const reconcileCall = source.indexOf('updateMilestoneStatus(mid, "complete"', summaryGuard);
-    assert.ok(reconcileCall > -1, "successful SUMMARY should reconcile DB to complete");
+    assert.ok(reconcileCall > -1, "updateMilestoneStatus reconciliation should follow the SUMMARY check");
 
-    const stopAction = source.indexOf('action: "stop"', summaryGuard);
-    assert.ok(stopAction > -1, "SUMMARY mismatch should return stop action");
-    const warningLevel = source.indexOf('level: "warning"', summaryGuard);
-    assert.ok(warningLevel > -1, "SUMMARY mismatch should be warning-level stop (pauses auto-mode)");
+    // Reconciliation must happen before the dispatch action
+    const dispatchIdx = source.indexOf('unitType: "complete-milestone"', reconcileCall);
+    assert.ok(dispatchIdx > -1, "reconciliation should appear before the dispatch action");
   });
 });

package/src/resources/extensions/gsd/tests/integration/worktree-e2e.test.ts

@@ -200,17 +200,6 @@ Test
 
 ## Boundary Map
 _None_
-`);
-      writeFileSync(join(msDir, "M001-SUMMARY.md"), `---
-id: M001
-title: "Test Milestone"
-status: complete
-completed_at: 2026-04-18T00:00:00Z
----
-
-# M001: Test Milestone
-
-Completed.
 `);
       run("git add -A", repo);
       run("git commit -m \"add milestone\"", repo);

package/src/resources/extensions/gsd/tests/milestone-status-authoritative.test.ts

@@ -75,7 +75,7 @@ test("getMilestoneStatus returns 'pending' for authoritative 'pending' even when
   assert.equal(getMilestoneStatus(milestone, {}), "pending");
 });
 
-test("getMilestoneStatus preserves authoritative 'parked' item status", () => {
+test("getMilestoneStatus maps 'parked' to 'pending' item status", () => {
   const milestone = makeMilestone({
     id: "M004",
     status: "parked",
@@ -83,8 +83,8 @@ test("getMilestoneStatus preserves authoritative 'parked' item status", () => {
       { id: "S01", title: "Slice 1", done: true, tasks: [] },
     ],
   });
-  // Parked milestones should retain a distinct parked status in the UI
-  assert.equal(getMilestoneStatus(milestone, {}), "parked");
+  // Parked milestones should render as pending in the UI
+  assert.equal(getMilestoneStatus(milestone, {}), "pending");
 });
 
 test("getMilestoneStatus falls back to heuristic when no authoritative status", () => {

package/src/resources/extensions/gsd/tests/validate-milestone.test.ts

@@ -13,7 +13,7 @@ import { buildCompleteMilestonePrompt, buildValidateMilestonePrompt } from "../a
 import type { GSDState } from "../types.ts";
 import { clearPathCache } from "../paths.ts";
 import { clearParseCache } from "../files.ts";
-import { closeDatabase, insertMilestone, insertSlice, openDatabase, getMilestone } from "../gsd-db.ts";
+import { closeDatabase, insertMilestone, insertSlice, openDatabase } from "../gsd-db.ts";
 
 // ─── Helpers ──────────────────────────────────────────────────────────────
 
@@ -257,8 +257,8 @@ Test
 `);
     openTestDb(base);
     insertMilestone({ id: "M001", title: "Test Milestone", status: "active" });
-    insertSlice({ id: "S01", milestoneId: "M001", title: "First slice", status: "complete", depends: [] });
-    insertSlice({ id: "S02", milestoneId: "M001", title: "Skipped slice", status: "skipped", depends: [] });
+    insertSlice({ id: "S01", milestoneId: "M001", title: "First slice", status: "complete", depends: [], sequence: 1 });
+    insertSlice({ id: "S02", milestoneId: "M001", title: "Skipped slice", status: "skipped", depends: [], sequence: 2 });
     writeSliceSummary(base, "M001", "S01", "# S01 Summary\nDelivered.");
 
     const prompt = await buildCompleteMilestonePrompt("M001", "Test Milestone", base);
@@ -296,8 +296,8 @@ Test
 `);
     openTestDb(base);
     insertMilestone({ id: "M001", title: "Test Milestone", status: "active" });
-    insertSlice({ id: "S01", milestoneId: "M001", title: "First slice", status: "complete", depends: [] });
-    insertSlice({ id: "S02", milestoneId: "M001", title: "Skipped slice", status: "skipped", depends: [] });
+    insertSlice({ id: "S01", milestoneId: "M001", title: "First slice", status: "complete", depends: [], sequence: 1 });
+    insertSlice({ id: "S02", milestoneId: "M001", title: "Skipped slice", status: "skipped", depends: [], sequence: 2 });
     writeSliceSummary(base, "M001", "S01", "# S01 Summary\nDelivered.");
     writeSliceAssessment(base, "M001", "S01", "---\nverdict: PASS\n---\n# Assessment\nEvidence captured.");
 
@@ -385,128 +385,6 @@ test("dispatch rule skips when skip_milestone_validation preference is set", asy
   }
 });
 
-test("dispatch rule fails closed for failure-path SUMMARY when DB milestone is not complete (#4658)", async () => {
-  const state: GSDState = {
-    activeMilestone: { id: "M001", title: "Test" },
-    activeSlice: null,
-    activeTask: null,
-    phase: "completing-milestone",
-    recentDecisions: [],
-    blockers: [],
-    nextAction: "Complete milestone M001.",
-    registry: [{ id: "M001", title: "Test", status: "active" }],
-    progress: { milestones: { done: 0, total: 1 } },
-  };
-
-  const base = makeTmpBase();
-  try {
-    openTestDb(base);
-    insertMilestone({ id: "M001", title: "Test", status: "active" });
-    writeMilestoneSummary(base, "M001", "# Milestone Summary\nverification FAILED — not complete.");
-
-    const ctx: DispatchContext = {
-      basePath: base,
-      mid: "M001",
-      midTitle: "Test",
-      state,
-      prefs: undefined,
-    };
-    const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "stop");
-    if (result.action === "stop") {
-      assert.equal(result.level, "warning");
-      assert.match(result.reason, /failure-path SUMMARY/i);
-    }
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("dispatch rule reconciles DB for successful stale SUMMARY (#4658)", async () => {
-  const state: GSDState = {
-    activeMilestone: { id: "M001", title: "Test" },
-    activeSlice: null,
-    activeTask: null,
-    phase: "completing-milestone",
-    recentDecisions: [],
-    blockers: [],
-    nextAction: "Complete milestone M001.",
-    registry: [{ id: "M001", title: "Test", status: "active" }],
-    progress: { milestones: { done: 0, total: 1 } },
-  };
-
-  const base = makeTmpBase();
-  try {
-    openTestDb(base);
-    insertMilestone({ id: "M001", title: "Test", status: "active" });
-    writeMilestoneSummary(
-      base,
-      "M001",
-      [
-        "---",
-        "id: M001",
-        "status: complete",
-        "---",
-        "",
-        "# M001: Test",
-        "",
-        "**Complete.**",
-      ].join("\n"),
-    );
-
-    const ctx: DispatchContext = {
-      basePath: base,
-      mid: "M001",
-      midTitle: "Test",
-      state,
-      prefs: undefined,
-    };
-    const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "skip");
-    const milestone = getMilestone("M001");
-    assert.equal(milestone?.status, "complete");
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("dispatch rule fails closed for ambiguous stale SUMMARY (#4658)", async () => {
-  const state: GSDState = {
-    activeMilestone: { id: "M001", title: "Test" },
-    activeSlice: null,
-    activeTask: null,
-    phase: "completing-milestone",
-    recentDecisions: [],
-    blockers: [],
-    nextAction: "Complete milestone M001.",
-    registry: [{ id: "M001", title: "Test", status: "active" }],
-    progress: { milestones: { done: 0, total: 1 } },
-  };
-
-  const base = makeTmpBase();
-  try {
-    openTestDb(base);
-    insertMilestone({ id: "M001", title: "Test", status: "active" });
-    writeMilestoneSummary(base, "M001", "# M001 Summary\nSome notes without completion metadata.");
-
-    const ctx: DispatchContext = {
-      basePath: base,
-      mid: "M001",
-      midTitle: "Test",
-      state,
-      prefs: undefined,
-    };
-    const result = await resolveDispatch(ctx);
-    assert.equal(result.action, "stop");
-    if (result.action === "stop") {
-      assert.equal(result.level, "warning");
-      assert.match(result.reason, /ambiguous SUMMARY/i);
-    }
-  } finally {
-    cleanup(base);
-  }
-});
-
 // ─── Artifact resolution & verification ───────────────────────────────────
 
 test("resolveExpectedArtifactPath returns VALIDATION path for validate-milestone", () => {

package/src/resources/extensions/mcp-client/index.ts

@@ -514,7 +514,7 @@ export default function (pi: ExtensionAPI) {
 		await closeAll();
 	});
 
-	pi.on("session_before_switch", async () => {
+	pi.on("session_switch", async () => {
 		await closeAll();
 		configCache = null;
 	});

package/src/resources/extensions/ollama/index.ts

@@ -16,8 +16,7 @@
  * Respects OLLAMA_HOST env var for non-default endpoints.
  */
 
-import { type ExtensionAPI } from "@gsd/pi-coding-agent";
-import { importExtensionModule } from "@gsd/pi-coding-agent";
+import { importExtensionModule, type ExtensionAPI } from "@gsd/pi-coding-agent";
 import * as client from "./ollama-client.js";
 import { discoverModels } from "./ollama-discovery.js";
 import { registerOllamaCommands } from "./ollama-commands.js";
@@ -74,11 +73,12 @@ async function probeAndRegister(pi: ExtensionAPI): Promise<boolean> {
 	// so the "ollama" fallback is harmless. For cloud endpoints (OLLAMA_HOST pointing
 	// to ollama.com or a remote instance), OLLAMA_API_KEY is picked up here.
 	pi.registerProvider("ollama", {
-		// authMode and isReady removed from ProviderConfig in pi 0.67.2
+		authMode: "apiKey",
 		apiKey: process.env.OLLAMA_API_KEY ?? "ollama",
 		baseUrl,
 		api: "ollama-chat",
 		streamSimple: streamOllamaChat,
+		isReady: () => true,
 		models: models.map((m) => ({
 			id: m.id,
 			name: m.name,

package/src/resources/extensions/ollama/ollama-chat-provider.ts

@@ -14,6 +14,7 @@ import {
 	type AssistantMessageEventStream,
 	type Context,
 	type ImageContent,
+	type InferenceMetrics,
 	type Message,
 	type Model,
 	type SimpleStreamOptions,
@@ -167,7 +168,7 @@ export function streamOllamaChat(
 					endBlock();
 
 					output.usage = buildUsage(chunk);
-					// inferenceMetrics removed from AssistantMessage in pi 0.67.2
+					output.inferenceMetrics = extractMetrics(chunk);
 					// Preserve "toolUse" if tool calls were processed
 					if (output.stopReason !== "toolUse") {
 						output.stopReason = mapStopReason(chunk.done_reason);
@@ -193,8 +194,7 @@ function buildRequest(
 	context: Context,
 	options?: SimpleStreamOptions,
 ): OllamaChatRequest {
-	// providerOptions removed from Model in pi 0.67.2; cast via unknown for extension data
-	const ollamaOpts = ((model as unknown as { providerOptions?: OllamaChatOptions }).providerOptions ?? {}) as OllamaChatOptions;
+	const ollamaOpts = (model.providerOptions ?? {}) as OllamaChatOptions;
 
 	const request: OllamaChatRequest = {
 		model: model.id,
@@ -388,9 +388,21 @@ function buildUsage(chunk: OllamaChatResponse): Usage {
 	};
 }
 
-// extractMetrics removed: InferenceMetrics was removed from pi-ai in pi 0.67.2
-// and inferenceMetrics was removed from AssistantMessage. Ollama perf metrics
-// (tokensPerSecond, evalDurationMs, etc.) are no longer surfaced via this path.
+function extractMetrics(chunk: OllamaChatResponse): InferenceMetrics | undefined {
+	if (!chunk.eval_duration && !chunk.total_duration) return undefined;
+
+	const evalCount = chunk.eval_count ?? 0;
+	const evalDurationNs = chunk.eval_duration ?? 0;
+	const evalDurationMs = evalDurationNs / 1e6;
+	const tokensPerSecond = evalDurationNs > 0 ? evalCount / (evalDurationNs / 1e9) : 0;
+
+	return {
+		tokensPerSecond,
+		totalDurationMs: (chunk.total_duration ?? 0) / 1e6,
+		evalDurationMs,
+		promptEvalDurationMs: (chunk.prompt_eval_duration ?? 0) / 1e6,
+	};
+}
 
 // ─── Stream lifecycle helpers ───────────────────────────────────────────────
 // Replicated from openai-shared.ts (not exported from @gsd/pi-ai)

package/src/resources/extensions/remote-questions/config.ts

@@ -55,24 +55,13 @@ function hydrateRemoteTokensFromAuth(): void {
 
   try {
     const auth = AuthStorage.create();
-    const authData = (auth as unknown as {
-      data?: Record<string, { type?: string; key?: string } | Array<{ type?: string; key?: string }>>;
-    }).data ?? {};
 
     for (const [providerId, envVar] of needed) {
       try {
-        const raw = authData[providerId];
-        const creds = Array.isArray(raw)
-          ? raw
-          : raw
-            ? [raw]
-            : [];
-        if (creds.length === 0) {
-          const fallbackCred = auth.get(providerId) as { type?: string; key?: string } | undefined;
-          if (fallbackCred) creds.push(fallbackCred);
-        }
-
-        const apiKeyCred = creds.find((c) => c.type === "api_key" && !!c.key);
+        const creds = auth.getCredentialsForProvider(providerId);
+        const apiKeyCred = creds.find((c: { type: string; key?: string }) => c.type === "api_key" && !!c.key) as
+          | { type: "api_key"; key: string }
+          | undefined;
         if (apiKeyCred?.key) {
           process.env[envVar] = apiKeyCred.key;
         }

package/src/resources/extensions/search-the-web/index.ts

@@ -5,8 +5,7 @@
  * interactive mode so startup is not blocked on the full search tool stack.
  */
 
-import { type ExtensionAPI } from "@gsd/pi-coding-agent";
-import { importExtensionModule } from "@gsd/pi-coding-agent";
+import { importExtensionModule, type ExtensionAPI } from "@gsd/pi-coding-agent";
 import { registerSearchProviderCommand } from "./command-search-provider.js";
 import { registerNativeSearchHooks } from "./native-search.js";
 

package/src/resources/extensions/shared/tests/format-utils.test.ts

@@ -11,7 +11,6 @@ import {
   centerLine,
   fitColumns,
 } from "../layout-utils.js";
-import { visibleWidth } from "@gsd/pi-tui";
 
 describe("formatDuration", () => {
   it("formats seconds", () => {
@@ -60,8 +59,8 @@ describe("joinColumns", () => {
 
   it("truncates when content overflows", () => {
     const result = joinColumns("a".repeat(20), "b".repeat(20), 30);
-    // Should be truncated to 30 visible columns (ANSI reset codes may make string length > 30)
-    assert.ok(visibleWidth(result) <= 30);
+    // Should be truncated to 30 chars
+    assert.ok(result.length <= 30);
   });
 });
 
@@ -73,8 +72,7 @@ describe("centerLine", () => {
 
   it("truncates when content exceeds width", () => {
     const result = centerLine("abcdefgh", 4);
-    // Should be truncated to 4 visible columns (ANSI reset codes may make string length > 4)
-    assert.ok(visibleWidth(result) <= 4);
+    assert.ok(result.length <= 4);
   });
 });
 

package/src/resources/extensions/universal-config/index.ts

@@ -114,7 +114,7 @@ export default function universalConfig(pi: ExtensionAPI) {
 
   // ── Invalidate cache on session switch ──────────────────────────────────
 
-  pi.on("session_before_switch", () => {
+  pi.on("session_switch", () => {
     cachedResult = null;
   });
 }