gsd-pi 2.77.0-dev.538325aea → 2.77.0

package/dist/resources/extensions/gsd/auto-dispatch.js

@@ -17,7 +17,7 @@ import { parseRoadmap } from "./parsers-legacy.js";
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { logWarning, logError } from "./workflow-logger.js";
 import { join } from "node:path";
-import { hasImplementationArtifacts, classifyMilestoneSummaryContent } from "./auto-recovery.js";
+import { hasImplementationArtifacts } from "./auto-recovery.js";
 import { buildDiscussMilestonePrompt, buildResearchMilestonePrompt, buildPlanMilestonePrompt, buildResearchSlicePrompt, buildPlanSlicePrompt, buildRefineSlicePrompt, buildExecuteTaskPrompt, buildCompleteSlicePrompt, buildCompleteMilestonePrompt, buildValidateMilestonePrompt, buildReplanSlicePrompt, buildRunUatPrompt, buildReassessRoadmapPrompt, buildRewriteDocsPrompt, buildReactiveExecutePrompt, buildGateEvaluatePrompt, buildParallelResearchSlicesPrompt, checkNeedsReassessment, checkNeedsRunUat, } from "./auto-prompts.js";
 import { resolveModelWithFallbacksForUnit } from "./preferences-models.js";
 import { resolveUokFlags } from "./uok/flags.js";
@@ -702,13 +702,22 @@ export const DISPATCH_RULES = [
                     return { action: "skip" };
                 }
             }
+            // Reconciliation guard (#4324): when the SUMMARY file already exists
+            // on disk but the DB says the milestone is not complete, the DB is
+            // out of sync (e.g. journal reset, partial merge, crash recovery).
+            // Reconcile the DB status directly instead of re-dispatching the
+            // tool, which would overwrite the richer on-disk SUMMARY with a
+            // thinner regenerated version — causing silent data loss.
             const existingSummary = resolveMilestoneFile(basePath, mid, "SUMMARY");
-            let summaryOutcome = "unknown";
             if (existingSummary && isDbAvailable()) {
-                const summaryContent = await loadFile(existingSummary);
-                if (summaryContent) {
-                    summaryOutcome = classifyMilestoneSummaryContent(summaryContent);
+                try {
+                    updateMilestoneStatus(mid, "complete", new Date().toISOString());
+                    logWarning("dispatch", `Milestone ${mid} has SUMMARY on disk but DB status was not complete — reconciled DB to complete (#4324)`);
+                }
+                catch (err) {
+                    logWarning("dispatch", `Failed to reconcile milestone ${mid} status: ${err instanceof Error ? err.message : String(err)}`);
                 }
+                return { action: "skip" };
             }
             // Safety guard (#2675): block completion when VALIDATION verdict is
             // needs-remediation. The state machine treats needs-remediation as
@@ -786,41 +795,6 @@ export const DISPATCH_RULES = [
             catch (err) { /* fall through — don't block on DB errors */
                 logWarning("dispatch", `verification class check failed: ${err instanceof Error ? err.message : String(err)}`);
             }
-            // Disk/DB mismatch handling (#4658): SUMMARY presence alone is not enough.
-            // Apply post-gate policy:
-            // - success summary: reconcile DB and skip re-dispatch
-            // - failure summary: pause/fail-closed
-            // - unknown summary: pause/fail-closed
-            if (existingSummary && isDbAvailable()) {
-                const milestone = getMilestone(mid);
-                const status = milestone?.status ?? "missing";
-                if (summaryOutcome === "success") {
-                    try {
-                        updateMilestoneStatus(mid, "complete", new Date().toISOString());
-                        logWarning("dispatch", `Milestone ${mid} SUMMARY indicates completion while DB status was "${status}" — reconciled DB to complete (#4658)`);
-                        return { action: "skip" };
-                    }
-                    catch (err) {
-                        return {
-                            action: "stop",
-                            level: "warning",
-                            reason: `Milestone ${mid} SUMMARY indicates completion but DB reconciliation failed (${err instanceof Error ? err.message : String(err)}). Auto-mode paused for manual review.`,
-                        };
-                    }
-                }
-                if (summaryOutcome === "failure") {
-                    return {
-                        action: "stop",
-                        level: "warning",
-                        reason: `Milestone ${mid} has a failure-path SUMMARY while DB status is "${status}". Auto-mode will not promote completion from failure artifacts. Re-run complete-milestone only after blockers are resolved and verification passes.`,
-                    };
-                }
-                return {
-                    action: "stop",
-                    level: "warning",
-                    reason: `Milestone ${mid} has an ambiguous SUMMARY while DB status is "${status}". Auto-mode paused instead of promoting completion from file presence alone.`,
-                };
-            }
             return {
                 action: "dispatch",
                 unitType: "complete-milestone",

package/dist/resources/extensions/gsd/auto-post-unit.js

@@ -45,23 +45,8 @@ import { ensureCodebaseMapFresh } from "./codebase-generator.js";
 import { resolveUokFlags } from "./uok/flags.js";
 import { UokGateRunner } from "./uok/gate-runner.js";
 import { writeTurnGitTransaction } from "./uok/gitops.js";
-import { isClosedStatus } from "./status-guards.js";
 /** Maximum verification retry attempts before escalating to blocker placeholder (#2653). */
 const MAX_VERIFICATION_RETRIES = 3;
-const COMPLETE_MILESTONE_DB_SETTLE_MS = 1500;
-const COMPLETE_MILESTONE_DB_SETTLE_POLL_MS = 100;
-async function waitForMilestoneDbClose(mid) {
-    const deadline = Date.now() + COMPLETE_MILESTONE_DB_SETTLE_MS;
-    while (Date.now() < deadline) {
-        if (!isDbAvailable())
-            return false;
-        const milestone = getMilestone(mid);
-        if (milestone && isClosedStatus(milestone.status))
-            return true;
-        await new Promise((resolve) => setTimeout(resolve, COMPLETE_MILESTONE_DB_SETTLE_POLL_MS));
-    }
-    return false;
-}
 /** Enqueue a sidecar item (hook, triage, or quick-task) for the main loop to
  *  drain via runUnit. Logs the enqueue event and notifies the UI. */
 function enqueueSidecar(s, ctx, entry, debugExtra, notification) {
@@ -632,25 +617,6 @@ export async function postUnitPreVerification(pctx, opts) {
             }
             // If verification failed, attempt to regenerate missing projection files
             // from DB data before giving up (e.g. research-slice produces PLAN from engine).
-            if (!triggerArtifactVerified) {
-                if (s.currentUnit.type === "complete-milestone") {
-                    try {
-                        const { milestone: mid } = parseUnitId(s.currentUnit.id);
-                        if (mid) {
-                            const settled = await waitForMilestoneDbClose(mid);
-                            if (settled) {
-                                triggerArtifactVerified = verifyExpectedArtifact(s.currentUnit.type, s.currentUnit.id, s.basePath);
-                                if (triggerArtifactVerified) {
-                                    invalidateAllCaches();
-                                }
-                            }
-                        }
-                    }
-                    catch (e) {
-                        debugLog("postUnit", { phase: "artifact-verify-settle-db", error: String(e) });
-                    }
-                }
-            }
             if (!triggerArtifactVerified) {
                 try {
                     const { milestone: mid, slice: sid } = parseUnitId(s.currentUnit.id);

package/dist/resources/extensions/gsd/auto-recovery.js

@@ -11,12 +11,10 @@ import { appendEvent } from "./workflow-events.js";
 import { atomicWriteSync } from "./atomic-write.js";
 import { clearParseCache } from "./files.js";
 import { parseRoadmap as parseLegacyRoadmap, parsePlan as parseLegacyPlan } from "./parsers-legacy.js";
-import { isDbAvailable, getTask, getSlice, getSliceTasks, getPendingGates, updateTaskStatus, updateSliceStatus, insertSlice, getMilestone } from "./gsd-db.js";
+import { isDbAvailable, getTask, getSlice, getSliceTasks, getPendingGates, updateTaskStatus, updateSliceStatus, insertSlice } from "./gsd-db.js";
 import { isValidationTerminal } from "./state.js";
 import { getErrorMessage } from "./error-utils.js";
 import { logWarning, logError } from "./workflow-logger.js";
-import { splitFrontmatter, parseFrontmatterMap } from "./files.js";
-import { isClosedStatus } from "./status-guards.js";
 import { nativeConflictFiles, nativeCommit, nativeCheckoutTheirs, nativeAddPaths, nativeMergeAbort, nativeResetHard, } from "./native-git-bridge.js";
 import { resolveSlicePath, resolveSliceFile, resolveTasksDir, resolveTaskFiles, relMilestoneFile, relSliceFile, buildSliceFileName, resolveMilestoneFile, clearPathCache, resolveGsdRootFile, } from "./paths.js";
 import { existsSync, mkdirSync, readFileSync, writeFileSync, unlinkSync, } from "node:fs";
@@ -25,30 +23,6 @@ import { dirname, join } from "node:path";
 import { resolveExpectedArtifactPath, diagnoseExpectedArtifact, } from "./auto-artifact-paths.js";
 // Re-export so existing consumers of auto-recovery.ts keep working.
 export { resolveExpectedArtifactPath, diagnoseExpectedArtifact };
-/**
- * Classify milestone summary content for recovery/dispatch decisions.
- * - success: canonical completion summary (frontmatter status is closed)
- * - failure: explicit blocker/failure markers
- * - unknown: ambiguous content
- */
-export function classifyMilestoneSummaryContent(content) {
-    const [fmLines] = splitFrontmatter(content);
-    const fm = fmLines ? parseFrontmatterMap(fmLines) : null;
-    const rawStatus = typeof fm?.status === "string" ? fm.status.trim().toLowerCase() : "";
-    if (rawStatus) {
-        if (isClosedStatus(rawStatus))
-            return "success";
-        if (["active", "pending", "blocked", "failed", "incomplete"].includes(rawStatus))
-            return "failure";
-    }
-    const failureSignal = /(?:^|\n)\s*#\s*BLOCKER\b/i.test(content)
-        || /auto-mode recovery failed/i.test(content)
-        || /verification\s+failed/i.test(content)
-        || /\bnot complete\b/i.test(content);
-    if (failureSignal)
-        return "failure";
-    return "unknown";
-}
 // ─── Artifact Resolution & Verification ───────────────────────────────────────
 /**
  * Check whether a milestone produced implementation artifacts (non-`.gsd/` files)
@@ -459,17 +433,6 @@ export function verifyExpectedArtifact(unitType, unitId, base) {
     // A milestone with only .gsd/ plan files and zero implementation code is
     // not genuinely complete — the LLM wrote plan files but skipped actual work.
     if (unitType === "complete-milestone") {
-        const summaryOutcome = classifyMilestoneSummaryContent(readFileSync(absPath, "utf-8"));
-        if (summaryOutcome === "failure")
-            return false;
-        const { milestone: mid } = parseUnitId(unitId);
-        if (mid && isDbAvailable()) {
-            const dbMilestone = getMilestone(mid);
-            if (!dbMilestone)
-                return false;
-            if (!isClosedStatus(dbMilestone.status) && summaryOutcome !== "success")
-                return false;
-        }
         if (hasImplementationArtifacts(base) === "absent")
             return false;
     }

package/dist/resources/extensions/gsd/auto-start.js

@@ -31,7 +31,6 @@ import { restoreHookState, resetHookState } from "./post-unit-hooks.js";
 import { resetProactiveHealing, setLevelChangeCallback } from "./doctor-proactive.js";
 import { snapshotSkills } from "./skill-discovery.js";
 import { isDbAvailable, getMilestone, openDatabase, getDbStatus } from "./gsd-db.js";
-import { isClosedStatus } from "./status-guards.js";
 import { debugLog, enableDebug, isDebugEnabled, getDebugLogPath, } from "./debug-logger.js";
 import { logWarning, logError } from "./workflow-logger.js";
 import { existsSync, mkdirSync, readdirSync, rmSync, statSync, unlinkSync, } from "node:fs";
@@ -312,24 +311,11 @@ export async function bootstrapAutoSession(s, ctx, pi, base, verboseMode, reques
         }
         // Invalidate caches before initial state derivation
         invalidateAllCaches();
+        // Clean stale runtime unit files for completed milestones (#887)
+        cleanStaleRuntimeUnits(gsdRoot(base), (mid) => !!resolveMilestoneFile(base, mid, "SUMMARY"));
         // Open the project-root DB before deriveState so DB-backed state
         // derivation (queue-order, task status) works on a cold start (#2841).
-        // Must happen before cleanStaleRuntimeUnits so the cleanup predicate can
-        // consult DB status and avoid clearing runtime units for milestones that
-        // only have a failure-path SUMMARY on disk (#4663).
         await openProjectDbIfPresent(base);
-        // Clean stale runtime unit files for completed milestones (#887).
-        // DB-authoritative: when DB is available, require DB status to be closed
-        // before clearing runtime units. A SUMMARY file alone is no longer
-        // trusted as proof of completion (#4663). Fall back to SUMMARY-file
-        // presence only when DB is unavailable (legacy/pre-migration).
-        cleanStaleRuntimeUnits(gsdRoot(base), (mid) => {
-            if (isDbAvailable()) {
-                const row = getMilestone(mid);
-                return !!row && isClosedStatus(row.status);
-            }
-            return !!resolveMilestoneFile(base, mid, "SUMMARY");
-        });
         // ── Orphaned milestone branch audit ──
         // Catches completed milestones whose teardown (merge + branch delete)
         // was lost due to session ending between completion and teardown.

package/dist/resources/extensions/gsd/dispatch-guard.js

@@ -2,26 +2,10 @@
 import { resolveMilestoneFile } from "./paths.js";
 import { findMilestoneIds } from "./guided-flow.js";
 import { parseUnitId } from "./unit-id.js";
-import { isDbAvailable, getMilestoneSlices, getMilestone } from "./gsd-db.js";
+import { isDbAvailable, getMilestoneSlices } from "./gsd-db.js";
 import { parseRoadmap } from "./parsers-legacy.js";
 import { isClosedStatus } from "./status-guards.js";
 import { readFileSync } from "node:fs";
-/**
- * Detect failure-path milestone SUMMARY content (#4663 sibling to #4658).
- * A failure SUMMARY must not let the dispatch guard treat an active
- * milestone as complete. The markers mirror those produced by
- * writeBlockerPlaceholder and the "verification FAILED" retry path.
- *
- * This is intentionally a minimal local detector so this fix does not
- * depend on PR #4660's `classifyMilestoneSummaryContent`. It can migrate
- * to the shared classifier once that lands.
- */
-function isFailureMilestoneSummary(content) {
-    return (/(?:^|\n)\s*#\s*BLOCKER\b/i.test(content) ||
-        /auto-mode recovery failed/i.test(content) ||
-        /verification\s+failed/i.test(content) ||
-        /\bnot complete\b/i.test(content));
-}
 const SLICE_DISPATCH_TYPES = new Set([
     "research-slice",
     "plan-slice",
@@ -55,33 +39,8 @@ export function getPriorSliceCompletionBlocker(base, _mainBranch, unitType, unit
     for (const mid of milestoneIds) {
         if (resolveMilestoneFile(base, mid, "PARKED"))
             continue;
-        // DB/SUMMARY completion check (#4663 sibling to #4658).
-        // Prior behavior treated any SUMMARY file on disk as proof of milestone
-        // completion, which is wrong when the SUMMARY is a failure-path report
-        // (verification FAILED, blocker placeholder, etc.). Resolve as follows:
-        //   1. When DB is available and status is closed → skip (authoritative).
-        //   2. When SUMMARY exists but looks like a failure/blocker report →
-        //      do not short-circuit; fall through to the slice-level check so
-        //      the guard can still block dependents of an active milestone.
-        //   3. Otherwise (SUMMARY without failure markers) → skip. Preserves
-        //      the #1716 contract where a completed milestone with unchecked
-        //      remediation slices is still treated as done.
-        const summaryPath = resolveMilestoneFile(base, mid, "SUMMARY");
-        if (isDbAvailable()) {
-            const milestoneRow = getMilestone(mid);
-            if (milestoneRow && isClosedStatus(milestoneRow.status))
-                continue;
-        }
-        if (summaryPath) {
-            let summaryContent = null;
-            try {
-                summaryContent = readFileSync(summaryPath, "utf-8");
-            }
-            catch { /* ignore */ }
-            if (!summaryContent || !isFailureMilestoneSummary(summaryContent)) {
-                continue;
-            }
-        }
+        if (resolveMilestoneFile(base, mid, "SUMMARY"))
+            continue;
         let slices = null;
         if (isDbAvailable()) {
             const rows = getMilestoneSlices(mid);

package/dist/resources/extensions/gsd/guided-flow.js

@@ -228,7 +228,7 @@ export function checkAutoStartAfterDiscuss() {
         }
     }
     pendingAutoStartMap.delete(basePath);
-    ctx.ui.notify(`Milestone ${milestoneId} ready.`, "info");
+    ctx.ui.notify(`Milestone ${milestoneId} ready.`, "success");
     startAutoDetached(ctx, pi, basePath, false, { step });
     return true;
 }

package/dist/resources/extensions/gsd/prompts/system.md

@@ -213,7 +213,6 @@ Fix the root cause, not symptoms. When applying a temporary mitigation, label it
 - State uncertainty plainly: "Not sure this handles X - testing it." No performed confidence, no hedging paragraphs.
 - All user-visible narration must be grammatical English. Do not emit compressed planner notes like "Need inspect X" or "Maybe read Y first". If it would look acceptable in a commit comment or standup note, it's acceptable here.
 - When debugging, stay curious. Problems are puzzles. Say what's interesting about the failure before reaching for fixes.
-- After completing a task, give a brief completion summary and present 2-4 contextual next-step options as a numbered list (the last option is always "Other"). This reduces cognitive load by letting the user pick rather than formulate what's next. Omit the numbered list when the response must follow a strict output format (JSON, patches, commit messages, structured data).
 
 Good narration: "Three existing handlers follow a middleware pattern - using that instead of a custom wrapper."
 Good narration: "Tests pass. Running slice-level verification."

package/dist/resources/extensions/mcp-client/index.js

@@ -398,7 +398,7 @@ export default function (pi) {
     pi.on("session_shutdown", async () => {
         await closeAll();
     });
-    pi.on("session_before_switch", async () => {
+    pi.on("session_switch", async () => {
         await closeAll();
         configCache = null;
     });

package/dist/resources/extensions/ollama/index.js

@@ -63,11 +63,12 @@ async function probeAndRegister(pi) {
     // so the "ollama" fallback is harmless. For cloud endpoints (OLLAMA_HOST pointing
     // to ollama.com or a remote instance), OLLAMA_API_KEY is picked up here.
     pi.registerProvider("ollama", {
-        // authMode and isReady removed from ProviderConfig in pi 0.67.2
+        authMode: "apiKey",
         apiKey: process.env.OLLAMA_API_KEY ?? "ollama",
         baseUrl,
         api: "ollama-chat",
         streamSimple: streamOllamaChat,
+        isReady: () => true,
         models: models.map((m) => ({
             id: m.id,
             name: m.name,

package/dist/resources/extensions/ollama/ollama-chat-provider.js

@@ -126,7 +126,7 @@ export function streamOllamaChat(model, context, options) {
                         processChunks(thinkParser.flush());
                     endBlock();
                     output.usage = buildUsage(chunk);
-                    // inferenceMetrics removed from AssistantMessage in pi 0.67.2
+                    output.inferenceMetrics = extractMetrics(chunk);
                     // Preserve "toolUse" if tool calls were processed
                     if (output.stopReason !== "toolUse") {
                         output.stopReason = mapStopReason(chunk.done_reason);
@@ -145,7 +145,6 @@ export function streamOllamaChat(model, context, options) {
 }
 // ─── Request building ───────────────────────────────────────────────────────
 function buildRequest(model, context, options) {
-    // providerOptions removed from Model in pi 0.67.2; cast via unknown for extension data
     const ollamaOpts = (model.providerOptions ?? {});
     const request = {
         model: model.id,
@@ -320,9 +319,20 @@ function buildUsage(chunk) {
         cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 },
     };
 }
-// extractMetrics removed: InferenceMetrics was removed from pi-ai in pi 0.67.2
-// and inferenceMetrics was removed from AssistantMessage. Ollama perf metrics
-// (tokensPerSecond, evalDurationMs, etc.) are no longer surfaced via this path.
+function extractMetrics(chunk) {
+    if (!chunk.eval_duration && !chunk.total_duration)
+        return undefined;
+    const evalCount = chunk.eval_count ?? 0;
+    const evalDurationNs = chunk.eval_duration ?? 0;
+    const evalDurationMs = evalDurationNs / 1e6;
+    const tokensPerSecond = evalDurationNs > 0 ? evalCount / (evalDurationNs / 1e9) : 0;
+    return {
+        tokensPerSecond,
+        totalDurationMs: (chunk.total_duration ?? 0) / 1e6,
+        evalDurationMs,
+        promptEvalDurationMs: (chunk.prompt_eval_duration ?? 0) / 1e6,
+    };
+}
 // ─── Stream lifecycle helpers ───────────────────────────────────────────────
 // Replicated from openai-shared.ts (not exported from @gsd/pi-ai)
 function buildInitialOutput(model) {

package/dist/resources/extensions/remote-questions/config.js

@@ -40,20 +40,9 @@ function hydrateRemoteTokensFromAuth() {
         return;
     try {
         const auth = AuthStorage.create();
-        const authData = auth.data ?? {};
         for (const [providerId, envVar] of needed) {
             try {
-                const raw = authData[providerId];
-                const creds = Array.isArray(raw)
-                    ? raw
-                    : raw
-                        ? [raw]
-                        : [];
-                if (creds.length === 0) {
-                    const fallbackCred = auth.get(providerId);
-                    if (fallbackCred)
-                        creds.push(fallbackCred);
-                }
+                const creds = auth.getCredentialsForProvider(providerId);
                 const apiKeyCred = creds.find((c) => c.type === "api_key" && !!c.key);
                 if (apiKeyCred?.key) {
                     process.env[envVar] = apiKeyCred.key;

package/dist/resources/extensions/universal-config/index.js

@@ -93,7 +93,7 @@ export default function universalConfig(pi) {
         },
     });
     // ── Invalidate cache on session switch ──────────────────────────────────
-    pi.on("session_before_switch", () => {
+    pi.on("session_switch", () => {
         cachedResult = null;
     });
 }

package/dist/security-overrides.d.ts

@@ -7,8 +7,5 @@
  *
  * Precedence: env var > settings.json > built-in defaults
  */
-import type { SettingsManager } from '@gsd/pi-coding-agent';
-export declare const SAFE_COMMAND_PREFIXES: readonly string[];
-export declare function setAllowedCommandPrefixes(prefixes: string[]): void;
-export declare function getAllowedCommandPrefixes(): readonly string[];
+import { type SettingsManager } from '@gsd/pi-coding-agent';
 export declare function applySecurityOverrides(settingsManager: SettingsManager): void;

package/dist/security-overrides.js

@@ -7,22 +7,9 @@
  *
  * Precedence: env var > settings.json > built-in defaults
  */
+import { setAllowedCommandPrefixes } from '@gsd/pi-coding-agent';
 import { setFetchAllowedUrls } from './resources/extensions/search-the-web/url-utils.js';
-// ---------------------------------------------------------------------------
-// GSD-owned command prefix allowlist state
-// (setAllowedCommandPrefixes / getAllowedCommandPrefixes were removed from
-//  pi-coding-agent's SettingsManager in 0.67.2 — GSD owns this state now)
-// ---------------------------------------------------------------------------
-export const SAFE_COMMAND_PREFIXES = ['npm', 'npx', 'yarn', 'pnpm', 'node'];
-let _allowedCommandPrefixes = [...SAFE_COMMAND_PREFIXES];
-export function setAllowedCommandPrefixes(prefixes) {
-    _allowedCommandPrefixes = prefixes;
-}
-export function getAllowedCommandPrefixes() {
-    return _allowedCommandPrefixes;
-}
 export function applySecurityOverrides(settingsManager) {
-    const sm = settingsManager;
     // --- Command prefix allowlist ---
     const envPrefixes = process.env.GSD_ALLOWED_COMMAND_PREFIXES;
     if (envPrefixes) {
@@ -32,7 +19,7 @@ export function applySecurityOverrides(settingsManager) {
         }
     }
     else {
-        const settingsPrefixes = sm.getAllowedCommandPrefixes?.();
+        const settingsPrefixes = settingsManager.getAllowedCommandPrefixes();
         if (settingsPrefixes && settingsPrefixes.length > 0) {
             setAllowedCommandPrefixes(settingsPrefixes);
         }
@@ -46,7 +33,7 @@ export function applySecurityOverrides(settingsManager) {
         }
     }
     else {
-        const settingsUrls = sm.getFetchAllowedUrls?.();
+        const settingsUrls = settingsManager.getFetchAllowedUrls();
         if (settingsUrls && settingsUrls.length > 0) {
             setFetchAllowedUrls(settingsUrls);
         }