gsd-pi 2.50.0-dev.d210a87 → 2.50.0

package/src/resources/extensions/gsd/tests/dist-redirect.mjs

@@ -7,28 +7,17 @@ const require = createRequire(import.meta.url);
 const ROOT = new URL("../../../../../", import.meta.url);
 
 export function resolve(specifier, context, nextResolve) {
-  // 1. Redirect all workspace package bare imports to source.
-  //    CI portability runs don't build any packages/ dist artifacts, so every
-  //    @gsd/* specifier (including transitive ones pulled in by pi-coding-agent
-  //    source itself) must resolve to the TypeScript source entrypoint.
+  // 1. Direct redirects to dist/ for specific packages
   if (specifier === "../../packages/pi-coding-agent/src/index.js") {
-    specifier = new URL("packages/pi-coding-agent/src/index.ts", ROOT).href;
-  } else if (specifier === "@gsd/pi-coding-agent") {
-    specifier = new URL("packages/pi-coding-agent/src/index.ts", ROOT).href;
+    specifier = new URL("packages/pi-coding-agent/dist/index.js", ROOT).href;
   } else if (specifier === "@gsd/pi-ai/oauth") {
-    specifier = new URL("packages/pi-ai/src/utils/oauth/index.ts", ROOT).href;
+    specifier = new URL("packages/pi-ai/dist/utils/oauth/index.js", ROOT).href;
   } else if (specifier === "@gsd/pi-ai") {
-    specifier = new URL("packages/pi-ai/src/index.ts", ROOT).href;
+    specifier = new URL("packages/pi-ai/dist/index.js", ROOT).href;
   } else if (specifier === "@gsd/pi-agent-core") {
-    specifier = new URL("packages/pi-agent-core/src/index.ts", ROOT).href;
+    specifier = new URL("packages/pi-agent-core/dist/index.js", ROOT).href;
   } else if (specifier === "@gsd/pi-tui") {
-    specifier = new URL("packages/pi-tui/src/index.ts", ROOT).href;
-  } else if (specifier === "@gsd/native") {
-    specifier = new URL("packages/native/src/index.ts", ROOT).href;
-  } else if (specifier.startsWith("@gsd/native/")) {
-    // Sub-path imports like @gsd/native/fd, @gsd/native/text, etc.
-    const subpath = specifier.slice("@gsd/native/".length);
-    specifier = new URL(`packages/native/src/${subpath}/index.ts`, ROOT).href;
+    specifier = new URL("packages/pi-tui/dist/index.js", ROOT).href;
   }
   // 2. Redirect packages/*/dist/ → packages/*/src/ with .js→.ts for strip-types
   //    Also handles local imports — skip rewrite for dist/ paths that are real compiled artifacts.
@@ -65,15 +54,9 @@ export function resolve(specifier, context, nextResolve) {
 }
 
 export function load(url, context, nextLoad) {
-  // Node's --experimental-strip-types handles plain .ts but not .tsx and not
-  // all TypeScript syntax used by workspace packages (parameter properties,
-  // decorators, etc.). Transpile all workspace package source files and .tsx
-  // files through TypeScript's transpileModule to avoid those crashes.
-  const shouldTranspileWithTypeScript =
-    url.endsWith('.tsx') ||
-    (url.endsWith('.ts') && url.includes('/packages/') && url.includes('/src/'));
-
-  if (shouldTranspileWithTypeScript) {
+  // Node's --experimental-strip-types handles .ts but not .tsx (which may contain JSX).
+  // Use TypeScript to transpile .tsx → JS with react-jsx transform, then serve as module.
+  if (url.endsWith('.tsx')) {
     const ts = require('typescript');
     const source = readFileSync(fileURLToPath(url), 'utf-8');
     const { outputText } = ts.transpileModule(source, {
@@ -83,8 +66,6 @@ export function load(url, context, nextLoad) {
         module: ts.ModuleKind.ESNext,
         target: ts.ScriptTarget.ESNext,
         esModuleInterop: true,
-        experimentalDecorators: true,
-        emitDecoratorMetadata: true,
       },
     });
     return { format: 'module', source: outputText, shortCircuit: true };

package/src/resources/extensions/gsd/tests/idle-recovery.test.ts

@@ -294,66 +294,3 @@ test('verifyExpectedArtifact: hook types always return true', () => {
   }
 });
 
-
-test('writeBlockerPlaceholder: updates DB task status for execute-task (#2531)', async () => {
-  const base = createFixtureBase();
-  try {
-    const { openDatabase, closeDatabase, insertMilestone, insertSlice, insertTask, getTask, isDbAvailable } =
-      await import("../gsd-db.ts");
-
-    const dbPath = join(base, ".gsd", "gsd.db");
-    // Create the tasks directory (required for artifact path resolution)
-    mkdirSync(join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks"), { recursive: true });
-
-    openDatabase(dbPath);
-    try {
-      insertMilestone({ id: "M001", title: "Test", status: "active" });
-      insertSlice({ id: "S01", milestoneId: "M001", title: "Slice", status: "active" });
-      insertTask({ id: "T01", sliceId: "S01", milestoneId: "M001", title: "Task", status: "pending" });
-
-      // Before fix: writeBlockerPlaceholder wrote the file but left DB as "pending"
-      writeBlockerPlaceholder("execute-task", "M001/S01/T01", base, "idle recovery exhausted");
-
-      const task = getTask("M001", "S01", "T01");
-      assert.equal(task?.status, "complete",
-        "writeBlockerPlaceholder must update DB task status to 'complete' so verifyExpectedArtifact passes");
-
-      // Verify the full chain works: verifyExpectedArtifact should return true
-      const verified = verifyExpectedArtifact("execute-task", "M001/S01/T01", base);
-      assert.equal(verified, true,
-        "verifyExpectedArtifact should pass after writeBlockerPlaceholder updates DB status");
-    } finally {
-      if (isDbAvailable()) closeDatabase();
-    }
-  } finally {
-    cleanup(base);
-  }
-});
-
-test('writeBlockerPlaceholder: does NOT update DB for non-execute-task types', async () => {
-  const base = createFixtureBase();
-  try {
-    const { openDatabase, closeDatabase, insertMilestone, insertSlice, getSlice, isDbAvailable } =
-      await import("../gsd-db.ts");
-
-    const dbPath = join(base, ".gsd", "gsd.db");
-    mkdirSync(join(base, ".gsd", "milestones", "M001", "slices", "S01"), { recursive: true });
-
-    openDatabase(dbPath);
-    try {
-      insertMilestone({ id: "M001", title: "Test", status: "active" });
-      insertSlice({ id: "S01", milestoneId: "M001", title: "Slice", status: "active" });
-
-      // research-slice is NOT execute-task — DB should NOT be updated
-      writeBlockerPlaceholder("research-slice", "M001/S01", base, "idle recovery exhausted");
-
-      const slice = getSlice("M001", "S01");
-      assert.equal(slice?.status, "active",
-        "writeBlockerPlaceholder should not change DB status for non-execute-task types");
-    } finally {
-      if (isDbAvailable()) closeDatabase();
-    }
-  } finally {
-    cleanup(base);
-  }
-});

package/src/resources/extensions/gsd/tests/model-router.test.ts

@@ -165,43 +165,3 @@ test("falls back to configured model when no light-tier model available", () =>
   assert.equal(result.modelId, "claude-opus-4-6");
   assert.equal(result.wasDowngraded, false);
 });
-
-// ─── #2192: Unknown models honor explicit config ─────────────────────────────
-
-test("#2192: unknown model is not downgraded — respects user config", () => {
-  const config = { ...defaultRoutingConfig(), enabled: true };
-  const result = resolveModelForComplexity(
-    makeClassification("light"),
-    { primary: "gpt-5.4", fallbacks: [] },
-    config,
-    ["gpt-5.4", ...AVAILABLE_MODELS],
-  );
-  assert.equal(result.modelId, "gpt-5.4", "unknown model should be used as-is");
-  assert.equal(result.wasDowngraded, false, "should not be downgraded");
-  assert.ok(result.reason.includes("not in the known tier map"), "reason should explain why");
-});
-
-test("#2192: unknown model with provider prefix is not downgraded", () => {
-  const config = { ...defaultRoutingConfig(), enabled: true };
-  const result = resolveModelForComplexity(
-    makeClassification("standard"),
-    { primary: "custom-provider/my-model-v3", fallbacks: [] },
-    config,
-    ["custom-provider/my-model-v3", ...AVAILABLE_MODELS],
-  );
-  assert.equal(result.modelId, "custom-provider/my-model-v3");
-  assert.equal(result.wasDowngraded, false);
-});
-
-test("#2192: known model is still downgraded normally", () => {
-  const config = { ...defaultRoutingConfig(), enabled: true };
-  // claude-opus-4-6 is known as "heavy" — a light request should downgrade
-  const result = resolveModelForComplexity(
-    makeClassification("light"),
-    { primary: "claude-opus-4-6", fallbacks: [] },
-    config,
-    AVAILABLE_MODELS,
-  );
-  assert.equal(result.wasDowngraded, true, "known heavy model should still be downgraded for light tasks");
-  assert.notEqual(result.modelId, "claude-opus-4-6");
-});

package/src/resources/extensions/gsd/tests/notifications.test.ts

@@ -31,10 +31,7 @@ test("shouldSendDesktopNotification disables all categories when notifications a
   assert.equal(shouldSendDesktopNotification("milestone", prefs), false);
 });
 
-test("buildDesktopNotificationCommand falls back to osascript on macOS when terminal-notifier is absent", () => {
-  // When terminal-notifier is not on PATH, falls back to osascript.
-  // This test runs in CI where terminal-notifier is typically not installed.
-  // If terminal-notifier IS installed, we verify it returns that instead.
+test("buildDesktopNotificationCommand uses argument arrays for macOS notifications", () => {
   const command = buildDesktopNotificationCommand(
     "darwin",
     `Bob's "Milestone"`,
@@ -43,30 +40,11 @@ test("buildDesktopNotificationCommand falls back to osascript on macOS when term
   );
 
   assert.ok(command);
-  if (command.file.includes("terminal-notifier")) {
-    // terminal-notifier path — verify args structure
-    assert.ok(command.args.includes("-title"));
-    assert.ok(command.args.includes("-message"));
-    assert.ok(command.args.includes("-sound"));
-    assert.ok(command.args.includes("Basso")); // error level
-  } else {
-    // osascript fallback path
-    assert.equal(command.file, "osascript");
-    assert.deepEqual(command.args.slice(0, 1), ["-e"]);
-    assert.match(command.args[1], /Bob's \\"Milestone\\"/);
-    assert.match(command.args[1], /Budget! Path: C:\\\\temp/);
-    assert.doesNotMatch(command.args[1], /\n/);
-  }
-});
-
-test("buildDesktopNotificationCommand uses Glass sound for non-error on macOS", () => {
-  const command = buildDesktopNotificationCommand("darwin", "Title", "Message", "info");
-  assert.ok(command);
-  if (command.file.includes("terminal-notifier")) {
-    assert.ok(command.args.includes("Glass"));
-  } else {
-    assert.match(command.args[1], /sound name "Glass"/);
-  }
+  assert.equal(command.file, "osascript");
+  assert.deepEqual(command.args.slice(0, 1), ["-e"]);
+  assert.match(command.args[1], /Bob's \\"Milestone\\"/);
+  assert.match(command.args[1], /Budget! Path: C:\\\\temp/);
+  assert.doesNotMatch(command.args[1], /\n/);
 });
 
 test("buildDesktopNotificationCommand preserves literal shell characters on linux", () => {

package/src/resources/extensions/gsd/tests/preferences.test.ts

@@ -377,53 +377,3 @@ test("unrecognized format warning is emitted at most once (#2373)", () => {
     _resetParseWarningFlag();
   }
 });
-
-// ── Experimental preferences ─────────────────────────────────────────────────
-
-test("experimental.rtk: true is accepted and stored", () => {
-  const result = validatePreferences({ experimental: { rtk: true } });
-  assert.deepEqual(result.errors, []);
-  assert.equal(result.preferences.experimental?.rtk, true);
-});
-
-test("experimental.rtk: false is accepted and stored", () => {
-  const result = validatePreferences({ experimental: { rtk: false } });
-  assert.deepEqual(result.errors, []);
-  assert.equal(result.preferences.experimental?.rtk, false);
-});
-
-test("experimental.rtk: non-boolean produces error", () => {
-  const result = validatePreferences({ experimental: { rtk: "yes" } } as unknown as GSDPreferences);
-  assert.ok(result.errors.some(e => e.includes("experimental.rtk")), `expected rtk error in: ${JSON.stringify(result.errors)}`);
-});
-
-test("experimental: non-object produces error", () => {
-  const result = validatePreferences({ experimental: true } as unknown as GSDPreferences);
-  assert.ok(result.errors.some(e => e.includes("experimental must be an object")));
-});
-
-test("experimental: unknown key produces warning", () => {
-  const result = validatePreferences({ experimental: { rtk: true, future_flag: true } } as unknown as GSDPreferences);
-  assert.ok(result.warnings.some(w => w.includes("future_flag")), `expected unknown-key warning in: ${JSON.stringify(result.warnings)}`);
-  assert.equal(result.preferences.experimental?.rtk, true);
-});
-
-test("experimental: omitting rtk defaults to undefined (opt-in)", () => {
-  const result = validatePreferences({ version: 1 });
-  assert.equal(result.preferences.experimental, undefined);
-});
-
-test("experimental.rtk parses correctly from preferences markdown", () => {
-  const content = "---\nversion: 1\nexperimental:\n  rtk: true\n---\n";
-  const prefs = parsePreferencesMarkdown(content);
-  assert.notEqual(prefs, null);
-  assert.equal(prefs!.experimental?.rtk, true);
-});
-
-test("experimental.rtk defaults to off in new project preferences", () => {
-  // No experimental key → feature is disabled
-  const content = "---\nversion: 1\n---\n";
-  const prefs = parsePreferencesMarkdown(content);
-  assert.notEqual(prefs, null);
-  assert.equal(prefs!.experimental?.rtk, undefined);
-});

package/src/resources/extensions/gsd/tests/queue-reorder-e2e.test.ts

@@ -292,44 +292,4 @@ test('E2E: depends_on inline format preserved after partial removal', () => {
   }
 });
 
-test('E2E: DB-backed path respects queue order (#2556)', async () => {
-    // Regression test for #2556: getActiveMilestoneId and deriveStateFromDb
-    // used lexicographic sort instead of queue order, causing a deadlock when
-    // the dispatch guard (which respects queue order) blocked completion.
-    const base = createFixtureBase();
-    try {
-      const { openDatabase, closeDatabase, insertMilestone, isDbAvailable } = await import('../gsd-db.ts');
-      const dbPath = join(base, '.gsd', 'gsd.db');
-
-      // Create milestone directories (required for findMilestoneIds)
-      writeMilestoneDir(base, 'M006');
-      writeContext(base, 'M006', '', 'Earlier milestone');
-      writeMilestoneDir(base, 'M008');
-      writeContext(base, 'M008', '', 'Later milestone');
-
-      // Open DB and insert milestones
-      openDatabase(dbPath);
-      try {
-        insertMilestone({ id: 'M006', title: 'Earlier', status: 'active' });
-        insertMilestone({ id: 'M008', title: 'Later', status: 'active' });
-
-        // Set queue order: M008 should come FIRST (user reordered via /gsd queue)
-        saveQueueOrder(base, ['M008', 'M006']);
-
-        // deriveState should pick M008 (queue-first), not M006 (ID-first)
-        invalidateStateCache();
-        const state = await deriveState(base);
-        assert.equal(
-          state.activeMilestone?.id,
-          'M008',
-          'DB-backed deriveState must respect queue order — M008 is queued first',
-        );
-      } finally {
-        if (isDbAvailable()) closeDatabase();
-      }
-    } finally {
-      cleanup(base);
-    }
-});
-
 });

package/src/resources/extensions/gsd/tests/reactive-executor.test.ts

@@ -15,7 +15,6 @@ import {
 } from "../reactive-graph.ts";
 import { validatePreferences } from "../preferences-validation.ts";
 import type { ReactiveExecutionState } from "../types.ts";
-import { parseUnitId } from "../unit-id.ts";
 
 // ─── Preference Validation ────────────────────────────────────────────────
 
@@ -442,12 +441,13 @@ test("unitId batch encoding round-trips correctly", () => {
   const unitId = `${mid}/${sid}/reactive+${selected.join(",")}`;
 
   // Parse it back
-  const { milestone, slice, task: batchPart } = parseUnitId(unitId);
-  assert.equal(milestone, "M001");
-  assert.equal(slice, "S01");
-  const plusIdx = batchPart!.indexOf("+");
+  const parts = unitId.split("/");
+  assert.equal(parts[0], "M001");
+  assert.equal(parts[1], "S01");
+  const batchPart = parts[2];
+  const plusIdx = batchPart.indexOf("+");
   assert.ok(plusIdx > 0, "Should have + separator");
-  const batchIds = batchPart!.slice(plusIdx + 1).split(",");
+  const batchIds = batchPart.slice(plusIdx + 1).split(",");
   assert.deepEqual(batchIds, ["T02", "T03", "T05"]);
 });
 

package/src/resources/extensions/gsd/tests/retry-state-reset.test.ts

@@ -16,7 +16,6 @@ import {
   resolveHookArtifactPath,
 } from "../post-unit-hooks.ts";
 import { uncheckTaskInPlan } from "../undo.ts";
-import { parseUnitId } from "../unit-id.ts";
 
 // ─── Fixture Helpers ───────────────────────────────────────────────────────
 
@@ -184,7 +183,8 @@ test('Full retry reset: all steps combined', () => {
       retryArtifact: "NEEDS-REWORK.md",
     };
 
-    const { milestone: mid, slice: sid, task: tid } = parseUnitId(trigger.unitId);
+    const parts = trigger.unitId.split("/");
+    const [mid, sid, tid] = parts;
 
     // Simulate completedUnits
     let completedUnits = [
@@ -264,10 +264,11 @@ test('Retry reset: idempotent when artifacts already missing', () => {
     };
 
     // These should not throw even with missing files
-    const { milestone: mid, slice: sid, task: tid } = parseUnitId(trigger.unitId);
+    const parts = trigger.unitId.split("/");
+    const [mid, sid, tid] = parts;
 
     // Uncheck — returns false because no PLAN file
-    const uncheckResult = uncheckTaskInPlan(base, mid, sid!, tid!);
+    const uncheckResult = uncheckTaskInPlan(base, mid, sid, tid);
     assert.ok(!uncheckResult, "uncheck returns false when no PLAN exists");
 
     // Summary does not exist — no crash

package/src/resources/extensions/gsd/tests/run-uat.test.ts

@@ -460,150 +460,4 @@ test('(n) stale replay guard', async () => {
     }
 });
 
-test('(q) verdict in ASSESSMENT file skips UAT dispatch (file-based path)', async () => {
-    // Regression test for #2644: run-uat prompt writes the verdict to
-    // S{sid}-ASSESSMENT.md (via gsd_summary_save artifact_type:"ASSESSMENT"),
-    // but checkNeedsRunUat only checked S{sid}-UAT.md — causing a stuck loop.
-    const base = createFixtureBase();
-    try {
-      const roadmapDir = join(base, '.gsd', 'milestones', 'M001');
-      mkdirSync(roadmapDir, { recursive: true });
-      writeFileSync(
-        join(roadmapDir, 'M001-ROADMAP.md'),
-        [
-          '# M001: Test roadmap',
-          '',
-          '## Slices',
-          '',
-          '- [x] **S01: First slice** `risk:low` `depends:[]`',
-          '- [ ] **S02: Next slice** `risk:low` `depends:[S01]`',
-          '',
-          '## Boundary Map',
-          '',
-        ].join('\n'),
-      );
-
-      // UAT spec file WITHOUT a verdict (the spec never gets one)
-      writeSliceFile(base, 'M001', 'S01', 'UAT', makeUatContent('artifact-driven'));
-      // ASSESSMENT file WITH a verdict (where run-uat actually writes it)
-      writeSliceFile(base, 'M001', 'S01', 'ASSESSMENT', '---\nverdict: PASS\n---\n# UAT Assessment\n');
-
-      const state = {
-        activeMilestone: { id: 'M001', title: 'Test roadmap' },
-        activeSlice: { id: 'S02', title: 'Next slice' },
-        activeTask: null,
-        phase: 'planning',
-        recentDecisions: [],
-        blockers: [],
-        nextAction: 'Plan S02',
-        registry: [],
-      } as const;
-
-      const result = await checkNeedsRunUat(base, 'M001', state as any, { uat_dispatch: true } as any);
-      assert.deepStrictEqual(
-        result,
-        null,
-        'verdict in ASSESSMENT file should prevent re-dispatch of run-uat',
-      );
-    } finally {
-      cleanup(base);
-    }
-});
-
-test('(r) no ASSESSMENT file still dispatches UAT (no false skip)', async () => {
-    // Guard: when there is no ASSESSMENT file at all, UAT should still dispatch
-    // normally. The ASSESSMENT check must not cause a false-negative skip.
-    const base = createFixtureBase();
-    try {
-      const roadmapDir = join(base, '.gsd', 'milestones', 'M001');
-      mkdirSync(roadmapDir, { recursive: true });
-      writeFileSync(
-        join(roadmapDir, 'M001-ROADMAP.md'),
-        [
-          '# M001: Test roadmap',
-          '',
-          '## Slices',
-          '',
-          '- [x] **S01: First slice** `risk:low` `depends:[]`',
-          '- [ ] **S02: Next slice** `risk:low` `depends:[S01]`',
-          '',
-          '## Boundary Map',
-          '',
-        ].join('\n'),
-      );
-
-      // UAT spec file WITHOUT a verdict, and NO ASSESSMENT file
-      writeSliceFile(base, 'M001', 'S01', 'UAT', makeUatContent('artifact-driven'));
-
-      const state = {
-        activeMilestone: { id: 'M001', title: 'Test roadmap' },
-        activeSlice: { id: 'S02', title: 'Next slice' },
-        activeTask: null,
-        phase: 'planning',
-        recentDecisions: [],
-        blockers: [],
-        nextAction: 'Plan S02',
-        registry: [],
-      } as const;
-
-      const result = await checkNeedsRunUat(base, 'M001', state as any, { uat_dispatch: true } as any);
-      assert.deepStrictEqual(
-        result,
-        { sliceId: 'S01', uatType: 'artifact-driven' },
-        'without ASSESSMENT file, UAT still dispatches normally',
-      );
-    } finally {
-      cleanup(base);
-    }
-});
-
-test('(s) ASSESSMENT without verdict does not skip UAT dispatch', async () => {
-    // Guard: an ASSESSMENT file that exists but has no verdict line should
-    // NOT suppress UAT dispatch — only a file with an actual verdict should.
-    const base = createFixtureBase();
-    try {
-      const roadmapDir = join(base, '.gsd', 'milestones', 'M001');
-      mkdirSync(roadmapDir, { recursive: true });
-      writeFileSync(
-        join(roadmapDir, 'M001-ROADMAP.md'),
-        [
-          '# M001: Test roadmap',
-          '',
-          '## Slices',
-          '',
-          '- [x] **S01: First slice** `risk:low` `depends:[]`',
-          '- [ ] **S02: Next slice** `risk:low` `depends:[S01]`',
-          '',
-          '## Boundary Map',
-          '',
-        ].join('\n'),
-      );
-
-      // UAT spec WITHOUT verdict
-      writeSliceFile(base, 'M001', 'S01', 'UAT', makeUatContent('artifact-driven'));
-      // ASSESSMENT file WITHOUT verdict (partial/incomplete assessment)
-      writeSliceFile(base, 'M001', 'S01', 'ASSESSMENT', '# UAT Assessment\n\nStill running checks...\n');
-
-      const state = {
-        activeMilestone: { id: 'M001', title: 'Test roadmap' },
-        activeSlice: { id: 'S02', title: 'Next slice' },
-        activeTask: null,
-        phase: 'planning',
-        recentDecisions: [],
-        blockers: [],
-        nextAction: 'Plan S02',
-        registry: [],
-      } as const;
-
-      const result = await checkNeedsRunUat(base, 'M001', state as any, { uat_dispatch: true } as any);
-      assert.deepStrictEqual(
-        result,
-        { sliceId: 'S01', uatType: 'artifact-driven' },
-        'ASSESSMENT without verdict should not suppress UAT dispatch',
-      );
-    } finally {
-      cleanup(base);
-    }
-});
-
 });

package/src/resources/extensions/gsd/tests/sidecar-queue.test.ts

@@ -113,12 +113,12 @@ test("postUnitPostVerification pushes to sidecarQueue for hooks", () => {
   assert.ok(triageSectionStart > -1, "auto-post-unit.ts must have a triage check section");
   const hookSection = source.slice(hookSectionStart, triageSectionStart);
   assert.ok(
-    hookSection.includes("enqueueSidecar(") || hookSection.includes("s.sidecarQueue.push("),
-    "hook section must enqueue to sidecarQueue (via enqueueSidecar or direct push)",
+    hookSection.includes("s.sidecarQueue.push("),
+    "hook section must push to s.sidecarQueue",
   );
   assert.ok(
-    hookSection.includes('"hook"'),
-    "hook sidecar item must reference kind 'hook'",
+    hookSection.includes('kind: "hook"'),
+    "hook sidecar item must have kind: 'hook'",
   );
 });
 
@@ -132,12 +132,12 @@ test("postUnitPostVerification pushes to sidecarQueue for triage", () => {
   assert.ok(quickTaskSectionStart > -1, "auto-post-unit.ts must have a quick-task dispatch section");
   const triageSection = source.slice(triageSectionStart, quickTaskSectionStart);
   assert.ok(
-    triageSection.includes("enqueueSidecar(") || triageSection.includes("s.sidecarQueue.push("),
-    "triage section must enqueue to sidecarQueue (via enqueueSidecar or direct push)",
+    triageSection.includes("s.sidecarQueue.push("),
+    "triage section must push to s.sidecarQueue",
   );
   assert.ok(
-    triageSection.includes('"triage"'),
-    "triage sidecar item must reference kind 'triage'",
+    triageSection.includes('kind: "triage"'),
+    "triage sidecar item must have kind: 'triage'",
   );
 });
 
@@ -149,12 +149,12 @@ test("postUnitPostVerification pushes to sidecarQueue for quick-tasks", () => {
   assert.ok(quickTaskSectionStart > -1, "auto-post-unit.ts must have a quick-task dispatch section");
   const quickTaskSection = source.slice(quickTaskSectionStart);
   assert.ok(
-    quickTaskSection.includes("enqueueSidecar(") || quickTaskSection.includes("s.sidecarQueue.push("),
-    "quick-task section must enqueue to sidecarQueue (via enqueueSidecar or direct push)",
+    quickTaskSection.includes("s.sidecarQueue.push("),
+    "quick-task section must push to s.sidecarQueue",
   );
   assert.ok(
-    quickTaskSection.includes('"quick-task"'),
-    "quick-task sidecar item must reference kind 'quick-task'",
+    quickTaskSection.includes('kind: "quick-task"'),
+    "quick-task sidecar item must have kind: 'quick-task'",
   );
 });
 

package/src/resources/extensions/gsd/tests/terminated-transient.test.ts

@@ -47,27 +47,3 @@ test("#2309: rate limits are still transient", () => {
   assert.equal(rlResult.isTransient, true, "rate limits are still transient");
   assert.equal(rlResult.isRateLimit, true, "rate limits are flagged as rate limits");
 });
-
-// --- #2572: stream-truncation JSON parse errors should be transient ---
-
-test("#2572: 'Expected double-quoted property name' (truncated stream) is transient", () => {
-  const result = classifyProviderError("Expected double-quoted property name in JSON at position 23 (line 1 column 24)");
-  assert.equal(result.isTransient, true, "truncated-stream JSON parse error should be transient");
-  assert.equal(result.isRateLimit, false, "not a rate limit");
-  assert.equal(result.suggestedDelayMs, 15_000, "should use 15s backoff like connection errors");
-});
-
-test("#2572: 'Unexpected end of JSON input' (truncated stream) is transient", () => {
-  const result = classifyProviderError("Unexpected end of JSON input");
-  assert.equal(result.isTransient, true, "'Unexpected end of JSON input' should be transient");
-});
-
-test("#2572: 'Unexpected token' in JSON (truncated stream) is transient", () => {
-  const result = classifyProviderError("Unexpected token < in JSON at position 0");
-  assert.equal(result.isTransient, true, "'Unexpected token in JSON' should be transient");
-});
-
-test("#2572: 'SyntaxError' with JSON context (truncated stream) is transient", () => {
-  const result = classifyProviderError("SyntaxError: JSON.parse: unexpected character at line 1 column 1");
-  assert.equal(result.isTransient, true, "'SyntaxError...JSON' should be transient");
-});

package/src/resources/extensions/gsd/tests/triage-dispatch.test.ts

@@ -119,7 +119,7 @@ test("dispatch: triage dispatch keeps the loop in continue mode", () => {
     postUnitSrc.indexOf("// ── Quick-task dispatch"),
   );
   assert.ok(
-    triageBlock.includes('return "continue"') || triageBlock.includes("return enqueueSidecar("),
+    triageBlock.includes('return "continue"'),
     "triage dispatch should return 'continue' after enqueuing sidecar work",
   );
 });
@@ -320,7 +320,7 @@ test("dispatch: quick-task dispatch keeps the loop in continue mode", () => {
     postUnitSrc.indexOf("if (s.stepMode)"),
   );
   assert.ok(
-    quickTaskSection.includes('return "continue"') || quickTaskSection.includes("return enqueueSidecar("),
+    quickTaskSection.includes('return "continue"'),
     "quick-task dispatch should return 'continue' after enqueuing sidecar work",
   );
 });

package/src/resources/extensions/gsd/types.ts

@@ -157,8 +157,6 @@ export interface Summary {
   whatHappened: string;
   deviations: string;
   filesModified: FileModified[];
-  followUps: string;
-  knownLimitations: string;
 }
 
 // ─── Continue-Here ─────────────────────────────────────────────────────────