gsd-pi 2.50.0-dev.d210a87 → 2.50.0

package/src/resources/extensions/gsd/tests/auto-lock-creation.test.ts

@@ -140,7 +140,7 @@ test("isLockProcessAlive returns false for dead PID", () => {
   assert.equal(isLockProcessAlive(lock), false, "dead PID should return false");
 });
 
-test("#2470: isLockProcessAlive returns true for own PID (we hold the lock)", () => {
+test("isLockProcessAlive returns false for own PID (recycled)", () => {
   const lock = {
     pid: process.pid,
     startedAt: new Date().toISOString(),
@@ -148,7 +148,7 @@ test("#2470: isLockProcessAlive returns true for own PID (we hold the lock)", ()
     unitId: "M001/S01/T01",
     unitStartedAt: new Date().toISOString(),
   };
-  assert.equal(isLockProcessAlive(lock), true, "own PID means we are alive — not stale (#2470)");
+  assert.equal(isLockProcessAlive(lock), false, "own PID should return false (recycled)");
 });
 
 test("isLockProcessAlive returns false for invalid PID", () => {

package/src/resources/extensions/gsd/tests/auto-loop.test.ts

@@ -882,74 +882,6 @@ test("autoLoop handles dispatch stop action", async (t) => {
   );
 });
 
-// #2474: warning-level dispatch stop should pause (resumable), not hard-stop
-test("autoLoop pauses instead of stopping for warning-level dispatch stop", async (t) => {
-  _resetPendingResolve();
-
-  const ctx = makeMockCtx();
-  ctx.ui.setStatus = () => {};
-  const pi = makeMockPi();
-  const s = makeLoopSession();
-
-  const deps = makeMockDeps({
-    resolveDispatch: async () => {
-      deps.callLog.push("resolveDispatch");
-      return {
-        action: "stop" as const,
-        reason: 'UAT verdict for S01 is "partial" — blocking progression.',
-        level: "warning" as const,
-      };
-    },
-  });
-
-  await autoLoop(ctx, pi, s, deps);
-
-  assert.ok(
-    deps.callLog.includes("resolveDispatch"),
-    "should have called resolveDispatch",
-  );
-  assert.ok(
-    deps.callLog.includes("pauseAuto"),
-    "warning-level stop should call pauseAuto (resumable)",
-  );
-  assert.ok(
-    !deps.callLog.includes("stopAuto"),
-    "warning-level stop should NOT call stopAuto (hard stop)",
-  );
-});
-
-// #2474: error-level dispatch stop should still hard-stop
-test("autoLoop hard-stops for error-level dispatch stop", async (t) => {
-  _resetPendingResolve();
-
-  const ctx = makeMockCtx();
-  ctx.ui.setStatus = () => {};
-  const pi = makeMockPi();
-  const s = makeLoopSession();
-
-  const deps = makeMockDeps({
-    resolveDispatch: async () => {
-      deps.callLog.push("resolveDispatch");
-      return {
-        action: "stop" as const,
-        reason: "Cannot complete milestone: missing SUMMARY files.",
-        level: "error" as const,
-      };
-    },
-  });
-
-  await autoLoop(ctx, pi, s, deps);
-
-  assert.ok(
-    deps.callLog.includes("stopAuto"),
-    "error-level stop should call stopAuto (hard stop)",
-  );
-  assert.ok(
-    !deps.callLog.includes("pauseAuto"),
-    "error-level stop should NOT call pauseAuto",
-  );
-});
-
 test("autoLoop handles dispatch skip action by continuing", async (t) => {
   _resetPendingResolve();
 

package/src/resources/extensions/gsd/tests/complete-milestone.test.ts

@@ -5,7 +5,6 @@ import { join, dirname } from "node:path";
 import { tmpdir } from "node:os";
 import { fileURLToPath } from "node:url";
 import { invalidateAllCaches } from '../cache.ts';
-import { parseUnitId } from "../unit-id.ts";
 
 // loadPrompt reads from ~/.gsd/agent/extensions/gsd/prompts/ (main checkout).
 // In a worktree the file may not exist there yet, so we resolve prompts
@@ -223,7 +222,8 @@ describe("complete-milestone", () => {
 
       const unitType = "complete-milestone";
       const unitId = "M001";
-      const { milestone: mid } = parseUnitId(unitId);
+      const parts = unitId.split("/");
+      const mid = parts[0]!;
 
       // This is the exact logic from diagnoseExpectedArtifact for "complete-milestone"
       const result = `${relMilestoneFile(base, mid, "SUMMARY")} (milestone summary)`;

package/src/resources/extensions/gsd/tests/crash-recovery.test.ts

@@ -68,10 +68,8 @@ test("clearLock is safe when no lock exists", (t) => {
 
 // ─── isLockProcessAlive ──────────────────────────────────────────────────
 
-test("#2470: isLockProcessAlive returns true for own PID (we hold the lock)", () => {
-  // Own PID means we ARE the lock holder — alive, not stale. (#2470)
-  // Callers that need recycled-PID detection (e.g. startAuto) already
-  // guard with `crashLock.pid !== process.pid` before calling us.
+test("isLockProcessAlive returns true for current process (different pid)", () => {
+  // Our own PID is explicitly excluded (recycled PID guard)
   const lock: LockData = {
     pid: process.pid,
     startedAt: new Date().toISOString(),
@@ -79,7 +77,7 @@ test("#2470: isLockProcessAlive returns true for own PID (we hold the lock)", ()
     unitId: "M001/S01/T01",
     unitStartedAt: new Date().toISOString(),
   };
-  assert.equal(isLockProcessAlive(lock), true, "own PID should return true — we are alive");
+  assert.equal(isLockProcessAlive(lock), false, "own PID should return false");
 });
 
 test("isLockProcessAlive returns false for dead PID", () => {

package/src/resources/extensions/gsd/tests/custom-verification.test.ts

@@ -15,7 +15,6 @@ import { tmpdir } from "node:os";
 import { stringify } from "yaml";
 import { runCustomVerification } from "../custom-verification.ts";
 import type { WorkflowDefinition } from "../definition-loader.ts";
-import { createFakeRtk } from "../../../../tests/rtk-test-utils.ts";
 
 /** Create a temp run directory with the given definition and optional files. */
 function makeTempRun(
@@ -226,38 +225,6 @@ describe("shell-command policy", () => {
     const result = runCustomVerification(runDir, "step-1");
     assert.equal(result, "retry");
   });
-
-  it("rewrites shell-command verification through RTK when available", () => {
-    const fake = createFakeRtk({
-      "echo raw": "echo rewritten",
-    });
-    const previous = process.env.GSD_RTK_PATH;
-    process.env.GSD_RTK_PATH = fake.path;
-
-    try {
-      const def = makeDef([
-        {
-          id: "step-1",
-          name: "Build artifact",
-          prompt: "Build the artifact",
-          requires: [],
-          produces: ["artifact.txt"],
-          verify: {
-            policy: "shell-command",
-            command: "echo raw",
-          },
-        },
-      ]);
-
-      const runDir = makeTempRun(def);
-      const result = runCustomVerification(runDir, "step-1");
-      assert.equal(result, "continue");
-    } finally {
-      if (previous === undefined) delete process.env.GSD_RTK_PATH;
-      else process.env.GSD_RTK_PATH = previous;
-      fake.cleanup();
-    }
-  });
 });
 
 // ─── prompt-verify tests ────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/derive-state-db.test.ts

@@ -769,10 +769,9 @@ describe('derive-state-db', async () => {
       const elapsed = performance.now() - start;
 
       console.log(`  deriveStateFromDb() took ${elapsed.toFixed(3)}ms`);
-      // Use 25ms threshold — catches real regressions without flaking on
-      // slower CI runners (Windows agents measured at ~12ms under load;
-      // the 10ms threshold was too tight for those environments).
-      assert.ok(elapsed < 25, `perf-db: deriveStateFromDb() <25ms (got ${elapsed.toFixed(3)}ms)`);
+      // Use 10ms threshold — catches real regressions without flaking on
+      // CI runners under load (1ms threshold failed at 1.050ms on GitHub Actions)
+      assert.ok(elapsed < 10, `perf-db: deriveStateFromDb() <10ms (got ${elapsed.toFixed(3)}ms)`);
 
       closeDatabase();
     } finally {