gsd-pi 2.43.0 → 2.44.0-dev.0b97ffd

package/packages/pi-coding-agent/src/core/fs-utils.test.ts

@@ -1,66 +1,54 @@
 import assert from "node:assert/strict";
-import { describe, it } from "node:test";
+import { describe, it, afterEach } from "node:test";
 import { mkdtempSync, readFileSync, rmSync, existsSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import { atomicWriteFileSync } from "./fs-utils.js";
 
 describe("atomicWriteFileSync", () => {
-	it("writes file content atomically", () => {
-		const dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
-		try {
-			const filePath = join(dir, "test.txt");
-			atomicWriteFileSync(filePath, "hello world");
-			assert.equal(readFileSync(filePath, "utf-8"), "hello world");
-		} finally {
+	let dir: string;
+
+	afterEach(() => {
+		if (dir) {
 			rmSync(dir, { recursive: true, force: true });
 		}
 	});
 
+	it("writes file content atomically", () => {
+		dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
+		const filePath = join(dir, "test.txt");
+		atomicWriteFileSync(filePath, "hello world");
+		assert.equal(readFileSync(filePath, "utf-8"), "hello world");
+	});
+
 	it("overwrites existing file atomically", () => {
-		const dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
-		try {
-			const filePath = join(dir, "test.txt");
-			atomicWriteFileSync(filePath, "first");
-			atomicWriteFileSync(filePath, "second");
-			assert.equal(readFileSync(filePath, "utf-8"), "second");
-		} finally {
-			rmSync(dir, { recursive: true, force: true });
-		}
+		dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
+		const filePath = join(dir, "test.txt");
+		atomicWriteFileSync(filePath, "first");
+		atomicWriteFileSync(filePath, "second");
+		assert.equal(readFileSync(filePath, "utf-8"), "second");
 	});
 
 	it("does not leave .tmp file after successful write", () => {
-		const dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
-		try {
-			const filePath = join(dir, "test.txt");
-			atomicWriteFileSync(filePath, "content");
-			assert.equal(existsSync(filePath + ".tmp"), false);
-		} finally {
-			rmSync(dir, { recursive: true, force: true });
-		}
+		dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
+		const filePath = join(dir, "test.txt");
+		atomicWriteFileSync(filePath, "content");
+		assert.equal(existsSync(filePath + ".tmp"), false);
 	});
 
 	it("supports Buffer content", () => {
-		const dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
-		try {
-			const filePath = join(dir, "test.bin");
-			const buf = Buffer.from([0x00, 0x01, 0x02, 0xff]);
-			atomicWriteFileSync(filePath, buf);
-			const result = readFileSync(filePath);
-			assert.deepEqual(result, buf);
-		} finally {
-			rmSync(dir, { recursive: true, force: true });
-		}
+		dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
+		const filePath = join(dir, "test.bin");
+		const buf = Buffer.from([0x00, 0x01, 0x02, 0xff]);
+		atomicWriteFileSync(filePath, buf);
+		const result = readFileSync(filePath);
+		assert.deepEqual(result, buf);
 	});
 
 	it("supports encoding parameter", () => {
-		const dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
-		try {
-			const filePath = join(dir, "test.txt");
-			atomicWriteFileSync(filePath, "utf8 content", "utf-8");
-			assert.equal(readFileSync(filePath, "utf-8"), "utf8 content");
-		} finally {
-			rmSync(dir, { recursive: true, force: true });
-		}
+		dir = mkdtempSync(join(tmpdir(), "fs-utils-test-"));
+		const filePath = join(dir, "test.txt");
+		atomicWriteFileSync(filePath, "utf8 content", "utf-8");
+		assert.equal(readFileSync(filePath, "utf-8"), "utf8 content");
 	});
 });

package/packages/pi-coding-agent/src/core/lifecycle-hooks.ts

@@ -0,0 +1,274 @@
+import { spawnSync } from "node:child_process";
+import { existsSync, readFileSync } from "node:fs";
+import { homedir } from "node:os";
+import { dirname, join, resolve } from "node:path";
+import { pathToFileURL } from "node:url";
+import { parseGitUrl } from "../utils/git.js";
+import {
+	importExtensionModule,
+	loadExtensions,
+	type LifecycleHookContext,
+	type LifecycleHookMap,
+	type LifecycleHookHandler,
+	type LifecycleHookPhase,
+	type LifecycleHookScope,
+} from "./extensions/index.js";
+import type { DefaultPackageManager } from "./package-manager.js";
+
+interface ExtensionManifest {
+	dependencies?: {
+		runtime?: string[];
+	};
+}
+
+export interface PackageLifecycleHooksOptions {
+	source: string;
+	local: boolean;
+	cwd: string;
+	agentDir: string;
+	appName: string;
+	packageManager: DefaultPackageManager;
+	stdout: NodeJS.WriteStream;
+	stderr: NodeJS.WriteStream;
+}
+
+export type LifecycleHooksTarget = "source" | "installed";
+
+export interface PrepareLifecycleHooksOptions {
+	verifyRuntimeDependencies?: boolean;
+}
+
+export interface LifecycleHooksRunResult {
+	phase: LifecycleHookPhase;
+	hooksRun: number;
+	hookErrors: number;
+	legacyHooksRun: number;
+	entryPathCount: number;
+	skipped: boolean;
+}
+
+interface LoadedLifecycleHooks {
+	source: string;
+	scope: LifecycleHookScope;
+	installedPath?: string;
+	cwd: string;
+	stdout: NodeJS.WriteStream;
+	stderr: NodeJS.WriteStream;
+	entryPaths: string[];
+	hooksByPath: Map<string, LifecycleHookMap>;
+}
+
+function toScope(local: boolean): LifecycleHookScope {
+	return local ? "project" : "user";
+}
+
+function readManifestRuntimeDeps(dir: string): string[] {
+	const manifestPath = join(dir, "extension-manifest.json");
+	if (!existsSync(manifestPath)) return [];
+	try {
+		const manifest = JSON.parse(readFileSync(manifestPath, "utf-8")) as ExtensionManifest;
+		return manifest.dependencies?.runtime?.filter((dep): dep is string => typeof dep === "string") ?? [];
+	} catch {
+		return [];
+	}
+}
+
+function collectRuntimeDependencies(installedPath: string, entryPaths: string[]): string[] {
+	const deps = new Set<string>();
+	const candidateDirs = new Set<string>([installedPath, ...entryPaths.map((entryPath) => dirname(entryPath))]);
+	for (const dir of candidateDirs) {
+		for (const dep of readManifestRuntimeDeps(dir)) {
+			deps.add(dep);
+		}
+	}
+	return Array.from(deps);
+}
+
+function verifyRuntimeDependencies(runtimeDeps: string[], source: string, appName: string): void {
+	const missing: string[] = [];
+	for (const dep of runtimeDeps) {
+		const result = spawnSync(dep, ["--version"], { encoding: "utf-8", timeout: 5000 });
+		if (result.error || result.status !== 0) {
+			missing.push(dep);
+		}
+	}
+	if (missing.length === 0) return;
+	throw new Error(
+		`Missing runtime dependencies: ${missing.join(", ")}.\n` +
+			`Install them and retry: ${appName} install ${source}`,
+	);
+}
+
+function resolveLocalSourcePath(source: string, cwd: string): string | undefined {
+	const trimmed = source.trim();
+	if (!trimmed) return undefined;
+	if (trimmed.startsWith("npm:")) return undefined;
+	if (parseGitUrl(trimmed)) return undefined;
+
+	let normalized = trimmed;
+	if (normalized === "~") {
+		normalized = homedir();
+	} else if (normalized.startsWith("~/")) {
+		normalized = join(homedir(), normalized.slice(2));
+	}
+
+	const absolutePath = resolve(cwd, normalized);
+	return existsSync(absolutePath) ? absolutePath : undefined;
+}
+
+async function resolveEntryPathsFromTarget(
+	options: PackageLifecycleHooksOptions,
+	target: LifecycleHooksTarget,
+	scope: LifecycleHookScope,
+): Promise<{ entryPaths: string[]; installedPath?: string }> {
+	if (target === "source") {
+		const localSourcePath = resolveLocalSourcePath(options.source, options.cwd);
+		if (!localSourcePath) return { entryPaths: [] };
+		const resolved = await options.packageManager.resolveExtensionSources([localSourcePath], { local: true });
+		const entryPaths = resolved.extensions.filter((resource) => resource.enabled).map((resource) => resource.path);
+		return { entryPaths, installedPath: localSourcePath };
+	}
+
+	const installedPath = options.packageManager.getInstalledPath(options.source, scope);
+	if (!installedPath) return { entryPaths: [] };
+	const resolved = await options.packageManager.resolveExtensionSources([installedPath], { local: true });
+	const entryPaths = resolved.extensions.filter((resource) => resource.enabled).map((resource) => resource.path);
+	return { entryPaths, installedPath };
+}
+
+export async function prepareLifecycleHooks(
+	options: PackageLifecycleHooksOptions,
+	target: LifecycleHooksTarget,
+	prepareOptions?: PrepareLifecycleHooksOptions,
+): Promise<LoadedLifecycleHooks | null> {
+	const scope = toScope(options.local);
+	const { entryPaths, installedPath } = await resolveEntryPathsFromTarget(options, target, scope);
+	if (entryPaths.length === 0) {
+		return null;
+	}
+
+	if (prepareOptions?.verifyRuntimeDependencies && installedPath) {
+		const runtimeDeps = collectRuntimeDependencies(installedPath, entryPaths);
+		verifyRuntimeDependencies(runtimeDeps, options.source, options.appName);
+	}
+
+	const loaded = await loadExtensions(entryPaths, options.cwd);
+	for (const { path, error } of loaded.errors) {
+		options.stderr.write(`[lifecycle-hooks] Failed to load extension "${path}": ${error}\n`);
+	}
+
+	const hooksByPath = new Map<string, LifecycleHookMap>();
+	for (const extension of loaded.extensions) {
+		hooksByPath.set(extension.path, extension.lifecycleHooks);
+	}
+
+	return {
+		source: options.source,
+		scope,
+		installedPath,
+		cwd: options.cwd,
+		stdout: options.stdout,
+		stderr: options.stderr,
+		entryPaths,
+		hooksByPath,
+	};
+}
+
+async function runHookSafe(
+	hook: LifecycleHookHandler,
+	context: LifecycleHookContext,
+	stderr: NodeJS.WriteStream,
+): Promise<boolean> {
+	try {
+		await hook(context);
+		return true;
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		stderr.write(`[lifecycle-hooks:${context.phase}] Hook failed: ${message}\n`);
+		return false;
+	}
+}
+
+function getLegacyExportCandidates(phase: LifecycleHookPhase): string[] {
+	return [phase];
+}
+
+async function runLegacyExportHook(
+	entryPath: string,
+	phase: LifecycleHookPhase,
+	context: LifecycleHookContext,
+): Promise<LifecycleHookHandler | null> {
+	try {
+		const module = await importExtensionModule<Record<string, unknown>>(import.meta.url, pathToFileURL(entryPath).href);
+		for (const exportName of getLegacyExportCandidates(phase)) {
+			const candidate = module[exportName];
+			if (typeof candidate === "function") {
+				return candidate as LifecycleHookHandler;
+			}
+		}
+		return null;
+	} catch {
+		return null;
+	}
+}
+
+export async function runLifecycleHooks(
+	loaded: LoadedLifecycleHooks | null,
+	phase: LifecycleHookPhase,
+): Promise<LifecycleHooksRunResult> {
+	if (!loaded) {
+		return {
+			phase,
+			hooksRun: 0,
+			hookErrors: 0,
+			legacyHooksRun: 0,
+			entryPathCount: 0,
+			skipped: true,
+		};
+	}
+
+	const context: LifecycleHookContext = {
+		phase,
+		source: loaded.source,
+		installedPath: loaded.installedPath,
+		scope: loaded.scope,
+		cwd: loaded.cwd,
+		interactive: Boolean(process.stdin.isTTY && process.stdout.isTTY),
+		log: (message) => loaded.stdout.write(`${message}\n`),
+		warn: (message) => loaded.stderr.write(`${message}\n`),
+		error: (message) => loaded.stderr.write(`${message}\n`),
+	};
+
+	let hooksRun = 0;
+	let hookErrors = 0;
+	let legacyHooksRun = 0;
+
+	for (const entryPath of loaded.entryPaths) {
+		const hookMap = loaded.hooksByPath.get(entryPath);
+		const registeredHooks = hookMap?.[phase] ?? [];
+		if (registeredHooks.length > 0) {
+			for (const hook of registeredHooks) {
+				hooksRun += 1;
+				const ok = await runHookSafe(hook, context, loaded.stderr);
+				if (!ok) hookErrors += 1;
+			}
+			continue;
+		}
+
+		const legacyHook = await runLegacyExportHook(entryPath, phase, context);
+		if (!legacyHook) continue;
+
+		legacyHooksRun += 1;
+		const ok = await runHookSafe(legacyHook, context, loaded.stderr);
+		if (!ok) hookErrors += 1;
+	}
+
+	return {
+		phase,
+		hooksRun,
+		hookErrors,
+		legacyHooksRun,
+		entryPathCount: loaded.entryPaths.length,
+		skipped: false,
+	};
+}

package/packages/pi-coding-agent/src/core/lsp/client.ts

@@ -24,6 +24,17 @@ const clients = new Map<string, LspClient>();
 const clientLocks = new Map<string, Promise<LspClient>>();
 const fileOperationLocks = new Map<string, Promise<void>>();
 
+/** Track stream listeners per client so they can be removed on shutdown. */
+interface StreamHandlers {
+	stdoutData?: (chunk: Buffer) => void;
+	stdoutEnd?: () => void;
+	stdoutError?: () => void;
+	stderrData?: (chunk: Buffer) => void;
+	stderrEnd?: () => void;
+	stderrError?: () => void;
+}
+const clientStreamHandlers = new Map<string, StreamHandlers>();
+
 // Idle timeout configuration (disabled by default)
 let idleTimeoutMs: number | null = null;
 let idleCheckInterval: ReturnType<typeof setInterval> | null = null;
@@ -257,7 +268,9 @@ async function startMessageReader(client: LspClient): Promise<void> {
 	}
 
 	return new Promise<void>((resolve) => {
-		stdout.on("data", async (chunk: Buffer) => {
+		const handlers = clientStreamHandlers.get(client.name) ?? {};
+
+		handlers.stdoutData = async (chunk: Buffer) => {
 			const currentBuffer: Buffer = Buffer.concat([client.messageBuffer, chunk]);
 
 			if (currentBuffer.length > MAX_MESSAGE_BUFFER_SIZE) {
@@ -307,17 +320,22 @@ async function startMessageReader(client: LspClient): Promise<void> {
 			}
 
 			client.messageBuffer = workingBuffer;
-		});
+		};
+		stdout.on("data", handlers.stdoutData);
 
-		stdout.on("end", () => {
+		handlers.stdoutEnd = () => {
 			client.isReading = false;
 			resolve();
-		});
+		};
+		stdout.on("end", handlers.stdoutEnd);
 
-		stdout.on("error", () => {
+		handlers.stdoutError = () => {
 			client.isReading = false;
 			resolve();
-		});
+		};
+		stdout.on("error", handlers.stdoutError);
+
+		clientStreamHandlers.set(client.name, handlers);
 	});
 }
 
@@ -402,21 +420,28 @@ async function startStderrReader(client: LspClient): Promise<void> {
 	if (!stderr) return;
 
 	return new Promise<void>((resolve) => {
-		stderr.on("data", (chunk: Buffer) => {
+		const handlers = clientStreamHandlers.get(client.name) ?? {};
+
+		handlers.stderrData = (chunk: Buffer) => {
 			const text = chunk.toString("utf-8");
 			client.stderrBuffer += text;
 			if (client.stderrBuffer.length > 4096) {
 				client.stderrBuffer = client.stderrBuffer.slice(-4096);
 			}
-		});
+		};
+		stderr.on("data", handlers.stderrData);
 
-		stderr.on("end", () => {
+		handlers.stderrEnd = () => {
 			resolve();
-		});
+		};
+		stderr.on("end", handlers.stderrEnd);
 
-		stderr.on("error", () => {
+		handlers.stderrError = () => {
 			resolve();
-		});
+		};
+		stderr.on("error", handlers.stderrError);
+
+		clientStreamHandlers.set(client.name, handlers);
 	});
 }
 
@@ -706,6 +731,23 @@ export function notifyFileChanged(filePath: string): void {
 	}
 }
 
+/**
+ * Remove stdout/stderr stream listeners for a client to prevent leaks.
+ */
+function removeStreamHandlers(client: LspClient): void {
+	const handlers = clientStreamHandlers.get(client.name);
+	if (!handlers) return;
+
+	if (handlers.stdoutData) client.proc.stdout?.removeListener("data", handlers.stdoutData);
+	if (handlers.stdoutEnd) client.proc.stdout?.removeListener("end", handlers.stdoutEnd);
+	if (handlers.stdoutError) client.proc.stdout?.removeListener("error", handlers.stdoutError);
+	if (handlers.stderrData) client.proc.stderr?.removeListener("data", handlers.stderrData);
+	if (handlers.stderrEnd) client.proc.stderr?.removeListener("end", handlers.stderrEnd);
+	if (handlers.stderrError) client.proc.stderr?.removeListener("error", handlers.stderrError);
+
+	clientStreamHandlers.delete(client.name);
+}
+
 /**
  * Shutdown a specific client by key.
  */
@@ -720,6 +762,9 @@ function shutdownClient(key: string): void {
 
 	sendRequest(client, "shutdown", null).catch(() => {});
 
+	// Remove stream listeners before killing the process
+	removeStreamHandlers(client);
+
 	try {
 		killProcessTree(client.proc.pid);
 	} catch {
@@ -860,6 +905,9 @@ function shutdownAll(): void {
 			pending.reject(err);
 		}
 
+		// Remove stream listeners before killing the process
+		removeStreamHandlers(client);
+
 		void (async () => {
 			const timeout = new Promise<void>(resolve => setTimeout(resolve, 5_000));
 			const result = sendRequest(client, "shutdown", null).catch(() => {});
@@ -893,14 +941,28 @@ export function getActiveClients(): LspServerStatus[] {
 // Process Cleanup
 // =============================================================================
 
+const _beforeExitHandler = () => shutdownAll();
+const _sigintHandler = () => {
+	shutdownAll();
+	process.exit(0);
+};
+const _sigtermHandler = () => {
+	shutdownAll();
+	process.exit(0);
+};
+
 if (typeof process !== "undefined") {
-	process.on("beforeExit", shutdownAll);
-	process.on("SIGINT", () => {
-		shutdownAll();
-		process.exit(0);
-	});
-	process.on("SIGTERM", () => {
-		shutdownAll();
-		process.exit(0);
-	});
+	process.on("beforeExit", _beforeExitHandler);
+	process.on("SIGINT", _sigintHandler);
+	process.on("SIGTERM", _sigtermHandler);
+}
+
+/**
+ * Remove process-level signal handlers registered at module load.
+ * Call this during graceful teardown to prevent leaked listeners.
+ */
+export function removeProcessHandlers(): void {
+	process.off("beforeExit", _beforeExitHandler);
+	process.off("SIGINT", _sigintHandler);
+	process.off("SIGTERM", _sigtermHandler);
 }