gsd-pi 2.43.0 → 2.44.0-dev.0b97ffd

package/src/resources/extensions/gsd/tests/post-unit-hooks.test.ts

@@ -1,9 +1,10 @@
 // GSD Extension — Hook Engine Tests (Post-Unit, Pre-Dispatch, State Persistence)
 
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
 import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync, readFileSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
-import { createTestContext } from "./test-helpers.ts";
 import {
   checkPostUnitHooks,
   getActiveHook,
@@ -20,8 +21,6 @@ import {
   triggerHookManually,
 } from "../post-unit-hooks.ts";
 
-const { assertEq, assertTrue, assertMatch, report } = createTestContext();
-
 // ─── Fixture Helpers ───────────────────────────────────────────────────────
 
 function createFixtureBase(): string {
@@ -36,14 +35,14 @@ function createFixtureBase(): string {
 
 // ─── resolveHookArtifactPath ───────────────────────────────────────────────
 
-console.log("\n=== resolveHookArtifactPath ===");
 
-{
+describe('post-unit-hooks', () => {
+test('resolveHookArtifactPath', () => {
   const base = "/project";
 
   // Task-level
   const taskPath = resolveHookArtifactPath(base, "M001/S01/T01", "REVIEW-PASS.md");
-  assertEq(
+  assert.deepStrictEqual(
     taskPath,
     join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks", "T01-REVIEW-PASS.md"),
     "task-level artifact path",
@@ -51,7 +50,7 @@ console.log("\n=== resolveHookArtifactPath ===");
 
   // Slice-level
   const slicePath = resolveHookArtifactPath(base, "M001/S01", "REVIEW-PASS.md");
-  assertEq(
+  assert.deepStrictEqual(
     slicePath,
     join(base, ".gsd", "milestones", "M001", "slices", "S01", "REVIEW-PASS.md"),
     "slice-level artifact path",
@@ -59,129 +58,106 @@ console.log("\n=== resolveHookArtifactPath ===");
 
   // Milestone-level
   const milestonePath = resolveHookArtifactPath(base, "M001", "REVIEW-PASS.md");
-  assertEq(
+  assert.deepStrictEqual(
     milestonePath,
     join(base, ".gsd", "milestones", "M001", "REVIEW-PASS.md"),
     "milestone-level artifact path",
   );
-}
+});
 
 // ─── resetHookState ────────────────────────────────────────────────────────
-
-console.log("\n=== resetHookState ===");
-
-{
+test('resetHookState', () => {
   resetHookState();
-  assertEq(getActiveHook(), null, "no active hook after reset");
-  assertTrue(!isRetryPending(), "no retry pending after reset");
-  assertEq(consumeRetryTrigger(), null, "no retry trigger after reset");
-}
+  assert.deepStrictEqual(getActiveHook(), null, "no active hook after reset");
+  assert.ok(!isRetryPending(), "no retry pending after reset");
+  assert.deepStrictEqual(consumeRetryTrigger(), null, "no retry trigger after reset");
+});
 
 // ─── checkPostUnitHooks with no hooks configured ───────────────────────────
-
-console.log("\n=== No hooks configured ===");
-
-{
+test('No hooks configured', () => {
   resetHookState();
   const base = createFixtureBase();
   try {
     const result = checkPostUnitHooks("execute-task", "M001/S01/T01", base);
-    assertEq(result, null, "returns null when no hooks configured");
+    assert.deepStrictEqual(result, null, "returns null when no hooks configured");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
 // ─── Hook units don't trigger hooks (no hook-on-hook) ──────────────────────
-
-console.log("\n=== Hook-on-hook prevention ===");
-
-{
+test('Hook-on-hook prevention', () => {
   resetHookState();
   const base = createFixtureBase();
   try {
     const result = checkPostUnitHooks("hook/code-review", "M001/S01/T01", base);
-    assertEq(result, null, "hook units don't trigger other hooks");
+    assert.deepStrictEqual(result, null, "hook units don't trigger other hooks");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
 // ─── consumeRetryTrigger clears state ──────────────────────────────────────
-
-console.log("\n=== consumeRetryTrigger clears state ===");
-
-{
+test('consumeRetryTrigger clears state', () => {
   resetHookState();
-  assertEq(consumeRetryTrigger(), null, "no trigger initially");
-  assertTrue(!isRetryPending(), "no retry initially");
-}
+  assert.deepStrictEqual(consumeRetryTrigger(), null, "no trigger initially");
+  assert.ok(!isRetryPending(), "no retry initially");
+});
 
 // ─── Variable substitution in prompts ──────────────────────────────────────
-
-console.log("\n=== Variable substitution ===");
-
-{
+test('Variable substitution', () => {
   const base = "/project";
 
   // 3-part ID
   const path3 = resolveHookArtifactPath(base, "M002/S03/T05", "result.md");
-  assertTrue(path3.includes("M002"), "3-part ID extracts milestoneId");
-  assertTrue(path3.includes("S03"), "3-part ID extracts sliceId");
-  assertTrue(path3.includes("T05"), "3-part ID extracts taskId");
-  assertTrue(path3.includes("milestones"), "3-part ID includes milestones/ segment");
+  assert.ok(path3.includes("M002"), "3-part ID extracts milestoneId");
+  assert.ok(path3.includes("S03"), "3-part ID extracts sliceId");
+  assert.ok(path3.includes("T05"), "3-part ID extracts taskId");
+  assert.ok(path3.includes("milestones"), "3-part ID includes milestones/ segment");
 
   // 2-part ID
   const path2 = resolveHookArtifactPath(base, "M002/S03", "result.md");
-  assertTrue(path2.includes("M002"), "2-part ID extracts milestoneId");
-  assertTrue(path2.includes("S03"), "2-part ID extracts sliceId");
-  assertTrue(path2.includes("milestones"), "2-part ID includes milestones/ segment");
+  assert.ok(path2.includes("M002"), "2-part ID extracts milestoneId");
+  assert.ok(path2.includes("S03"), "2-part ID extracts sliceId");
+  assert.ok(path2.includes("milestones"), "2-part ID includes milestones/ segment");
 
   // 1-part ID
   const path1 = resolveHookArtifactPath(base, "M002", "result.md");
-  assertTrue(path1.includes("M002"), "1-part ID extracts milestoneId");
-  assertTrue(path1.includes("milestones"), "1-part ID includes milestones/ segment");
-}
+  assert.ok(path1.includes("M002"), "1-part ID extracts milestoneId");
+  assert.ok(path1.includes("milestones"), "1-part ID includes milestones/ segment");
+});
 
 // ═══════════════════════════════════════════════════════════════════════════
 // Phase 2: Pre-Dispatch Hook Tests
 // ═══════════════════════════════════════════════════════════════════════════
-
-console.log("\n=== Pre-dispatch: no hooks configured ===");
-
-{
+test('Pre-dispatch: no hooks configured', () => {
   const base = createFixtureBase();
   try {
     const result = runPreDispatchHooks("execute-task", "M001/S01/T01", "original prompt", base);
-    assertEq(result.action, "proceed", "proceeds when no hooks");
-    assertEq(result.prompt, "original prompt", "prompt unchanged");
-    assertEq(result.firedHooks.length, 0, "no hooks fired");
+    assert.deepStrictEqual(result.action, "proceed", "proceeds when no hooks");
+    assert.deepStrictEqual(result.prompt, "original prompt", "prompt unchanged");
+    assert.deepStrictEqual(result.firedHooks.length, 0, "no hooks fired");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
-
-console.log("\n=== Pre-dispatch: hook units bypass ===");
+});
 
-{
+test('Pre-dispatch: hook units bypass', () => {
   const base = createFixtureBase();
   try {
     const result = runPreDispatchHooks("hook/review", "M001/S01/T01", "hook prompt", base);
-    assertEq(result.action, "proceed", "hook units always proceed");
-    assertEq(result.prompt, "hook prompt", "hook prompt unchanged");
-    assertEq(result.firedHooks.length, 0, "no hooks fired for hook units");
+    assert.deepStrictEqual(result.action, "proceed", "hook units always proceed");
+    assert.deepStrictEqual(result.prompt, "hook prompt", "hook prompt unchanged");
+    assert.deepStrictEqual(result.firedHooks.length, 0, "no hooks fired for hook units");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
 // ═══════════════════════════════════════════════════════════════════════════
 // Phase 3: State Persistence Tests
 // ═══════════════════════════════════════════════════════════════════════════
-
-console.log("\n=== State persistence: persist and restore ===");
-
-{
+test('State persistence: persist and restore', () => {
   const base = createFixtureBase();
   try {
     resetHookState();
@@ -189,19 +165,17 @@ console.log("\n=== State persistence: persist and restore ===");
     // Persist empty state
     persistHookState(base);
     const filePath = join(base, ".gsd", "hook-state.json");
-    assertTrue(existsSync(filePath), "hook-state.json created");
+    assert.ok(existsSync(filePath), "hook-state.json created");
 
     const content = JSON.parse(readFileSync(filePath, "utf-8"));
-    assertEq(typeof content.savedAt, "string", "savedAt is a string");
-    assertEq(Object.keys(content.cycleCounts).length, 0, "empty cycle counts");
+    assert.deepStrictEqual(typeof content.savedAt, "string", "savedAt is a string");
+    assert.deepStrictEqual(Object.keys(content.cycleCounts).length, 0, "empty cycle counts");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
-
-console.log("\n=== State persistence: restore from disk ===");
+});
 
-{
+test('State persistence: restore from disk', () => {
   const base = createFixtureBase();
   try {
     resetHookState();
@@ -222,16 +196,14 @@ console.log("\n=== State persistence: restore from disk ===");
     // Verify by persisting and reading back
     persistHookState(base);
     const restored = JSON.parse(readFileSync(stateFile, "utf-8"));
-    assertEq(restored.cycleCounts["review/execute-task/M001/S01/T01"], 2, "cycle count restored for review");
-    assertEq(restored.cycleCounts["simplify/execute-task/M001/S01/T02"], 1, "cycle count restored for simplify");
+    assert.deepStrictEqual(restored.cycleCounts["review/execute-task/M001/S01/T01"], 2, "cycle count restored for review");
+    assert.deepStrictEqual(restored.cycleCounts["simplify/execute-task/M001/S01/T02"], 1, "cycle count restored for simplify");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
-
-console.log("\n=== State persistence: clear ===");
+});
 
-{
+test('State persistence: clear', () => {
   const base = createFixtureBase();
   try {
     resetHookState();
@@ -246,77 +218,65 @@ console.log("\n=== State persistence: clear ===");
     clearPersistedHookState(base);
 
     const cleared = JSON.parse(readFileSync(stateFile, "utf-8"));
-    assertEq(Object.keys(cleared.cycleCounts).length, 0, "cycle counts cleared");
+    assert.deepStrictEqual(Object.keys(cleared.cycleCounts).length, 0, "cycle counts cleared");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
-console.log("\n=== State persistence: restore handles missing file ===");
-
-{
+test('State persistence: restore handles missing file', () => {
   const base = createFixtureBase();
   try {
     resetHookState();
     // Should not throw
     restoreHookState(base);
-    assertEq(getActiveHook(), null, "no active hook after restore from missing file");
+    assert.deepStrictEqual(getActiveHook(), null, "no active hook after restore from missing file");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
-console.log("\n=== State persistence: restore handles corrupt file ===");
-
-{
+test('State persistence: restore handles corrupt file', () => {
   const base = createFixtureBase();
   try {
     resetHookState();
     writeFileSync(join(base, ".gsd", "hook-state.json"), "not json", "utf-8");
     // Should not throw
     restoreHookState(base);
-    assertEq(getActiveHook(), null, "no active hook after corrupt restore");
+    assert.deepStrictEqual(getActiveHook(), null, "no active hook after corrupt restore");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
 // ═══════════════════════════════════════════════════════════════════════════
 // Phase 3: Hook Status Reporting Tests
 // ═══════════════════════════════════════════════════════════════════════════
-
-console.log("\n=== Hook status: no hooks ===");
-
-{
+test('Hook status: no hooks', () => {
   resetHookState();
   const entries = getHookStatus();
   // No preferences file = no hooks
-  assertEq(entries.length, 0, "no entries when no hooks configured");
+  assert.deepStrictEqual(entries.length, 0, "no entries when no hooks configured");
 
   const formatted = formatHookStatus();
-  assertMatch(formatted, /No hooks configured/, "status message says no hooks");
-}
+  assert.match(formatted, /No hooks configured/, "status message says no hooks");
+});
 
 // ═══════════════════════════════════════════════════════════════════════════
 // Phase 4: Manual Hook Trigger Tests
 // ═══════════════════════════════════════════════════════════════════════════
-
-console.log("\n=== triggerHookManually: hook not found ===");
-
-{
+test('triggerHookManually: hook not found', () => {
   resetHookState();
   const base = createFixtureBase();
   try {
     const result = triggerHookManually("nonexistent-hook", "execute-task", "M001/S01/T01", base);
-    assertEq(result, null, "returns null when hook not found");
+    assert.deepStrictEqual(result, null, "returns null when hook not found");
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
-console.log("\n=== triggerHookManually: with configured hook ===");
-
-{
+test('triggerHookManually: with configured hook', () => {
   resetHookState();
   const base = createFixtureBase();
   try {
@@ -325,16 +285,16 @@ console.log("\n=== triggerHookManually: with configured hook ===");
     const result = triggerHookManually("code-review", "execute-task", "M001/S01/T01", base);
     // Result depends on whether code-review hook is configured in preferences
     // The function should either return null or a valid HookDispatchResult
-    assertTrue(result === null || typeof result === "object", "returns null or object");
+    assert.ok(result === null || typeof result === "object", "returns null or object");
     if (result) {
-      assertEq(result.hookName, "code-review", "hook name in result");
-      assertEq(result.unitType, "hook/code-review", "unit type is hook-prefixed");
-      assertEq(result.unitId, "M001/S01/T01", "unit ID preserved");
-      assertTrue(typeof result.prompt === "string", "prompt is a string");
+      assert.deepStrictEqual(result.hookName, "code-review", "hook name in result");
+      assert.deepStrictEqual(result.unitType, "hook/code-review", "unit type is hook-prefixed");
+      assert.deepStrictEqual(result.unitId, "M001/S01/T01", "unit ID preserved");
+      assert.ok(typeof result.prompt === "string", "prompt is a string");
     }
   } finally {
     rmSync(base, { recursive: true, force: true });
   }
-}
+});
 
-report();
+});

package/src/resources/extensions/gsd/tests/prompt-contracts.test.ts

@@ -57,3 +57,142 @@ test("guided-resume-task prompt preserves recovery state until work is supersede
   assert.match(prompt, /successfully completed or you have written a newer summary\/continue artifact/i);
   assert.doesNotMatch(prompt, /Delete the continue file after reading it/i);
 });
+
+// ─── Prompt migration: execute-task → gsd_task_complete ───────────────
+
+test("execute-task prompt references gsd_task_complete tool", () => {
+  const prompt = readPrompt("execute-task");
+  assert.match(prompt, /gsd_task_complete/);
+});
+
+test("execute-task prompt does not instruct LLM to write summary file manually", () => {
+  const prompt = readPrompt("execute-task");
+  // Should not contain "Write {{taskSummaryPath}}" as an action instruction
+  assert.doesNotMatch(prompt, /^\d+\.\s+Write `?\{\{taskSummaryPath\}\}`?/m);
+});
+
+test("execute-task prompt does not instruct LLM to toggle checkboxes manually", () => {
+  const prompt = readPrompt("execute-task");
+  assert.doesNotMatch(prompt, /change \[ \] to \[x\]/);
+  assert.doesNotMatch(prompt, /Mark \{\{taskId\}\} done in/);
+});
+
+test("execute-task prompt still contains template variables for context", () => {
+  const prompt = readPrompt("execute-task");
+  assert.match(prompt, /\{\{taskSummaryPath\}\}/);
+  assert.match(prompt, /\{\{planPath\}\}/);
+});
+
+test("guided-execute-task prompt references gsd_task_complete tool", () => {
+  const prompt = readPrompt("guided-execute-task");
+  assert.match(prompt, /gsd_task_complete/);
+});
+
+test("guided-execute-task prompt does not instruct manual file write", () => {
+  const prompt = readPrompt("guided-execute-task");
+  assert.doesNotMatch(prompt, /Write `?\{\{taskId\}\}-SUMMARY\.md`?.*mark it done/i);
+});
+
+// ─── Prompt migration: complete-slice → gsd_slice_complete ────────────
+// These tests are for T02 — expected to fail until that task runs.
+
+test("complete-slice prompt references gsd_slice_complete tool", () => {
+  const prompt = readPrompt("complete-slice");
+  assert.match(prompt, /gsd_slice_complete/);
+});
+
+test("complete-slice prompt does not instruct LLM to toggle checkboxes manually", () => {
+  const prompt = readPrompt("complete-slice");
+  assert.doesNotMatch(prompt, /change \[ \] to \[x\]/);
+});
+
+test("guided-complete-slice prompt references gsd_slice_complete tool", () => {
+  const prompt = readPrompt("guided-complete-slice");
+  assert.match(prompt, /gsd_slice_complete/);
+});
+
+test("complete-slice prompt does not instruct LLM to write summary/UAT files manually", () => {
+  const prompt = readPrompt("complete-slice");
+  assert.doesNotMatch(prompt, /^\d+\.\s+Write `?\{\{sliceSummaryPath\}\}/m);
+  assert.doesNotMatch(prompt, /^\d+\.\s+Write `?\{\{sliceUatPath\}\}/m);
+});
+
+test("complete-slice prompt preserves decisions and knowledge review steps", () => {
+  const prompt = readPrompt("complete-slice");
+  assert.match(prompt, /DECISIONS\.md/);
+  assert.match(prompt, /KNOWLEDGE\.md/);
+});
+
+test("complete-slice prompt still contains template variables for context", () => {
+  const prompt = readPrompt("complete-slice");
+  assert.match(prompt, /\{\{sliceSummaryPath\}\}/);
+  assert.match(prompt, /\{\{sliceUatPath\}\}/);
+  assert.match(prompt, /\{\{roadmapPath\}\}/);
+});
+
+test("plan-milestone prompt references DB-backed planning tool and explicitly forbids manual roadmap writes", () => {
+  const prompt = readPrompt("plan-milestone");
+  assert.match(prompt, /gsd_plan_milestone/);
+  assert.match(prompt, /Do \*\*not\*\* write `?\{\{outputPath\}\}`?, `?ROADMAP\.md`?, or other planning artifacts manually/i);
+});
+
+test("guided-plan-milestone prompt references DB-backed planning tool and explicitly forbids manual roadmap writes", () => {
+  const prompt = readPrompt("guided-plan-milestone");
+  assert.match(prompt, /gsd_plan_milestone/);
+  assert.match(prompt, /Do \*\*not\*\* write `?\{\{milestoneId\}\}-ROADMAP\.md`?, `?ROADMAP\.md`?, or other planning artifacts manually/i);
+});
+
+test("plan-slice prompt no longer frames direct PLAN writes as the source of truth", () => {
+  const prompt = readPrompt("plan-slice");
+  assert.match(prompt, /Do \*\*not\*\* rely on direct `PLAN\.md` writes as the source of truth/i);
+});
+
+test("plan-slice prompt explicitly names gsd_plan_slice and gsd_plan_task as DB-backed planning tools", () => {
+  const prompt = readPrompt("plan-slice");
+  assert.match(prompt, /gsd_plan_slice/);
+  assert.match(prompt, /gsd_plan_task/);
+  // The prompt should describe these as the canonical write path
+  assert.match(prompt, /DB-backed tools are the canonical write path/i);
+});
+
+test("plan-slice prompt does not instruct direct file writes as a primary step", () => {
+  const prompt = readPrompt("plan-slice");
+  // Should not instruct to "Write {{outputPath}}" as a primary step — tools handle rendering
+  assert.doesNotMatch(prompt, /^\d+\.\s+Write `?\{\{outputPath\}\}`?\s*$/m);
+});
+
+test("plan-slice prompt instructs calling gsd_plan_task for each task", () => {
+  const prompt = readPrompt("plan-slice");
+  assert.match(prompt, /call `gsd_plan_task` for each task/i);
+});
+
+test("replan-slice prompt requires DB-backed planning state when available", () => {
+  const prompt = readPrompt("replan-slice");
+  assert.match(prompt, /DB-backed planning tool exists for this phase, use it as the source of truth/i);
+});
+
+test("reassess-roadmap prompt references gsd_reassess_roadmap tool", () => {
+  const prompt = readPrompt("reassess-roadmap");
+  assert.match(prompt, /gsd_reassess_roadmap/);
+});
+
+// ─── Prompt migration: replan-slice → gsd_replan_slice ────────────────
+
+test("replan-slice prompt names gsd_replan_slice as the tool to use", () => {
+  const prompt = readPrompt("replan-slice");
+  assert.match(prompt, /gsd_replan_slice/);
+});
+
+// ─── Prompt migration: reassess-roadmap → gsd_reassess_roadmap ───────
+
+test("reassess-roadmap prompt names gsd_reassess_roadmap as the tool to use", () => {
+  const prompt = readPrompt("reassess-roadmap");
+  assert.match(prompt, /gsd_reassess_roadmap/);
+});
+
+test("reactive-execute prompt references tool calls instead of checkbox updates", () => {
+  const prompt = readPrompt("reactive-execute");
+  assert.doesNotMatch(prompt, /checkbox updates/);
+  assert.doesNotMatch(prompt, /checkbox edits/);
+  assert.match(prompt, /completion tool calls/);
+});