gsd-pi 2.33.0-dev.bafba33 → 2.33.1-dev.235d83a

package/dist/resources/extensions/gsd/tests/session-lock.test.ts

@@ -1,315 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdirSync, mkdtempSync, writeFileSync, existsSync, readFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  acquireSessionLock,
-  releaseSessionLock,
-  updateSessionLock,
-  validateSessionLock,
-  readSessionLockData,
-  isSessionLockHeld,
-  isSessionLockProcessAlive,
-} from "../session-lock.ts";
-
-// ─── acquireSessionLock ──────────────────────────────────────────────────
-
-test("acquireSessionLock succeeds on empty directory", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true, "should acquire lock on empty dir");
-
-  // Verify lock file was created with correct data
-  const lockPath = join(dir, ".gsd", "auto.lock");
-  assert.ok(existsSync(lockPath), "auto.lock should exist after acquire");
-
-  const data = JSON.parse(readFileSync(lockPath, "utf-8"));
-  assert.equal(data.pid, process.pid, "lock should contain current PID");
-  assert.equal(data.unitType, "starting", "initial unit type should be 'starting'");
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("acquireSessionLock rejects when another live process holds lock", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  // Simulate another process holding the lock by writing a lock with parent PID
-  const fakeLockData = {
-    pid: process.ppid,
-    startedAt: new Date().toISOString(),
-    unitType: "execute-task",
-    unitId: "M001/S01/T01",
-    unitStartedAt: new Date().toISOString(),
-    completedUnits: 2,
-  };
-  writeFileSync(join(dir, ".gsd", "auto.lock"), JSON.stringify(fakeLockData, null, 2));
-
-  // First acquire to set up proper-lockfile state
-  const result1 = acquireSessionLock(dir);
-
-  // If proper-lockfile is available, it should manage the OS lock.
-  // If not (fallback mode), the PID check should detect the live process.
-  // Either way, we can't fully simulate another process holding an OS lock
-  // from within the same process, so we test the fallback path.
-  if (result1.acquired) {
-    // We got the lock (proper-lockfile saw no OS lock from another process)
-    // This is expected since we're in the same process
-    releaseSessionLock(dir);
-  }
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("acquireSessionLock takes over stale lock from dead process", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  // Write a lock from a dead process
-  const staleLockData = {
-    pid: 9999999,
-    startedAt: "2026-03-01T00:00:00Z",
-    unitType: "execute-task",
-    unitId: "M001/S01/T01",
-    unitStartedAt: "2026-03-01T00:00:00Z",
-    completedUnits: 0,
-  };
-  writeFileSync(join(dir, ".gsd", "auto.lock"), JSON.stringify(staleLockData, null, 2));
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true, "should take over lock from dead process");
-
-  // Verify our PID is now in the lock
-  const data = readSessionLockData(dir);
-  assert.ok(data, "lock data should exist after acquire");
-  assert.equal(data!.pid, process.pid, "lock should contain our PID now");
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── releaseSessionLock ─────────────────────────────────────────────────
-
-test("releaseSessionLock removes the lock file", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true);
-
-  releaseSessionLock(dir);
-
-  const lockPath = join(dir, ".gsd", "auto.lock");
-  assert.ok(!existsSync(lockPath), "auto.lock should be removed after release");
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("releaseSessionLock is safe when no lock exists", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  // Should not throw
-  releaseSessionLock(dir);
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── updateSessionLock ──────────────────────────────────────────────────
-
-test("updateSessionLock updates the lock data without re-acquiring", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true);
-
-  updateSessionLock(dir, "execute-task", "M001/S01/T02", 3, "/tmp/session.jsonl");
-
-  const data = readSessionLockData(dir);
-  assert.ok(data, "lock data should exist after update");
-  assert.equal(data!.pid, process.pid, "PID should still be ours");
-  assert.equal(data!.unitType, "execute-task", "unit type should be updated");
-  assert.equal(data!.unitId, "M001/S01/T02", "unit ID should be updated");
-  assert.equal(data!.completedUnits, 3, "completed count should be updated");
-  assert.equal(data!.sessionFile, "/tmp/session.jsonl", "session file should be recorded");
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── validateSessionLock ────────────────────────────────────────────────
-
-test("validateSessionLock returns true when we hold the lock", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true);
-
-  assert.equal(validateSessionLock(dir), true, "should validate when we hold the lock");
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("validateSessionLock returns false after release", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true);
-  assert.equal(validateSessionLock(dir), true, "should be valid while held");
-
-  // Release the lock — both OS lock and lock file are removed
-  releaseSessionLock(dir);
-
-  // After release, _lockedPath is cleared and lock file is gone
-  assert.equal(isSessionLockHeld(dir), false, "should not be held after release");
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("validateSessionLock returns false when another PID owns the lock", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  // Write lock data with a different PID (parent process)
-  const foreignLockData = {
-    pid: process.ppid,
-    startedAt: new Date().toISOString(),
-    unitType: "execute-task",
-    unitId: "M001/S01/T01",
-    unitStartedAt: new Date().toISOString(),
-    completedUnits: 0,
-  };
-  writeFileSync(join(dir, ".gsd", "auto.lock"), JSON.stringify(foreignLockData, null, 2));
-
-  // Without holding the OS lock, validate should check PID
-  assert.equal(validateSessionLock(dir), false, "should fail when another PID owns lock");
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── isSessionLockHeld ──────────────────────────────────────────────────
-
-test("isSessionLockHeld returns true after acquire", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  acquireSessionLock(dir);
-  assert.equal(isSessionLockHeld(dir), true);
-
-  releaseSessionLock(dir);
-  assert.equal(isSessionLockHeld(dir), false, "should return false after release");
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── isSessionLockProcessAlive ──────────────────────────────────────────
-
-test("isSessionLockProcessAlive returns false for dead PID", () => {
-  const data = {
-    pid: 9999999,
-    startedAt: new Date().toISOString(),
-    unitType: "starting",
-    unitId: "bootstrap",
-    unitStartedAt: new Date().toISOString(),
-    completedUnits: 0,
-  };
-  assert.equal(isSessionLockProcessAlive(data), false);
-});
-
-test("isSessionLockProcessAlive returns false for own PID (recycled)", () => {
-  const data = {
-    pid: process.pid,
-    startedAt: new Date().toISOString(),
-    unitType: "starting",
-    unitId: "bootstrap",
-    unitStartedAt: new Date().toISOString(),
-    completedUnits: 0,
-  };
-  // Own PID returns false because it means the lock is from a recycled PID
-  assert.equal(isSessionLockProcessAlive(data), false);
-});
-
-// ─── readSessionLockData ────────────────────────────────────────────────
-
-test("readSessionLockData returns null when no lock exists", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const data = readSessionLockData(dir);
-  assert.equal(data, null);
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("readSessionLockData reads existing lock data", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  const lockData = {
-    pid: 12345,
-    startedAt: "2026-03-18T00:00:00Z",
-    unitType: "execute-task",
-    unitId: "M001/S01/T01",
-    unitStartedAt: "2026-03-18T00:01:00Z",
-    completedUnits: 2,
-    sessionFile: "/tmp/session.jsonl",
-  };
-  writeFileSync(join(dir, ".gsd", "auto.lock"), JSON.stringify(lockData, null, 2));
-
-  const data = readSessionLockData(dir);
-  assert.ok(data, "should read lock data");
-  assert.equal(data!.pid, 12345);
-  assert.equal(data!.unitType, "execute-task");
-  assert.equal(data!.unitId, "M001/S01/T01");
-  assert.equal(data!.completedUnits, 2);
-  assert.equal(data!.sessionFile, "/tmp/session.jsonl");
-
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── Acquire → Release → Re-Acquire lifecycle ──────────────────────────
-
-test("session lock supports acquire → release → re-acquire cycle", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-  // First acquire
-  const r1 = acquireSessionLock(dir);
-  assert.equal(r1.acquired, true, "first acquire should succeed");
-  assert.equal(isSessionLockHeld(dir), true);
-
-  // Release
-  releaseSessionLock(dir);
-  assert.equal(isSessionLockHeld(dir), false);
-
-  // Re-acquire
-  const r2 = acquireSessionLock(dir);
-  assert.equal(r2.acquired, true, "re-acquire after release should succeed");
-  assert.equal(isSessionLockHeld(dir), true);
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ─── Lock creates .gsd/ directory if needed ─────────────────────────────
-
-test("acquireSessionLock creates .gsd/ if it does not exist", () => {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-session-lock-"));
-  // Do NOT create .gsd/ — let the lock function do it
-
-  const result = acquireSessionLock(dir);
-  assert.equal(result.acquired, true, "should succeed even without .gsd/");
-  assert.ok(existsSync(join(dir, ".gsd")), ".gsd/ should be created");
-
-  releaseSessionLock(dir);
-  rmSync(dir, { recursive: true, force: true });
-});

package/dist/resources/extensions/gsd/tests/skill-lifecycle.test.ts

@@ -1,126 +0,0 @@
-/**
- * Tests for skill telemetry and skill health (#599).
- * Tests the pure functions — no file I/O, no extension context.
- */
-
-import { describe, it, beforeEach } from "node:test";
-import assert from "node:assert/strict";
-import type { UnitMetrics } from "../metrics.js";
-
-// ─── Test helpers ─────────────────────────────────────────────────────────────
-
-function makeUnit(overrides: Partial<UnitMetrics> = {}): UnitMetrics {
-  return {
-    type: "execute-task",
-    id: "M001/S01/T01",
-    model: "claude-sonnet-4-20250514",
-    startedAt: 1000,
-    finishedAt: 2000,
-    tokens: { input: 1000, output: 500, cacheRead: 200, cacheWrite: 100, total: 1800 },
-    cost: 0.05,
-    toolCalls: 3,
-    assistantMessages: 5,
-    userMessages: 2,
-    ...overrides,
-  };
-}
-
-// ─── Skill Telemetry ──────────────────────────────────────────────────────────
-
-describe("skill-telemetry", () => {
-  // Note: captureAvailableSkills/getAndClearSkills depend on filesystem (getAgentDir)
-  // so we test the data flow via getSkillLastUsed and detectStaleSkills which are pure
-
-  it("getSkillLastUsed returns most recent timestamp per skill", async () => {
-    const { getSkillLastUsed } = await import("../skill-telemetry.js");
-
-    const units = [
-      makeUnit({ finishedAt: 1000, skills: ["rust-core", "axum-web-framework"] }),
-      makeUnit({ finishedAt: 2000, skills: ["rust-core"] }),
-      makeUnit({ finishedAt: 3000, skills: ["axum-web-framework"] }),
-    ];
-
-    const result = getSkillLastUsed(units);
-    assert.equal(result.get("rust-core"), 2000);
-    assert.equal(result.get("axum-web-framework"), 3000);
-  });
-
-  it("getSkillLastUsed returns empty map for units without skills", async () => {
-    const { getSkillLastUsed } = await import("../skill-telemetry.js");
-
-    const units = [makeUnit(), makeUnit()];
-    const result = getSkillLastUsed(units);
-    assert.equal(result.size, 0);
-  });
-});
-
-// ─── Skill Health ─────────────────────────────────────────────────────────────
-
-describe("skill-health", () => {
-  it("buildHealSkillPrompt includes unit ID", async () => {
-    const { buildHealSkillPrompt } = await import("../skill-health.js");
-    const prompt = buildHealSkillPrompt("M001/S01/T01");
-    assert.ok(prompt.includes("M001/S01/T01"));
-    assert.ok(prompt.includes("Skill Heal Analysis"));
-    assert.ok(prompt.includes("skill-review-queue.md"));
-  });
-
-  it("computeStaleAvoidList excludes already-avoided skills", async () => {
-    // This test requires filesystem access for loadLedgerFromDisk
-    // so we test the filtering logic conceptually
-    const { computeStaleAvoidList } = await import("../skill-health.js");
-
-    // With no metrics file, should return empty
-    const result = computeStaleAvoidList("/nonexistent/path", ["some-skill"]);
-    assert.ok(Array.isArray(result));
-  });
-});
-
-// ─── UnitMetrics skills field ─────────────────────────────────────────────────
-
-describe("UnitMetrics skills field", () => {
-  it("skills field is optional and accepts string array", () => {
-    const unit = makeUnit({ skills: ["rust-core", "axum-web-framework"] });
-    assert.deepEqual(unit.skills, ["rust-core", "axum-web-framework"]);
-  });
-
-  it("skills field is undefined when not provided", () => {
-    const unit = makeUnit();
-    assert.equal(unit.skills, undefined);
-  });
-});
-
-// ─── Preferences ──────────────────────────────────────────────────────────────
-
-describe("skill_staleness_days preference", () => {
-  it("validates valid staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 30 });
-    assert.equal(result.preferences.skill_staleness_days, 30);
-    assert.equal(result.errors.length, 0);
-  });
-
-  it("validates zero (disabled) staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 0 });
-    assert.equal(result.preferences.skill_staleness_days, 0);
-    assert.equal(result.errors.length, 0);
-  });
-
-  it("rejects negative staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: -5 });
-    assert.equal(result.preferences.skill_staleness_days, undefined);
-    assert.ok(result.errors.some(e => e.includes("skill_staleness_days")));
-  });
-
-  it("floors fractional days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 30.7 });
-    assert.equal(result.preferences.skill_staleness_days, 30);
-  });
-});

package/dist/resources/extensions/gsd/tests/smart-entry-draft.test.ts

@@ -1,123 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.js";
-import { resolveMilestoneFile } from "../paths.js";
-
-let passed = 0;
-let failed = 0;
-
-function assert(condition: boolean, message: string): void {
-  if (condition) {
-    passed++;
-  } else {
-    failed++;
-    console.error(`  FAIL: ${message}`);
-  }
-}
-
-// ─── Fixture: milestone with only CONTEXT-DRAFT.md ──────────────────────
-
-const tmpBase = mkdtempSync(join(tmpdir(), "gsd-smart-entry-draft-test-"));
-const gsd = join(tmpBase, ".gsd");
-
-mkdirSync(join(gsd, "milestones", "M001"), { recursive: true });
-
-const draftContent = `# M001: Test Milestone — Context\n\n**Status:** Draft\n\nSeed material from a prior discussion.\n`;
-writeFileSync(
-  join(gsd, "milestones", "M001", "M001-CONTEXT-DRAFT.md"),
-  draftContent,
-);
-
-// ─── Test: deriveState returns 'needs-discussion' for draft-only milestone ───
-
-const state = await deriveState(tmpBase);
-
-assert(
-  state.phase === "needs-discussion",
-  `phase should be 'needs-discussion' for draft-only milestone, got: "${state.phase}"`,
-);
-
-assert(
-  state.activeMilestone?.id === "M001",
-  `active milestone should be M001, got: "${state.activeMilestone?.id}"`,
-);
-
-// ─── Test: resolveMilestoneFile resolves CONTEXT-DRAFT ─────────────────────
-
-const draftFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT-DRAFT");
-
-assert(
-  draftFile !== null && draftFile !== undefined,
-  `resolveMilestoneFile should resolve CONTEXT-DRAFT, got: ${draftFile}`,
-);
-
-assert(
-  draftFile!.endsWith("M001-CONTEXT-DRAFT.md"),
-  `resolved path should end with M001-CONTEXT-DRAFT.md, got: "${draftFile}"`,
-);
-
-// ─── Test: CONTEXT.md is NOT resolved (only draft exists) ──────────────────
-
-const contextFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT");
-
-assert(
-  contextFile === null || contextFile === undefined,
-  `resolveMilestoneFile should NOT resolve CONTEXT when only CONTEXT-DRAFT exists, got: "${contextFile}"`,
-);
-
-// ─── Static: guided-flow.ts has 'needs-discussion' branch ─────────────────
-
-const guidedFlowSource = readFileSync(
-  join(import.meta.dirname, "..", "guided-flow.ts"),
-  "utf-8",
-);
-
-assert(
-  guidedFlowSource.includes('state.phase === "needs-discussion"'),
-  "guided-flow.ts should have 'needs-discussion' phase check in showSmartEntry",
-);
-
-// Check the branch has draft-aware menu options
-const branchIdx = guidedFlowSource.indexOf('state.phase === "needs-discussion"');
-const branchChunk = guidedFlowSource.slice(branchIdx, branchIdx + 4000);
-
-assert(
-  branchChunk.includes("discuss_draft"),
-  "needs-discussion branch should have 'discuss_draft' option",
-);
-
-assert(
-  branchChunk.includes("discuss_fresh"),
-  "needs-discussion branch should have 'discuss_fresh' option",
-);
-
-assert(
-  branchChunk.includes("skip_milestone"),
-  "needs-discussion branch should have 'skip_milestone' option",
-);
-
-assert(
-  branchChunk.includes("CONTEXT-DRAFT"),
-  "needs-discussion branch should load CONTEXT-DRAFT via resolveMilestoneFile",
-);
-
-assert(
-  branchChunk.includes("Draft Seed") || branchChunk.includes("draftContent"),
-  "discuss_draft path should include draft content as seed in the dispatched prompt",
-);
-
-assert(
-  branchChunk.includes("return"),
-  "needs-discussion branch should return early (not fall through to generic no-roadmap menu)",
-);
-
-// ─── Cleanup ──────────────────────────────────────────────────────────────
-
-rmSync(tmpBase, { recursive: true, force: true });
-
-// ─── Results ──────────────────────────────────────────────────────────────
-
-console.log(`\nsmart-entry-draft: ${passed} passed, ${failed} failed`);
-if (failed > 0) process.exit(1);