gsd-pi 2.28.0 → 2.29.0-dev.7612840

package/packages/pi-coding-agent/src/core/constants.ts

@@ -0,0 +1,59 @@
+/**
+ * Centralized configuration constants for the coding agent.
+ *
+ * Values grouped by subsystem. Each constant documents where it is consumed
+ * so that changes can be audited in one place.
+ */
+
+// =============================================================================
+// Timeouts
+// =============================================================================
+
+/** Shell command execution timeout used by resolve-config-value. */
+export const COMMAND_EXECUTION_TIMEOUT_MS = 10_000;
+
+/** LSP server liveness check timeout (lspmux). */
+export const LSP_LIVENESS_TIMEOUT_MS = 1_000;
+
+/** Staleness threshold for the async auth-storage file lock. */
+export const AUTH_LOCK_STALE_MS = 30_000;
+
+// =============================================================================
+// Caches
+// =============================================================================
+
+/** TTL for the cached lspmux state detection result. */
+export const LSP_STATE_CACHE_TTL_MS = 5 * 60 * 1_000;
+
+// =============================================================================
+// Compaction & Summarization
+// =============================================================================
+
+/** Tokens reserved for the LLM prompt + response during compaction and branch summarization. */
+export const COMPACTION_RESERVE_TOKENS = 16_384;
+
+/** Tokens from the tail of the conversation kept verbatim after compaction. */
+export const COMPACTION_KEEP_RECENT_TOKENS = 20_000;
+
+/** Max characters kept per tool-result block when serializing for summarization. */
+export const TOOL_RESULT_MAX_CHARS = 2_000;
+
+// =============================================================================
+// Retry
+// =============================================================================
+
+/** Base delay for exponential back-off retries (2 s, 4 s, 8 s ...). */
+export const RETRY_BASE_DELAY_MS = 2_000;
+
+/** Maximum server-requested delay before the retry loop gives up. */
+export const RETRY_MAX_DELAY_MS = 300_000;
+
+// =============================================================================
+// Tool Defaults
+// =============================================================================
+
+/** Default result-count cap for the find/glob tool. */
+export const FIND_DEFAULT_LIMIT = 1_000;
+
+/** Default line-count cap for tool-output truncation. */
+export const TRUNCATE_DEFAULT_MAX_LINES = 2_000;

package/packages/pi-coding-agent/src/core/extensions/loader.ts

@@ -105,7 +105,7 @@ function getAliases(): Record<string, string> {
 	return _aliases;
 }
 
-const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
+const UNICODE_SPACES = /[\u00A0\u1680\u2000-\u200A\u202F\u205F\u3000]/g;
 
 function normalizeUnicodeSpaces(str: string): string {
 	return str.replace(UNICODE_SPACES, " ");

package/packages/pi-coding-agent/src/core/lsp/index.ts

@@ -14,7 +14,7 @@ import {
 	setIdleTimeout,
 	WARMUP_TIMEOUT_MS,
 } from "./client.js";
-import { getServersForFile, type LspConfig, loadConfig } from "./config.js";
+import { getServersForFile, type LspConfig, loadConfig, hasRootMarkers, resolveCommand } from "./config.js";
 import { applyTextEdits, applyWorkspaceEdit } from "./edits.js";
 import { ToolAbortError, clampTimeout, throwIfAborted } from "./helpers.js";
 import { detectLspmux } from "./lspmux.js";
@@ -370,10 +370,36 @@ export function createLspTool(cwd: string): AgentTool<typeof lspSchema, LspToolD
 						: "lspmux: installed but server not running"
 					: "";
 
-				const serverStatus =
-					servers.length > 0
-						? `Active language servers: ${servers.join(", ")}`
-						: "No language servers configured for this project";
+				let serverStatus: string;
+				if (servers.length > 0) {
+					serverStatus = `Active language servers: ${servers.join(", ")}`;
+				} else {
+					// Diagnose why no servers were detected
+					const DEFAULTS = (await import("./defaults.json", { with: { type: "json" } })).default as Record<string, { command: string; rootMarkers: string[] }>;
+					const diagnostics: string[] = ["No language servers configured for this project."];
+					const matchedButMissing: string[] = [];
+					const noMarkers: string[] = [];
+
+					for (const [name, def] of Object.entries(DEFAULTS)) {
+						if (hasRootMarkers(cwd, def.rootMarkers)) {
+							const resolved = resolveCommand(def.command, cwd);
+							if (!resolved) {
+								matchedButMissing.push(`  ${name}: project detected (${def.rootMarkers[0]}) but '${def.command}' not found — install it with npm/pip/brew`);
+							}
+						}
+					}
+
+					if (matchedButMissing.length > 0) {
+						diagnostics.push("\nDetected projects missing language servers:");
+						diagnostics.push(...matchedButMissing);
+						diagnostics.push("\nInstall the missing server command and restart GSD, or run: lsp reload");
+					} else {
+						diagnostics.push("No recognized project markers found in the working directory.");
+						diagnostics.push("LSP auto-detects projects via files like package.json, Cargo.toml, go.mod, pyproject.toml, etc.");
+					}
+
+					serverStatus = diagnostics.join("\n");
+				}
 
 				const output = lspmuxStatus ? `${serverStatus}\n${lspmuxStatus}` : serverStatus;
 				return {

package/packages/pi-coding-agent/src/core/lsp/lspmux.ts

@@ -2,6 +2,7 @@ import { execSync, spawn } from "node:child_process";
 import * as fsPromises from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
+import { LSP_LIVENESS_TIMEOUT_MS, LSP_STATE_CACHE_TTL_MS } from "../constants.js";
 
 /**
  * lspmux integration for LSP server multiplexing.
@@ -41,8 +42,6 @@ const DEFAULT_SUPPORTED_SERVERS = new Set([
 	"rust-analyzer",
 ]);
 
-const LIVENESS_TIMEOUT_MS = 1000;
-const STATE_CACHE_TTL_MS = 5 * 60 * 1000;
 
 // =============================================================================
 // Helpers
@@ -50,7 +49,16 @@ const STATE_CACHE_TTL_MS = 5 * 60 * 1000;
 
 function which(command: string): string | null {
 	try {
-		return execSync(`which ${command}`, { encoding: "utf-8" }).trim() || null;
+		// On Windows, prefer `where.exe` over `which` — MSYS/Git Bash's `which`
+		// returns POSIX paths (/c/Users/...) that Node's spawn() can't execute (#1121).
+		const isWindows = process.platform === "win32";
+		const cmd = isWindows ? "where.exe" : "which";
+		const result = isWindows
+			? execSync(`${cmd} ${command}`, { encoding: "utf-8" })
+			: execSync(`which ${command}`, { encoding: "utf-8" });
+		// `where.exe` may return multiple lines — take the first
+		const resolved = result.trim().split(/\r?\n/)[0]?.trim();
+		return resolved || null;
 	} catch {
 		return null;
 	}
@@ -108,7 +116,7 @@ async function checkServerRunning(binaryPath: string): Promise<boolean> {
 			new Promise<number>((resolve) => {
 				proc.on("exit", (code: number | null) => resolve(code ?? 1));
 			}),
-			new Promise<null>(resolve => setTimeout(() => resolve(null), LIVENESS_TIMEOUT_MS)),
+			new Promise<null>(resolve => setTimeout(() => resolve(null), LSP_LIVENESS_TIMEOUT_MS)),
 		]);
 
 		if (exited === null) {
@@ -124,7 +132,7 @@ async function checkServerRunning(binaryPath: string): Promise<boolean> {
 
 export async function detectLspmux(): Promise<LspmuxState> {
 	const now = Date.now();
-	if (cachedState && now - cacheTimestamp < STATE_CACHE_TTL_MS) {
+	if (cachedState && now - cacheTimestamp < LSP_STATE_CACHE_TTL_MS) {
 		return cachedState;
 	}
 

package/packages/pi-coding-agent/src/core/model-resolver.ts

@@ -504,6 +504,20 @@ export async function findInitialModel(options: {
 	if (defaultProvider && defaultModelId) {
 		const found = modelRegistry.find(defaultProvider, defaultModelId);
 		if (found) {
+			// Check if the provider's recommended default is a higher-capability variant
+			// of the saved model (e.g. saved "claude-opus-4-6" vs recommended "claude-opus-4-6[1m]").
+			// If so, prefer the recommended variant to avoid using a smaller context window (#1125).
+			const recommendedId = defaultModelPerProvider[defaultProvider as KnownProvider];
+			if (recommendedId && recommendedId !== defaultModelId && recommendedId.startsWith(defaultModelId)) {
+				const recommended = modelRegistry.find(defaultProvider, recommendedId);
+				if (recommended) {
+					model = recommended;
+					if (defaultThinkingLevel) {
+						thinkingLevel = defaultThinkingLevel;
+					}
+					return { model, thinkingLevel, fallbackMessage: undefined };
+				}
+			}
 			model = found;
 			if (defaultThinkingLevel) {
 				thinkingLevel = defaultThinkingLevel;

package/packages/pi-coding-agent/src/core/resolve-config-value.test.ts

@@ -89,6 +89,64 @@ describe("resolveConfigValue — command allowlist enforcement", () => {
 	});
 });
 
+describe("resolveConfigValue — shell operator bypass prevention", () => {
+	it("blocks semicolon chaining (pass; malicious)", () => {
+		const result = resolveConfigValue("!pass show key; curl http://evil.com");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks pipe operator (pass | evil)", () => {
+		const result = resolveConfigValue("!pass show key | cat /etc/passwd");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks && chaining (pass && evil)", () => {
+		const result = resolveConfigValue("!pass show key && rm -rf /");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks || chaining (pass || evil)", () => {
+		const result = resolveConfigValue("!pass show key || curl evil.com");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks backtick subshell (pass `evil`)", () => {
+		const result = resolveConfigValue("!pass show `curl evil.com`");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks $() subshell (pass $(evil))", () => {
+		const result = resolveConfigValue("!pass show $(curl evil.com)");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks output redirection (pass > file)", () => {
+		const result = resolveConfigValue("!pass show key > /tmp/stolen");
+		assert.equal(result, undefined);
+	});
+
+	it("blocks input redirection (pass < file)", () => {
+		const result = resolveConfigValue("!pass show key < /dev/null");
+		assert.equal(result, undefined);
+	});
+
+	it("writes stderr warning when shell operators detected", () => {
+		const stderrChunks: string[] = [];
+		const originalWrite = process.stderr.write.bind(process.stderr);
+		process.stderr.write = (chunk: string | Uint8Array, ...args: unknown[]) => {
+			stderrChunks.push(chunk.toString());
+			return true;
+		};
+
+		try {
+			resolveConfigValue("!pass show key; curl evil.com");
+			assert.ok(stderrChunks.some((line) => line.includes("shell operators")));
+		} finally {
+			process.stderr.write = originalWrite;
+		}
+	});
+});
+
 describe("resolveConfigValue — caching", () => {
 	it("caches the result of a blocked command", () => {
 		const callCount = { n: 0 };

package/packages/pi-coding-agent/src/core/resolve-config-value.ts

@@ -3,7 +3,10 @@
  * Used by auth-storage.ts and model-registry.ts.
  */
 
-import { execSync } from "child_process";
+import { execFileSync } from "child_process";
+import { COMMAND_EXECUTION_TIMEOUT_MS } from "./constants.js";
+
+const SHELL_OPERATORS = /[;|&`$><]/;
 
 // Cache for shell command results (persists for process lifetime)
 const commandResultCache = new Map<string, string | undefined>();
@@ -40,18 +43,25 @@ function executeCommand(commandConfig: string): string | undefined {
 	}
 
 	const command = commandConfig.slice(1);
-	const firstToken = command.split(/\s+/)[0];
+	const tokens = command.split(/\s+/).filter(Boolean);
+	const firstToken = tokens[0];
 	if (!SAFE_COMMAND_PREFIXES.includes(firstToken)) {
 		process.stderr.write(`[resolve-config-value] Blocked disallowed command: "${firstToken}". Allowed: ${SAFE_COMMAND_PREFIXES.join(", ")}\n`);
 		commandResultCache.set(commandConfig, undefined);
 		return undefined;
 	}
 
+	if (SHELL_OPERATORS.test(command)) {
+		process.stderr.write(`[resolve-config-value] Blocked shell operators in command: "${command}"\n`);
+		commandResultCache.set(commandConfig, undefined);
+		return undefined;
+	}
+
 	let result: string | undefined;
 	try {
-		const output = execSync(command, {
+		const output = execFileSync(firstToken, tokens.slice(1), {
 			encoding: "utf-8",
-			timeout: 10000,
+			timeout: COMMAND_EXECUTION_TIMEOUT_MS,
 			stdio: ["ignore", "pipe", "ignore"],
 		});
 		result = output.trim() || undefined;

package/packages/pi-coding-agent/src/core/session-manager.ts

@@ -27,6 +27,25 @@ import {
 } from "./messages.js";
 import { BlobStore, externalizeImageData, isBlobRef, resolveImageData } from "./blob-store.js";
 
+/** Inline concurrency limiter to cap parallel async operations. */
+function pLimit(concurrency: number) {
+	const queue: (() => void)[] = [];
+	let active = 0;
+	return <T>(fn: () => Promise<T>): Promise<T> => {
+		return new Promise<T>((resolve, reject) => {
+			const run = () => {
+				active++;
+				fn().then(resolve, reject).finally(() => {
+					active--;
+					if (queue.length > 0) queue.shift()!();
+				});
+			};
+			if (active < concurrency) run();
+			else queue.push(run);
+		});
+	};
+}
+
 const BLOB_EXTERNALIZE_THRESHOLD = 1024; // 1KB minimum to externalize
 const MAX_PERSIST_CHARS = 500_000;
 const TRUNCATION_NOTICE = "\n\n[Session persistence truncated large content]";
@@ -1624,13 +1643,17 @@ export class SessionManager {
 			const sessions: SessionInfo[] = [];
 			const allFiles = dirFiles.flat();
 
+			// Limit concurrency to avoid memory spikes with many session files
+			const limit = pLimit(10);
 			const results = await Promise.all(
-				allFiles.map(async (file) => {
-					const info = await buildSessionInfo(file);
-					loaded++;
-					onProgress?.(loaded, totalFiles);
-					return info;
-				}),
+				allFiles.map((file) =>
+					limit(async () => {
+						const info = await buildSessionInfo(file);
+						loaded++;
+						onProgress?.(loaded, totalFiles);
+						return info;
+					}),
+				),
 			);
 
 			for (const info of results) {

package/packages/pi-coding-agent/src/core/settings-manager.ts

@@ -3,6 +3,12 @@ import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
 import { dirname, join } from "path";
 import lockfile from "proper-lockfile";
 import { CONFIG_DIR_NAME, getAgentDir } from "../config.js";
+import {
+	COMPACTION_KEEP_RECENT_TOKENS,
+	COMPACTION_RESERVE_TOKENS,
+	RETRY_BASE_DELAY_MS,
+	RETRY_MAX_DELAY_MS,
+} from "./constants.js";
 import type { BashInterceptorRule } from "./tools/bash-interceptor.js";
 
 export interface CompactionSettings {
@@ -134,6 +140,8 @@ export interface Settings {
 	thinkingBudgets?: ThinkingBudgetsSettings; // Custom token budgets for thinking levels
 	editorPaddingX?: number; // Horizontal padding for input editor (default: 0)
 	autocompleteMaxVisible?: number; // Max visible items in autocomplete dropdown (default: 5)
+	respectGitignoreInPicker?: boolean; // When false, @ file picker shows gitignored files (default: true)
+	searchExcludeDirs?: string[]; // Directories to exclude from @ file search (e.g., ["node_modules", ".git", "dist"])
 	showHardwareCursor?: boolean; // Show terminal cursor while still positioning it for IME
 	markdown?: MarkdownSettings;
 	memory?: MemorySettings;
@@ -709,11 +717,11 @@ export class SettingsManager {
 	}
 
 	getCompactionReserveTokens(): number {
-		return this.settings.compaction?.reserveTokens ?? 16384;
+		return this.settings.compaction?.reserveTokens ?? COMPACTION_RESERVE_TOKENS;
 	}
 
 	getCompactionKeepRecentTokens(): number {
-		return this.settings.compaction?.keepRecentTokens ?? 20000;
+		return this.settings.compaction?.keepRecentTokens ?? COMPACTION_KEEP_RECENT_TOKENS;
 	}
 
 	getCompactionSettings(): { enabled: boolean; reserveTokens: number; keepRecentTokens: number } {
@@ -726,7 +734,7 @@ export class SettingsManager {
 
 	getBranchSummarySettings(): { reserveTokens: number; skipPrompt: boolean } {
 		return {
-			reserveTokens: this.settings.branchSummary?.reserveTokens ?? 16384,
+			reserveTokens: this.settings.branchSummary?.reserveTokens ?? COMPACTION_RESERVE_TOKENS,
 			skipPrompt: this.settings.branchSummary?.skipPrompt ?? false,
 		};
 	}
@@ -752,8 +760,8 @@ export class SettingsManager {
 		return {
 			enabled: this.getRetryEnabled(),
 			maxRetries: this.settings.retry?.maxRetries ?? 3,
-			baseDelayMs: this.settings.retry?.baseDelayMs ?? 2000,
-			maxDelayMs: this.settings.retry?.maxDelayMs ?? 300000,
+			baseDelayMs: this.settings.retry?.baseDelayMs ?? RETRY_BASE_DELAY_MS,
+			maxDelayMs: this.settings.retry?.maxDelayMs ?? RETRY_MAX_DELAY_MS,
 		};
 	}
 
@@ -1024,6 +1032,26 @@ export class SettingsManager {
 		this.save();
 	}
 
+	getRespectGitignoreInPicker(): boolean {
+		return this.settings.respectGitignoreInPicker ?? true;
+	}
+
+	setRespectGitignoreInPicker(value: boolean): void {
+		this.globalSettings.respectGitignoreInPicker = value;
+		this.markModified("respectGitignoreInPicker");
+		this.save();
+	}
+
+	getSearchExcludeDirs(): string[] {
+		return this.settings.searchExcludeDirs ?? [];
+	}
+
+	setSearchExcludeDirs(dirs: string[]): void {
+		this.globalSettings.searchExcludeDirs = dirs.filter(Boolean);
+		this.markModified("searchExcludeDirs");
+		this.save();
+	}
+
 	getCodeBlockIndent(): string {
 		return this.settings.markdown?.codeBlockIndent ?? "  ";
 	}

package/packages/pi-coding-agent/src/core/system-prompt.ts

@@ -94,6 +94,17 @@ export function buildSystemPrompt(options: BuildSystemPromptOptions = {}): strin
 		prompt += `\nCurrent date and time: ${dateTime}`;
 		prompt += `\nCurrent working directory: ${resolvedCwd}`;
 
+		// Append promptGuidelines from extension-registered tools.
+		// Without this, tools registered via pi.registerTool() with promptGuidelines
+		// have their definitions reach the API but the model has no guidance on when
+		// to use them (#1184).
+		if (promptGuidelines && promptGuidelines.length > 0) {
+			prompt += "\n\n";
+			for (const guideline of promptGuidelines) {
+				prompt += guideline + "\n";
+			}
+		}
+
 		return prompt;
 	}
 

package/packages/pi-coding-agent/src/core/tools/edit-diff.ts

@@ -9,7 +9,7 @@
 
 import { constants } from "fs";
 import { access, readFile } from "fs/promises";
-import { resolveToCwd } from "./path-utils.js";
+import { resolveToCwd, UNICODE_SPACES } from "./path-utils.js";
 
 export function detectLineEnding(content: string): "\r\n" | "\n" {
 	const crlfIdx = content.indexOf("\r\n");
@@ -41,7 +41,7 @@ export function normalizeForFuzzyMatch(text: string): string {
 		.replace(/[“”]/g, '"')
 		.replace(/[‘’]/g, "'")
 		.replace(/[‐‑‒–—−]/g, "-")
-		.replace(/[\u00A0\u1680\u2000-\u200A\u202F\u205F\u3000]/g, " ")
+		.replace(UNICODE_SPACES, " ")
 		.split("\n")
 		.map((line) => line.replace(/[ \t]+$/g, ""))
 		.join("\n");

package/packages/pi-coding-agent/src/core/tools/find.ts

@@ -3,6 +3,7 @@ import { glob as nativeGlob } from "@gsd/native/glob";
 import { type Static, Type } from "@sinclair/typebox";
 import { existsSync } from "fs";
 import path from "path";
+import { FIND_DEFAULT_LIMIT } from "../constants.js";
 import { resolveToCwd } from "./path-utils.js";
 import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate.js";
 
@@ -16,7 +17,7 @@ const findSchema = Type.Object({
 
 export type FindToolInput = Static<typeof findSchema>;
 
-const DEFAULT_LIMIT = 1000;
+const DEFAULT_LIMIT = FIND_DEFAULT_LIMIT;
 
 export interface FindToolDetails {
 	truncation?: TruncationResult;

package/packages/pi-coding-agent/src/core/tools/hashline-edit.ts

@@ -20,7 +20,7 @@ import {
 	applyHashlineEdits,
 	computeLineHash,
 	type HashlineEdit,
-	hashlineParseText,
+	parseHashlineText,
 	parseTag,
 } from "./hashline.js";
 import { resolveToCwd } from "./path-utils.js";
@@ -99,7 +99,7 @@ function tryParseTag(raw: string): Anchor | undefined {
 function resolveEditAnchors(edits: HashlineEditItem[]): HashlineEdit[] {
 	const result: HashlineEdit[] = [];
 	for (const edit of edits) {
-		const lines = hashlineParseText(edit.lines);
+		const lines = parseHashlineText(edit.lines);
 		const tag = edit.pos ? tryParseTag(edit.pos) : undefined;
 		const end = edit.end ? tryParseTag(edit.end) : undefined;
 
@@ -207,9 +207,9 @@ export function createHashlineEditTool(cwd: string, options?: HashlineEditToolOp
 							for (const edit of edits) {
 								if ((edit.op === "append" || edit.op === "prepend") && !edit.pos && !edit.end) {
 									if (edit.op === "prepend") {
-										lines.unshift(...hashlineParseText(edit.lines));
+										lines.unshift(...parseHashlineText(edit.lines));
 									} else {
-										lines.push(...hashlineParseText(edit.lines));
+										lines.push(...parseHashlineText(edit.lines));
 									}
 								} else {
 									throw new Error(`File not found: ${path}`);

package/packages/pi-coding-agent/src/core/tools/hashline.test.ts

@@ -8,7 +8,7 @@ import {
 	validateLineRef,
 	applyHashlineEdits,
 	HashlineMismatchError,
-	hashlineParseText,
+	parseHashlineText,
 	stripNewLinePrefixes,
 	type HashlineEdit,
 	type Anchor,
@@ -395,31 +395,31 @@ describe("stripNewLinePrefixes", () => {
 });
 
 // ═══════════════════════════════════════════════════════════════════════════
-// hashlineParseText
+// parseHashlineText
 // ═══════════════════════════════════════════════════════════════════════════
 
-describe("hashlineParseText", () => {
+describe("parseHashlineText", () => {
 	it("returns empty array for null", () => {
-		assert.deepEqual(hashlineParseText(null), []);
+		assert.deepEqual(parseHashlineText(null), []);
 	});
 
 	it("returns array input as-is when no strip heuristic applies", () => {
 		const input = ["- [x] done", "- [ ] todo"];
-		assert.equal(hashlineParseText(input), input);
+		assert.equal(parseHashlineText(input), input);
 	});
 
 	it("splits string on newline and preserves Markdown list '-' prefix", () => {
-		const result = hashlineParseText("- item one\n- item two\n- item three");
+		const result = parseHashlineText("- item one\n- item two\n- item three");
 		assert.deepEqual(result, ["- item one", "- item two", "- item three"]);
 	});
 
 	it("strips '+' diff markers from string input", () => {
-		const result = hashlineParseText("+line one\n+line two");
+		const result = parseHashlineText("+line one\n+line two");
 		assert.deepEqual(result, ["line one", "line two"]);
 	});
 
 	it("still strips trailing empty from string split", () => {
-		assert.deepEqual(hashlineParseText("foo\n"), ["foo"]);
+		assert.deepEqual(parseHashlineText("foo\n"), ["foo"]);
 	});
 });
 

package/packages/pi-coding-agent/src/core/tools/hashline.ts

@@ -230,7 +230,7 @@ export function stripNewLinePrefixes(lines: string[]): string[] {
  * Parse edit content — handles string, array, or null input.
  * Strips hashline prefixes and diff markers from model output.
  */
-export function hashlineParseText(edit: string[] | string | null): string[] {
+export function parseHashlineText(edit: string[] | string | null): string[] {
 	if (edit === null) return [];
 	if (typeof edit === "string") {
 		const normalizedEdit = edit.endsWith("\n") ? edit.slice(0, -1) : edit;

package/packages/pi-coding-agent/src/core/tools/index.ts

@@ -99,7 +99,7 @@ export {
 	formatLineTag,
 	type HashlineEdit,
 	HashlineMismatchError,
-	hashlineParseText,
+	parseHashlineText,
 	type HashMismatch,
 	parseTag,
 	stripNewLinePrefixes,

package/packages/pi-coding-agent/src/core/tools/path-utils.ts

@@ -2,7 +2,7 @@ import { accessSync, constants } from "node:fs";
 import * as os from "node:os";
 import { isAbsolute, resolve as resolvePath } from "node:path";
 
-const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
+export const UNICODE_SPACES = /[\u00A0\u1680\u2000-\u200A\u202F\u205F\u3000]/g;
 const NARROW_NO_BREAK_SPACE = "\u202F";
 function normalizeUnicodeSpaces(str: string): string {
 	return str.replace(UNICODE_SPACES, " ");

package/packages/pi-coding-agent/src/core/tools/truncate.ts

@@ -8,7 +8,9 @@
  * Never returns partial lines (except bash tail truncation edge case).
  */
 
-export const DEFAULT_MAX_LINES = 2000;
+import { TRUNCATE_DEFAULT_MAX_LINES } from "../constants.js";
+
+export const DEFAULT_MAX_LINES = TRUNCATE_DEFAULT_MAX_LINES;
 export const DEFAULT_MAX_BYTES = 50 * 1024; // 50KB
 export const GREP_MAX_LINE_LENGTH = 500; // Max chars per grep match line