gsd-pi 2.10.12 → 2.12.0

package/dist/resources/extensions/gsd/tests/dispatch-guard.test.ts

@@ -0,0 +1,91 @@
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { execSync } from "node:child_process";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { getPriorSliceCompletionBlocker } from "../dispatch-guard.ts";
+import { createTestContext } from './test-helpers.ts';
+
+const { assertEq, report } = createTestContext();
+function run(command: string, cwd: string): void {
+  execSync(command, { cwd, stdio: ["ignore", "pipe", "pipe"] });
+}
+
+const repo = mkdtempSync(join(tmpdir(), "gsd-dispatch-guard-"));
+try {
+  mkdirSync(join(repo, ".gsd", "milestones", "M002"), { recursive: true });
+  mkdirSync(join(repo, ".gsd", "milestones", "M003"), { recursive: true });
+
+  writeFileSync(join(repo, ".gsd", "milestones", "M002", "M002-ROADMAP.md"), [
+    "# M002: Previous",
+    "",
+    "## Slices",
+    "- [x] **S01: Done** `risk:low` `depends:[]`",
+    "- [ ] **S02: Pending** `risk:low` `depends:[S01]`",
+    "",
+  ].join("\n"));
+
+  writeFileSync(join(repo, ".gsd", "milestones", "M003", "M003-ROADMAP.md"), [
+    "# M003: Current",
+    "",
+    "## Slices",
+    "- [ ] **S01: First** `risk:low` `depends:[]`",
+    "- [ ] **S02: Second** `risk:low` `depends:[S01]`",
+    "",
+  ].join("\n"));
+
+  run("git init -b main", repo);
+  run("git config user.email test@example.com", repo);
+  run("git config user.name Test", repo);
+  run("git add .", repo);
+  run("git commit -m init", repo);
+
+  assertEq(
+    getPriorSliceCompletionBlocker(repo, "main", "plan-slice", "M003/S01"),
+    "Cannot dispatch plan-slice M003/S01: earlier slice M002/S02 is not complete on main.",
+    "blocks first slice of next milestone when prior milestone is incomplete on main",
+  );
+
+  writeFileSync(join(repo, ".gsd", "milestones", "M002", "M002-ROADMAP.md"), [
+    "# M002: Previous",
+    "",
+    "## Slices",
+    "- [x] **S01: Done** `risk:low` `depends:[]`",
+    "- [x] **S02: Done** `risk:low` `depends:[S01]`",
+    "",
+  ].join("\n"));
+  run("git add .", repo);
+  run("git commit -m complete-m002", repo);
+
+  assertEq(
+    getPriorSliceCompletionBlocker(repo, "main", "execute-task", "M003/S02/T01"),
+    "Cannot dispatch execute-task M003/S02/T01: earlier slice M003/S01 is not complete on main.",
+    "blocks later slice in same milestone when an earlier slice is incomplete on main",
+  );
+
+  writeFileSync(join(repo, ".gsd", "milestones", "M003", "M003-ROADMAP.md"), [
+    "# M003: Current",
+    "",
+    "## Slices",
+    "- [x] **S01: First** `risk:low` `depends:[]`",
+    "- [ ] **S02: Second** `risk:low` `depends:[S01]`",
+    "",
+  ].join("\n"));
+  run("git add .", repo);
+  run("git commit -m complete-m003-s01", repo);
+
+  assertEq(
+    getPriorSliceCompletionBlocker(repo, "main", "execute-task", "M003/S02/T01"),
+    null,
+    "allows dispatch when all earlier slices are complete on main",
+  );
+
+  assertEq(
+    getPriorSliceCompletionBlocker(repo, "main", "plan-milestone", "M003"),
+    null,
+    "does not affect non-slice dispatch types",
+  );
+} finally {
+  rmSync(repo, { recursive: true, force: true });
+}
+
+report();

package/dist/resources/extensions/gsd/tests/doctor-fixlevel.test.ts

@@ -0,0 +1,170 @@
+/**
+ * Tests that doctor's fixLevel option correctly separates task-level
+ * bookkeeping from completion state transitions.
+ *
+ * fixLevel:"task" — fixes task checkboxes, does NOT create slice summary
+ *   stubs, UAT stubs, or mark slices done in the roadmap.
+ * fixLevel:"all" (default) — fixes everything including completion transitions.
+ */
+
+import { mkdirSync, writeFileSync, rmSync, readFileSync, existsSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import test from "node:test";
+import assert from "node:assert/strict";
+import { runGSDDoctor } from "../doctor.ts";
+
+function makeTmp(name: string): string {
+  const dir = join(tmpdir(), `doctor-fixlevel-${name}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+  mkdirSync(dir, { recursive: true });
+  return dir;
+}
+
+/**
+ * Build a minimal .gsd structure: milestone with one slice, one task
+ * marked done with a summary — but no slice summary and roadmap unchecked.
+ * This is exactly the state after the last task completes.
+ */
+function buildScaffold(base: string) {
+  const gsd = join(base, ".gsd");
+  const m = join(gsd, "milestones", "M001");
+  const s = join(m, "slices", "S01", "tasks");
+  mkdirSync(s, { recursive: true });
+
+  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
+
+## Slices
+
+- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
+  > Demo text
+`);
+
+  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
+
+**Goal:** test
+
+## Tasks
+
+- [x] **T01: Do stuff** \`est:5m\`
+`);
+
+  writeFileSync(join(s, "T01-SUMMARY.md"), `---
+id: T01
+parent: S01
+milestone: M001
+duration: 5m
+verification_result: passed
+completed_at: 2026-01-01
+---
+
+# T01: Do stuff
+
+Done.
+`);
+}
+
+test("fixLevel:task — detects completion issues but does NOT create summary stub or mark roadmap", async () => {
+  const tmp = makeTmp("task-level");
+  try {
+    buildScaffold(tmp);
+
+    const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
+
+    // Should detect the issues
+    const codes = report.issues.map(i => i.code);
+    assert.ok(codes.includes("all_tasks_done_missing_slice_summary"), "should detect missing summary");
+    assert.ok(codes.includes("all_tasks_done_roadmap_not_checked"), "should detect unchecked roadmap");
+
+    // Should NOT have fixed them
+    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
+    assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
+
+    const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
+    assert.ok(roadmapContent.includes("- [ ] **S01"), "roadmap should still show S01 as unchecked");
+
+    // Fixes applied should NOT include completion artifacts
+    for (const f of report.fixesApplied) {
+      assert.ok(!f.includes("SUMMARY"), `should not have fixed summary: ${f}`);
+      assert.ok(!f.includes("roadmap"), `should not have fixed roadmap: ${f}`);
+    }
+  } finally {
+    rmSync(tmp, { recursive: true, force: true });
+  }
+});
+
+test("fixLevel:all (default) — detects AND fixes completion issues", async () => {
+  const tmp = makeTmp("all-level");
+  try {
+    buildScaffold(tmp);
+
+    const report = await runGSDDoctor(tmp, { fix: true });
+
+    // Should detect the issues
+    const codes = report.issues.map(i => i.code);
+    assert.ok(codes.includes("all_tasks_done_missing_slice_summary"), "should detect missing summary");
+    assert.ok(codes.includes("all_tasks_done_roadmap_not_checked"), "should detect unchecked roadmap");
+
+    // SHOULD have fixed them
+    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
+    assert.ok(existsSync(sliceSummaryPath), "should have created summary stub");
+
+    const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
+    assert.ok(roadmapContent.includes("- [x] **S01"), "roadmap should show S01 as checked");
+  } finally {
+    rmSync(tmp, { recursive: true, force: true });
+  }
+});
+
+test("fixLevel:task — still fixes task-level bookkeeping (checkbox marking)", async () => {
+  const tmp = makeTmp("task-checkbox");
+  try {
+    const gsd = join(tmp, ".gsd");
+    const m = join(gsd, "milestones", "M001");
+    const s = join(m, "slices", "S01", "tasks");
+    mkdirSync(s, { recursive: true });
+
+    writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
+
+## Slices
+
+- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
+  > Demo text
+`);
+
+    // Task NOT checked in plan but has a summary — doctor should mark it done
+    writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
+
+**Goal:** test
+
+## Tasks
+
+- [ ] **T01: Do stuff** \`est:5m\`
+`);
+
+    writeFileSync(join(s, "T01-SUMMARY.md"), `---
+id: T01
+parent: S01
+milestone: M001
+duration: 5m
+verification_result: passed
+completed_at: 2026-01-01
+---
+
+# T01: Do stuff
+
+Done.
+`);
+
+    const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
+
+    // Should have fixed the task checkbox
+    const planContent = readFileSync(join(m, "slices", "S01", "S01-PLAN.md"), "utf8");
+    assert.ok(planContent.includes("- [x] **T01"), "should have marked T01 done in plan");
+
+    // Should NOT have touched slice-level completion
+    const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
+    assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
+  } finally {
+    rmSync(tmp, { recursive: true, force: true });
+  }
+});