gsd-pi 2.10.12 → 2.12.0

package/dist/resources/skills/swiftui/workflows/write-tests.md

@@ -0,0 +1,235 @@
+<required_reading>
+**Read these reference files NOW before starting:**
+1. `../macos-apps/references/cli-workflow.md` - Test commands from CLI
+2. `../macos-apps/references/testing-tdd.md` - TDD patterns, avoiding @main hangs
+3. `references/testing-debugging.md` - SwiftUI-specific testing and debugging
+</required_reading>
+
+<process>
+## Step 1: Identify Testing Scope
+
+**Test business logic in view models, not views:**
+```swift
+// Testable view model
+@Observable
+final class LoginViewModel {
+    var email = ""
+    var password = ""
+    var isLoading = false
+
+    var isValidInput: Bool {
+        !email.isEmpty && password.count >= 8
+    }
+}
+
+// View is just presentation
+struct LoginView: View {
+    let viewModel: LoginViewModel
+    var body: some View {
+        Form {
+            TextField("Email", text: $viewModel.email)
+            Button("Login") { }
+                .disabled(!viewModel.isValidInput)
+        }
+    }
+}
+```
+
+## Step 2: Write Unit Tests
+
+**Using Swift Testing (@Test):**
+```swift
+import Testing
+@testable import MyApp
+
+@Test("Email validation")
+func emailValidation() {
+    let viewModel = LoginViewModel()
+
+    viewModel.email = ""
+    viewModel.password = "password123"
+    #expect(!viewModel.isValidInput)
+
+    viewModel.email = "user@example.com"
+    #expect(viewModel.isValidInput)
+}
+
+@Test("Async loading")
+func asyncLoading() async {
+    let mockService = MockService()
+    let viewModel = TaskViewModel(service: mockService)
+
+    await viewModel.load()
+
+    #expect(!viewModel.tasks.isEmpty)
+}
+```
+
+## Step 3: Add Accessibility Identifiers
+
+```swift
+TextField("Email", text: $email)
+    .accessibilityIdentifier("emailField")
+
+SecureField("Password", text: $password)
+    .accessibilityIdentifier("passwordField")
+
+Button("Login") { }
+    .accessibilityIdentifier("loginButton")
+```
+
+## Step 4: Write UI Tests
+
+```swift
+import XCTest
+
+final class LoginUITests: XCTestCase {
+    var app: XCUIApplication!
+
+    override func setUp() {
+        continueAfterFailure = false
+        app = XCUIApplication()
+        app.launch()
+    }
+
+    func testLoginFlow() {
+        let emailField = app.textFields["emailField"]
+        let passwordField = app.secureTextFields["passwordField"]
+        let loginButton = app.buttons["loginButton"]
+
+        XCTAssertTrue(emailField.waitForExistence(timeout: 5))
+
+        emailField.tap()
+        emailField.typeText("user@example.com")
+
+        passwordField.tap()
+        passwordField.typeText("password123")
+
+        XCTAssertTrue(loginButton.isEnabled)
+        loginButton.tap()
+
+        let welcomeText = app.staticTexts["welcomeMessage"]
+        XCTAssertTrue(welcomeText.waitForExistence(timeout: 5))
+    }
+}
+```
+
+## Step 5: Create Previews for Visual Testing
+
+```swift
+#Preview("Empty") { LoginView(viewModel: LoginViewModel()) }
+
+#Preview("Filled") {
+    let viewModel = LoginViewModel()
+    viewModel.email = "user@example.com"
+    viewModel.password = "password123"
+    return LoginView(viewModel: viewModel)
+}
+
+#Preview("Error") {
+    let viewModel = LoginViewModel()
+    viewModel.errorMessage = "Invalid credentials"
+    return LoginView(viewModel: viewModel)
+}
+
+#Preview("Dark Mode") {
+    LoginView(viewModel: LoginViewModel())
+        .preferredColorScheme(.dark)
+}
+```
+
+## Step 6: Run Tests from CLI
+
+```bash
+# Run all tests with parsed output
+xcodebuild test -scheme AppName -destination 'platform=iOS Simulator,name=iPhone 15 Pro' 2>&1 | xcsift
+
+# Run only unit tests
+xcodebuild test -scheme AppName -only-testing:AppNameTests 2>&1 | xcsift
+
+# Run only UI tests
+xcodebuild test -scheme AppName -only-testing:AppNameUITests 2>&1 | xcsift
+
+# Run specific test class
+xcodebuild test -scheme AppName -only-testing:AppNameTests/LoginViewModelTests 2>&1 | xcsift
+
+# Run specific test method
+xcodebuild test -scheme AppName -only-testing:AppNameTests/LoginViewModelTests/testEmailValidation 2>&1 | xcsift
+
+# Generate test coverage
+xcodebuild test -scheme AppName -enableCodeCoverage YES -resultBundlePath TestResults.xcresult 2>&1 | xcsift
+xcrun xccov view --report TestResults.xcresult
+```
+
+**If tests hang:** The test target likely depends on the app target with `@main`. Extract testable code to a Core framework target. See `../macos-apps/references/testing-tdd.md`.
+
+Report to user:
+- "Tests: X pass, Y fail"
+- "Coverage: Z% of lines"
+- If failures: "Failed tests: [list]. Investigating..."
+</process>
+
+<anti_patterns>
+## Avoid These Mistakes
+
+**Testing view bodies:**
+```swift
+// Wrong: can't test views directly
+func testView() {
+    let view = LoginView()
+    // Can't inspect SwiftUI view
+}
+
+// Right: test view model
+@Test func emailInput() {
+    let viewModel = LoginViewModel()
+    viewModel.email = "test@example.com"
+    #expect(viewModel.email == "test@example.com")
+}
+```
+
+**Missing accessibility identifiers:**
+```swift
+// Wrong: using text
+let button = app.buttons["Login"]
+
+// Right: stable identifier
+let button = app.buttons["loginButton"]
+```
+
+**No dependency injection:**
+```swift
+// Wrong: can't mock
+@Observable
+class ViewModel {
+    private let service = RealService()
+}
+
+// Right: injectable
+@Observable
+class ViewModel {
+    private let service: ServiceProtocol
+    init(service: ServiceProtocol) {
+        self.service = service
+    }
+}
+```
+
+**No edge case testing:**
+```swift
+// Test empty, invalid, error states
+@Test func emptyEmail() { }
+@Test func shortPassword() { }
+@Test func networkError() { }
+```
+</anti_patterns>
+
+<success_criteria>
+This workflow is complete when:
+- [ ] Unit tests verify view model business logic
+- [ ] UI tests verify user flows using accessibility identifiers
+- [ ] All tests pass: `xcodebuild test -scheme YourApp`
+- [ ] Edge cases and error states have coverage
+- [ ] Dependencies use protocols for testability
+- [ ] Previews exist for major UI states
+</success_criteria>

package/dist/wizard.js

@@ -14,6 +14,7 @@ export function loadStoredEnvKeys(authStorage) {
         ['slack_bot', 'SLACK_BOT_TOKEN'],
         ['discord_bot', 'DISCORD_BOT_TOKEN'],
         ['groq', 'GROQ_API_KEY'],
+        ['ollama-cloud', 'OLLAMA_API_KEY'],
     ];
     for (const [provider, envVar] of providers) {
         if (!process.env[envVar]) {

package/package.json

@@ -1,15 +1,15 @@
 {
   "name": "gsd-pi",
-  "version": "2.10.12",
+  "version": "2.12.0",
   "description": "GSD — Get Shit Done coding agent",
   "license": "MIT",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/glittercowboy/gsd-pi.git"
+    "url": "https://github.com/gsd-build/gsd-2.git"
   },
-  "homepage": "https://github.com/glittercowboy/gsd-pi#readme",
+  "homepage": "https://github.com/gsd-build/gsd-2#readme",
   "bugs": {
-    "url": "https://github.com/glittercowboy/gsd-pi/issues"
+    "url": "https://github.com/gsd-build/gsd-2/issues"
   },
   "type": "module",
   "workspaces": [
@@ -43,8 +43,10 @@
     "build:pi-coding-agent": "npm run build -w @gsd/pi-coding-agent",
     "build:native-pkg": "npm run build -w @gsd/native",
     "build:pi": "npm run build:native-pkg && npm run build:pi-tui && npm run build:pi-ai && npm run build:pi-agent-core && npm run build:pi-coding-agent",
-    "build": "npm run build:pi && tsc && npm run copy-themes",
+    "build": "npm run build:pi && tsc && npm run copy-resources && npm run copy-themes && npm run copy-export-html",
+    "copy-resources": "node -e \"const{cpSync,rmSync}=require('fs');rmSync('dist/resources',{recursive:true,force:true});cpSync('src/resources','dist/resources',{recursive:true,force:true})\"",
     "copy-themes": "node -e \"const{mkdirSync,cpSync}=require('fs');const{resolve}=require('path');const src=resolve(__dirname,'packages/pi-coding-agent/dist/modes/interactive/theme');mkdirSync('pkg/dist/modes/interactive/theme',{recursive:true});cpSync(src,'pkg/dist/modes/interactive/theme',{recursive:true})\"",
+    "copy-export-html": "node -e \"const{mkdirSync,cpSync}=require('fs');const{resolve}=require('path');const src=resolve(__dirname,'packages/pi-coding-agent/dist/core/export-html');mkdirSync('pkg/dist/core/export-html',{recursive:true});cpSync(src,'pkg/dist/core/export-html',{recursive:true})\"",
     "test:unit": "node --import ./src/resources/extensions/gsd/tests/resolve-ts.mjs --experimental-strip-types --test src/resources/extensions/gsd/tests/*.test.ts src/resources/extensions/gsd/tests/*.test.mjs src/tests/*.test.ts",
     "test:integration": "node --import ./src/resources/extensions/gsd/tests/resolve-ts.mjs --experimental-strip-types --test src/resources/extensions/gsd/tests/*integration*.test.ts src/tests/integration/*.test.ts",
     "test": "npm run test:unit && npm run test:integration",
@@ -52,7 +54,7 @@
     "test:native": "node --test packages/native/src/__tests__/grep.test.mjs",
     "build:native": "node native/scripts/build.js",
     "build:native:dev": "node native/scripts/build.js --dev",
-    "dev": "tsc --watch",
+    "dev": "node scripts/dev.js",
     "postinstall": "node scripts/link-workspace-packages.cjs && node scripts/postinstall.js",
     "pi:install-global": "node scripts/install-pi-global.js",
     "pi:uninstall-global": "node scripts/uninstall-pi-global.js",

package/packages/native/dist/fd/index.d.ts

@@ -11,6 +11,7 @@ export type { FuzzyFindMatch, FuzzyFindOptions, FuzzyFindResult };
  *
  * Searches for files and directories whose paths match the query string.
  * Results are sorted by match quality (higher score = better match).
+ * Reuses the shared native filesystem scan cache used by glob discovery.
  *
  * Scoring tiers (highest to lowest):
  * - 120: exact filename match

package/packages/native/dist/fd/index.js

@@ -10,6 +10,7 @@ import { native } from "../native.js";
  *
  * Searches for files and directories whose paths match the query string.
  * Results are sorted by match quality (higher score = better match).
+ * Reuses the shared native filesystem scan cache used by glob discovery.
  *
  * Scoring tiers (highest to lowest):
  * - 120: exact filename match

package/packages/native/dist/grep/index.d.ts

@@ -16,5 +16,6 @@ export declare function searchContent(content: Buffer | Uint8Array, options: Sea
  * Search files on disk for a regex pattern.
  *
  * Walks the directory tree respecting .gitignore and optional glob filters.
+ * Runs on the native blocking worker pool and resolves asynchronously.
  */
-export declare function grep(options: GrepOptions): GrepResult;
+export declare function grep(options: GrepOptions): Promise<GrepResult>;

package/packages/native/dist/grep/index.js

@@ -17,6 +17,7 @@ export function searchContent(content, options) {
  * Search files on disk for a regex pattern.
  *
  * Walks the directory tree respecting .gitignore and optional glob filters.
+ * Runs on the native blocking worker pool and resolves asynchronously.
  */
 export function grep(options) {
     return native.grep(options);

package/packages/native/src/__tests__/fd.test.mjs

@@ -139,6 +139,41 @@ describe("native fd: fuzzyFind()", () => {
     );
   });
 
+  test("reuses the shared fs scan cache until invalidated", (t) => {
+    const previousTtl = process.env.FS_SCAN_CACHE_TTL_MS;
+    process.env.FS_SCAN_CACHE_TTL_MS = "10000";
+
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-fd-test-"));
+    t.after(() => {
+      native.invalidateFsScanCache(tmpDir);
+      fs.rmSync(tmpDir, { recursive: true, force: true });
+      if (previousTtl === undefined) {
+        delete process.env.FS_SCAN_CACHE_TTL_MS;
+      } else {
+        process.env.FS_SCAN_CACHE_TTL_MS = previousTtl;
+      }
+    });
+
+    fs.writeFileSync(path.join(tmpDir, "cached.txt"), "cached");
+    native.invalidateFsScanCache(tmpDir);
+
+    const warm = native.fuzzyFind({ query: "cached", path: tmpDir });
+    assert.ok(warm.matches.some((m) => m.path === "cached.txt"));
+
+    fs.unlinkSync(path.join(tmpDir, "cached.txt"));
+
+    const cached = native.fuzzyFind({ query: "cached", path: tmpDir });
+    assert.ok(
+      cached.matches.some((m) => m.path === "cached.txt"),
+      "should serve warm results from the shared fs scan cache",
+    );
+
+    native.invalidateFsScanCache(tmpDir);
+
+    const refreshed = native.fuzzyFind({ query: "cached", path: tmpDir });
+    assert.equal(refreshed.matches.length, 0);
+  });
+
   test("results are sorted by score descending", (t) => {
     const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-fd-test-"));
     t.after(() => fs.rmSync(tmpDir, { recursive: true, force: true }));

package/packages/native/src/__tests__/grep.test.mjs

@@ -93,7 +93,24 @@ describe("native grep: search()", () => {
 describe("native grep: grep()", () => {
   let tmpDir;
 
-  test("searches files on disk", (t) => {
+  test("returns a promise", async (t) => {
+    tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-grep-test-"));
+    t.after(() => fs.rmSync(tmpDir, { recursive: true, force: true }));
+
+    fs.writeFileSync(path.join(tmpDir, "file1.txt"), "hello world\n");
+
+    const pending = native.grep({
+      pattern: "hello",
+      path: tmpDir,
+    });
+
+    assert.equal(typeof pending?.then, "function");
+
+    const result = await pending;
+    assert.equal(result.totalMatches, 1);
+  });
+
+  test("searches files on disk", async (t) => {
     tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-grep-test-"));
     t.after(() => fs.rmSync(tmpDir, { recursive: true, force: true }));
 
@@ -101,7 +118,7 @@ describe("native grep: grep()", () => {
     fs.writeFileSync(path.join(tmpDir, "file2.txt"), "hello rust\nbaz qux\n");
     fs.writeFileSync(path.join(tmpDir, "file3.log"), "no match here\n");
 
-    const result = native.grep({
+    const result = await native.grep({
       pattern: "hello",
       path: tmpDir,
     });
@@ -115,7 +132,7 @@ describe("native grep: grep()", () => {
     assert.deepEqual(paths, [...paths].sort());
   });
 
-  test("respects glob filter", (t) => {
+  test("respects glob filter", async (t) => {
     tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-grep-test-"));
     t.after(() => fs.rmSync(tmpDir, { recursive: true, force: true }));
 
@@ -123,7 +140,7 @@ describe("native grep: grep()", () => {
     fs.writeFileSync(path.join(tmpDir, "code.js"), "hello javascript\n");
     fs.writeFileSync(path.join(tmpDir, "readme.md"), "hello markdown\n");
 
-    const result = native.grep({
+    const result = await native.grep({
       pattern: "hello",
       path: tmpDir,
       glob: "*.ts",
@@ -133,7 +150,7 @@ describe("native grep: grep()", () => {
     assert.equal(result.matches[0].line, "hello typescript");
   });
 
-  test("respects maxCount", (t) => {
+  test("respects maxCount", async (t) => {
     tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-grep-test-"));
     t.after(() => fs.rmSync(tmpDir, { recursive: true, force: true }));
 
@@ -141,7 +158,7 @@ describe("native grep: grep()", () => {
       fs.writeFileSync(path.join(tmpDir, `file${i}.txt`), "match_me\n");
     }
 
-    const result = native.grep({
+    const result = await native.grep({
       pattern: "match_me",
       path: tmpDir,
       maxCount: 3,
@@ -151,9 +168,9 @@ describe("native grep: grep()", () => {
     assert.equal(result.limitReached, true);
   });
 
-  test("errors on non-existent path", () => {
-    assert.throws(() => {
-      native.grep({
+  test("errors on non-existent path", async () => {
+    await assert.rejects(() => {
+      return native.grep({
         pattern: "test",
         path: "/nonexistent/path/that/does/not/exist",
       });

package/packages/native/src/fd/index.ts

@@ -19,6 +19,7 @@ export type { FuzzyFindMatch, FuzzyFindOptions, FuzzyFindResult };
  *
  * Searches for files and directories whose paths match the query string.
  * Results are sorted by match quality (higher score = better match).
+ * Reuses the shared native filesystem scan cache used by glob discovery.
  *
  * Scoring tiers (highest to lowest):
  * - 120: exact filename match

package/packages/native/src/grep/index.ts

@@ -42,7 +42,8 @@ export function searchContent(
  * Search files on disk for a regex pattern.
  *
  * Walks the directory tree respecting .gitignore and optional glob filters.
+ * Runs on the native blocking worker pool and resolves asynchronously.
  */
-export function grep(options: GrepOptions): GrepResult {
-  return native.grep(options) as GrepResult;
+export function grep(options: GrepOptions): Promise<GrepResult> {
+  return native.grep(options) as Promise<GrepResult>;
 }

package/packages/pi-agent-core/dist/agent-loop.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"agent-loop.d.ts","sourceRoot":"","sources":["../src/agent-loop.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAGN,WAAW,EAIX,MAAM,YAAY,CAAC;AACpB,OAAO,KAAK,EACX,YAAY,EACZ,UAAU,EACV,eAAe,EACf,YAAY,EAGZ,QAAQ,EACR,MAAM,YAAY,CAAC;AA8BpB;;;GAGG;AACH,wBAAgB,SAAS,CACxB,OAAO,EAAE,YAAY,EAAE,EACvB,OAAO,EAAE,YAAY,EACrB,MAAM,EAAE,eAAe,EACvB,MAAM,CAAC,EAAE,WAAW,EACpB,QAAQ,CAAC,EAAE,QAAQ,GACjB,WAAW,CAAC,UAAU,EAAE,YAAY,EAAE,CAAC,CA8BzC;AAED;;;;;;;GAOG;AACH,wBAAgB,iBAAiB,CAChC,OAAO,EAAE,YAAY,EACrB,MAAM,EAAE,eAAe,EACvB,MAAM,CAAC,EAAE,WAAW,EACpB,QAAQ,CAAC,EAAE,QAAQ,GACjB,WAAW,CAAC,UAAU,EAAE,YAAY,EAAE,CAAC,CA+BzC"}
+{"version":3,"file":"agent-loop.d.ts","sourceRoot":"","sources":["../src/agent-loop.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAGN,WAAW,EAIX,MAAM,YAAY,CAAC;AACpB,OAAO,KAAK,EACX,YAAY,EACZ,UAAU,EACV,eAAe,EACf,YAAY,EAIZ,QAAQ,EACR,MAAM,YAAY,CAAC;AA8BpB;;;GAGG;AACH,wBAAgB,SAAS,CACxB,OAAO,EAAE,YAAY,EAAE,EACvB,OAAO,EAAE,YAAY,EACrB,MAAM,EAAE,eAAe,EACvB,MAAM,CAAC,EAAE,WAAW,EACpB,QAAQ,CAAC,EAAE,QAAQ,GACjB,WAAW,CAAC,UAAU,EAAE,YAAY,EAAE,CAAC,CA8BzC;AAED;;;;;;;GAOG;AACH,wBAAgB,iBAAiB,CAChC,OAAO,EAAE,YAAY,EACrB,MAAM,EAAE,eAAe,EACvB,MAAM,CAAC,EAAE,WAAW,EACpB,QAAQ,CAAC,EAAE,QAAQ,GACjB,WAAW,CAAC,UAAU,EAAE,YAAY,EAAE,CAAC,CA+BzC"}