groove-dev 0.27.111 → 0.27.113

package/moe-training/test/client/step-classifier.test.js

@@ -132,11 +132,11 @@ describe('StepClassifier', () => {
     assert.equal(StepClassifier.countUserInterventions(steps), 0);
   });
 
-  it('reclassifies action with error content to error', () => {
+  it('never reclassifies action to error', () => {
     const classifier = new StepClassifier();
     const step = { type: 'action', content: 'Command failed with exit code 1' };
     const result = classifier.onStep(step);
-    assert.equal(result.type, 'error');
+    assert.equal(result.type, 'action');
   });
 
   it('reclassifies observation with error content to error', () => {
@@ -215,19 +215,75 @@ describe('StepClassifier', () => {
     assert.equal(result.type, 'error');
   });
 
-  it('preserves action type when is_error is false', () => {
+  it('does not reclassify observation containing bare word "error" in source code', () => {
     const classifier = new StepClassifier();
-    const step = { type: 'action', content: 'Command failed with exit code 1', is_error: false };
+    const step = { type: 'observation', content: 'function handleError(err) { console.error(err); }' };
     const result = classifier.onStep(step);
-    assert.equal(result.type, 'action');
+    assert.equal(result.type, 'observation');
   });
 
-  it('still reclassifies action to error when is_error is not set', () => {
+  it('does not reclassify observation with "0 errors" or "found 0 vulnerabilities"', () => {
     const classifier = new StepClassifier();
-    const step = { type: 'action', content: 'Command failed with exit code 1' };
+    const step = { type: 'observation', content: 'Build succeeded\n0 errors, 0 warnings\nfound 0 vulnerabilities' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'observation');
+  });
+
+  it('does not reclassify observation reading a file that mentions exceptions', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: '{"scripts": {"build": "tsc && vite build"}, "name": "my-app"}' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'observation');
+  });
+
+  it('reclassifies observation with real TypeScript build error', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'src/main.ts(1,8): error TS2882: Cannot find module' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with Python traceback', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'Traceback (most recent call last):\n  File "main.py", line 5' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with actual TypeError message', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'TypeError: Cannot read properties of undefined (reading "map")' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with exit code failure', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'Process exited with exit code 1' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with ModuleNotFoundError', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'ModuleNotFoundError: No module named requests' };
     const result = classifier.onStep(step);
     assert.equal(result.type, 'error');
   });
+
+  it('preserves action type even with error keywords', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'action', content: 'Command failed with exit code 1' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'action');
+  });
+
+  it('preserves action type regardless of is_error flag', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'action', content: 'ENOENT: no such file', is_error: true };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'action');
+  });
 });
 
 describe('StepClassifier.classifyIntent', () => {

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.111",
+  "version": "0.27.113",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.111",
+  "version": "0.27.113",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/api.js

@@ -3855,6 +3855,48 @@ Keep responses concise. Help them think, don't lecture them about the system the
   // --- Preview Proxy (same-origin iframe support) ---
   // Forwards HTTP requests to the dev server so the GUI can iframe the preview
   // without cross-origin issues. WebSocket upgrade for HMR is handled in index.js.
+
+  function rewriteAbsoluteUrls(body, proxyBase) {
+    let out = body;
+    // HTML attributes: src, href, action, poster
+    out = out.replace(/((?:src|href|action|poster)\s*=\s*(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    // JS imports: from '/' and import('/')
+    out = out.replace(/(from\s+(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    out = out.replace(/(import\s*\(\s*(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    // CSS url()
+    out = out.replace(/(url\s*\(\s*(["']?))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    return out;
+  }
+
+  const REWRITABLE_TYPES = ['text/html', 'application/javascript', 'text/javascript', 'text/css'];
+
+  function handleProxyResponse(proxyRes, res, proxyBase) {
+    const fwdHeaders = { ...proxyRes.headers };
+    delete fwdHeaders['content-security-policy'];
+    delete fwdHeaders['x-frame-options'];
+
+    const ct = (fwdHeaders['content-type'] || '').toLowerCase();
+    const shouldRewrite = REWRITABLE_TYPES.some((t) => ct.includes(t));
+
+    if (!shouldRewrite) {
+      res.writeHead(proxyRes.statusCode, fwdHeaders);
+      proxyRes.pipe(res);
+      return;
+    }
+
+    const chunks = [];
+    proxyRes.on('data', (c) => chunks.push(c));
+    proxyRes.on('end', () => {
+      let body = Buffer.concat(chunks).toString('utf8');
+      body = rewriteAbsoluteUrls(body, proxyBase);
+      const buf = Buffer.from(body, 'utf8');
+      fwdHeaders['content-length'] = buf.length;
+      delete fwdHeaders['transfer-encoding'];
+      res.writeHead(proxyRes.statusCode, fwdHeaders);
+      res.end(buf);
+    });
+  }
+
   app.all('/api/preview/:teamId/proxy/*', (req, res) => {
     const entry = daemon.preview?.get(req.params.teamId);
     if (!entry || !entry.url) return res.status(404).json({ error: 'No active preview for this team' });
@@ -3865,9 +3907,11 @@ Keep responses concise. Help them think, don't lecture them about the system the
     const proxyPath = req.params[0] || '';
     const search = req.url.includes('?') ? '?' + req.url.split('?').slice(1).join('?') : '';
     const fullPath = '/' + proxyPath + search;
+    const proxyBase = `/api/preview/${req.params.teamId}/proxy`;
 
     const headers = { ...req.headers };
     delete headers.host;
+    delete headers['accept-encoding'];
     headers.host = targetUrl.host;
 
     const proxyReq = httpRequest({
@@ -3876,13 +3920,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
       path: fullPath,
       method: req.method,
       headers,
-    }, (proxyRes) => {
-      const fwdHeaders = { ...proxyRes.headers };
-      delete fwdHeaders['content-security-policy'];
-      delete fwdHeaders['x-frame-options'];
-      res.writeHead(proxyRes.statusCode, fwdHeaders);
-      proxyRes.pipe(res);
-    });
+    }, (proxyRes) => handleProxyResponse(proxyRes, res, proxyBase));
 
     proxyReq.on('error', (err) => {
       if (!res.headersSent) res.status(502).json({ error: `Proxy error: ${err.message}` });
@@ -3899,9 +3937,11 @@ Keep responses concise. Help them think, don't lecture them about the system the
     try { targetUrl = new URL(entry.devUrl || entry.url); } catch { return res.status(500).json({ error: 'Invalid preview URL' }); }
 
     const search = req.url.includes('?') ? '?' + req.url.split('?').slice(1).join('?') : '';
+    const proxyBase = `/api/preview/${req.params.teamId}/proxy`;
 
     const headers = { ...req.headers };
     delete headers.host;
+    delete headers['accept-encoding'];
     headers.host = targetUrl.host;
 
     const proxyReq = httpRequest({
@@ -3910,13 +3950,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
       path: '/' + search,
       method: req.method,
       headers,
-    }, (proxyRes) => {
-      const fwdHeaders = { ...proxyRes.headers };
-      delete fwdHeaders['content-security-policy'];
-      delete fwdHeaders['x-frame-options'];
-      res.writeHead(proxyRes.statusCode, fwdHeaders);
-      proxyRes.pipe(res);
-    });
+    }, (proxyRes) => handleProxyResponse(proxyRes, res, proxyBase));
 
     proxyReq.on('error', (err) => {
       if (!res.headersSent) res.status(502).json({ error: `Proxy error: ${err.message}` });
@@ -4855,9 +4889,13 @@ Keep responses concise. Help them think, don't lecture them about the system the
 
   app.get('/api/training/status', (req, res) => {
     let userId = null;
-    try { userId = ConsentManager.isCaptureEnabled() ? ConsentManager.getOrCreateUserId() : null; } catch (e) { /* no db yet */ }
+    let optedIn = false;
+    try {
+      userId = ConsentManager.getOrCreateUserId();
+      optedIn = ConsentManager.isCaptureEnabled();
+    } catch (e) { /* */ }
     res.json({
-      optedIn: !!daemon.config.training_opt_in,
+      optedIn,
       userId: userId ? userId.substring(0, 8) + '...' : null,
       captureActive: !!daemon.trajectoryCapture,
       sessionsCaptured: daemon.state.get('training_sessions_captured') || 0,
@@ -4869,52 +4907,23 @@ Keep responses concise. Help them think, don't lecture them about the system the
     const { enabled } = req.body;
     if (typeof enabled !== 'boolean') return res.status(400).json({ error: 'enabled must be boolean' });
 
-    const { saveConfig } = await import('./firstrun.js');
-
-    if (enabled) {
-      try {
-        await import('better-sqlite3');
-      } catch (modErr) {
-        console.error('[training/opt-in] Native module load failed:', modErr);
-        return res.status(500).json({
-          error: 'Failed to enable data sharing',
-          detail: 'Native SQLite module (better-sqlite3) is not available. On remote instances, ensure build tools are installed (gcc, g++, make, python3) and run: npm rebuild better-sqlite3',
-        });
-      }
-      try {
-        const userId = ConsentManager.getOrCreateUserId();
-        const consent = new ConsentManager();
-        try {
-          consent.recordConsent(userId, true, '1.0');
-        } finally {
-          consent.close();
-        }
-        daemon.config.training_opt_in = true;
-        saveConfig(daemon.grooveDir, daemon.config);
+    try {
+      const userId = ConsentManager.getOrCreateUserId();
+      const consent = new ConsentManager();
+      if (enabled) {
+        consent.recordConsent(userId, true, '1.0');
         await daemon._initTrajectoryCapture();
         daemon.state.set('training_enrolled_at', new Date().toISOString());
-      } catch (e) {
-        console.error('[training/opt-in] Failed to enable data sharing:', e);
-        daemon.config.training_opt_in = false;
-        saveConfig(daemon.grooveDir, daemon.config);
-        return res.status(500).json({ error: 'Failed to enable data sharing', detail: e.message });
-      }
-    } else {
-      daemon.config.training_opt_in = false;
-      saveConfig(daemon.grooveDir, daemon.config);
-      if (daemon.trajectoryCapture) {
-        try { await daemon.trajectoryCapture.shutdown(); } catch (e) { /* */ }
-        daemon.trajectoryCapture = null;
-      }
-      try {
-        const userId = ConsentManager.getOrCreateUserId();
-        const consent = new ConsentManager();
-        try {
-          consent.revokeConsent(userId);
-        } finally {
-          consent.close();
+      } else {
+        consent.revokeConsent(userId);
+        if (daemon.trajectoryCapture) {
+          try { await daemon.trajectoryCapture.shutdown(); } catch (e) { /* */ }
+          daemon.trajectoryCapture = null;
         }
-      } catch (e) { /* no user_id yet */ }
+      }
+    } catch (e) {
+      console.error('[training/opt-in] Failed to update data sharing:', e);
+      return res.status(500).json({ error: 'Failed to update data sharing', detail: e.message });
     }
 
     daemon.broadcast({ type: 'training:status', data: { optedIn: enabled, captureActive: !!daemon.trajectoryCapture } });
@@ -4924,18 +4933,13 @@ Keep responses concise. Help them think, don't lecture them about the system the
 
   app.post('/api/training/opt-in/delete', async (req, res) => {
     try {
-      daemon.config.training_opt_in = false;
-      const { saveConfig } = await import('./firstrun.js');
-      saveConfig(daemon.grooveDir, daemon.config);
+      const userId = ConsentManager.getOrCreateUserId();
+      const consent = new ConsentManager();
+      consent.revokeConsent(userId);
       if (daemon.trajectoryCapture) {
         try { await daemon.trajectoryCapture.shutdown(); } catch (e) { /* */ }
         daemon.trajectoryCapture = null;
       }
-      try {
-        const userId = ConsentManager.getOrCreateUserId();
-        const consent = new ConsentManager();
-        try { consent.revokeConsent(userId); } finally { consent.close(); }
-      } catch (e) { /* */ }
       daemon.broadcast({ type: 'training:status', data: { optedIn: false, captureActive: false } });
       if (daemon.audit) daemon.audit.log('training.delete', {});
       res.json({ ok: true, deleted: true });
@@ -4961,7 +4965,6 @@ Keep responses concise. Help them think, don't lecture them about the system the
       'port', 'journalistInterval', 'rotationThreshold', 'autoRotation',
       'qcThreshold', 'maxAgents', 'defaultProvider', 'defaultWorkingDir',
       'onboardingDismissed', 'defaultModel', 'defaultChatProvider', 'defaultChatModel',
-      'training_opt_in',
     ];
     for (const key of Object.keys(req.body)) {
       if (!ALLOWED_KEYS.includes(key)) {
@@ -6214,13 +6217,15 @@ Keep responses concise. Help them think, don't lecture them about the system the
         stdio: ['ignore', 'pipe', 'pipe'],
         env: tagEnv,
       });
+      daemon._networkCheckProc = proc;
       let stdout = '';
       let stderr = '';
       proc.stdout.on('data', (c) => { stdout += c.toString(); });
       proc.stderr.on('data', (c) => { stderr += c.toString(); });
       const timeout = setTimeout(() => { safeKill(proc, 'SIGTERM'); }, 10_000);
-      proc.on('error', () => { clearTimeout(timeout); resolvePromise(null); });
+      proc.on('error', () => { clearTimeout(timeout); daemon._networkCheckProc = null; resolvePromise(null); });
       proc.on('close', (code) => {
+        daemon._networkCheckProc = null;
         clearTimeout(timeout);
         if (code !== 0) return resolvePromise(null);
         const tags = [];

package/node_modules/@groove-dev/daemon/src/index.js

@@ -290,11 +290,11 @@ export class Daemon {
     });
 
     // Debounced file I/O for registry changes (at most once per 2s)
-    let _registryIoTimer = null;
+    this._registryIoTimer = null;
     const _debouncedRegistryIo = () => {
-      if (_registryIoTimer) return;
-      _registryIoTimer = setTimeout(() => {
-        _registryIoTimer = null;
+      if (this._registryIoTimer) return;
+      this._registryIoTimer = setTimeout(() => {
+        this._registryIoTimer = null;
         this.introducer.writeRegistryFile(this.projectDir);
         this.introducer.injectGrooveSection(this.projectDir);
       }, 2000);
@@ -666,17 +666,15 @@ export class Daemon {
   }
 
   async _initTrajectoryCapture() {
-    if (!this.config.training_opt_in) return;
     try {
-      if (ConsentManager.isCaptureEnabled()) {
-        const pkgPath = new URL('../package.json', import.meta.url);
-        const version = JSON.parse(readFileSync(pkgPath, 'utf8')).version;
-        this.trajectoryCapture = new TrajectoryCapture({
-          centralCommandUrl: process.env.GROOVE_CENTRAL_URL || 'https://api.groovedev.ai',
-          grooveVersion: version,
-        });
-        this.trajectoryCapture.init();
-      }
+      if (!ConsentManager.isCaptureEnabled()) return;
+      const pkgPath = new URL('../package.json', import.meta.url);
+      const version = JSON.parse(readFileSync(pkgPath, 'utf8')).version;
+      this.trajectoryCapture = new TrajectoryCapture({
+        centralCommandUrl: process.env.GROOVE_CENTRAL_URL || 'https://api.groovedev.ai',
+        grooveVersion: version,
+      });
+      this.trajectoryCapture.init();
     } catch (e) {
       // Training capture is never critical
     }
@@ -781,6 +779,11 @@ export class Daemon {
     if (this._stateSaveInterval) clearInterval(this._stateSaveInterval);
     if (this._classifierInterval) clearInterval(this._classifierInterval);
     if (this._subscriptionPollInterval) clearInterval(this._subscriptionPollInterval);
+    if (this._registryIoTimer) clearTimeout(this._registryIoTimer);
+    if (this._networkCheckProc) {
+      try { this._networkCheckProc.kill(); } catch { /* already exited */ }
+      this._networkCheckProc = null;
+    }
 
     // Clean up file watchers and terminal sessions
     this.fileWatcher.unwatchAll();
@@ -825,10 +828,19 @@ export class Daemon {
 
     // Close server
     return new Promise((resolvePromise) => {
-      this.wss.close(() => {
-        this.server.close(() => {
-          console.log('GROOVE daemon stopped.');
-          resolvePromise();
+      this.federationWss.close(() => {
+        this.wss.close(() => {
+          this.server.close(() => {
+            // Unref lingering handles (idle fetch/undici TLS pool connections,
+            // closed servers) so they don't prevent process exit in tests.
+            for (const h of process._getActiveHandles()) {
+              if (typeof h.unref === 'function' && h !== process.stdout && h !== process.stderr) {
+                h.unref();
+              }
+            }
+            console.log('GROOVE daemon stopped.');
+            resolvePromise();
+          });
         });
       });
     });