gloomberb 0.7.0 → 0.7.2

package/src/renderers/electrobun/bun/index.ts

@@ -13,7 +13,7 @@ import * as nodeConfigStoreHost from "../../../data/config-store-node";
 import { cloneLayout, findPaneInstance, type AppConfig } from "../../../types/config";
 import type { AppSessionSnapshot } from "../../../core/state/session-persistence";
 import type { PaneRuntimeState } from "../../../core/state/app-state";
-import type { DesktopDockPreviewState, DesktopSharedStateSnapshot } from "../../../types/desktop-window";
+import type { DesktopDockPreviewState, DesktopSharedStateSnapshot, DesktopThemePreviewState } from "../../../types/desktop-window";
 import type { ReleaseInfo, UpdateCheckResult, UpdateProgress } from "../../../updater";
 import { buildSoundCommand } from "../../../notifications/app-notifier";
 import { isPaneDetached } from "../../../plugins/pane-manager";
@@ -37,8 +37,12 @@ import {
   type WindowFrame,
   type WindowMinimumSize,
 } from "./window-frame";
-
-const MAIN_WINDOW_RPC_KEY = "main";
+import {
+  detachedRpcKey,
+  focusWindowForRpcKey,
+  MAIN_WINDOW_RPC_KEY,
+  paneIdFromDetachedRpcKey,
+} from "./window-focus";
 
 type DesktopRpc = ReturnType<typeof BrowserView.defineRPC<ElectrobunDesktopRpcSchema>>;
 type WindowMoveEvent = { data?: { x?: number; y?: number } };
@@ -61,6 +65,7 @@ let services: AppServices | null = null;
 let mainWindow: BrowserWindow | null = null;
 let desktopWorkspace: DesktopWorkspace | null = null;
 let currentDockPreview: DesktopDockPreviewState = { paneId: null, edge: null };
+let currentThemePreview: DesktopThemePreviewState = { theme: null };
 let desktopUpdateInProgress = false;
 
 const detachedWindows = new Map<string, BrowserWindow>();
@@ -101,10 +106,6 @@ function requireDesktopWorkspace(): DesktopWorkspace {
   return desktopWorkspace;
 }
 
-function detachedRpcKey(instanceId: string): string {
-  return `detached:${instanceId}`;
-}
-
 function registerWindowRpc(key: string, rpc: DesktopRpc): void {
   windowRpcs.set(key, rpc);
   rpcWindowKeys.set(rpc, key);
@@ -156,10 +157,11 @@ function normalizeInitWindowTarget(
   if (rpcKey === MAIN_WINDOW_RPC_KEY) {
     return { kind: "main" };
   }
-  if (rpcKey?.startsWith("detached:")) {
+  const detachedPaneId = paneIdFromDetachedRpcKey(rpcKey);
+  if (detachedPaneId) {
     return {
       kind: "detached",
-      paneId: rpcKey.slice("detached:".length) || undefined,
+      paneId: detachedPaneId,
     };
   }
   const kind = payload.kind === "detached" ? "detached" : "main";
@@ -560,6 +562,17 @@ function sendDockPreview(preview: DesktopDockPreviewState): void {
   });
 }
 
+function sendThemePreview(preview: DesktopThemePreviewState): void {
+  if (currentThemePreview.theme === preview.theme) return;
+  currentThemePreview = preview;
+  const encodedPreview = encodeRpcValue(preview) as DesktopThemePreviewState;
+  forEachReadyWindowRpc((rpc) => {
+    rpc.send["desktop.themePreview"]({
+      preview: encodedPreview,
+    });
+  });
+}
+
 function clearDockPreview(paneId?: string): void {
   if (paneId && currentDockPreview.paneId && currentDockPreview.paneId !== paneId) return;
   sendDockPreview({ paneId: null, edge: null });
@@ -848,6 +861,7 @@ async function initialize(
     config: requireConfig(),
     sessionSnapshot: getSessionSnapshot(),
     desktopSnapshot: getDesktopSnapshot(),
+    desktopThemePreview: currentThemePreview,
     pluginState: loadPluginState(),
     capabilityManifests: requireServices().pluginRegistry.capabilities.manifests({ rendererOnly: true }),
     windowKind: windowTarget.kind,
@@ -869,6 +883,9 @@ async function handleDesktop(
       sendDesktopState(snapshot);
       return null;
     }
+    case "desktop.setThemePreview":
+      sendThemePreview((payload.preview ?? { theme: null }) as DesktopThemePreviewState);
+      return null;
     case "desktop.replaceDetachedPaneState":
       if (typeof payload.paneId !== "string") {
         throw new Error("desktop.replaceDetachedPaneState requires paneId.");
@@ -881,7 +898,7 @@ async function handleDesktop(
       }
       const snapshot = workspace.popOutPane(payload.paneId, resolveDetachedWindowFrame(payload.paneId));
       await commitDesktopSnapshot(snapshot);
-      (detachedWindows.get(payload.paneId) as any)?.focus?.();
+      focusWindowForRpcKey(detachedRpcKey(payload.paneId), mainWindow, detachedWindows);
       return null;
     }
     case "desktop.dockDetachedPane": {
@@ -911,7 +928,7 @@ async function handleDesktop(
       if (typeof payload.paneId !== "string") {
         throw new Error("desktop.focusDetachedPane requires paneId.");
       }
-      (detachedWindows.get(payload.paneId) as any)?.focus?.();
+      focusWindowForRpcKey(detachedRpcKey(payload.paneId), mainWindow, detachedWindows);
       return null;
     default:
       throw new Error(`Unknown desktop method: ${method}`);
@@ -1055,6 +1072,9 @@ async function handleBackendRequest(
     case "host.copyText":
       Utils.clipboardWriteText(normalizeText(payload.text) ?? "");
       return null;
+    case "host.focusWindow":
+      focusWindowForRpcKey(getRpcWindowKey(rpc), mainWindow, detachedWindows);
+      return null;
     case "host.copyPngImage": {
       const pngBase64 = normalizeText(payload.pngBase64);
       if (!pngBase64) throw new Error("host.copyPngImage requires PNG data.");
@@ -1141,6 +1161,7 @@ mainWindow = new BrowserWindow({
   sandbox: false,
 });
 updateWindowFrameCache(mainWindow, DEFAULT_WINDOW_FRAME, MAIN_WINDOW_MIN_SIZE);
+focusWindowForRpcKey(MAIN_WINDOW_RPC_KEY, mainWindow, detachedWindows);
 (mainWindow as any).on?.("move", (event: WindowMoveEvent) => {
   applyWindowMoveEvent(mainWindow, event);
 });

package/src/renderers/electrobun/bun/window-focus.ts

@@ -0,0 +1,37 @@
+export const MAIN_WINDOW_RPC_KEY = "main";
+
+const DETACHED_WINDOW_RPC_PREFIX = "detached:";
+
+export interface FocusableElectrobunWindow {
+  focus?: () => void;
+}
+
+export function detachedRpcKey(instanceId: string): string {
+  return `${DETACHED_WINDOW_RPC_PREFIX}${instanceId}`;
+}
+
+export function paneIdFromDetachedRpcKey(rpcKey: string | undefined): string | null {
+  if (!rpcKey?.startsWith(DETACHED_WINDOW_RPC_PREFIX)) return null;
+  return rpcKey.slice(DETACHED_WINDOW_RPC_PREFIX.length) || null;
+}
+
+export function resolveWindowForRpcKey<T>(
+  rpcKey: string | undefined,
+  mainWindow: T | null,
+  detachedWindows: ReadonlyMap<string, T>,
+): T | null {
+  if (rpcKey === MAIN_WINDOW_RPC_KEY) return mainWindow;
+  const paneId = paneIdFromDetachedRpcKey(rpcKey);
+  return paneId ? detachedWindows.get(paneId) ?? null : null;
+}
+
+export function focusWindowForRpcKey(
+  rpcKey: string | undefined,
+  mainWindow: FocusableElectrobunWindow | null,
+  detachedWindows: ReadonlyMap<string, FocusableElectrobunWindow>,
+): boolean {
+  const window = resolveWindowForRpcKey(rpcKey, mainWindow, detachedWindows);
+  if (!window?.focus) return false;
+  window.focus();
+  return true;
+}

package/src/renderers/electrobun/shared/protocol.ts

@@ -1,5 +1,5 @@
 import type { AppSessionSnapshot } from "../../../core/state/session-persistence";
-import type { DesktopDockPreviewState, DesktopSharedStateSnapshot } from "../../../types/desktop-window";
+import type { DesktopDockPreviewState, DesktopSharedStateSnapshot, DesktopThemePreviewState } from "../../../types/desktop-window";
 import type { DesktopApplicationMenuCommand } from "../../../types/desktop-menu";
 import type { AppConfig } from "../../../types/config";
 import type { UpdateProgress } from "../../../updater";
@@ -11,6 +11,7 @@ export interface ElectrobunBackendInit {
   config: AppConfig;
   sessionSnapshot: AppSessionSnapshot | null;
   desktopSnapshot: DesktopSharedStateSnapshot | null;
+  desktopThemePreview: DesktopThemePreviewState;
   pluginState: Record<string, Record<string, unknown>>;
   capabilityManifests: CapabilityManifest[];
   windowKind: "main" | "detached";
@@ -39,6 +40,10 @@ export interface DesktopDockPreviewMessage {
   preview: DesktopDockPreviewState;
 }
 
+export interface DesktopThemePreviewMessage {
+  preview: DesktopThemePreviewState;
+}
+
 export interface UpdateProgressMessage {
   progress: UpdateProgress;
 }
@@ -65,6 +70,7 @@ export interface ElectrobunDesktopRpcSchema {
       "application-menu.select": ApplicationMenuSelectMessage;
       "desktop.state": DesktopStateMessage;
       "desktop.dockPreview": DesktopDockPreviewMessage;
+      "desktop.themePreview": DesktopThemePreviewMessage;
       "update.progress": UpdateProgressMessage;
       "capability.event": CapabilityEventMessage;
     };

package/src/renderers/electrobun/view/app-services.ts

@@ -6,7 +6,7 @@ import { PluginRegistry } from "../../../plugins/registry";
 import type { AppServices } from "../../../core/app-services";
 import type { AppConfig } from "../../../types/config";
 import type { DataProvider, QuoteSubscriptionTarget } from "../../../types/data-provider";
-import type { Quote } from "../../../types/financials";
+import type { Quote, TickerFinancials } from "../../../types/financials";
 import type { NewsArticle, NewsQuery } from "../../../news/types";
 import type { TickerRecord, TickerMetadata } from "../../../types/ticker";
 import { newsProvider, type CapabilityManifest } from "../../../capabilities";
@@ -21,7 +21,6 @@ import { debugLog } from "../../../utils/debug-log";
 import { measurePerf } from "../../../utils/perf-marks";
 import { getRendererBuiltinPlugins } from "../../../plugins/catalog-ui";
 
-const REMOTE_DATA_REQUEST_CACHE_LIMIT = 150;
 const servicesLog = debugLog.createLogger("services");
 const ASSET_DATA_CAPABILITY_ID = "asset-data.asset-data-router";
 const NEWS_CAPABILITY_ID = "news.core";
@@ -58,6 +57,9 @@ type PayloadBuilder = (...args: any[]) => Record<string, unknown>;
 
 const assetDataPayloads: Record<string, PayloadBuilder> = {
   canProvide: (ticker, exchange, context) => ({ ticker, exchange, context }),
+  getCachedFinancialsForTargets: (targets, options) => ({ targets, options }),
+  getQuotesBatch: (targets, options) => ({ targets, options }),
+  getTickerFinancialsBatch: (targets, options) => ({ targets, options }),
   getTickerFinancials: (ticker, exchange, context) => ({ ticker, exchange, context }),
   getQuote: (ticker, exchange, context) => ({ ticker, exchange, context }),
   getExchangeRate: (fromCurrency) => ({ fromCurrency }),
@@ -96,21 +98,16 @@ function hasRendererOperation(operations: Set<string> | null, operationId: strin
 }
 
 function createCapabilityInvoker() {
-  const requestCache = new Map<string, Promise<unknown>>();
+  const inFlightRequests = new Map<string, Promise<unknown>>();
   return function invoke<T>(capabilityId: string, operationId: string, payload: unknown): Promise<T> {
     const requestPayload = { capabilityId, operationId, payload };
     const key = JSON.stringify(requestPayload);
-    const cached = requestCache.get(key);
-    if (cached) return cached as Promise<T>;
-    const promise = backendRequest<T>("capability.invoke", requestPayload).catch((error) => {
-      requestCache.delete(key);
-      throw error;
+    const inFlight = inFlightRequests.get(key);
+    if (inFlight) return inFlight as Promise<T>;
+    const promise = backendRequest<T>("capability.invoke", requestPayload).finally(() => {
+      inFlightRequests.delete(key);
     });
-    requestCache.set(key, promise);
-    if (requestCache.size > REMOTE_DATA_REQUEST_CACHE_LIMIT) {
-      const oldestKey = requestCache.keys().next().value;
-      if (oldestKey) requestCache.delete(oldestKey);
-    }
+    inFlightRequests.set(key, promise);
     return promise;
   };
 }
@@ -120,10 +117,69 @@ function createRemoteAssetDataClient(): RemoteAssetDataClient {
   const assetDataOperations = getRendererOperationIds(ASSET_DATA_CAPABILITY_ID);
   const newsOperations = getRendererOperationIds(NEWS_CAPABILITY_ID);
   let nextSubscriptionId = 1;
+  const quoteListeners = new Map<string, {
+    target: QuoteSubscriptionTarget;
+    listeners: Set<(target: QuoteSubscriptionTarget, quote: Quote) => void>;
+  }>();
+  let quoteBackendSubscriptionId: string | null = null;
+  let disposeQuoteBackendMessages: (() => void) | null = null;
+  let quoteBackendFlushTimer: ReturnType<typeof setTimeout> | null = null;
+
+  const quoteTargetKey = (target: QuoteSubscriptionTarget) =>
+    `${target.symbol}:${target.exchange ?? ""}:${target.context?.brokerId ?? ""}:${target.context?.brokerInstanceId ?? ""}:${target.context?.instrument?.conId ?? target.context?.instrument?.localSymbol ?? ""}`;
+
+  const scheduleQuoteBackendSubscriptionFlush = () => {
+    if (quoteBackendFlushTimer) return;
+    quoteBackendFlushTimer = setTimeout(() => {
+      quoteBackendFlushTimer = null;
+      flushQuoteBackendSubscription();
+    }, 25);
+  };
+
+  const flushQuoteBackendSubscription = () => {
+    if (!hasRendererOperation(assetDataOperations, "subscribeQuotes")) return;
+    const targets = [...quoteListeners.values()].map((entry) => entry.target);
+    const previousSubscriptionId = quoteBackendSubscriptionId;
+    if (previousSubscriptionId) {
+      quoteBackendSubscriptionId = null;
+      disposeQuoteBackendMessages?.();
+      disposeQuoteBackendMessages = null;
+      void backendRequest("capability.unsubscribe", { subscriptionId: previousSubscriptionId }).catch(() => {});
+    }
+    if (targets.length === 0) return;
+
+    const subscriptionId = `quote:${nextSubscriptionId++}`;
+    quoteBackendSubscriptionId = subscriptionId;
+    disposeQuoteBackendMessages = onCapabilityEvent(subscriptionId, (message) => {
+      const event = message.event as { target: QuoteSubscriptionTarget; quote: Quote };
+      const key = quoteTargetKey(event.target);
+      for (const listener of quoteListeners.get(key)?.listeners ?? []) {
+        listener(event.target, event.quote);
+      }
+    });
+    void backendRequest("capability.subscribe", {
+      subscriptionId,
+      capabilityId: ASSET_DATA_CAPABILITY_ID,
+      operationId: "subscribeQuotes",
+      payload: { targets },
+    }).catch((error) => {
+      if (quoteBackendSubscriptionId === subscriptionId) {
+        quoteBackendSubscriptionId = null;
+        disposeQuoteBackendMessages?.();
+        disposeQuoteBackendMessages = null;
+      }
+      console.error("Failed to subscribe to backend quotes", error);
+    });
+  };
+
   const base = {
     id: "desktop-backend",
     name: "Gloomberb Backend",
-    getCachedFinancialsForTargets: () => new Map(),
+    getCachedFinancialsForTargets: (targets, options) => (
+      hasRendererOperation(assetDataOperations, "getCachedFinancialsForTargets")
+        ? invoke<Map<string, TickerFinancials>>(ASSET_DATA_CAPABILITY_ID, "getCachedFinancialsForTargets", { targets, options })
+        : new Map()
+    ),
     getNews: (query: NewsQuery) => (
       hasRendererOperation(newsOperations, "fetchNews")
         ? invoke<NewsArticle[]>(NEWS_CAPABILITY_ID, "fetchNews", { query })
@@ -142,28 +198,29 @@ function createRemoteAssetDataClient(): RemoteAssetDataClient {
       ).values()];
       if (uniqueTargets.length === 0) return () => {};
 
-      const subscriptionId = `quote:${nextSubscriptionId++}`;
-      const disposeMessages = onCapabilityEvent(subscriptionId, (message) => {
-        const event = message.event as { target: QuoteSubscriptionTarget; quote: Quote };
-        onQuote(event.target, event.quote);
-      });
       let disposed = false;
-
-      void backendRequest("capability.subscribe", {
-        subscriptionId,
-        capabilityId: ASSET_DATA_CAPABILITY_ID,
-        operationId: "subscribeQuotes",
-        payload: { targets: uniqueTargets },
-      }).catch((error) => {
-        disposeMessages();
-        console.error("Failed to subscribe to backend quotes", error);
-      });
+      for (const target of uniqueTargets) {
+        const key = quoteTargetKey(target);
+        const entry = quoteListeners.get(key) ?? { target, listeners: new Set() };
+        entry.target = target;
+        entry.listeners.add(onQuote);
+        quoteListeners.set(key, entry);
+      }
+      scheduleQuoteBackendSubscriptionFlush();
 
       return () => {
         if (disposed) return;
         disposed = true;
-        disposeMessages();
-        void backendRequest("capability.unsubscribe", { subscriptionId }).catch(() => {});
+        for (const target of uniqueTargets) {
+          const key = quoteTargetKey(target);
+          const entry = quoteListeners.get(key);
+          if (!entry) continue;
+          entry.listeners.delete(onQuote);
+          if (entry.listeners.size === 0) {
+            quoteListeners.delete(key);
+          }
+        }
+        scheduleQuoteBackendSubscriptionFlush();
       };
     },
   };

package/src/renderers/electrobun/view/backend-rpc.ts

@@ -7,6 +7,7 @@ import {
   type ContextMenuSelectMessage,
   type DesktopDockPreviewMessage,
   type DesktopStateMessage,
+  type DesktopThemePreviewMessage,
   type ElectrobunBackendInit,
   type ElectrobunDesktopRpcSchema,
   type UpdateProgressMessage,
@@ -17,6 +18,7 @@ type ContextMenuSelectListener = (message: ContextMenuSelectMessage) => void;
 type ApplicationMenuSelectListener = (message: ApplicationMenuSelectMessage) => void;
 type DesktopStateListener = (message: DesktopStateMessage) => void;
 type DesktopDockPreviewListener = (message: DesktopDockPreviewMessage) => void;
+type DesktopThemePreviewListener = (message: DesktopThemePreviewMessage) => void;
 type UpdateProgressListener = (message: UpdateProgressMessage) => void;
 type CapabilityEventListener = (message: CapabilityEventMessage) => void;
 
@@ -25,6 +27,7 @@ const contextMenuSelectListeners = new Map<string, Set<ContextMenuSelectListener
 const applicationMenuSelectListeners = new Set<ApplicationMenuSelectListener>();
 const desktopStateListeners = new Set<DesktopStateListener>();
 const desktopDockPreviewListeners = new Set<DesktopDockPreviewListener>();
+const desktopThemePreviewListeners = new Set<DesktopThemePreviewListener>();
 const updateProgressListeners = new Set<UpdateProgressListener>();
 const capabilityEventListeners = new Map<string, Set<CapabilityEventListener>>();
 
@@ -81,6 +84,11 @@ const rpc = Electroview.defineRPC<ElectrobunDesktopRpcSchema>({
           listener({ preview: decodeRpcValue(message.preview) });
         }
       },
+      "desktop.themePreview": (message) => {
+        for (const listener of desktopThemePreviewListeners) {
+          listener({ preview: decodeRpcValue(message.preview) });
+        }
+      },
       "update.progress": (message) => {
         const decoded = { progress: decodeRpcValue<UpdateProgressMessage["progress"]>(message.progress) };
         for (const listener of updateProgressListeners) {
@@ -165,6 +173,13 @@ export function onDesktopDockPreview(listener: DesktopDockPreviewListener): () =
   };
 }
 
+export function onDesktopThemePreview(listener: DesktopThemePreviewListener): () => void {
+  desktopThemePreviewListeners.add(listener);
+  return () => {
+    desktopThemePreviewListeners.delete(listener);
+  };
+}
+
 export function onUpdateProgress(listener: UpdateProgressListener): () => void {
   updateProgressListeners.add(listener);
   return () => {