gloomberb 0.7.0 → 0.7.2

package/src/plugins/builtin/market-movers/screener.ts

@@ -1,14 +1,54 @@
-import { createThrottledFetch } from "../../../utils/throttled-fetch";
-
-const screenerClient = createThrottledFetch({
-  requestsPerMinute: 15,
-  maxRetries: 2,
-  timeoutMs: 10_000,
-  defaultHeaders: {
-    "User-Agent": "Gloomberb/0.4.1",
-    Accept: "application/json",
-  },
-});
+import { createThrottledFetch, type ThrottledFetchTransport } from "../../../utils/throttled-fetch";
+
+const YAHOO_FINANCE_HOSTS = [
+  "query2.finance.yahoo.com",
+  "query1.finance.yahoo.com",
+] as const;
+
+const YAHOO_FINANCE_HEADERS = {
+  "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36",
+  Accept: "application/json,text/plain,*/*",
+  "Accept-Language": "en-US,en;q=0.9",
+  Referer: "https://finance.yahoo.com/",
+};
+
+export interface YahooScreenerApi {
+  fetchJson<T = unknown>(path: string, params: Record<string, string | number>): Promise<T>;
+}
+
+export function createYahooScreenerApi(transport?: ThrottledFetchTransport): YahooScreenerApi {
+  const client = createThrottledFetch({
+    requestsPerMinute: 15,
+    maxRetries: 2,
+    timeoutMs: 10_000,
+    defaultHeaders: YAHOO_FINANCE_HEADERS,
+    transport,
+  });
+
+  return {
+    async fetchJson<T = unknown>(path: string, params: Record<string, string | number>): Promise<T> {
+      let lastError: unknown;
+      for (const host of YAHOO_FINANCE_HOSTS) {
+        const url = new URL(`https://${host}${path}`);
+        for (const [key, value] of Object.entries(params)) {
+          url.searchParams.set(key, String(value));
+        }
+
+        try {
+          return await client.fetchJson<T>(url.toString());
+        } catch (error) {
+          lastError = error;
+        }
+      }
+
+      throw lastError instanceof Error
+        ? lastError
+        : new Error("Yahoo Finance screener request failed");
+    },
+  };
+}
+
+const screenerApi = createYahooScreenerApi();
 
 export type ScreenerCategory = "day_gainers" | "day_losers" | "most_actives";
 
@@ -75,9 +115,18 @@ export function parseScreenerResponse(data: any): ScreenerQuote[] {
   }
 }
 
-export async function fetchScreener(category: ScreenerCategory, count = 25): Promise<ScreenerQuote[]> {
-  const url = `https://query2.finance.yahoo.com/v1/finance/screener/predefined/saved?scrIds=${category}&count=${count}`;
-  const data = await screenerClient.fetchJson(url);
+export async function fetchScreener(
+  category: ScreenerCategory,
+  count = 25,
+  api: YahooScreenerApi = screenerApi,
+): Promise<ScreenerQuote[]> {
+  const data = await api.fetchJson("/v1/finance/screener/predefined/saved", {
+    formatted: "false",
+    lang: "en-US",
+    region: "US",
+    scrIds: category,
+    count,
+  });
   return parseScreenerResponse(data);
 }
 
@@ -96,9 +145,13 @@ export function parseTrendingResponse(data: any): TrendingSymbol[] {
   }
 }
 
-export async function fetchTrending(count = 25): Promise<TrendingSymbol[]> {
-  const url = `https://query2.finance.yahoo.com/v1/finance/trending/US?count=${count}`;
-  const data = await screenerClient.fetchJson(url);
+export async function fetchTrending(
+  count = 25,
+  api: YahooScreenerApi = screenerApi,
+): Promise<TrendingSymbol[]> {
+  const data = await api.fetchJson("/v1/finance/trending/US", {
+    count,
+  });
   return parseTrendingResponse(data);
 }
 

package/src/plugins/builtin/news-wire/breaking-pane.tsx

@@ -1,7 +1,7 @@
 import { Box } from "../../../ui";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import type { PaneProps } from "../../../types/plugin";
-import { useNewsArticles } from "../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles } from "../../../news/hooks";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../plugin-runtime";
 import { Spinner } from "../../../components";
 import type { MarketNewsItem } from "../../../types/news-source";
@@ -41,7 +41,8 @@ export function BreakingPane({ focused, width, height }: PaneProps) {
   const [aiRunning, setAiRunning] = useState(false);
   const [spinFrame, setSpinFrame] = useState(0);
   const processingRef = useRef(false);
-  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles);
+  const loadNewsStory = useLoadNewsStory();
+  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles, loadNewsStory);
   const { readArticleIds, markArticleRead } = useNewsReadState();
 
   useEffect(() => {

package/src/plugins/builtin/news-wire/industry-pane.tsx

@@ -2,7 +2,7 @@ import { Box } from "../../../ui";
 import { useEffect, useMemo } from "react";
 import type { PaneProps } from "../../../types/plugin";
 import type { MarketNewsItem } from "../../../types/news-source";
-import { useNewsArticles } from "../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles } from "../../../news/hooks";
 import type { NewsQueryPhase } from "../../../news/types";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../plugin-runtime";
 import { Spinner, Tabs } from "../../../components";
@@ -43,7 +43,8 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
   const [sortPreference, setSortPreference] = usePluginPaneState<NewsSortPreference>("industry:sort", DEFAULT_SORT);
   const { articles, allArticles, phase } = useIndustryArticles(category);
   const loading = phase === "loading" || (phase === "refreshing" && articles.length === 0);
-  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles);
+  const loadNewsStory = useLoadNewsStory();
+  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles, loadNewsStory);
   const { readArticleIds, markArticleRead } = useNewsReadState();
   const counts = useMemo(() => {
     const next: Record<string, number> = { all: allArticles.length };
@@ -64,21 +65,6 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
     setSelectedArticleId(null);
   }, [category, setSelectedArticleId]);
 
-  const handleRootKeyDown = (event: {
-    name?: string;
-    preventDefault?: () => void;
-    stopPropagation?: () => void;
-  }) => {
-    if (event.name !== "left" && event.name !== "right" && event.name !== "h" && event.name !== "l") return;
-    event.stopPropagation?.();
-    event.preventDefault?.();
-    const index = SECTOR_TABS.indexOf(category);
-    const delta = event.name === "left" || event.name === "h" ? -1 : 1;
-    const nextIndex = Math.max(0, Math.min(SECTOR_TABS.length - 1, index + delta));
-    setCategory(SECTOR_TABS[nextIndex]!);
-    return true;
-  };
-
   useNewsArticleFooter({
     registrationId: "news-wire:industry",
     focused,
@@ -93,6 +79,7 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
         onSelect={(value) => setCategory(value as SectorNewsSelection)}
         compact
         variant="bare"
+        focused={focused}
       />
     </Box>
   );
@@ -126,7 +113,6 @@ export function IndustryPane({ focused, width, height }: PaneProps) {
       detailContent={detailContent}
       detailTitle={detailArticle?.title}
       rootBefore={rootBefore}
-      onRootKeyDown={handleRootKeyDown}
       columns={["time", "source", "title", "tickers", "categories"]}
       emptyContent={loading && articles.length === 0 ? (
         <Box width="100%" paddingX={1} paddingY={1}>

package/src/plugins/builtin/news-wire/news-detail-view.tsx

@@ -10,9 +10,27 @@ import { collectNewsDisplayTickers } from "../../../news/ticker-symbols";
 import { useInlineTickers } from "../../../state/use-inline-tickers";
 import { wrapTextLines } from "../../../utils/text-wrap";
 
-export function useNewsArticleDetail(articles: MarketNewsItem[]) {
+function hasStoryItems(article: MarketNewsItem | null): boolean {
+  return (article?.items?.length ?? 0) > 0;
+}
+
+function mergeLoadedArticle(base: MarketNewsItem, loaded: MarketNewsItem | null | undefined): MarketNewsItem {
+  if (!loaded) return base;
+  return {
+    ...base,
+    ...loaded,
+    items: hasStoryItems(loaded) ? loaded.items : base.items,
+  };
+}
+
+export function useNewsArticleDetail(
+  articles: MarketNewsItem[],
+  loadArticleDetail?: (articleId: string) => Promise<MarketNewsItem | null>,
+) {
   const [detailArticleId, setDetailArticleId] = useState<string | null>(null);
-  const detailArticle = useMemo(
+  const [loadedArticles, setLoadedArticles] = useState<Map<string, MarketNewsItem>>(() => new Map());
+  const requestedArticleIds = useRef<Set<string>>(new Set());
+  const baseDetailArticle = useMemo(
     () => (
       detailArticleId
         ? articles.find((article) => article.id === detailArticleId) ?? null
@@ -20,12 +38,36 @@ export function useNewsArticleDetail(articles: MarketNewsItem[]) {
     ),
     [articles, detailArticleId],
   );
+  const detailArticle = useMemo(() => (
+    baseDetailArticle && detailArticleId
+      ? mergeLoadedArticle(baseDetailArticle, loadedArticles.get(detailArticleId))
+      : baseDetailArticle
+  ), [baseDetailArticle, detailArticleId, loadedArticles]);
 
   useEffect(() => {
-    if (detailArticleId && !detailArticle) {
+    if (detailArticleId && !baseDetailArticle) {
       setDetailArticleId(null);
     }
-  }, [detailArticle, detailArticleId]);
+  }, [baseDetailArticle, detailArticleId]);
+
+  useEffect(() => {
+    if (!detailArticleId || !baseDetailArticle || hasStoryItems(detailArticle)) return;
+    if (!loadArticleDetail || requestedArticleIds.current.has(detailArticleId)) return;
+
+    requestedArticleIds.current.add(detailArticleId);
+    void loadArticleDetail(detailArticleId)
+      .then((loadedArticle) => {
+        if (!loadedArticle) return;
+        setLoadedArticles((current) => {
+          const next = new Map(current);
+          next.set(detailArticleId, loadedArticle);
+          return next;
+        });
+      })
+      .catch(() => {
+        requestedArticleIds.current.delete(detailArticleId);
+      });
+  }, [baseDetailArticle, detailArticle, detailArticleId, loadArticleDetail]);
 
   const openArticle = useCallback((article: MarketNewsItem) => {
     setDetailArticleId(article.id);

package/src/plugins/builtin/news-wire/news-preset-pane.tsx

@@ -1,6 +1,6 @@
 import { Box } from "../../../ui";
 import type { NewsQuery } from "../../../news/types";
-import { useNewsArticles } from "../../../news/hooks";
+import { useLoadNewsStory, useNewsArticles } from "../../../news/hooks";
 import type { PaneProps } from "../../../types/plugin";
 import { useDebouncedPluginPaneState, usePluginPaneState } from "../../plugin-runtime";
 import { Spinner } from "../../../components";
@@ -45,7 +45,8 @@ export function NewsPresetPane({
     `${paneKey}:sort`,
     defaultSort,
   );
-  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles);
+  const loadNewsStory = useLoadNewsStory();
+  const { detailArticle, openArticle, closeDetail } = useNewsArticleDetail(articles, loadNewsStory);
   const { readArticleIds, markArticleRead } = useNewsReadState();
 
   useNewsArticleFooter({

package/src/plugins/builtin/notes.tsx

@@ -473,6 +473,7 @@ function createQuickNotesPane(notesFiles: NotesFiles) {
             variant="pill"
             closeMode="active"
             onAdd={addTab}
+            focused={focused && !editing && !renaming}
           />
         </Box>
         {/* Rename input */}

package/src/plugins/builtin/options.tsx

@@ -246,23 +246,8 @@ export function OptionsView({ width, height, focused, onCapture = () => {} }: Op
       return true;
     }
 
-    if (!interactive) return false;
-
-    const numExp = chain?.expirationDates.length ?? 0;
-    if (event.name === "h" || event.name === "left") {
-      event.preventDefault?.();
-      event.stopPropagation?.();
-      setExpIdx((i) => Math.max(i - 1, 0));
-      return true;
-    }
-    if (event.name === "l" || event.name === "right") {
-      event.preventDefault?.();
-      event.stopPropagation?.();
-      setExpIdx((i) => Math.min(i + 1, Math.max(numExp - 1, 0)));
-      return true;
-    }
     return false;
-  }, [chain?.expirationDates.length, enterInteractive, exitInteractive, interactive, strikes.length]);
+  }, [enterInteractive, exitInteractive, interactive, strikes.length]);
 
   if (!ticker) return <Text fg={colors.textDim}>Select a ticker to view options.</Text>;
   if (loading && !chain) return <Spinner label="Loading options chain..." />;
@@ -299,6 +284,7 @@ export function OptionsView({ width, height, focused, onCapture = () => {} }: Op
             }}
             compact
             variant="bare"
+            focused={focused && interactive}
           />
         </Box>
         {loading && <Spinner />}

package/src/plugins/builtin/portfolio-list/pane.tsx

@@ -282,7 +282,6 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     [tickers, financialsMap, activeSort, columnContext, columns],
   );
 
-  const currentTabIdx = visibleCollections.findIndex((collection) => collection.id === activeCollectionId);
   const selectedIdx = sortedTickers.findIndex((ticker) => ticker.metadata.ticker === cursorSymbol);
   const safeSelectedIdx = selectedIdx >= 0 ? selectedIdx : 0;
 
@@ -359,35 +358,15 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       return true;
     }
 
-    if (showCollectionTabs && (key === "h" || key === "left")) {
-      event.preventDefault?.();
-      event.stopPropagation?.();
-      const previousCollection = visibleCollections[Math.max(currentTabIdx - 1, 0)];
-      if (previousCollection) handleCollectionSelect(previousCollection.id);
-      return true;
-    }
-
-    if (showCollectionTabs && (key === "l" || key === "right")) {
-      event.preventDefault?.();
-      event.stopPropagation?.();
-      const nextCollection = visibleCollections[Math.min(currentTabIdx + 1, visibleCollections.length - 1)];
-      if (nextCollection) handleCollectionSelect(nextCollection.id);
-      return true;
-    }
-
     return false;
   }, [
     cashDrawerExpanded,
-    currentTabIdx,
     focused,
     openTickerFloating,
     safeSelectedIdx,
     setCashDrawerExpanded,
-    handleCollectionSelect,
     showCashDrawer,
-    showCollectionTabs,
     sortedTickers,
-    visibleCollections,
   ]);
 
   useEffect(() => {
@@ -471,32 +450,29 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     if (queue.length === 0) return;
 
     let cancelled = false;
-    const runNext = async (): Promise<void> => {
-      if (cancelled) return;
-      const nextTicker = queue.shift();
-      if (!nextTicker) return;
-
-      const key = `${nextTicker.metadata.ticker}:${nextTicker.metadata.exchange ?? ""}`;
-      const instrument = instrumentFromTicker(nextTicker, nextTicker.metadata.ticker);
-      warmupInFlightRef.current.add(key);
-      warmupAttemptRef.current.set(key, nowTimestamp);
+    const runBatch = async (): Promise<void> => {
+      const entries = queue.flatMap((ticker) => {
+        const instrument = instrumentFromTicker(ticker, ticker.metadata.ticker);
+        if (!instrument) return [];
+        const key = `${ticker.metadata.ticker}:${ticker.metadata.exchange ?? ""}`;
+        warmupInFlightRef.current.add(key);
+        warmupAttemptRef.current.set(key, nowTimestamp);
+        return [{ key, instrument }];
+      });
+      if (entries.length === 0) return;
       try {
-        if (instrument) {
-          await sharedCoordinator.loadSnapshot(instrument);
-        }
+        await sharedCoordinator.loadSnapshotsBatch(entries.map((entry) => entry.instrument));
       } catch {
         // Best-effort warmup for visible rows only.
       } finally {
-        warmupInFlightRef.current.delete(key);
-      }
-
-      if (mountedRef.current && !cancelled) {
-        await runNext();
+        for (const entry of entries) {
+          warmupInFlightRef.current.delete(entry.key);
+        }
       }
     };
 
     const timeoutId = setTimeout(() => {
-      void runNext();
+      if (!cancelled && mountedRef.current) void runBatch();
     }, VISIBLE_FINANCIAL_WARMUP_DELAY_MS);
 
     return () => {
@@ -590,6 +566,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
                 activeValue={activeCollectionId}
                 onSelect={handleCollectionSelect}
                 compact
+                focused={focused}
               />
             </Box>
           </Box>

package/src/plugins/builtin/research/index.test.ts

@@ -0,0 +1,94 @@
+import { describe, expect, test } from "bun:test";
+import type { AnalystRatingRecord } from "../../../types/financials";
+import {
+  nextRatingSortPreference,
+  sortRatingRows,
+  type RatingSortPreference,
+} from "./index";
+
+const ratings: AnalystRatingRecord[] = [
+  {
+    date: "2026-05-06",
+    firm: "Beta Capital",
+    action: "Raises",
+    current: "Neutral",
+    prior: "Neutral",
+    currentPriceTarget: 385,
+    priorPriceTarget: 270,
+  },
+  {
+    date: "2026-05-07",
+    firm: "Alpha Research",
+    action: "Downgrade",
+    current: "Hold",
+    prior: "Buy",
+    currentPriceTarget: 340,
+    priorPriceTarget: 335,
+  },
+  {
+    date: "2026-05-06",
+    firm: "Zenith",
+    action: "Upgrade",
+    current: "Buy",
+    prior: "Neutral",
+    currentPriceTarget: 525,
+    priorPriceTarget: 265,
+  },
+  {
+    date: "2026-05-05",
+    firm: "No Target",
+    action: "Reiterates",
+    current: "Buy",
+    prior: "Buy",
+  },
+];
+
+describe("analyst rating sorting", () => {
+  test("sorts date newest first by default", () => {
+    const preference: RatingSortPreference = { columnId: "date", direction: "desc" };
+
+    expect(sortRatingRows(ratings, preference).map((row) => row.firm)).toEqual([
+      "Alpha Research",
+      "Beta Capital",
+      "Zenith",
+      "No Target",
+    ]);
+  });
+
+  test("sorts target by current target value with missing targets last", () => {
+    const preference: RatingSortPreference = { columnId: "target", direction: "desc" };
+
+    expect(sortRatingRows(ratings, preference).map((row) => row.firm)).toEqual([
+      "Zenith",
+      "Beta Capital",
+      "Alpha Research",
+      "No Target",
+    ]);
+  });
+
+  test("sorts text columns alphabetically with recent dates as a tie-breaker", () => {
+    const preference: RatingSortPreference = { columnId: "firm", direction: "asc" };
+
+    expect(sortRatingRows(ratings, preference).map((row) => row.firm)).toEqual([
+      "Alpha Research",
+      "Beta Capital",
+      "No Target",
+      "Zenith",
+    ]);
+  });
+
+  test("uses sensible first-click directions per column", () => {
+    expect(nextRatingSortPreference({ columnId: "date", direction: "desc" }, "date")).toEqual({
+      columnId: "date",
+      direction: "asc",
+    });
+    expect(nextRatingSortPreference({ columnId: "date", direction: "desc" }, "target")).toEqual({
+      columnId: "target",
+      direction: "desc",
+    });
+    expect(nextRatingSortPreference({ columnId: "target", direction: "desc" }, "firm")).toEqual({
+      columnId: "firm",
+      direction: "asc",
+    });
+  });
+});