gloomberb 0.5.1 → 0.6.1

package/src/plugins/builtin/portfolio-list.test.tsx

@@ -3,17 +3,18 @@ import { existsSync, rmSync } from "fs";
 import { tmpdir } from "os";
 import { join } from "path";
 import { act, useReducer } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../renderers/opentui/test-utils";
 import { AppPersistence } from "../../data/app-persistence";
 import { AppContext, appReducer, createInitialState, PaneInstanceProvider, type AppAction } from "../../state/app-context";
-import { ProviderRouter } from "../../sources/provider-router";
+import { AssetDataRouter } from "../../sources/provider-router";
 import { cloneLayout, createDefaultConfig, type AppConfig, type BrokerInstanceConfig } from "../../types/config";
 import type { DataProvider } from "../../types/data-provider";
 import type { Quote } from "../../types/financials";
 import type { TickerRecord } from "../../types/ticker";
 import { MarketDataCoordinator, setSharedMarketDataCoordinator } from "../../market-data/coordinator";
-import { setSharedRegistryForTests } from "../registry";
-import { ibkrGatewayManager } from "../ibkr/gateway-service";
+import { createTestPluginRuntime } from "../../test-support/plugin-runtime";
+import { PluginRenderProvider, type PluginRuntimeAccess } from "../plugin-runtime";
+import type { BrokerAdapter } from "../../types/broker";
 import { portfolioListPlugin } from "./portfolio-list";
 
 const TEST_PANE_ID = "portfolio-list:test";
@@ -191,6 +192,7 @@ function PortfolioHarness({
   quote,
   exchangeRates,
   stateMutator,
+  runtime = createTestPluginRuntime(),
 }: {
   config: AppConfig;
   collectionId: string;
@@ -200,6 +202,7 @@ function PortfolioHarness({
   quote?: Quote;
   exchangeRates?: Map<string, number>;
   stateMutator?: (state: ReturnType<typeof createInitialState>) => void;
+  runtime?: PluginRuntimeAccess;
 }) {
   const initialState = createPortfolioState(config, collectionId, expanded, {
     ticker,
@@ -215,13 +218,15 @@ function PortfolioHarness({
   return (
     <AppContext value={{ state, dispatch }}>
       <PaneInstanceProvider paneId={TEST_PANE_ID}>
-        <PortfolioPane
-          paneId={TEST_PANE_ID}
-          paneType="portfolio-list"
-          focused
-          width={100}
-          height={24}
-        />
+        <PluginRenderProvider pluginId="portfolio-list" runtime={runtime}>
+          <PortfolioPane
+            paneId={TEST_PANE_ID}
+            paneType="portfolio-list"
+            focused
+            width={100}
+            height={24}
+          />
+        </PluginRenderProvider>
       </PaneInstanceProvider>
     </AppContext>
   );
@@ -229,6 +234,9 @@ function PortfolioHarness({
 
 async function flushFrame() {
   await act(async () => {
+    await Promise.resolve();
+    await testSetup!.renderOnce();
+    await Promise.resolve();
     await testSetup!.renderOnce();
   });
 }
@@ -242,18 +250,45 @@ afterEach(async () => {
   sharedCoordinator = null;
   setSharedMarketDataCoordinator(null);
   harnessState = null;
-  setSharedRegistryForTests(undefined);
-  await ibkrGatewayManager.removeInstance("ibkr-live");
   for (const path of tempPaths.splice(0)) {
     if (existsSync(path)) rmSync(path, { force: true });
   }
 });
 
 describe("PortfolioListPane cash and margin UI", () => {
-  test("defaults new portfolio panes to floating", () => {
-    const paneDef = portfolioListPlugin.panes?.find((entry) => entry.id === "portfolio-list");
+  test("opens the selected ticker on a second row click", async () => {
+    const portfolioId = "broker:ibkr-flex:DU12345";
+    const config = createPortfolioConfig(portfolioId, [createBrokerInstance("flex")]);
+    const pinned: Array<{ symbol: string; options: { floating?: boolean; paneType?: string } | undefined }> = [];
+    const runtime = createTestPluginRuntime({
+      navigateTicker: () => {
+        throw new Error("portfolio rows should open fixed floating panes directly");
+      },
+      pinTicker: (symbol, options) => {
+        pinned.push({ symbol, options });
+      },
+    });
+
+    testSetup = await testRender(
+      <PortfolioHarness config={config} collectionId={portfolioId} runtime={runtime} />,
+      { width: 100, height: 24 },
+    );
+
+    await flushFrame();
+    const rowY = testSetup.captureCharFrame().split("\n").findIndex((line) => line.includes("AAPL"));
+    expect(rowY).toBeGreaterThanOrEqual(0);
+
+    await act(async () => {
+      await testSetup!.mockMouse.click(2, rowY);
+      await testSetup!.renderOnce();
+    });
+    expect(pinned).toEqual([]);
 
-    expect(paneDef?.defaultMode).toBe("floating");
+    await act(async () => {
+      await testSetup!.mockMouse.click(2, rowY);
+      await testSetup!.renderOnce();
+    });
+    expect(pinned).toEqual([{ symbol: "AAPL", options: { floating: true, paneType: "ticker-detail" } }]);
   });
 
   test("keeps non-broker portfolios unchanged", async () => {
@@ -284,7 +319,11 @@ describe("PortfolioListPane cash and margin UI", () => {
 
   test("keeps native price and avg cost while converting market value and pnl to base currency", async () => {
     const portfolioId = "broker:ibkr-flex:DU12345";
-    const config = createPortfolioConfig(portfolioId, [createBrokerInstance("flex")]);
+    const config = createPortfolioConfigWithColumns(
+      portfolioId,
+      ["ticker", "price", "change_pct", "shares", "avg_cost", "cost_basis", "mkt_value", "pnl"],
+      [createBrokerInstance("flex")],
+    );
 
     testSetup = await testRender(
       <PortfolioHarness
@@ -368,7 +407,7 @@ describe("PortfolioListPane cash and margin UI", () => {
     await flushFrame();
 
     const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("Val 1.3k");
+    expect(frame).toContain("1.3k");
     expect(frame).toContain("125");
     expect(frame).toContain("+250");
     expect(frame).toContain("25.00%");
@@ -486,34 +525,45 @@ describe("PortfolioListPane cash and margin UI", () => {
 
   test("shows a live gateway badge in the header and drawer preview", async () => {
     const config = createPortfolioConfig("broker:ibkr-live:DU12345", [createBrokerInstance("gateway", "ibkr-live")]);
-    const service = ibkrGatewayManager.getService("ibkr-live") as any;
-    service.updateSnapshot({
-      status: { state: "connected", updatedAt: Date.now(), mode: "gateway" },
-      accounts: [{
-        accountId: "DU12345",
-        name: "DU12345",
-        currency: "USD",
-        source: "gateway",
-        updatedAt: Date.now(),
-        totalCashValue: -75000,
-        settledCash: -70000,
-        availableFunds: 15000,
-        excessLiquidity: 12000,
-        buyingPower: 30000,
-        netLiquidation: 200000,
-        cashBalances: [
-          { currency: "USD", quantity: -75000, baseValue: -75000, baseCurrency: "USD" },
-          { currency: "EUR", quantity: -10000, baseValue: undefined, baseCurrency: "USD" },
-        ],
-      }],
-      openOrders: [],
-      executions: [],
+    const liveAccount = {
+      accountId: "DU12345",
+      name: "DU12345",
+      currency: "USD",
+      source: "gateway" as const,
+      updatedAt: Date.now(),
+      totalCashValue: -75000,
+      settledCash: -70000,
+      availableFunds: 15000,
+      excessLiquidity: 12000,
+      buyingPower: 30000,
+      netLiquidation: 200000,
+      cashBalances: [
+        { currency: "USD", quantity: -75000, baseValue: -75000, baseCurrency: "USD" },
+        { currency: "EUR", quantity: -10000, baseValue: undefined, baseCurrency: "USD" },
+      ],
+    };
+    const liveBroker: BrokerAdapter = {
+      id: "ibkr",
+      name: "Interactive Brokers",
+      configSchema: [],
+      validate: async () => true,
+      importPositions: async () => [],
+      getStatus: () => ({ state: "connected", updatedAt: Date.now(), mode: "gateway" }),
+      subscribeStatus: (_instance, listener) => {
+        listener();
+        return () => {};
+      },
+      listAccounts: async () => [liveAccount],
+    };
+    const runtime = createTestPluginRuntime({
+      getBrokerAdapter: (brokerType) => brokerType === "ibkr" ? liveBroker : null,
     });
 
     testSetup = await testRender(
       <PortfolioHarness
         config={config}
         collectionId="broker:ibkr-live:DU12345"
+        runtime={runtime}
         brokerAccounts={{
           "ibkr-live": [{
             accountId: "DU12345",
@@ -593,7 +643,7 @@ describe("PortfolioListPane cash and margin UI", () => {
     expect(harnessState?.paneState[TEST_PANE_ID]?.cashDrawerExpanded).toBe(true);
   });
 
-  test("renders the summary on its own row below the tabs", async () => {
+  test("renders the table directly below tabs when the footer owns the summary", async () => {
     const config = {
       ...createPortfolioConfig("broker:ibkr-flex:DU12345", [createBrokerInstance("flex")]),
       watchlists: [
@@ -629,11 +679,34 @@ describe("PortfolioListPane cash and margin UI", () => {
 
     const lines = testSetup.captureCharFrame().split("\n");
     const tabsRow = lines.findIndex((line) => line.includes("Main Portfolio"));
-    const summaryRow = lines.findIndex((line) => line.includes("Net Liq 125k  Val 1.3k  Cash -50k"));
+    const tableHeaderRow = lines.findIndex((line) => line.includes("TICKER"));
 
     expect(tabsRow).toBeGreaterThanOrEqual(0);
-    expect(summaryRow).toBeGreaterThan(tabsRow);
-    expect(lines[summaryRow + 1]).toContain("TICKER");
+    expect(tableHeaderRow).toBe(tabsRow + 1);
+  });
+
+  test("hides collection tabs when there is only one visible collection", async () => {
+    const config = createPortfolioConfig("main");
+    config.portfolios = [{ id: "main", name: "Main Portfolio", currency: "USD" }];
+    config.watchlists = [];
+
+    testSetup = await testRender(
+      <PortfolioHarness
+        config={config}
+        collectionId="main"
+        ticker={makeTicker({ portfolios: ["main"], positions: [] })}
+      />,
+      { width: 100, height: 12 },
+    );
+
+    await flushFrame();
+
+    const lines = testSetup.captureCharFrame().split("\n");
+    const tabsRow = lines.findIndex((line) => line.includes("Main Portfolio"));
+    const tableHeaderRow = lines.findIndex((line) => line.includes("TICKER"));
+
+    expect(tabsRow).toBe(-1);
+    expect(tableHeaderRow).toBe(0);
   });
 
   test("renders bid ask and spread when those columns are enabled", async () => {
@@ -698,9 +771,6 @@ describe("PortfolioListPane cash and margin UI", () => {
       async search() {
         return [];
       },
-      async getNews() {
-        return [];
-      },
       async getArticleSummary() {
         return null;
       },
@@ -720,6 +790,9 @@ describe("PortfolioListPane cash and margin UI", () => {
     );
 
     await flushFrame();
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 380));
+    });
     await act(async () => {
       resolveFinancials({
         annualStatements: [],
@@ -791,9 +864,6 @@ describe("PortfolioListPane cash and margin UI", () => {
       async search() {
         return [];
       },
-      async getNews() {
-        return [];
-      },
       async getArticleSummary() {
         return null;
       },
@@ -826,7 +896,7 @@ describe("PortfolioListPane cash and margin UI", () => {
       },
     };
 
-    const seedRouter = new ProviderRouter(yahooProvider, [cloudProvider], persistence.resources);
+    const seedRouter = new AssetDataRouter(yahooProvider, [cloudProvider], persistence.resources);
     await seedRouter.getTickerFinancials("AAPL", "NASDAQ", {
       brokerId: "ibkr",
       brokerInstanceId: "ibkr-live",
@@ -834,7 +904,7 @@ describe("PortfolioListPane cash and margin UI", () => {
     });
 
     let liveCalls = 0;
-    const cachedRouter = new ProviderRouter({
+    const cachedRouter = new AssetDataRouter({
       ...yahooProvider,
       async getTickerFinancials() {
         liveCalls += 1;
@@ -982,9 +1052,6 @@ describe("PortfolioListPane cash and margin UI", () => {
       async search() {
         return [];
       },
-      async getNews() {
-        return [];
-      },
       async getArticleSummary() {
         return null;
       },

package/src/plugins/builtin/quote-monitor.test.tsx

@@ -1,10 +1,10 @@
 import { afterEach, describe, expect, test } from "bun:test";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../renderers/opentui/test-utils";
 import type { TickerFinancials } from "../../types/financials";
 import type { TickerRecord } from "../../types/ticker";
 import { createDefaultConfig } from "../../types/config";
 import { AppContext, createInitialState, PaneInstanceProvider } from "../../state/app-context";
-import { QuoteMonitorPane, tickerDetailPlugin } from "./ticker-detail";
+import { QuoteMonitorPane } from "./ticker-detail";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
 
@@ -86,29 +86,4 @@ describe("QuoteMonitorPane", () => {
     expect(frame).toContain("-9.82");
   });
 
-  test("registers a quote monitor pane template bound to the active ticker", () => {
-    const template = tickerDetailPlugin.paneTemplates?.find((entry) => entry.id === "quote-monitor-pane");
-
-    expect(template).toBeDefined();
-    expect(template?.label).toBe("Quote Monitor");
-    expect(template?.canCreate?.({
-      config: createDefaultConfig("/tmp/gloomberb-test"),
-      layout: createDefaultConfig("/tmp/gloomberb-test").layout,
-      focusedPaneId: "ticker-detail:main",
-      activeTicker: "MSFT",
-      activeCollectionId: null,
-    })).toBe(true);
-    expect(template?.createInstance?.({
-      config: createDefaultConfig("/tmp/gloomberb-test"),
-      layout: createDefaultConfig("/tmp/gloomberb-test").layout,
-      focusedPaneId: "ticker-detail:main",
-      activeTicker: "MSFT",
-      activeCollectionId: null,
-    })).toEqual({
-      title: "MSFT",
-      binding: { kind: "fixed", symbol: "MSFT" },
-      settings: { symbol: "MSFT" },
-      placement: "floating",
-    });
-  });
 });