gloomberb 0.5.1 → 0.6.1

package/src/plugins/builtin/alerts/index.tsx

@@ -1,12 +1,16 @@
-import { useCallback, useEffect, useMemo, useRef, useState } from "react";
-import { TextAttributes, type ScrollBoxRenderable } from "@opentui/core";
-import { useKeyboard } from "@opentui/react";
-import { DataTable, type DataTableCell, type DataTableColumn } from "../../../components";
+import { useCallback, useEffect, useMemo, useState } from "react";
+import { TextAttributes } from "../../../ui";
+import {
+  DataTableView,
+  usePaneFooter,
+  type DataTableCell,
+  type DataTableColumn,
+  type DataTableKeyEvent,
+} from "../../../components";
 import type { GloomPlugin, GloomPluginContext, PaneProps } from "../../../types/plugin";
 import type { AlertCondition, AlertRule } from "./types";
 import { colors } from "../../../theme/colors";
-import { getSharedRegistry } from "../../registry";
-import { usePluginConfigState } from "../../plugin-runtime";
+import { useMarketData, usePluginAppActions, usePluginConfigState } from "../../plugin-runtime";
 import {
   createAlert,
   evaluateAlert,
@@ -14,9 +18,14 @@ import {
   serializeAlerts,
   deserializeAlerts,
 } from "./alert-engine";
+import type { DataProvider } from "../../../types/data-provider";
+import type { Quote } from "../../../types/financials";
+import { formatMarketPrice } from "../../../utils/market-format";
+import { formatQuoteAgeWithSource } from "../../../utils/quote-time";
 
 const ALERTS_KEY = "alerts";
 const POLL_INTERVAL_MS = 30_000;
+const PANE_QUOTE_REFRESH_MS = 30_000;
 
 function relativeTime(ts: number): string {
   const diff = Date.now() - ts;
@@ -30,6 +39,92 @@ function relativeTime(ts: number): string {
   return `${days}d ago`;
 }
 
+function normalizeAlertSymbol(value: string | null | undefined): string {
+  return value?.trim().toUpperCase() ?? "";
+}
+
+function createQuoteErrorMessage(symbol: string, error?: unknown): string {
+  if (error instanceof Error && error.message.trim()) return error.message;
+  return `No quote found for "${symbol}".`;
+}
+
+async function resolveAlertQuote(marketData: Pick<DataProvider, "getQuote">, symbol: string): Promise<Quote> {
+  const quote = await marketData.getQuote(symbol, "");
+  if (!quote || typeof quote.price !== "number" || !Number.isFinite(quote.price)) {
+    throw new Error(`No quote found for "${symbol}".`);
+  }
+  return quote;
+}
+
+function quoteAlertFields(quote: Quote, checkedAt = Date.now()): Pick<
+  AlertRule,
+  "lastCheckedPrice" | "lastCheckedAt" | "lastQuoteUpdatedAt" | "lastQuoteSource" | "lastQuoteProviderId"
+> & { lastCheckError?: undefined } {
+  return {
+    lastCheckedPrice: quote.price,
+    lastCheckedAt: checkedAt,
+    lastQuoteUpdatedAt: quote.lastUpdated,
+    lastQuoteSource: quote.dataSource,
+    lastQuoteProviderId: quote.providerId,
+    lastCheckError: undefined,
+  };
+}
+
+function quoteErrorAlertFields(error: string, checkedAt = Date.now()): Pick<
+  AlertRule,
+  "lastCheckedAt" | "lastCheckError"
+> {
+  return {
+    lastCheckedAt: checkedAt,
+    lastCheckError: error,
+  };
+}
+
+function formatCurrentPrice(alert: AlertRule, maxWidth = 9): string {
+  if (alert.lastCheckError) return "No quote";
+  return alert.lastCheckedPrice == null
+    ? "-"
+    : formatMarketPrice(alert.lastCheckedPrice, { maxWidth, minimumFractionDigits: 2 });
+}
+
+function formatAlertTargetPrice(alert: AlertRule, maxWidth = 9): string {
+  return formatMarketPrice(alert.targetPrice, { maxWidth, minimumFractionDigits: 2 });
+}
+
+function formatAlertDistance(alert: AlertRule): string {
+  const currentPrice = alert.lastCheckedPrice;
+  if (alert.lastCheckError) return "-";
+  if (currentPrice == null || !Number.isFinite(currentPrice) || currentPrice === 0) return "-";
+  const percent = ((alert.targetPrice - currentPrice) / currentPrice) * 100;
+  if (!Number.isFinite(percent)) return "-";
+  const abs = Math.abs(percent);
+  const decimals = abs < 10 ? 1 : 0;
+  return `${percent >= 0 ? "+" : ""}${percent.toFixed(decimals)}%`;
+}
+
+function formatQuoteChecked(alert: AlertRule): string {
+  if (alert.lastCheckError) return "No quote";
+  if (alert.lastQuoteUpdatedAt) {
+    return formatQuoteAgeWithSource({
+      lastUpdated: alert.lastQuoteUpdatedAt,
+      dataSource: alert.lastQuoteSource,
+    });
+  }
+  if (alert.lastCheckedAt) return relativeTime(alert.lastCheckedAt);
+  return "-";
+}
+
+function conditionLabel(condition: AlertCondition): string {
+  switch (condition) {
+    case "above":
+      return "Above";
+    case "below":
+      return "Below";
+    case "crosses":
+      return "Cross";
+  }
+}
+
 interface AlertCommandInput {
   symbol: string;
   condition: AlertCondition;
@@ -58,15 +153,21 @@ function parseAlertCondition(value: string | undefined): AlertCondition | null {
   }
 }
 
-function parseAlertShortcutValues(input: string): Record<string, string> {
+function parseAlertShortcutValues(
+  input: string,
+  context?: { activeTicker: string | null },
+): Record<string, string> {
   const parts = input.trim().split(/\s+/).filter(Boolean);
-  if (parts.length === 0) return {};
+  if (parts.length === 0) {
+    const activeTicker = normalizeAlertSymbol(context?.activeTicker);
+    return activeTicker ? { symbol: activeTicker } : {};
+  }
   if (parts.length > 3) {
     throw new Error("Use SA SYMBOL above|below|crosses PRICE.");
   }
 
   const values: Record<string, string> = {
-    symbol: parts[0]!.toUpperCase(),
+    symbol: normalizeAlertSymbol(parts[0]),
   };
 
   if (parts[1]) {
@@ -109,22 +210,26 @@ function parseAlertCommandValues(values?: Record<string, string>): AlertCommandI
 type AlertColumnId =
   | "status"
   | "symbol"
-  | "condition"
+  | "current"
   | "target"
-  | "last"
+  | "away"
+  | "condition"
+  | "quote"
   | "triggered"
   | "rearm";
 
 type AlertColumn = DataTableColumn & { id: AlertColumnId };
 
 const ALERT_COLUMNS: AlertColumn[] = [
-  { id: "status", label: "Status", width: 6 },
-  { id: "symbol", label: "Symbol", width: 8 },
-  { id: "condition", label: "Condition", width: 9 },
-  { id: "target", label: "Target", width: 8, align: "right" },
-  { id: "last", label: "Last", width: 8, align: "right" },
-  { id: "triggered", label: "Triggered", width: 9 },
-  { id: "rearm", label: "", width: 6 },
+  { id: "status", label: "State", width: 6, align: "left" },
+  { id: "symbol", label: "Symbol", width: 7, align: "left" },
+  { id: "current", label: "Current", width: 9, align: "right" },
+  { id: "target", label: "Target", width: 9, align: "right" },
+  { id: "away", label: "Away", width: 8, align: "right" },
+  { id: "condition", label: "Trigger", width: 7, align: "left" },
+  { id: "quote", label: "Quote", width: 8, align: "left" },
+  { id: "triggered", label: "Alerted", width: 8, align: "left" },
+  { id: "rearm", label: "", width: 6, align: "left" },
 ];
 
 const ALERT_TABLE_CONTENT_WIDTH = ALERT_COLUMNS.reduce(
@@ -134,10 +239,10 @@ const ALERT_TABLE_CONTENT_WIDTH = ALERT_COLUMNS.reduce(
 
 export function AlertsPane({ focused, width, height, close }: PaneProps) {
   const [alertsJson, setAlertsJson] = usePluginConfigState<string>(ALERTS_KEY, "[]");
+  const marketData = useMarketData();
+  const { openPluginCommandWorkflow } = usePluginAppActions();
   const [selectedIdx, setSelectedIdx] = useState(0);
-  const [hoveredIdx, setHoveredIdx] = useState<number | null>(null);
-  const scrollRef = useRef<ScrollBoxRenderable>(null);
-  const headerScrollRef = useRef<ScrollBoxRenderable>(null);
+  const marketDataId = marketData?.id ?? null;
   const showHorizontalScrollbar = ALERT_TABLE_CONTENT_WIDTH > width;
 
   const { alerts, rows, activeCount, triggeredCount } = useMemo(() => {
@@ -155,8 +260,12 @@ export function AlertsPane({ focused, width, height, close }: PaneProps) {
     };
   }, [alertsJson]);
 
-  const saveAlerts = useCallback((next: AlertRule[]) => {
-    setAlertsJson(serializeAlerts(next));
+  const saveAlerts = useCallback((next: AlertRule[] | ((current: AlertRule[]) => AlertRule[])) => {
+    setAlertsJson((currentJson) => {
+      const current = deserializeAlerts(currentJson);
+      const resolved = typeof next === "function" ? next(current) : next;
+      return serializeAlerts(resolved);
+    });
   }, [setAlertsJson]);
 
   const deleteAlert = useCallback((id: string) => {
@@ -167,76 +276,104 @@ export function AlertsPane({ focused, width, height, close }: PaneProps) {
   const rearmAlert = useCallback((id: string) => {
     saveAlerts(
       alerts.map((a) =>
-        a.id === id ? { ...a, status: "active" as const, triggeredAt: undefined } : a,
+        a.id === id ? { ...a, status: "active" as const, triggeredAt: undefined, lastCheckError: undefined } : a,
       ),
     );
   }, [alerts, saveAlerts]);
 
-  const openSetAlertCommand = useCallback(() => {
-    getSharedRegistry()?.openPluginCommandWorkflow("set-alert");
-  }, []);
+  const startAddAlert = useCallback(() => {
+    openPluginCommandWorkflow("set-alert");
+  }, [openPluginCommandWorkflow]);
 
   const deleteSelectedAlert = useCallback(() => {
     const selected = rows[selectedIdx];
     if (selected) deleteAlert(selected.id);
   }, [deleteAlert, rows, selectedIdx]);
 
-  const syncHeaderScroll = useCallback(() => {
-    const body = scrollRef.current;
-    const header = headerScrollRef.current;
-    if (body && header && header.scrollLeft !== body.scrollLeft) {
-      header.scrollLeft = body.scrollLeft;
-    }
-  }, []);
+  useEffect(() => {
+    if (!marketData || rows.length === 0) return;
+    const now = Date.now();
+    const dueAlerts = rows.filter((alert) => (
+      !alert.lastCheckedAt || now - alert.lastCheckedAt > PANE_QUOTE_REFRESH_MS
+    ));
+    if (dueAlerts.length === 0) return;
+
+    let cancelled = false;
+    void Promise.all(dueAlerts.map(async (alert) => {
+      try {
+        const quote = await resolveAlertQuote(marketData, alert.symbol);
+        return { id: alert.id, patch: quoteAlertFields(quote) };
+      } catch (error) {
+        return {
+          id: alert.id,
+          patch: quoteErrorAlertFields(createQuoteErrorMessage(alert.symbol, error)),
+        };
+      }
+    })).then((updates) => {
+      if (cancelled || updates.length === 0) return;
+      const patches = new Map(updates.map((update) => [update.id, update.patch]));
+      saveAlerts((current) => current.map((alert) => {
+        const patch = patches.get(alert.id);
+        return patch ? { ...alert, ...patch } : alert;
+      }));
+    });
 
-  const handleBodyScrollActivity = useCallback(() => {
-    syncHeaderScroll();
-  }, [syncHeaderScroll]);
+    return () => {
+      cancelled = true;
+    };
+  }, [marketDataId, rows, saveAlerts]);
+
+  usePaneFooter("alerts", () => ({
+    info: [
+      {
+        id: "active",
+        parts: [
+          { text: String(activeCount), tone: "value", bold: true },
+          { text: "active", tone: "label" },
+        ],
+      },
+      ...(triggeredCount > 0 ? [{
+        id: "triggered",
+        parts: [
+          { text: String(triggeredCount), tone: "warning" as const, bold: true },
+          { text: "triggered", tone: "label" as const },
+        ],
+      }] : []),
+    ],
+    hints: [
+      { id: "add", key: "a", label: "dd alert", onPress: startAddAlert },
+      { id: "delete", key: "d", label: "elete", onPress: deleteSelectedAlert, disabled: rows.length === 0 },
+    ],
+  }), [
+    activeCount,
+    deleteSelectedAlert,
+    rows.length,
+    startAddAlert,
+    triggeredCount,
+  ]);
 
   useEffect(() => {
     setSelectedIdx((prev) => (rows.length === 0 ? 0 : Math.min(prev, rows.length - 1)));
   }, [rows.length]);
 
-  useKeyboard((event) => {
-    if (!focused) return;
-
-    if (event.name === "j" || event.name === "down") {
-      event.preventDefault?.();
-      if (rows.length > 0) {
-        setSelectedIdx((prev) => Math.min(prev + 1, rows.length - 1));
-      }
-    } else if (event.name === "k" || event.name === "up") {
-      event.preventDefault?.();
-      if (rows.length > 0) {
-        setSelectedIdx((prev) => Math.max(prev - 1, 0));
-      }
-    } else if (event.name === "d") {
+  const handleTableKeyDown = useCallback((event: DataTableKeyEvent) => {
+    if (event.name === "d") {
       event.preventDefault?.();
       deleteSelectedAlert();
-    } else if (event.name === "return") {
-      event.preventDefault?.();
-      const selected = rows[selectedIdx];
-      if (selected?.status === "triggered") rearmAlert(selected.id);
-    } else if (event.name === "a" || event.name === "n") {
+      return true;
+    }
+    if (event.name === "a" || event.name === "n") {
       event.preventDefault?.();
-      openSetAlertCommand();
-    } else if (event.name === "escape") {
+      startAddAlert();
+      return true;
+    }
+    if (event.name === "escape") {
       event.preventDefault?.();
       close?.();
+      return true;
     }
-  });
-
-  // Keep selection in scroll view
-  useEffect(() => {
-    const sb = scrollRef.current;
-    if (!sb?.viewport || rows.length === 0 || selectedIdx < 0) return;
-    const viewportHeight = Math.max(sb.viewport.height, 1);
-    if (selectedIdx < sb.scrollTop) {
-      sb.scrollTo(selectedIdx);
-    } else if (selectedIdx >= sb.scrollTop + viewportHeight) {
-      sb.scrollTo(selectedIdx - viewportHeight + 1);
-    }
-  }, [selectedIdx, rows.length]);
+    return false;
+  }, [close, deleteSelectedAlert, startAddAlert]);
 
   const renderCell = useCallback((
     alert: AlertRule,
@@ -264,16 +401,26 @@ export function AlertsPane({ focused, width, height, close }: PaneProps) {
           color: selectedColor ?? colors.textBright,
           attributes: TextAttributes.BOLD,
         };
+      case "current":
+        return {
+          text: formatCurrentPrice(alert, column.width),
+          color: selectedColor ?? (alert.lastCheckError ? colors.negative : colors.text),
+        };
+      case "target":
+        return { text: formatAlertTargetPrice(alert, column.width), color: selectedColor };
+      case "away":
+        return {
+          text: formatAlertDistance(alert),
+          color: selectedColor ?? colors.textDim,
+        };
       case "condition":
         return {
-          text: alert.condition,
+          text: conditionLabel(alert.condition),
           color: selectedColor,
         };
-      case "target":
-        return { text: String(alert.targetPrice), color: selectedColor };
-      case "last":
+      case "quote":
         return {
-          text: alert.lastCheckedPrice == null ? "-" : String(alert.lastCheckedPrice),
+          text: formatQuoteChecked(alert),
           color: selectedColor ?? colors.textDim,
         };
       case "triggered":
@@ -293,77 +440,29 @@ export function AlertsPane({ focused, width, height, close }: PaneProps) {
   }, [rearmAlert]);
 
   return (
-    <box
-      flexDirection="column"
-      width={width}
-      height={height}
-      backgroundColor={colors.bg}
-    >
-      <box
-        flexDirection="row"
-        height={1}
-        paddingX={1}
-        backgroundColor={colors.bg}
-      >
-        <text fg={colors.textDim}>{activeCount} active</text>
-        {triggeredCount > 0 && (
-          <box marginLeft={1}>
-            <text fg={colors.textMuted}>{triggeredCount} triggered</text>
-          </box>
-        )}
-      </box>
-
-      <DataTable<AlertRule, AlertColumn>
-        columns={ALERT_COLUMNS}
-        items={rows}
-        sortColumnId={null}
-        sortDirection="asc"
-        onHeaderClick={() => {}}
-        headerScrollRef={headerScrollRef}
-        scrollRef={scrollRef}
-        syncHeaderScroll={syncHeaderScroll}
-        onBodyScrollActivity={handleBodyScrollActivity}
-        hoveredIdx={hoveredIdx}
-        setHoveredIdx={setHoveredIdx}
-        getItemKey={(alert) => alert.id}
-        isSelected={(_alert, index) => index === selectedIdx}
-        onSelect={(_alert, index) => setSelectedIdx(index)}
-        onActivate={(alert) => {
-          if (alert.status === "triggered") rearmAlert(alert.id);
-        }}
-        renderCell={renderCell}
-        emptyStateTitle="No alerts"
-        emptyStateHint="Use the action bar to create one."
-        showHorizontalScrollbar={showHorizontalScrollbar}
-      />
-
-      <box
-        flexDirection="row"
-        height={1}
-        paddingX={1}
-        backgroundColor={colors.panel}
-      >
-        <box
-          onMouseDown={(event: any) => {
-            event.preventDefault?.();
-            event.stopPropagation?.();
-            openSetAlertCommand();
-          }}
-        >
-          <text fg={colors.textDim}>[a]dd alert</text>
-        </box>
-        <box width={2} />
-        <box
-          onMouseDown={(event: any) => {
-            event.preventDefault?.();
-            event.stopPropagation?.();
-            deleteSelectedAlert();
-          }}
-        >
-          <text fg={rows.length > 0 ? colors.textDim : colors.textMuted}>[d]elete</text>
-        </box>
-      </box>
-    </box>
+    <DataTableView<AlertRule, AlertColumn>
+      focused={focused}
+      selectedIndex={selectedIdx}
+      onRootKeyDown={handleTableKeyDown}
+      rootWidth={width}
+      rootHeight={height}
+      rootBackgroundColor={colors.bg}
+      columns={ALERT_COLUMNS}
+      items={rows}
+      sortColumnId={null}
+      sortDirection="asc"
+      onHeaderClick={() => {}}
+      getItemKey={(alert) => alert.id}
+      isSelected={(_alert, index) => index === selectedIdx}
+      onSelect={(_alert, index) => setSelectedIdx(index)}
+      onActivate={(alert) => {
+        if (alert.status === "triggered") rearmAlert(alert.id);
+      }}
+      renderCell={renderCell}
+      emptyStateTitle="No alerts"
+      emptyStateHint="Use the action bar to create one."
+      showHorizontalScrollbar={showHorizontalScrollbar}
+    />
   );
 }
 
@@ -396,7 +495,7 @@ export const alertsPlugin: GloomPlugin = {
       shortcut: "SA",
       shortcutArg: {
         placeholder: "symbol condition price",
-        kind: "text",
+        kind: "ticker",
         parse: parseAlertShortcutValues,
       },
       wizardLayout: "form",
@@ -426,16 +525,21 @@ export const alertsPlugin: GloomPlugin = {
       ],
       async execute(values) {
         const input = parseAlertCommandValues(values);
-        if (!input) return;
+        if (!input) throw new Error("Use a symbol, condition, and target price.");
 
-        const alert = createAlert(input.symbol, input.condition, input.price);
+        const quote = await resolveAlertQuote(ctx.marketData, input.symbol);
+
+        const alert = {
+          ...createAlert(quote.symbol || input.symbol, input.condition, input.price),
+          ...quoteAlertFields(quote),
+        };
         const existing = loadAlerts(ctx);
         existing.push(alert);
         saveAlerts(ctx, existing);
 
         ctx.notify({
-          body: `Alert set: ${formatAlertDescription(alert)}`,
-          type: "info",
+          body: `Alert set: ${formatAlertDescription(alert)} (current ${formatMarketPrice(quote.price, { minimumFractionDigits: 2 })})`,
+          type: "success",
         });
       },
     });
@@ -454,9 +558,11 @@ export const alertsPlugin: GloomPlugin = {
       for (const alert of alerts) {
         if (alert.status !== "active") continue;
         try {
-          const quote = await ctx.dataProvider.getQuote(alert.symbol, "");
+          const quote = await ctx.marketData.getQuote(alert.symbol, "");
           if (!quote || typeof quote.price !== "number") {
             ctx.log.warn("poll: no quote", { symbol: alert.symbol });
+            Object.assign(alert, quoteErrorAlertFields(`No quote found for "${alert.symbol}".`));
+            changed = true;
             continue;
           }
 
@@ -475,10 +581,12 @@ export const alertsPlugin: GloomPlugin = {
             });
             changed = true;
           }
-          alert.lastCheckedPrice = quote.price;
+          Object.assign(alert, quoteAlertFields(quote));
           changed = true;
         } catch (err) {
           ctx.log.error("poll: error", { symbol: alert.symbol, error: String(err) });
+          Object.assign(alert, quoteErrorAlertFields(createQuoteErrorMessage(alert.symbol, err)));
+          changed = true;
         }
       }
 
@@ -497,7 +605,7 @@ export const alertsPlugin: GloomPlugin = {
       component: AlertsPane,
       defaultPosition: "right",
       defaultMode: "floating",
-      defaultFloatingSize: { width: 65, height: 20 },
+      defaultFloatingSize: { width: 82, height: 20 },
     });
 
     ctx.registerPaneTemplate({

package/src/plugins/builtin/alerts/types.ts

@@ -1,3 +1,5 @@
+import type { QuoteDataSource } from "../../../types/financials";
+
 export type AlertCondition = "above" | "below" | "crosses";
 export type AlertStatus = "active" | "triggered" | "expired";
 
@@ -10,5 +12,10 @@ export interface AlertRule {
   status: AlertStatus;
   triggeredAt?: number;
   lastCheckedPrice?: number;
+  lastCheckedAt?: number;
+  lastCheckError?: string;
+  lastQuoteUpdatedAt?: number;
+  lastQuoteSource?: QuoteDataSource;
+  lastQuoteProviderId?: string;
   message?: string;
 }

package/src/plugins/builtin/analytics/index.test.tsx

@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { act, useReducer, type ReactElement } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../../renderers/opentui/test-utils";
 import {
   AppContext,
   appReducer,
@@ -8,10 +8,12 @@ import {
   PaneInstanceProvider,
 } from "../../../state/app-context";
 import { setSharedMarketDataCoordinator } from "../../../market-data/coordinator";
+import { createTestPluginRuntime } from "../../../test-support/plugin-runtime";
 import { cloneLayout, createDefaultConfig, type AppConfig } from "../../../types/config";
 import type { TickerFinancials } from "../../../types/financials";
 import type { TickerRecord } from "../../../types/ticker";
 import type { BrokerAccount } from "../../../types/trading";
+import { PluginRenderProvider } from "../../plugin-runtime";
 import { analyticsPlugin } from "./index";
 
 const TEST_PANE_ID = "analytics:test";
@@ -39,6 +41,7 @@ function createAnalyticsConfig(initialPortfolioId: string): AppConfig {
       params: { portfolioId: initialPortfolioId },
     }],
     floating: [],
+    detached: [],
   };
 
   return {
@@ -140,13 +143,15 @@ function AnalyticsHarness({
   return (
     <AppContext value={{ state, dispatch }}>
       <PaneInstanceProvider paneId={TEST_PANE_ID}>
-        <AnalyticsPane
-          paneId={TEST_PANE_ID}
-          paneType="analytics"
-          focused
-          width={100}
-          height={24}
-        />
+        <PluginRenderProvider pluginId={analyticsPlugin.id} runtime={createTestPluginRuntime()}>
+          <AnalyticsPane
+            paneId={TEST_PANE_ID}
+            paneType="analytics"
+            focused
+            width={100}
+            height={24}
+          />
+        </PluginRenderProvider>
       </PaneInstanceProvider>
     </AppContext>
   );