gloomberb 0.3.7 → 0.4.1

package/src/plugins/ibkr/gateway-service.ts

@@ -25,6 +25,11 @@ import { tmpdir } from "os";
 import { join } from "path";
 import { firstValueFrom, filter, take, timeout } from "rxjs";
 import type { TimeRange } from "../../components/chart/chart-types";
+import {
+  normalizeChartResolutionSupport,
+  type ChartResolutionSupport,
+  type ManualChartResolution,
+} from "../../components/chart/chart-resolution";
 import type { BrokerConnectionStatus, BrokerPosition } from "../../types/broker";
 import type { QuoteSubscriptionTarget } from "../../types/data-provider";
 import type { Fundamentals, FinancialStatement, Quote, PricePoint, TickerFinancials } from "../../types/financials";
@@ -290,6 +295,7 @@ const IBKR_DATA_TIMEOUT = 8_000;
 const IBKR_QUOTE_STREAM_TICKS = "165,221,233";
 
 const HISTORY_PARAMS: Record<TimeRange, { duration: string; size: BarSizeSetting }> = {
+  "1D": { duration: "1 D", size: BarSizeSetting.MINUTES_FIVE },
   "1W": { duration: "7 D", size: BarSizeSetting.HOURS_ONE },
   "1M": { duration: "1 M", size: BarSizeSetting.HOURS_ONE },
   "3M": { duration: "3 M", size: BarSizeSetting.DAYS_ONE },
@@ -299,6 +305,17 @@ const HISTORY_PARAMS: Record<TimeRange, { duration: string; size: BarSizeSetting
   "ALL": { duration: "10 Y", size: BarSizeSetting.MONTHS_ONE },
 };
 
+const IBKR_RESOLUTION_SUPPORT = normalizeChartResolutionSupport([
+  { resolution: "1m", maxRange: "1W" },
+  { resolution: "5m", maxRange: "1M" },
+  { resolution: "15m", maxRange: "3M" },
+  { resolution: "30m", maxRange: "6M" },
+  { resolution: "1h", maxRange: "1Y" },
+  { resolution: "1d", maxRange: "ALL" },
+  { resolution: "1wk", maxRange: "ALL" },
+  { resolution: "1mo", maxRange: "ALL" },
+]);
+
 /** Map generic bar size labels to IBKR BarSizeSetting values. */
 const GENERIC_BAR_SIZE_MAP: Record<string, BarSizeSetting> = {
   "1m": BarSizeSetting.MINUTES_ONE,
@@ -307,7 +324,8 @@ const GENERIC_BAR_SIZE_MAP: Record<string, BarSizeSetting> = {
   "30m": BarSizeSetting.MINUTES_THIRTY,
   "1h": BarSizeSetting.HOURS_ONE,
   "1d": BarSizeSetting.DAYS_ONE,
-  "1w": BarSizeSetting.WEEKS_ONE,
+  "1wk": BarSizeSetting.WEEKS_ONE,
+  "1mo": BarSizeSetting.MONTHS_ONE,
 };
 
 export function parseIbkrHistoricalBarTime(value: string | number): Date {
@@ -383,6 +401,65 @@ function hasDelayedMarketData(
   ].some((tickType) => marketData.has(tickType));
 }
 
+function firstNonSmartExchange(value?: string): string | undefined {
+  return value
+    ?.split(",")
+    .map((entry) => entry.trim())
+    .find((entry) => entry.length > 0 && entry !== "SMART");
+}
+
+function resolveIbkrListingExchange(
+  current: Quote | undefined,
+  contract: Contract,
+  details: ContractDetails,
+): string | undefined {
+  return current?.listingExchangeName
+    ?? contract.primaryExch
+    ?? firstNonSmartExchange(details.validExchanges)
+    ?? (current?.exchangeName !== "SMART" ? current?.exchangeName : undefined)
+    ?? (contract.exchange !== "SMART" ? contract.exchange : undefined);
+}
+
+function resolveIbkrRoutingExchange(current: Quote | undefined, contract: Contract): string | undefined {
+  return current?.routingExchangeName
+    ?? contract.exchange
+    ?? "SMART";
+}
+
+function ibkrVenueFields(
+  current: Quote | undefined,
+  contract: Contract,
+  details: ContractDetails,
+): Pick<
+  Quote,
+  | "exchangeName"
+  | "fullExchangeName"
+  | "listingExchangeName"
+  | "listingExchangeFullName"
+  | "routingExchangeName"
+  | "routingExchangeFullName"
+  | "marketState"
+  | "sessionConfidence"
+> {
+  const listingExchangeName = resolveIbkrListingExchange(current, contract, details);
+  const listingExchangeFullName = current?.listingExchangeFullName
+    ?? current?.fullExchangeName
+    ?? listingExchangeName;
+  const routingExchangeName = resolveIbkrRoutingExchange(current, contract);
+  const routingExchangeFullName = current?.routingExchangeFullName ?? routingExchangeName;
+
+  return {
+    exchangeName: listingExchangeName,
+    fullExchangeName: listingExchangeFullName,
+    listingExchangeName,
+    listingExchangeFullName,
+    routingExchangeName,
+    routingExchangeFullName,
+    marketState: current?.marketState,
+    sessionConfidence: current?.sessionConfidence ?? "unknown",
+  };
+}
+
 interface TickByTickBidAskUpdate {
   time: number;
   bidPrice: number;
@@ -417,9 +494,7 @@ export function applyTickByTickAllLastToQuote(
     volume: current?.volume,
     name: current?.name ?? details.longName ?? details.marketName ?? contract.symbol,
     lastUpdated: tick.time ? tick.time * 1000 : Date.now(),
-    exchangeName: current?.exchangeName ?? details.validExchanges?.split(",")[0],
-    fullExchangeName: current?.fullExchangeName ?? details.validExchanges?.split(",")[0],
-    marketState: current?.marketState ?? "REGULAR",
+    ...ibkrVenueFields(current, contract, details),
     preMarketPrice: current?.preMarketPrice,
     preMarketChange: current?.preMarketChange,
     preMarketChangePercent: current?.preMarketChangePercent,
@@ -1052,6 +1127,67 @@ export class IbkrGatewayService {
     });
   }
 
+  getChartResolutionSupport(
+    _ticker: string,
+    _config: IbkrGatewayConfig,
+    _exchange?: string,
+    _instrument?: BrokerContractRef | null,
+  ): ChartResolutionSupport[] {
+    return IBKR_RESOLUTION_SUPPORT;
+  }
+
+  getChartResolutionCapabilities(
+    _ticker: string,
+    _config: IbkrGatewayConfig,
+    _exchange?: string,
+    _instrument?: BrokerContractRef | null,
+  ): ManualChartResolution[] {
+    return IBKR_RESOLUTION_SUPPORT.map((entry) => entry.resolution);
+  }
+
+  async getPriceHistoryForResolution(
+    ticker: string,
+    config: IbkrGatewayConfig,
+    exchange: string,
+    bufferRange: TimeRange,
+    resolution: ManualChartResolution,
+    instrument?: BrokerContractRef | null,
+  ): Promise<PricePoint[]> {
+    const ibkrBarSize = GENERIC_BAR_SIZE_MAP[resolution];
+    if (!ibkrBarSize) return [];
+
+    return this.dedup(`history:${ticker}:${exchange}:${bufferRange}:${resolution}`, async () => {
+      await this.connect(config);
+      const contract = await withTimeout(this.resolveContract(ticker, exchange, instrument ?? null), IBKR_DATA_TIMEOUT, "resolveContract");
+      const params = HISTORY_PARAMS[bufferRange];
+      const detailsPromise = withTimeout(this.getPrimaryContractDetails(contract), IBKR_DATA_TIMEOUT, "getContractDetails")
+        .catch(() => undefined);
+      const bars = await this.withMarketDataFallback(
+        config,
+        () => withTimeout(this.api!.getHistoricalData(
+          contract,
+          "",
+          params.duration,
+          ibkrBarSize,
+          WhatToShow.TRADES,
+          1,
+          1,
+        ), IBKR_DATA_TIMEOUT, "getHistoricalData"),
+      );
+      const details = await detailsPromise;
+      const priceDivisor = getIbkrPriceDivisor(contract, details);
+
+      return bars.map((bar) => ({
+        date: parseIbkrHistoricalBarTime(bar.time),
+        open: normalizeIbkrPriceValue(bar.open, priceDivisor),
+        high: normalizeIbkrPriceValue(bar.high, priceDivisor),
+        low: normalizeIbkrPriceValue(bar.low, priceDivisor),
+        close: normalizeIbkrPriceValue(bar.close ?? bar.open ?? bar.high ?? bar.low ?? 0, priceDivisor) ?? 0,
+        volume: bar.volume,
+      }));
+    });
+  }
+
   async getDetailedPriceHistory(
     ticker: string,
     config: IbkrGatewayConfig,
@@ -2150,9 +2286,7 @@ export class IbkrGatewayService {
       volume: marketData.get(IBApiTickType.VOLUME)?.value ?? marketData.get(IBApiTickType.DELAYED_VOLUME)?.value,
       name: details.longName || details.marketName || contract.symbol,
       lastUpdated: ingressTm,
-      exchangeName: details.validExchanges?.split(",")[0],
-      fullExchangeName: details.validExchanges?.split(",")[0],
-      marketState: "REGULAR",
+      ...ibkrVenueFields(undefined, contract, details),
       bid: normalizeIbkrPriceValue(
         marketData.get(IBApiTickType.BID)?.value ?? marketData.get(IBApiTickType.DELAYED_BID)?.value,
         priceDivisor,
@@ -2259,6 +2393,12 @@ export class IbkrGatewayServiceManager {
     await service.disconnect();
     this.services.delete(instanceId);
   }
+
+  async destroyAll(): Promise<void> {
+    const services = [...this.services.values()];
+    this.services.clear();
+    await Promise.allSettled(services.map((service) => service.disconnect()));
+  }
 }
 
 export const ibkrGatewayManager = new IbkrGatewayServiceManager();

package/src/plugins/ibkr/index.tsx

@@ -1,7 +1,7 @@
 import type { GloomPlugin, GloomPluginContext } from "../../types/plugin";
 import { ibkrBroker } from "./broker-adapter";
 import { buildPersistedIbkrGatewayConfig } from "./config";
-import { setResolvedIbkrGatewayListener } from "./gateway-service";
+import { ibkrGatewayManager, setResolvedIbkrGatewayListener } from "./gateway-service";
 import {
   getTradeTicketState,
   getTradingPaneState,
@@ -150,4 +150,10 @@ export const ibkrPlugin: GloomPlugin = {
       },
     });
   },
+
+  dispose() {
+    lastSelectedTickerSymbol = null;
+    setResolvedIbkrGatewayListener(null);
+    void ibkrGatewayManager.destroyAll().catch(() => {});
+  },
 };

package/src/plugins/pane-manager.test.ts

@@ -71,7 +71,7 @@ describe("pane-manager split-tree drops", () => {
     const next = gridlockAllPanes(layout);
 
     expect(next.floating).toHaveLength(0);
-    expect(getDockedPaneIds(next)).toHaveLength(4);
+    expect(getDockedPaneIds(next)).toHaveLength(5);
   });
 
   test("gridlock infers a matching tiled layout from arranged windows", () => {

package/src/plugins/plugin-runtime.tsx

@@ -2,6 +2,7 @@ import {
   createContext,
   useCallback,
   useContext,
+  useRef,
   useSyncExternalStore,
   type ReactNode,
   type SetStateAction,
@@ -101,12 +102,21 @@ export function usePluginPaneState<T>(key: string, fallback: T, paneId?: string)
   const { pluginId } = usePluginRenderContext();
   const scopedPaneId = paneId ?? usePaneInstanceId();
   const { state, dispatch } = useAppState();
+  const stateRef = useRef(state);
+  const fallbackRef = useRef(fallback);
+  stateRef.current = state;
+  fallbackRef.current = fallback;
   const paneState = state.paneState[scopedPaneId];
   const value = getPluginPaneStateValue(paneState, pluginId, key, fallback);
 
   const setValue = useCallback((nextValue: SetStateAction<T>) => {
-    const currentPaneState = state.paneState[scopedPaneId];
-    const currentValue = getPluginPaneStateValue(currentPaneState, pluginId, key, fallback);
+    const currentPaneState = stateRef.current.paneState[scopedPaneId];
+    const currentValue = getPluginPaneStateValue(
+      currentPaneState,
+      pluginId,
+      key,
+      fallbackRef.current,
+    );
     const resolved = typeof nextValue === "function"
       ? (nextValue as (previousValue: T) => T)(currentValue)
       : nextValue;
@@ -122,7 +132,7 @@ export function usePluginPaneState<T>(key: string, fallback: T, paneId?: string)
       key,
       value: resolved,
     });
-  }, [dispatch, fallback, key, pluginId, scopedPaneId, state.paneState]);
+  }, [dispatch, key, pluginId, scopedPaneId]);
 
   return [value, setValue];
 }
@@ -130,6 +140,8 @@ export function usePluginPaneState<T>(key: string, fallback: T, paneId?: string)
 export function usePluginState<T>(key: string, fallback: T, options?: { schemaVersion?: number }): [T, (value: SetStateAction<T>) => void] {
   const { pluginId, runtime } = usePluginRenderContext();
   const schemaVersion = options?.schemaVersion;
+  const fallbackRef = useRef(fallback);
+  fallbackRef.current = fallback;
 
   const subscribe = useCallback((listener: () => void) => (
     runtime.subscribeResumeState(pluginId, key, listener)
@@ -142,7 +154,9 @@ export function usePluginState<T>(key: string, fallback: T, options?: { schemaVe
   const value = useSyncExternalStore(subscribe, getSnapshot, getSnapshot);
 
   const setValue = useCallback((nextValue: SetStateAction<T>) => {
-    const currentValue = runtime.getResumeState<T>(pluginId, key, schemaVersion) ?? fallback;
+    const currentValue =
+      runtime.getResumeState<T>(pluginId, key, schemaVersion) ??
+      fallbackRef.current;
     const resolved = typeof nextValue === "function"
       ? (nextValue as (previousValue: T) => T)(currentValue)
       : nextValue;
@@ -150,7 +164,7 @@ export function usePluginState<T>(key: string, fallback: T, options?: { schemaVe
       return;
     }
     runtime.setResumeState(pluginId, key, resolved, schemaVersion);
-  }, [fallback, key, pluginId, runtime, schemaVersion]);
+  }, [key, pluginId, runtime, schemaVersion]);
 
   return [value, setValue];
 }
@@ -158,10 +172,16 @@ export function usePluginState<T>(key: string, fallback: T, options?: { schemaVe
 export function usePluginConfigState<T>(key: string, fallback: T): [T, (value: SetStateAction<T>) => void] {
   const { pluginId, runtime } = usePluginRenderContext();
   const { state } = useAppState();
+  const stateRef = useRef(state);
+  const fallbackRef = useRef(fallback);
+  stateRef.current = state;
+  fallbackRef.current = fallback;
   const value = (state.config.pluginConfig[pluginId]?.[key] as T | undefined) ?? fallback;
 
   const setValue = useCallback((nextValue: SetStateAction<T>) => {
-    const currentValue = (state.config.pluginConfig[pluginId]?.[key] as T | undefined) ?? fallback;
+    const currentValue =
+      (stateRef.current.config.pluginConfig[pluginId]?.[key] as T | undefined) ??
+      fallbackRef.current;
     const resolved = typeof nextValue === "function"
       ? (nextValue as (previousValue: T) => T)(currentValue)
       : nextValue;
@@ -169,7 +189,7 @@ export function usePluginConfigState<T>(key: string, fallback: T): [T, (value: S
       return;
     }
     void runtime.setConfigState(pluginId, key, resolved);
-  }, [fallback, key, pluginId, runtime, state.config.pluginConfig]);
+  }, [key, pluginId, runtime]);
 
   return [value, setValue];
 }

package/src/plugins/prediction-markets/cli.ts

@@ -0,0 +1,28 @@
+import type { CliCommandDef } from "../../types/plugin";
+import { createPredictionLaunchRequest, parsePredictionCommandArgs } from "./launch";
+
+export const predictionMarketsCliCommand: CliCommandDef = {
+  name: "predictions",
+  aliases: ["prediction-markets", "pm"],
+  description: "Launch the UI with Prediction Markets focused",
+  help: {
+    usage: ["predictions [...]"],
+    sections: [{
+      title: "Prediction Launch",
+      columns: [
+        { header: "Input" },
+        { header: "Example" },
+      ],
+      rows: [
+        ["gloomberb predictions [venue] [category] [browse-tab] [search...]", "gloomberb predictions world"],
+        ["venue", "all | polymarket | kalshi"],
+        ["category", "all | politics | world | macro | crypto | science | sports | entertainment | climate | social"],
+        ["browse-tab", "top | ending | new | watchlist"],
+      ],
+    }],
+  },
+  execute: async (args) => ({
+    kind: "launch-ui",
+    request: createPredictionLaunchRequest(parsePredictionCommandArgs(args)),
+  }),
+};

package/src/plugins/prediction-markets/controller-data.ts

@@ -26,6 +26,7 @@ import { subscribePolymarketMarket } from "./services/polymarket-ws";
 import type {
   PredictionBrowseTab,
   PredictionCategoryId,
+  PredictionVenue,
   PredictionListRow,
   PredictionMarketDetail,
   PredictionMarketSummary,
@@ -36,9 +37,52 @@ import type {
 
 const KEYBOARD_DETAIL_LOAD_DELAY_MS = 140;
 
+function formatPredictionVenueLabel(venue: PredictionVenue): string {
+  return venue === "polymarket" ? "Polymarket" : "Kalshi";
+}
+
+function joinPredictionVenueLabels(venues: PredictionVenue[]): string {
+  const labels = [...new Set(venues.map(formatPredictionVenueLabel))];
+  if (labels.length <= 1) return labels[0] ?? "";
+  return `${labels.slice(0, -1).join(" and ")} and ${labels.at(-1)}`;
+}
+
+function formatPredictionLoadError(
+  venue: PredictionVenue,
+  subject: "markets" | "market detail",
+  error: unknown,
+): string {
+  const venueLabel = formatPredictionVenueLabel(venue);
+  const fallback = `Could not load ${venueLabel} ${subject}.`;
+  if (!(error instanceof Error)) {
+    return fallback;
+  }
+
+  const message = error.message.trim();
+  if (message.length === 0) {
+    return fallback;
+  }
+
+  const requestFailureMatch = message.match(/Request failed \((\d+)\)/i);
+  if (requestFailureMatch) {
+    return `${venueLabel} ${subject} request failed (${requestFailureMatch[1]}).`;
+  }
+
+  if (
+    /typo in the url or port|access the url|unable to connect|could not resolve host|connection refused/i.test(
+      message,
+    )
+  ) {
+    return `${venueLabel} is unavailable right now.`;
+  }
+
+  return `${fallback} ${message}`;
+}
+
 export function usePredictionMarketsDataState({
   browseTab,
   categoryId,
+  detailOpen,
   effectiveVenueScope,
   focused,
   historyRange,
@@ -52,6 +96,7 @@ export function usePredictionMarketsDataState({
 }: {
   browseTab: PredictionBrowseTab;
   categoryId: PredictionCategoryId;
+  detailOpen: boolean;
   effectiveVenueScope: PredictionVenueScope;
   focused: boolean;
   historyRange: "1D" | "1W" | "1M" | "ALL";
@@ -150,14 +195,84 @@ export function usePredictionMarketsDataState({
       ].filter((value): value is string => value != null),
     [includeKalshi, includePolymarket, kalshiCatalogKey, polymarketCatalogKey],
   );
+  const activeCatalogSources = useMemo(
+    () =>
+      [
+        includePolymarket
+          ? {
+              venue: "polymarket" as const,
+              cacheKey: polymarketCatalogKey,
+              error: catalogErrors[polymarketCatalogKey] ?? null,
+              markets: polymarketCatalog,
+            }
+          : null,
+        includeKalshi
+          ? {
+              venue: "kalshi" as const,
+              cacheKey: kalshiCatalogKey,
+              error: catalogErrors[kalshiCatalogKey] ?? null,
+              markets: kalshiCatalog,
+            }
+          : null,
+      ].filter(
+        (
+          value,
+        ): value is {
+          venue: PredictionVenue;
+          cacheKey: string;
+          error: string | null;
+          markets: PredictionMarketSummary[];
+        } => value != null,
+      ),
+    [
+      catalogErrors,
+      includeKalshi,
+      includePolymarket,
+      kalshiCatalog,
+      kalshiCatalogKey,
+      polymarketCatalog,
+      polymarketCatalogKey,
+    ],
+  );
   const catalogLoadCount = activeCatalogKeys.reduce(
     (count, cacheKey) => count + (catalogPending[cacheKey] ?? 0),
     0,
   );
-  const catalogError = activeCatalogKeys
-    .map((cacheKey) => catalogErrors[cacheKey])
-    .filter((value): value is string => !!value)
-    .join(" ") || null;
+  const catalogStatus = useMemo(() => {
+    const failingSources = activeCatalogSources.filter((source) => !!source.error);
+    if (failingSources.length === 0) {
+      return null;
+    }
+
+    const loadedSources = activeCatalogSources.filter(
+      (source) => !source.error && source.markets.length > 0,
+    );
+    if (failingSources.length < activeCatalogSources.length) {
+      const unavailableVenues = joinPredictionVenueLabels(
+        failingSources.map((source) => source.venue),
+      );
+      if (loadedSources.length > 0) {
+        return {
+          tone: "warning" as const,
+          message: `${unavailableVenues} unavailable right now; showing ${joinPredictionVenueLabels(
+            loadedSources.map((source) => source.venue),
+          )} markets.`,
+        };
+      }
+      return {
+        tone: "warning" as const,
+        message: `${unavailableVenues} unavailable right now.`,
+      };
+    }
+
+    return {
+      tone: "danger" as const,
+      message: failingSources
+        .map((source) => source.error)
+        .filter((value): value is string => !!value)
+        .join(" "),
+    };
+  }, [activeCatalogSources]);
 
   const allMarkets = useMemo(() => {
     const merged: PredictionMarketSummary[] = [];
@@ -201,7 +316,11 @@ export function usePredictionMarketsDataState({
     [selectedRowKey, visibleRows],
   );
   const selectedSummary = useMemo(
-    () =>
+    () => {
+      if (!detailOpen || !selectedRow) {
+        return null;
+      }
+      return (
       selectedRow?.markets.find(
         (market) => market.key === selectedDetailMarketKey,
       ) ??
@@ -209,8 +328,10 @@ export function usePredictionMarketsDataState({
         (market) => market.key === selectedRow.focusMarketKey,
       ) ??
       selectedRow?.representative ??
-      null,
-    [selectedDetailMarketKey, selectedRow],
+      null
+      );
+    },
+    [detailOpen, selectedDetailMarketKey, selectedRow],
   );
   const selectedSummaryKey = selectedSummary?.key ?? null;
   const selectedSummaryVenue = selectedSummary?.venue ?? null;
@@ -268,9 +389,7 @@ export function usePredictionMarketsDataState({
           updatePredictionErrorState(
             current,
             cacheKey,
-            error instanceof Error
-              ? error.message
-              : "Could not load Polymarket markets.",
+            formatPredictionLoadError("polymarket", "markets", error),
           ),
         );
       } finally {
@@ -302,9 +421,7 @@ export function usePredictionMarketsDataState({
           updatePredictionErrorState(
             current,
             cacheKey,
-            error instanceof Error
-              ? error.message
-              : "Could not load Kalshi markets.",
+            formatPredictionLoadError("kalshi", "markets", error),
           ),
         );
       } finally {
@@ -352,9 +469,7 @@ export function usePredictionMarketsDataState({
           updatePredictionErrorState(
             current,
             cacheKey,
-            error instanceof Error
-              ? error.message
-              : "Could not load market detail.",
+            formatPredictionLoadError(summary.venue, "market detail", error),
           ),
         );
         if (currentDetailCacheKeyRef.current === cacheKey) {
@@ -597,7 +712,7 @@ export function usePredictionMarketsDataState({
   }, []);
 
   return {
-    catalogError,
+    catalogStatus,
     catalogLoadCount,
     debouncedSearchQuery,
     detail,