gloomberb 0.3.7 → 0.4.1

package/src/plugins/builtin/comparison-chart.test.tsx

@@ -1,6 +1,7 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act } from "react";
 import { testRender } from "@opentui/react/test-utils";
+import { MarketDataCoordinator, setSharedMarketDataCoordinator } from "../../market-data/coordinator";
 import {
   AppContext,
   createInitialState,
@@ -23,6 +24,7 @@ import {
 const TEST_PANE_ID = "comparison-chart:test";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
+let sharedCoordinator: MarketDataCoordinator | null = null;
 
 function makeTicker(symbol: string, currency: string): TickerRecord {
   return {
@@ -76,12 +78,19 @@ function createProvider(historyBySymbol: Record<string, number[]>, currencyBySym
     search: async () => [],
     getNews: async () => [],
     getArticleSummary: async () => null,
+    getChartResolutionCapabilities: async () => ["5m", "15m", "1h", "1d", "1wk", "1mo"],
     getPriceHistory: async (symbol) => (
       historyBySymbol[symbol] ?? []
     ).map((close, index) => ({
       date: new Date(2024, 0, index + 2),
       close,
     })),
+    getPriceHistoryForResolution: async (symbol) => (
+      historyBySymbol[symbol] ?? []
+    ).map((close, index) => ({
+      date: new Date(2024, 0, index + 2),
+      close,
+    })),
   };
 }
 
@@ -154,6 +163,8 @@ afterEach(() => {
     testSetup.renderer.destroy();
     testSetup = undefined;
   }
+  sharedCoordinator = null;
+  setSharedMarketDataCoordinator(null);
   setSharedRegistryForTests(undefined);
   setSharedDataProviderForTests(undefined);
 });
@@ -178,6 +189,8 @@ describe("comparisonChartPlugin", () => {
       title: "AAPL · MSFT · NVDA",
       settings: {
         axisMode: "percent",
+        rangePreset: "1Y",
+        chartResolution: "1d",
         symbols: ["AAPL", "MSFT", "NVDA"],
         symbolsText: "AAPL, MSFT, NVDA",
       },
@@ -190,19 +203,24 @@ describe("comparisonChartPlugin", () => {
       symbols: ["AAPL", "MSFT"],
     })).toEqual({
       axisMode: "percent",
+      rangePreset: "1Y",
+      chartResolution: "1d",
       symbols: ["AAPL", "MSFT"],
       symbolsText: "AAPL, MSFT",
     });
   });
 
   test("renders one shared overlay chart with the mixed-currency warning", async () => {
-    setSharedDataProviderForTests(createProvider({
+    const provider = createProvider({
       AAPL: [100, 102, 104, 106],
       "7203": [2000, 2020, 2050, 2100],
     }, {
       AAPL: "USD",
       "7203": "JPY",
-    }));
+    });
+    setSharedDataProviderForTests(provider);
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
     setSharedRegistryForTests(createRegistrySpy({ selected: [], focused: [] }));
 
     testSetup = await testRender(
@@ -224,14 +242,54 @@ describe("comparisonChartPlugin", () => {
 
     const frame = testSetup.captureCharFrame();
     expect(frame).toContain("Mixed currencies detected; showing percent change.");
-    expect(frame).toContain("1:1W");
+    expect(frame).toContain("1:1D");
+    expect(frame).toContain("2:1W");
+    expect(frame).toContain("1D");
+    expect(frame).toContain("view:");
     expect(frame).toContain("arrows legend");
     expect(frame).not.toContain("side by side");
   });
 
+  test("keeps controls visible when comparison history is empty", async () => {
+    const provider = createProvider({
+      AAPL: [],
+      MSFT: [],
+    }, {
+      AAPL: "USD",
+      MSFT: "USD",
+    });
+    setSharedDataProviderForTests(provider);
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
+    setSharedRegistryForTests(createRegistrySpy({ selected: [], focused: [] }));
+
+    testSetup = await testRender(
+      createComparisonHarness({
+        axisMode: "price",
+        symbols: ["AAPL", "MSFT"],
+        symbolsText: "AAPL, MSFT",
+      }, [
+        makeTicker("AAPL", "USD"),
+        makeTicker("MSFT", "USD"),
+      ], [
+        ["AAPL", makeFinancials("AAPL", "USD", [])],
+        ["MSFT", makeFinancials("MSFT", "USD", [])],
+      ]),
+      { width: 120, height: 20 },
+    );
+
+    await flushFrames();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("No chart data yet.");
+    expect(frame).toContain("1:1D");
+    expect(frame).toContain("2:1W");
+    expect(frame).toContain("AUTO");
+  });
+
   test("moves legend selection with the keyboard and opens the selected ticker on Enter", async () => {
     const spy = { selected: [] as string[], focused: [] as string[] };
-    setSharedDataProviderForTests(createProvider({
+    const provider = createProvider({
       AAPL: [100, 102, 104],
       MSFT: [200, 202, 204],
       NVDA: [300, 305, 310],
@@ -239,7 +297,10 @@ describe("comparisonChartPlugin", () => {
       AAPL: "USD",
       MSFT: "USD",
       NVDA: "USD",
-    }));
+    });
+    setSharedDataProviderForTests(provider);
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
     setSharedRegistryForTests(createRegistrySpy(spy));
 
     testSetup = await testRender(

package/src/plugins/builtin/comparison-chart.tsx

@@ -1,7 +1,12 @@
 import { useCallback, useMemo } from "react";
 import { EmptyState } from "../../components";
 import { ComparisonStockChart } from "../../components/chart/comparison-stock-chart";
-import type { ChartAxisMode } from "../../components/chart/chart-types";
+import type { ChartAxisMode, TimeRange } from "../../components/chart/chart-types";
+import {
+  DEFAULT_COMPARISON_CHART_RANGE_PRESET,
+  DEFAULT_COMPARISON_CHART_RESOLUTION,
+  normalizeChartResolution,
+} from "../../components/chart/chart-resolution";
 import { getSharedRegistry } from "../../plugins/registry";
 import { useAppState } from "../../state/app-context";
 import { colors } from "../../theme/colors";
@@ -13,6 +18,8 @@ export const COMPARISON_CHART_TEMPLATE_ID = "comparison-chart-pane";
 
 interface ComparisonChartPaneSettings {
   axisMode: ChartAxisMode;
+  rangePreset: TimeRange;
+  chartResolution: ReturnType<typeof normalizeChartResolution>;
   symbols: string[];
   symbolsText: string;
 }
@@ -46,6 +53,17 @@ export function getComparisonChartPaneSettings(settings: Record<string, unknown>
 
   return {
     axisMode: isChartAxisMode(settings?.axisMode) ? settings.axisMode : "price",
+    rangePreset: settings?.rangePreset === "1D"
+      || settings?.rangePreset === "1W"
+      || settings?.rangePreset === "1M"
+      || settings?.rangePreset === "3M"
+      || settings?.rangePreset === "6M"
+      || settings?.rangePreset === "1Y"
+      || settings?.rangePreset === "5Y"
+      || settings?.rangePreset === "ALL"
+      ? settings.rangePreset
+      : DEFAULT_COMPARISON_CHART_RANGE_PRESET,
+    chartResolution: normalizeChartResolution(settings?.chartResolution, DEFAULT_COMPARISON_CHART_RESOLUTION),
     symbols,
     symbolsText: storedText.trim().length > 0 ? storedText : formatTickerListInput(symbols),
   };
@@ -159,6 +177,8 @@ export const comparisonChartPlugin: GloomPlugin = {
           placement: "floating",
           settings: {
             axisMode: "percent",
+            rangePreset: DEFAULT_COMPARISON_CHART_RANGE_PRESET,
+            chartResolution: DEFAULT_COMPARISON_CHART_RESOLUTION,
             symbols,
             symbolsText: formatTickerListInput(symbols),
           },

package/src/plugins/builtin/layout-manager.tsx

@@ -25,6 +25,11 @@ export function setLayoutManagerDispatch(
   getStateRef = getState;
 }
 
+export function clearLayoutManagerDispatch() {
+  dispatchRef = null;
+  getStateRef = null;
+}
+
 function persistLayout(layout: LayoutConfig) {
   if (!dispatchRef) return;
   dispatchRef({ type: "PUSH_LAYOUT_HISTORY" });
@@ -261,4 +266,8 @@ export const layoutManagerPlugin: GloomPlugin = {
       },
     });
   },
+
+  dispose() {
+    clearLayoutManagerDispatch();
+  },
 };

package/src/plugins/builtin/news.tsx

@@ -1,5 +1,4 @@
 import { useRef, useEffect, useState } from "react";
-import { useKeyboard } from "@opentui/react";
 import type { GloomPlugin, DetailTabProps } from "../../types/plugin";
 import { usePaneTicker } from "../../state/app-context";
 import { colors } from "../../theme/colors";
@@ -88,15 +87,6 @@ function NewsTab({ width, height, focused }: DetailTabProps) {
     setSummaryCache((prev) => new Map(prev).set(selected.url, selectedSummary));
   }, [selected?.url, selectedSummary]);
 
-  useKeyboard((event) => {
-    if (!focused || news.length === 0) return;
-    if (event.name === "j" || event.name === "down") {
-      setSelectedIdx((index) => Math.min(index + 1, news.length - 1));
-    } else if (event.name === "k" || event.name === "up") {
-      setSelectedIdx((index) => Math.max(index - 1, 0));
-    }
-  });
-
   useEffect(() => {
     if (news.length > 0 && selectedIdx >= news.length) {
       setSelectedIdx(Math.max(0, news.length - 1));
@@ -114,13 +104,13 @@ function NewsTab({ width, height, focused }: DetailTabProps) {
     <DetailFeedView
       width={width}
       height={height}
+      focused={focused}
       items={items}
       selectedIdx={selectedIdx}
       hoveredIdx={hoveredIdx}
       onSelect={setSelectedIdx}
       onHover={setHoveredIdx}
       listVariant="single-line"
-      splitListWidthRatio={0.36}
     />
   );
 }