gloomberb 0.3.3 → 0.4.0

package/src/components/chart/chart-controller.ts

@@ -0,0 +1,309 @@
+import type { QueryEntry } from "../../market-data/result-types";
+import type { PricePoint } from "../../types/financials";
+import { clampChartZoom, getVisiblePointCount } from "./chart-viewport";
+import type { ChartResolution, ChartViewState, ComparisonChartViewState, TimeRange } from "./chart-types";
+import {
+  clampTimeRangeToMaxRange,
+  getBestSupportedResolutionForPreset,
+  getCompatibleBufferRange,
+  getNextBufferRange,
+  getPresetResolution,
+  getSupportMaxRange,
+  getWidestPresetForResolution,
+  isDateWindowWithinTimeRange,
+  isTimeRangeAtOrBelow,
+  subtractTimeRange,
+  type ChartResolutionSupport,
+  type ManualChartResolution,
+} from "./chart-resolution";
+
+type ViewStateWithViewport = Pick<ChartViewState, "presetRange" | "bufferRange" | "activePreset" | "resolution" | "panOffset" | "zoomLevel" | "cursorX" | "cursorY">
+  | Pick<ComparisonChartViewState, "presetRange" | "bufferRange" | "activePreset" | "resolution" | "panOffset" | "zoomLevel" | "cursorX" | "cursorY">;
+
+export interface VisibleDateWindow {
+  start: Date | null;
+  end: Date | null;
+  dates: Date[];
+  startIdx: number;
+  endIdx: number;
+  totalDates: number;
+}
+
+export interface ChartBodyState<T> {
+  data: T | null;
+  blocking: boolean;
+  updating: boolean;
+  emptyMessage: string | null;
+  errorMessage: string | null;
+}
+
+function clamp(value: number, min: number, max: number): number {
+  return Math.max(min, Math.min(max, value));
+}
+
+function coerceDate(value: Date | string | number): Date {
+  return value instanceof Date ? value : new Date(value);
+}
+
+export function getPointDates(points: readonly Pick<PricePoint, "date">[]): Date[] {
+  return points.map((point) => coerceDate(point.date as Date | string | number));
+}
+
+export function getCanonicalVisiblePointCount(dates: readonly Date[], presetRange: TimeRange): number {
+  if (dates.length === 0) return 0;
+  if (presetRange === "ALL") return dates.length;
+  const endDate = dates[dates.length - 1]!;
+  const threshold = subtractTimeRange(endDate, presetRange).getTime();
+  const firstVisibleIndex = dates.findIndex((date) => date.getTime() >= threshold);
+  if (firstVisibleIndex < 0) return dates.length;
+  return Math.max(dates.length - firstVisibleIndex, 1);
+}
+
+export function getCanonicalZoomLevel(dates: readonly Date[], presetRange: TimeRange): number {
+  if (dates.length === 0) return 1;
+  const visibleCount = getCanonicalVisiblePointCount(dates, presetRange);
+  return clampChartZoom(dates.length, dates.length / Math.max(visibleCount, 1));
+}
+
+export function buildVisibleDateWindow(
+  dates: readonly Date[],
+  panOffset: number,
+  zoomLevel: number,
+): VisibleDateWindow {
+  if (dates.length === 0) {
+    return { start: null, end: null, dates: [], startIdx: 0, endIdx: 0, totalDates: 0 };
+  }
+  const visibleCount = getVisiblePointCount(dates.length, zoomLevel);
+  const maxPan = Math.max(dates.length - visibleCount, 0);
+  const pan = clamp(panOffset, 0, maxPan);
+  const endIdx = dates.length - pan;
+  const startIdx = Math.max(endIdx - visibleCount, 0);
+  const visibleDates = dates.slice(startIdx, endIdx);
+  return {
+    start: visibleDates[0] ?? null,
+    end: visibleDates[visibleDates.length - 1] ?? null,
+    dates: visibleDates,
+    startIdx,
+    endIdx,
+    totalDates: dates.length,
+  };
+}
+
+export function formatVisibleSpanLabel(window: Pick<VisibleDateWindow, "start" | "end">): string {
+  if (!window.start || !window.end) return "view: --";
+  const sameYear = window.start.getFullYear() === window.end.getFullYear();
+  const sameMonth = sameYear && window.start.getMonth() === window.end.getMonth();
+  const startLabel = window.start.toLocaleDateString("en-US", {
+    month: "short",
+    day: "numeric",
+    ...(sameYear ? {} : { year: "numeric" }),
+  });
+  const endLabel = window.end.toLocaleDateString("en-US", {
+    month: sameMonth ? undefined : "short",
+    day: "numeric",
+    year: sameYear ? undefined : "numeric",
+  });
+  return `view:${startLabel}-${endLabel}`;
+}
+
+export function isCanonicalPresetViewport(
+  dates: readonly Date[],
+  state: Pick<ViewStateWithViewport, "activePreset" | "panOffset" | "zoomLevel" | "resolution">,
+): boolean {
+  if (!state.activePreset) return false;
+  if (state.panOffset !== 0) return false;
+  const canonicalZoom = getCanonicalZoomLevel(dates, state.activePreset);
+  return Math.abs(state.zoomLevel - canonicalZoom) < 0.001;
+}
+
+export function resolvePresetSelectionWithResolution<S extends ViewStateWithViewport>(
+  state: S,
+  presetRange: TimeRange,
+  resolution: ManualChartResolution,
+  supportMaxRange: TimeRange | null = null,
+): S {
+  return {
+    ...state,
+    presetRange,
+    bufferRange: getCompatibleBufferRange(presetRange, supportMaxRange),
+    activePreset: presetRange,
+    resolution,
+    panOffset: 0,
+    zoomLevel: 1,
+    cursorX: null,
+    cursorY: null,
+  };
+}
+
+export function resolvePresetSelection<S extends ViewStateWithViewport>(
+  state: S,
+  presetRange: TimeRange,
+  supportMaxRange: TimeRange | null = null,
+): S {
+  return resolvePresetSelectionWithResolution(
+    state,
+    presetRange,
+    getPresetResolution(presetRange),
+    supportMaxRange,
+  );
+}
+
+export function resolveResolutionSelection<S extends ViewStateWithViewport>(
+  state: S,
+  resolution: ChartResolution,
+  support: ReadonlyMap<ManualChartResolution, TimeRange>,
+  visibleWindow: Pick<VisibleDateWindow, "start" | "end"> | null,
+): S | null {
+  if (resolution === "auto") {
+    return {
+      ...state,
+      resolution,
+      bufferRange: getNextBufferRange(state.presetRange),
+      activePreset: null,
+      panOffset: 0,
+      zoomLevel: 1,
+      cursorX: null,
+      cursorY: null,
+    };
+  }
+
+  const maxRange = getSupportMaxRange(support, resolution);
+  if (!maxRange) return null;
+
+  const visibleSpanTooWide = visibleWindow?.start && visibleWindow.end
+    ? !isDateWindowWithinTimeRange(visibleWindow.start, visibleWindow.end, maxRange)
+    : false;
+  const shouldSnap = !isTimeRangeAtOrBelow(state.presetRange, maxRange) || visibleSpanTooWide;
+  const presetRange = shouldSnap
+    ? getWidestPresetForResolution(resolution, maxRange)
+    : clampTimeRangeToMaxRange(state.presetRange, maxRange);
+
+  return {
+    ...state,
+    presetRange,
+    bufferRange: getCompatibleBufferRange(presetRange, maxRange),
+    activePreset: shouldSnap ? presetRange : null,
+    resolution,
+    panOffset: 0,
+    zoomLevel: 1,
+    cursorX: null,
+    cursorY: null,
+  };
+}
+
+export function resolveStoredChartSelection<S extends ViewStateWithViewport>(
+  state: S,
+  presetRange: TimeRange,
+  resolution: ChartResolution,
+  support: ReadonlyMap<ManualChartResolution, TimeRange>,
+): S {
+  const resetState = {
+    ...state,
+    presetRange,
+    panOffset: 0,
+    zoomLevel: 1,
+    cursorX: null,
+    cursorY: null,
+  };
+
+  if (resolution === "auto") {
+    return {
+      ...resetState,
+      resolution,
+      bufferRange: getNextBufferRange(presetRange),
+      activePreset: null,
+    };
+  }
+
+  const resolvedSelection = resolveResolutionSelection(
+    {
+      ...resetState,
+      bufferRange: getNextBufferRange(presetRange),
+      activePreset: null,
+      resolution: "auto",
+    },
+    resolution,
+    support,
+    null,
+  );
+
+  if (!resolvedSelection) {
+    const fallbackResolution = getBestSupportedResolutionForPreset(presetRange, support);
+    if (!fallbackResolution) {
+      return {
+        ...resetState,
+        resolution: "auto",
+        bufferRange: getNextBufferRange(presetRange),
+        activePreset: null,
+      };
+    }
+    return resolvePresetSelectionWithResolution(
+      resetState,
+      presetRange,
+      fallbackResolution,
+      getSupportMaxRange(support, fallbackResolution),
+    );
+  }
+
+  return {
+    ...resolvedSelection,
+    activePreset: resolvedSelection.resolution === getBestSupportedResolutionForPreset(resolvedSelection.presetRange, support)
+      ? resolvedSelection.presetRange
+      : null,
+  };
+}
+
+export function clearActivePreset<S extends Pick<ViewStateWithViewport, "activePreset">>(state: S): S {
+  if (state.activePreset === null) return state;
+  return {
+    ...state,
+    activePreset: null,
+  };
+}
+
+export function resolveChartBodyState<T>(
+  entry: QueryEntry<T> | null | undefined,
+  hasData: (value: T | null) => boolean,
+  emptyMessage: string,
+): ChartBodyState<T> {
+  const data = entry?.data ?? null;
+  const hasCurrentData = hasData(data);
+
+  if (!entry || entry.phase === "idle" || ((entry.phase === "loading" || entry.phase === "refreshing") && !hasCurrentData)) {
+    return {
+      data: null,
+      blocking: true,
+      updating: false,
+      emptyMessage: null,
+      errorMessage: null,
+    };
+  }
+
+  if (entry.phase === "error" && !hasCurrentData) {
+    return {
+      data: null,
+      blocking: false,
+      updating: false,
+      emptyMessage: null,
+      errorMessage: entry.error?.message ?? "Chart data failed to load.",
+    };
+  }
+
+  if (!hasCurrentData) {
+    return {
+      data,
+      blocking: false,
+      updating: false,
+      emptyMessage,
+      errorMessage: null,
+    };
+  }
+
+  return {
+    data,
+    blocking: false,
+    updating: entry.phase === "refreshing",
+    emptyMessage: null,
+    errorMessage: null,
+  };
+}

package/src/components/chart/chart-data.ts

@@ -78,22 +78,21 @@ export function getVisibleWindow(
   viewState: ChartViewState,
   chartWidth: number,
 ): VisibleWindow {
-  const filtered = filterByTimeRange(history, viewState.timeRange);
-  if (filtered.length === 0) {
+  if (history.length === 0) {
     return { points: [], startIdx: 0, endIdx: 0 };
   }
 
-  const visibleCount = getVisiblePointCount(filtered.length, viewState.zoomLevel);
+  const visibleCount = getVisiblePointCount(history.length, viewState.zoomLevel);
 
   // Clamp pan offset
-  const maxPan = Math.max(filtered.length - visibleCount, 0);
+  const maxPan = Math.max(history.length - visibleCount, 0);
   const pan = Math.min(Math.max(viewState.panOffset, 0), maxPan);
 
-  const endIdx = filtered.length - pan;
+  const endIdx = history.length - pan;
   const startIdx = Math.max(endIdx - visibleCount, 0);
 
   return {
-    points: filtered.slice(startIdx, endIdx),
+    points: history.slice(startIdx, endIdx),
     startIdx,
     endIdx,
   };

package/src/components/chart/chart-pane-settings.ts

@@ -0,0 +1,27 @@
+import { saveConfig } from "../../data/config-store";
+import { setPaneSettings } from "../../pane-settings";
+import { useAppState, usePaneInstance, usePaneInstanceId } from "../../state/app-context";
+import type { ChartResolution, TimeRange } from "./chart-types";
+
+export function usePersistChartControlSelection(rangePresetKey: string): (
+  range: TimeRange,
+  resolution: ChartResolution,
+) => void {
+  const { state, dispatch } = useAppState();
+  const paneId = usePaneInstanceId();
+  const pane = usePaneInstance();
+
+  return (range, resolution) => {
+    const layout = setPaneSettings(state.config.layout, paneId, {
+      ...(pane?.settings ?? {}),
+      [rangePresetKey]: range,
+      chartResolution: resolution,
+    });
+    const layouts = state.config.layouts.map((savedLayout, index) => (
+      index === state.config.activeLayoutIndex ? { ...savedLayout, layout } : savedLayout
+    ));
+    const nextConfig = { ...state.config, layout, layouts };
+    dispatch({ type: "SET_CONFIG", config: nextConfig });
+    saveConfig(nextConfig).catch(() => {});
+  };
+}

package/src/components/chart/chart-renderer.ts

@@ -917,6 +917,7 @@ export interface RenderChartOptions {
   axisMode?: ChartAxisMode;
   currency?: string;
   colors: ResolvedChartPalette;
+  timeAxisDates?: Array<Date | string | number>;
 }
 
 export interface ChartScene {
@@ -1027,6 +1028,8 @@ export function buildChartScene(
     ? null
     : max - (cursorY / Math.max(chartRows - 1, 1)) * range;
 
+  const timeAxisDates = opts.timeAxisDates ?? points.map((point) => point.date);
+
   return {
     points,
     width: opts.width,
@@ -1045,7 +1048,7 @@ export function buildChartScene(
     dateAtCursor: activePoint.date,
     changeAtCursor: activePoint.close - points[0]!.close,
     changePctAtCursor: points[0]!.close ? ((activePoint.close - points[0]!.close) / points[0]!.close) * 100 : 0,
-    timeLabels: buildTimeAxis(points.map((point) => point.date), opts.width),
+    timeLabels: buildTimeAxis(timeAxisDates, opts.width),
     cursorX,
     cursorY,
     cursorColumn,
@@ -1138,10 +1141,12 @@ export function renderChart(
     );
   }
 
+  const timeAxisDates = opts.timeAxisDates ?? points.map((point) => point.date);
+
   return {
     lines: bufferToBrailleLines(buf, palette.bgColor),
     axisLabels: [...axisLabelsByRow.entries()].map(([row, label]) => ({ row, label })),
-    timeLabels: buildTimeAxis(points.map((point) => point.date), width),
+    timeLabels: buildTimeAxis(timeAxisDates, width),
     activePoint,
     priceAtCursor,
     crosshairPrice,

package/src/components/chart/chart-resolution.test.ts

@@ -0,0 +1,56 @@
+import { describe, expect, test } from "bun:test";
+import {
+  clampTimeRangeForResolution,
+  getActiveRangePreset,
+  getPresetResolution,
+  intersectChartResolutions,
+  isRangePresetSupported,
+  normalizeChartResolution,
+  sortChartResolutions,
+} from "./chart-resolution";
+
+describe("chart-resolution", () => {
+  test("maps range presets to their default manual resolutions", () => {
+    expect(getPresetResolution("1W")).toBe("5m");
+    expect(getPresetResolution("1M")).toBe("15m");
+    expect(getPresetResolution("3M")).toBe("1h");
+    expect(getPresetResolution("6M")).toBe("1d");
+    expect(getPresetResolution("1Y")).toBe("1d");
+    expect(getPresetResolution("5Y")).toBe("1wk");
+    expect(getPresetResolution("ALL")).toBe("1mo");
+  });
+
+  test("derives the active range preset only for the exact reset preset pair", () => {
+    expect(getActiveRangePreset("1Y", "1d", 1, 0)).toBe("1Y");
+    expect(getActiveRangePreset("1Y", "auto", 1, 0)).toBeNull();
+    expect(getActiveRangePreset("1Y", "1d", 1.2, 0)).toBeNull();
+    expect(getActiveRangePreset("1Y", "1d", 1, 2)).toBeNull();
+  });
+
+  test("intersects and sorts provider capabilities", () => {
+    expect(intersectChartResolutions([
+      ["1d", "5m", "1wk", "nope"],
+      ["1wk", "1d", "1mo"],
+      ["1d", "1wk"],
+    ])).toEqual(["1d", "1wk"]);
+  });
+
+  test("checks whether a range preset is supported by the visible capability set", () => {
+    expect(isRangePresetSupported("1Y", ["1d", "1wk"])).toBe(true);
+    expect(isRangePresetSupported("ALL", ["1d", "1wk"])).toBe(false);
+  });
+
+  test("clamps overly-wide ranges for manual intraday resolutions", () => {
+    expect(clampTimeRangeForResolution("5Y", "5m")).toBe("1W");
+    expect(clampTimeRangeForResolution("6M", "1h")).toBe("3M");
+    expect(clampTimeRangeForResolution("1M", "15m")).toBe("1M");
+    expect(clampTimeRangeForResolution("5Y", "1d")).toBe("5Y");
+    expect(clampTimeRangeForResolution("5Y", "auto")).toBe("5Y");
+  });
+
+  test("normalizes and sorts chart resolution values", () => {
+    expect(normalizeChartResolution("1h")).toBe("1h");
+    expect(normalizeChartResolution("bogus", "1d")).toBe("1d");
+    expect(sortChartResolutions(["1wk", "auto", "15m", "1d"])).toEqual(["auto", "15m", "1d", "1wk"]);
+  });
+});