gloomberb 0.3.3 → 0.4.0

package/src/plugins/builtin/portfolio-list/command-bar.ts

@@ -0,0 +1,122 @@
+import type { CommandBarFieldValue, CommandBarWorkflowField } from "../../../components/command-bar/workflow-types";
+import type { AppConfig } from "../../../types/config";
+import type { TickerRecord } from "../../../types/ticker";
+import { getManualPortfolioPosition, isManualPortfolio } from "./mutations";
+
+export interface SetPortfolioPositionWorkflowState {
+  fields: CommandBarWorkflowField[];
+  values: Record<string, CommandBarFieldValue>;
+  pendingLabel: string;
+}
+
+interface ManualPortfolioPositionWorkflowOptions {
+  preferredPortfolioId?: string | null;
+  ticker: TickerRecord | null;
+  pendingLabel: string;
+  positionOptional?: boolean;
+  defaultAvgCost?: number | null;
+}
+
+function buildManualPortfolioPositionWorkflow(
+  config: AppConfig,
+  options: ManualPortfolioPositionWorkflowOptions,
+): SetPortfolioPositionWorkflowState | null {
+  const manualPortfolios = config.portfolios.filter(isManualPortfolio);
+  if (manualPortfolios.length === 0) return null;
+
+  const preferredPortfolio = manualPortfolios.find((portfolio) => portfolio.id === options.preferredPortfolioId) ?? manualPortfolios[0]!;
+  const preferredPosition = options.ticker
+    ? getManualPortfolioPosition(options.ticker, preferredPortfolio.id)
+    : null;
+
+  const fields: CommandBarWorkflowField[] = [
+    {
+      id: "portfolioId",
+      label: "Portfolio",
+      type: "select",
+      options: manualPortfolios.map((portfolio) => ({
+        label: portfolio.name,
+        value: portfolio.id,
+        description: portfolio.currency,
+      })),
+      required: true,
+    },
+    {
+      id: "ticker",
+      label: "Ticker",
+      type: "text",
+      placeholder: "AAPL",
+      required: true,
+    },
+    {
+      id: "shares",
+      label: "Shares",
+      type: "number",
+      placeholder: "10",
+      required: !options.positionOptional,
+    },
+    {
+      id: "avgCost",
+      label: "Avg Cost",
+      type: "number",
+      placeholder: "180",
+      required: !options.positionOptional,
+    },
+    {
+      id: "currency",
+      label: "Currency",
+      type: "text",
+      placeholder: preferredPortfolio.currency,
+      required: false,
+    },
+  ];
+
+  const values: Record<string, CommandBarFieldValue> = {
+    portfolioId: preferredPortfolio.id,
+    ticker: options.ticker?.metadata.ticker ?? "",
+    shares: preferredPosition ? String(preferredPosition.shares) : "",
+    avgCost: preferredPosition
+      ? String(preferredPosition.avgCost)
+      : Number.isFinite(options.defaultAvgCost)
+        ? String(options.defaultAvgCost)
+        : "",
+    currency: preferredPosition?.currency ?? "",
+  };
+
+  return {
+    fields,
+    values,
+    pendingLabel: options.pendingLabel,
+  };
+}
+
+export function buildSetPortfolioPositionWorkflow(
+  config: AppConfig,
+  options: {
+    activeCollectionId: string | null;
+    activeTicker: TickerRecord | null;
+  },
+): SetPortfolioPositionWorkflowState | null {
+  return buildManualPortfolioPositionWorkflow(config, {
+    preferredPortfolioId: options.activeCollectionId,
+    ticker: options.activeTicker,
+    pendingLabel: "Saving position…",
+  });
+}
+
+export function buildAddToPortfolioWorkflow(
+  config: AppConfig,
+  options: {
+    preferredPortfolioId?: string | null;
+    ticker: TickerRecord | null;
+    defaultAvgCost?: number | null;
+  },
+): SetPortfolioPositionWorkflowState | null {
+  return buildManualPortfolioPositionWorkflow(config, {
+    preferredPortfolioId: options.preferredPortfolioId,
+    ticker: options.ticker,
+    pendingLabel: "Adding to portfolio…",
+    positionOptional: true,
+    defaultAvgCost: options.defaultAvgCost,
+  });
+}

package/src/plugins/builtin/portfolio-list/header.tsx

@@ -1,13 +1,11 @@
-import { useEffect, useMemo, useRef, useState, useSyncExternalStore } from "react";
+import { memo, useEffect, useMemo, useRef, useState, useSyncExternalStore } from "react";
 import { TextAttributes } from "@opentui/core";
 import type { AppState } from "../../../state/app-context";
-import { useFxRatesMap } from "../../../market-data/hooks";
 import { colors, priceColor } from "../../../theme/colors";
 import type { TickerFinancials } from "../../../types/financials";
 import type { Portfolio, TickerRecord } from "../../../types/ticker";
 import { formatCompact, formatNumber, formatPercentRaw, padTo } from "../../../utils/format";
 import { getMostRecentQuoteUpdate } from "../../../utils/quote-time";
-import { selectEffectiveExchangeRates } from "../../../utils/exchange-rate-map";
 import { ibkrGatewayManager } from "../../ibkr/gateway-service";
 import { calculatePortfolioSummaryTotals } from "./metrics";
 import {
@@ -18,22 +16,6 @@ import {
   type ResolvedPortfolioAccountState,
 } from "./summary";
 
-function getSummaryCurrencies(
-  tickers: TickerRecord[],
-  financialsMap: Map<string, TickerFinancials>,
-  baseCurrency: string,
-  accountState: ResolvedPortfolioAccountState | null,
-): string[] {
-  return [
-    baseCurrency,
-    ...tickers.map((ticker) => ticker.metadata.currency),
-    ...tickers.map((ticker) => financialsMap.get(ticker.metadata.ticker)?.quote?.currency),
-    ...tickers.flatMap((ticker) => ticker.metadata.positions.map((position) => position.currency)),
-    ...(accountState?.visibleCashBalances.map((balance) => balance.currency) ?? []),
-    ...(accountState?.visibleCashBalances.map((balance) => balance.baseCurrency) ?? []),
-  ];
-}
-
 export function shouldToggleCashMarginDrawer(key: string | undefined, showCashDrawer: boolean): boolean {
   return key === "c" && showCashDrawer;
 }
@@ -49,7 +31,7 @@ export function usePortfolioAccountState(
   );
   return useMemo(
     () => resolvePortfolioAccountState(portfolio, state, snapshot),
-    [portfolio, snapshot, state],
+    [portfolio, snapshot, state.brokerAccounts, state.config],
   );
 }
 
@@ -139,10 +121,12 @@ export function PortfolioCashMarginDrawer({
   );
 }
 
-export function PortfolioSummaryBar({
+export const PortfolioSummaryBar = memo(function PortfolioSummaryBar({
   tickers,
   financialsMap,
-  state,
+  baseCurrency,
+  exchangeRates,
+  refreshingCount,
   isPortfolio,
   collectionId,
   width,
@@ -150,7 +134,9 @@ export function PortfolioSummaryBar({
 }: {
   tickers: TickerRecord[];
   financialsMap: Map<string, TickerFinancials>;
-  state: AppState;
+  baseCurrency: string;
+  exchangeRates: Map<string, number>;
+  refreshingCount: number;
   isPortfolio: boolean;
   collectionId: string | null;
   width: number;
@@ -163,7 +149,7 @@ export function PortfolioSummaryBar({
   const wasRefreshing = useRef(false);
 
   useEffect(() => {
-    if (state.refreshing.size > 0) {
+    if (refreshingCount > 0) {
       wasRefreshing.current = true;
       return;
     }
@@ -171,7 +157,7 @@ export function PortfolioSummaryBar({
       wasRefreshing.current = false;
       setLastRefresh(new Date());
     }
-  }, [state.refreshing.size]);
+  }, [refreshingCount]);
 
   useEffect(() => {
     if (financialsMap.size > 0 && !lastRefresh) {
@@ -179,27 +165,23 @@ export function PortfolioSummaryBar({
     }
   }, [financialsMap.size, lastRefresh]);
 
-  const exchangeRates = useFxRatesMap(
-    getSummaryCurrencies(tickers, financialsMap, state.config.baseCurrency, accountState),
-  );
-  const effectiveExchangeRates = selectEffectiveExchangeRates(exchangeRates, state.exchangeRates);
   const totals = useMemo(
     () => calculatePortfolioSummaryTotals(
       tickers,
       financialsMap,
-      state.config.baseCurrency,
-      effectiveExchangeRates,
+      baseCurrency,
+      exchangeRates,
       isPortfolio,
       collectionId,
     ),
-    [tickers, financialsMap, state.config.baseCurrency, effectiveExchangeRates, isPortfolio, collectionId],
+    [baseCurrency, collectionId, exchangeRates, financialsMap, isPortfolio, tickers],
   );
 
   const refreshTimestamp = lastRefreshTimestamp ?? lastRefresh?.getTime() ?? null;
   const refreshText = refreshTimestamp != null
     ? new Date(refreshTimestamp).toLocaleTimeString("en-US", { hour: "numeric", minute: "2-digit" })
     : "—";
-  const isRefreshing = state.refreshing.size > 0;
+  const isRefreshing = refreshingCount > 0;
 
   if (!isPortfolio) {
     if (totals.watchlistCount === 0) return null;
@@ -224,4 +206,4 @@ export function PortfolioSummaryBar({
   });
 
   return <box height={1}>{renderSummarySegments(segments, width)}</box>;
-}
+});

package/src/plugins/builtin/portfolio-list/index.tsx

@@ -7,6 +7,7 @@ import {
   getPortfolioPaneSettings,
   resolveCollectionPaneId,
 } from "./settings";
+import { portfolioCliCommand, watchlistCliCommand } from "./cli/commands";
 
 export { shouldToggleCashMarginDrawer };
 
@@ -29,6 +30,10 @@ export const portfolioListPlugin: GloomPlugin = {
       ),
     },
   ],
+  cliCommands: [
+    portfolioCliCommand,
+    watchlistCliCommand,
+  ],
   paneTemplates: [
     {
       id: "new-collection-pane",

package/src/plugins/builtin/portfolio-list/metrics.test.ts

@@ -0,0 +1,61 @@
+import { describe, expect, test } from "bun:test";
+import { getColumnValue, type ColumnContext } from "./metrics";
+import type { ColumnConfig } from "../../../types/config";
+import type { TickerFinancials } from "../../../types/financials";
+import type { TickerRecord } from "../../../types/ticker";
+
+const TICKER_COLUMN: ColumnConfig = {
+  id: "ticker",
+  label: "Ticker",
+  width: 12,
+  align: "left",
+};
+
+const TEST_CONTEXT: ColumnContext = {
+  baseCurrency: "USD",
+  exchangeRates: new Map(),
+  now: Date.now(),
+};
+
+function makeTicker(): TickerRecord {
+  return {
+    metadata: {
+      ticker: "AAPL",
+      exchange: "NASDAQ",
+      currency: "USD",
+      name: "Apple",
+      portfolios: [],
+      watchlists: [],
+      positions: [],
+      custom: {},
+      tags: [],
+    },
+  };
+}
+
+function makeFinancials(marketState?: TickerFinancials["quote"]["marketState"]): TickerFinancials {
+  return {
+    annualStatements: [],
+    quarterlyStatements: [],
+    priceHistory: [],
+    quote: {
+      symbol: "AAPL",
+      price: 100,
+      currency: "USD",
+      change: 1,
+      changePercent: 1,
+      lastUpdated: Date.now(),
+      marketState,
+    },
+  };
+}
+
+describe("portfolio-list metrics", () => {
+  test("maps session states to the portfolio status glyphs", () => {
+    expect(getColumnValue(TICKER_COLUMN, makeTicker(), makeFinancials("REGULAR"), TEST_CONTEXT).text).toBe("● AAPL");
+    expect(getColumnValue(TICKER_COLUMN, makeTicker(), makeFinancials("PRE"), TEST_CONTEXT).text).toBe("◐ AAPL");
+    expect(getColumnValue(TICKER_COLUMN, makeTicker(), makeFinancials("POST"), TEST_CONTEXT).text).toBe("◐ AAPL");
+    expect(getColumnValue(TICKER_COLUMN, makeTicker(), makeFinancials("CLOSED"), TEST_CONTEXT).text).toBe("○ AAPL");
+    expect(getColumnValue(TICKER_COLUMN, makeTicker(), makeFinancials(undefined), TEST_CONTEXT).text).toBe("◌ AAPL");
+  });
+});

package/src/plugins/builtin/portfolio-list/metrics.ts

@@ -5,7 +5,7 @@ import type { TickerRecord } from "../../../types/ticker";
 import { priceColor } from "../../../theme/colors";
 import { clampQuoteTimestamp, formatQuoteAgeWithSource } from "../../../utils/quote-time";
 import { convertCurrency, formatCompact, formatCurrency, formatNumber, formatPercentRaw, formatPrice } from "../../../utils/format";
-import { getActiveQuoteDisplay, type ActiveQuoteDisplay } from "../../../utils/market-status";
+import { getActiveQuoteDisplay, marketStateDot, type ActiveQuoteDisplay } from "../../../utils/market-status";
 import { formatOptionTicker } from "../../../utils/options";
 
 export interface ColumnContext {
@@ -191,7 +191,7 @@ export function getColumnValue(
   switch (col.id) {
     case "ticker": {
       const marketState = quote?.marketState;
-      const statusDot = marketState === "REGULAR" ? "\u25CF" : "\u25CB";
+      const statusDot = marketStateDot(marketState);
       const displayName = ticker.metadata.assetCategory === "OPT"
         ? formatOptionTicker(ticker.metadata.ticker)
         : ticker.metadata.ticker;

package/src/plugins/builtin/portfolio-list/mutations.test.ts

@@ -0,0 +1,187 @@
+import { describe, expect, test } from "bun:test";
+import { createDefaultConfig } from "../../../types/config";
+import type { TickerRecord } from "../../../types/ticker";
+import {
+  createManualPortfolio,
+  deleteManualPortfolio,
+  isManualPortfolio,
+  removeTickerFromPortfolio,
+  resolveManualPositionCurrency,
+  setManualPortfolioPosition,
+} from "./mutations";
+
+function makeTicker(overrides: Partial<TickerRecord["metadata"]> = {}): TickerRecord {
+  return {
+    metadata: {
+      ticker: "AAPL",
+      exchange: "NASDAQ",
+      currency: "USD",
+      name: "Apple Inc.",
+      portfolios: [],
+      watchlists: [],
+      positions: [],
+      custom: {},
+      tags: [],
+      ...overrides,
+    },
+  };
+}
+
+describe("portfolio-list mutations", () => {
+  test("identifies manual portfolios", () => {
+    const config = createDefaultConfig("/tmp/gloomberb-mutations");
+    expect(isManualPortfolio(config.portfolios[0]!)).toBe(true);
+    expect(isManualPortfolio({
+      id: "broker:ibkr",
+      name: "IBKR",
+      currency: "USD",
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-live",
+    })).toBe(false);
+  });
+
+  test("rejects duplicate manual portfolio names", () => {
+    const config = createDefaultConfig("/tmp/gloomberb-mutations");
+    expect(() => createManualPortfolio(config, "Main Portfolio", config.baseCurrency)).toThrow('Portfolio "Main Portfolio" already exists.');
+  });
+
+  test("deletes a manual portfolio and cleans memberships plus positions", () => {
+    const config = createDefaultConfig("/tmp/gloomberb-mutations");
+    config.portfolios.push({ id: "research", name: "Research", currency: "USD" });
+
+    const firstTicker = makeTicker({
+      ticker: "AAPL",
+      portfolios: ["research"],
+      positions: [{
+        portfolio: "research",
+        shares: 10,
+        avgCost: 180,
+        currency: "USD",
+        broker: "manual",
+      }],
+    });
+    const secondTicker = makeTicker({
+      ticker: "MSFT",
+      portfolios: ["research", "main"],
+      positions: [{
+        portfolio: "research",
+        shares: 5,
+        avgCost: 300,
+        currency: "USD",
+        broker: "manual",
+      }, {
+        portfolio: "main",
+        shares: 3,
+        avgCost: 200,
+        currency: "USD",
+        broker: "manual",
+      }],
+    });
+
+    const result = deleteManualPortfolio(config, [firstTicker, secondTicker], "research");
+
+    expect(result.config.portfolios.map((portfolio) => portfolio.id)).toEqual(["main"]);
+    expect(result.cleanedTickerCount).toBe(2);
+    expect(result.removedPositionCount).toBe(2);
+    expect(result.tickers).toEqual([
+      makeTicker({
+        ticker: "AAPL",
+        portfolios: [],
+      }),
+      makeTicker({
+        ticker: "MSFT",
+        portfolios: ["main"],
+        positions: [{
+          portfolio: "main",
+          shares: 3,
+          avgCost: 200,
+          currency: "USD",
+          broker: "manual",
+        }],
+      }),
+    ]);
+  });
+
+  test("removing a ticker from a portfolio also removes its positions", () => {
+    const ticker = makeTicker({
+      portfolios: ["main", "research"],
+      positions: [{
+        portfolio: "research",
+        shares: 4,
+        avgCost: 100,
+        currency: "USD",
+        broker: "manual",
+      }, {
+        portfolio: "main",
+        shares: 1,
+        avgCost: 90,
+        currency: "USD",
+        broker: "manual",
+      }],
+    });
+
+    const result = removeTickerFromPortfolio(ticker, "research");
+
+    expect(result.changed).toBe(true);
+    expect(result.removedPositionCount).toBe(1);
+    expect(result.ticker.metadata.portfolios).toEqual(["main"]);
+    expect(result.ticker.metadata.positions).toEqual([{
+      portfolio: "main",
+      shares: 1,
+      avgCost: 90,
+      currency: "USD",
+      broker: "manual",
+    }]);
+  });
+
+  test("setting a manual position replaces the aggregate entry for that portfolio", () => {
+    const ticker = makeTicker({
+      portfolios: ["main"],
+      positions: [{
+        portfolio: "main",
+        shares: 1,
+        avgCost: 100,
+        currency: "USD",
+        broker: "manual",
+      }, {
+        portfolio: "other",
+        shares: 2,
+        avgCost: 50,
+        currency: "USD",
+        broker: "manual",
+      }],
+    });
+
+    const result = setManualPortfolioPosition(ticker, "main", {
+      shares: 10,
+      avgCost: 150,
+      currency: "USD",
+    });
+
+    expect(result.addedMembership).toBe(false);
+    expect(result.replacedPositionCount).toBe(1);
+    expect(result.ticker.metadata.portfolios).toEqual(["main"]);
+    expect(result.ticker.metadata.positions).toEqual([{
+      portfolio: "other",
+      shares: 2,
+      avgCost: 50,
+      currency: "USD",
+      broker: "manual",
+    }, {
+      portfolio: "main",
+      shares: 10,
+      avgCost: 150,
+      currency: "USD",
+      broker: "manual",
+    }]);
+  });
+
+  test("resolves position currency from explicit, ticker, portfolio, or base currency defaults", () => {
+    const portfolio = { id: "research", name: "Research", currency: "EUR" };
+
+    expect(resolveManualPositionCurrency("jpy", makeTicker(), portfolio, "USD")).toBe("JPY");
+    expect(resolveManualPositionCurrency("", makeTicker({ currency: "CAD" }), portfolio, "USD")).toBe("CAD");
+    expect(resolveManualPositionCurrency("", makeTicker({ currency: "" }), portfolio, "USD")).toBe("EUR");
+    expect(resolveManualPositionCurrency("", makeTicker({ currency: "" }), { ...portfolio, currency: "" }, "USD")).toBe("USD");
+  });
+});