gloomberb 0.18.3 → 0.18.5

package/src/architecture/core-builtin-allowlist.json

@@ -16,15 +16,18 @@
   "src/cli/pane-functions/headless.ts": ["portfolio-list"],
   "src/cli/pane-functions/options.ts": ["ticker-detail"],
   "src/cli/pane-functions/resolver.ts": ["chart-composer"],
+  "src/cli/pane-functions/screenshot-bridge.ts": ["time-sales"],
+  "src/cli/pane-functions/screenshot-chart-evidence.ts": ["chart-composer"],
+  "src/cli/pane-functions/screenshot-data-evidence.ts": ["chart-composer","ticker-detail"],
   "src/cli/pane-functions/screenshot-evidence.ts": ["attention","awards","catalysts","company-attention","company-kpis","credit-documents","exposure","market-heatmap","options-calculator","options-scenario","power","realized-vol","supply-chain","vol-surface","volatility","world-venue-map"],
-  "src/cli/pane-functions/screenshot.ts": ["chart-composer","econ-statistics","market-valuation","portfolio-list","ticker-detail","time-sales"],
+  "src/cli/pane-functions/screenshot-payload.ts": ["chart-composer","econ-statistics","market-valuation","portfolio-list","ticker-detail","time-sales"],
   "src/components/command-bar/commands/direct/index.ts": ["broker-manager"],
   "src/components/command-bar/routes/root/help-items.ts": ["help"],
   "src/components/command-bar/workflow/ops.ts": ["correlation","portfolio-list","ticker-detail"],
   "src/components/layout/shell/index.tsx": ["cloud"],
   "src/components/onboarding/use-onboarding-upgrade.ts": ["chat"],
   "src/layout/desks.ts": ["chart-composer"],
-  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","commodities-energy","commodity-balances","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","debt-maturities","dividend-yield","docs","doe","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","fixed-income","futures","futures-curve","fx-matrix","gpu","help","insider","ipo-calendar","iv-history","jobs","jodi","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","primary-dealers","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","ticker-detail","time-sales","trace-bonds","treasury-auctions","treasury-daily","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
+  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","commodities-energy","commodity-balances","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","crypto-etf-flows","debt-maturities","dividend-yield","docs","doe","earnings","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","fixed-income","futures","futures-curve","fx-matrix","gpu","help","holders","insider","ipo-calendar","iv-history","jobs","jodi","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","primary-dealers","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","thirteenf","ticker-detail","time-sales","trace-bonds","treasury-auctions","treasury-daily","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
   "src/plugins/catalog-ui.ts": ["alerts","clinical-trials","cloud","comment-letters","custom-view","fear-greed","ipo-calendar","market-halts","market-heatmap","members","news","notes","openfda","research-search"],
   "src/plugins/catalog.ts": ["debug"],
   "src/remote/controller.ts": ["custom-view"],

package/src/architecture/ui-literals-allowlist.json

@@ -65,14 +65,14 @@
       "radius": 5,
       "spacing": 2
     },
-    "why": "Chat has its own owner and conventions; reported, not changed (GLO-768)."
+    "why": "Chat has its own owner and conventions; reported, not changed."
   },
   "src/plugins/builtin/chat/content/handle-prompt.tsx": {
     "literals": {
       "font weight": 1,
       "spacing": 2
     },
-    "why": "Chat has its own owner and conventions; reported, not changed (GLO-768)."
+    "why": "Chat has its own owner and conventions; reported, not changed."
   },
   "src/plugins/builtin/chat/message/pane-chip.tsx": {
     "literals": {
@@ -80,7 +80,7 @@
       "radius": 3,
       "spacing": 2
     },
-    "why": "Chat has its own owner and conventions; reported, not changed (GLO-768)."
+    "why": "Chat has its own owner and conventions; reported, not changed."
   },
   "src/plugins/builtin/credit-documents/gauge.tsx": {
     "literals": {

package/src/architecture/ui-tokens-allowlist.json

@@ -26,7 +26,7 @@
       "measure": "inset",
       "value": 7.2,
       "component": "PaneSidebarRow",
-      "why": "Chat has its own owner: its channel rows start 7px in (reported, not changed, in GLO-768)."
+      "why": "Chat has its own owner: its channel rows start 7px in (reported, not changed)."
     }
   ],
   "FXMD_REST_HEALTH": [

package/src/brokers/broker-portfolio-sync.ts

@@ -1,6 +1,7 @@
 import type { BrokerAdapter } from "../types/broker";
 import type { AppConfig, BrokerInstanceConfig } from "../types/config";
 import type { Portfolio, TickerPosition, TickerRecord } from "../types/ticker";
+import type { BrokerAccount } from "../types/trading";
 import { buildBrokerPortfolioId, getBrokerInstance, isBrokerPortfolioId } from "../utils/broker-instances";
 import { isSignedInBrokerProfile } from "./signed-in/profile";
 
@@ -55,6 +56,42 @@ export function isHeldByOtherSignedInProfile(
   return !!owner && owner.id !== instance.id && isSignedInBrokerProfile(owner);
 }
 
+/**
+ * The accounts `instance` reports that another enabled profile already holds
+ * under the account's own number, such as IBKR U1234567 synced on this device
+ * and linked through SnapTrade as well. That profile keeps the account, so its
+ * portfolio and positions appear once.
+ */
+export function accountsHeldUnderOwnNumber(
+  config: AppConfig,
+  instance: BrokerInstanceConfig,
+  accounts: readonly BrokerAccount[],
+): Set<string> {
+  const held = new Set(config.portfolios.flatMap((portfolio) => {
+    if (!portfolio.brokerAccountId || portfolio.brokerInstanceId === instance.id) return [];
+    const owner = getBrokerInstance(config.brokerInstances, portfolio.brokerInstanceId);
+    return owner && owner.enabled !== false ? [portfolio.brokerAccountId.trim().toUpperCase()] : [];
+  }));
+  return new Set(accounts.flatMap((account) => {
+    const number = account.brokerageAccountId?.trim().toUpperCase();
+    return number && held.has(number) ? [account.accountId] : [];
+  }));
+}
+
+/**
+ * The accounts of `instance` to list: without those another enabled profile
+ * holds under their own number (`accountsHeldUnderOwnNumber`), so an account
+ * linked twice appears once wherever accounts are chosen or shown.
+ */
+export function accountsShownFor(
+  config: AppConfig,
+  instance: BrokerInstanceConfig,
+  accounts: BrokerAccount[],
+): BrokerAccount[] {
+  const held = accountsHeldUnderOwnNumber(config, instance, accounts);
+  return held.size ? accounts.filter((account) => !held.has(account.accountId)) : accounts;
+}
+
 /**
  * Who keeps a portfolio when the profile holding it is removed: another
  * enabled profile of the same broker that syncs the same account. Only a

package/src/brokers/directory.ts

@@ -57,6 +57,17 @@ export function brokerMethodSummary(entry: BrokerDirectoryEntry): string {
   return signsIn ? t("Sign in") : t("On this device");
 }
 
+/**
+ * The method summary with what the broker says of itself, for a list that
+ * gives each broker a line under its name: "Sign in · Brokerages you link in
+ * SnapTrade" for one that is not itself a broker.
+ */
+export function brokerDirectorySummary(entry: BrokerDirectoryEntry): string {
+  const described = entry.methods.find((method) => method.kind === "signed-in")?.broker.description?.trim();
+  const summary = brokerMethodSummary(entry);
+  return described ? `${summary} · ${described}` : summary;
+}
+
 export function brokerMethodLabel(entry: BrokerDirectoryEntry, method: BrokerMethod): string {
   if (method.kind === "signed-in") {
     return entry.methods.some((candidate) => candidate.kind === "device") ? t("Sign in (recommended)") : t("Sign in");

package/src/brokers/logos.ts

@@ -15,11 +15,13 @@ function svg(markup: string): string {
 
 /**
  * The marks the official plugins ship as their icon, for the same brokers
- * when Gloom connects them, keyed by the backend's broker id.
+ * when Gloom connects them, keyed by the backend's broker id. SnapTrade has
+ * no plugin: its mark is from its own site, on white.
  */
 const SIGNED_IN_BROKER_LOGOS: Readonly<Record<string, string>> = {
   ibkr: svg('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64"><defs><linearGradient id="t" x1="0" y1="0" x2="0" y2="64" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#262626"/><stop offset="1" stop-color="#0F0F0F"/></linearGradient><linearGradient id="m" gradientUnits="userSpaceOnUse" x1="3633.335" y1="66.0445" x2="3671.0737" y2="66.0445" gradientTransform="matrix(-1 0 0 1 3673.7529 0)"><stop offset="0" stop-color="#D71F27"/><stop offset="1" stop-color="#971B1E"/></linearGradient></defs><rect width="64" height="64" fill="url(#t)"/><g transform="translate(20.4 8.2) scale(0.539)"><polygon points="40.4,86.8 2.7,86.8 2.7,45.3" fill="url(#m)"/><polygon points="40.4,1.5 2.7,45.3 2.7,86.8" fill="#D71F27"/><circle cx="35.2" cy="55.5" r="11.3" fill="#D71F27"/></g></svg>'),
   robinhood: svg('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64"><rect width="64" height="64" fill="#CCFF00"/><path transform="translate(14 14) scale(1.5)" d="M2.84 24h.53c.096 0 .192-.048.224-.128C7.591 13.696 11.94 8.656 14.67 5.638c.112-.128.064-.225-.096-.225h-4.88a.55.55 0 0 0-.45.225L5.746 9.972c-.514.642-.642 1.236-.642 2.086v4.43c-1.14 3.194-1.862 5.361-2.392 7.32-.032.125.016.192.129.192M20.447.646c-.754-.802-4.157-.834-5.73-.224a3 3 0 0 0-.786.465 41 41 0 0 0-3.323 3.178c-.112.113-.064.225.097.225h5.409c.497 0 .786.289.786.786v6.1c0 .16.128.208.225.064l3.258-4.254c.53-.69.69-.898.835-1.861.192-1.413.08-3.58-.77-4.479m-6.982 16.18 2.231-3.676a.7.7 0 0 0 .064-.29V6.73c0-.16-.112-.225-.224-.097-3.355 3.74-5.971 7.672-8.395 12.407-.06.12.016.225.16.177l5.009-1.54c.565-.174.882-.402 1.155-.852" fill="#1A1A1A"/></svg>'),
+  snaptrade: svg('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64"><defs><linearGradient id="a" x1="14" y1="-33.2" x2="39.35" y2="10.81" gradientUnits="userSpaceOnUse"><stop stop-color="#045856"/><stop offset="1" stop-color="#52C4C2"/></linearGradient><linearGradient id="b" x1="14.33" y1="34.34" x2="-24.58" y2="-4.39" gradientUnits="userSpaceOnUse"><stop stop-color="#E6960D"/><stop offset=".27" stop-color="#F2CA86"/></linearGradient><linearGradient id="c" x1="1.95" y1="33.87" x2="-32.55" y2="-6.92" gradientUnits="userSpaceOnUse"><stop stop-color="#E6960D"/><stop offset=".27" stop-color="#F2CA86"/></linearGradient></defs><rect width="64" height="64" fill="#FFFFFF"/><g transform="translate(12.4 10.45) scale(1.4)"><path d="M27.47 11.24 27.11 10.62 22.55 2.73C21.96 1.72 20.88 1.09 19.7 1.09H11.12C9.95 1.09 8.86 1.72 8.28 2.73L3.71 10.62 8.28 18.51C8.86 19.53 9.95 20.15 11.12 20.15H15.42L9.9 10.62 15.41 1.1 20.92 10.62 25.32 18.23 27.46 14.52C28.05 13.5 28.05 12.25 27.46 11.24Z" fill="url(#a)"/><path d="M24.21 20.15 19.64 12.26C19.06 11.25 17.97 10.62 16.8 10.62H12.5L18.01 20.15 12.5 29.69H16.8C17.97 29.69 19.06 29.06 19.64 28.05Z" fill="url(#b)"/><path d="M6.99 20.15 2.59 12.54.44 16.26C-.15 17.27-.15 18.52.44 19.54L.8 20.15 5.36 28.05C5.95 29.06 7.03 29.69 8.21 29.69H12.5L6.99 20.15Z" fill="url(#c)"/></g></svg>'),
 };
 
 /** The plugin icon of a broker adapter (`getBrokerLogo` on the plugin runtime). */

package/src/brokers/signed-in/adapter.ts

@@ -10,12 +10,15 @@ import { ApiRequestError } from "../../api-client/errors";
 import { openUrl } from "../../components/ui/external-link";
 import type { BrokerAdapter, BrokerConnectionStatus, BrokerPosition } from "../../types/broker";
 import type { BrokerInstanceConfig } from "../../types/config";
+import type { Quote } from "../../types/financials";
 import type {
   BrokerAccount,
   BrokerExecution,
   BrokerOrder,
+  BrokerOrderPreview,
   BrokerOrderRequest,
   BrokerPortfolioPerformance,
+  BrokerTradingCapabilities,
 } from "../../types/trading";
 import { findSignedInBroker, refreshSignedInBrokers } from "./catalog";
 import type { SignedInBroker, SignedInBrokerConnection } from "./client";
@@ -47,16 +50,50 @@ function brokerReason(lastError: string | null | undefined): string | null {
   return described.replace(/[\s.]+$/, "").slice(0, 200) || null;
 }
 
-/** What to tell the user when Gloom answers a broker call with an error. */
-function describeSignedInBrokerError(error: unknown, brokerName: string): string {
+/** Gloom holds no live sign-in for the broker: only connecting again helps. */
+class SignInNeededError extends Error {}
+
+/**
+ * What to tell the user when Gloom answers a broker call with an error, and
+ * whether only a new sign-in, to Gloom or the broker, gets the profile going.
+ */
+function describeSignedInBrokerError(error: unknown, brokerName: string): { message: string; needsSignIn: boolean } {
   const status = error instanceof ApiRequestError ? error.status : undefined;
-  if (status === 401) return `Sign in to Gloom first, then connect ${brokerName}.`;
+  if (status === 401) return { message: `Sign in to Gloom first, then connect ${brokerName}.`, needsSignIn: true };
   const signInAgain = `${brokerName} needs you to sign in again. Press Connect in Brokers.`;
   // A sign-in the broker ended says why, in Gloom's words.
-  if (status === 409) return (error instanceof ApiRequestError && writtenMessage(error)) || signInAgain;
-  if (status === 404) return signInAgain;
-  if (status === 502) return `${brokerName} is not responding. Try again shortly.`;
-  return error instanceof Error && error.message ? error.message : String(error);
+  if (status === 409) return { message: (error instanceof ApiRequestError && writtenMessage(error)) || signInAgain, needsSignIn: true };
+  if (status === 404) return { message: signInAgain, needsSignIn: true };
+  if (status === 502) return { message: `${brokerName} is not responding. Try again shortly.`, needsSignIn: false };
+  // A refused order or a busy broker says why without its error code.
+  if (error instanceof ApiRequestError && (status === 403 || status === 422 || status === 503)) {
+    return { message: writtenMessage(error) ?? error.message, needsSignIn: false };
+  }
+  return {
+    message: error instanceof Error && error.message ? error.message : String(error),
+    needsSignIn: error instanceof SignInNeededError,
+  };
+}
+
+/**
+ * Gloom answered an order action and nothing was placed, changed or
+ * cancelled: the broker refused it, its check lapsed, trading is not granted,
+ * the broker was too busy to take it, or the sign-in has to be renewed. A
+ * 502 or a lost answer may have reached the broker, so it is not one.
+ */
+function refusedOrderAction(error: unknown): boolean {
+  if (!(error instanceof ApiRequestError)) return false;
+  return error.status !== undefined && error.status >= 400 && error.status < 500 || error.status === 503;
+}
+
+/** A sign-in that ended or was never made, as opposed to a refused order: the profile's status says so. */
+function signInLost(error: unknown): boolean {
+  if (!(error instanceof ApiRequestError)) return false;
+  return error.status === 401 || error.status === 404 || error.status === 409 && error.code === "reauth_required";
+}
+
+function refused(message: string): Error {
+  return Object.assign(new Error(message), { refused: true });
 }
 
 /** The broker does not offer this. A broker tool that failed is also a 422, but a failure. */
@@ -67,7 +104,7 @@ function isUnsupported(error: unknown): boolean {
 type BrokerRequest = <T>(
   broker: string,
   path: string,
-  options?: { method?: "GET" | "POST" | "DELETE"; body?: unknown },
+  options?: { method?: "GET" | "POST" | "PUT" | "DELETE"; body?: unknown },
 ) => Promise<T>;
 
 export interface SignedInBrokerAdapterDeps {
@@ -84,6 +121,60 @@ interface PortfolioSnapshot {
   fetchedAt?: number;
 }
 
+/** Gloom's answer to a direct-mode order, before the user confirms it. */
+interface DirectOrderPreview {
+  status: "preview";
+  previewId: string;
+  expiresAt: string;
+  impact: {
+    source: "broker" | "unavailable";
+    sourceLabel: string;
+    currency?: string;
+    estimatedCost?: number;
+    cashBefore?: number;
+    cashAfter?: number;
+    commission?: number;
+    fees?: number;
+    disclosure: string;
+  };
+}
+
+interface PlacedOrder { status: "placed"; order: BrokerOrder }
+
+/** The quote a direct-mode broker gives the ticket. */
+interface SignedInBrokerQuote {
+  symbol: string;
+  name?: string;
+  currency?: string;
+  price: number;
+  bid?: number;
+  ask?: number;
+  bidSize?: number;
+  askSize?: number;
+  lastTradePrice?: number;
+  lastUpdated: number;
+  dataSource: "live" | "delayed";
+}
+
+/** The same order always keys the same, whatever order its fields arrive in. */
+function canonical(value: unknown): string {
+  if (Array.isArray(value)) return `[${value.map(canonical).join(",")}]`;
+  if (value && typeof value === "object") {
+    return `{${Object.entries(value).filter(([, entry]) => entry !== undefined).sort(([a], [b]) => (a < b ? -1 : a > b ? 1 : 0))
+      .map(([key, entry]) => `${JSON.stringify(key)}:${canonical(entry)}`).join(",")}}`;
+  }
+  return JSON.stringify(value) ?? "null";
+}
+
+/** The ticket's fields, without the profile's own, as Gloom checks and places the order. */
+function orderBody(request: BrokerOrderRequest): BrokerOrderRequest {
+  const { brokerInstanceId: _profile, ...body } = request;
+  const { brokerInstanceId: _contractProfile, ...contract } = body.contract;
+  return { ...body, contract };
+}
+
+const DIRECT_TIF = ["DAY"];
+
 export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAdapterDeps> = {}): BrokerAdapter {
   const deps: SignedInBrokerAdapterDeps = {
     request: (broker, path, options) => apiClient.brokerRequest(broker, path, options),
@@ -95,12 +186,29 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
   };
   const statuses = new Map<string, BrokerConnectionStatus>();
   const listeners = new Map<string, Set<() => void>>();
+  /** Whether each profile's sign-in granted trading, as its last connect read it. */
+  const canTrade = new Map<string, boolean>();
+  /** Direct mode: the check the user is reviewing, per profile, by the exact order it was for. */
+  const previews = new Map<string, { order: string; previewId: string; expiresAt: number }>();
+  /** Direct mode: the broker's own id behind each order number the app holds, per profile. */
+  const handles = new Map<string, Map<number, { accountId: string; brokerOrderId: string }>>();
 
   const brokerName = (instance: BrokerInstanceConfig) =>
     deps.findBroker(signedInBrokerId(instance))?.name ?? instance.label;
 
-  const setStatus = (instance: BrokerInstanceConfig, state: "connected" | "error", message?: string) => {
-    statuses.set(instance.id, { state, message, mode: METHOD, updatedAt: deps.now() });
+  /** The broker's direct-mode orders, or null for one that keeps orders for review or takes none. */
+  const directOrders = (instance: BrokerInstanceConfig) => {
+    const orders = deps.findBroker(signedInBrokerId(instance))?.capabilities.orders;
+    return orders && orders.mode === "direct" ? orders : null;
+  };
+
+  const setStatus = (instance: BrokerInstanceConfig, state: "connected" | "error", message?: string, needsSignIn = false) => {
+    statuses.set(instance.id, {
+      state, message, mode: METHOD, updatedAt: deps.now(),
+      ...(needsSignIn ? { needsSignIn } : {}),
+      // A direct-mode broker says per quote whether it is real-time.
+      ...(directOrders(instance) ? { quoteData: "realtime" as const } : {}),
+    });
     for (const listener of listeners.get(instance.id) ?? []) listener();
   };
 
@@ -111,8 +219,8 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
       setStatus(instance, "connected");
       return result;
     } catch (error) {
-      const message = describeSignedInBrokerError(error, brokerName(instance));
-      setStatus(instance, "error", message);
+      const { message, needsSignIn } = describeSignedInBrokerError(error, brokerName(instance));
+      setStatus(instance, "error", message, needsSignIn);
       throw new Error(message);
     }
   };
@@ -130,7 +238,51 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
   const snapshot = (instance: BrokerInstanceConfig) =>
     track(instance, () => get<PortfolioSnapshot>(instance, "/snapshot"));
 
-  /** Checks an order against what the broker takes, before Gloom sees it. */
+  /**
+   * An order as the app holds it: this profile's, under this adapter, and
+   * remembered by its number so a change or cancel can name it to the broker.
+   */
+  const ownOrder = (instance: BrokerInstanceConfig, order: BrokerOrder): BrokerOrder => {
+    if (order.brokerOrderId && order.accountId) {
+      const known = handles.get(instance.id) ?? new Map();
+      known.set(order.orderId, { accountId: order.accountId, brokerOrderId: order.brokerOrderId });
+      handles.set(instance.id, known);
+    }
+    return { ...order, brokerInstanceId: instance.id, contract: { ...order.contract, brokerId: SIGNED_IN_BROKER_TYPE, brokerInstanceId: instance.id } };
+  };
+
+  /**
+   * One order action. A refusal leaves the profile's status alone (the
+   * broker is fine; the order is not) and is marked refused; a sign-in that
+   * ended shows on the profile as any failed call does.
+   */
+  const orderAction = async <T>(instance: BrokerInstanceConfig, run: () => Promise<T>): Promise<T> => {
+    try {
+      const result = await run();
+      setStatus(instance, "connected");
+      return result;
+    } catch (error) {
+      const { message, needsSignIn } = describeSignedInBrokerError(error, brokerName(instance));
+      if (signInLost(error)) setStatus(instance, "error", message, needsSignIn);
+      throw refusedOrderAction(error) ? refused(message) : new Error(message);
+    }
+  };
+
+  /** The broker's id for an order number; nothing is sent when it cannot be found. */
+  const brokerOrderHandle = async (instance: BrokerInstanceConfig, orderId: number) => {
+    const known = handles.get(instance.id)?.get(orderId);
+    if (known) return known;
+    try {
+      for (const order of await get<BrokerOrder[]>(instance, "/orders")) ownOrder(instance, order);
+    } catch (error) {
+      throw refused(describeSignedInBrokerError(error, brokerName(instance)).message);
+    }
+    const found = handles.get(instance.id)?.get(orderId);
+    if (!found) throw refused("This order is no longer listed. Refresh your orders.");
+    return found;
+  };
+
+  /** Checks an order against what the broker takes, before Gloom sees it: a failure sent nothing. */
   const checkOrder = async (instance: BrokerInstanceConfig, request: BrokerOrderRequest) => {
     const id = signedInBrokerId(instance);
     let broker = deps.findBroker(id);
@@ -140,14 +292,25 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
     }
     const name = broker?.name ?? instance.label;
     const orders = broker?.capabilities.orders;
-    if (!orders) throw new Error(`${name} does not take orders from Gloom.`);
+    if (!orders) throw refused(`${name} does not take orders from Gloom.`);
     if (!orders.types.includes(request.orderType)) {
-      throw new Error(`${name} does not take ${request.orderType} orders from Gloom.`);
+      throw refused(`${name} does not take ${request.orderType} orders from Gloom.`);
+    }
+    // A server that does not say it takes a bracket, an OCO pair or a trailing stop would drop its fields and place a bare
+    // order: never send one it has not named.
+    if (!request.orderClass && (request.takeProfitPrice !== undefined || request.stopLossPrice !== undefined)) {
+      throw refused("A take profit or stop loss needs a bracket or OCO order.");
+    }
+    if (request.orderClass && !orders.orderClasses?.includes(request.orderClass)) {
+      throw refused(`${name} does not take ${request.orderClass === "oco" ? "OCO" : "bracket"} orders from Gloom.`);
+    }
+    if (request.orderType === "TRAIL" && !orders.trailing?.includes(request.trailingPercent !== undefined ? "percent" : "amount")) {
+      throw refused(`${name} does not take this trailing stop from Gloom.`);
     }
-    if (!(request.quantity > 0)) throw new Error("Quantity must be positive.");
+    if (!(request.quantity > 0)) throw refused("Quantity must be positive.");
     const needsLimit = request.orderType === "LMT" || request.orderType === "STP LMT";
     if (needsLimit && !(typeof request.limitPrice === "number" && request.limitPrice > 0)) {
-      throw new Error("A limit order needs a limit price.");
+      throw refused("A limit order needs a limit price.");
     }
     return { name, mode: orders.mode };
   };
@@ -156,6 +319,8 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
     id: SIGNED_IN_BROKER_TYPE,
     name: "Signed-in broker",
     configSchema: [],
+    // A signed-in broker's quotes come through Gloom and count against the broker's allowance.
+    ticketQuotesOnly: true,
 
     async validate() {
       return true;
@@ -191,17 +356,51 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
       return getOptional<BrokerExecution[]>(instance, "/executions?period=DAYS_90", []);
     },
 
-    listOpenOrders(instance) {
-      return getOptional<BrokerOrder[]>(instance, "/orders", []);
+    async listOpenOrders(instance) {
+      return (await getOptional<BrokerOrder[]>(instance, "/orders", [])).map((order) => ownOrder(instance, order));
     },
 
     async previewOrder(instance, request) {
       const { name, mode } = await checkOrder(instance, request);
-      return mode === "review" ? { warningText: `${name} opens this order for you to review and submit.` } : {};
+      if (mode === "review") return { warningText: `${name} opens this order for you to review and submit.` };
+      const answer = await orderAction(instance, () => deps.request<DirectOrderPreview>(
+        signedInBrokerId(instance),
+        "/orders",
+        { method: "POST", body: orderBody(request) },
+      ));
+      previews.set(instance.id, { order: canonical(orderBody(request)), previewId: answer.previewId, expiresAt: Date.parse(answer.expiresAt) });
+      const { impact } = answer;
+      const preview: BrokerOrderPreview = {
+        impactSource: impact.source,
+        impactSourceLabel: impact.sourceLabel,
+        disclosure: impact.disclosure,
+        currency: impact.currency,
+        estimatedCost: impact.estimatedCost,
+        commission: impact.commission,
+        commissionCurrency: impact.commission === undefined ? undefined : impact.currency,
+        fees: impact.fees,
+        cashBefore: impact.cashBefore,
+        cashAfter: impact.cashAfter,
+      };
+      return Object.fromEntries(Object.entries(preview).filter(([, value]) => value !== undefined)) as BrokerOrderPreview;
     },
 
     async placeOrder(instance, request) {
-      const { name } = await checkOrder(instance, request);
+      const { name, mode } = await checkOrder(instance, request);
+      if (mode === "direct") {
+        // Only the order the user reviewed, while its check stands.
+        const preview = previews.get(instance.id);
+        if (!preview || preview.order !== canonical(orderBody(request)) || !(preview.expiresAt > deps.now())) {
+          throw refused("Review this order again before placing it.");
+        }
+        const placed = await orderAction(instance, () => deps.request<PlacedOrder>(
+          signedInBrokerId(instance),
+          "/orders",
+          { method: "POST", body: { ...orderBody(request), previewId: preview.previewId } },
+        ));
+        previews.delete(instance.id);
+        return ownOrder(instance, placed.order);
+      }
       const placed = await track(instance, () => deps.request<{ status: string; id: string; reviewUrl: string }>(
         signedInBrokerId(instance),
         "/orders",
@@ -228,23 +427,102 @@ export function createSignedInBrokerAdapter(overrides: Partial<SignedInBrokerAda
       };
     },
 
-    async modifyOrder(instance) {
+    async modifyOrder(instance, orderId, request) {
+      const { name, mode } = await checkOrder(instance, request);
+      if (mode !== "direct") throw refused(`Orders sent to ${name} are managed in ${name}.`);
+      const handle = await brokerOrderHandle(instance, orderId);
+      const changed = await orderAction(instance, () => deps.request<PlacedOrder>(
+        signedInBrokerId(instance),
+        `/orders/${encodeURIComponent(handle.brokerOrderId)}`,
+        { method: "PUT", body: { ...orderBody(request), accountId: handle.accountId } },
+      ));
+      return ownOrder(instance, changed.order);
+    },
+
+    async cancelOrder(instance, orderId) {
       const name = brokerName(instance);
-      throw new Error(`Orders sent to ${name} are managed in ${name}.`);
+      if (!directOrders(instance)) throw refused(`Orders sent to ${name} are managed in ${name}.`);
+      const handle = await brokerOrderHandle(instance, orderId);
+      await orderAction(instance, () => deps.request<{ cancelled: boolean }>(
+        signedInBrokerId(instance),
+        `/orders/${encodeURIComponent(handle.brokerOrderId)}?accountId=${encodeURIComponent(handle.accountId)}`,
+        { method: "DELETE" },
+      ));
     },
 
-    async cancelOrder(instance) {
+    /**
+     * Direct mode only: what the ticket offers. Trading needs the profile
+     * switched on and a sign-in that granted it; the broker's linked
+     * account may still be read-only, which its check then says.
+     */
+    getTradingCapabilities(instance) {
       const name = brokerName(instance);
-      throw new Error(`Orders sent to ${name} are managed in ${name}.`);
+      const orders = directOrders(instance);
+      if (!orders) {
+        return { enabled: false, disabledReason: `${name} does not take orders from the ticket.`, orderTypes: [], tif: [] };
+      }
+      const granted = canTrade.get(instance.id) === true;
+      const switchedOn = instance.config.tradingEnabled === true;
+      const capabilities: BrokerTradingCapabilities = {
+        enabled: granted && switchedOn,
+        orderTypes: [...orders.types],
+        tif: orders.tif?.length ? [...orders.tif] : DIRECT_TIF,
+        ...(orders.orderClasses?.length ? { orderClasses: [...orders.orderClasses] } : {}),
+        ...(orders.trailing?.length ? { trailing: [...orders.trailing] } : {}),
+        minQuantity: 1,
+        quantityStep: 1,
+        modify: true,
+        cancel: true,
+        executionKind: "order-summaries",
+      };
+      if (!granted) capabilities.disabledReason = `${name} is connected read-only. Connect it again in Brokers to allow trading.`;
+      else if (!switchedOn) capabilities.disabledReason = "Trading is off for this profile.";
+      return capabilities;
+    },
+
+    getTradingConfigUpdate(_instance, enabled) {
+      return { tradingEnabled: enabled };
+    },
+
+    // The ticket's quote. A symbol the broker cannot price, or its request
+    // allowance spent, is the ticket's to say; only a lost sign-in is the profile's.
+    async getQuote(ticker, instance) {
+      const id = signedInBrokerId(instance);
+      if (!directOrders(instance)) throw new Error(`${brokerName(instance)} gives no quotes to the ticket.`);
+      const answer = await orderAction(instance, () => deps.request<SignedInBrokerQuote>(
+        id,
+        `/quote?symbol=${encodeURIComponent(ticker.trim().toUpperCase())}`,
+      ));
+      const quote: Quote = {
+        symbol: answer.symbol,
+        name: answer.name,
+        price: answer.price,
+        bid: answer.bid,
+        ask: answer.ask,
+        bidSize: answer.bidSize,
+        askSize: answer.askSize,
+        currency: answer.currency ?? "USD",
+        // The broker gives no prior close: no change to show.
+        change: Number.NaN,
+        changePercent: Number.NaN,
+        changeBasis: "none",
+        lastUpdated: answer.lastUpdated,
+        receivedAt: deps.now(),
+        dataSource: answer.dataSource,
+        delivery: "poll",
+        providerId: id,
+      };
+      return quote;
     },
 
     async connect(instance) {
       await track(instance, async () => {
         const connection = await get<SignedInBrokerConnection>(instance, "");
+        canTrade.set(instance.id, connection.status === "connected" && connection.canTrade === true);
         if (connection.status !== "connected") {
           const name = brokerName(instance);
           const reason = brokerReason(connection.lastError);
-          throw new Error(reason
+          throw new SignInNeededError(reason
             ? `${name} needs you to sign in again: ${reason}. Press Connect in Brokers.`
             : `Press Connect in Brokers to sign in to ${name}.`);
         }

package/src/brokers/signed-in/client.ts

@@ -4,12 +4,22 @@
  * appears here without an app release.
  */
 import { apiClient } from "../../api-client";
-import type { BrokerOrderType } from "../../types/trading";
+import type { BrokerOrderClass, BrokerOrderType, BrokerTrailingUnit } from "../../types/trading";
 
 interface SignedInBrokerCapabilities {
   history: boolean;
   executions: boolean;
-  orders: false | { mode: "review" | "direct"; types: BrokerOrderType[] };
+  /**
+   * Review: the broker keeps each order for the user to submit there. Direct: Gloom checks the
+   * order with the broker, the user confirms that check in the ticket, and Gloom places it.
+   */
+  orders: false | {
+    mode: "review" | "direct"; types: BrokerOrderType[]; tif?: string[];
+    /** Brackets and OCO pairs the broker places and runs itself; absent from a server that sends none. */
+    orderClasses?: BrokerOrderClass[];
+    /** How a trailing stop (`TRAIL` in `types`) is set. */
+    trailing?: BrokerTrailingUnit[];
+  };
   /** Connecting Gloom replaces this broker's link to other AI apps. */
   singleConnection: boolean;
   /** Shown before connecting, e.g. an account the user must create first. */
@@ -19,6 +29,8 @@ interface SignedInBrokerCapabilities {
 export interface SignedInBroker {
   id: string;
   name: string;
+  /** Under the name where brokers are listed, for one that is not itself a broker (SnapTrade). */
+  description?: string;
   capabilities: SignedInBrokerCapabilities;
 }