gloomberb 0.18.3 → 0.18.5

package/src/renderers/electrobun/bun/desktop/state-broadcaster.ts

@@ -28,6 +28,7 @@ function desktopStateKey(snapshot: DesktopSharedStateSnapshot): string {
     paneState: snapshot.paneState,
     focusedPaneId: snapshot.focusedPaneId,
     statusBarVisible: snapshot.statusBarVisible,
+    brokerSyncErrors: snapshot.brokerSyncErrors ?? {},
   });
 }
 

package/src/renderers/electrobun/bun/desktop/update.ts

@@ -33,13 +33,14 @@ import {
 import { logFailure } from "../../../../utils/log-failure";
 import { compareSemver, isPrereleaseVersion } from "../../../../utils/semver";
 import { VERSION } from "../../../../version";
+import { DESKTOP_APP_NAME, LEGACY_DESKTOP_APP_NAME } from "../../shared/app-name";
 
 type ElectrobunUpdater = typeof Electrobun.Updater;
 
 /**
  * The part of Electrobun's updater this flow uses. Tests pass a fake, because
  * the real module cannot be loaded or exercised outside the packaged app.
- * `setUpdateSource` is Gloomberb's patch (patches/electrobun@*.patch).
+ * `setUpdateSource` is this app's patch (patches/electrobun@*.patch).
  */
 export type ElectrobunUpdaterApi = Pick<
   ElectrobunUpdater,
@@ -51,7 +52,7 @@ export type ElectrobunUpdaterApi = Pick<
   | "getStatusHistory"
   | "onStatusChange"
   | "setUpdateSource"
-> & {
+> & Partial<Pick<ElectrobunUpdater, "appDataFolder">> & {
   localInfo: Pick<ElectrobunUpdater["localInfo"], "channel" | "baseUrl">;
 };
 
@@ -81,6 +82,8 @@ function isUpdateAside(entry: string, appName: string): boolean {
  * process runs from: starting from it means the install that left them worked.
  * macOS keeps the app in its bundle, Linux in `<app data>/app` (`bin/bun`
  * inside it); Windows installs through its own script and leaves none.
+ * Beside `Gloom.app` it also takes `Gloomberb.app.previous`: the copy the
+ * update that brought the new name moved aside, under the old one.
  * Resolves to the paths it removed.
  */
 export async function removeUpdateAsides(
@@ -92,9 +95,12 @@ export async function removeUpdateAsides(
     : platform === "linux" && basename(dirname(execPath)) === "bin" ? dirname(dirname(execPath)) : undefined;
   if (!app) return [];
   const folder = dirname(app);
+  const names = platform === "darwin" && basename(app) === `${DESKTOP_APP_NAME}.app`
+    ? [basename(app), `${LEGACY_DESKTOP_APP_NAME}.app`]
+    : [basename(app)];
   const removed: string[] = [];
   for (const entry of await readdir(folder).catch(() => [] as string[])) {
-    if (!isUpdateAside(entry, basename(app))) continue;
+    if (!names.some((name) => isUpdateAside(entry, name))) continue;
     const path = join(folder, entry);
     // One that still cannot be removed (another user's) is tried again at the next start.
     const done = await rm(path, { recursive: true, force: true }).then(() => true, logFailure("desktop-update", "Could not remove an old copy of the app", false));
@@ -103,6 +109,65 @@ export async function removeUpdateAsides(
   return removed;
 }
 
+const TAR_BLOCK = 512;
+
+/**
+ * The first path in a tar, read from its leading headers: a ustar name and
+ * prefix, or the long name a pax (`x`) or GNU (`L`) header gives it. Null when
+ * `bytes` ends before one.
+ */
+export function firstTarPath(bytes: Uint8Array): string | null {
+  const decoder = new TextDecoder();
+  const field = (start: number, length: number) => {
+    const raw = bytes.subarray(start, start + length);
+    const end = raw.indexOf(0);
+    return decoder.decode(end === -1 ? raw : raw.subarray(0, end));
+  };
+  let longName: string | null = null;
+  for (let header = 0; header + TAR_BLOCK <= bytes.length;) {
+    if (bytes[header] === 0) return null;
+    const type = String.fromCharCode(bytes[header + 156] ?? 0);
+    const size = Number.parseInt(field(header + 124, 12).trim() || "0", 8);
+    const data = header + TAR_BLOCK;
+    if (type === "x" || type === "L" || type === "g" || type === "K") {
+      if (!Number.isFinite(size) || data + size > bytes.length) return null;
+      if (type === "L") longName = field(data, size);
+      if (type === "x") longName = /(?:^|\n)\d+ path=([^\n]*)\n/.exec(decoder.decode(bytes.subarray(data, data + size)))?.[1] ?? longName;
+      header = data + Math.ceil(size / TAR_BLOCK) * TAR_BLOCK;
+      continue;
+    }
+    if (longName) return longName;
+    const name = field(header, 100);
+    // POSIX ustar ("ustar\0") only: GNU tar keeps other fields where the prefix would be.
+    const prefix = field(header + 257, 6) === "ustar" ? field(header + 345, 155) : "";
+    return prefix ? `${prefix}/${name}` : name;
+  }
+  return null;
+}
+
+/**
+ * Removes the unpacked update archives in Electrobun's `self-extraction`
+ * folder whose app carries its name from before the rename. The one that
+ * matters is the Windows archive an install from then updated from: it is
+ * packed again with the folder renamed (scripts/write-legacy-desktop-files.ts),
+ * so its bytes are not those of the archive the next release's patch is made
+ * from, and bspatch would turn it into a broken build. Without it the updater
+ * downloads the full archive instead. Resolves to the paths it removed.
+ */
+async function removeLegacyUpdateArchives(folder: string): Promise<string[]> {
+  const removed: string[] = [];
+  for (const entry of await readdir(folder).catch(() => [] as string[])) {
+    if (!entry.endsWith(".tar")) continue;
+    const path = join(folder, entry);
+    const head = await Bun.file(path).slice(0, 64 * 1024).bytes().catch(() => null);
+    const top = head ? firstTarPath(head)?.replace(/^\.\//, "").split("/")[0] : undefined;
+    if (top !== LEGACY_DESKTOP_APP_NAME && top !== `${LEGACY_DESKTOP_APP_NAME}.app`) continue;
+    const done = await rm(path, { force: true }).then(() => true, logFailure("desktop-update", "Could not remove an update archive from before the rename", false));
+    if (done) removed.push(path);
+  }
+  return removed;
+}
+
 /**
  * Where the running app sits, for update failure reports and for what an
  * install that cannot replace it means. Electrobun replaces the macOS bundle
@@ -464,6 +529,8 @@ export function createElectrobunDesktopUpdater(
       }
       target = result.release;
 
+      const appData = await updater.appDataFolder?.().catch(() => null);
+      if (appData) await removeLegacyUpdateArchives(join(appData, "self-extraction"));
       await updater.downloadUpdate();
       const updateInfo = updater.updateInfo();
       if (updateInfo?.error) {

package/src/renderers/electrobun/bun/desktop/workspace/index.ts

@@ -151,6 +151,7 @@ export function createDesktopWorkspace(
     paneState: clonePaneStateMap(sharedState.paneState),
     focusedPaneId: sharedState.focusedPaneId,
     statusBarVisible: sharedState.statusBarVisible,
+    brokerSyncErrors: { ...sharedState.brokerSyncErrors },
     mainStateRevision: sharedState.mainStateRevision,
     layoutChanged: sharedState.layoutChanged,
   });
@@ -179,6 +180,7 @@ export function createDesktopWorkspace(
         paneState: filterPaneState(syncedConfig.layout, clonePaneStateMap(snapshot.paneState)),
         focusedPaneId: snapshot.focusedPaneId,
         statusBarVisible: snapshot.statusBarVisible,
+        brokerSyncErrors: { ...snapshot.brokerSyncErrors },
         mainStateRevision: snapshot.mainStateRevision ?? currentRevision,
         layoutChanged: snapshot.layoutChanged,
       };

package/src/renderers/electrobun/bun/external-plugins.ts

@@ -14,6 +14,7 @@ import {
   loadExternalPlugin,
 } from "../../../plugins/loader";
 import { createNodePluginManager } from "../../../plugins/manager-node";
+import { deactivatePluginForRemoval } from "../../../plugins/marketplace/deactivation";
 import { readPluginIcon } from "../../../plugins/plugin-icon";
 import type { PluginRegistry } from "../../../plugins/registry";
 import { desktopRendererCapabilityManifests } from "./desktop/initialization";
@@ -157,6 +158,33 @@ export async function collectExternalPluginBundles(): Promise<DesktopExternalPlu
   return bundles;
 }
 
+let prefetchedBundles: Promise<DesktopExternalPluginBundle[]> | null = null;
+
+/**
+ * Starts compiling every plugin for the view before it asks. The bundle cache
+ * above lives in memory, so the first window of a launch always compiles;
+ * started at launch, that runs while the view loads its own bundle.
+ */
+export function prefetchExternalPluginBundles(): void {
+  if (prefetchedBundles) return;
+  const bundles = collectExternalPluginBundles();
+  // The view's request reports a failure; this one only must not go unhandled.
+  bundles.catch(() => {
+    // Intentional ignore: the window that takes these bundles reports the failure.
+  });
+  prefetchedBundles = bundles;
+}
+
+/**
+ * The bundles for a window: the launch's prefetch once, then a new collection,
+ * which the mtime cache keeps cheap, so a later window sees plugins installed since.
+ */
+export function takeExternalPluginBundles(): Promise<DesktopExternalPluginBundle[]> {
+  const prefetched = prefetchedBundles;
+  prefetchedBundles = null;
+  return prefetched ?? collectExternalPluginBundles();
+}
+
 /** One plugin, compiled fresh, so the view can activate what was just installed or updated. */
 export function bundleExternalPluginDirectory(directory: string): Promise<DesktopExternalPluginBundle | null> {
   return bundlePluginDirectory(join(getPluginsDir(), directory), { fresh: true });
@@ -209,12 +237,6 @@ export function deactivateExternalPlugin(
   registry: PluginRegistry,
   pluginId: string,
 ): { capabilityManifests: ReturnType<typeof desktopRendererCapabilityManifests> } {
-  if (registry.allPlugins.has(pluginId)) {
-    try {
-      registry.unregister(pluginId);
-    } catch (error) {
-      log.error(`Deactivating ${pluginId} failed: ${error instanceof Error ? error.message : String(error)}`);
-    }
-  }
+  deactivatePluginForRemoval(registry, pluginId);
   return { capabilityManifests: desktopRendererCapabilityManifests(registry.capabilities) };
 }

package/src/renderers/electrobun/bun/index.ts

@@ -1,4 +1,5 @@
-import Electrobun, { ApplicationMenu, Screen } from "electrobun/bun";
+import Electrobun, { ApplicationMenu, Screen, Utils } from "electrobun/bun";
+import { homedir } from "os";
 import { debugLog } from "../../../utils/debug-log";
 import { setConfigStoreHost } from "../../../data/config/store";
 import * as nodeConfigStoreHost from "../../../data/config/store/node";
@@ -6,6 +7,7 @@ import { ELECTROBUN_CONTEXT_MENU_ACTION } from "../shared/protocol";
 import { contextMenuSelectionMessage } from "./context-menu/click";
 import { applicationMenuCommand, createApplicationMenuGate } from "./application-menu/click";
 import { DesktopBackend } from "./desktop/backend";
+import { startDesktopBackend } from "./desktop/initialization";
 import {
   MAIN_WINDOW_MIN_SIZE,
   defaultMainWindowFrame,
@@ -13,6 +15,7 @@ import {
 } from "./window/frame";
 import { MAIN_WINDOW_RPC_KEY } from "./window/focus";
 import { createAppWindow } from "./window/create";
+import { desktopBootFramePath, desktopBootFramePreload, readDesktopBootFrame } from "./window/boot-frame";
 import { getWindowFrame } from "./window/events";
 import {
   fitWindowFrameToDisplays,
@@ -23,6 +26,8 @@ import {
 } from "./window/remembered-frame";
 import { reapStaleTerminalMedia } from "../../opentui/terminal-media";
 import { installProcessCrashListeners } from "../../../telemetry/crash-reports-node";
+import { renameLegacyMacApp } from "./desktop/app-name";
+import { scheduleDesktopRelaunch } from "./desktop/relaunch";
 
 console.log = (...args) => console.error(...args);
 console.info = (...args) => console.error(...args);
@@ -40,6 +45,27 @@ setConfigStoreHost(nodeConfigStoreHost);
 // before the config, and its off switch, has been read.
 installProcessCrashListeners();
 
+// An install from before the rename runs from Gloomberb.app, where its updater
+// put this build. It takes the new name and opens again from there before any
+// window shows. Anywhere else this returns without touching the disk.
+const appRename = await renameLegacyMacApp({
+  execPath: process.execPath,
+  platform: process.platform,
+  homeDir: homedir(),
+  pathEnv: process.env.PATH ?? "",
+}).catch((error: unknown) => {
+  console.error("[desktop] could not give the app its new name", error instanceof Error ? error.message : String(error));
+  return null;
+});
+if (appRename?.kind === "renamed") {
+  scheduleDesktopRelaunch(appRename.bundle);
+  Utils.quit();
+  // The process is exiting; nothing below may open a window meanwhile.
+  await new Promise<never>(() => {});
+} else if (appRename?.kind === "skipped") {
+  console.error(`[desktop] kept the app's old name: ${appRename.reason}`);
+}
+
 function readOpenUrlEvent(event: unknown): string | null {
   const data = event && typeof event === "object" ? (event as { data?: unknown }).data : null;
   if (!data || typeof data !== "object") return null;
@@ -135,13 +161,21 @@ function scheduleRememberedWindow(): void {
 }
 
 const mainWindow = createAppWindow({
-  title: "Gloomberb",
+  title: "Gloom",
   frame: initialMainWindowFrame,
   rpc: mainRpc,
   minSize: MAIN_WINDOW_MIN_SIZE,
   onFrameChange: scheduleRememberedWindow,
+  // The layout the window last drew, which its page draws before its script
+  // has loaded (dom/boot-frame.ts).
+  preload: desktopBootFramePreload(readDesktopBootFrame(desktopBootFramePath())),
 });
 backend.mainWindow = mainWindow;
+// The window is loading its view; the services it will ask for start now
+// rather than when it asks. Its `init` reports a failure, and retries.
+startDesktopBackend(backend).catch((error) => {
+  console.error("[desktop] startup failed", error instanceof Error ? error.stack ?? error.message : String(error));
+});
 if (rememberedWindow?.fullscreen) {
   try { mainWindow.setFullScreen(true); } catch { /* the framed window is still the one they sized */ }
 } else if (rememberedWindow?.maximized) {

package/src/renderers/electrobun/bun/window/boot-frame.ts

@@ -0,0 +1,67 @@
+import { mkdirSync, readFileSync, renameSync, rmSync, writeFileSync } from "fs";
+import { dirname, join } from "path";
+import { getGloomberbDirs } from "../../../../data/config/home";
+import { isBootFrame, type BootFrame } from "../../../dom/boot-frame-page";
+import { DESKTOP_BOOT_FRAME_GLOBAL } from "../../shared/boot-frame";
+
+/**
+ * The main window's launch frame lives beside the remembered window frame:
+ * read before the config, and drawn for this machine's screen.
+ */
+const FILE_NAME = "desktop-boot-frame.json";
+
+export function desktopBootFramePath(env: NodeJS.ProcessEnv = process.env): string {
+  return join(dirname(getGloomberbDirs(env).configFile), FILE_NAME);
+}
+
+export function readDesktopBootFrame(path: string): BootFrame | null {
+  try {
+    const frame: unknown = JSON.parse(readFileSync(path, "utf8"));
+    return isBootFrame(frame) ? frame : null;
+  } catch {
+    return null;
+  }
+}
+
+interface BootFrameSender {
+  /** The main window's view; a popped-out pane's draws no frame. */
+  mainWindow: boolean;
+  /** A session is up. After all data was reset there is none until the next launch. */
+  session: boolean;
+}
+
+/**
+ * Keeps the frame a view sent, if it may: from the main window, while a
+ * session is up, and of the right shape and size. A closing window's last
+ * frame, sent after a reset, is dropped. Returns whether it was written.
+ */
+export function saveDesktopBootFrame(path: string, frame: unknown, sender: BootFrameSender): boolean {
+  if (!sender.mainWindow || !sender.session || !isBootFrame(frame)) return false;
+  mkdirSync(dirname(path), { recursive: true });
+  const temporary = `${path}.${process.pid}.tmp`;
+  writeFileSync(temporary, JSON.stringify(frame));
+  renameSync(temporary, path);
+  return true;
+}
+
+/**
+ * Forgets the frame, with the rest of the data on a reset. It sits beside
+ * the config, which a custom data folder is not, so removing the data folder
+ * alone could leave it behind.
+ */
+export function removeDesktopBootFrame(path: string): void {
+  rmSync(path, { force: true });
+}
+
+/**
+ * The main window's preload: the frame its page draws before its script
+ * loads, or null for the bare shell. Set either way, which is how the page
+ * tells the main window from a popped-out pane's.
+ */
+export function desktopBootFramePreload(frame: BootFrame | null): string {
+  const json = JSON.stringify(frame)
+    .replace(/</g, "\\u003c")
+    .replace(/\u2028/g, "\\u2028")
+    .replace(/\u2029/g, "\\u2029");
+  return `window.${DESKTOP_BOOT_FRAME_GLOBAL} = ${json};`;
+}

package/src/renderers/electrobun/bun/window/create.ts

@@ -51,17 +51,20 @@ interface AppWindowOptions {
   minSize: WindowMinimumSize;
   /** Runs after each move or resize has been applied to the cached frame. */
   onFrameChange?: () => void;
+  /** Script run in the page before its own. */
+  preload?: string;
 }
 
 /**
  * Opens a window on the app view with this platform's chrome and icon, keeps
  * its cached frame current as it moves, and holds it to `minSize` on resize.
  */
-export function createAppWindow({ title, frame, rpc, minSize, onFrameChange }: AppWindowOptions): BrowserWindow {
+export function createAppWindow({ title, frame, rpc, minSize, onFrameChange, preload }: AppWindowOptions): BrowserWindow {
   const window = new BrowserWindow({
     title,
     frame,
     url: "views://mainview/index.html",
+    ...(preload ? { preload } : {}),
     renderer: desktopWindowRenderer(),
     rpc,
     styleMask: desktopWindowStyleMask(),

package/src/renderers/electrobun/shared/app-name.ts

@@ -0,0 +1,17 @@
+/**
+ * The desktop app is Gloom. Builds up to 0.18.4 were named Gloomberb, and an
+ * install from then still is: `Gloomberb.app` on a Mac, a `Gloomberb` folder
+ * inside the Windows update archive, and an updater that asks the release for
+ * `<channel>-<os>-<arch>-Gloomberb.*` files. The release keeps publishing
+ * those under the old name (scripts/write-legacy-desktop-files.ts), and a Mac
+ * bundle still named Gloomberb.app renames itself (bun/desktop/app-name.ts).
+ */
+export const DESKTOP_APP_NAME = "Gloom";
+export const LEGACY_DESKTOP_APP_NAME = "Gloomberb";
+
+/**
+ * Kept through the rename. Electrobun names the app's data and update folders
+ * after it, and macOS ties the app's settings, WebKit storage and permissions
+ * to it.
+ */
+export const DESKTOP_APP_IDENTIFIER = "com.vincelwt.gloomberb";

package/src/renderers/electrobun/shared/boot-frame.ts

@@ -0,0 +1,7 @@
+/**
+ * Where the main window's page finds the launch frame (dom/boot-frame.ts):
+ * the Bun process sets it in the window's preload, before the page's own
+ * scripts run. A window it is not set in, one holding a popped-out pane,
+ * draws no frame.
+ */
+export const DESKTOP_BOOT_FRAME_GLOBAL = "__gloomDesktopBootFrame";

package/src/renderers/electrobun/shared/protocol.ts

@@ -10,6 +10,7 @@ import type { CapabilityManifest } from "../../../capabilities";
 import type { PluginOperationResult, PluginPin } from "../../../plugins/marketplace/store";
 import type { RemoteControlRequest, RemoteControlResponse } from "../../../remote/types";
 import type { HttpProxyRequestEnvelope, HttpProxyResponseEnvelope } from "../../../utils/http-proxy-response";
+import type { BootFrame } from "../../dom/boot-frame-page";
 
 export const ELECTROBUN_CONTEXT_MENU_ACTION = "gloom.context-menu.select";
 
@@ -27,6 +28,8 @@ export interface ElectrobunBackendInit {
   hostName?: string;
   windowKind: "main" | "detached";
   paneId?: string;
+  /** What the launch's plugin seed could not install, for the main window to say once. */
+  pluginSeedNotice?: { body: string; type: "error" | "info" };
   /** What the view needs to send crash reports and usage counts the same way the Bun process would. */
   telemetry: ElectrobunTelemetryInit;
 }
@@ -203,7 +206,7 @@ interface DesktopBackendRequestMap {
   "host.exit": { request: null; response: null };
   "host.windowControl": { request: { action: DesktopWindowControlAction }; response: null };
   "host.windowFullscreen": { request: null; response: boolean };
-  "host.openExternal": { request: { url: string }; response: null };
+  "host.openExternal": { request: { url: string }; response: boolean };
   "host.copyText": { request: { text: string }; response: null };
   "host.focusWindow": { request: null; response: null };
   "host.copyPngImage": { request: { pngBase64: string }; response: null };
@@ -217,6 +220,8 @@ interface DesktopBackendRequestMap {
     response: null;
   };
   "host.showContextMenu": { request: { menu: DesktopContextMenuItem[] }; response: boolean };
+  /** The layout the main window draws at the next launch before its script loads (dom/boot-frame.ts). Only the main window's is kept. */
+  "host.saveBootFrame": { request: { frame: BootFrame }; response: null };
   /** The unread count for the Dock icon badge: `""` (none), `"1"` to `"99"` or `"99+"`. Only the main window's is applied. */
   "host.setAppBadge": { request: { label: string }; response: null };
   /** `channel` absent (an older view) means stable. */

package/src/renderers/electrobun/view/cli-pane-shot-entry.tsx

@@ -185,7 +185,7 @@ async function restoreShotCloudSession(): Promise<void> {
 
 /**
  * Runs an asset-data request in the Bun process so the page sees exactly what
- * `gloomberb fn` sees. The page can only reach the cloud API on its own, and
+ * `gloom fn` sees. The page can only reach the cloud API on its own, and
  * the cloud is one source among several: analyst rating price targets and part
  * of the corporate action history come from providers the router merges in.
  */

package/src/renderers/electrobun/view/cli-pane-shot-frame.tsx

@@ -125,8 +125,8 @@ function useShotStatusLine(enabled: boolean, hasAsOf: () => boolean): ShotStatus
 }
 
 /**
- * Static captures retain warnings and optional source status without action
- * shortcuts. With `statusLine` the footer also carries the capture's dated
+ * Static captures retain warnings, what a filter leaves out (`capture`) and
+ * optional source status without action shortcuts. With `statusLine` the footer also carries the capture's dated
  * status line (`Fri 9 Oct close · 15 min delayed · markets closed until Mon`),
  * inside the requested size: the body gives up the footer row for it. The
  * pane's own text that says the same goes, so the date is said once: its `as
@@ -149,7 +149,7 @@ export function PaneShotFrame({ paneId, title, width, height, preserveStatus = f
   const datesData = statusLine && dates === "data";
   return <PaneFooterProvider>{(registeredFooter) => {
     const status: PaneFooterSegment[] = statusLine ? [{ id: "shot-status", parts: [{ text: statusText, tone: "label" }] }] : [];
-    const info = registeredFooter.info.filter((segment) => (preserveStatus || segment.icon === "warning")
+    const info = registeredFooter.info.filter((segment) => (preserveStatus || segment.icon === "warning" || segment.capture)
       && !(datesPaneData(segment) && (datesData || crowded))
       && !(segment.quoteStatus && statusLine && dates !== null));
     shownAsOf.current = info.some(datesPaneData);

package/src/renderers/electrobun/view/config-host.ts

@@ -1,4 +1,5 @@
 import { setConfigStoreHost, type ConfigStoreHost } from "../../../data/config/store";
+import { stopBootFrameRecorders } from "../../dom/boot-frame";
 import type { AppConfig } from "../../../types/config";
 import { backendRequest, getElectrobunBackendInitSnapshot } from "./backend-rpc";
 
@@ -20,6 +21,8 @@ const electrobunConfigStoreHost: ConfigStoreHost = {
     return config;
   },
   async resetAllData(dataDir: string) {
+    // Before the reset, or the frame saved as the window closes would bring the old layout back.
+    stopBootFrameRecorders();
     await backendRequest("config.resetAllData", { dataDir });
   },
   async exportConfig(config: AppConfig, destPath: string) {

package/src/renderers/electrobun/view/desktop/window/snapshot.ts

@@ -32,6 +32,7 @@ export function detachedSnapshotKey(snapshot: DesktopSharedStateSnapshot, paneId
     portfolios: snapshot.config.portfolios,
     watchlists: snapshot.config.watchlists,
     brokerInstances: snapshot.config.brokerInstances,
+    brokerSyncErrors: snapshot.brokerSyncErrors ?? {},
     pluginConfig: snapshot.config.pluginConfig,
     disabledPlugins: snapshot.config.disabledPlugins,
     chartPreferences: snapshot.config.chartPreferences,

package/src/renderers/electrobun/view/fatal-screen.tsx

@@ -21,7 +21,7 @@ function formatFatalError(error: unknown, details?: string): string {
 }
 
 export function DesktopFatalScreen({
-  title = "Gloomberb crashed",
+  title = "Gloom crashed",
   error,
   details,
   source,

package/src/renderers/electrobun/view/main.tsx

@@ -26,6 +26,7 @@ import { installElectrobunUpdateHost } from "./update-host";
 import { installScreenshotWatermark } from "./screenshot-watermark";
 import { installElectrobunWindowFullscreenTracking } from "./window-fullscreen";
 import { installDomMarketDataFrames } from "../../dom/data-frames";
+import { releaseBootFrameWhenDrawn, startBootFrameRecorder } from "../../dom/boot-frame";
 import { DomErrorBoundary, DomHostProviders } from "../../dom/dom-host-providers";
 import { DesktopFatalScreen } from "./fatal-screen";
 import { resolveRendererWindowError } from "./renderer-window-error";
@@ -45,6 +46,7 @@ import { getMarketplaceHost, setPluginManager, type PluginManager } from "../../
 import { remoteNotesFilesIO, setNotesFilesIO } from "../../../plugins/builtin/notes/files";
 import { NOTES_FILES_CAPABILITY_ID } from "../../../capabilities";
 import { loadOfficialPluginIds } from "../../../plugins/marketplace/feed";
+import { setPluginSeedNotice } from "../../../plugins/seed-notice";
 import { crashReportsEnabled, installCrashReporter, reportCrash } from "../../../telemetry/crash-reports";
 import { browserDoNotTrack, installWindowCrashListeners } from "../../../telemetry/crash-reports-dom";
 import { currentTelemetryConfig } from "../../../telemetry/live-config";
@@ -72,9 +74,14 @@ const bootLog = debugLog.createLogger("electrobun-web-boot");
 let appMounted = false;
 
 appRootElement.tabIndex = -1;
-root.render(<div className="gloom-loading">Starting Gloomberb...</div>);
+// The page drew the layout this window last drew, or the bare shell, before
+// this script loaded (dom/boot-frame.ts); it stays until the app has drawn its own.
+const releaseBootFrame = releaseBootFrameWhenDrawn(document, appRootElement);
+/** How long after the app mounts the launch frame stays at most. */
+const BOOT_FRAME_RELEASE_FALLBACK_MS = 4_000;
 
-function renderFatalError(error: unknown, details?: string, title = "Gloomberb failed to start"): void {
+function renderFatalError(error: unknown, details?: string, title = "Gloom failed to start"): void {
+  releaseBootFrame();
   root.render(
     <DesktopFatalScreen
       title={title}
@@ -94,7 +101,7 @@ window.__gloomRenderFatalError = (error, details, source) => {
   }) === "ignore") {
     return;
   }
-  renderFatalError(error, details, "Gloomberb crashed");
+  renderFatalError(error, details, "Gloom crashed");
 };
 
 function focusWebSurface(): void {
@@ -113,9 +120,13 @@ function requestStartupFocus(): void {
 
 async function boot() {
   bootLog.info("boot started");
+  // Both asked for at once: the Bun process compiles the plugins while it
+  // answers `init`, rather than after this view asks a second time.
   const backendInitPromise = initElectrobunBackend();
+  const externalBundlesPromise = backendRequest("plugins.listExternal");
   // Avoid a premature global unhandled-rejection render while UI chunks load.
   void backendInitPromise.catch(() => {});
+  void externalBundlesPromise.catch(() => {});
 
   installElectrobunConfigStoreHost();
   installElectrobunBrokerRemoteClient();
@@ -156,6 +167,8 @@ async function boot() {
     : init.desktopSnapshot;
   const config = desktopSnapshot?.config ?? init.config;
   applyLanguageFromConfig(config);
+  // Said by the app once it is up, as the terminal says it.
+  setPluginSeedNotice(init.pluginSeedNotice ?? null);
   const desktopWindowBridge = createDesktopWindowBridge(init.windowKind, init.paneId);
   const desktopApplicationMenuBridge: DesktopApplicationMenuBridge = {
     subscribe: (listener) => onBackendMessage("application-menu.select", ({ command }) => listener(command)),
@@ -172,7 +185,11 @@ async function boot() {
     "startup.electrobun.load-external-plugins",
     async () => {
       try {
-        return await loadDesktopExternalPlugins(await backendRequest("plugins.listExternal"));
+        // Asked once more if the early request failed: it waits for the
+        // whole launch, which a first run's plugin downloads can stretch past
+        // the request's time limit.
+        const bundles = await externalBundlesPromise.catch(() => backendRequest("plugins.listExternal"));
+        return await loadDesktopExternalPlugins(bundles);
       } catch (error) {
         debugLog.createLogger("desktop-plugins").error(`External plugin load failed: ${error}`);
         return [];
@@ -245,6 +262,15 @@ async function boot() {
     );
     appMounted = true;
   });
+  // A layout with neither panes nor a status bar has nothing to wait for.
+  window.setTimeout(releaseBootFrame, BOOT_FRAME_RELEASE_FALLBACK_MS);
+  if (init.windowKind === "main") {
+    startBootFrameRecorder({
+      doc: document,
+      root: appRootElement,
+      save: (frame) => { void backendRequest("host.saveBootFrame", { frame }).catch(() => {}); },
+    });
+  }
   requestStartupFocus();
   bootLog.info("root render scheduled", {
     layoutPanes: config.layout.instances.length,

package/src/renderers/electrobun/view/news-source.ts

@@ -1,6 +1,6 @@
 import { apiClient } from "../../../api-client";
 import { newsProvider, type NewsCapability } from "../../../capabilities";
-import { cloudNewsParams, mapCloudNewsArticle } from "../../../sources/gloomberb-cloud/news";
+import { cloudNewsReadArticles, mapCloudNewsArticle, readCloudNews } from "../../../sources/gloomberb-cloud/news";
 import type { NewsArticle, NewsPage, NewsQuery } from "../../../news/types";
 
 interface BackendNews {
@@ -10,7 +10,7 @@ interface BackendNews {
   getNewsPage(query: NewsQuery): Promise<NewsPage>;
 }
 
-type CloudNewsClient = Pick<typeof apiClient, "getCloudNews" | "getCloudNewsStory">;
+type CloudNewsClient = Pick<typeof apiClient, "getCloudNews" | "getCloudNewsStory" | "searchCloudNews">;
 
 /**
  * The view's only news source: the desktop view runs without capability
@@ -28,10 +28,10 @@ export function createDesktopNewsSource(backend: BackendNews, client: CloudNewsC
       fetchNews: (query) => backend.getNews(query),
       fetchNewsPage: async (query) => {
         try {
-          const response = await client.getCloudNews(cloudNewsParams(query));
+          const read = await readCloudNews(client, query);
           return {
-            articles: response.items.map((item) => mapCloudNewsArticle(item, query.ticker)),
-            nextCursor: response.nextCursor ?? null,
+            articles: cloudNewsReadArticles(read, query.ticker),
+            nextCursor: read.nextCursor ?? null,
           };
         } catch {
           // The aggregate page keeps RSS failures beside any usable stories.

package/src/renderers/electrobun/view/remote/asset-data-client.ts

@@ -121,7 +121,7 @@ export function createRemoteAssetDataClient(): RemoteAssetDataClient {
 
   const base: RemoteAssetDataClientBase = {
     id: "desktop-backend",
-    name: "Gloomberb Backend",
+    name: "Gloom Backend",
     getCachedFinancialsForTargets: (targets, options) => (
       hasRendererOperation(assetDataOperations, "getCachedFinancialsForTargets")
         ? invoke<Map<string, TickerFinancials>>(ASSET_DATA_CAPABILITY_ID, "getCachedFinancialsForTargets", { targets, options })

package/src/renderers/electrobun/view/ui-host.tsx

@@ -33,7 +33,7 @@ export const webRendererHost: RendererHost = {
     await backendRequest("host.windowControl", { action });
   },
   async openExternal(url) {
-    await backendRequest("host.openExternal", { url });
+    return await backendRequest("host.openExternal", { url });
   },
   async copyText(text) {
     try {