gloomberb 0.18.2 → 0.18.3

package/src/components/chart/composite/drawing-store.ts

@@ -1,4 +1,4 @@
-import { useEffect, useRef } from "react";
+import { useCallback, useEffect, useRef } from "react";
 import { usePaneSettingValue } from "../../../state/app/context";
 import { CHART_DRAWINGS_SETTING_KEY, parseChartDrawings, type ChartDrawing } from "./tools";
 
@@ -40,6 +40,12 @@ export function ChartDrawingStore({
   if (restoredRef.current === null) {
     restoredRef.current = parseChartDrawings(stored);
   }
+  // What the settings hold, so removing the last drawing is told even when the
+  // pane opened with none: it is not "nothing to say" but "the stored one is gone".
+  const writtenRef = useRef<readonly ChartDrawing[]>(restoredRef.current);
+  const pendingRef = useRef<readonly ChartDrawing[] | null>(null);
+  const setStoredRef = useRef(setStored);
+  setStoredRef.current = setStored;
 
   useEffect(() => {
     const restored = restoredRef.current;
@@ -47,13 +53,27 @@ export function ChartDrawingStore({
     // Restoring once on mount: later writes must not scroll back in time.
   }, []);
 
+  const write = useCallback((next: readonly ChartDrawing[]) => {
+    pendingRef.current = null;
+    writtenRef.current = next;
+    setStoredRef.current(next);
+  }, []);
+
   useEffect(() => {
-    const restored = restoredRef.current ?? NO_DRAWINGS;
-    if (drawings === restored) return;
-    if (drawings.length === 0 && restored.length === 0) return;
-    const timer = setTimeout(() => setStored(drawings), DRAWING_PERSIST_DELAY_MS);
+    // Untouched, or still waiting for the restore above: nothing of the user's to write.
+    if (drawings === NO_DRAWINGS || drawings === writtenRef.current || (drawings.length === 0 && writtenRef.current.length === 0)) {
+      pendingRef.current = null;
+      return;
+    }
+    pendingRef.current = drawings;
+    const timer = setTimeout(() => write(drawings), DRAWING_PERSIST_DELAY_MS);
     return () => clearTimeout(timer);
-  }, [drawings, setStored]);
+  }, [drawings, write]);
+
+  // A change made just before the chart goes away (a tab switch) is still saved.
+  useEffect(() => () => {
+    if (pendingRef.current) write(pendingRef.current);
+  }, [write]);
 
   return null;
 }

package/src/components/chart/composite/interactions.ts

@@ -362,7 +362,8 @@ export function resolveCompositeChartInteraction(event: {
   if (shifted && key === "d") return "arm-line";
   if (shifted && key === "p") return "arm-pencil";
   if (shifted && key === "h") return "arm-level";
-  if (key === "backspace") return "delete-drawing";
+  // Delete is the same act on a keyboard that has the key, or on a Mac with fn.
+  if (key === "backspace" || key === "delete") return "delete-drawing";
   if (key === "c" && !event.shift) return "cycle-colour";
   if (event.shift) return null;
   if (key === "a") return "pan-left";

package/src/components/chart/composite/panel-surface.tsx

@@ -623,6 +623,17 @@ export function CompositePanelSurface({
       updateCursor(event);
       return;
     }
+    // With no tool in hand, a press on a drawing or a level picks it so Backspace
+    // or Delete can remove it; the press still pans, and one on bare plot lets go.
+    const ratios = pointerRatios(event);
+    if (ratios) {
+      const drawingHit = drawings.length > 0 ? hitTestDrawings(drawings, scene, panel, ratios, plotAspect) : null;
+      const levelHit = !drawingHit && levels?.onEdit && levelDomain
+        ? hitTestLevel(projectedLevels, ratios.yRatio, levelGrabRatio(panel.height))
+        : null;
+      onSelectDrawing(drawingHit ? drawingHit.drawing.id : null);
+      onSelectLevel(levelHit?.editable ? levelHit.id : null);
+    }
     if (!updateCursor(event)) return;
     dragRef.current = startPanGesture(
       frame,

package/src/components/chart/composite/types.ts

@@ -315,6 +315,12 @@ export interface CompositeChartProps {
     interaction: "pan" | "reset" | "zoom",
   ) => void;
   onActivate?: () => void;
+  /**
+   * A press on the chart itself (plot, legend or tool bar), not a wheel turn.
+   * The chart consumes the press, so an owner that shares the pane with a
+   * field that takes typed keys hears it here to hand the keyboard back.
+   */
+  onPress?: () => void;
   onToggleSeries?: (seriesId: string) => void;
   isSeriesToggleable?: (series: ResolvedSeries) => boolean;
   /**

package/src/components/chart/composite/use-composite-chart-keyboard.ts

@@ -424,7 +424,7 @@ export function useCompositeChartKeyboard({
       stepLevel(event.name === "[" ? -1 : 1);
       return;
     }
-    if (toolsActive && selectedLevel?.editable && levelsEditable && isPlainKey(event, "backspace")) {
+    if (toolsActive && selectedLevel?.editable && levelsEditable && isPlainKey(event, "backspace", "delete")) {
       consume();
       removeSelectedLevel();
       return;

package/src/components/command-bar/routes/root/command-items.ts

@@ -3,11 +3,26 @@ import type { TickerRecord } from "../../../../types/ticker";
 import { isManualPortfolio } from "../../../../portfolio/mutations";
 import type { Command } from "../../commands/registry";
 import type { ResultItem } from "../../list/model";
-import { canRestartToApply } from "../../../../updater";
+import { canRestartToApply, type UpdateProgress } from "../../../../updater";
 import { NIGHTLY_CHANNEL_SUMMARY, resolveUpdateChannel } from "../../../../updater/channel";
+import { updateFailureReason } from "../../../../updater/failure";
+import { t, tf } from "../../../../i18n";
 import { isPrereleaseVersion } from "../../../../utils/semver";
 import { VERSION } from "../../../../version";
 
+/** "Update failed: download interrupted", as the header says it. */
+function failedUpdateLabel(progress: UpdateProgress): string {
+  const reason = progress.failure ? t(updateFailureReason(progress.failure)) : (progress.error ?? "").replace(/\s+/g, " ").trim();
+  return tf("Update failed: {error}", { error: reason });
+}
+
+/** The whole error under the failed update's row, unless the label already says all of it. */
+function failedUpdateLines(progress: UpdateProgress): ResultItem["lines"] {
+  const error = (progress.error ?? "").replace(/\s+/g, " ").trim();
+  if (!progress.failure || !error) return undefined;
+  return [{ segments: [{ text: error, emphasis: "muted" }] }];
+}
+
 interface RootCommandItemBuilderOptions {
   activeCollectionId: string | null;
   activeTickerData: TickerRecord | null | undefined;
@@ -88,9 +103,12 @@ export function createRootCommandItemBuilder({
         return activeTickerSymbol ? `Remove ${activeTickerSymbol} from Portfolio` : command.label;
       case "set-portfolio-position":
         return activeTickerSymbol ? `Set Position for ${activeTickerSymbol}` : command.label;
-      // The row only shows its label, so a downloaded update is announced there.
+      // The row only shows its label, so a downloaded update is announced there,
+      // and a failed one with its reason; Enter restarts into the one and retries the other.
       case "check-for-updates":
-        return state.updateProgress?.phase === "ready" ? "Update ready, restart to apply" : command.label;
+        if (state.updateProgress?.phase === "ready") return "Update ready, restart to apply";
+        if (state.updateProgress?.phase === "error") return failedUpdateLabel(state.updateProgress);
+        return command.label;
       default:
         return command.label;
     }
@@ -140,7 +158,7 @@ export function createRootCommandItemBuilder({
           return state.updateProgress.message ?? "Update ready, restart to apply";
         }
         if (state.updateProgress?.phase === "error") {
-          return `Update failed: ${state.updateProgress.error}`;
+          return `${failedUpdateLabel(state.updateProgress)}. ${state.updateProgress.error ?? ""}`.trim();
         }
         if (state.updateCheckInProgress) return "Checking releases now";
         if (state.updateAvailable) {
@@ -198,8 +216,11 @@ export function createRootCommandItemBuilder({
       // "update" is a whole word here so it lands on this command before Set
       // Portfolio Position (whose keywords say "update position") and Release
       // Channel, which keeps the word further back.
+      // Ready and failed rename the row; its own name still finds it.
       case "check-for-updates":
-        return state.updateProgress?.phase === "ready" ? "update check for updates restart relaunch" : "update";
+        if (state.updateProgress?.phase === "ready") return "update check for updates restart relaunch";
+        if (state.updateProgress?.phase === "error") return "update check for updates retry";
+        return "update";
       case "release-channel":
         return "nightly stable beta prerelease update updates channel";
       default:
@@ -218,9 +239,14 @@ export function createRootCommandItemBuilder({
       right: smartRight(command, arg),
       shortcutQuery: command.prefix || undefined,
       searchText: smartSearchText(command),
+      ...(command.id === "check-for-updates" && state.updateProgress?.phase === "error"
+        ? { lines: failedUpdateLines(state.updateProgress) }
+        : {}),
+      // Busy while it checks, downloads or installs; a failed update is retried from here.
       disabled:
         command.id === "check-for-updates" &&
-        (state.updateCheckInProgress || (!!state.updateProgress && !canRestartToApply(state.updateProgress))),
+        (state.updateCheckInProgress
+          || (!!state.updateProgress && !canRestartToApply(state.updateProgress) && state.updateProgress.phase !== "error")),
       action: () => runDirectCommand(command, arg),
     };
   };

package/src/components/data-table/view.tsx

@@ -11,7 +11,7 @@ import {
 import type { ScrollBoxRenderable } from "../../ui";
 import { useBeforeShortcut, useShortcut } from "../../react/input";
 import { isPlainKey, isPlainKeyboardEvent } from "../../utils/keyboard";
-import { DataTable, type DataTableColumn, type DataTableProps } from "../ui";
+import { DataTable, PaneStatusBody, type DataTableColumn, type DataTableProps, type PaneStatusBodyProps } from "../ui";
 import { useDataTableSortMenu } from "./sort-menu";
 import {
   TableViewFrame,
@@ -89,6 +89,19 @@ export type DataTableSelection<T> =
       ) => void;
     };
 
+/**
+ * What the table's body shows instead of rows while it has none to show: its
+ * first page loading after a tab or filter change, a failed load, a state
+ * with nothing to list. The same states `PaneStatusBody` draws, in the
+ * table's place under `rootBefore`, so the query bar and figures above stay
+ * on screen (and a search field keeps its focus) while the body waits.
+ */
+export type DataTableBodyStatus = Omit<PaneStatusBodyProps, "children" | "width" | "height" | "align">;
+
+function bodyStatusShown(status: DataTableBodyStatus | undefined): status is DataTableBodyStatus {
+  return !!status && (!!status.error || status.loading === true || status.empty === true);
+}
+
 interface SelectionCommitTarget {
   index: number;
   id?: string;
@@ -124,6 +137,12 @@ export interface DataTableViewProps<
   isNavigable?: (item: T, index: number) => boolean;
   rootBefore?: ReactNode;
   rootAfter?: ReactNode;
+  /**
+   * Replaces the table (header and rows) with a loading, error or empty
+   * state while `rootBefore` stays. Precedence is the caller's, as with
+   * `PaneStatusBody`: pass `loading` only while there is nothing to show.
+   */
+  status?: DataTableBodyStatus;
   rootWidth?: number;
   rootHeight?: number;
   rootBackgroundColor?: string;
@@ -165,6 +184,7 @@ export function DataTableView<
   isNavigable,
   rootBefore,
   rootAfter,
+  status,
   rootWidth,
   rootHeight,
   rootBackgroundColor,
@@ -728,7 +748,7 @@ export function DataTableView<
       before={rootBefore}
       after={rootAfter}
     >
-      <DataTable<T, C>
+      {bodyStatusShown(status) ? <PaneStatusBody {...status} /> : <DataTable<T, C>
         {...tableProps}
         headerScrollRef={effectiveHeaderScrollRef}
         scrollRef={effectiveScrollRef}
@@ -741,7 +761,7 @@ export function DataTableView<
         onActivate={handleTableActivate}
         onRowMouseDown={handleRowMouseDown}
         onRowContextMenu={handleRowContextMenu}
-      />
+      />}
     </TableViewFrame>
   );
 }

package/src/components/index.ts

@@ -67,6 +67,7 @@ export { usePagedRows } from "./paged-rows";
 export type { PageLoader, PageRequest, PagedRows, PagedRowsOptions, RowPage } from "./paged-rows";
 export { DataTableView } from "./data-table/view";
 export type {
+  DataTableBodyStatus,
   DataTableKeyEvent,
   DataTableRootKeyContext,
   DataTableSelectionChangeReason,

package/src/components/layout/detached-pane-shell.tsx

@@ -441,6 +441,7 @@ export function DetachedPaneShell({ pluginRegistry, desktopWindowBridge }: Detac
                 onMouseDown: () => toggleQuickSetting(setting.key),
               }))}
               tabs={headerTabs}
+              bodyBackground={background}
               titleBar={{
                 rows: headerHeightRows,
                 overlay: titleBarOverlay === true,

package/src/components/layout/floating-pane.tsx

@@ -143,6 +143,7 @@ export function FloatingPaneWrapper({
         showActions={showActions}
         quickSettings={quickSettings}
         tabs={headerTabs}
+        bodyBackground={bg}
         topRule
         onHeaderMouseMove={onHeaderMouseMove}
         onHeaderMouseDown={onHeaderMouseDown}