gloomberb 0.16.3 → 0.16.4

package/src/plugins/builtin/cloud/terminal-relay/acm-tab.tsx

@@ -0,0 +1,89 @@
+import { useMemo, useState, useSyncExternalStore } from "react";
+import { EmptyState, usePaneFooter, type PaneHint } from "../../../../components";
+import { ListView, type ListViewItem } from "../../../../components/ui/list-view";
+import { t, tf } from "../../../../i18n";
+import { useAppLanguage } from "../../../../i18n/react";
+import { useShortcut } from "../../../../react/input";
+import { Box } from "../../../../ui";
+import { formatTimeAgo } from "../../../../utils/datetime-format";
+import { isPlainKey } from "../../../../utils/keyboard";
+import { type AssistantGrant, terminalRelayGrants } from "./grants";
+import { recordRelayActivity } from "./indicator";
+
+const EMPTY: AssistantGrant[] = [];
+
+function decisionText(grant: AssistantGrant): string {
+  if (grant.decision === "deny") return t("Denied");
+  return grant.decision === "always" ? t("Always allowed") : t("Allowed this session");
+}
+
+/**
+ * The Agents tab of the account pane: the remote assistants that asked to
+ * control this terminal, and what was decided. `r` revokes the selected one,
+ * so its next call asks again; revoking a key or disconnecting a client in
+ * Cloud settings does the same from the web.
+ */
+export function AgentsAccountTab({ focused, width }: { focused: boolean; width: number }) {
+  const language = useAppLanguage();
+  const grants = useSyncExternalStore(
+    (listener) => terminalRelayGrants.subscribe(listener),
+    () => terminalRelayGrants.list(),
+    () => EMPTY,
+  );
+  const [selectedIndex, setSelectedIndex] = useState(0);
+  const items = useMemo<ListViewItem[]>(() => grants.map((grant) => ({
+    id: grant.clientId,
+    label: grant.name,
+    description: grant.lastUsedAt
+      ? tf("{decision} · last acted {ago}", { decision: decisionText(grant), ago: formatTimeAgo(new Date(grant.lastUsedAt)) })
+      : decisionText(grant),
+    right: grant.decision === "deny" ? t("denied") : grant.decision === "always" ? t("always") : t("session"),
+  })), [grants, language]);
+  const index = Math.min(selectedIndex, Math.max(0, items.length - 1));
+  const selected = grants[index];
+
+  const revoke = (grant: AssistantGrant | undefined) => {
+    if (!grant) return;
+    terminalRelayGrants.forget(grant.clientId);
+    recordRelayActivity({ type: "revoked", clientId: grant.clientId });
+  };
+
+  useShortcut((event) => {
+    if (!focused || event.targetEditable || items.length === 0) return;
+    if (isPlainKey(event, "down", "j")) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      setSelectedIndex(Math.min(items.length - 1, index + 1));
+    } else if (isPlainKey(event, "up", "k")) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      setSelectedIndex(Math.max(0, index - 1));
+    }
+  });
+
+  const hints = useMemo<PaneHint[]>(() => selected
+    ? [{ id: "revoke", key: "r", label: "evoke", title: t("Revoke"), onPress: () => revoke(selected) }]
+    : [], [selected, language]);
+  usePaneFooter("account-management:agents", () => ({ info: [], hints }), [hints]);
+
+  if (items.length === 0) {
+    return (
+      <EmptyState
+        title={t("No assistant has asked to control this terminal.")}
+        hint={t("Connect one to the Gloom Cloud MCP with Terminal control.")}
+      />
+    );
+  }
+
+  return (
+    <Box flexDirection="column" width={width}>
+      <ListView
+        items={items}
+        selectedIndex={index}
+        onSelect={setSelectedIndex}
+        showSelectedDescription
+        surface="plain"
+      />
+    </Box>
+  );
+}

package/src/plugins/builtin/cloud/terminal-relay/client.ts

@@ -0,0 +1,97 @@
+import { TERMINAL_RELAY_FEATURE } from "../../../../api-client/socket";
+import type { TerminalRelayEngine } from "./engine";
+import { TERMINAL_RELAY_PROTOCOL, terminalRelayToolDescriptors } from "./manifest";
+
+/** What the relay needs from the Cloud socket (apiClient in the app, a fake in tests). */
+export interface TerminalRelaySocket {
+  subscribeConnection(listener: (event: "ready" | "closed") => void): () => void;
+  subscribeCloudEvent(type: string, listener: (data: unknown) => void): () => void;
+  sendFrame(frame: Record<string, unknown>): boolean;
+  serverOffers(feature: string): boolean;
+}
+
+export interface TerminalDeviceIdentity {
+  id: string;
+  kind: "desktop" | "tui";
+  name: string;
+  appVersion: string;
+}
+
+const ACTIVITY_INTERVAL_MS = 30_000;
+const RELAY_FRAMES = ["terminal.call", "terminal.cancel", "terminal.revoke"] as const;
+
+/**
+ * Announces this app on the Cloud socket after each server hello and hands
+ * relayed frames to the engine. An older server never offers the relay, so
+ * the app never announces itself there.
+ */
+export class TerminalRelayClient {
+  private announced = false;
+  private lastActivityAt = 0;
+
+  constructor(
+    private readonly socket: TerminalRelaySocket,
+    private readonly engine: TerminalRelayEngine,
+    private readonly device: () => TerminalDeviceIdentity | null,
+    private readonly now: () => number = Date.now,
+  ) {}
+
+  start(): () => void {
+    const unsubscribers = [
+      this.socket.subscribeConnection((event) => {
+        if (event === "ready") this.announce();
+        else this.lost();
+      }),
+      ...RELAY_FRAMES.map((type) => this.socket.subscribeCloudEvent(type, (data) => {
+        if (this.announced) this.engine.receive(type, data);
+      })),
+    ];
+    // The socket may already be up when the relay starts.
+    this.announce();
+    return () => {
+      if (this.announced) this.socket.sendFrame({ type: "terminal.bye" });
+      this.lost();
+      for (const unsubscribe of unsubscribers) unsubscribe();
+    };
+  }
+
+  /**
+   * The session changed: announce once signed in, say goodbye once signed
+   * out, without waiting for the socket to reconnect.
+   */
+  refresh(): void {
+    if (this.announced && !this.device()) {
+      this.socket.sendFrame({ type: "terminal.bye" });
+      this.lost();
+    } else if (!this.announced) {
+      this.announce();
+    }
+  }
+
+  /** The person used the app; Gloom Cloud picks the most recently used terminal by default. */
+  activity(): void {
+    if (!this.announced || this.now() - this.lastActivityAt < ACTIVITY_INTERVAL_MS) return;
+    if (this.socket.sendFrame({ type: "terminal.active" })) this.lastActivityAt = this.now();
+  }
+
+  private announce(): void {
+    if (!this.socket.serverOffers(TERMINAL_RELAY_FEATURE)) return;
+    const device = this.device();
+    if (!device) return;
+    this.engine.connected();
+    this.announced = this.socket.sendFrame({
+      type: "terminal.hello",
+      device: {
+        ...device,
+        protocol: TERMINAL_RELAY_PROTOCOL,
+        tools: terminalRelayToolDescriptors(),
+      },
+    });
+    this.lastActivityAt = this.now();
+  }
+
+  private lost(): void {
+    this.announced = false;
+    this.engine.disconnected();
+  }
+}

package/src/plugins/builtin/cloud/terminal-relay/connect-section.tsx

@@ -0,0 +1,57 @@
+import { useCallback, useSyncExternalStore } from "react";
+import { Button } from "../../../../components/ui/button";
+import { t, tf } from "../../../../i18n";
+import { useAppLanguage } from "../../../../i18n/react";
+import { useThemeColors } from "../../../../theme/theme-context";
+import { Box, Text } from "../../../../ui";
+import { useDialogKeyboard } from "../../../../ui/dialog";
+import { isPlainKey } from "../../../../utils/keyboard";
+import { getSharedRegistry } from "../../../registry";
+import { requestAccountManagementTab } from "../../account-management/navigation";
+import type { McpConnectSectionProps } from "../mcp-connect/sections";
+import { type AssistantGrant, terminalRelayGrants } from "./grants";
+
+const NONE: AssistantGrant[] = [];
+
+function allowedText(count: number): string {
+  if (count === 0) return t("None allowed yet");
+  return count === 1 ? t("1 assistant allowed") : tf("{count} assistants allowed", { count });
+}
+
+/**
+ * The Terminal control line of the Connect an AI assistant dialog: what it
+ * does, how many assistants may drive this terminal now, and the way to the
+ * Agents tab where they are revoked. `m` or a click opens it.
+ */
+export function TerminalControlSection({ width, dialogId, dismiss }: McpConnectSectionProps) {
+  useAppLanguage();
+  const colors = useThemeColors();
+  const grants = useSyncExternalStore(
+    (listener) => terminalRelayGrants.subscribe(listener),
+    () => terminalRelayGrants.list(),
+    () => NONE,
+  );
+  const allowed = grants.filter((grant) => grant.decision !== "deny").length;
+  const openAgents = useCallback(() => {
+    requestAccountManagementTab("agents");
+    getSharedRegistry()?.showPane("account-management");
+    dismiss?.();
+  }, [dismiss]);
+
+  useDialogKeyboard((event) => {
+    if (!isPlainKey(event, "m")) return;
+    event.preventDefault?.();
+    event.stopPropagation?.();
+    openAgents();
+  }, { scope: dialogId });
+
+  return (
+    <Box flexDirection="column" width={width}>
+      <Text fg={colors.textDim} wrapText>{t("With Terminal control, an assistant can drive this terminal.")}</Text>
+      <Box flexDirection="row" gap={2} alignItems="center" flexWrap="wrap">
+        <Button label={t("Manage assistants")} shortcut="m" onPress={openAgents} />
+        <Text fg={colors.textDim}>{allowedText(allowed)}</Text>
+      </Box>
+    </Box>
+  );
+}