gloomberb 0.15.2 → 0.15.4

package/src/plugins/builtin/estimate-revisions/pane.tsx

@@ -1,41 +1,42 @@
 import { useCallback, useEffect, useMemo, useRef } from "react";
-import { Box, ScrollBox, useUiCapabilities, type ScrollBoxRenderable } from "../../../ui";
+import { Box, ScrollBox, type ScrollBoxRenderable } from "../../../ui";
 import {
   useAsyncResource,
   useAutoRefresh,
   usePaneSettingValue,
   usePluginPaneState,
-  useShortcut,
 } from "../../../public/react";
 import {
-  CompositeChart,
+  ChartTableHeader,
   DataTableStackView,
   DataTableView,
   EmptyState,
   KeyValueRow,
   PaneStatusBody,
   Prose,
-  StatGrid,
-  statGridRows,
-  Tabs,
-  usePaneHeaderTabs,
+  spanAxisFormatter,
+  useChartTableSelection,
   usePaneNoticeFooter,
   usePaneStatusLinkFooter,
+  usePaneTabs,
   type DataTableColumn,
   type DataTableKeyEvent,
   type StatItem,
 } from "../../../components";
-import { ApiRequestError } from "../../../api-client/errors";
+import { isAccessDenied } from "../../../api-client/errors";
 import { listingIdentity } from "../shared/ticker-request";
 import type {
+  EstimateObservation,
   EstimatePeriod,
   EstimateSurprise,
 } from "../../../api-client/estimate-revisions";
 import { staticSeries } from "../../../components/chart/static/series";
 import { useThemeColors } from "../../../theme/theme-context";
 import type { PaneProps } from "../../../types/plugin";
+import { formatPercentileRank } from "../../../utils/format";
 import { canonicalExchange } from "../../../utils/exchanges";
 import { isPlainKey } from "../../../utils/keyboard";
+import { usePaneRefreshKey } from "../../../components/data-table/table-pane";
 import { SignInWall } from "../cloud/auth-actions";
 import {
   isCloudSessionRequired,
@@ -65,15 +66,13 @@ import {
 import { usePaneTickerIdentity } from "../../../state/hooks/pane-ticker";
 
 const clearDeniedEstimates = (error: unknown) =>
-  (error instanceof ApiRequestError && [401, 403].includes(error.status ?? 0))
-  || (error instanceof Error && isCloudSessionRequired(error.message));
+  isAccessDenied(error) || (error instanceof Error && isCloudSessionRequired(error.message));
 
 const TABS = [
   { value: "revisions", label: "Revisions" },
   { value: "surprises", label: "Surprises" },
   { value: "guidance", label: "Guidance" },
 ];
-const PANELS = [{ id: "main" }];
 const GUIDANCE_COLUMNS: DataTableColumn[] = [
   ...PERIOD_COLUMNS.filter((column) =>
     ["period", "currency", "eps", "percentile", "asOf"].includes(column.id),
@@ -97,6 +96,17 @@ const SURPRISE: DataTableColumn[] = [
   { id: "percent", label: "SURPRISE %", width: 12, align: "right" },
   { id: "percentile", label: "PCTL 1Y", width: 9, align: "right" },
 ];
+const historyId = (row: EstimateObservation) => `${row.source}:${row.date}`;
+const historyDate = (row: EstimateObservation) => new Date(`${row.date}T00:00:00Z`);
+const historySource = (row: EstimateObservation) => row.source === "yahoo" ? "Recorded" : "Reported lookback";
+/** EPS ticks with the decimals the plotted range needs. */
+const formatEpsAxis = spanAxisFormatter((value, digits) => value.toFixed(digits));
+
+/**
+ * One fiscal period: its consensus figures, the EPS history as recorded and
+ * as reported in lookbacks, then every observation. The selected observation
+ * is the chart's cursor.
+ */
 function EstimateDetail({
   period,
   width,
@@ -122,6 +132,8 @@ function EstimateDetail({
     "estimate-history:row",
     null,
   );
+  const selectedId = rows.some((row) => historyId(row) === selected) ? selected : rows[0] ? historyId(rows[0]) : null;
+  // The legend names each line as the SOURCE column does.
   const series = useMemo(
     () => [
       staticSeries(estimatePoints(period.recorded), {
@@ -132,14 +144,16 @@ function EstimateDetail({
       }),
       staticSeries(estimatePoints(period.lookbacks), {
         id: "lookbacks",
-        label: "Reported lookbacks",
+        label: "Reported lookback",
         color: colors.warning,
         calendarSpaced: true,
       }),
     ],
     [period, colors],
   );
-  const { nativePaneChrome } = useUiCapabilities();
+  const link = useChartTableSelection({
+    rows, getId: historyId, getDate: historyDate, selectedId, onSelect: setSelected, focused,
+  });
   const breadth = period.breadth.find((row) => row.days === 30);
   const asOf = current?.date;
   // The latest observation date is said once, on the consensus; the other
@@ -151,7 +165,7 @@ function EstimateDetail({
       id: "eps",
       label: "EPS",
       value: `${number(current?.average)}${period.currency ? ` ${period.currency}` : ""}`,
-      detail: [pctl == null ? null : `${pctl.toFixed(0)} pctl`, asOf].filter(Boolean).join(" · ") || undefined,
+      detail: [pctl == null ? null : formatPercentileRank(pctl), asOf].filter(Boolean).join(" · ") || undefined,
     },
     {
       id: "change",
@@ -182,71 +196,44 @@ function EstimateDetail({
       detail: otherDate(period.revenue.asOf),
     }] : []),
   ];
-  const figureRows = statGridRows(figures, width);
-  const chartHeight = Math.max(4, Math.floor((height - figureRows - 2) * 0.6));
-  // The desktop table takes whatever the chart leaves, down to the footer; the
-  // terminal splits its rows by count.
+  const hasHistory = rows.some((row) => row.average != null);
   return (
-    <Box
-      width={width}
-      height={nativePaneChrome ? undefined : height}
-      flexGrow={nativePaneChrome ? 1 : undefined}
-      flexBasis={nativePaneChrome ? 0 : undefined}
-      minHeight={nativePaneChrome ? 0 : undefined}
-      flexDirection="column"
-    >
-      <StatGrid items={figures} width={width} />
-      {rows.some((row) => row.average != null) ? (
-        <CompositeChart
-          series={series}
-          panels={PANELS}
-          width={width}
-          height={chartHeight}
-          focused={focused}
-          showTimeAxis
-          showLegend
-          navigable={false}
-          formatAxisValue={number}
-          remoteKind="estimate-revision-history"
-        />
-      ) : (
-        <EmptyState title="No observed revision history." />
-      )}
-      <DataTableView
-        columns={HISTORY}
-        items={rows}
-        focused={focused}
-        rootWidth={width}
-        rootHeight={Math.max(3, height - figureRows - chartHeight - 1)}
-        selection={{
-          kind: "id",
-          selectedId: selected,
-          getId: (row) => `${row.source}:${row.date}`,
-          onChange: setSelected,
-        }}
-        getItemKey={(row) => `${row.source}:${row.date}`}
-        onActivate={(row) => setSelected(`${row.source}:${row.date}`)}
-        sortColumnId={historySort.column}
-        sortDirection={historySort.direction}
-        onHeaderClick={(column) =>
-          setHistorySort((old) => nextEstimateSort(old, column))
-        }
-        renderCell={(row, column) => ({
-          text:
-            column.id === "date"
-              ? row.date
-              : column.id === "source"
-                ? row.source === "yahoo"
-                  ? "Recorded"
-                  : "Reported lookback"
-                : number(
-                    row[column.id as "average" | "low" | "high" | "analysts"],
-                  ),
-          color: row.source === "yahoo" ? colors.text : colors.warning,
-        })}
-        emptyStateTitle="No stored observations."
-      />
-    </Box>
+    <DataTableView<EstimateObservation>
+      columns={HISTORY}
+      items={rows}
+      focused={focused}
+      rootWidth={width}
+      rootHeight={height}
+      rootBefore={<ChartTableHeader width={width} height={height} tableRows={rows.length} figures={figures}
+        chart={hasHistory ? {
+          series, formatValue: number, formatAxisValue: formatEpsAxis, remoteKind: "estimate-revision-history", ...link,
+        } : null} />}
+      selection={{
+        kind: "id",
+        selectedId,
+        getId: historyId,
+        onChange: setSelected,
+      }}
+      getItemKey={historyId}
+      onActivate={(row) => setSelected(historyId(row))}
+      sortColumnId={historySort.column}
+      sortDirection={historySort.direction}
+      onHeaderClick={(column) =>
+        setHistorySort((old) => nextEstimateSort(old, column))
+      }
+      renderCell={(row, column, _index, state) => ({
+        text:
+          column.id === "date"
+            ? row.date
+            : column.id === "source"
+              ? historySource(row)
+              : number(
+                  row[column.id as "average" | "low" | "high" | "analysts"],
+                ),
+        color: state.selected ? colors.selectedText : row.source === "yahoo" ? colors.text : colors.warning,
+      })}
+      emptyStateTitle="No stored observations."
+    />
   );
 }
 export function EstimateRevisionsPane({ width, height, focused }: PaneProps) {
@@ -354,12 +341,7 @@ export function EstimateRevisionsPane({ width, height, focused }: PaneProps) {
     pinnedTarget.notice,
   ]);
   useAutoRefresh(resource.updatedAt, resource.load);
-  useShortcut((event) => {
-    if (focused && isPlainKey(event, "r")) {
-      event.preventDefault();
-      void resource.reload();
-    }
-  });
+  usePaneRefreshKey(() => void resource.reload(), { focused });
   usePaneNoticeFooter({
     registrationId: "estimates:notices",
     focused,
@@ -387,26 +369,19 @@ export function EstimateRevisionsPane({ width, height, focused }: PaneProps) {
               },
             ],
           },
-          ...(resource.data?.stale
-            ? [
-                {
-                  id: "stale",
-                  parts: [{ text: "stale", tone: "warning" as const }],
-                },
-              ]
-            : []),
         ]
       : [],
+    stale: !!data && resource.data?.stale,
   });
   const signInWall = !data && isCloudSessionRequired(resource.error);
   // Every tab would show the same wall, so the strip waits for data.
-  const tabsInHeader = usePaneHeaderTabs(!symbol || signInWall ? null : {
+  const { strip: tabStrip, rows: tabRows } = usePaneTabs(!symbol || signInWall ? null : {
     tabs: TABS,
     activeValue: tab,
     onSelect: setTab,
     focused: focused && !detailOpen,
+    dense: true,
   });
-  const tabRows = tabsInHeader ? 0 : 1;
   if (!symbol) return <EmptyState title="Select a ticker." />;
   if (signInWall)
     return (
@@ -422,15 +397,7 @@ export function EstimateRevisionsPane({ width, height, focused }: PaneProps) {
   );
   return (
     <Box width={width} height={height} flexDirection="column">
-      {!tabsInHeader && (
-        <Tabs
-          tabs={TABS}
-          activeValue={tab}
-          onSelect={setTab}
-          focused={focused && !detailOpen}
-          dense
-        />
-      )}
+      {tabStrip}
       <PaneStatusBody
         loading={resource.loading && !data}
         error={!data ? resource.error : null}
@@ -461,7 +428,7 @@ export function EstimateRevisionsPane({ width, height, focused }: PaneProps) {
                 <EstimateDetail
                   period={selectedPeriod}
                   width={width}
-                  height={Math.max(3, bodyHeight - 2)}
+                  height={Math.max(3, bodyHeight - 1)}
                   focused={focused}
                 />
               ) : null

package/src/plugins/builtin/executives/data.ts

@@ -3,7 +3,7 @@ import {
   type CloudProxyStatementListPayload,
   type CloudProxyStatementPayload,
 } from "../../../api-client";
-import { ApiRequestError } from "../../../api-client/errors";
+import { ApiRequestError, isPermanentClientError } from "../../../api-client/errors";
 import type { PluginPersistence } from "../../../types/plugin";
 
 /**
@@ -52,12 +52,6 @@ export function resetExecutivesPersistence(): void {
   failedRefreshes.clear();
 }
 
-/** Removed or denied research must not be replaced by previously cached data. */
-export function discardProxyData(error: unknown): boolean {
-  const status = error instanceof ApiRequestError ? error.status : undefined;
-  return status !== undefined && status >= 400 && status < 500 && status !== 408 && status !== 429;
-}
-
 function loadCached<T>(
   kind: string,
   key: string,
@@ -87,7 +81,8 @@ function loadCached<T>(
   }).catch((error: unknown) => {
     // A failed forced refresh must be retried on reopen even before the old TTL.
     if (current()) failedRefreshes.add(failedKey);
-    if (discardProxyData(error)) {
+    // Removed or denied research must not be replaced by previously cached data.
+    if (isPermanentClientError(error)) {
       if (current()) store?.deleteResource(kind, key, { sourceKey: CACHE_SOURCE });
       if (error instanceof ApiRequestError && error.status === 404) {
         return { data: null, fetchedAt: null };

package/src/plugins/builtin/executives/format.ts

@@ -1,4 +1,5 @@
 import type { CloudExecutiveRowPayload } from "../../../api-client";
+import { formatShortDate } from "../../../utils/datetime-format";
 import { formatPercentRaw } from "../../../utils/format";
 
 /** "$36.3M", "$282K", "$50,000". */
@@ -30,16 +31,8 @@ export function formatChange(
 }
 
 export function formatFiled(value: string | null): string {
-  if (!value) return "—";
-  const date = new Date(value);
-  if (Number.isNaN(date.getTime())) return "—";
-  return date.toLocaleDateString("en-US", {
-    // Filing and meeting dates are calendar labels, not local event times.
-    timeZone: "UTC",
-    month: "short",
-    day: "2-digit",
-    year: "numeric",
-  });
+  // Filing and meeting dates are calendar labels, not local event times.
+  return formatShortDate(value, { day: "2-digit", utc: true, fallback: "\u2014" });
 }
 
 /** Share of a row's total that was stock and option awards, as "82%". */
@@ -49,10 +42,3 @@ export function equityShare(row: CloudExecutiveRowPayload): string {
   if (equity <= 0) return "";
   return `${Math.round((equity / row.total) * 100)}%`;
 }
-
-/** "President and CEO" trimmed to fit a column. */
-export function shortTitle(title: string, max: number): string {
-  const cleaned = title.replace(/\s+/g, " ").trim();
-  if (cleaned.length <= max) return cleaned;
-  return `${cleaned.slice(0, Math.max(1, max - 1)).trimEnd()}…`;
-}