gloomberb 0.15.2 → 0.15.4

package/src/api-client/views.ts

@@ -1,22 +1,10 @@
-import { ApiRequestError } from "./errors";
+import { ApiRequestError, RevisionConflictError } from "./errors";
+import { putWithRevision, type CloudApiRequest } from "./request";
 import type { TeamPluginStateEntry, TeamView } from "./types";
 
-type CloudApiRequest = <T>(path: string, options?: RequestInit) => Promise<T>;
-
 /** A write refused because the server holds a newer revision. */
-export class TeamRevisionConflictError extends Error {
-  constructor(
-    message: string,
-    public readonly currentRevision: number,
-    public readonly current: unknown = null,
-  ) {
-    super(message);
-    this.name = "TeamRevisionConflictError";
-  }
-}
-
-function ifMatch(revision: number | undefined): Record<string, string> {
-  return revision ? { "if-match": String(revision) } : {};
+export class TeamRevisionConflictError<T = unknown> extends RevisionConflictError<T> {
+  override name = "TeamRevisionConflictError";
 }
 
 export class CloudViewsApi {
@@ -47,27 +35,14 @@ export class CloudViewsApi {
     viewId: string,
     input: { spec: Record<string, unknown>; name?: string; expectedRevision: number },
   ): Promise<TeamView> {
-    try {
-      return await this.request<TeamView>(`/views/${encodeURIComponent(viewId)}`, {
-        method: "PUT",
-        headers: ifMatch(input.expectedRevision),
-        body: JSON.stringify({ spec: input.spec, ...(input.name ? { name: input.name } : {}) }),
-      });
-    } catch (error) {
-      if (error instanceof ApiRequestError && error.status === 412) {
-        const current = await this.getTeamView(viewId).catch(() => null);
-        throw new TeamRevisionConflictError(error.message, current?.revision ?? input.expectedRevision + 1, current);
-      }
-      throw error;
-    }
-  }
-
-  async renameTeamView(viewId: string, name: string): Promise<TeamView> {
-    return this.request(`/views/${encodeURIComponent(viewId)}`, { method: "PATCH", body: JSON.stringify({ name }) });
-  }
-
-  async deleteTeamView(viewId: string): Promise<void> {
-    await this.request(`/views/${encodeURIComponent(viewId)}`, { method: "DELETE" });
+    return putWithRevision<TeamView, TeamView>(this.request, `/views/${encodeURIComponent(viewId)}`, {
+      spec: input.spec,
+      ...(input.name ? { name: input.name } : {}),
+    }, {
+      expected: input.expectedRevision,
+      loadCurrent: () => this.getTeamView(viewId),
+      conflict: TeamRevisionConflictError,
+    });
   }
 
   // Plugin state
@@ -97,18 +72,16 @@ export class CloudViewsApi {
     value: unknown,
     expectedRevision?: number,
   ): Promise<TeamPluginStateEntry> {
-    try {
-      return await this.request<TeamPluginStateEntry>(
-        `/teams/${encodeURIComponent(teamId)}/plugin-state/${encodeURIComponent(pluginId)}/${encodeURIComponent(key)}`,
-        { method: "PUT", headers: ifMatch(expectedRevision), body: JSON.stringify({ value }) },
-      );
-    } catch (error) {
-      if (error instanceof ApiRequestError && error.status === 412) {
-        const current = await this.getTeamPluginState(teamId, pluginId, key).catch(() => null);
-        throw new TeamRevisionConflictError(error.message, current?.revision ?? (expectedRevision ?? 0) + 1, current);
-      }
-      throw error;
-    }
+    return putWithRevision<TeamPluginStateEntry, TeamPluginStateEntry>(
+      this.request,
+      `/teams/${encodeURIComponent(teamId)}/plugin-state/${encodeURIComponent(pluginId)}/${encodeURIComponent(key)}`,
+      { value },
+      {
+        expected: expectedRevision,
+        loadCurrent: () => this.getTeamPluginState(teamId, pluginId, key),
+        conflict: TeamRevisionConflictError,
+      },
+    );
   }
 
   async deleteTeamPluginState(teamId: string, pluginId: string, key: string): Promise<void> {

package/src/app/app-bootstrap-state.ts

@@ -4,11 +4,9 @@ import {
   reconcileAppSessionSnapshot,
   type AppSessionSnapshot,
 } from "../core/state/session-persistence";
+import { materializeDetachedLayouts } from "../core/state/app/layout";
 import type { SessionStore } from "../data/session-store";
-import {
-  materializeDetachedPanesAsFloating,
-  type AppConfig,
-} from "../types/config";
+import type { AppConfig } from "../types/config";
 import type {
   DesktopSharedStateSnapshot,
   DesktopWindowBridge,
@@ -48,16 +46,7 @@ export function resolveInitialAppConfig({
   hasDesktopWindowBridge,
 }: ResolveInitialAppConfigOptions): AppConfig {
   const baseConfig = desktopSnapshot?.config ?? initialConfig;
-  if (hasDesktopWindowBridge) return baseConfig;
-
-  return {
-    ...baseConfig,
-    layout: materializeDetachedPanesAsFloating(baseConfig.layout),
-    layouts: baseConfig.layouts.map((entry) => ({
-      ...entry,
-      layout: materializeDetachedPanesAsFloating(entry.layout),
-    })),
-  };
+  return hasDesktopWindowBridge ? baseConfig : materializeDetachedLayouts(baseConfig);
 }
 
 export function resolveCliLaunchConfig<TLaunchState = unknown>({

package/src/app/pane-runtime/plugin-bindings.ts

@@ -21,6 +21,8 @@ import {
   removePane,
 } from "../../plugins/pane-manager";
 import type { PluginRegistry } from "../../plugins/registry";
+import { reportCrash } from "../../telemetry/crash-reports";
+import { recordFunctionOpen, usageFunctionForPane } from "../../telemetry/usage-counts";
 import {
   resolveTickerNavigationReplacementPane,
   shouldFocusTickerNavigationTarget,
@@ -33,6 +35,7 @@ import type {
   LayoutConfig,
   PaneInstanceConfig,
 } from "../../types/config";
+import { TICKER_RESEARCH_PANE_ID } from "../../types/config";
 import type { DataProvider } from "../../types/data-provider";
 import type {
   PaneDef,
@@ -44,7 +47,7 @@ import type {
 import type { TickerOpenTarget } from "../../tickers/open-target";
 import { instrumentFromTicker } from "../../market-data/request-types";
 import { tickerInstrumentLabel } from "../../tickers/instrument-label";
-import { stableStringify } from "../../remote/revision";
+import { stableStringify } from "../../utils/hash";
 
 // Registry callbacks are rebound on renders. Request ownership must survive
 // that rebinding, while separate source panes retain independent navigation.
@@ -215,12 +218,16 @@ export function bindAppPanePluginRegistry({
 
     focusVisiblePane(instanceId, layout);
   };
+  // Ticker links in panes and menus, and DES from the command bar, open the
+  // research pane (or the pane asked for) through these two.
   pluginRegistry.pinTickerFn = (symbol, options) => {
     if (isDetachedWindow) return;
+    recordFunctionOpen(usageFunctionForPane(pluginRegistry, options?.paneType ?? TICKER_RESEARCH_PANE_ID));
     void openPinnedTicker(symbol, options);
   };
   pluginRegistry.navigateTickerFn = (rawSymbol, options) => {
     if (isDetachedWindow) return;
+    recordFunctionOpen(usageFunctionForPane(pluginRegistry, TICKER_RESEARCH_PANE_ID));
     const sourcePaneId = options?.sourcePaneId ?? stateRef.current.focusedPaneId;
     const requests = tickerNavigationRequests.get(pluginRegistry) ?? new Map<string | null, symbol>();
     tickerNavigationRequests.set(pluginRegistry, requests);
@@ -352,6 +359,7 @@ export function bindAppPanePluginRegistry({
           ...(entry.linked ? { linked: true } : {}),
           ...(entry.unsupportedTarget ? { unsupportedTarget: entry.unsupportedTarget } : {}),
           ...(entry.error ? { loadError: entry.error } : {}),
+          ...(entry.needsGloomberb ? { needsGloomberb: entry.needsGloomberb } : {}),
           ...(entry.needsRestart ? { needsRestart: true } : {}),
         });
       }
@@ -361,6 +369,14 @@ export function bindAppPanePluginRegistry({
     activate: async (entry) => {
       if (isDetachedWindow) throw new Error("Manage plugins from the main window.");
       const pluginId = entry.plugin.id;
+      // New files under modules this process already imported: loading them
+      // would mix old and new code, so what is running keeps running and the
+      // row asks for a restart. The commit is the checkout's, now the new one.
+      if (entry.needsRestart) {
+        const running = listExternalPlugins().find((existing) => existing.directory === entry.directory);
+        upsertExternalPlugin({ ...(running ?? entry), ...(entry.commit ? { commit: entry.commit } : {}), needsRestart: true });
+        return;
+      }
       if (entry.error || entry.unsupportedTarget) {
         upsertExternalPlugin(entry);
         return;
@@ -381,6 +397,7 @@ export function bindAppPanePluginRegistry({
         upsertExternalPlugin(entry);
       } catch (error) {
         upsertExternalPlugin({ ...entry, error: error instanceof Error ? error.message : String(error) });
+        reportCrash(error, { kind: "plugin", plugin: pluginId });
         throw error;
       }
     },
@@ -415,6 +432,9 @@ export function bindAppPanePluginRegistry({
       const broker = [...pluginRegistry.brokers.keys()].some((type) => pluginRegistry.getBrokerPluginId(type) === pluginId);
       return { panes, templates, commands, capabilities, broker };
     },
+    notify: (notification) => {
+      pluginRegistry.notify(notification);
+    },
     setPluginEnabled: (pluginId, enabled) => {
       const current = stateRef.current.config;
       if (!enabled) {

package/src/app/runtime/broker-import.ts

@@ -133,7 +133,11 @@ export function useBrokerImportRuntime({
   }, [applyBrokerImportResult, pluginRegistry.brokers, pluginRegistry.persistence.resources, stateRef, tickerRepository]);
 
   const autoImportBrokerPositions = useCallback(async (tickerMap: Map<string, TickerRecord>) => {
-    const restoredConfig = restoreBrokerPortfoliosFromTickerPositions(stateRef.current.config, tickerMap.values());
+    const restoredConfig = restoreBrokerPortfoliosFromTickerPositions(
+      stateRef.current.config,
+      tickerMap.values(),
+      pluginRegistry.brokers,
+    );
     if (restoredConfig !== stateRef.current.config) {
       dispatch({ type: "SET_CONFIG", config: restoredConfig });
       await saveConfigImmediately(restoredConfig);

package/src/app/runtime/desktop-menu.ts

@@ -1,11 +1,11 @@
 import { useEffect, type Dispatch } from "react";
-import { notifyGridlockComplete } from "../../plugins/gridlock-notification";
-import { gridlockAllPanes } from "../../plugins/pane-manager";
+import { tidyWindows } from "../../plugins/pane-manager";
 import type { PluginRegistry } from "../../plugins/registry";
 import type { AppAction, AppState } from "../../state/app/context";
 import type { DesktopApplicationMenuBridge } from "../../types/desktop-menu";
 import type { DesktopWindowBridge } from "../../types/desktop-window";
 import type { RendererHost } from "../../ui/host";
+import { recordFunctionOpen } from "../../telemetry/usage-counts";
 
 export function useDesktopApplicationMenuRuntime({
   desktopApplicationMenuBridge,
@@ -34,6 +34,14 @@ export function useDesktopApplicationMenuRuntime({
         case "open-plugin-workflow":
           pluginRegistry.openPluginCommandWorkflowFn(command.commandId);
           break;
+        case "open-builtin-workflow":
+          dispatch({
+            type: "SET_COMMAND_BAR",
+            open: true,
+            query: "",
+            launch: { kind: "builtin-workflow", actionId: command.actionId },
+          });
+          break;
         case "open-url":
           void rendererHost.openExternal(command.url).catch((error) => {
             const message = error instanceof Error ? error.message : String(error);
@@ -47,26 +55,29 @@ export function useDesktopApplicationMenuRuntime({
           dispatch({ type: "TOGGLE_STATUS_BAR" });
           break;
         case "open-layout-gallery":
+          recordFunctionOpen({ shortcut: "LAY", externalPluginId: null });
           pluginRegistry.showPane("layout-marketplace");
           break;
+        case "quit":
+          // Through the view, so what was counted is sent before the app goes.
+          rendererHost.requestExit();
+          break;
         case "layout-undo":
           dispatch({ type: "UNDO_LAYOUT" });
           break;
         case "layout-redo":
           dispatch({ type: "REDO_LAYOUT" });
           break;
-        case "layout-gridlock": {
-          const { width, height } = pluginRegistry.getTermSizeFn();
-          pluginRegistry.updateLayoutFn(gridlockAllPanes(
-            stateRef.current.config.layout,
-            { x: 0, y: 0, width, height },
-            pluginRegistry.panes,
-          ));
-          notifyGridlockComplete(pluginRegistry.notify.bind(pluginRegistry), () => {
-            dispatch({ type: "UNDO_LAYOUT" });
+        case "layout-gridlock":
+          tidyWindows({
+            layout: stateRef.current.config.layout,
+            size: pluginRegistry.getTermSizeFn(),
+            paneTypes: pluginRegistry.panes,
+            apply: pluginRegistry.updateLayoutFn,
+            notify: pluginRegistry.notify,
+            onRevert: () => dispatch({ type: "UNDO_LAYOUT" }),
           });
           break;
-        }
       }
     });
   }, [

package/src/app/runtime/layout-warmup.ts

@@ -1,7 +1,7 @@
 import { useEffect, useRef } from "react";
 import { resolveInstrumentForPane } from "../../core/state/app/instrument";
 import type { InstrumentRef } from "../../market-data/request-types";
-import { buildInstrumentKey } from "../../market-data/selectors";
+import { instrumentIdentityKey } from "../../utils/instrument-identity";
 import { getDockedPaneIds } from "../../plugins/pane-manager/dock-tree";
 import type { AppConfig } from "../../types/config";
 import type { TickerRecord } from "../../types/ticker";
@@ -35,7 +35,7 @@ export function collectSavedLayoutInstruments(
       if (instruments.length >= limit) return;
       const instrument = resolveInstrumentForPane(state, paneId);
       if (!instrument) continue;
-      const key = buildInstrumentKey(instrument);
+      const key = instrumentIdentityKey(instrument);
       if (seen.has(key)) continue;
       seen.add(key);
       instruments.push(instrument);

package/src/app/runtime/plugin-bindings.ts

@@ -3,6 +3,7 @@ import {
   clearPersistedBrokerAccounts,
   getBrokerAccountCacheSourceKey,
 } from "../../brokers/account-cache";
+import { findPortfolioHeir } from "../../brokers/broker-portfolio-sync";
 import type { AppTickerRepositoryPort } from "../../core/app-service-ports";
 import type { MarketDataCoordinator } from "../../market-data/coordinator";
 import { instrumentFromTicker } from "../../market-data/request-types";
@@ -190,18 +191,33 @@ export function bindPluginRegistryRuntimeAccess({
     const broker = pluginRegistry.brokers.get(instance.brokerType);
     await broker?.disconnect?.(instance).catch(() => {});
 
-    const removedPortfolioIds = new Set(
-      stateRef.current.config.portfolios
-        .filter((portfolio) => portfolio.brokerInstanceId === instanceId)
-        .map((portfolio) => portfolio.id),
-    );
+    // A portfolio another profile of the account can keep (the account switched
+    // to or from sign-in) goes to that profile; only this profile's positions go.
+    const syncsAccount = (candidate: BrokerInstanceConfig, accountId: string) =>
+      (stateRef.current.brokerAccounts[candidate.id] ?? []).some((account) => account.accountId === accountId)
+      || [...stateRef.current.tickers.values()].some((ticker) => ticker.metadata.positions.some((position) =>
+        position.brokerInstanceId === candidate.id && position.brokerAccountId === accountId));
+    const heirs = new Map<string, string>();
+    const removedPortfolioIds = new Set<string>();
+    for (const portfolio of stateRef.current.config.portfolios) {
+      if (portfolio.brokerInstanceId !== instanceId) continue;
+      const heir = findPortfolioHeir(stateRef.current.config, instance, portfolio, pluginRegistry.brokers, syncsAccount);
+      if (heir) heirs.set(portfolio.id, heir.id);
+      else removedPortfolioIds.add(portfolio.id);
+    }
 
-    const nextPortfolios = stateRef.current.config.portfolios.filter((portfolio) => !removedPortfolioIds.has(portfolio.id));
+    const nextPortfolios = stateRef.current.config.portfolios.flatMap((portfolio) => {
+      if (removedPortfolioIds.has(portfolio.id)) return [];
+      const heirId = heirs.get(portfolio.id);
+      return [heirId ? { ...portfolio, brokerInstanceId: heirId } : portfolio];
+    });
     const nextTickers = new Map(stateRef.current.tickers);
 
     for (const ticker of stateRef.current.tickers.values()) {
       const nextPositions = ticker.metadata.positions.filter((position) => position.brokerInstanceId !== instanceId);
-      const nextPortfolioRefs = ticker.metadata.portfolios.filter((portfolioId) => !removedPortfolioIds.has(portfolioId));
+      const heldPortfolioIds = new Set(nextPositions.map((position) => position.portfolio));
+      const nextPortfolioRefs = ticker.metadata.portfolios.filter((portfolioId) =>
+        !removedPortfolioIds.has(portfolioId) && (!heirs.has(portfolioId) || heldPortfolioIds.has(portfolioId)));
       const nextBrokerContracts = (ticker.metadata.broker_contracts ?? []).filter((contract) => contract.brokerInstanceId !== instanceId);
 
       const nextTicker: TickerRecord = {
@@ -244,5 +260,9 @@ export function bindPluginRegistryRuntimeAccess({
     dispatch({ type: "SET_TICKERS", tickers: nextTickers });
     await saveConfigImmediately(nextConfig);
     pluginRegistry.events.emit("config:changed", { config: nextConfig });
+    // The profile that kept a portfolio fills in what the removed one held there.
+    for (const heirId of new Set(heirs.values())) {
+      void importBrokerPositions(heirId).catch(() => {});
+    }
   };
 }

package/src/app/runtime/startup.ts

@@ -18,13 +18,46 @@ import {
   type InitializeAppStateArgs,
 } from "../../state/app/bootstrap";
 import type { DataProvider } from "../../types/data-provider";
+import {
+  findPaneInstance,
+  getPlacedPaneInstanceIds,
+  type LayoutConfig,
+} from "../../types/config";
 import type { BrokerAccount } from "../../types/trading";
+import {
+  recordRestoredFunctions,
+  usageFunctionForPane,
+  type UsageFunction,
+} from "../../telemetry/usage-counts";
 import { debugLog } from "../../utils/debug-log";
 import { startMainThreadStallMonitor } from "../../utils/main-thread-stall";
 import { measurePerfAsync } from "../../utils/perf-marks";
 
 const appLog = debugLog.createLogger("app");
 
+/** How long the restored panes wait for plugins that register theirs during setup. */
+const RESTORED_FUNCTIONS_WAIT_MS = 15_000;
+
+/**
+ * One function per pane placed in the layout: docked, floating and popped
+ * out. Panes of disabled plugins are hidden and left out.
+ */
+function restoredUsageFunctions(
+  layout: LayoutConfig,
+  pluginRegistry: PluginRegistry,
+  disabledPlugins: readonly string[],
+): UsageFunction[] {
+  const functions: UsageFunction[] = [];
+  for (const instanceId of getPlacedPaneInstanceIds(layout)) {
+    const paneId = findPaneInstance(layout, instanceId)?.paneId;
+    if (!paneId) continue;
+    const pluginId = pluginRegistry.getPanePluginId(paneId);
+    if (pluginId && disabledPlugins.includes(pluginId)) continue;
+    functions.push(usageFunctionForPane(pluginRegistry, paneId));
+  }
+  return functions;
+}
+
 interface UseAppStartupRuntimeOptions {
   appActive: boolean;
   autoImportBrokerPositions: InitializeAppStateArgs["autoImportBrokerPositions"];
@@ -36,6 +69,8 @@ interface UseAppStartupRuntimeOptions {
   isDetachedWindow?: boolean;
   marketData: MarketDataCoordinator;
   pluginRegistry: PluginRegistry;
+  /** Settles once every plugin has registered, setup included. */
+  pluginsReady?: Promise<unknown>;
   primeCachedFinancials: InitializeAppStateArgs["primeCachedFinancials"];
   refreshQuote: InitializeAppStateArgs["refreshQuote"];
   refreshQuotesBatch: InitializeAppStateArgs["refreshQuotesBatch"];
@@ -57,6 +92,7 @@ export function useAppStartupRuntime({
   isDetachedWindow = false,
   marketData,
   pluginRegistry,
+  pluginsReady,
   primeCachedFinancials,
   refreshQuote,
   refreshQuotesBatch,
@@ -88,7 +124,7 @@ export function useAppStartupRuntime({
             pluginRegistry.brokers,
           );
         } catch (error) {
-          console.error("[startup] Failed to load persisted broker accounts:", error);
+          appLog.error("Failed to load persisted broker accounts", { error: error instanceof Error ? error.message : String(error) });
           pluginRegistry.notify({
             body: "Failed to load saved broker account data. Check local storage permissions.",
             type: "error",
@@ -162,6 +198,24 @@ export function useAppStartupRuntime({
     // identity, so this runs when initialization flips and not again.
   }, [externalPlugins, isDetachedWindow, pluginRegistry, state.initialized]);
 
+  // What people keep on screen: the functions open in the workspace restored
+  // at launch, counted once per session. The layout is taken as restored,
+  // before cloud sync can replace it; the first launch shows the default
+  // layout, not one anybody chose.
+  useEffect(() => {
+    if (!state.initialized || isDetachedWindow) return;
+    const { config } = getState();
+    if (!config.onboardingComplete) return;
+    const waitForPlugins = new Promise<void>((resolve) => {
+      setTimeout(resolve, RESTORED_FUNCTIONS_WAIT_MS);
+    });
+    void Promise.race([pluginsReady, waitForPlugins]).then(() => {
+      recordRestoredFunctions(restoredUsageFunctions(config.layout, pluginRegistry, config.disabledPlugins));
+    }).catch(() => {
+      /* Counting is best effort and must not surface as a crash. */
+    });
+  }, [getState, isDetachedWindow, pluginRegistry, pluginsReady, state.initialized]);
+
   useEffect(() => {
     if (!focusedTickerSymbol) return;
     const ticker = state.tickers.get(focusedTickerSymbol);

package/src/app/runtime/ticker-refresh.ts

@@ -1,7 +1,7 @@
 import { useCallback, useEffect, useRef, type Dispatch } from "react";
 import type { MarketDataCoordinator } from "../../market-data/coordinator";
 import { instrumentFromTicker, type InstrumentRef } from "../../market-data/request-types";
-import { buildInstrumentKey } from "../../market-data/selectors";
+import { instrumentIdentityKey } from "../../utils/instrument-identity";
 import type { PluginRegistry } from "../../plugins/registry";
 import type { AppAction } from "../../state/app/context";
 import type { InitializeAppStateArgs } from "../../state/app/bootstrap";
@@ -28,7 +28,7 @@ function resolveRefreshEntries(entries: RefreshEntry[]): InstrumentRefreshEntry[
   for (const entry of entries) {
     const instrument = entry.instrument ?? instrumentFromTicker(entry.ticker, entry.ticker.metadata.ticker);
     if (!instrument) continue;
-    const key = buildInstrumentKey(instrument);
+    const key = instrumentIdentityKey(instrument);
     const previous = targets.get(key);
     targets.set(key, { ...entry, instrument, key, priority: Math.min(previous?.priority ?? entry.priority, entry.priority) });
   }
@@ -66,7 +66,7 @@ export function useTickerRefreshRuntime({
   }, [dispatch]);
 
   const performRefreshTicker = useCallback(async (instrument: InstrumentRef) => {
-    const key = buildInstrumentKey(instrument);
+    const key = instrumentIdentityKey(instrument);
     if (refreshInFlight.has(key)) return;
     refreshInFlight.add(key);
     setRefreshing(instrument.symbol, true);
@@ -86,7 +86,7 @@ export function useTickerRefreshRuntime({
   }, [baseCurrency, marketData, pluginRegistry.events, setRefreshing]);
 
   const performRefreshQuote = useCallback(async (instrument: InstrumentRef) => {
-    const key = buildInstrumentKey(instrument);
+    const key = instrumentIdentityKey(instrument);
     if (refreshInFlight.has(key) || quoteRefreshInFlight.has(key)) return;
     quoteRefreshInFlight.add(key);
     try {
@@ -105,7 +105,7 @@ export function useTickerRefreshRuntime({
   const refreshTicker = useCallback<AppTickerRefreshRuntime["refreshTicker"]>((symbol, _exchange = "", tickerOverride, priority = 2, target) => {
     const instrument = target ?? instrumentFromTicker(tickerOverride ?? tickers.get(symbol), symbol);
     if (!instrument) return;
-    const key = buildInstrumentKey(instrument);
+    const key = instrumentIdentityKey(instrument);
     if (refreshInFlight.has(key) || pendingRefreshesRef.current.financials.has(key)) return;
     pendingRefreshesRef.current.financials.add(key);
     refreshQueueRef.current.queue.enqueue({
@@ -120,7 +120,7 @@ export function useTickerRefreshRuntime({
   const refreshQuote = useCallback<AppTickerRefreshRuntime["refreshQuote"]>((symbol, _exchange = "", tickerOverride, priority = 2, target) => {
     const instrument = target ?? instrumentFromTicker(tickerOverride ?? tickers.get(symbol), symbol);
     if (!instrument) return;
-    const key = buildInstrumentKey(instrument);
+    const key = instrumentIdentityKey(instrument);
     if (refreshInFlight.has(key) || quoteRefreshInFlight.has(key)
       || pendingRefreshesRef.current.financials.has(key) || pendingRefreshesRef.current.quotes.has(key)) return;
     pendingRefreshesRef.current.quotes.add(key);

package/src/app/runtime/update.ts

@@ -9,6 +9,7 @@ import {
   type ReleaseInfo,
 } from "../../updater";
 import { VERSION } from "../../version";
+import { runAutomated } from "../../telemetry/usage-counts";
 
 const UPDATE_CHECK_INTERVAL_MS = 60 * 60_000; // hourly
 
@@ -94,9 +95,10 @@ export function useAppUpdateRuntime({
     dispatch({ type: "SET_CONFIG", config: nextConfig });
     void saveConfigImmediately(nextConfig).catch(() => {});
     if (!isUpgrade) return;
-    void pluginRegistry.createPaneFromTemplateAsyncFn("changelog-pane", {
+    // Opened by the app, not the user: usage counts leave it out.
+    void runAutomated(() => pluginRegistry.createPaneFromTemplateAsyncFn("changelog-pane", {
       values: { version: VERSION },
-    }).catch(() => {});
+    })).catch(() => {});
   }, [dispatch, enabled, isDetachedWindow, pluginRegistry, stateRef]);
 
   useEffect(() => {

package/src/app.tsx

@@ -62,6 +62,8 @@ import { useAppLanguage } from "./i18n/react";
 import { AppLanguageConfigObserver } from "./app/language-observer";
 import { isPaneShareHandoff } from "./shares/location";
 import { apiClient } from "./api-client";
+import { reportTelemetryConfig } from "./telemetry/live-config";
+import { recordFunctionOpen } from "./telemetry/usage-counts";
 
 const EMPTY_EXTERNAL_PLUGINS: LoadedExternalPlugin[] = [];
 
@@ -83,6 +85,8 @@ interface AppInnerProps {
   signInGateActive?: boolean;
   /** Fires once the startup state is in place and the first real layout can paint. */
   onInitialized?: () => void;
+  /** Settles once every plugin has registered, setup included. */
+  pluginsReady?: Promise<unknown>;
 }
 
 function ThemedAppRoot({ children }: { children: ReactNode }) {
@@ -119,12 +123,17 @@ function AppInner({
   onOnboardingComplete,
   signInGateActive = false,
   onInitialized,
+  pluginsReady,
 }: AppInnerProps) {
   const dispatch = useAppDispatch();
   const stateRef = useAppStateRef();
   const getRemoteState = useCallback(() => stateRef.current, [stateRef]);
   useLinkedLayoutSync(pluginRegistry);
   const config = useAppSelector((state) => state.config);
+  // Telemetry switches apply as soon as they change, not at the next launch.
+  useEffect(() => {
+    reportTelemetryConfig(config.telemetry);
+  }, [config.telemetry]);
   const tickers = useAppSelector((state) => state.tickers);
   const paneState = useAppSelector((state) => state.paneState);
   const focusedPaneId = useAppSelector((state) => state.focusedPaneId);
@@ -298,6 +307,7 @@ function AppInner({
     isDetachedWindow,
     marketData,
     pluginRegistry,
+    pluginsReady,
     primeCachedFinancials,
     refreshQuote,
     refreshQuotesBatch,
@@ -431,7 +441,10 @@ function AppInner({
         desktopWindowBridge={desktopWindowBridge}
       >
         <ThemedAppRoot>
-          <Header onOpenHelp={() => pluginRegistry.showPane("help")} />
+          <Header onOpenHelp={() => {
+            recordFunctionOpen({ shortcut: "HELP", externalPluginId: null });
+            pluginRegistry.showPane("help");
+          }} />
           <TransientLayoutProvider>
             <Shell
               pluginRegistry={pluginRegistry}
@@ -608,6 +621,7 @@ export function App({
           onboardingActive={showOnboarding}
           signInGateActive={signInGateActive}
           onInitialized={onInitialized}
+          pluginsReady={services.ready}
           onOnboardingComplete={(updatedConfig) => {
             setConfig(updatedConfig);
             setShowOnboarding(false);