gloomberb 0.15.2 → 0.15.3

package/src/renderers/cloudflare/worker.ts

@@ -1,4 +1,5 @@
 import { handleHttpProxy } from "./http-proxy";
+import { HTTP_PROXY_PATH } from "../../utils/plugin-proxy-hosts";
 
 interface StaticAssetsBinding {
   fetch(request: Request): Promise<Response>;
@@ -11,8 +12,16 @@ export interface WorkerEnv {
 const SHARE_PATH = /^\/s\/[a-f0-9]{32}\/?$/;
 const LAYOUT_SHARE_PATH = /^\/l\/[a-f0-9]{32}\/?$/;
 const API_PATH = /^\/api(?:\/|$)/;
-const HTTP_PROXY_PATH = "/http-proxy";
 const APPLE_APP_SITE_ASSOCIATION_PATH = "/.well-known/apple-app-site-association";
+const ROBOTS_PATH = "/robots.txt";
+
+/**
+ * Crawling stays allowed on purpose. Deep links are kept out of the index by
+ * the `x-robots-tag` header on their HTML, which a crawler only sees if it may
+ * fetch the page. A `Disallow` would leave already indexed URLs stuck as
+ * "Indexed, though blocked by robots.txt".
+ */
+const ROBOTS_TXT = "User-agent: *\nAllow: /\n";
 
 /**
  * Lets the iOS app claim `https://term.gloom.sh/s/...` share links.
@@ -52,13 +61,13 @@ export const SECURITY_HEADERS = {
   "x-frame-options": "DENY",
 } as const;
 
-export function withSecurityHeaders(response: Response, options: { share?: boolean } = {}): Response {
+export function withSecurityHeaders(response: Response, options: { share?: boolean; noindex?: boolean } = {}): Response {
   const headers = new Headers(response.headers);
   for (const [name, value] of Object.entries(SECURITY_HEADERS)) headers.set(name, value);
+  const html = (headers.get("content-type") ?? "").includes("text/html");
   if (options.share) headers.set("x-robots-tag", "noindex, nofollow, noarchive");
-  if ((headers.get("content-type") ?? "").includes("text/html")) {
-    headers.set("cache-control", "no-store");
-  }
+  else if (options.noindex && html) headers.set("x-robots-tag", "noindex");
+  if (html) headers.set("cache-control", "no-store");
   return new Response(response.body, { status: response.status, statusText: response.statusText, headers });
 }
 
@@ -107,13 +116,23 @@ export async function handleRequest(request: Request, env: WorkerEnv, fetchApi:
       }),
     );
   }
+  // Without this the SPA fallback answers with the app's HTML.
+  if (url.pathname === ROBOTS_PATH) {
+    return withSecurityHeaders(new Response(ROBOTS_TXT, {
+      headers: { "content-type": "text/plain; charset=utf-8", "cache-control": "public, max-age=3600" },
+    }));
+  }
   const socialShare = SHARE_PATH.test(url.pathname) || LAYOUT_SHARE_PATH.test(url.pathname);
   if (socialShare) {
     const assetUrl = new URL("/share.html", url.origin);
     const assetRequest = new Request(assetUrl, { method: request.method, headers: request.headers });
     return withSecurityHeaders(await env.ASSETS.fetch(assetRequest), { share: true });
   }
-  return withSecurityHeaders(await env.ASSETS.fetch(request));
+  // Every path and query gets the same "Gloomberb" shell, so deep links such as
+  // `/?ticker=GPC&tab=executives` would be indexed as thin duplicates. Only the
+  // bare root stays indexable.
+  const deepLink = url.pathname !== "/" || url.search !== "";
+  return withSecurityHeaders(await env.ASSETS.fetch(request), { noindex: deepLink });
 }
 
 export default {

package/src/renderers/electrobun/bun/application-menu/click.ts

@@ -2,27 +2,11 @@ import {
   ELECTROBUN_APPLICATION_MENU_ACTION,
   type ElectrobunApplicationMenuCommand,
 } from "./index";
-
-function record(value: unknown): Record<string, unknown> | null {
-  return value && typeof value === "object" && !Array.isArray(value)
-    ? value as Record<string, unknown>
-    : null;
-}
-
-function applicationMenuClickPayload(event: unknown): Record<string, unknown> | null {
-  const eventRecord = record(event);
-  if (!eventRecord) return null;
-
-  const wrappedPayload = record(eventRecord.data);
-  if (typeof wrappedPayload?.action === "string") {
-    return wrappedPayload;
-  }
-
-  return typeof eventRecord.action === "string" ? eventRecord : null;
-}
+import { recordOrNull } from "../../../../utils/guards";
+import { menuClickPayload } from "../menu-event";
 
 function normalizeApplicationMenuCommand(value: unknown): ElectrobunApplicationMenuCommand | null {
-  const command = record(value);
+  const command = recordOrNull(value);
   if (!command || typeof command.type !== "string") return null;
 
   switch (command.type) {
@@ -35,6 +19,10 @@ function normalizeApplicationMenuCommand(value: unknown): ElectrobunApplicationM
       return typeof command.commandId === "string" && command.commandId.length > 0
         ? { type: "open-plugin-workflow", commandId: command.commandId }
         : null;
+    case "open-builtin-workflow":
+      return typeof command.actionId === "string" && command.actionId.length > 0
+        ? { type: "open-builtin-workflow", actionId: command.actionId }
+        : null;
     case "open-url":
       return typeof command.url === "string" && command.url.length > 0
         ? { type: "open-url", url: command.url }
@@ -54,7 +42,7 @@ function normalizeApplicationMenuCommand(value: unknown): ElectrobunApplicationM
 }
 
 export function applicationMenuCommand(event: unknown): ElectrobunApplicationMenuCommand | null {
-  const payload = applicationMenuClickPayload(event);
+  const payload = menuClickPayload(event);
   if (payload?.action !== ELECTROBUN_APPLICATION_MENU_ACTION) return null;
   return normalizeApplicationMenuCommand(payload.data);
 }

package/src/renderers/electrobun/bun/application-menu/index.ts

@@ -9,8 +9,7 @@ const GITHUB_ISSUE_URL = "https://github.com/gloom-sh/gloomberb/issues/new/choos
 
 export type ElectrobunApplicationMenuCommand =
   | DesktopApplicationMenuCommand
-  | { type: "open-devtools" }
-  | { type: "quit" };
+  | { type: "open-devtools" };
 
 function commandItem(
   label: string,
@@ -99,8 +98,8 @@ function buildApplicationMenu(keybindings: ResolvedKeybindings): ApplicationMenu
         commandItem("Redo Layout Change", { type: "layout-redo" }),
         commandItem("Tidy Windows", { type: "layout-gridlock" }, accelerator("tidy-windows")),
         { type: "divider" },
-        commandItem("New Layout...", { type: "open-plugin-workflow", commandId: "new-layout" }),
-        commandItem("Rename Current Layout...", { type: "open-plugin-workflow", commandId: "rename-layout" }),
+        commandItem("New Layout...", { type: "open-builtin-workflow", actionId: "new-layout" }),
+        commandItem("Rename Current Layout...", { type: "open-builtin-workflow", actionId: "rename-layout" }),
         openCommandBar("Duplicate Current Layout", "Duplicate Layout"),
         openCommandBar("Delete Current Layout...", "Delete Layout"),
       ],

package/src/renderers/electrobun/bun/context-menu/click.ts

@@ -1,27 +1,8 @@
-export interface ContextMenuSelectionMessage {
-  requestId: string;
-  itemId: string;
-}
-
-function record(value: unknown): Record<string, unknown> | null {
-  return value && typeof value === "object" && !Array.isArray(value)
-    ? value as Record<string, unknown>
-    : null;
-}
-
-function contextMenuClickPayload(event: unknown): Record<string, unknown> | null {
-  const eventRecord = record(event);
-  if (!eventRecord) return null;
-
-  const wrappedPayload = record(eventRecord.data);
-  if (typeof wrappedPayload?.action === "string") {
-    return wrappedPayload;
-  }
-
-  return typeof eventRecord.action === "string" ? eventRecord : null;
-}
+import { recordOrNull } from "../../../../utils/guards";
+import type { ContextMenuSelectMessage } from "../../shared/protocol";
+import { menuClickPayload } from "../menu-event";
 
-function decodeActionSelection(action: string, expectedAction: string): ContextMenuSelectionMessage | null {
+function decodeActionSelection(action: string, expectedAction: string): ContextMenuSelectMessage | null {
   const prefix = `${expectedAction}:`;
   if (!action.startsWith(prefix)) return null;
 
@@ -40,8 +21,8 @@ function decodeActionSelection(action: string, expectedAction: string): ContextM
 export function contextMenuSelectionMessage(
   event: unknown,
   expectedAction: string,
-): ContextMenuSelectionMessage | null {
-  const payload = contextMenuClickPayload(event);
+): ContextMenuSelectMessage | null {
+  const payload = menuClickPayload(event);
   if (typeof payload?.action !== "string") return null;
 
   const actionMessage = decodeActionSelection(payload.action, expectedAction);
@@ -49,7 +30,7 @@ export function contextMenuSelectionMessage(
 
   if (payload.action !== expectedAction) return null;
 
-  const data = record(payload.data);
+  const data = recordOrNull(payload.data);
   if (typeof data?.requestId !== "string" || typeof data.itemId !== "string") {
     return null;
   }

package/src/renderers/electrobun/bun/context-menu/normalize.ts

@@ -1,22 +1,17 @@
 import { ELECTROBUN_CONTEXT_MENU_ACTION } from "../../shared/protocol";
 import { contextMenuSelectionMessage } from "./click";
+import { recordOrNull } from "../../../../utils/guards";
 
 function normalizeText(value: unknown): string | undefined {
   return typeof value === "string" && value.length > 0 ? value : undefined;
 }
 
-function record(value: unknown): Record<string, unknown> | null {
-  return value && typeof value === "object" && !Array.isArray(value)
-    ? value as Record<string, unknown>
-    : null;
-}
-
 export function normalizeContextMenuItems(value: unknown, depth = 0): unknown[] {
   if (!Array.isArray(value) || depth > 4) return [];
 
   const items: unknown[] = [];
   for (const rawItem of value) {
-    const item = record(rawItem);
+    const item = recordOrNull(rawItem);
     if (!item) continue;
     if (item.type === "divider" || item.type === "separator") {
       items.push({ type: "divider" });
@@ -26,7 +21,7 @@ export function normalizeContextMenuItems(value: unknown, depth = 0): unknown[]
     const submenu = normalizeContextMenuItems(item.submenu, depth + 1);
     const role = normalizeText(item.role);
     const action = normalizeText(item.action);
-    const data = record(item.data);
+    const data = recordOrNull(item.data);
     const customAction = contextMenuSelectionMessage({ action, data }, ELECTROBUN_CONTEXT_MENU_ACTION) !== null;
 
     if (!role && !customAction && submenu.length === 0 && !normalizeText(item.label)) continue;
@@ -52,7 +47,7 @@ export function normalizeContextMenuItems(value: unknown, depth = 0): unknown[]
 
 export function getContextMenuRequestId(items: unknown[]): string | null {
   for (const item of items) {
-    const recordItem = record(item);
+    const recordItem = recordOrNull(item);
     if (!recordItem) continue;
     const message = contextMenuSelectionMessage(recordItem, ELECTROBUN_CONTEXT_MENU_ACTION);
     if (message) {

package/src/renderers/electrobun/bun/core-capabilities.ts

@@ -1,5 +1,3 @@
-import { mkdir, readFile, unlink, writeFile } from "fs/promises";
-import { dirname, join } from "path";
 import {
   BROKER_CAPABILITY_ID,
   NOTES_FILES_CAPABILITY_ID,
@@ -7,11 +5,11 @@ import {
   type PluginCapability,
 } from "../../../capabilities";
 import type { AppServices } from "../../../core/app-services";
+import { diskNotesFilesIO, isNotesFile } from "../../../plugins/builtin/notes/files";
 import type { BrokerAdapter } from "../../../types/broker";
 import type { AppConfig, BrokerInstanceConfig } from "../../../types/config";
 
 const DESKTOP_CORE_PLUGIN_ID = "desktop-core";
-const NOTES_INDEX_FILE = "__quick-notes-index__.json";
 
 const BROKER_INVOKE_OPERATIONS = new Set([
   "validate",
@@ -186,78 +184,32 @@ function createBrokerCapability(options: CoreCapabilityOptions): PluginCapabilit
   };
 }
 
-function notePath(dataDir: string, symbol: string): string {
-  return join(dataDir, `${symbol}.md`);
-}
-
-function notesIndexPath(dataDir: string): string {
-  return join(dataDir, NOTES_INDEX_FILE);
-}
-
-async function readTextOrEmpty(path: string): Promise<string> {
-  try {
-    return await readFile(path, "utf-8");
-  } catch {
-    return "";
-  }
-}
-
-async function writeTextEnsuringParent(path: string, value: string): Promise<void> {
-  await mkdir(dirname(path), { recursive: true });
-  await writeFile(path, value, "utf-8");
-}
-
-async function deleteFileIfPresent(path: string): Promise<void> {
-  try {
-    await unlink(path);
-  } catch (error) {
-    if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
-  }
-}
-
+/**
+ * The desktop view's notes: it runs `NotesFiles` over these operations, so
+ * the files and their layout are the ones the terminal reads.
+ */
 function createNotesFilesCapability(): PluginCapability {
+  const io = (input: any) => diskNotesFilesIO(requireString(input.dataDir, "Notes dataDir"));
+  const file = (input: any) => {
+    const name = requireString(input.file, "Notes file");
+    if (!isNotesFile(name)) throw new Error(`"${name}" is not a notes file.`);
+    return name;
+  };
   return {
     id: NOTES_FILES_CAPABILITY_ID,
     kind: "notes-files",
     name: "Notes Files",
     operations: {
-      load: op((input: any) => readTextOrEmpty(notePath(
-        requireString(input.dataDir, "Notes dataDir"),
-        requireString(input.symbol, "Notes symbol"),
-      ))),
-      save: op(async (input: any) => {
-        await writeTextEnsuringParent(
-          notePath(
-            requireString(input.dataDir, "Notes dataDir"),
-            requireString(input.symbol, "Notes symbol"),
-          ),
-          optionalString(input.notes) ?? "",
-        );
+      read: op((input: any) => io(input).read(file(input))),
+      write: op(async (input: any) => {
+        await io(input).write(file(input), optionalString(input.text) ?? "");
         return null;
       }, "action"),
       delete: op(async (input: any) => {
-        await deleteFileIfPresent(notePath(
-          requireString(input.dataDir, "Notes dataDir"),
-          requireString(input.symbol, "Notes symbol"),
-        ));
-        return null;
-      }, "action"),
-      loadQuickNotesIndex: op(async (input: any) => {
-        const raw = await readTextOrEmpty(notesIndexPath(requireString(input.dataDir, "Notes dataDir")));
-        if (!raw.trim()) return [];
-        try {
-          return JSON.parse(raw);
-        } catch {
-          return [];
-        }
-      }),
-      saveQuickNotesIndex: op(async (input: any) => {
-        await writeTextEnsuringParent(
-          notesIndexPath(requireString(input.dataDir, "Notes dataDir")),
-          JSON.stringify(input.entries ?? []),
-        );
+        await io(input).delete(file(input));
         return null;
       }, "action"),
+      listKeys: op((input: any) => io(input).listKeys()),
     },
   };
 }

package/src/renderers/electrobun/bun/desktop/detached-windows.ts

@@ -1,4 +1,4 @@
-import { BrowserWindow } from "electrobun/bun";
+import type { BrowserWindow } from "electrobun/bun";
 import { findPaneInstance, type AppConfig } from "../../../../types/config";
 import type { DesktopSharedStateSnapshot } from "../../../../types/desktop-window";
 import { isPaneDetached } from "../../../../plugins/pane-manager";
@@ -14,22 +14,9 @@ import {
   focusWindowForRpcKey,
   paneIdFromDetachedRpcKey,
 } from "../window/focus";
-import {
-  applyWindowMoveEvent,
-  applyWindowResizeEvent,
-  getWindowFrame,
-  updateWindowFrameCache,
-  type WindowMoveEvent,
-  type WindowResizeEvent,
-} from "./window-events";
+import { getWindowFrame } from "../window/events";
+import { createAppWindow } from "../window/create";
 import type { DesktopStateBroadcaster, DesktopStateRpc } from "./state-broadcaster";
-import { applyWindowsCustomChrome } from "./windows-custom-chrome";
-import { applyWindowsWindowIcon } from "./windows-icons";
-import {
-  desktopTitleBarStyle,
-  desktopWindowRenderer,
-  desktopWindowStyleMask,
-} from "./window-style";
 
 const INITIAL_DOCK_SUPPRESSION_MS = 800;
 const WINDOW_CONTROL_DOCK_SUPPRESSION_MS = 5_000;
@@ -189,20 +176,13 @@ export class DesktopDetachedWindowManager<Rpc extends DesktopStateRpc> {
     const rpc = this.options.createRpc(detachedRpcKey(instanceId));
     const initialFrame = normalizeWindowFrameWithMinimum(frame, DEFAULT_WINDOW_FRAME, DETACHED_WINDOW_MIN_SIZE);
     const title = this.resolveTitle(instanceId);
-    const window = new BrowserWindow({
+    const window = createAppWindow({
       title,
       frame: initialFrame,
-      url: "views://mainview/index.html",
-      renderer: desktopWindowRenderer(),
       rpc: rpc as never,
-      styleMask: desktopWindowStyleMask(),
-      titleBarStyle: desktopTitleBarStyle(),
-      navigationRules: JSON.stringify(["views://*"]),
-      sandbox: false,
+      minSize: DETACHED_WINDOW_MIN_SIZE,
+      onFrameChange: () => this.scheduleMove(instanceId),
     });
-    applyWindowsWindowIcon(title);
-    applyWindowsCustomChrome(title);
-    updateWindowFrameCache(window, initialFrame, DETACHED_WINDOW_MIN_SIZE);
     this.windows.set(instanceId, window);
     this.suppressDockUntil.set(instanceId, Date.now() + INITIAL_DOCK_SUPPRESSION_MS);
 
@@ -217,15 +197,6 @@ export class DesktopDetachedWindowManager<Rpc extends DesktopStateRpc> {
       void this.options.commitDesktopSnapshot(this.options.getDesktopWorkspace().closeDetachedPane(instanceId));
     });
 
-    (window as any).on?.("move", (event: WindowMoveEvent) => {
-      applyWindowMoveEvent(window, event);
-      this.scheduleMove(instanceId);
-    });
-    (window as any).on?.("resize", (event: WindowResizeEvent) => {
-      applyWindowResizeEvent(window, event, DETACHED_WINDOW_MIN_SIZE);
-      this.scheduleMove(instanceId);
-    });
-
     return window;
   }
 

package/src/renderers/electrobun/bun/desktop/host-requests.ts

@@ -4,7 +4,6 @@ import { buildSoundCommand } from "../../../../notifications/app-notifier";
 import type {
   DesktopBackendRequestResponse,
   DesktopHostRequest,
-  DesktopRestartMessage,
   DesktopWindowControlAction,
 } from "../../shared/protocol";
 import { safeExternalUrl } from "../../../../utils/external-url";
@@ -21,7 +20,6 @@ interface DesktopHostRequestOptions<TRpc> {
   getRpcWindowKey: (rpc: TRpc) => string | undefined;
   isWindowFullscreenForRpcKey: (windowKey: string | undefined) => boolean;
   request: DesktopHostRequest;
-  restartDesktopApp: (message?: DesktopRestartMessage) => void;
   rpc: TRpc;
   teardownServices: () => void;
   trackContextMenuRequest: (requestId: string, rpc: TRpc) => void;
@@ -62,18 +60,11 @@ export async function handleDesktopHostRequest<TRpc>({
   getRpcWindowKey,
   isWindowFullscreenForRpcKey,
   request,
-  restartDesktopApp,
   rpc,
   teardownServices,
   trackContextMenuRequest,
 }: DesktopHostRequestOptions<TRpc>): Promise<DesktopBackendRequestResponse<DesktopHostRequest["method"]>> {
   switch (request.method) {
-    case "host.restart":
-      restartDesktopApp({
-        reason: typeof request.payload.reason === "string" ? request.payload.reason : undefined,
-        source: typeof request.payload.source === "string" ? request.payload.source : "backend-request",
-      });
-      return null;
     case "host.exit": {
       closeAllDetachedWindows();
       teardownServices();

package/src/renderers/electrobun/bun/desktop/http-fetch.ts

@@ -3,7 +3,12 @@ import {
   GLOOM_CLOUD_FRED_CONNECTION_ID,
   GLOOM_CLOUD_HTTP_CONNECTION_ID,
 } from "../../../../core/connection-health";
-import type { DesktopBackendRequestPayload, DesktopHttpFetchResponse } from "../../shared/protocol";
+import {
+  readRequestInit,
+  toResponseEnvelope,
+  type HttpProxyResponseEnvelope,
+} from "../../../../utils/http-proxy-response";
+import type { DesktopBackendRequestPayload } from "../../shared/protocol";
 
 function isGloomCloudUrl(url: URL): boolean {
   try {
@@ -20,7 +25,10 @@ export function reportCloudRequest(
   success: boolean,
   error?: unknown,
 ): void {
-  if (!isGloomCloudUrl(url)) return;
+  // Crash reports, usage counts and command-search reports are background
+  // traffic, kept out of the connections pane the same way the API client
+  // keeps them out in-process.
+  if (!isGloomCloudUrl(url) || url.pathname.startsWith("/telemetry/") || url.pathname === "/assist/searches") return;
   const report = {
     operation: `${method} ${url.pathname}`,
     success,
@@ -33,54 +41,21 @@ export function reportCloudRequest(
   }
 }
 
-export function normalizeHttpFetchHeaders(headers: unknown): Record<string, string> {
-  if (!headers || typeof headers !== "object" || Array.isArray(headers)) {
-    return {};
-  }
-  return Object.fromEntries(
-    Object.entries(headers as Record<string, unknown>)
-      .filter((entry): entry is [string, string] => typeof entry[1] === "string"),
-  );
-}
-
 export async function handleHttpFetch(
   payload: DesktopBackendRequestPayload<"http.fetch">,
-): Promise<DesktopHttpFetchResponse> {
+): Promise<HttpProxyResponseEnvelope> {
   const url = requireProxyableUrl(payload.url, "http.fetch");
-
-  const init =
-    payload.init && typeof payload.init === "object" && !Array.isArray(payload.init)
-      ? payload.init as Record<string, unknown>
-      : {};
-  const method =
-    typeof init.method === "string" && init.method.trim().length > 0
-      ? init.method.trim().toUpperCase()
-      : "GET";
-  const redirect =
-    init.redirect === "manual" || init.redirect === "error" || init.redirect === "follow"
-      ? init.redirect
-      : undefined;
-  const body =
-    typeof init.body === "string" && method !== "GET" && method !== "HEAD"
-      ? init.body
-      : undefined;
-  const timeoutMs =
-    typeof init.timeoutMs === "number"
-      && Number.isFinite(init.timeoutMs)
-      && init.timeoutMs > 0
-      && init.timeoutMs <= 120_000
-      ? init.timeoutMs
-      : undefined;
+  const { method, headers, body, redirect, timeoutMs } = readRequestInit(payload.init);
 
   const startedAt = performance.now();
   let response: Response;
   try {
     response = await fetch(url, {
       method,
-      headers: normalizeHttpFetchHeaders(init.headers),
+      headers,
       body,
       redirect,
-      signal: timeoutMs ? AbortSignal.timeout(timeoutMs) : undefined,
+      signal: timeoutMs && timeoutMs <= 120_000 ? AbortSignal.timeout(timeoutMs) : undefined,
     });
   } catch (error) {
     reportCloudRequest(url, method, performance.now() - startedAt, false, error);
@@ -93,30 +68,7 @@ export async function handleHttpFetch(
     response.ok,
     response.ok ? undefined : new Error(`${response.status} ${response.statusText}`.trim()),
   );
-  const { headers, setCookie } = collectResponseHeaders(response);
-
-  return {
-    status: response.status,
-    statusText: response.statusText,
-    headers,
-    setCookie,
-    body: await response.text(),
-  };
-}
-
-/** Plain header map plus the `Set-Cookie` list the view replays itself. */
-export function collectResponseHeaders(response: Response): {
-  headers: Record<string, string>;
-  setCookie: string[];
-} {
-  const headers: Record<string, string> = {};
-  response.headers.forEach((value, key) => {
-    headers[key] = value;
-  });
-  const setCookie = [...(response.headers.getSetCookie?.() ?? [])];
-  const fallback = response.headers.get("set-cookie");
-  if (fallback && setCookie.length === 0) setCookie.push(fallback);
-  return { headers, setCookie };
+  return toResponseEnvelope(response);
 }
 
 /** Rejects anything the desktop must not proxy on the app's behalf. */

package/src/renderers/electrobun/bun/desktop/http-stream.ts

@@ -3,12 +3,8 @@ import type {
   DesktopHttpStreamOpenResponse,
   DesktopHttpStreamRequest,
 } from "../../shared/protocol";
-import {
-  collectResponseHeaders,
-  normalizeHttpFetchHeaders,
-  reportCloudRequest,
-  requireProxyableUrl,
-} from "./http-fetch";
+import { readRequestInit, toResponseHead } from "../../../../utils/http-proxy-response";
+import { reportCloudRequest, requireProxyableUrl } from "./http-fetch";
 
 interface DesktopHttpStreamRpc {
   send: {
@@ -89,8 +85,7 @@ export class DesktopHttpStreamBridge<Rpc extends DesktopHttpStreamRpc> {
     // A reused id can only mean the view lost track of the old stream.
     this.streams.get(scopedId)?.abort();
 
-    const init = payload.init ?? {};
-    const method = init.method?.trim().toUpperCase() || "GET";
+    const { method, headers, body } = readRequestInit(payload.init);
     const controller = new AbortController();
     this.streams.set(scopedId, controller);
 
@@ -99,10 +94,8 @@ export class DesktopHttpStreamBridge<Rpc extends DesktopHttpStreamRpc> {
     try {
       response = await this.fetch(url, {
         method,
-        headers: normalizeHttpFetchHeaders(init.headers),
-        ...(typeof init.body === "string" && method !== "GET" && method !== "HEAD"
-          ? { body: init.body }
-          : {}),
+        headers,
+        ...(body === undefined ? {} : { body }),
         signal: controller.signal,
       });
     } catch (error) {
@@ -118,13 +111,7 @@ export class DesktopHttpStreamBridge<Rpc extends DesktopHttpStreamRpc> {
       response.ok ? undefined : new Error(`${response.status} ${response.statusText}`.trim()),
     );
 
-    const { headers, setCookie } = collectResponseHeaders(response);
-    const head: DesktopHttpStreamOpenResponse = {
-      status: response.status,
-      statusText: response.statusText,
-      headers,
-      setCookie,
-    };
+    const head: DesktopHttpStreamOpenResponse = toResponseHead(response);
     // The view decides what a refusal means, so its body is delivered the same
     // way a successful one is rather than thrown from here.
     void this.pump(rpc, payload.streamId, scopedId, response, controller);

package/src/renderers/electrobun/bun/desktop/initialization.ts

@@ -1,4 +1,5 @@
 import { existsSync, mkdirSync } from "fs";
+import { homedir } from "os";
 import { getGloomberbHome } from "../../../../data/config/home";
 import { createAppServices, type AppServices } from "../../../../core/app-services";
 import { loadDesktopBackendPlugins } from "../../../../plugins/catalog-backend";
@@ -26,6 +27,8 @@ import {
 } from "../window/focus";
 import type { DesktopBackendRequestPayload, ElectrobunBackendInit } from "../../shared/protocol";
 import type { CapabilityRegistry } from "../../../../capabilities";
+import { telemetryOptedOut } from "../../../../telemetry/crash-reports";
+import { describeNodeOs, readOrCreateInstallId } from "../../../../telemetry/crash-reports-node";
 
 interface DesktopWindowTarget {
   kind: "main" | "detached";
@@ -102,6 +105,12 @@ function buildInitializationPayload(
     desktopPlatform: process.platform,
     windowKind: windowTarget.kind,
     paneId: windowTarget.paneId,
+    telemetry: {
+      installId: readOrCreateInstallId(config.dataDir),
+      os: describeNodeOs(),
+      homeDir: homedir(),
+      optedOut: telemetryOptedOut(process.env),
+    },
   };
 }