gloomberb 0.11.3 → 0.13.1

package/src/brokers/test-broker.ts

@@ -0,0 +1,68 @@
+import type { BrokerAdapter } from "../types/broker";
+
+/**
+ * A stand-in broker for tests of the generic broker machinery.
+ *
+ * These tests used to reach for the real IBKR adapter, which now lives in its
+ * own repository. Depending on a plugin to exercise host code is backwards
+ * anyway: it made a core test fail whenever that plugin's schema changed, and
+ * it hid which behaviour was actually under test.
+ *
+ * The shape mirrors what the machinery has to handle — a mode switch, a nested
+ * config, and a password field that must survive an edit left blank.
+ */
+export const testBroker: BrokerAdapter = {
+  id: "test-broker",
+  name: "Test Broker",
+  configSchema: [
+    {
+      key: "connectionMode",
+      label: "Connection",
+      type: "select",
+      options: [
+        { value: "token", label: "Token" },
+        { value: "local", label: "Local" },
+      ],
+      defaultValue: "token",
+    },
+    { key: "token", label: "API Token", type: "password", required: true, visibleWhen: { connectionMode: "token" } },
+    { key: "accountId", label: "Account", type: "text", required: true, visibleWhen: { connectionMode: "token" } },
+    { key: "host", label: "Host", type: "text", defaultValue: "127.0.0.1", visibleWhen: { connectionMode: "local" } },
+  ],
+
+  async validate() {
+    return true;
+  },
+
+  async importPositions() {
+    return [];
+  },
+
+  getStatus() {
+    return { state: "disconnected", message: "", updatedAt: 0 };
+  },
+
+  getProfileActions() {
+    // The pane renders and invokes profile actions; one is enough to cover that.
+    return [{ id: "test-console", label: "Console", paneId: "ibkr-trading" }];
+  },
+
+  toConfigValues(instance) {
+    const config = instance.config as Record<string, unknown>;
+    const credentials = (config.credentials ?? {}) as Record<string, unknown>;
+    return {
+      connectionMode: String(config.connectionMode ?? "token"),
+      token: String(credentials.token ?? ""),
+      accountId: String(credentials.accountId ?? ""),
+      host: String(config.host ?? "127.0.0.1"),
+    };
+  },
+
+  fromConfigValues(values) {
+    return {
+      connectionMode: values.connectionMode,
+      credentials: { token: values.token, accountId: values.accountId },
+      host: values.host,
+    };
+  },
+};

package/src/cli/commands/plugins.ts

@@ -1,7 +1,8 @@
 import { join } from "path";
 import { existsSync, mkdirSync, readFileSync, readdirSync, rmSync } from "fs";
 import { execFileSync } from "child_process";
-import { getPluginsDir } from "../../plugins/loader";
+import { getPluginsDir, isPluginDirectory } from "../../plugins/loader";
+import { linkHostPackages } from "../../plugins/host-link";
 import {
   cliStyles,
   renderSection,
@@ -50,7 +51,20 @@ function parseGitHubRef(rawRef: string): { url: string; name: string } {
   throw new Error(`Invalid plugin reference: ${ref}. Use user/repo or a GitHub URL.`);
 }
 
-export async function installPlugin(ref: string) {
+export interface InstallPluginOptions {
+  /**
+   * Suppress child-process output and progress logging. The marketplace pane
+   * installs while the terminal UI owns the screen, and git and bun writing to
+   * stdout corrupts the rendered frame.
+   */
+  quiet?: boolean;
+}
+
+export async function installPlugin(ref: string, options: InstallPluginOptions = {}) {
+  const stdio = options.quiet ? "pipe" : "inherit";
+  const say = (message: string) => {
+    if (!options.quiet) console.log(message);
+  };
   ensurePluginsDir();
   const { url, name } = parseGitHubRef(ref);
   const targetDir = join(PLUGINS_DIR, name);
@@ -59,11 +73,11 @@ export async function installPlugin(ref: string) {
     fail(`Plugin "${name}" already exists.`, `Use "gloomberb update ${name}" to refresh it.`);
   }
 
-  console.log(cliStyles.accent(`Installing ${name}`));
-  console.log(cliStyles.muted(url));
+  say(cliStyles.accent(`Installing ${name}`));
+  say(cliStyles.muted(url));
 
   try {
-    execFileSync("git", ["clone", "--depth", "1", url, targetDir], { stdio: "inherit" });
+    execFileSync("git", ["clone", "--depth", "1", url, targetDir], { stdio });
   } catch {
     rmSync(targetDir, { recursive: true, force: true });
     fail(`Failed to clone ${url}.`);
@@ -71,11 +85,24 @@ export async function installPlugin(ref: string) {
 
   const pkgPath = join(targetDir, "package.json");
   if (existsSync(pkgPath)) {
-    console.log(cliStyles.muted("Installing plugin dependencies..."));
+    say(cliStyles.muted("Installing plugin dependencies..."));
     try {
-      execFileSync("bun", ["install"], { cwd: targetDir, stdio: "inherit" });
+      // --production: plugin repos depend on `gloomberb` as a devDependency so
+      // their own CI can typecheck against the real API. At runtime the host is
+      // symlinked in instead, and pulling a second full copy here would both
+      // waste a lot of disk and risk a duplicate React.
+      execFileSync("bun", ["install", "--production"], { cwd: targetDir, stdio });
     } catch {
-      console.error(cliStyles.warning("Warning: failed to install plugin dependencies."));
+      if (!options.quiet) console.error(cliStyles.warning("Warning: failed to install plugin dependencies."));
+    }
+  }
+
+  // After `bun install`, which prunes links it does not know about.
+  const link = linkHostPackages(targetDir);
+  if (link.error) {
+    if (!options.quiet) {
+      console.error(cliStyles.warning(`Warning: could not link the Gloomberb runtime (${link.error}).`));
+      console.error(cliStyles.muted("The plugin's \"gloomberb/*\" imports will not resolve."));
     }
   }
 
@@ -98,13 +125,13 @@ export async function installPlugin(ref: string) {
       const mod = await import(entryFile);
       const plugin = mod.default ?? mod.plugin;
       if (plugin?.id && plugin?.name) {
-        console.log(cliStyles.success(`Installed ${plugin.name} v${plugin.version || "0.0.0"}`));
+        say(cliStyles.success(`Installed ${plugin.name} v${plugin.version || "0.0.0"}`));
         return;
       }
     }
-    console.log(cliStyles.warning("Installed files, but no valid GloomPlugin export was found."));
+    say(cliStyles.warning("Installed files, but no valid GloomPlugin export was found."));
   } catch (err) {
-    console.log(cliStyles.warning(`Plugin validation failed: ${err}`));
+    say(cliStyles.warning(`Plugin validation failed: ${err}`));
   }
 }
 
@@ -122,7 +149,7 @@ export async function updatePlugins(name?: string) {
   const dirs = name
     ? [validatePluginDirectoryName(name)]
     : readdirSync(PLUGINS_DIR, { withFileTypes: true })
-        .filter((entry) => entry.isDirectory())
+        .filter((entry) => entry.isDirectory() && isPluginDirectory(entry.name))
         .map((entry) => entry.name);
 
   if (dirs.length === 0) {
@@ -141,8 +168,9 @@ export async function updatePlugins(name?: string) {
       execFileSync("git", ["pull", "--ff-only"], { cwd: targetDir, stdio: "inherit" });
       const pkgPath = join(targetDir, "package.json");
       if (existsSync(pkgPath)) {
-        execFileSync("bun", ["install"], { cwd: targetDir, stdio: "inherit" });
+        execFileSync("bun", ["install", "--production"], { cwd: targetDir, stdio: "inherit" });
       }
+      linkHostPackages(targetDir);
     } catch {
       console.error(cliStyles.danger(`Failed to update ${dir}.`));
     }
@@ -151,7 +179,8 @@ export async function updatePlugins(name?: string) {
 
 export function listPlugins() {
   ensurePluginsDir();
-  const entries = readdirSync(PLUGINS_DIR, { withFileTypes: true }).filter((entry) => entry.isDirectory());
+  const entries = readdirSync(PLUGINS_DIR, { withFileTypes: true })
+    .filter((entry) => entry.isDirectory() && isPluginDirectory(entry.name));
 
   if (entries.length === 0) {
     console.log(cliStyles.muted("No plugins installed."));