gloomberb 0.10.4 → 0.11.0

package/src/plugins/builtin/market-movers/index.tsx

@@ -1,15 +1,19 @@
 import { Box } from "../../../ui";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
-import { DataTableView, Tabs, usePaneFooter, type DataTableKeyEvent } from "../../../components";
+import { DataTableView, EmptyState, Tabs, usePaneFooter, type DataTableKeyEvent } from "../../../components";
 import type { PaneProps } from "../../../types/plugin";
 import type { PluginModule } from "../plugin-module";
 import { TICKER_RESEARCH_PANE_ID } from "../../../types/config";
 import { priceColor } from "../../../theme/colors";
 import { formatPercentRaw } from "../../../utils/format";
+import { useAppSelector, usePaneSettingValue } from "../../../state/app/context";
 import { useAssetData, usePluginTickerActions } from "../../runtime";
+import { useLiveQuoteEntries } from "../../../state/hooks/quote-streaming";
+import { useAutoRefresh } from "../shared/auto-refresh";
+import { useQuoteBoard } from "../shared/use-quote-board";
 import {
   attachMarketMoversPersistence,
-  fetchScreener,
+  fetchPreferredMarketMovers,
   fetchTrending,
   MARKET_SUMMARY_SYMBOLS,
   resetMarketMoversPersistence,
@@ -23,6 +27,8 @@ import {
   TABS,
   createRows,
   nextSortPreference,
+  resolveSummarySymbols,
+  resolveTabs,
   screenerQuoteFromQuote,
   sortRows,
   summaryQuoteFromQuote,
@@ -32,22 +38,68 @@ import {
   type TabId,
 } from "./model";
 import { buildMarketMoverColumns, renderMarketMoverCell } from "./table";
+import {
+  LIVE_STREAMING_QUICK_SETTING,
+  useLiveStreamingSetting,
+  withLiveStreamingSetting,
+} from "../shared/live-streaming";
+import {
+  buildScreenerQuoteTargets,
+  overlayScreenerQuoteEntries,
+  resolveScreenerQuoteFeedStatus,
+} from "../shared/screener-live-quotes";
+
+/** Stable identity: a fresh literal here would reload the board every render. */
+const NO_SAVED_SELECTION: string[] = [];
 
 function MarketMoversPane({ focused, width, height }: PaneProps) {
   const dataProvider = useAssetData();
   const { pinTicker } = usePluginTickerActions();
-  const [activeTab, setActiveTab] = useState<TabId>("gainers");
+  const liveStreaming = useLiveStreamingSetting();
+  const [savedTabs] = usePaneSettingValue<string[]>("tabs", NO_SAVED_SELECTION);
+  const [savedSummarySymbols] = usePaneSettingValue<string[]>("summarySymbols", NO_SAVED_SELECTION);
+  const tabs = useMemo(() => resolveTabs(savedTabs), [savedTabs]);
+  const summarySymbols = useMemo(() => resolveSummarySymbols(savedSummarySymbols), [savedSummarySymbols]);
+  // One cadence, the one the user configured, instead of a private 60s timer.
+  const refreshIntervalMinutes = useAppSelector((state) => state.config.refreshIntervalMinutes);
+  const refreshIntervalMs = Math.max(1, refreshIntervalMinutes || 1) * 60_000;
+  const [activeTab, setActiveTab] = useState<TabId>(tabs[0]!.id);
   const [quotes, setQuotes] = useState<ScreenerQuote[]>([]);
-  const [loading, setLoading] = useState(false);
+  // The first load starts before the effect runs; an empty board is not "no data".
+  const [loading, setLoading] = useState(true);
   const [loadError, setLoadError] = useState<string | null>(null);
   const [selectedSymbol, setSelectedSymbol] = useState<string | null>(null);
   const [sortPreference, setSortPreference] = useState<MarketMoverSortPreference>(DEFAULT_SORT_PREFERENCE);
-  const [summaryQuotes, setSummaryQuotes] = useState<MarketSummaryQuote[]>([]);
+  const [moversStale, setMoversStale] = useState(false);
+  const [lastLoadedAt, setLastLoadedAt] = useState<number | null>(null);
 
   const fetchGenRef = useRef(0);
 
+  const quoteTargets = useMemo(
+    () => buildScreenerQuoteTargets(quotes, selectedSymbol),
+    [quotes, selectedSymbol],
+  );
+  const {
+    entries: liveQuoteEntries,
+    freshnessNow,
+    subscriptionStartedAt,
+  } = useLiveQuoteEntries(quoteTargets, {
+    freshnessScopeKey: `market-movers:${activeTab}`,
+    liveStreaming,
+  });
+  const resolvedQuotes = useMemo(
+    () => overlayScreenerQuoteEntries(quotes, liveQuoteEntries),
+    [liveQuoteEntries, quotes],
+  );
+  const feedStatus = useMemo(
+    () => resolveScreenerQuoteFeedStatus(quoteTargets, liveQuoteEntries, {
+      now: freshnessNow,
+      subscriptionStartedAt,
+    }),
+    [freshnessNow, liveQuoteEntries, quoteTargets, subscriptionStartedAt],
+  );
   const columns = useMemo(() => buildMarketMoverColumns(width), [width]);
-  const rankedRows = useMemo(() => createRows(quotes), [quotes]);
+  const rankedRows = useMemo(() => createRows(resolvedQuotes), [resolvedQuotes]);
   const rows = useMemo(() => sortRows(rankedRows, sortPreference), [rankedRows, sortPreference]);
   const selectedIdx = selectedSymbol
     ? rows.findIndex((row) => row.symbol === selectedSymbol)
@@ -62,50 +114,28 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
     }
   }, [rows, selectedIdx, selectedSymbol]);
 
-  // Fetch market summary via the asset-data client.
-  useEffect(() => {
-    if (!dataProvider) return;
-    const loadSummary = async () => {
-      if (dataProvider.getQuotesBatch) {
-        const batchResults = await dataProvider.getQuotesBatch(
-          MARKET_SUMMARY_SYMBOLS.map((symbol) => ({ symbol, exchange: "" })),
-        ).catch(() => []);
-        const bySymbol = new Map(batchResults.map((result) => [result.target.symbol, result]));
-        setSummaryQuotes(
-          MARKET_SUMMARY_SYMBOLS
-            .map((symbol) => {
-              const result = bySymbol.get(symbol);
-              return result?.quote ? summaryQuoteFromQuote(symbol, result.quote) : null;
-            })
-            .filter((quote): quote is MarketSummaryQuote => !!quote),
-        );
-        return;
-      }
-
-      const results = await Promise.all(MARKET_SUMMARY_SYMBOLS.map(async (symbol) => {
-        try {
-          const quote = await dataProvider.getQuote(symbol, "");
-          return quote ? summaryQuoteFromQuote(symbol, quote) : null;
-        } catch {
-          return null;
-        }
-      }));
-      setSummaryQuotes(
-        MARKET_SUMMARY_SYMBOLS
-          .map((s) => results.find((r) => r?.symbol === s))
-          .filter((r): r is MarketSummaryQuote => !!r),
-      );
-    };
-    loadSummary();
-    const interval = setInterval(loadSummary, 60_000);
-    return () => clearInterval(interval);
-  }, [dataProvider]);
+  // The index summary is a quote board like any other, so it runs on the shared
+  // one instead of a third parallel pipeline against the same upstream.
+  const { quotes: summaryBoard } = useQuoteBoard(summarySymbols, refreshIntervalMs);
+  const summaryQuotes = useMemo<MarketSummaryQuote[]>(() => (
+    summarySymbols
+      .map((symbol) => {
+        const quote = summaryBoard.get(symbol)?.quote;
+        return quote ? summaryQuoteFromQuote(symbol, quote) : null;
+      })
+      .filter((quote): quote is MarketSummaryQuote => !!quote)
+  ), [summaryBoard, summarySymbols]);
 
-  const loadTab = useCallback(async (tab: TabId, options?: { forceRefresh?: boolean }) => {
+  const loadTab = useCallback(async (
+    tab: TabId,
+    options?: { forceRefresh?: boolean; background?: boolean },
+  ) => {
     fetchGenRef.current += 1;
     const gen = fetchGenRef.current;
-    setLoading(true);
-    setLoadError(null);
+    if (!options?.background) {
+      setLoading(true);
+      setLoadError(null);
+    }
 
     try {
       let data: ScreenerQuote[];
@@ -145,27 +175,47 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
         data = trending
           .map((t) => resolved.find((r) => r.symbol === t.symbol))
           .filter((r): r is ScreenerQuote => r !== undefined);
+        setMoversStale(false);
       } else {
-        data = await fetchScreener(CATEGORY_MAP[tab], 25, undefined, {
+        const result = await fetchPreferredMarketMovers(CATEGORY_MAP[tab], 25, {
           forceRefresh: options?.forceRefresh,
         });
         if (fetchGenRef.current !== gen) return;
+        data = result.quotes;
+        setMoversStale(result.stale);
       }
 
       setQuotes(data);
-      setSelectedSymbol(null);
+      if (!options?.background) setSelectedSymbol(null);
       setLoadError(null);
-    } catch (error) {
-      if (fetchGenRef.current === gen) {
-        setLoadError(error instanceof Error ? error.message : "Market movers unavailable");
+      setLastLoadedAt(Date.now());
+    } catch {
+      if (fetchGenRef.current !== gen) return;
+      if (options?.background) {
+        // Rows stay, but they are no longer what the pane just fetched.
+        setMoversStale(true);
+        return;
       }
+      setLoadError("Market movers temporarily unavailable");
     }
     finally {
-      if (fetchGenRef.current === gen) setLoading(false);
+      if (fetchGenRef.current === gen && !options?.background) setLoading(false);
     }
   }, [dataProvider]);
 
-  useEffect(() => { loadTab(activeTab); }, [activeTab, loadTab]);
+  useEffect(() => {
+    if (tabs.some((tab) => tab.id === activeTab)) return;
+    setActiveTab(tabs[0]!.id);
+  }, [activeTab, tabs]);
+
+  useEffect(() => {
+    void loadTab(activeTab);
+  }, [activeTab, loadTab]);
+
+  const backgroundRefresh = useCallback(() => {
+    void loadTab(activeTab, { background: true });
+  }, [activeTab, loadTab]);
+  useAutoRefresh(lastLoadedAt, backgroundRefresh);
 
   const openSymbol = useCallback((symbol: string) => {
     pinTicker(symbol, { floating: true, paneType: TICKER_RESEARCH_PANE_ID });
@@ -187,10 +237,6 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
     return false;
   }, [activeTab, loadTab]);
 
-  const refreshActiveTab = useCallback(() => {
-    void loadTab(activeTab, { forceRefresh: true });
-  }, [activeTab, loadTab]);
-
   usePaneFooter("market-movers", () => ({
     info: [
       ...summaryQuotes.map((idx) => {
@@ -204,15 +250,22 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
         };
       }),
       ...(loading ? [{ id: "loading", parts: [{ text: "loading", tone: "muted" as const }] }] : []),
+      ...(feedStatus ? [{
+        id: "feed",
+        parts: [{ text: feedStatus, tone: feedStatus === "live" ? "value" as const : "muted" as const }],
+      }] : []),
+      ...(moversStale ? [{
+        id: "stale",
+        parts: [{ text: "stale", tone: "muted" as const }],
+      }] : []),
     ],
-    hints: [{ id: "refresh", key: "r", label: "efresh", onPress: refreshActiveTab }],
-  }), [loading, refreshActiveTab, summaryQuotes]);
+  }), [feedStatus, loading, moversStale, summaryQuotes]);
 
   return (
     <Box flexDirection="column" width={width} height={height}>
       <Box height={1} paddingX={1}>
         <Tabs
-          tabs={TABS.map((tab) => ({ label: tab.label, value: tab.id }))}
+          tabs={tabs.map((tab) => ({ label: tab.label, value: tab.id }))}
           activeValue={activeTab}
           onSelect={(value) => {
             setActiveTab(value as TabId);
@@ -242,8 +295,12 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
         getItemKey={(row) => `${row.symbol}-${row.rank}`}
         onActivate={(row) => openSymbol(row.symbol)}
         renderCell={renderMarketMoverCell}
-        emptyStateTitle={loading ? "Loading movers..." : loadError ?? "No data"}
-        emptyStateHint={loadError ? "Yahoo Finance did not return market movers." : undefined}
+        emptyStateTitle={loading ? "Loading movers..." : loadError ?? "No movers returned."}
+        emptyContent={loadError ? (
+          <Box paddingX={1} paddingY={1}>
+            <EmptyState title={loadError} message="Try again in a moment." />
+          </Box>
+        ) : undefined}
       />
     </Box>
   );
@@ -267,6 +324,31 @@ export const marketMoversModule: PluginModule = {
       defaultPosition: "right",
       defaultMode: "floating",
       defaultFloatingSize: { width: 100, height: 36 },
+      quickSettings: [LIVE_STREAMING_QUICK_SETTING],
+      settings: (context) => withLiveStreamingSetting({
+        title: "Market Movers Settings",
+        values: {
+          tabs: resolveTabs(context.settings.tabs as string[] | undefined).map((tab) => tab.id),
+          summarySymbols: resolveSummarySymbols(context.settings.summarySymbols as string[] | undefined),
+        },
+        fields: [
+          {
+            key: "tabs",
+            label: "Lists",
+            type: "ordered-multi-select",
+            options: TABS.map((tab) => ({ value: tab.id, label: tab.label })),
+          },
+          {
+            key: "summarySymbols",
+            label: "Index summary",
+            type: "ordered-multi-select",
+            options: MARKET_SUMMARY_SYMBOLS.map((symbol) => ({
+              value: symbol,
+              label: INDEX_SHORT[symbol] ?? symbol,
+            })),
+          },
+        ],
+      }, context.settings),
     },
   ],
 

package/src/plugins/builtin/market-movers/model.ts

@@ -1,6 +1,6 @@
 import type { DataTableColumn } from "../../../components";
 import { compareSortValues, type SortDirection } from "../../../utils/sort-values";
-import type { MarketSummaryQuote, ScreenerCategory, ScreenerQuote } from "./screener";
+import { MARKET_SUMMARY_SYMBOLS, type MarketSummaryQuote, type ScreenerCategory, type ScreenerQuote } from "./screener";
 
 export type TabId = "gainers" | "losers" | "actives" | "trending";
 
@@ -40,6 +40,21 @@ export const DEFAULT_SORT_PREFERENCE: MarketMoverSortPreference = {
   direction: "asc",
 };
 
+/** The saved list selection, falling back to every list when it is unusable. */
+export function resolveTabs(saved?: readonly string[]): Array<{ id: TabId; label: string }> {
+  const byId = new Map(TABS.map((tab) => [tab.id as string, tab]));
+  const resolved = (saved ?? [])
+    .map((id) => byId.get(id))
+    .filter((tab): tab is { id: TabId; label: string } => !!tab);
+  return resolved.length > 0 ? resolved : [...TABS];
+}
+
+/** The saved index-summary selection, falling back to every index. */
+export function resolveSummarySymbols(saved?: readonly string[]): string[] {
+  const resolved = (saved ?? []).filter((symbol) => MARKET_SUMMARY_SYMBOLS.includes(symbol as never));
+  return resolved.length > 0 ? resolved : [...MARKET_SUMMARY_SYMBOLS];
+}
+
 export const INDEX_SHORT: Record<string, string> = {
   "^GSPC": "SPX",
   "^DJI": "DJIA",
@@ -125,7 +140,7 @@ export function summaryQuoteFromQuote(
   };
 }
 
-export function screenerQuoteFromQuote(symbol: string, quote: { name?: string; price?: number; change?: number; changePercent?: number; volume?: number; currency?: string }): ScreenerQuote {
+export function screenerQuoteFromQuote(symbol: string, quote: { name?: string; price?: number; change?: number; changePercent?: number; volume?: number; currency?: string; exchangeName?: string; listingExchangeName?: string; lastUpdated?: number }): ScreenerQuote {
   return {
     symbol,
     name: quote.name ?? symbol,
@@ -141,6 +156,7 @@ export function screenerQuoteFromQuote(symbol: string, quote: { name?: string; p
     fiftyTwoWeekLow: undefined,
     dayHigh: undefined,
     dayLow: undefined,
-    exchange: "",
+    exchange: quote.listingExchangeName ?? quote.exchangeName ?? "",
+    lastUpdated: quote.lastUpdated,
   };
 }

package/src/plugins/builtin/market-movers/screener.test.ts

@@ -3,11 +3,14 @@ import { MemoryPluginPersistence } from "../../../test-support/plugin-persistenc
 import {
   attachMarketMoversPersistence,
   createYahooScreenerApi,
+  fetchPreferredMarketMovers,
   fetchScreener,
+  fetchScreenerResult,
   parseScreenerResponse,
   parseTrendingResponse,
   resetMarketMoversPersistence,
   type YahooScreenerApi,
+  type PreferredMarketMoverSources,
 } from "./screener";
 
 const SAMPLE_SCREENER_RESPONSE = {
@@ -138,6 +141,111 @@ describe("parseTrendingResponse", () => {
 });
 
 describe("fetchScreener", () => {
+  test("uses Cloud rankings and prices while retaining Yahoo metadata", async () => {
+    const calls: unknown[] = [];
+    const yahooQuotes = parseScreenerResponse(SAMPLE_SCREENER_RESPONSE);
+    const sources: PreferredMarketMoverSources = {
+      isCloudEligible: () => true,
+      fetchCloud: async (category, count, mode) => {
+        calls.push({ category, count, mode });
+        return {
+          status: "success",
+          data: {
+            providerId: "gloomberb-cloud",
+            category,
+            asOf: "2026-08-14T23:59:00.000Z",
+            items: [
+              {
+                rank: 1,
+                symbol: "AAPL",
+                name: "AAPL",
+                price: 190,
+                change: 7.75,
+                changePercent: 4.25,
+                volume: 60_000_000,
+                currency: "USD",
+                exchange: "NASDAQ",
+                lastUpdated: 1_700_000_000_000,
+                dataSource: "live",
+              },
+            ],
+          },
+        };
+      },
+      fetchYahoo: async () => ({ data: yahooQuotes, stale: false }),
+    };
+
+    const result = await fetchPreferredMarketMovers(
+      "day_gainers",
+      25,
+      { forceRefresh: true },
+      sources,
+    );
+
+    expect(calls).toEqual([
+      { category: "gainers", count: 25, mode: "refresh" },
+    ]);
+    expect(result).toMatchObject({ source: "cloud", stale: false });
+    expect(result.quotes[0]).toMatchObject({
+      symbol: "AAPL",
+      name: "Apple Inc.",
+      price: 190,
+      changePercent: 4.25,
+      volume: 60_000_000,
+      avgVolume: 20_000_000,
+      marketCap: 2_900_000_000_000,
+      lastUpdated: 1_700_000_000_000,
+    });
+  });
+
+  test("keeps free accounts on Yahoo without calling the Pro screener", async () => {
+    let cloudCalls = 0;
+    const sources: PreferredMarketMoverSources = {
+      isCloudEligible: () => false,
+      fetchCloud: async () => {
+        cloudCalls += 1;
+        throw new Error("not expected");
+      },
+      fetchYahoo: async () => ({ data: parseScreenerResponse(SAMPLE_SCREENER_RESPONSE), stale: false }),
+    };
+
+    const result = await fetchPreferredMarketMovers(
+      "most_actives",
+      25,
+      undefined,
+      sources,
+    );
+
+    expect(cloudCalls).toBe(0);
+    expect(result.source).toBe("yahoo");
+    expect(result.quotes.map((quote) => quote.symbol)).toEqual(["AAPL", "MSFT"]);
+  });
+
+  test("reports a cached Yahoo fallback as stale", async () => {
+    // Regression: an expired cache served after a failed fetch reported
+    // stale: false, so the pane's stale marker never appeared.
+    const persistence = new MemoryPluginPersistence();
+    attachMarketMoversPersistence(persistence);
+    let calls = 0;
+    const api: YahooScreenerApi = {
+      async fetchJson<T = unknown>() {
+        calls += 1;
+        if (calls === 1) return SAMPLE_SCREENER_RESPONSE as T;
+        throw new Error("upstream down");
+      },
+    };
+
+    const fresh = await fetchScreenerResult("day_gainers", 2, api, { cache: true });
+    expect(fresh.stale).toBe(false);
+
+    const fallback = await fetchScreenerResult("day_gainers", 2, api, {
+      cache: true,
+      forceRefresh: true,
+    });
+    expect(fallback.stale).toBe(true);
+    expect(fallback.data.map((quote) => quote.symbol)).toEqual(["AAPL", "MSFT"]);
+  });
+
   test("falls back to the secondary Yahoo host when the primary host fails", async () => {
     const requestedHosts: string[] = [];
     const userAgents: string[] = [];