gloomberb 0.10.4 → 0.11.0

package/src/plugins/builtin/fx-matrix/pane.test.tsx

@@ -0,0 +1,109 @@
+import { afterEach, describe, expect, test } from "bun:test";
+import { act } from "react";
+import { testRender } from "../../../renderers/opentui/test-utils";
+import {
+  MarketDataCoordinator,
+  setSharedMarketDataCoordinator,
+} from "../../../market-data/coordinator";
+import type { QueryEntry } from "../../../market-data/result-types";
+import { AppContext, createInitialState, PaneInstanceProvider } from "../../../state/app/context";
+import { createDefaultConfig } from "../../../types/config";
+import { PluginRenderProvider, type PluginRuntimeAccess } from "../../runtime";
+import { fxMatrixModule } from "./index";
+
+const FxMatrixPane = fxMatrixModule.panes![0]!.component as (props: {
+  paneId: string;
+  paneType: string;
+  focused: boolean;
+  width: number;
+  height: number;
+}) => React.ReactNode;
+
+function readyEntry(rate: number): QueryEntry<number> {
+  return {
+    phase: "ready",
+    data: rate,
+    lastGoodData: rate,
+    source: "test",
+    fetchedAt: 1,
+    staleAt: null,
+    error: null,
+    attempts: [],
+  };
+}
+
+function errorEntry(): QueryEntry<number> {
+  return {
+    phase: "error",
+    data: null,
+    lastGoodData: null,
+    source: "test",
+    fetchedAt: null,
+    staleAt: null,
+    error: { reasonCode: "upstream", message: "no rate" },
+    attempts: [],
+  };
+}
+
+/** Every currency resolves except JPY, which has no rate at all. */
+const RATES: Record<string, number> = { EUR: 1.08, GBP: 1.27, CHF: 1.12, CAD: 0.73, AUD: 0.65, NZD: 0.6 };
+
+function installCoordinator(): void {
+  setSharedMarketDataCoordinator({
+    subscribe: () => () => {},
+    subscribeKeys: () => () => {},
+    getVersion: () => 1,
+    getFxEntry: (currency: string) => (
+      RATES[currency] != null ? readyEntry(RATES[currency]!) : errorEntry()
+    ),
+    loadFxRate: async () => {},
+  } as unknown as MarketDataCoordinator);
+}
+
+function Harness() {
+  const state = createInitialState(createDefaultConfig("/tmp/gloomberb-fxc-pane-test"));
+  const runtime = { getMarketData: () => ({}) } as unknown as PluginRuntimeAccess;
+
+  return (
+    <AppContext value={{ state, dispatch: () => {} }}>
+      <PluginRenderProvider runtime={runtime} pluginId="market-overview">
+        <PaneInstanceProvider paneId="fx-matrix">
+          <FxMatrixPane paneId="fx-matrix" paneType="fx-matrix" focused width={100} height={14} />
+        </PaneInstanceProvider>
+      </PluginRenderProvider>
+    </AppContext>
+  );
+}
+
+let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
+
+afterEach(async () => {
+  if (testSetup) {
+    await act(async () => {
+      testSetup!.renderer.destroy();
+    });
+    testSetup = undefined;
+  }
+  setSharedMarketDataCoordinator(null);
+});
+
+describe("FxMatrixPane", () => {
+  test("renders a missing rate as unavailable instead of parity", async () => {
+    installCoordinator();
+    testSetup = await testRender(<Harness />, { width: 100, height: 14 });
+    await act(async () => {
+      await testSetup!.renderOnce();
+      await testSetup!.renderOnce();
+    });
+
+    const frame = testSetup.captureCharFrame();
+    // EUR/USD is a real cross built from the two USD legs.
+    expect(frame).toContain("1.0800");
+
+    // Regression: a currency with no rate rendered 1.0000 against everything.
+    const jpyRow = frame.split("\n").find((line) => line.trimStart().startsWith("JPY"));
+    expect(jpyRow).toBeDefined();
+    expect(jpyRow).not.toContain("1.0000");
+    expect(jpyRow).toContain("—");
+  });
+});

package/src/plugins/builtin/help/components.tsx

@@ -1,6 +1,6 @@
 import type { ReactNode } from "react";
 import { Box, Text, TextAttributes } from "../../../ui";
-import { colors, hoverBg } from "../../../theme/colors";
+import { colors } from "../../../theme/colors";
 import { t } from "../../../i18n";
 
 export interface HelpShortcutEntry {
@@ -48,35 +48,6 @@ export function HelpSection({ title, children }: { title: string; children: Reac
   );
 }
 
-export function ActionButton({
-  id,
-  label,
-  hovered,
-  onHover,
-  onPress,
-}: {
-  id: string;
-  label: string;
-  hovered: boolean;
-  onHover: (id: string | null) => void;
-  onPress: () => void;
-}) {
-  return (
-    <Box
-      backgroundColor={hovered ? hoverBg() : colors.panel}
-      onMouseOver={() => onHover(id)}
-      onMouseOut={() => onHover(null)}
-      onMouseDown={(event: any) => {
-        event.stopPropagation?.();
-        event.preventDefault?.();
-        onPress();
-      }}
-    >
-      <Text fg={hovered ? colors.textBright : colors.text}>{` ${t(label)} `}</Text>
-    </Box>
-  );
-}
-
 export function ShortcutGroup({ title, entries }: { title: string; entries: HelpShortcutEntry[] }) {
   return (
     <Box flexDirection="column" marginTop={1}>

package/src/plugins/builtin/help/index.tsx

@@ -1,7 +1,7 @@
 import { Box, ScrollBox, Text, useUiHost } from "../../../ui";
 import { TextAttributes } from "../../../ui";
 import { useState } from "react";
-import { Tabs } from "../../../components";
+import { Button, Tabs } from "../../../components";
 import { ExternalLinkText } from "../../../components/ui";
 import type { PaneProps } from "../../../types/plugin";
 import type { PluginModule } from "../plugin-module";
@@ -11,7 +11,6 @@ import { getSharedRegistry } from "../../registry";
 import { usePluginAppActions } from "../../runtime";
 import { detectShortcutPlatform, formatPrimaryShortcut, getShortcutDisplayMode } from "../../../utils/shortcut-labels";
 import {
-  ActionButton,
   HelpSection,
   ShortcutGroup,
   ShortcutRow,
@@ -31,13 +30,12 @@ const HELP_TABS = [
 ] as const;
 
 type HelpTabId = typeof HELP_TABS[number]["value"];
-const GLOOMBERB_ISSUES_URL = "https://github.com/vincelwt/gloomberb/issues";
+const GLOOMBERB_ISSUES_URL = "https://github.com/gloom-sh/gloomberb/issues";
 
 function HelpPane({ focused, width, height }: PaneProps) {
   const registry = getSharedRegistry();
   const { openCommandBar, showPane } = usePluginAppActions();
   const [activeTabId, setActiveTabId] = useState<HelpTabId>("basics");
-  const [hoveredAction, setHoveredAction] = useState<string | null>(null);
   const commandShortcuts = resolveCommandShortcuts(registry);
   const pluginShortcuts = resolvePluginShortcuts(registry);
   const windowTemplates = resolveWindowTemplates(registry);
@@ -75,13 +73,7 @@ function HelpPane({ focused, width, height }: PaneProps) {
         return (
           <>
             <Box flexDirection="row" gap={1}>
-              <ActionButton
-                id="plugins"
-                label="Manage Plugins"
-                hovered={hoveredAction === "plugins"}
-                onHover={setHoveredAction}
-                onPress={openPluginManager}
-              />
+              <Button label="Manage Plugins" onPress={openPluginManager} />
             </Box>
 
             <HelpSection title="Command Prefixes">
@@ -306,13 +298,7 @@ function HelpPane({ focused, width, height }: PaneProps) {
         return (
           <>
             <Box flexDirection="row" gap={1}>
-              <ActionButton
-                id="debug"
-                label="Open Debug Log"
-                hovered={hoveredAction === "debug"}
-                onHover={setHoveredAction}
-                onPress={openDebugLog}
-              />
+              <Button label="Open Debug Log" onPress={openDebugLog} />
               <ExternalLinkText
                 url={GLOOMBERB_ISSUES_URL}
                 label={t("GitHub Issues")}
@@ -339,13 +325,7 @@ function HelpPane({ focused, width, height }: PaneProps) {
             </Box>
 
             <Box flexDirection="row" gap={1}>
-              <ActionButton
-                id="layout"
-                label="Layout Actions"
-                hovered={hoveredAction === "layout"}
-                onHover={setHoveredAction}
-                onPress={openLayoutActions}
-              />
+              <Button label="Layout Actions" onPress={openLayoutActions} />
             </Box>
 
             <HelpSection title="Command Bar">

package/src/plugins/builtin/holders/pane.tsx

@@ -99,10 +99,12 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
     setSelectedId(sortedRows[0]?.id ?? null);
   }, [selectedId, sortedRows]);
 
+  // Keyed on the holder set itself: re-sorting or a ticking market cap must not
+  // restart 25 two-request 13F lookups.
   useEffect(() => {
     fundMatchAbortRef.current?.abort();
     setFundMatches(new Map());
-    if (sortedRows.length === 0) {
+    if (rows.length === 0) {
       setFundMatching(false);
       return;
     }
@@ -110,7 +112,7 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
     const controller = new AbortController();
     fundMatchAbortRef.current = controller;
     setFundMatching(true);
-    void loadHolder13FMatches(sortedRows, controller.signal)
+    void loadHolder13FMatches(rows, controller.signal)
       .then((matches) => {
         if (fundMatchAbortRef.current !== controller) return;
         setFundMatches(matches);
@@ -125,7 +127,7 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
         fundMatchAbortRef.current = null;
       }
     };
-  }, [sortedRows]);
+  }, [rows]);
 
   const selectedRow = activeIdx >= 0 ? sortedRows[activeIdx] ?? null : null;
   const selectedFundMatch = selectedRow ? fundMatches.get(selectedRow.id) ?? null : null;
@@ -169,7 +171,7 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
       toggleView();
       return true;
     }
-    if ((event.name === "f" || event.name === "enter" || event.name === "return") && selectedFundMatch) {
+    if ((event.name === "o" || event.name === "enter" || event.name === "return") && selectedFundMatch) {
       event.preventDefault?.();
       event.stopPropagation?.();
       openFundDetail(selectedRow);
@@ -208,7 +210,7 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
       toggleView();
       return;
     }
-    if (isPlainKey(event, "f", "enter", "return") && selectedFundMatch) {
+    if (isPlainKey(event, "o", "enter", "return") && selectedFundMatch) {
       event.preventDefault?.();
       event.stopPropagation?.();
       openFundDetail(selectedRow);
@@ -261,18 +263,20 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
         ...(fundMatching ? [{ id: "fund-matching", parts: [{ text: "13F matching", tone: "muted" as const }] }] : []),
       ],
       hints: [
-        { id: "refresh", key: "r", label: "efresh", onPress: refresh },
         { id: "view", key: "s", label: "witch", onPress: toggleView },
-        ...(selectedFundMatch ? [{ id: "fund", key: "f", label: "und", onPress: () => openFundDetail(selectedRow) }] : []),
+        // `f` is the filter key in sibling panes, so opening a fund uses `o`.
+        ...(selectedFundMatch ? [{ id: "fund", key: "o", label: "pen 13F", onPress: () => openFundDetail(selectedRow) }] : []),
       ],
     };
-  }, [data?.asOf, fundMatching, loading, openFundDetail, refresh, selectedFundMatch, selectedRow, toggleView]);
+  }, [data?.asOf, fundMatching, loading, openFundDetail, selectedFundMatch, selectedRow, toggleView]);
 
-  const emptyTitle = !symbol
-    ? "No ticker selected"
+  // Both views share one status; the treemap must not claim "no chartable
+  // values" while the request is still in flight or the pane has no ticker.
+  const statusTitle = !symbol
+    ? "No ticker selected."
     : loading
       ? "Loading holders..."
-      : error ?? "No holders available";
+      : error ?? (sortedRows.length === 0 ? "No holders available" : null);
   const chartHeight = Math.max(1, height - 1 - (nativePaneChrome ? 1 : 0));
 
   return (
@@ -308,11 +312,12 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
           onHeaderClick={handleHeaderClick}
           getItemKey={(row) => row.id}
           renderCell={renderCell}
-          emptyStateTitle={emptyTitle}
+          emptyStateTitle={statusTitle ?? "No holders available"}
         />
       ) : (
         <HoldersTreemap
           rows={sortedRows}
+          emptyStateTitle={statusTitle ?? undefined}
           width={width}
           height={chartHeight}
           selectedId={selectedId}

package/src/plugins/builtin/holders/treemap.tsx

@@ -8,7 +8,7 @@ import {
 } from "./format";
 import type { HolderRow } from "./types";
 
-export function HoldersTreemap({ rows, width, height, selectedId, onSelect, onActivate, currency, marketCap }: {
+export function HoldersTreemap({ rows, width, height, selectedId, onSelect, onActivate, currency, marketCap, emptyStateTitle }: {
   rows: HolderRow[];
   width: number;
   height: number;
@@ -17,6 +17,8 @@ export function HoldersTreemap({ rows, width, height, selectedId, onSelect, onAc
   onActivate?: (row: HolderRow) => void;
   currency: string;
   marketCap?: number;
+  /** Loading, error, and no-ticker states the pane resolves for both views. */
+  emptyStateTitle?: string;
 }) {
   const items = useMemo<Array<MetricTreemapItem<HolderRow>>>(() => rows.map((row) => {
     const ownership = formatHolderOwnershipLine(row, marketCap);
@@ -43,7 +45,7 @@ export function HoldersTreemap({ rows, width, height, selectedId, onSelect, onAc
       selectedId={selectedId}
       onSelect={(item) => onSelect(item.data)}
       onActivate={onActivate ? (item) => onActivate(item.data) : undefined}
-      emptyStateTitle="No chartable holder values"
+      emptyStateTitle={emptyStateTitle ?? "No chartable holder values"}
     />
   );
 }

package/src/plugins/builtin/insider/index.tsx

@@ -1,4 +1,3 @@
-import { Text } from "../../../ui";
 import { useCallback, useMemo, useState } from "react";
 import type { PluginModule } from "../plugin-module";
 import type { SecFilingItem } from "../../../types/data-provider";
@@ -8,8 +7,7 @@ import {
 } from "../../../market-data/hooks";
 import { instrumentFromTicker } from "../../../market-data/request-types";
 import { usePaneTicker } from "../../../state/app/context";
-import { colors } from "../../../theme/colors";
-import { FeedDataTableStackView, Spinner, useExternalLinkFooter, type FeedDataTableItem } from "../../../components";
+import { EmptyState, FeedDataTableStackView, Spinner, useExternalLinkFooter, type FeedDataTableItem } from "../../../components";
 import { usePluginPaneState } from "../../runtime";
 import { isUsEquityTicker } from "../../../utils/sec";
 import { formatCompact, formatCurrency } from "../../../utils/format";
@@ -26,6 +24,10 @@ import {
 import { useSecFilingContentCache } from "../sec/filing-content";
 
 const FORM4_LIMIT = 20;
+// SEC returns one recent-submissions payload per company, so scanning deep for
+// Form 4s costs no extra request; filtering the newest 20 filings of any form
+// hides insider activity behind a burst of 8-Ks.
+const SEC_FILING_SCAN_LIMIT = 300;
 const NINETY_DAYS_MS = 90 * 24 * 60 * 60 * 1000;
 
 interface ParsedFiling {
@@ -34,7 +36,9 @@ interface ParsedFiling {
   isLoading: boolean;
 }
 
-function buildSummary(parsed: ParsedFiling[]): string {
+/** Null while filings are still parsing, so the pane never claims "no activity" early. */
+function buildSummary(parsed: ParsedFiling[]): string | null {
+  if (parsed.some(({ isLoading }) => isLoading)) return null;
   const cutoff = new Date(Date.now() - NINETY_DAYS_MS);
   let buyShares = 0;
   let sellShares = 0;
@@ -109,11 +113,11 @@ function InsiderView({ width, height, focused }: { width: number; height: number
   const instrument = instrumentFromTicker(ticker, ticker?.metadata.ticker ?? null);
 
   const filingsEntry = useSecFilingsQuery(
-    instrument && eligibleTicker ? { instrument, count: FORM4_LIMIT } : null,
+    instrument && eligibleTicker ? { instrument, count: SEC_FILING_SCAN_LIMIT } : null,
   );
   const allFilings = useResolvedEntryValue(filingsEntry) ?? [];
   const form4Filings = useMemo(
-    () => allFilings.filter((f) => f.form.trim() === "4"),
+    () => allFilings.filter((f) => f.form.trim() === "4").slice(0, FORM4_LIMIT),
     [allFilings],
   );
 
@@ -178,7 +182,7 @@ function InsiderView({ width, height, focused }: { width: number; height: number
   const selectedFilterName = selectedTransaction?.reportedName ?? null;
   const pendingLabel = pendingCount > 0 ? `loading ${pendingCount}...` : "";
   const footerInfo = useMemo(() => [
-    { id: "summary", parts: [{ text: truncateText(summary, Math.max(24, width - 20)), tone: "muted" as const }] },
+    ...(summary ? [{ id: "summary", parts: [{ text: truncateText(summary, Math.max(24, width - 20)), tone: "muted" as const }] }] : []),
     ...(nameFilter ? [{ id: "filter", parts: [{ text: `filter: ${truncateText(nameFilter, 24)}`, tone: "warning" as const }] }] : []),
     ...(pendingLabel ? [{ id: "pending", parts: [{ text: pendingLabel, tone: "muted" as const }] }] : []),
   ], [nameFilter, pendingLabel, summary, width]);
@@ -205,10 +209,12 @@ function InsiderView({ width, height, focused }: { width: number; height: number
     label: "filing",
   });
 
-  if (!ticker) return <Text fg={colors.textDim}>Select a ticker to view insider activity.</Text>;
+  if (!ticker) {
+    return <EmptyState title="No ticker selected." message="Select a ticker to view insider activity." />;
+  }
   if (!eligibleTicker) return renderFilingNotice("Insider transactions are only shown for US equities.", width);
   if (loading && allFilings.length === 0) return <Spinner label="Loading insider filings..." />;
-  if (error) return renderFilingNotice(`Error: ${error}`, width);
+  if (error) return <EmptyState title="Insider filings unavailable." message={error} />;
   if (!loading && form4Filings.length === 0) {
     return renderFilingNotice(`No Form 4 filings found for ${ticker.metadata.ticker}.`, width);
   }
@@ -225,7 +231,11 @@ function InsiderView({ width, height, focused }: { width: number; height: number
       onRootKeyDown={handleRootKeyDown}
       sourceLabel="Insider"
       titleLabel="Transaction"
-      emptyStateTitle={nameFilter ? "No insider transactions for this filter." : "No insider transactions."}
+      emptyStateTitle={nameFilter
+        ? "No insider transactions for this filter."
+        : pendingCount > 0
+          ? "Loading Form 4 transactions..."
+          : "No insider transactions."}
     />
   );
 }

package/src/plugins/builtin/ipo-calendar/cache.ts

@@ -0,0 +1,101 @@
+import type { PluginPersistence } from "../../../types/plugin";
+import { fetchIpoCalendar, type IpoCalendarFetchResult } from "./client";
+import type { IPORecord } from "./types";
+
+const CACHE_KIND = "ipo-calendar";
+const CACHE_KEY = "board";
+const CACHE_SOURCE = "stockanalysis";
+const CACHE_SCHEMA_VERSION = 1;
+/**
+ * The board moves on pricing days, not minutes, so a quarter hour of freshness
+ * is enough; the week-long expiry is what keeps an offline start usable.
+ */
+const CACHE_POLICY = {
+  staleMs: 15 * 60 * 1000,
+  expireMs: 7 * 24 * 60 * 60 * 1000,
+} as const;
+
+type PersistedIPORecord = Omit<IPORecord, "date"> & { date: string };
+
+export interface IpoCalendarResult {
+  records: IPORecord[];
+  fetchedAt: number;
+  /** True when the network failed and cached records were served instead. */
+  stale: boolean;
+  /** Endpoints that failed while others succeeded. */
+  errors: string[];
+}
+
+let persistence: PluginPersistence | null = null;
+let activeFetch: Promise<IpoCalendarResult> | null = null;
+
+export function attachIpoCalendarPersistence(next: PluginPersistence): void {
+  persistence = next;
+}
+
+export function resetIpoCalendarPersistence(): void {
+  persistence = null;
+  activeFetch = null;
+}
+
+function readCache(options?: { allowExpired?: boolean }): IpoCalendarResult | null {
+  const record = persistence?.getResource<PersistedIPORecord[]>(CACHE_KIND, CACHE_KEY, {
+    sourceKey: CACHE_SOURCE,
+    schemaVersion: CACHE_SCHEMA_VERSION,
+    allowExpired: options?.allowExpired,
+  });
+  if (!record || !Array.isArray(record.value)) return null;
+  const records = record.value
+    .map((entry) => ({ ...entry, date: new Date(entry.date) }))
+    .filter((entry) => !Number.isNaN(entry.date.getTime()));
+  return { records, fetchedAt: record.fetchedAt, stale: !!record.stale, errors: [] };
+}
+
+export function getCachedIpoCalendar(): IpoCalendarResult | null {
+  return readCache({ allowExpired: true });
+}
+
+/**
+ * Serves fresh cache without a request, shares one in-flight fetch across
+ * panes, and falls back to whatever is cached when Stock Analysis is
+ * unreachable. A partial scrape is cached but keeps its errors so the pane can
+ * say so rather than presenting half a board as the whole one.
+ */
+export async function loadIpoCalendar(
+  force = false,
+  loader: () => Promise<IpoCalendarFetchResult> = fetchIpoCalendar,
+): Promise<IpoCalendarResult> {
+  const cached = readCache();
+  if (!force && cached && !cached.stale) return cached;
+  if (activeFetch) return activeFetch;
+
+  const fallback = cached ?? readCache({ allowExpired: true });
+  activeFetch = loader()
+    .then(({ records, errors }) => {
+      if (records.length === 0) {
+        if (fallback) return { ...fallback, stale: true, errors };
+        throw new Error(errors.join("; ") || "Stock Analysis returned no IPOs");
+      }
+      persistence?.setResource(
+        CACHE_KIND,
+        CACHE_KEY,
+        records.map((record) => ({ ...record, date: record.date.toISOString() })),
+        { sourceKey: CACHE_SOURCE, schemaVersion: CACHE_SCHEMA_VERSION, cachePolicy: CACHE_POLICY },
+      );
+      return { records, fetchedAt: Date.now(), stale: false, errors };
+    })
+    .catch((error: unknown) => {
+      if (fallback) {
+        return {
+          ...fallback,
+          stale: true,
+          errors: [error instanceof Error ? error.message : String(error)],
+        };
+      }
+      throw error;
+    })
+    .finally(() => {
+      activeFetch = null;
+    });
+  return activeFetch;
+}

package/src/plugins/builtin/ipo-calendar/client.test.ts

@@ -0,0 +1,31 @@
+import { describe, expect, test } from "bun:test";
+import { getFlatData } from "./client";
+
+describe("getFlatData", () => {
+  test("selects the node with IPO records, not the first object-shaped node", () => {
+    const payload = {
+      nodes: [
+        {
+          data: [
+            { session: "abc", user: null },
+            { cookie: "x" },
+          ],
+        },
+        { type: "skip" },
+        {
+          data: [
+            { type: "root" },
+            { s: "AAAA", n: "Alpha", ipoDate: "2026-08-13" },
+            { s: "BBBB", n: "Beta", ipoDate: "2026-08-20" },
+          ],
+        },
+      ],
+    };
+
+    const flat = getFlatData(payload);
+    expect(flat).not.toBeNull();
+    expect(flat).toHaveLength(3);
+    expect(flat?.[1]).toEqual({ s: "AAAA", n: "Alpha", ipoDate: "2026-08-13" });
+    expect(flat?.[2]).toEqual({ s: "BBBB", n: "Beta", ipoDate: "2026-08-20" });
+  });
+});