gitspace 0.2.0-rc.20 → 0.2.0-rc.21

package/src/core/review-executor.ts

@@ -1,316 +0,0 @@
-/**
- * Local review operation executor.
- *
- * Shared by LocalSessionBackend (direct filesystem access) and
- * RemoteSessionHandler (over encrypted WebSocket). Implements all
- * ReviewOperation variants using the core review and git modules.
- */
-
-import {
-  getThreads,
-  createThread,
-  addReply,
-  updateThread,
-  updateComment,
-  deleteComment,
-  detectPRNumber,
-} from './review.js';
-import {
-  getWorkspaceChangedFiles,
-  getWorkspaceDiff,
-  getWorkspaceFileContextRange,
-  getWorkspaceFileDiff,
-  getWorkspaceFileVersions,
-} from './git.js';
-import { importGitHubReview, pushGitHubReview } from './github-review.js';
-import { readProjectConfig } from './config.js';
-import { scanWorkspaces } from '../lib/remote-session/workspace-scanner.js';
-import type { ReviewOperation, ReviewResult } from '../types/review.js';
-import { matchesWorkspaceId } from '../utils/workspace-id.js';
-
-type ScanWorkspacesFn = typeof scanWorkspaces;
-
-async function resolveWorkspaceByName(
-  projectName: string,
-  workspaceName: string,
-  scan: ScanWorkspacesFn
-): Promise<{ id: string; path: string; baseBranch: string }> {
-  const workspaces = await scan();
-  const workspace = workspaces.find(
-    (w) => w.projectName === projectName && matchesWorkspaceId(w, workspaceName)
-  );
-
-  if (!workspace) {
-    throw new Error(`Workspace not found: ${projectName}:${workspaceName}`);
-  }
-
-  let baseBranch = 'main';
-  try {
-    const projectConfig = readProjectConfig(projectName);
-    baseBranch = projectConfig.baseBranch ?? 'main';
-  } catch {
-    // Fall back to 'main'
-  }
-
-  return { id: workspace.id, path: workspace.path, baseBranch };
-}
-
-/**
- * Execute a ReviewOperation with direct filesystem access.
- *
- * @param operation - The operation to execute
- * @param scan - scanWorkspaces implementation (injectable for testing)
- */
-export async function executeLocalReviewOperation(
-  operation: ReviewOperation,
-  scan: ScanWorkspacesFn = scanWorkspaces
-): Promise<ReviewResult> {
-  switch (operation.op) {
-    case 'get_threads': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const threads = getThreads(workspace.path, workspace.id, workspace.baseBranch);
-      return { op: 'threads', threads };
-    }
-
-    case 'create_thread': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const thread = await createThread(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        operation.target,
-        operation.body,
-        operation.decision
-      );
-      return { op: 'thread_created', thread };
-    }
-
-    case 'add_reply': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const thread = addReply(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        operation.threadId,
-        operation.body
-      );
-      return { op: 'comment_added', thread };
-    }
-
-    case 'update_thread': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const thread = updateThread(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        operation.threadId,
-        { resolved: operation.resolved, decision: operation.decision }
-      );
-      return { op: 'thread_updated', thread };
-    }
-
-    case 'update_comment': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const thread = updateComment(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        operation.threadId,
-        operation.commentId,
-        operation.body
-      );
-      return { op: 'comment_updated', thread };
-    }
-
-    case 'delete_comment': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const thread = deleteComment(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        operation.threadId,
-        operation.commentId
-      );
-      return {
-        op: 'comment_deleted',
-        thread,
-      };
-    }
-
-    case 'get_diff': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const diffResult = await getWorkspaceDiff(workspace.path, workspace.baseBranch);
-      return {
-        op: 'diff',
-        diff: diffResult.diff,
-        baseBranch: diffResult.baseBranch,
-        headBranch: diffResult.headBranch,
-      };
-    }
-
-    case 'get_changed_files': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const changed = await getWorkspaceChangedFiles(workspace.path, workspace.baseBranch);
-      return {
-        op: 'changed_files',
-        files: changed.files,
-        baseBranch: changed.baseBranch,
-        headBranch: changed.headBranch,
-      };
-    }
-
-    case 'get_file_diff': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const result = await getWorkspaceFileDiff(
-        workspace.path,
-        workspace.baseBranch,
-        operation.filePath,
-        operation.prevFilePath
-      );
-      return {
-        op: 'file_diff',
-        filePath: operation.filePath,
-        prevFilePath: operation.prevFilePath,
-        diff: result.diff,
-      };
-    }
-
-    case 'get_file_versions': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const { oldContents, newContents } = await getWorkspaceFileVersions(
-        workspace.path,
-        workspace.baseBranch,
-        operation.filePath,
-        operation.prevFilePath
-      );
-      return {
-        op: 'file_versions',
-        filePath: operation.filePath,
-        prevFilePath: operation.prevFilePath,
-        oldContents,
-        newContents,
-      };
-    }
-
-    case 'get_file_context_range': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const result = await getWorkspaceFileContextRange(
-        workspace.path,
-        workspace.baseBranch,
-        operation.filePath,
-        operation.prevFilePath,
-        {
-          oldStart: operation.oldStart,
-          oldEnd: operation.oldEnd,
-          newStart: operation.newStart,
-          newEnd: operation.newEnd,
-        }
-      );
-
-      return {
-        op: 'file_context_range',
-        filePath: operation.filePath,
-        prevFilePath: operation.prevFilePath,
-        oldStart: result.oldStart,
-        oldLines: result.oldLines,
-        oldTotal: result.oldTotal,
-        newStart: result.newStart,
-        newLines: result.newLines,
-        newTotal: result.newTotal,
-      };
-    }
-
-    case 'import_github': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const prNumber =
-        operation.prNumber ?? (await detectPRNumber(workspace.path)) ?? null;
-      if (!prNumber) {
-        throw new Error(
-          'Could not determine PR number. Pass prNumber explicitly or ensure the branch has an open PR.'
-        );
-      }
-      const { imported, threads } = await importGitHubReview(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        prNumber
-      );
-      return { op: 'github_imported', imported, threads };
-    }
-
-    case 'push_github': {
-      const workspace = await resolveWorkspaceByName(
-        operation.projectName,
-        operation.workspaceName,
-        scan
-      );
-      const prNumber =
-        operation.prNumber ?? (await detectPRNumber(workspace.path)) ?? null;
-      if (!prNumber) {
-        throw new Error(
-          'Could not determine PR number. Pass prNumber explicitly or ensure the branch has an open PR.'
-        );
-      }
-      const { url } = await pushGitHubReview(
-        workspace.path,
-        workspace.id,
-        workspace.baseBranch,
-        prNumber
-      );
-      return { op: 'github_pushed', prNumber, url };
-    }
-
-    default: {
-      const unknown = operation as { op: string };
-      throw new Error(`Unknown review operation: ${unknown.op}`);
-    }
-  }
-}

package/src/core/review.ts

@@ -1,407 +0,0 @@
-/**
- * Core review operations
- *
- * Manages ReviewThread storage in <workspace>/.gitspace/review/<workspaceName>/notes.json
- * Threads are namespaced by workspace name so that workspaces branched from each
- * other don't share the same thread store.
- */
-
-import { existsSync, readFileSync, writeFileSync, mkdirSync, appendFileSync } from 'fs';
-import { join, dirname } from 'path';
-import { exec } from 'child_process';
-import { promisify } from 'util';
-import type {
-  ReviewSession,
-  ReviewThread,
-  ReviewComment,
-  ThreadTarget,
-  HunkDecision,
-} from '../types/review.js';
-import { generateId } from '../utils/id.js';
-import { SpacesError } from '../types/errors.js';
-import { logger } from '../utils/logger.js';
-
-const execAsync = promisify(exec);
-
-// ============================================================================
-// Path Helpers
-// ============================================================================
-
-/**
- * Returns the directory where review notes are stored for this workspace.
- * Path: <workspacePath>/.gitspace/review/<workspaceName>/
- */
-function getReviewDir(workspacePath: string, workspaceName: string): string {
-  return join(workspacePath, '.gitspace', 'review', workspaceName);
-}
-
-/**
- * Returns the path to the notes.json file for this workspace.
- */
-function getNotesPath(workspacePath: string, workspaceName: string): string {
-  return join(getReviewDir(workspacePath, workspaceName), 'notes.json');
-}
-
-// ============================================================================
-// Session Read / Write
-// ============================================================================
-
-/**
- * Read the review session from disk. Returns a fresh session if none exists.
- */
-export function readReviewSession(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string
-): ReviewSession {
-  const notesPath = getNotesPath(workspacePath, workspaceName);
-
-  if (!existsSync(notesPath)) {
-    return createEmptySession(workspaceName, baseBranch);
-  }
-
-  try {
-    const raw = readFileSync(notesPath, 'utf-8');
-    const parsed = JSON.parse(raw) as ReviewSession;
-    return parsed;
-  } catch (error) {
-    const code =
-      typeof error === 'object' && error !== null && 'code' in error
-        ? String((error as { code?: unknown }).code)
-        : undefined;
-
-    if (code === 'ENOENT') {
-      return createEmptySession(workspaceName, baseBranch);
-    }
-
-    const message = error instanceof Error ? error.message : String(error);
-
-    if (error instanceof SyntaxError) {
-      logger.error(`Failed to parse review notes at ${notesPath}: ${message}`);
-      throw new SpacesError(`Corrupted review notes at ${notesPath}: ${message}`, 'USER_ERROR', 1);
-    }
-
-    logger.error(`Failed to read review notes at ${notesPath}: ${message}`);
-    if (error instanceof Error) {
-      throw error;
-    }
-
-    throw new SpacesError(`Failed to read review notes at ${notesPath}: ${message}`, 'SYSTEM_ERROR', 2);
-  }
-}
-
-/**
- * Write the review session to disk, creating directories as needed.
- */
-export function writeReviewSession(
-  workspacePath: string,
-  workspaceName: string,
-  session: ReviewSession
-): void {
-  const notesPath = getNotesPath(workspacePath, workspaceName);
-  const dir = dirname(notesPath);
-
-  if (!existsSync(dir)) {
-    mkdirSync(dir, { recursive: true });
-  }
-
-  const updated: ReviewSession = {
-    ...session,
-    updatedAt: new Date().toISOString(),
-  };
-
-  writeFileSync(notesPath, JSON.stringify(updated, null, 2), 'utf-8');
-}
-
-function createEmptySession(workspaceName: string, baseBranch: string): ReviewSession {
-  const now = new Date().toISOString();
-  return {
-    version: '1.0',
-    workspaceName,
-    baseBranch,
-    prNumber: null,
-    threads: [],
-    createdAt: now,
-    updatedAt: now,
-  };
-}
-
-// ============================================================================
-// Thread CRUD
-// ============================================================================
-
-/**
- * Get all threads for a workspace.
- */
-export function getThreads(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string
-): ReviewThread[] {
-  return readReviewSession(workspacePath, workspaceName, baseBranch).threads;
-}
-
-/**
- * Create a new thread with an initial comment.
- */
-export async function createThread(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string,
-  target: ThreadTarget,
-  body: string,
-  decision?: HunkDecision,
-  author = 'local'
-): Promise<ReviewThread> {
-  // Ensure .gitignore decision is handled before reading/writing session state so
-  // concurrent CRUD writes cannot be overwritten after an async gap.
-  await ensureGitignore(workspacePath, workspaceName);
-
-  const session = readReviewSession(workspacePath, workspaceName, baseBranch);
-  const now = new Date().toISOString();
-
-  const threadId = generateId();
-  const commentId = generateId();
-
-  const comment: ReviewComment = {
-    id: commentId,
-    threadId,
-    body,
-    author,
-    createdAt: now,
-  };
-
-  const thread: ReviewThread = {
-    id: threadId,
-    target,
-    decision: target.kind === 'hunk' ? (decision ?? 'pending') : undefined,
-    resolved: false,
-    comments: [comment],
-    createdAt: now,
-    updatedAt: now,
-  };
-
-  session.threads.push(thread);
-
-  writeReviewSession(workspacePath, workspaceName, session);
-  return thread;
-}
-
-/**
- * Add a reply to an existing thread.
- */
-export function addReply(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string,
-  threadId: string,
-  body: string,
-  author = 'local'
-): ReviewThread {
-  const session = readReviewSession(workspacePath, workspaceName, baseBranch);
-  const thread = session.threads.find(t => t.id === threadId);
-
-  if (!thread) {
-    throw new SpacesError(`Thread not found: ${threadId}`, 'USER_ERROR', 1);
-  }
-
-  const now = new Date().toISOString();
-  const comment: ReviewComment = {
-    id: generateId(),
-    threadId,
-    body,
-    author,
-    createdAt: now,
-  };
-
-  thread.comments.push(comment);
-  thread.updatedAt = now;
-
-  writeReviewSession(workspacePath, workspaceName, session);
-  return thread;
-}
-
-/**
- * Update a thread's resolved status or hunk decision.
- */
-export function updateThread(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string,
-  threadId: string,
-  updates: { resolved?: boolean; decision?: HunkDecision }
-): ReviewThread {
-  const session = readReviewSession(workspacePath, workspaceName, baseBranch);
-  const thread = session.threads.find(t => t.id === threadId);
-
-  if (!thread) {
-    throw new SpacesError(`Thread not found: ${threadId}`, 'USER_ERROR', 1);
-  }
-
-  if (updates.resolved !== undefined) {
-    thread.resolved = updates.resolved;
-  }
-
-  if (updates.decision !== undefined && thread.target.kind === 'hunk') {
-    thread.decision = updates.decision;
-  }
-
-  thread.updatedAt = new Date().toISOString();
-
-  writeReviewSession(workspacePath, workspaceName, session);
-  return thread;
-}
-
-/**
- * Update the body of a specific comment in a thread.
- */
-export function updateComment(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string,
-  threadId: string,
-  commentId: string,
-  body: string
-): ReviewThread {
-  const session = readReviewSession(workspacePath, workspaceName, baseBranch);
-  const thread = session.threads.find(t => t.id === threadId);
-
-  if (!thread) {
-    throw new SpacesError(`Thread not found: ${threadId}`, 'USER_ERROR', 1);
-  }
-
-  const comment = thread.comments.find(c => c.id === commentId);
-  if (!comment) {
-    throw new SpacesError(`Comment not found: ${commentId}`, 'USER_ERROR', 1);
-  }
-
-  comment.body = body;
-  thread.updatedAt = new Date().toISOString();
-
-  writeReviewSession(workspacePath, workspaceName, session);
-  return thread;
-}
-
-/**
- * Delete a specific comment from a thread.
- * If it's the only comment in the thread, the thread itself is deleted.
- * Returns the updated thread snapshot. If the last comment is deleted,
- * the returned thread keeps its original target metadata and has comments: [].
- */
-export function deleteComment(
-  workspacePath: string,
-  workspaceName: string,
-  baseBranch: string,
-  threadId: string,
-  commentId: string
-): ReviewThread {
-  const session = readReviewSession(workspacePath, workspaceName, baseBranch);
-  const threadIndex = session.threads.findIndex(t => t.id === threadId);
-
-  if (threadIndex === -1) {
-    throw new SpacesError(`Thread not found: ${threadId}`, 'USER_ERROR', 1);
-  }
-
-  const thread = session.threads[threadIndex];
-  const commentIndex = thread.comments.findIndex(c => c.id === commentId);
-
-  if (commentIndex === -1) {
-    throw new SpacesError(`Comment not found: ${commentId}`, 'USER_ERROR', 1);
-  }
-
-  thread.comments.splice(commentIndex, 1);
-  thread.updatedAt = new Date().toISOString();
-
-  // If no comments remain, delete the whole thread
-  if (thread.comments.length === 0) {
-    session.threads.splice(threadIndex, 1);
-    writeReviewSession(workspacePath, workspaceName, session);
-    return thread;
-  }
-
-  writeReviewSession(workspacePath, workspaceName, session);
-  return thread;
-}
-
-// ============================================================================
-// .gitignore Management
-// ============================================================================
-
-const GITIGNORE_ENTRY = '.gitspace/review/';
-const GITIGNORE_MARKER = '# gssh review — workspace review notes';
-
-/**
- * Ensure that .gitspace/review/ is handled appropriately in .gitignore.
- * On first note creation, prompts the user whether to gitignore or commit.
- * Remembers the choice in a local marker file so it's not asked again.
- */
-async function ensureGitignore(workspacePath: string, workspaceName: string): Promise<void> {
-  const reviewDir = getReviewDir(workspacePath, workspaceName);
-  const markerPath = join(reviewDir, '.gitignore-decided');
-
-  // Already decided — skip
-  if (existsSync(markerPath)) return;
-
-  const gitignorePath = join(workspacePath, '.gitignore');
-  const alreadyIgnored =
-    existsSync(gitignorePath) &&
-    readFileSync(gitignorePath, 'utf-8').includes(GITIGNORE_ENTRY);
-
-  if (alreadyIgnored) {
-    // Already ignored — write marker and return
-    mkdirSync(dirname(markerPath), { recursive: true });
-    writeFileSync(markerPath, 'gitignored\n', 'utf-8');
-    return;
-  }
-
-  let keepPrivate = true;
-
-  // Only prompt when running interactively (stdin is a TTY).
-  // When called from the serve daemon there is no TTY, so we silently
-  // default to keeping notes private.
-  const isTTY = Boolean(process.stdin.isTTY);
-  if (isTTY) {
-    try {
-      const { confirm } = await import('@inquirer/prompts');
-      keepPrivate = await confirm({
-        message:
-          'Review notes found. Keep them private (add to .gitignore) or share with the team (commit alongside branch)?',
-        default: true,
-      });
-    } catch {
-      // Prompt cancelled or non-interactive — default to private
-      keepPrivate = true;
-    }
-  }
-
-  if (keepPrivate) {
-    appendFileSync(
-      gitignorePath,
-      `\n${GITIGNORE_MARKER}\n${GITIGNORE_ENTRY}\n`,
-      'utf-8'
-    );
-  }
-
-  mkdirSync(dirname(markerPath), { recursive: true });
-  writeFileSync(markerPath, keepPrivate ? 'gitignored\n' : 'committed\n', 'utf-8');
-}
-
-// ============================================================================
-// Workspace Detection
-// ============================================================================
-
-/**
- * Detect the PR number associated with the current workspace branch
- * by using `gh pr view`.
- */
-export async function detectPRNumber(workspacePath: string): Promise<number | null> {
-  try {
-    const { stdout } = await execAsync('gh pr view --json number --jq .number', {
-      cwd: workspacePath,
-    });
-    const num = parseInt(stdout.trim(), 10);
-    return isNaN(num) ? null : num;
-  } catch {
-    return null;
-  }
-}