gitspace 0.2.0-rc.20 → 0.2.0-rc.21

package/src/notifications/index.ts

@@ -1,32 +0,0 @@
-/**
- * Shared notifications module
- *
- * Provides types, policy logic, and hooks for notification handling
- * across TUI and Web platforms.
- */
-
-// Types
-export type {
-  NotificationConfig,
-  ToastNotification,
-  InboxDiff,
-} from './types.js';
-export { DEFAULT_NOTIFICATION_CONFIG } from './types.js';
-
-// Policy functions
-export {
-  isNotificationTypeEnabled,
-  filterByConfig,
-  diffInbox,
-  itemToToast,
-  getToastableItems,
-  getMostRecentUnread,
-  getSessionLabel,
-} from './policy.js';
-
-// Hook
-export type {
-  UseNotificationsOptions,
-  UseNotificationsReturn,
-} from './useNotifications.js';
-export { useNotifications } from './useNotifications.js';

package/src/notifications/policy.test.ts

@@ -1,424 +0,0 @@
-import { describe, expect, it } from 'bun:test';
-import {
-  isNotificationTypeEnabled,
-  filterByConfig,
-  diffInbox,
-  itemToToast,
-  getToastableItems,
-  getMostRecentUnread,
-  getSessionLabel,
-} from './policy';
-import type { NotificationConfig } from './types';
-import type { InboxItem } from '../lib/remote-session/protocol';
-
-// ============================================================================
-// Test Fixtures
-// ============================================================================
-
-function createInboxItem(overrides: Partial<InboxItem> = {}): InboxItem {
-  return {
-    id: 'test-id-1',
-    sessionId: 'session-1',
-    sessionName: 'my-project:my-workspace:default',
-    type: 'exit',
-    timestamp: Date.now(),
-    read: false,
-    context: 'Command completed',
-    processTitle: 'npm test',
-    exitCode: 0,
-    ...overrides,
-  };
-}
-
-function createConfig(overrides: Partial<NotificationConfig> = {}): NotificationConfig {
-  return {
-    enabled: true,
-    minCommandDurationMs: 10000,
-    types: {
-      exit: true,
-      idle: true,
-      bell: true,
-      title: true,
-      osc: true,
-    },
-    toast: {
-      enabled: true,
-      holdWhenIdleMs: 15000,
-    },
-    ...overrides,
-  };
-}
-
-// ============================================================================
-// isNotificationTypeEnabled
-// ============================================================================
-
-describe('isNotificationTypeEnabled', () => {
-  it('should return false when notifications are disabled globally', () => {
-    const config = createConfig({ enabled: false });
-    expect(isNotificationTypeEnabled('exit', config)).toBe(false);
-    expect(isNotificationTypeEnabled('bell', config)).toBe(false);
-  });
-
-  it('should return true for enabled notification types', () => {
-    const config = createConfig();
-    expect(isNotificationTypeEnabled('exit', config)).toBe(true);
-    expect(isNotificationTypeEnabled('idle', config)).toBe(true);
-    expect(isNotificationTypeEnabled('bell', config)).toBe(true);
-    expect(isNotificationTypeEnabled('title', config)).toBe(true);
-    expect(isNotificationTypeEnabled('osc', config)).toBe(true);
-  });
-
-  it('should return false for disabled notification types', () => {
-    const config = createConfig({
-      types: { exit: false, idle: false, bell: true, title: true, osc: false },
-    });
-    expect(isNotificationTypeEnabled('exit', config)).toBe(false);
-    expect(isNotificationTypeEnabled('idle', config)).toBe(false);
-    expect(isNotificationTypeEnabled('osc', config)).toBe(false);
-    expect(isNotificationTypeEnabled('bell', config)).toBe(true);
-  });
-
-  it('should handle unknown types by checking osc setting', () => {
-    const configOscOn = createConfig({ types: { exit: true, idle: true, bell: true, title: true, osc: true } });
-    const configOscOff = createConfig({ types: { exit: true, idle: true, bell: true, title: true, osc: false } });
-
-    // Unknown types fall through to osc check
-    expect(isNotificationTypeEnabled('unknown' as any, configOscOn)).toBe(true);
-    expect(isNotificationTypeEnabled('unknown' as any, configOscOff)).toBe(false);
-  });
-});
-
-// ============================================================================
-// filterByConfig
-// ============================================================================
-
-describe('filterByConfig', () => {
-  it('should return empty array when notifications disabled', () => {
-    const items = [createInboxItem({ type: 'exit' }), createInboxItem({ type: 'bell' })];
-    const config = createConfig({ enabled: false });
-
-    expect(filterByConfig(items, config)).toEqual([]);
-  });
-
-  it('should filter out disabled notification types', () => {
-    const exitItem = createInboxItem({ id: '1', type: 'exit' });
-    const bellItem = createInboxItem({ id: '2', type: 'bell' });
-    const idleItem = createInboxItem({ id: '3', type: 'idle' });
-
-    const items = [exitItem, bellItem, idleItem];
-    const config = createConfig({
-      types: { exit: true, idle: false, bell: true, title: true, osc: true },
-    });
-
-    const result = filterByConfig(items, config);
-    expect(result).toHaveLength(2);
-    expect(result.map((i) => i.id)).toEqual(['1', '2']);
-  });
-
-  it('should return all items when all types enabled', () => {
-    const items = [
-      createInboxItem({ id: '1', type: 'exit' }),
-      createInboxItem({ id: '2', type: 'bell' }),
-      createInboxItem({ id: '3', type: 'idle' }),
-      createInboxItem({ id: '4', type: 'title' }),
-    ];
-    const config = createConfig();
-
-    expect(filterByConfig(items, config)).toHaveLength(4);
-  });
-
-  it('should use default config when not provided', () => {
-    const items = [createInboxItem({ type: 'exit' })];
-    // Default config has all types enabled
-    expect(filterByConfig(items)).toHaveLength(1);
-  });
-});
-
-// ============================================================================
-// diffInbox
-// ============================================================================
-
-describe('diffInbox', () => {
-  it('should detect newly added items', () => {
-    const previous: InboxItem[] = [];
-    const current = [createInboxItem({ id: 'new-1' }), createInboxItem({ id: 'new-2' })];
-
-    const diff = diffInbox(previous, current);
-
-    expect(diff.added).toHaveLength(2);
-    expect(diff.added.map((i) => i.id)).toEqual(['new-1', 'new-2']);
-    expect(diff.removed).toHaveLength(0);
-    expect(diff.read).toHaveLength(0);
-  });
-
-  it('should detect removed items', () => {
-    const previous = [createInboxItem({ id: 'old-1' }), createInboxItem({ id: 'old-2' })];
-    const current = [createInboxItem({ id: 'old-1' })];
-
-    const diff = diffInbox(previous, current);
-
-    expect(diff.added).toHaveLength(0);
-    expect(diff.removed).toHaveLength(1);
-    expect(diff.removed[0].id).toBe('old-2');
-  });
-
-  it('should detect items marked as read', () => {
-    const previous = [
-      createInboxItem({ id: 'item-1', read: false }),
-      createInboxItem({ id: 'item-2', read: false }),
-    ];
-    const current = [
-      createInboxItem({ id: 'item-1', read: true }),
-      createInboxItem({ id: 'item-2', read: false }),
-    ];
-
-    const diff = diffInbox(previous, current);
-
-    expect(diff.added).toHaveLength(0);
-    expect(diff.removed).toHaveLength(0);
-    expect(diff.read).toHaveLength(1);
-    expect(diff.read[0].id).toBe('item-1');
-  });
-
-  it('should handle mixed changes', () => {
-    const previous = [
-      createInboxItem({ id: 'kept', read: false }),
-      createInboxItem({ id: 'removed', read: false }),
-      createInboxItem({ id: 'marked-read', read: false }),
-    ];
-    const current = [
-      createInboxItem({ id: 'kept', read: false }),
-      createInboxItem({ id: 'marked-read', read: true }),
-      createInboxItem({ id: 'added', read: false }),
-    ];
-
-    const diff = diffInbox(previous, current);
-
-    expect(diff.added).toHaveLength(1);
-    expect(diff.added[0].id).toBe('added');
-    expect(diff.removed).toHaveLength(1);
-    expect(diff.removed[0].id).toBe('removed');
-    expect(diff.read).toHaveLength(1);
-    expect(diff.read[0].id).toBe('marked-read');
-  });
-
-  it('should not include previously read items in read list', () => {
-    const previous = [createInboxItem({ id: 'already-read', read: true })];
-    const current = [createInboxItem({ id: 'already-read', read: true })];
-
-    const diff = diffInbox(previous, current);
-    expect(diff.read).toHaveLength(0);
-  });
-});
-
-// ============================================================================
-// itemToToast
-// ============================================================================
-
-describe('itemToToast', () => {
-  it('should convert exit item with zero exit code', () => {
-    const item = createInboxItem({
-      id: 'exit-0',
-      type: 'exit',
-      exitCode: 0,
-      processTitle: 'npm test',
-      context: 'Tests passed\nAll 42 tests passed',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.id).toBe('exit-0');
-    expect(toast.sessionId).toBe('session-1');
-    expect(toast.sessionName).toBe('my-project:my-workspace:default');
-    expect(toast.icon).toBe('✅');
-    expect(toast.title).toBe('my-project / my-workspace / default: Completed - npm test');
-    expect(toast.preview).toBe('Tests passed');
-    expect(toast.item).toBe(item);
-  });
-
-  it('should convert exit item with non-zero exit code', () => {
-    const item = createInboxItem({
-      type: 'exit',
-      exitCode: 1,
-      processTitle: 'npm build',
-      context: 'Build failed',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.icon).toBe('❌');
-    expect(toast.title).toBe('my-project / my-workspace / default: Exit code 1 - npm build');
-  });
-
-  it('should convert bell item', () => {
-    const item = createInboxItem({
-      type: 'bell',
-      processTitle: undefined,
-      context: 'Alert notification',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.icon).toBe('🔔');
-    expect(toast.title).toBe('my-project / my-workspace / default: Bell');
-  });
-
-  it('should convert idle item', () => {
-    const item = createInboxItem({
-      type: 'idle',
-      processTitle: 'vim',
-      context: 'No activity for 5 minutes',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.icon).toBe('⏸️');
-    expect(toast.title).toBe('my-project / my-workspace / default: Activity Complete - vim');
-  });
-
-  it('should convert title item', () => {
-    const item = createInboxItem({
-      type: 'title',
-      processTitle: 'bash',
-      context: 'Title changed to: ~/projects',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.icon).toBe('📝');
-    expect(toast.title).toBe('my-project / my-workspace / default: Title Change - bash');
-  });
-
-  it('should convert osc item', () => {
-    const item = createInboxItem({
-      type: 'osc',
-      processTitle: 'app',
-      context: 'Custom notification',
-    });
-
-    const toast = itemToToast(item);
-
-    expect(toast.icon).toBe('📟');
-    expect(toast.title).toBe('my-project / my-workspace / default: OSC Notification - app');
-  });
-
-  it('should truncate long preview text', () => {
-    const longContext = 'A'.repeat(100) + '\nSecond line';
-    const item = createInboxItem({ context: longContext });
-
-    const toast = itemToToast(item);
-
-    expect(toast.preview.length).toBeLessThanOrEqual(60);
-  });
-});
-
-// ============================================================================
-// getToastableItems
-// ============================================================================
-
-describe('getToastableItems', () => {
-  it('should return empty array when notifications disabled', () => {
-    const items = [createInboxItem()];
-    const config = createConfig({ enabled: false });
-
-    expect(getToastableItems(items, config)).toEqual([]);
-  });
-
-  it('should return empty array when toasts disabled', () => {
-    const items = [createInboxItem()];
-    const config = createConfig({ toast: { enabled: false, holdWhenIdleMs: 15000 } });
-
-    expect(getToastableItems(items, config)).toEqual([]);
-  });
-
-  it('should filter and convert items to toasts', () => {
-    const items = [
-      createInboxItem({ id: '1', type: 'exit' }),
-      createInboxItem({ id: '2', type: 'bell' }),
-    ];
-    const config = createConfig({
-      types: { exit: true, idle: true, bell: false, title: true, osc: true },
-    });
-
-    const toasts = getToastableItems(items, config);
-
-    expect(toasts).toHaveLength(1);
-    expect(toasts[0].id).toBe('1');
-  });
-
-  it('should use default config when not provided', () => {
-    const items = [createInboxItem({ id: '1' })];
-
-    const toasts = getToastableItems(items);
-
-    expect(toasts).toHaveLength(1);
-  });
-});
-
-// ============================================================================
-// getMostRecentUnread
-// ============================================================================
-
-describe('getMostRecentUnread', () => {
-  it('should return null for empty array', () => {
-    expect(getMostRecentUnread([])).toBeNull();
-  });
-
-  it('should return null when all items are read', () => {
-    const items = [
-      createInboxItem({ id: '1', read: true }),
-      createInboxItem({ id: '2', read: true }),
-    ];
-
-    expect(getMostRecentUnread(items)).toBeNull();
-  });
-
-  it('should return the most recent unread item', () => {
-    const now = Date.now();
-    const items = [
-      createInboxItem({ id: 'old', read: false, timestamp: now - 2000 }),
-      createInboxItem({ id: 'newest', read: false, timestamp: now }),
-      createInboxItem({ id: 'middle', read: false, timestamp: now - 1000 }),
-    ];
-
-    const result = getMostRecentUnread(items);
-
-    expect(result).not.toBeNull();
-    expect(result!.id).toBe('newest');
-  });
-
-  it('should skip read items even if more recent', () => {
-    const now = Date.now();
-    const items = [
-      createInboxItem({ id: 'read-newest', read: true, timestamp: now }),
-      createInboxItem({ id: 'unread-older', read: false, timestamp: now - 1000 }),
-    ];
-
-    const result = getMostRecentUnread(items);
-
-    expect(result).not.toBeNull();
-    expect(result!.id).toBe('unread-older');
-  });
-});
-
-// ============================================================================
-// getSessionLabel
-// ============================================================================
-
-describe('getSessionLabel', () => {
-  it('should format session name into label', () => {
-    expect(getSessionLabel('my-project:my-workspace:default')).toBe(
-      'my-project / my-workspace / default'
-    );
-  });
-
-  it('should handle missing parts', () => {
-    expect(getSessionLabel('project')).toBe('project / unknown / unknown');
-    expect(getSessionLabel('project:workspace')).toBe('project / workspace / unknown');
-  });
-
-  it('should handle empty string', () => {
-    expect(getSessionLabel('')).toBe('unknown / unknown / unknown');
-  });
-});

package/src/notifications/policy.ts

@@ -1,139 +0,0 @@
-/**
- * Notification Policy
- *
- * Shared logic for filtering notifications based on user config.
- * Used by both TUI and Web to determine which notifications to show.
- */
-
-import type { InboxItem } from '../lib/remote-session/protocol.js';
-import type { NotificationConfig, ToastNotification, InboxDiff } from './types.js';
-import { DEFAULT_NOTIFICATION_CONFIG } from './types.js';
-import {
-  parseSessionName,
-  getInboxIcon,
-  getInboxTypeLabel,
-} from '../components/Inbox.js';
-
-/**
- * Check if a notification type is enabled in config
- */
-export function isNotificationTypeEnabled(
-  type: InboxItem['type'],
-  config: NotificationConfig
-): boolean {
-  if (!config.enabled) return false;
-
-  switch (type) {
-    case 'exit':
-      return config.types.exit;
-    case 'idle':
-      return config.types.idle;
-    case 'bell':
-      return config.types.bell;
-    case 'title':
-      return config.types.title;
-    default:
-      // OSC notifications come through as 'bell' type with context
-      return config.types.osc;
-  }
-}
-
-/**
- * Filter inbox items based on notification config
- */
-export function filterByConfig(
-  items: InboxItem[],
-  config: NotificationConfig = DEFAULT_NOTIFICATION_CONFIG
-): InboxItem[] {
-  if (!config.enabled) return [];
-
-  return items.filter((item) => isNotificationTypeEnabled(item.type, config));
-}
-
-/**
- * Compare two inbox states and return the diff
- */
-export function diffInbox(
-  previous: InboxItem[],
-  current: InboxItem[]
-): InboxDiff {
-  const prevIds = new Set(previous.map((i) => i.id));
-  const currIds = new Set(current.map((i) => i.id));
-  const prevReadIds = new Set(previous.filter((i) => i.read).map((i) => i.id));
-
-  const added = current.filter((i) => !prevIds.has(i.id));
-  const removed = previous.filter((i) => !currIds.has(i.id));
-  const read = current.filter(
-    (i) => i.read && prevIds.has(i.id) && !prevReadIds.has(i.id)
-  );
-
-  return { added, removed, read };
-}
-
-/**
- * Convert an inbox item to a toast notification
- */
-export function itemToToast(item: InboxItem): ToastNotification {
-  const icon = getInboxIcon(item);
-  const typeLabel = getInboxTypeLabel(item);
-
-  // Parse session name for display
-  const sessionLabel = getSessionLabel(item.sessionName);
-
-  // Build a concise title with session context
-  let title = `${sessionLabel}: ${typeLabel}`;
-  if (item.processTitle) {
-    title = `${sessionLabel}: ${typeLabel} - ${item.processTitle}`;
-  }
-
-  // Preview is the first line of context, truncated
-  const preview = item.context.split('\n')[0]?.substring(0, 60) || '';
-
-  return {
-    id: item.id,
-    sessionId: item.sessionId,
-    sessionName: item.sessionName,
-    icon,
-    title,
-    preview,
-    timestamp: item.timestamp,
-    item,
-  };
-}
-
-/**
- * Get toast-eligible notifications from new inbox items
- *
- * Filters by config and returns ToastNotification objects
- * for items that should trigger a toast.
- */
-export function getToastableItems(
-  newItems: InboxItem[],
-  config: NotificationConfig = DEFAULT_NOTIFICATION_CONFIG
-): ToastNotification[] {
-  if (!config.enabled || !config.toast.enabled) {
-    return [];
-  }
-
-  return filterByConfig(newItems, config).map(itemToToast);
-}
-
-/**
- * Get the most recent unread item (for quick-jump)
- */
-export function getMostRecentUnread(items: InboxItem[]): InboxItem | null {
-  const unread = items.filter((i) => !i.read);
-  if (unread.length === 0) return null;
-
-  // Sort by timestamp descending
-  unread.sort((a, b) => b.timestamp - a.timestamp);
-  return unread[0];
-}
-
-/**
- * Session label for display (project / workspace / session)
- */
-export function getSessionLabel(sessionName: string): string {
-  const parts = parseSessionName(sessionName);
-  return `${parts.project} / ${parts.workspace} / ${parts.session}`;
-}

package/src/notifications/types.ts

@@ -1,82 +0,0 @@
-/**
- * Shared notification types
- *
- * Types used across TUI, Web, and tmux-lite for notification handling.
- */
-
-import type { InboxItem } from '../lib/remote-session/protocol.js';
-
-/**
- * Notification config as used by the shared notification system.
- * This matches the structure from types/config.ts but is redeclared
- * for environments (like web) that can't import node-only config modules.
- */
-export interface NotificationConfig {
-  enabled: boolean;
-  minCommandDurationMs: number;
-  types: {
-    exit: boolean;
-    idle: boolean;
-    bell: boolean;
-    title: boolean;
-    osc: boolean;
-  };
-  toast: {
-    enabled: boolean;
-    /** Hold toasts when user is idle for this duration (ms). 0 = disabled. (default: 15000) */
-    holdWhenIdleMs: number;
-  };
-}
-
-/**
- * Default notification config (matches types/config.ts)
- */
-export const DEFAULT_NOTIFICATION_CONFIG: NotificationConfig = {
-  enabled: true,
-  minCommandDurationMs: 10000,
-  types: {
-    exit: true,
-    idle: true,
-    bell: true,
-    title: true,
-    osc: true,
-  },
-  toast: {
-    enabled: true,
-    holdWhenIdleMs: 15000,
-  },
-};
-
-/**
- * Toast notification data
- */
-export interface ToastNotification {
-  /** Unique ID for deduplication */
-  id: string;
-  /** Session ID to attach to */
-  sessionId: string;
-  /** Session display name */
-  sessionName: string;
-  /** Notification type icon */
-  icon: string;
-  /** Title for the toast */
-  title: string;
-  /** Preview/context text */
-  preview: string;
-  /** Timestamp */
-  timestamp: number;
-  /** Original inbox item */
-  item: InboxItem;
-}
-
-/**
- * Result from comparing inbox states
- */
-export interface InboxDiff {
-  /** Newly added items since last check */
-  added: InboxItem[];
-  /** Items that were removed */
-  removed: InboxItem[];
-  /** Items that were marked as read */
-  read: InboxItem[];
-}