github-issue-tower-defence-management 1.46.0 → 1.48.0

package/src/domain/usecases/RevertOrphanedPreparationUseCase.test.ts

@@ -158,9 +158,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -206,9 +203,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -247,9 +241,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -283,46 +274,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
-      allowIssueCacheMinutes: 60,
-      preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
-    });
-
-    expect(mockIssueRepository.updateStatus.mock.calls).toHaveLength(1);
-    expect(mockIssueRepository.updateStatus.mock.calls[0][2]).toBe('1');
-  });
-
-  it('should revert orphaned issue to Awaiting Workspace when awaitingQualityCheckStatus is not provided', async () => {
-    const stuckIssue = createMockIssue({
-      url: 'https://github.com/user/repo/issues/10',
-      status: 'Preparation',
-    });
-    mockIssueRepository.getAllIssues.mockResolvedValue({
-      issues: [stuckIssue],
-      cacheUsed: false,
-    });
-    mockLocalCommandRunner.runCommand.mockResolvedValue({
-      stdout: '',
-      stderr: '',
-      exitCode: 1,
-    });
-    mockIssueCommentRepository.getCommentsFromIssue.mockResolvedValue([
-      {
-        author: 'bot',
-        content: 'From: agent report',
-        createdAt: new Date(),
-      },
-    ]);
-    mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
-      createPassingPr(),
-    ]);
-
-    await useCase.run({
-      projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -356,9 +307,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -393,9 +341,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -422,9 +367,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -449,9 +391,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -484,9 +423,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'check {URL}',
     });
@@ -526,9 +462,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'check {URL}',
     });
@@ -543,9 +476,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
     await expect(
       useCase.run({
         projectUrl: 'https://github.com/user/repo',
-        preparationStatus: 'Preparation',
-        awaitingWorkspaceStatus: 'Awaiting Workspace',
-        awaitingQualityCheckStatus: 'Awaiting Quality Check',
         allowIssueCacheMinutes: 0,
         preparationProcessCheckCommand: 'check {URL}',
       }),
@@ -559,20 +489,29 @@ describe('RevertOrphanedPreparationUseCase', () => {
     await expect(
       useCase.run({
         projectUrl: 'https://github.com/user/repo',
-        preparationStatus: 'Preparation',
-        awaitingWorkspaceStatus: 'Awaiting Workspace',
-        awaitingQualityCheckStatus: 'Awaiting Quality Check',
         allowIssueCacheMinutes: 0,
         preparationProcessCheckCommand: 'check {URL}',
       }),
     ).rejects.toThrow('Project not found. projectId: project-1');
   });
 
-  it('should do nothing when awaitingWorkspaceStatus is not found in project statuses', async () => {
+  it('should do nothing when Awaiting Workspace status is not found in project statuses', async () => {
     const preparationIssue = createMockIssue({
       url: 'https://github.com/user/repo/issues/10',
       status: 'Preparation',
     });
+    const projectWithoutAwaitingWorkspace = {
+      ...mockProject,
+      status: {
+        ...mockProject.status,
+        statuses: mockProject.status.statuses.filter(
+          (s) => s.name !== 'Awaiting Workspace',
+        ),
+      },
+    };
+    mockProjectRepository.getProject.mockResolvedValue(
+      projectWithoutAwaitingWorkspace,
+    );
     mockIssueRepository.getAllIssues.mockResolvedValue({
       issues: [preparationIssue],
       cacheUsed: false,
@@ -585,9 +524,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'NonExistentStatus',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 0,
       preparationProcessCheckCommand: 'check {URL}',
     });
@@ -606,9 +542,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'check {URL}',
     });
@@ -645,9 +578,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "Please handover {URL}"',
       awLogDirectoryPath: '/home/user/logs-aw',
@@ -710,9 +640,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "Please handover {URL}"',
       awLogDirectoryPath: '/home/user/logs-aw',
@@ -747,9 +674,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "Please handover {URL}"',
       awLogDirectoryPath: '/home/user/logs-aw',
@@ -780,9 +704,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -812,9 +733,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "Please handover {URL}"',
       awLogDirectoryPath: '/home/user/logs-aw',
@@ -842,9 +760,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 0,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });
@@ -877,9 +792,6 @@ describe('RevertOrphanedPreparationUseCase', () => {
 
     await useCase.run({
       projectUrl: 'https://github.com/user/repo',
-      preparationStatus: 'Preparation',
-      awaitingWorkspaceStatus: 'Awaiting Workspace',
-      awaitingQualityCheckStatus: 'Awaiting Quality Check',
       allowIssueCacheMinutes: 60,
       preparationProcessCheckCommand: 'pgrep -fa "claude-agent.*{URL}"',
     });

package/src/domain/usecases/RevertOrphanedPreparationUseCase.ts

@@ -6,6 +6,11 @@ import { IssueCommentRepository } from './adapter-interfaces/IssueCommentReposit
 import { ProjectRepository } from './adapter-interfaces/ProjectRepository';
 import { LocalCommandRunner } from './adapter-interfaces/LocalCommandRunner';
 import { Issue } from '../entities/Issue';
+import {
+  AWAITING_QUALITY_CHECK_STATUS_NAME,
+  AWAITING_WORKSPACE_STATUS_NAME,
+  PREPARATION_STATUS_NAME,
+} from '../entities/WorkflowStatus';
 
 export class RevertOrphanedPreparationUseCase {
   constructor(
@@ -29,9 +34,6 @@ export class RevertOrphanedPreparationUseCase {
 
   run = async (params: {
     projectUrl: string;
-    preparationStatus: string;
-    awaitingWorkspaceStatus: string;
-    awaitingQualityCheckStatus?: string;
     allowIssueCacheMinutes: number;
     preparationProcessCheckCommand: string;
     awLogDirectoryPath?: string;
@@ -55,21 +57,19 @@ export class RevertOrphanedPreparationUseCase {
     );
 
     const preparationIssues = issues.filter(
-      (issue) => issue.status === params.preparationStatus,
+      (issue) => issue.status === PREPARATION_STATUS_NAME,
     );
 
     const awaitingWorkspaceStatusOption = project.status.statuses.find(
-      (s) => s.name === params.awaitingWorkspaceStatus,
+      (s) => s.name === AWAITING_WORKSPACE_STATUS_NAME,
     );
     if (!awaitingWorkspaceStatusOption) {
       return;
     }
 
-    const awaitingQualityCheckStatusOption = params.awaitingQualityCheckStatus
-      ? project.status.statuses.find(
-          (s) => s.name === params.awaitingQualityCheckStatus,
-        )
-      : null;
+    const awaitingQualityCheckStatusOption = project.status.statuses.find(
+      (s) => s.name === AWAITING_QUALITY_CHECK_STATUS_NAME,
+    );
 
     for (const issue of preparationIssues) {
       const isOrphaned = await this.isOrphanedIssue(issue, params);

package/src/domain/usecases/SetupTowerDefenceProjectUseCase.test.ts

@@ -0,0 +1,187 @@
+import { mock } from 'jest-mock-extended';
+import { SetupTowerDefenceProjectUseCase } from './SetupTowerDefenceProjectUseCase';
+import { ProjectRepository } from './adapter-interfaces/ProjectRepository';
+import { FieldOption, Project } from '../entities/Project';
+import {
+  AWAITING_QUALITY_CHECK_STATUS_NAME,
+  AWAITING_WORKSPACE_STATUS_NAME,
+  DEFAULT_STATUS_NAME,
+  DISABLED_STATUS_NAME,
+  PREPARATION_STATUS_NAME,
+  REQUIRED_WORKFLOW_STATUSES,
+} from '../entities/WorkflowStatus';
+
+const buildProject = (statuses: FieldOption[]): Project => ({
+  id: 'project-1',
+  url: 'https://github.com/orgs/test-org/projects/1',
+  databaseId: 1,
+  name: 'test-project',
+  status: {
+    name: 'Status',
+    fieldId: 'status-field-1',
+    statuses,
+  },
+  nextActionDate: null,
+  nextActionHour: null,
+  story: null,
+  remainingEstimationMinutes: null,
+  dependedIssueUrlSeparatedByComma: null,
+  completionDate50PercentConfidence: null,
+});
+
+const buildCanonicalStatuses = (): FieldOption[] =>
+  REQUIRED_WORKFLOW_STATUSES.map((required, index) => ({
+    id: `id-${index}`,
+    name: required.name,
+    color: required.color,
+    description: required.description,
+  }));
+
+describe('SetupTowerDefenceProjectUseCase', () => {
+  it('should skip update when project already has required statuses in canonical order', async () => {
+    const mockProjectRepository =
+      mock<Pick<ProjectRepository, 'getByUrl' | 'updateStatusList'>>();
+    const project = buildProject(buildCanonicalStatuses());
+    mockProjectRepository.getByUrl.mockResolvedValue(project);
+
+    const useCase = new SetupTowerDefenceProjectUseCase(mockProjectRepository);
+    await useCase.run({ projectUrl: project.url });
+
+    expect(mockProjectRepository.updateStatusList).not.toHaveBeenCalled();
+  });
+
+  it('should skip update when project already has required statuses plus extras after them', async () => {
+    const mockProjectRepository =
+      mock<Pick<ProjectRepository, 'getByUrl' | 'updateStatusList'>>();
+    const statuses = [
+      ...buildCanonicalStatuses(),
+      {
+        id: 'extra-1',
+        name: 'Done',
+        color: 'GREEN' as const,
+        description: '',
+      },
+    ];
+    const project = buildProject(statuses);
+    mockProjectRepository.getByUrl.mockResolvedValue(project);
+
+    const useCase = new SetupTowerDefenceProjectUseCase(mockProjectRepository);
+    await useCase.run({ projectUrl: project.url });
+
+    expect(mockProjectRepository.updateStatusList).not.toHaveBeenCalled();
+  });
+
+  it('should add missing required statuses while preserving existing custom statuses', async () => {
+    const mockProjectRepository =
+      mock<Pick<ProjectRepository, 'getByUrl' | 'updateStatusList'>>();
+    const statuses: FieldOption[] = [
+      {
+        id: 'unread-id',
+        name: DEFAULT_STATUS_NAME,
+        color: 'GRAY',
+        description: 'Default fallback status for issues before triage',
+      },
+      {
+        id: 'extra-1',
+        name: 'Done',
+        color: 'GREEN',
+        description: '',
+      },
+    ];
+    const project = buildProject(statuses);
+    mockProjectRepository.getByUrl.mockResolvedValue(project);
+    mockProjectRepository.updateStatusList.mockResolvedValue([]);
+
+    const useCase = new SetupTowerDefenceProjectUseCase(mockProjectRepository);
+    await useCase.run({ projectUrl: project.url });
+
+    expect(mockProjectRepository.updateStatusList).toHaveBeenCalledTimes(1);
+    expect(mockProjectRepository.updateStatusList).toHaveBeenCalledWith(
+      project,
+      [
+        {
+          id: 'unread-id',
+          name: DEFAULT_STATUS_NAME,
+          color: 'GRAY',
+          description: 'Default fallback status for issues before triage',
+        },
+        {
+          id: null,
+          name: AWAITING_WORKSPACE_STATUS_NAME,
+          color: 'YELLOW',
+          description: 'Issue is ready and waiting for an agent workspace',
+        },
+        {
+          id: null,
+          name: PREPARATION_STATUS_NAME,
+          color: 'ORANGE',
+          description: 'Agent is preparing the issue',
+        },
+        {
+          id: null,
+          name: AWAITING_QUALITY_CHECK_STATUS_NAME,
+          color: 'BLUE',
+          description: 'Awaiting human quality check',
+        },
+        {
+          id: null,
+          name: DISABLED_STATUS_NAME,
+          color: 'GRAY',
+          description: 'Disabled and excluded from the active workflow',
+        },
+        {
+          id: 'extra-1',
+          name: 'Done',
+          color: 'GREEN',
+          description: '',
+        },
+      ],
+    );
+  });
+
+  it('should reorder existing required statuses into canonical order when out of order', async () => {
+    const mockProjectRepository =
+      mock<Pick<ProjectRepository, 'getByUrl' | 'updateStatusList'>>();
+    const reversedStatuses: FieldOption[] = REQUIRED_WORKFLOW_STATUSES.slice()
+      .reverse()
+      .map((required, index) => ({
+        id: `reversed-id-${index}`,
+        name: required.name,
+        color: required.color,
+        description: required.description,
+      }));
+    const project = buildProject(reversedStatuses);
+    mockProjectRepository.getByUrl.mockResolvedValue(project);
+    mockProjectRepository.updateStatusList.mockResolvedValue([]);
+
+    const useCase = new SetupTowerDefenceProjectUseCase(mockProjectRepository);
+    await useCase.run({ projectUrl: project.url });
+
+    expect(mockProjectRepository.updateStatusList).toHaveBeenCalledTimes(1);
+    const [, payload] = mockProjectRepository.updateStatusList.mock.calls[0];
+    expect(payload.map((status) => status.name)).toEqual([
+      DEFAULT_STATUS_NAME,
+      AWAITING_WORKSPACE_STATUS_NAME,
+      PREPARATION_STATUS_NAME,
+      AWAITING_QUALITY_CHECK_STATUS_NAME,
+      DISABLED_STATUS_NAME,
+    ]);
+  });
+
+  it('should fix color when an existing required status has wrong color', async () => {
+    const mockProjectRepository =
+      mock<Pick<ProjectRepository, 'getByUrl' | 'updateStatusList'>>();
+    const statuses = buildCanonicalStatuses();
+    statuses[2] = { ...statuses[2], color: 'RED' };
+    const project = buildProject(statuses);
+    mockProjectRepository.getByUrl.mockResolvedValue(project);
+    mockProjectRepository.updateStatusList.mockResolvedValue([]);
+
+    const useCase = new SetupTowerDefenceProjectUseCase(mockProjectRepository);
+    await useCase.run({ projectUrl: project.url });
+
+    expect(mockProjectRepository.updateStatusList).toHaveBeenCalledTimes(1);
+    const [, payload] = mockProjectRepository.updateStatusList.mock.calls[0];
+    expect(payload[2].color).toBe('ORANGE');
+  });
+});

package/src/domain/usecases/SetupTowerDefenceProjectUseCase.ts

@@ -0,0 +1,69 @@
+import { FieldOption } from '../entities/Project';
+import { ProjectRepository } from './adapter-interfaces/ProjectRepository';
+import {
+  REQUIRED_WORKFLOW_STATUSES,
+  WorkflowStatusDefinition,
+} from '../entities/WorkflowStatus';
+
+export class SetupTowerDefenceProjectUseCase {
+  constructor(
+    private readonly projectRepository: Pick<
+      ProjectRepository,
+      'getByUrl' | 'updateStatusList'
+    >,
+  ) {}
+
+  run = async (params: { projectUrl: string }): Promise<void> => {
+    const project = await this.projectRepository.getByUrl(params.projectUrl);
+    const existing = project.status.statuses;
+
+    if (
+      SetupTowerDefenceProjectUseCase.hasRequiredStatusesInCanonicalOrder(
+        existing,
+      )
+    ) {
+      return;
+    }
+
+    const requiredNames = new Set(
+      REQUIRED_WORKFLOW_STATUSES.map((s) => s.name),
+    );
+    const others = existing.filter((status) => !requiredNames.has(status.name));
+
+    const newStatusList: (Omit<FieldOption, 'id'> & {
+      id: FieldOption['id'] | null;
+    })[] = [
+      ...REQUIRED_WORKFLOW_STATUSES.map((required) => {
+        const found = existing.find((status) => status.name === required.name);
+        return {
+          id: found ? found.id : null,
+          name: required.name,
+          color: required.color,
+          description: required.description,
+        };
+      }),
+      ...others.map((other) => ({
+        id: other.id,
+        name: other.name,
+        color: other.color,
+        description: other.description,
+      })),
+    ];
+
+    await this.projectRepository.updateStatusList(project, newStatusList);
+  };
+
+  private static hasRequiredStatusesInCanonicalOrder = (
+    existing: FieldOption[],
+  ): boolean => {
+    if (existing.length < REQUIRED_WORKFLOW_STATUSES.length) {
+      return false;
+    }
+    return REQUIRED_WORKFLOW_STATUSES.every(
+      (required: WorkflowStatusDefinition, index: number) => {
+        const actual = existing[index];
+        return actual.name === required.name && actual.color === required.color;
+      },
+    );
+  };
+}