github-issue-tower-defence-management 1.46.0 → 1.48.0

package/src/adapter/entry-points/cli/index.test.ts

@@ -66,10 +66,7 @@ describe('CLI', () => {
 
   const defaultConfig = {
     projectUrl: 'https://github.com/orgs/test/projects/1',
-    awaitingWorkspaceStatus: 'Awaiting',
-    preparationStatus: 'Preparing',
     defaultAgentName: 'agent1',
-    awaitingQualityCheckStatus: 'Awaiting QC',
     projectName: 'test-project',
   };
 
@@ -128,8 +125,6 @@ describe('CLI', () => {
     it('should load config from YAML file', () => {
       const config = {
         projectUrl: 'https://github.com/orgs/test/projects/1',
-        awaitingWorkspaceStatus: 'Awaiting',
-        preparationStatus: 'Preparing',
         defaultAgentName: 'agent1',
         defaultLlmModelName: 'claude-opus-4-5',
         defaultLlmAgentName: 'aw',
@@ -137,7 +132,6 @@ describe('CLI', () => {
         allowIssueCacheMinutes: 5,
         utilizationPercentageThreshold: 80,
         allowedIssueAuthors: 'user1,user2',
-        awaitingQualityCheckStatus: 'Awaiting QC',
         thresholdForAutoReject: 5,
         workflowBlockerResolvedWebhookUrl: 'https://example.com/webhook',
         projectName: 'test-project',
@@ -197,14 +191,14 @@ describe('CLI', () => {
     it('should ignore non-string values for string fields', () => {
       const config = {
         projectUrl: 123,
-        awaitingWorkspaceStatus: true,
+        defaultAgentName: true,
       };
       writeConfig(config);
 
       const result = loadConfigFile(configFilePath);
 
       expect(result.projectUrl).toBeUndefined();
-      expect(result.awaitingWorkspaceStatus).toBeUndefined();
+      expect(result.defaultAgentName).toBeUndefined();
     });
 
     it('should ignore non-number values for number fields', () => {
@@ -263,16 +257,14 @@ describe('CLI', () => {
 Some description
 <details>
 <summary>config</summary>
-awaitingWorkspaceStatus: 'Custom Awaiting'
-preparationStatus: 'Custom Preparing'
 defaultAgentName: 'readme-agent'
+defaultLlmModelName: 'claude-opus-4-5'
 </details>`;
 
       const result = parseProjectReadmeConfig(readme);
 
-      expect(result.awaitingWorkspaceStatus).toBe('Custom Awaiting');
-      expect(result.preparationStatus).toBe('Custom Preparing');
       expect(result.defaultAgentName).toBe('readme-agent');
+      expect(result.defaultLlmModelName).toBe('claude-opus-4-5');
     });
 
     it('should return empty config when no details/summary section exists', () => {
@@ -506,8 +498,6 @@ codexHomeCandidates:
       expect(mockRun).toHaveBeenCalledTimes(1);
       expect(mockRun).toHaveBeenCalledWith({
         projectUrl: 'https://github.com/orgs/test/projects/1',
-        awaitingWorkspaceStatus: 'Awaiting',
-        preparationStatus: 'Preparing',
         defaultAgentName: 'agent1',
         defaultLlmModelName: null,
         defaultLlmAgentName: null,
@@ -548,8 +538,6 @@ codexHomeCandidates:
       expect(mockRun).toHaveBeenCalledTimes(1);
       expect(mockRun).toHaveBeenCalledWith({
         projectUrl: 'https://github.com/orgs/override/projects/2',
-        awaitingWorkspaceStatus: 'Awaiting',
-        preparationStatus: 'Preparing',
         defaultAgentName: 'override-agent',
         defaultLlmModelName: null,
         defaultLlmAgentName: null,
@@ -750,8 +738,6 @@ codexHomeCandidates:
 
     it('should exit with error when projectUrl is missing from both CLI and config', async () => {
       const configWithoutProjectUrl = {
-        awaitingWorkspaceStatus: 'Awaiting',
-        preparationStatus: 'Preparing',
         defaultAgentName: 'agent1',
       };
       writeConfig(configWithoutProjectUrl);
@@ -782,79 +768,9 @@ codexHomeCandidates:
       processExitSpy.mockRestore();
     });
 
-    it('should exit with error when awaitingWorkspaceStatus is missing', async () => {
-      const configMissing = {
-        projectUrl: 'https://github.com/orgs/test/projects/1',
-        preparationStatus: 'Preparing',
-        defaultAgentName: 'agent1',
-      };
-      writeConfig(configMissing);
-
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-      const processExitSpy = jest
-        .spyOn(process, 'exit')
-        .mockImplementation(() => {
-          throw new Error('process.exit called');
-        });
-
-      await expect(
-        program.parseAsync([
-          'node',
-          'test',
-          'startDaemon',
-          '--configFilePath',
-          configFilePath,
-        ]),
-      ).rejects.toThrow('process.exit called');
-
-      expect(consoleErrorSpy).toHaveBeenCalledWith(
-        'awaitingWorkspaceStatus is required. Provide via --awaitingWorkspaceStatus, config file, or project README.',
-      );
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-
-      consoleErrorSpy.mockRestore();
-      processExitSpy.mockRestore();
-    });
-
-    it('should exit with error when preparationStatus is missing', async () => {
-      const configMissing = {
-        projectUrl: 'https://github.com/orgs/test/projects/1',
-        awaitingWorkspaceStatus: 'Awaiting',
-        defaultAgentName: 'agent1',
-      };
-      writeConfig(configMissing);
-
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-      const processExitSpy = jest
-        .spyOn(process, 'exit')
-        .mockImplementation(() => {
-          throw new Error('process.exit called');
-        });
-
-      await expect(
-        program.parseAsync([
-          'node',
-          'test',
-          'startDaemon',
-          '--configFilePath',
-          configFilePath,
-        ]),
-      ).rejects.toThrow('process.exit called');
-
-      expect(consoleErrorSpy).toHaveBeenCalledWith(
-        'preparationStatus is required. Provide via --preparationStatus, config file, or project README.',
-      );
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-
-      consoleErrorSpy.mockRestore();
-      processExitSpy.mockRestore();
-    });
-
     it('should exit with error when defaultAgentName is missing', async () => {
       const configMissing = {
         projectUrl: 'https://github.com/orgs/test/projects/1',
-        awaitingWorkspaceStatus: 'Awaiting',
-        preparationStatus: 'Preparing',
       };
       writeConfig(configMissing);
 
@@ -1068,52 +984,6 @@ codexHomeCandidates:
         }),
       );
     });
-
-    it('should write runtimeConfig-{projectId}.json atomically after useCase run', async () => {
-      const configWithNumericValues = {
-        ...defaultConfig,
-        maximumPreparingIssuesCount: 10,
-        utilizationPercentageThreshold: 97,
-        allowIssueCacheMinutes: 5,
-        thresholdForAutoReject: 30,
-      };
-      writeConfig(configWithNumericValues);
-
-      const mockRun = jest.fn().mockResolvedValue(undefined);
-      const MockedStartPreparationUseCase = jest.mocked(
-        StartPreparationUseCase,
-      );
-      MockedStartPreparationUseCase.mockImplementation(function (
-        this: StartPreparationUseCase,
-      ) {
-        this.run = mockRun;
-        return this;
-      });
-
-      await program.parseAsync([
-        'node',
-        'test',
-        'startDaemon',
-        '--configFilePath',
-        configFilePath,
-      ]);
-
-      const cacheDir = path.join(process.cwd(), 'tmp/cache/test-project');
-      const runtimeConfigPath = path.join(
-        cacheDir,
-        'runtimeConfig-PVT_kwHOtest456.json',
-      );
-      expect(fs.existsSync(runtimeConfigPath)).toBe(true);
-      const written: unknown = JSON.parse(
-        fs.readFileSync(runtimeConfigPath, 'utf-8'),
-      );
-      expect(written).toMatchObject({
-        maximumPreparingIssuesCount: 10,
-        utilizationPercentageThreshold: 97,
-        allowIssueCacheMinutes: 5,
-        thresholdForAutoReject: 30,
-      });
-    });
   });
 
   describe('notifyFinishedIssuePreparation', () => {
@@ -1144,9 +1014,6 @@ codexHomeCandidates:
       expect(mockRun).toHaveBeenCalledWith({
         projectUrl: 'https://github.com/orgs/test/projects/1',
         issueUrl: 'https://github.com/test/repo/issues/1',
-        preparationStatus: 'Preparing',
-        awaitingWorkspaceStatus: 'Awaiting',
-        awaitingQualityCheckStatus: 'Awaiting QC',
         thresholdForAutoReject: 3,
         workflowBlockerResolvedWebhookUrl: null,
       });
@@ -1175,16 +1042,11 @@ codexHomeCandidates:
         'https://github.com/test/repo/issues/1',
         '--projectUrl',
         'https://github.com/orgs/override/projects/2',
-        '--awaitingQualityCheckStatus',
-        'Override QC',
       ]);
 
       expect(mockRun).toHaveBeenCalledWith({
         projectUrl: 'https://github.com/orgs/override/projects/2',
         issueUrl: 'https://github.com/test/repo/issues/1',
-        preparationStatus: 'Preparing',
-        awaitingWorkspaceStatus: 'Awaiting',
-        awaitingQualityCheckStatus: 'Override QC',
         thresholdForAutoReject: 3,
         workflowBlockerResolvedWebhookUrl: null,
       });
@@ -1320,11 +1182,7 @@ codexHomeCandidates:
     });
 
     it('should exit with error when projectUrl is missing', async () => {
-      const configMissing = {
-        preparationStatus: 'Preparing',
-        awaitingWorkspaceStatus: 'Awaiting',
-        awaitingQualityCheckStatus: 'Awaiting QC',
-      };
+      const configMissing = {};
       writeConfig(configMissing);
 
       const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
@@ -1355,114 +1213,6 @@ codexHomeCandidates:
       processExitSpy.mockRestore();
     });
 
-    it('should exit with error when preparationStatus is missing', async () => {
-      const configMissing = {
-        projectUrl: 'https://github.com/orgs/test/projects/1',
-        awaitingWorkspaceStatus: 'Awaiting',
-        awaitingQualityCheckStatus: 'Awaiting QC',
-      };
-      writeConfig(configMissing);
-
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-      const processExitSpy = jest
-        .spyOn(process, 'exit')
-        .mockImplementation(() => {
-          throw new Error('process.exit called');
-        });
-
-      await expect(
-        program.parseAsync([
-          'node',
-          'test',
-          'notifyFinishedIssuePreparation',
-          '--configFilePath',
-          configFilePath,
-          '--issueUrl',
-          'https://github.com/test/repo/issues/1',
-        ]),
-      ).rejects.toThrow('process.exit called');
-
-      expect(consoleErrorSpy).toHaveBeenCalledWith(
-        'preparationStatus is required. Provide via --preparationStatus, config file, or project README.',
-      );
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-
-      consoleErrorSpy.mockRestore();
-      processExitSpy.mockRestore();
-    });
-
-    it('should exit with error when awaitingWorkspaceStatus is missing', async () => {
-      const configMissing = {
-        projectUrl: 'https://github.com/orgs/test/projects/1',
-        preparationStatus: 'Preparing',
-        awaitingQualityCheckStatus: 'Awaiting QC',
-      };
-      writeConfig(configMissing);
-
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-      const processExitSpy = jest
-        .spyOn(process, 'exit')
-        .mockImplementation(() => {
-          throw new Error('process.exit called');
-        });
-
-      await expect(
-        program.parseAsync([
-          'node',
-          'test',
-          'notifyFinishedIssuePreparation',
-          '--configFilePath',
-          configFilePath,
-          '--issueUrl',
-          'https://github.com/test/repo/issues/1',
-        ]),
-      ).rejects.toThrow('process.exit called');
-
-      expect(consoleErrorSpy).toHaveBeenCalledWith(
-        'awaitingWorkspaceStatus is required. Provide via --awaitingWorkspaceStatus, config file, or project README.',
-      );
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-
-      consoleErrorSpy.mockRestore();
-      processExitSpy.mockRestore();
-    });
-
-    it('should exit with error when awaitingQualityCheckStatus is missing', async () => {
-      const configMissing = {
-        projectUrl: 'https://github.com/orgs/test/projects/1',
-        preparationStatus: 'Preparing',
-        awaitingWorkspaceStatus: 'Awaiting',
-      };
-      writeConfig(configMissing);
-
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
-      const processExitSpy = jest
-        .spyOn(process, 'exit')
-        .mockImplementation(() => {
-          throw new Error('process.exit called');
-        });
-
-      await expect(
-        program.parseAsync([
-          'node',
-          'test',
-          'notifyFinishedIssuePreparation',
-          '--configFilePath',
-          configFilePath,
-          '--issueUrl',
-          'https://github.com/test/repo/issues/1',
-        ]),
-      ).rejects.toThrow('process.exit called');
-
-      expect(consoleErrorSpy).toHaveBeenCalledWith(
-        'awaitingQualityCheckStatus is required. Provide via --awaitingQualityCheckStatus, config file, or project README.',
-      );
-      expect(processExitSpy).toHaveBeenCalledWith(1);
-
-      consoleErrorSpy.mockRestore();
-      processExitSpy.mockRestore();
-    });
-
     it('should pass workflowBlockerResolvedWebhookUrl from config file', async () => {
       const configWithWebhook = {
         ...defaultConfig,
@@ -1501,12 +1251,12 @@ codexHomeCandidates:
       );
     });
 
-    it('should apply README config overrides', async () => {
+    it('should apply README config overrides for thresholdForAutoReject', async () => {
       const readmeContent = [
         '# Project',
         '<details>',
         '<summary>config</summary>',
-        "awaitingQualityCheckStatus: 'README QC'",
+        'thresholdForAutoReject: 9',
         '</details>',
       ].join('\n');
       mockFetchReturningReadme(readmeContent);
@@ -1535,7 +1285,7 @@ codexHomeCandidates:
 
       expect(mockRun).toHaveBeenCalledWith(
         expect.objectContaining({
-          awaitingQualityCheckStatus: 'README QC',
+          thresholdForAutoReject: 9,
         }),
       );
     });

package/src/adapter/entry-points/cli/index.ts

@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-import * as fs from 'fs';
 import { Command } from 'commander';
 import { HandleScheduledEventUseCaseHandler } from '../handlers/HandleScheduledEventUseCaseHandler';
 export {
@@ -31,12 +30,9 @@ import { OauthAPIProxyClaudeRepository } from '../../repositories/OauthAPIProxyC
 import { GitHubIssueCommentRepository } from '../../repositories/GitHubIssueCommentRepository';
 import { FetchWebhookRepository } from '../../repositories/FetchWebhookRepository';
 import { RevertOrphanedPreparationUseCase } from '../../../domain/usecases/RevertOrphanedPreparationUseCase';
-import { Project } from '../../../domain/entities/Project';
 
 type StartDaemonOptions = {
   projectUrl?: string;
-  awaitingWorkspaceStatus?: string;
-  preparationStatus?: string;
   defaultAgentName?: string;
   defaultLlmModelName?: string;
   defaultLlmAgentName?: string;
@@ -51,9 +47,6 @@ type StartDaemonOptions = {
 type NotifyFinishedOptions = {
   issueUrl: string;
   projectUrl?: string;
-  preparationStatus?: string;
-  awaitingWorkspaceStatus?: string;
-  awaitingQualityCheckStatus?: string;
   thresholdForAutoReject?: string;
   workflowBlockerResolvedWebhookUrl?: string;
   configFilePath: string;
@@ -115,11 +108,6 @@ program
     'Path to config file for tower defence management',
   )
   .option('--projectUrl <url>', 'GitHub project URL')
-  .option(
-    '--awaitingWorkspaceStatus <status>',
-    'Status for issues awaiting workspace',
-  )
-  .option('--preparationStatus <status>', 'Status for issues in preparation')
   .option('--defaultAgentName <name>', 'Default agent name')
   .option('--defaultLlmModelName <name>', 'Default LLM model name')
   .option('--defaultLlmAgentName <name>', 'Default LLM agent name')
@@ -154,8 +142,6 @@ program
 
     const cliOverrides: ConfigFile = {
       projectUrl: options.projectUrl,
-      awaitingWorkspaceStatus: options.awaitingWorkspaceStatus,
-      preparationStatus: options.preparationStatus,
       defaultAgentName: options.defaultAgentName,
       defaultLlmModelName: options.defaultLlmModelName,
       defaultLlmAgentName: options.defaultLlmAgentName,
@@ -190,8 +176,6 @@ program
     );
 
     const projectUrl = config.projectUrl;
-    const awaitingWorkspaceStatus = config.awaitingWorkspaceStatus;
-    const preparationStatus = config.preparationStatus;
     const defaultAgentName = config.defaultAgentName;
 
     if (!projectUrl) {
@@ -200,18 +184,6 @@ program
       );
       process.exit(1);
     }
-    if (!awaitingWorkspaceStatus) {
-      console.error(
-        'awaitingWorkspaceStatus is required. Provide via --awaitingWorkspaceStatus, config file, or project README.',
-      );
-      process.exit(1);
-    }
-    if (!preparationStatus) {
-      console.error(
-        'preparationStatus is required. Provide via --preparationStatus, config file, or project README.',
-      );
-      process.exit(1);
-    }
     if (!defaultAgentName) {
       console.error(
         'defaultAgentName is required. Provide via --defaultAgentName, config file, or project README.',
@@ -254,16 +226,9 @@ program
       cachePath,
       token,
     );
-    const projectRepository = {
-      ...new GraphqlProjectRepository(...githubRepositoryParams),
-
-      prepareStatus: async (
-        _name: string,
-        project: Project,
-      ): Promise<Project> => {
-        return project;
-      },
-    };
+    const projectRepository = new GraphqlProjectRepository(
+      ...githubRepositoryParams,
+    );
     const apiV3IssueRepository = new ApiV3IssueRepository(
       ...githubRepositoryParams,
     );
@@ -297,9 +262,6 @@ program
       );
       await revertUseCase.run({
         projectUrl,
-        preparationStatus,
-        awaitingWorkspaceStatus,
-        awaitingQualityCheckStatus: config.awaitingQualityCheckStatus,
         allowIssueCacheMinutes,
         preparationProcessCheckCommand,
         awLogDirectoryPath: config.awLogDirectoryPath,
@@ -329,8 +291,6 @@ program
 
     await useCase.run({
       projectUrl,
-      awaitingWorkspaceStatus,
-      preparationStatus,
       defaultAgentName,
       defaultLlmModelName: config.defaultLlmModelName ?? null,
       defaultLlmAgentName: config.defaultLlmAgentName ?? null,
@@ -342,23 +302,6 @@ program
       codexHomeCandidates,
       allowIssueCacheMinutes,
     });
-
-    const projectId = await projectRepository.findProjectIdByUrl(projectUrl);
-    if (projectId) {
-      const runtimeConfig = {
-        resolvedAt: new Date().toISOString(),
-        maximumPreparingIssuesCount: maximumPreparingIssuesCount,
-        utilizationPercentageThreshold:
-          config.utilizationPercentageThreshold ?? 90,
-        allowIssueCacheMinutes: allowIssueCacheMinutes,
-        thresholdForAutoReject: config.thresholdForAutoReject ?? 3,
-      };
-      const finalPath = `${cachePath}/runtimeConfig-${projectId}.json`;
-      const tmpPath = `${finalPath}.tmp`;
-      fs.mkdirSync(cachePath, { recursive: true });
-      fs.writeFileSync(tmpPath, JSON.stringify(runtimeConfig));
-      fs.renameSync(tmpPath, finalPath);
-    }
   });
 
 program
@@ -370,15 +313,6 @@ program
   )
   .requiredOption('--issueUrl <url>', 'GitHub issue URL')
   .option('--projectUrl <url>', 'GitHub project URL')
-  .option('--preparationStatus <status>', 'Status for issues in preparation')
-  .option(
-    '--awaitingWorkspaceStatus <status>',
-    'Status for issues awaiting workspace',
-  )
-  .option(
-    '--awaitingQualityCheckStatus <status>',
-    'Status for issues awaiting quality check',
-  )
   .option(
     '--thresholdForAutoReject <count>',
     'Threshold for auto-escalation after consecutive rejections (default: 3)',
@@ -398,9 +332,6 @@ program
 
     const cliOverrides: ConfigFile = {
       projectUrl: options.projectUrl,
-      preparationStatus: options.preparationStatus,
-      awaitingWorkspaceStatus: options.awaitingWorkspaceStatus,
-      awaitingQualityCheckStatus: options.awaitingQualityCheckStatus,
       thresholdForAutoReject: options.thresholdForAutoReject
         ? Number(options.thresholdForAutoReject)
         : undefined,
@@ -426,9 +357,6 @@ program
     );
 
     const projectUrl = config.projectUrl;
-    const preparationStatus = config.preparationStatus;
-    const awaitingWorkspaceStatus = config.awaitingWorkspaceStatus;
-    const awaitingQualityCheckStatus = config.awaitingQualityCheckStatus;
 
     if (!projectUrl) {
       console.error(
@@ -436,24 +364,6 @@ program
       );
       process.exit(1);
     }
-    if (!preparationStatus) {
-      console.error(
-        'preparationStatus is required. Provide via --preparationStatus, config file, or project README.',
-      );
-      process.exit(1);
-    }
-    if (!awaitingWorkspaceStatus) {
-      console.error(
-        'awaitingWorkspaceStatus is required. Provide via --awaitingWorkspaceStatus, config file, or project README.',
-      );
-      process.exit(1);
-    }
-    if (!awaitingQualityCheckStatus) {
-      console.error(
-        'awaitingQualityCheckStatus is required. Provide via --awaitingQualityCheckStatus, config file, or project README.',
-      );
-      process.exit(1);
-    }
 
     let thresholdForAutoReject = 3;
     const rawThreshold = config.thresholdForAutoReject;
@@ -487,16 +397,9 @@ program
       cachePath,
       token,
     );
-    const projectRepository = {
-      ...new GraphqlProjectRepository(...githubRepositoryParams),
-
-      prepareStatus: async (
-        _name: string,
-        project: Project,
-      ): Promise<Project> => {
-        return project;
-      },
-    };
+    const projectRepository = new GraphqlProjectRepository(
+      ...githubRepositoryParams,
+    );
     const apiV3IssueRepository = new ApiV3IssueRepository(
       ...githubRepositoryParams,
     );
@@ -526,9 +429,6 @@ program
     await useCase.run({
       projectUrl,
       issueUrl: options.issueUrl,
-      preparationStatus,
-      awaitingWorkspaceStatus,
-      awaitingQualityCheckStatus,
       thresholdForAutoReject,
       workflowBlockerResolvedWebhookUrl,
     });