gentle-pi 2.2.0 → 2.3.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +51 -80
- package/assets/agents/review-readability.md +0 -2
- package/assets/agents/review-reliability.md +0 -2
- package/assets/agents/review-resilience.md +0 -2
- package/assets/agents/review-risk.md +0 -2
- package/assets/agents/sdd-apply.md +5 -3
- package/assets/agents/sdd-proposal.md +2 -0
- package/assets/agents/sdd-research.md +54 -0
- package/assets/agents/sdd-status.md +4 -4
- package/assets/agents/sdd-tasks.md +2 -3
- package/assets/agents/sdd-verify.md +21 -1
- package/assets/chains/sdd-full.chain.md +1 -1
- package/assets/chains/sdd-verify.chain.md +1 -1
- package/assets/orchestrator-delegation.md +54 -248
- package/assets/orchestrator-memory.md +2 -0
- package/assets/orchestrator.md +22 -38
- package/assets/sdd-orchestrator-workflow.md +30 -37
- package/assets/support/sdd-status-contract.md +7 -7
- package/contracts/review-integration/v1/schemas/transition-execution.schema.json +42 -0
- package/contracts/review-integration/v2/schemas/last-event-closure.schema.json +66 -0
- package/contracts/review-integration/v2/schemas/opencode-provider-role.schema.json +14 -0
- package/docs/native-authority-architecture.md +9 -11
- package/docs/review-integration.md +27 -373
- package/extensions/ask-user-choice.ts +151 -0
- package/extensions/gentle-ai.ts +1778 -3673
- package/extensions/quiet-tools.ts +515 -32
- package/extensions/sdd-init.ts +4 -8
- package/lib/gentle-ai-renderer.ts +70 -0
- package/lib/model-routing-authority.ts +133 -0
- package/lib/native-review-cli.ts +372 -940
- package/lib/opaque-pi-reviewer-adapter.ts +284 -0
- package/lib/review-candidate-view.ts +341 -132
- package/lib/review-host-relay.ts +210 -68
- package/lib/review-integration-v2.ts +839 -307
- package/lib/review-last-event-controller.ts +35 -0
- package/lib/sdd-preflight.ts +177 -66
- package/lib/sdd-status.ts +66 -111
- package/lib/terminal-theme.ts +1 -1
- package/package.json +83 -82
- package/runtime/gentle-ai-binary.mjs +1 -1
- package/runtime/native-review-cli.mjs +322 -890
- package/runtime/review-integration-v2.mjs +789 -257
- package/runtime/review-relay-contract.mjs +1 -1
- package/scripts/{build-git-commit-transaction-runner.mjs → build-runtime-modules.mjs} +4 -5
- package/scripts/gentle-ai-installer.mjs +75 -22
- package/scripts/maintainer/provider-relay-matrix.mjs +195 -11
- package/scripts/test-packed-runner.mjs +4 -7
- package/scripts/verify-package-files.mjs +12 -13
- package/skills/_shared/review-ledger-contract.md +8 -14
- package/skills/chained-pr/SKILL.md +3 -0
- package/skills/cognitive-doc-design/SKILL.md +1 -1
- package/skills/comment-writer/SKILL.md +1 -1
- package/skills/gentle-ai/SKILL.md +7 -74
- package/skills/judgment-day/SKILL.md +5 -7
- package/skills/rdd-defect-workflow/SKILL.md +3 -3
- package/skills/release/SKILL.md +3 -3
- package/skills/skill-registry/SKILL.md +1 -1
- package/skills/work-unit-commits/SKILL.md +3 -1
- package/tests/artifact-language.test.ts +24 -11
- package/tests/ask-user-choice.test.ts +264 -0
- package/tests/codegraph-tools.test.ts +3 -3
- package/tests/crosslane/cross-lane.mjs +15 -1168
- package/tests/delegated-key-learnings-contract.test.ts +8 -6
- package/tests/devbinary/native-review-parity.devtest.ts +167 -250
- package/tests/devbinary/pi-host-relay.devtest.ts +867 -0
- package/tests/fixtures/devbinary/last-event-capture-correction-plan.captured.json +10 -0
- package/tests/fixtures/devbinary/last-event-capture-refuter-approved.captured.json +20 -0
- package/tests/fixtures/devbinary/last-event-capture-refuter-correction-required.captured.json +26 -0
- package/tests/fixtures/devbinary/last-event-capture-result-approved.captured.json +8 -0
- package/tests/fixtures/devbinary/last-event-capture-result-correction-required.captured.json +26 -0
- package/tests/fixtures/devbinary/last-event-capture-validation-approved.captured.json +8 -0
- package/tests/fixtures/devbinary/last-event-closure.provenance.md +13 -0
- package/tests/fixtures/devbinary/review-acknowledged-v1.captured.json +9 -0
- package/tests/fixtures/devbinary/review-acknowledged.provenance.md +31 -0
- package/tests/fixtures/devbinary/start-v3-zero-lens-closed.captured.json +21 -0
- package/tests/fixtures/native-review-cli/v2.5.0-rc.1/PROVENANCE.txt +15 -0
- package/tests/gentle-ai-binary.test.ts +83 -13
- package/tests/gentle-ai-dev-binary.test.ts +51 -228
- package/tests/gentle-ai-installer.test.ts +137 -47
- package/tests/gentle-ai.test.ts +820 -131
- package/tests/gentle-theme.test.ts +133 -0
- package/tests/maintainer/provider-relay.maintest.ts +340 -4
- package/tests/model-routing-authority.test.ts +257 -0
- package/tests/native-review-capability-contract.test.ts +28 -1
- package/tests/native-review-cli.test.ts +586 -962
- package/tests/native-review-consent.test.ts +150 -66
- package/tests/native-review-parity-runtime.test.ts +80 -359
- package/tests/native-review-parity.test.ts +674 -925
- package/tests/opaque-pi-reviewer-adapter.test.ts +266 -0
- package/tests/orchestrator-budget.test.ts +132 -88
- package/tests/orchestrator-rdd-ownership.test.ts +103 -0
- package/tests/package-manifest.test.ts +37 -35
- package/tests/provider-defect-handoff.test.ts +15 -118
- package/tests/quiet-tool-rendering.test.ts +1055 -28
- package/tests/review-authority-recovery-docs.test.ts +1 -2
- package/tests/review-candidate-view.test.ts +409 -3
- package/tests/review-compact-contract.test.ts +4 -30
- package/tests/review-controller-lock-status.test.ts +2 -2
- package/tests/review-controller-native-recovery.test.ts +363 -1450
- package/tests/review-controller-native-routing.test.ts +1251 -5642
- package/tests/review-controller-retired-ops.test.ts +1 -1
- package/tests/review-controller-workspace-root.test.ts +222 -71
- package/tests/review-controller.test.ts +26 -816
- package/tests/review-corrected-finalize-binding.test.ts +112 -153
- package/tests/review-dispatch-hydration-gap.test.ts +1 -53
- package/tests/review-gate.test.ts +0 -45
- package/tests/review-host-relay-restart-parity.test.ts +360 -0
- package/tests/review-host-relay-routing.test.ts +117 -82
- package/tests/review-host-relay.test.ts +242 -8
- package/tests/review-integration-v2-forward.test.ts +576 -553
- package/tests/review-integration-v2.test.ts +239 -165
- package/tests/review-last-event-closure.test.ts +408 -0
- package/tests/review-ledger-contract.test.ts +97 -35
- package/tests/review-recovered-lineage-routing.test.ts +0 -47
- package/tests/review-relay-transport-agent.test.ts +119 -46
- package/tests/review-snapshot.test.ts +3 -2
- package/tests/runtime-harness.mjs +361 -196
- package/tests/sdd-agent-tools.test.ts +36 -0
- package/tests/sdd-preflight.test.ts +81 -15
- package/tests/sdd-status.test.ts +109 -110
- package/tests/skill-collision-prefixes.test.ts +5 -8
- package/tests/writer-edit-surface-scope.test.ts +230 -0
- package/themes/Gentleman-Cute.json +94 -0
- package/themes/Gentleman-Sexy.json +92 -0
- package/lib/git-commit-transaction.ts +0 -861
- package/runtime/git-commit-transaction.mjs +0 -862
- package/scripts/run-git-commit-transaction.mjs +0 -35
- package/tests/fixtures/native-review-cli/v2.1.3/sdd-status-engram.json +0 -139
- package/tests/fixtures/native-review-cli/v2.1.3/sdd-status.json +0 -200
- package/tests/git-commit-transaction.test.ts +0 -530
package/assets/orchestrator.md
CHANGED
|
@@ -8,6 +8,8 @@ Defined once in the identity/harness section injected above (the `Current person
|
|
|
8
8
|
|
|
9
9
|
## Core Role
|
|
10
10
|
|
|
11
|
+
Package assets root: `{{GENTLE_PI_ASSETS_ROOT}}`. Lazy asset paths below are relative to this root.
|
|
12
|
+
|
|
11
13
|
You are a COORDINATOR, not the default executor for substantial work. Maintain one thin conversation thread, delegate real phase work to Pi subagents when available, and synthesize results for the user.
|
|
12
14
|
|
|
13
15
|
Keep synthesis short by default: decision, outcome, next action. Expand only when the user asks or the situation requires detail.
|
|
@@ -20,7 +22,7 @@ Generated technical artifacts — whether by the parent inline or by subagents
|
|
|
20
22
|
|
|
21
23
|
Public/contextual comments and replies are different from technical artifacts. When using `comment-writer` or drafting a human-facing GitHub, PR review, Slack, Discord, or async comment, write in the target context language by default. Spanish issue/thread -> Spanish comment. English thread -> English comment. Mixed context -> target message language. Explicit user language or tone override wins. Spanish comments default to neutral/professional Spanish unless the user or target context clearly calls for regional tone.
|
|
22
24
|
|
|
23
|
-
Subagent-facing English delegation and the quote/UI/SDD-artifact exceptions: `
|
|
25
|
+
Subagent-facing English delegation and the quote/UI/SDD-artifact exceptions: `orchestrator-delegation.md`.
|
|
24
26
|
|
|
25
27
|
## Mental Model
|
|
26
28
|
|
|
@@ -38,60 +40,56 @@ Delegation is not optional once complexity appears. If a task crosses the trigge
|
|
|
38
40
|
Route work through the smallest harness that is safe. Three tiers:
|
|
39
41
|
|
|
40
42
|
1. **Inline Direct** — small, mechanical, parent has context (typo, one-file edit, read-only check of 1-3 known files, bash for state). No SDD ceremony; stop when it is no longer small.
|
|
41
|
-
2. **Simple Delegation** — generic non-SDD exploration → `gentle-ai-explore`; bounded implementation → `gentle-ai-worker`; command-running generic non-SDD verification → `gentle-ai-verify`. Try its package role; if missing/unusable, use native `Agent` under the same read-only mapping/verification constraints and report fallback. SDD roles stay inside SDD
|
|
42
|
-
3. **SDD (optional)** — selected only by an explicit request (`/sdd-new`/`/sdd-ff`/`/sdd-continue` or a direct ask) or an accepted proposal; size, file count, or risk alone never selects SDD. Suggest it organically when durable proposal/spec/design/tasks would materially reduce substantial ambiguity. Once selected, do not jump to implementation; create artifacts and gate for approval.
|
|
43
|
+
2. **Simple Delegation** — generic non-SDD exploration → `gentle-ai-explore`; bounded implementation → `gentle-ai-worker`; command-running generic non-SDD verification → `gentle-ai-verify`. Try its package role; if missing/unusable, use native `Agent` under the same read-only mapping/verification constraints and report fallback. SDD roles stay inside SDD.
|
|
44
|
+
3. **SDD (optional)** — selected only by an explicit request (`/gentle-sdd-new`/`/gentle-sdd-ff`/`/gentle-sdd-continue` or a direct ask) or an accepted proposal; size, file count, or risk alone never selects SDD. Suggest it organically when durable proposal/spec/design/tasks would materially reduce substantial ambiguity. Once selected, do not jump to implementation; create artifacts and gate for approval.
|
|
43
45
|
|
|
44
46
|
## Delegation Rules
|
|
45
47
|
|
|
46
48
|
Core question: does this inflate parent context without need?
|
|
47
49
|
|
|
48
|
-
The canonical per-action table is the mirrored gentle-ai canon Delegation Rules table in `
|
|
50
|
+
The canonical per-action table is the mirrored gentle-ai canon Delegation Rules table in `orchestrator-delegation.md`.
|
|
51
|
+
|
|
52
|
+
Before launching bounded writer (`gentle-ai-worker` or `worker`), task/context needs nonempty `## Allowed edit surfaces`: narrow repository-relative paths/globs; never `.`, bare repo root, or absolute. Parent derives surfaces, maps unknown targets read-only, shows derived candidates only for genuine scope choices. Do not ask the human to author paths or globs.
|
|
49
53
|
|
|
50
54
|
Mandatory Delegation Triggers — stop rules; once fired, delegate through the best available subagent runtime (prefer `subagent_run`, else Pi's native `Agent`):
|
|
51
55
|
|
|
52
56
|
1. **4-file rule** — 4+ files to understand → delegate a scout/mapping task.
|
|
53
57
|
2. **Multi-file write rule** — 2+ non-trivial files touched → delegate one writer.
|
|
54
|
-
3. **
|
|
55
|
-
4. **
|
|
56
|
-
5. **
|
|
57
|
-
6. **Long-session rule** — ~20 tool calls, 5 exploratory reads, or 2 non-mechanical edits without delegation → pause and delegate.
|
|
58
|
-
7. **Review actor rule** — review lenses run only when selected by ordinary transaction start; explicit Judgment Day uses its two named judges. Lifecycle and SDD boundaries launch zero review actors.
|
|
58
|
+
3. **Incident rule** — diagnose wrong cwd/worktree/git/tooling incidents separately before resuming work.
|
|
59
|
+
4. **Verification rule** — executing/delegating verification commands → `gentle-ai-verify`; only the 1-3-file read-only check stays inline.
|
|
60
|
+
5. **Long-session rule** — ~20 tool calls, 5 exploratory reads, or 2 non-mechanical edits without delegation → pause and delegate.
|
|
59
61
|
|
|
60
62
|
{{GENTLE_PI_BACKGROUND_POLICY}}; rules: the background-subagents block in the delegation contract.
|
|
61
63
|
|
|
62
|
-
Full table, Work Routing Ladder examples/model-routing detail, Cost and Context Balance, Canonical Workflows,
|
|
64
|
+
Full table, Work Routing Ladder examples/model-routing detail, Cost and Context Balance, Canonical Workflows, and the mirrored gentle-ai canon (blocking-prompt relays, language, and delegation): `orchestrator-delegation.md`.
|
|
63
65
|
|
|
64
66
|
## SDD Workflow (lazy-loaded)
|
|
65
67
|
|
|
66
68
|
The detailed SDD workflow is intentionally not embedded in this always-on parent prompt. Before handling any `/sdd-*` command, natural-language SDD request, SDD continuation/routing, apply/verify/sync/archive work, or SDD/Judgment-Day phase delegation, read this package asset first:
|
|
67
69
|
|
|
68
|
-
`
|
|
70
|
+
`sdd-orchestrator-workflow.md`
|
|
69
71
|
|
|
70
72
|
That lazy surface contains the SDD phases, native dispatcher rules, status contract, preflight/init guards, artifact-store policy, execution mode, Strict TDD forwarding, phase result contract, and review workload guard.
|
|
71
73
|
|
|
72
|
-
Hard preflight invariant: `openspec/config.yaml`, existing SDD changes, installed `.pi`/global SDD assets, or a todo named "preflight" are not session preflight. Do not mark SDD preflight complete, start `sdd-init`, launch SDD subagents/chains, or move to explore/proposal/spec/design/tasks until this session has
|
|
74
|
+
Hard preflight invariant: `openspec/config.yaml`, existing SDD changes, installed `.pi`/global SDD assets, or a todo named "preflight" are not session preflight. Do not mark SDD preflight complete, start `sdd-init`, launch SDD subagents/chains, or move to explore/proposal/spec/design/tasks until this session has an injected `## SDD Session Preflight` block or a canonical-authority resolution. Defaults and capability constraints may resolve fields without confirmation prompts; preserve unresolved-choice and safety gates.
|
|
73
75
|
|
|
74
76
|
## Memory Contract
|
|
75
77
|
|
|
76
|
-
When
|
|
77
|
-
|
|
78
|
-
### Non-SDD delegation
|
|
79
|
-
|
|
80
|
-
- Read context: the parent/orchestrator searches memory (the injected Engram search tool), selects relevant observations, and passes them into the subagent prompt. The subagent does NOT search memory itself.
|
|
81
|
-
- Write context: the subagent MUST save significant discoveries, decisions, or bug fixes via the injected Engram save tool before returning when memory tools are available.
|
|
82
|
-
- Prompt forwarding: when delegating, add a concrete instruction such as: `If you make important discoveries, decisions, or fix bugs, save them to Engram via the available memory save tool with project: '<project>' before returning.`
|
|
83
|
-
|
|
84
|
-
SDD phase table, artifact keys, and the lifecycle rule: `{{GENTLE_PI_MEMORY_PATH}}`.
|
|
78
|
+
When memory is available, the parent selects context and subagents save significant discoveries before returning. SDD phase table, artifact keys, and persistence guidance: `orchestrator-memory.md`.
|
|
85
79
|
|
|
86
80
|
## Skill Registry Protocol
|
|
87
81
|
|
|
88
|
-
The parent resolves
|
|
82
|
+
The parent resolves matching skill paths once per session and passes them under `## Skills to load before work`. Subagents read those exact `SKILL.md` files before work; if the registry is absent, report that project-specific paths were unavailable.
|
|
89
83
|
|
|
90
|
-
Fallback-report semantics (`paths-injected`/`fallback-registry`/`fallback-path`/`none`) and the SDD-executor skill distinction: `
|
|
84
|
+
Fallback-report semantics (`paths-injected`/`fallback-registry`/`fallback-path`/`none`) and the SDD-executor skill distinction: `orchestrator-skills.md`.
|
|
91
85
|
|
|
92
86
|
## Intent-Driven Skill Discovery
|
|
93
87
|
|
|
94
|
-
For skill-shaped requests, do not treat injected `<available_skills>` as complete; use the registry/filesystem only as a discovery aid, never to override a small request or a user's concrete ask. Discovery order, the common intent-hint table, and fallback behavior when no skill matches: `
|
|
88
|
+
For skill-shaped requests, do not treat injected `<available_skills>` as complete; use the registry/filesystem only as a discovery aid, never to override a small request or a user's concrete ask. Discovery order, the common intent-hint table, and fallback behavior when no skill matches: `orchestrator-skills.md`.
|
|
89
|
+
|
|
90
|
+
## Gentle AI RDD ownership
|
|
91
|
+
|
|
92
|
+
Gentle AI dynamically supplies runtime-specific RDD instructions via generated Pi APPEND_SYSTEM composition. Follow only those exact native instructions; if absent or unsupported, this package does not invent or fall back.
|
|
95
93
|
|
|
96
94
|
## Safety
|
|
97
95
|
|
|
@@ -100,17 +98,3 @@ For skill-shaped requests, do not treat injected `<available_skills>` as complet
|
|
|
100
98
|
- Ask before destructive git operations, publishing, or irreversible file changes.
|
|
101
99
|
- Keep writes single-threaded unless isolated worktrees are explicitly approved.
|
|
102
100
|
- Preserve human control: user decisions beat agent momentum.
|
|
103
|
-
|
|
104
|
-
## Bounded Review Transactions
|
|
105
|
-
|
|
106
|
-
Compact `gentle_review` uses `start -> finalize -> validate`; START freezes scope, risk, and budget; FINALIZE permits one correction, failure escalates.
|
|
107
|
-
|
|
108
|
-
Compact gates use zero actors and rederive authority, target, and evidence. Pi adds one-shot authorization. Legacy authority is read-only; Judgment Day is separate.
|
|
109
|
-
Release from protected `main` may bypass receipt validation only when its immutable remote SHA and required CI are proven; otherwise native receipt validation applies.
|
|
110
|
-
Major and post-incident releases require explicit extraordinary review even when fast-path checks pass.
|
|
111
|
-
|
|
112
|
-
Dangerous-command safety remains independent and authoritative.
|
|
113
|
-
|
|
114
|
-
SDD completion adds no review or Judgment Day pass.
|
|
115
|
-
|
|
116
|
-
Controller and actor contract: `{{GENTLE_PI_DELEGATION_PATH}}`.
|
|
@@ -7,21 +7,22 @@ This is the lazy-loaded SDD workflow surface for el Gentleman on Pi. Read this f
|
|
|
7
7
|
SDD phases:
|
|
8
8
|
|
|
9
9
|
```text
|
|
10
|
-
init → explore → proposal → spec → design → tasks → apply → verify → sync → archive
|
|
10
|
+
init → explore → research (optional) → proposal → spec → design → tasks → apply → verify → sync → archive
|
|
11
11
|
```
|
|
12
12
|
|
|
13
13
|
Dependency graph:
|
|
14
14
|
|
|
15
15
|
```text
|
|
16
|
+
explore → research (optional) → proposal
|
|
16
17
|
proposal → spec ─┬→ tasks → apply → verify → sync → archive
|
|
17
18
|
proposal → design ┘
|
|
18
19
|
```
|
|
19
20
|
|
|
20
|
-
`/sdd-status [change]` is the read-only status action for resolving the active change, artifact paths, task progress, dependency readiness, and action context before apply/verify/sync/archive.
|
|
21
|
+
`/gentle-sdd-status [change]` is the read-only status action for resolving the active change, artifact paths, task progress, dependency readiness, and action context before apply/verify/sync/archive.
|
|
21
22
|
|
|
22
23
|
## Native SDD Dispatcher
|
|
23
24
|
|
|
24
|
-
The user expresses intent; they should not have to administer phases manually. For natural-language SDD requests and `/sdd-continue`, the parent/orchestrator must use the native status engine as the state authority, decide the next phase, and delegate only the phase that status marks ready.
|
|
25
|
+
The user expresses intent; they should not have to administer phases manually. For natural-language SDD requests and `/gentle-sdd-continue`, the parent/orchestrator must use the native status engine as the state authority, decide the next phase, and delegate only the phase that status marks ready.
|
|
25
26
|
|
|
26
27
|
Flow:
|
|
27
28
|
|
|
@@ -31,8 +32,8 @@ user intent → preflight/init guard → native status engine → phase decision
|
|
|
31
32
|
|
|
32
33
|
Rules:
|
|
33
34
|
|
|
34
|
-
- `/sdd-status` is a debug/status command, not the main UX.
|
|
35
|
-
- `/sdd-continue` is the native dispatcher command: resolve status, choose the next ready phase, and carry status/instructions into the subagent prompt.
|
|
35
|
+
- `/gentle-sdd-status` is a debug/status command, not the main UX.
|
|
36
|
+
- `/gentle-sdd-continue` is the native dispatcher command: resolve status, choose the next ready phase, and carry status/instructions into the subagent prompt.
|
|
36
37
|
- `sdd-apply`, `sdd-verify`, `sdd-sync`, and `sdd-archive` must obey parent-provided native status; they must not reconstruct readiness from prompt inference when status JSON is present.
|
|
37
38
|
- Do not launch a phase when native status marks that dependency `blocked`.
|
|
38
39
|
- `sdd-archive` cannot proceed unless native status says `dependencies.archive` is `ready` or `all_done` — UNLESS the store carve-out is active (`nextRecommended: "resolve-via-engram"`), in which case resolve archive readiness from Engram instead of treating `not_applicable` as a gate failure.
|
|
@@ -40,7 +41,7 @@ Rules:
|
|
|
40
41
|
|
|
41
42
|
## SDD Status Contract
|
|
42
43
|
|
|
43
|
-
Before `/sdd-continue`, `sdd-apply`, `sdd-verify`, `sdd-sync`, or `sdd-archive`, resolve and carry structured status. Lookup order: parent-provided status, then project override `.pi/gentle-ai/support/sdd-status-contract.md`, then globally installed `~/.pi/agent/gentle-ai/support/sdd-status-contract.md`, then the embedded `sdd-status` prompt contract. Do not use `assets/support/...` as a runtime path; that is only the package source path before installation.
|
|
44
|
+
Before `/gentle-sdd-continue`, `sdd-apply`, `sdd-verify`, `sdd-sync`, or `sdd-archive`, resolve and carry structured status. Lookup order: parent-provided status, then project override `.pi/gentle-ai/support/sdd-status-contract.md`, then globally installed `~/.pi/agent/gentle-ai/support/sdd-status-contract.md`, then the embedded `sdd-status` prompt contract. Do not use `assets/support/...` as a runtime path; that is only the package source path before installation.
|
|
44
45
|
|
|
45
46
|
Status must include:
|
|
46
47
|
|
|
@@ -55,23 +56,17 @@ Do not guess the active change. If change selection is ambiguous, ask the user a
|
|
|
55
56
|
|
|
56
57
|
## Lazy SDD Preflight
|
|
57
58
|
|
|
58
|
-
Do not ask SDD setup questions on session start. The first time the user initiates an SDD process in a Pi session, run the SDD preflight once and keep those choices for the rest of that session. Runtime trigger detection is intentionally deterministic: slash SDD flows and `/sdd-init` run preflight automatically; for natural-language requests, the parent/orchestrator decides semantically whether SDD is needed and must run/reuse `/gentle:sdd-preflight` before continuing.
|
|
59
|
+
Do not ask SDD setup questions on session start. The first time the user initiates an SDD process in a Pi session, run the SDD preflight once and keep those choices for the rest of that session. Runtime trigger detection is intentionally deterministic: slash SDD flows and `/gentle-sdd-init` run preflight automatically; for natural-language requests, the parent/orchestrator decides semantically whether SDD is needed and must run/reuse `/gentle:sdd-preflight` before continuing.
|
|
59
60
|
|
|
60
|
-
**Hard gate:** `openspec/config.yaml`, existing SDD changes, installed `.pi`/global SDD assets, or a todo named "preflight" are not session preflight. They are project context only. Do not mark SDD preflight complete, start `sdd-init`, launch SDD subagents/chains, or move to explore/proposal/spec/design/tasks until this session has
|
|
61
|
+
**Hard gate:** `openspec/config.yaml`, existing SDD changes, installed `.pi`/global SDD assets, or a todo named "preflight" are not session preflight. They are project context only. Do not mark SDD preflight complete, start `sdd-init`, launch SDD subagents/chains, or move to explore/proposal/spec/design/tasks until this session has an injected `## SDD Session Preflight` block or an equivalent resolution from the canonical authority order below.
|
|
61
62
|
|
|
62
|
-
1.
|
|
63
|
-
2. an explicit user answer in the current conversation covering all four preflight choices below.
|
|
63
|
+
Resolve each field in this order: (1) explicit current user/session choice, (2) valid persisted preference, (3) capability or already-selected strategy constraint, (4) canonical documented default, and (5) ask only when the field is genuinely unresolved. If `/gentle:sdd-preflight` cannot be invoked, resolve the same order inline; do not recreate a four-question setup prompt. Missing Engram is a capability constraint that resolves the artifact store to `openspec` unless the user has made an incompatible explicit request, which remains a human decision.
|
|
64
64
|
|
|
65
|
-
|
|
65
|
+
Preflight canonical defaults are execution `auto`, artifact store `openspec`, delivery strategy `ask-on-risk`, and review budget `400`; capability and already-selected constraints may narrow them.
|
|
66
66
|
|
|
67
|
-
|
|
67
|
+
Selectors/inputs appear only for genuinely unresolved fields. Defaulted and one-option fields do not prompt; persisted/session values are reused, and an explicit current choice overrides them when presented. `chain_strategy` remains deferred, and `exception-ok` requires explicit `size:exception` acceptance and is never inferred.
|
|
68
68
|
|
|
69
|
-
-
|
|
70
|
-
- artifact store: `openspec`, `engram`, or `both` when callable memory tools are available;
|
|
71
|
-
- chained PR strategy: the canonical `delivery_strategy` — `ask-on-risk`, `auto-chain`, `single-pr`, or `exception-ok`. The preflight menu offers the first three; `exception-ok` is reachable only when the user explicitly accepts `size:exception`, either up front or when `ask-on-risk` stops to ask;
|
|
72
|
-
- review budget in changed lines.
|
|
73
|
-
|
|
74
|
-
Those four PR values are exactly the `delivery_strategy` domain `sdd-tasks` and `sdd-apply` accept; never emit a value outside it. The preflight offers no separate chained option because `delivery_strategy` is only consulted once the tasks forecast flags review-budget risk: below that line there is nothing to chain, and above it `auto-chain` already resolves without asking again.
|
|
69
|
+
The exact `delivery_strategy` domain accepted by `sdd-tasks` and `sdd-apply` is `ask-on-risk`, `auto-chain`, `single-pr`, or `exception-ok`; above the review threshold, `auto-chain` resolves without asking again.
|
|
75
70
|
|
|
76
71
|
The package should ensure SDD assets are present as global Pi runtime assets without the user needing to remember per-project setup commands. If assets are missing, install them non-destructively into:
|
|
77
72
|
|
|
@@ -92,9 +87,9 @@ When the store is `openspec` or `both`, the local artifact is:
|
|
|
92
87
|
openspec/config.yaml
|
|
93
88
|
```
|
|
94
89
|
|
|
95
|
-
If it is missing, ask the user for the minimal information needed or run `/sdd-init` if available.
|
|
90
|
+
If it is missing, ask the user for the minimal information needed or run `/gentle-sdd-init` if available.
|
|
96
91
|
|
|
97
|
-
When the store is `engram` or `none`, `/sdd-init` never writes that file, so its absence is expected and is not a missing init. Never re-trigger `/sdd-init` over it. Resolve project context from the Engram `sdd-init/{project}` topic for `engram`, or inline from the session for `none`, and ask the user only when that context is genuinely absent.
|
|
92
|
+
When the store is `engram` or `none`, `/gentle-sdd-init` never writes that file, so its absence is expected and is not a missing init. Never re-trigger `/gentle-sdd-init` over it. Resolve project context from the Engram `sdd-init/{project}` topic for `engram`, or inline from the session for `none`, and ask the user only when that context is genuinely absent.
|
|
98
93
|
|
|
99
94
|
This init guard runs after the session preflight gate above; project config presence or absence never substitutes for session preflight choices. Do not proceed with a substantial SDD flow while pretending project context, testing capability, or session preflight choices are known.
|
|
100
95
|
|
|
@@ -125,6 +120,18 @@ Interactive approval is phase-scoped. A user response such as "continue", "dale"
|
|
|
125
120
|
|
|
126
121
|
Before `sdd-proposal` in interactive mode, offer the user a proposal question round instead of silently deciding whether the proposal is clear enough. Explain that the questions are meant to improve the PRD/proposal by uncovering business understanding, business rules, implications, impact, edge cases, and product tradeoffs. Prefer 3–5 concrete product questions per round, then summarize the resulting assumptions and ask whether the user wants to correct anything or run a second question round. Cover business/product/PRD decisions: business problem, target users and situations, business rules, product outcome, current-state gap, implications and impact, edge cases, decision gaps, first-slice scope boundaries, non-goals, product constraints, and business tradeoffs. Do not ask about test commands, PR shape, changed-line budget, or other harness mechanics at proposal time unless the user explicitly asks to discuss delivery.
|
|
127
122
|
|
|
123
|
+
## Research and Pre-Proposal Gate
|
|
124
|
+
|
|
125
|
+
This gate is MANDATORY and applies in both execution modes; in interactive mode it runs alongside the proposal question round above, and the two never contradict: the question round shapes the proposal, the gate decides whether `sdd-proposal` may launch at all.
|
|
126
|
+
|
|
127
|
+
- Offer `sdd-research` immediately after `sdd-explore`. Research is optional until selected; selection makes completion mandatory.
|
|
128
|
+
- Before every proposal, invoke `sdd-proposal` only when selected research is `done` or research is unselected, product decisions are `confirmed`, evidence references are valid, and the selected artifact-store state is ready.
|
|
129
|
+
- The orchestrator owns product discovery. In automatic mode, unresolved product choices require one lossless grouped prompt with all context, options, consequences, allowed answers, and exact tokens; the orchestrator MUST persist the pending pre-proposal state before prompting, then STOP without invoking `sdd-proposal`.
|
|
130
|
+
- The proposer receives a confirmed pre-proposal handoff and MUST NOT interview the user or infer consent.
|
|
131
|
+
- Pi's native `gentle-pi.sdd-status` contract remains the sole status contract. Research and pre-proposal state are orchestrator-owned prose and artifacts (`sdd/{change}/research`, `sdd/{change}/preproposal`, `openspec/changes/{change}/research.md`) layered on top — never a native status field.
|
|
132
|
+
|
|
133
|
+
Runtime note: this runtime declares no evidence grants (`documentation=[]; open-web=[]`), so a SELECTED research lane fail-closes to a `blocked` outcome and blocks proposal readiness until the user deselects research or evidence capability arrives. SDD chains treat research as unselected.
|
|
134
|
+
|
|
128
135
|
## Delivery Strategy
|
|
129
136
|
|
|
130
137
|
On the first SDD chain request in a session, resolve the delivery strategy from preflight (or ask once) and cache it:
|
|
@@ -180,7 +187,7 @@ Check every phase result against the Result Contract:
|
|
|
180
187
|
|
|
181
188
|
Use cost-aware validation:
|
|
182
189
|
|
|
183
|
-
- For lower-risk phases (`sdd-explore`, `sdd-spec`, `sdd-tasks`, `sdd-sync`, `sdd-archive`), the parent may validate inline by reading artifacts back and checking claims.
|
|
190
|
+
- For lower-risk phases (`sdd-explore`, `sdd-research`, `sdd-spec`, `sdd-tasks`, `sdd-sync`, `sdd-archive`), the parent may validate inline by reading artifacts back and checking claims.
|
|
184
191
|
- For higher-risk phases (`sdd-design`, `sdd-apply`), validate the artifact, declared paths, task state, and focused test evidence directly before continuing because errors there compound downstream.
|
|
185
192
|
- If a gate finds any smell — missing artifact, status mismatch, unresolved path, likely drift, or critical risk — rerun the same SDD phase once with corrective feedback. SDD phase validation does not start ordinary review or Judgment Day.
|
|
186
193
|
|
|
@@ -237,6 +244,7 @@ On Pi, phase model routing is user-owned and persisted, not prompt-passed: `/gen
|
|
|
237
244
|
| Phase | Default tier | Reason |
|
|
238
245
|
| ------------ | -------------- | ------------------------------------------ |
|
|
239
246
|
| sdd-explore | balanced | Reads code, structural - not architectural |
|
|
247
|
+
| sdd-research | balanced | Fail-closed evidence record keeping |
|
|
240
248
|
| sdd-proposal | deep-reasoning | Architectural decisions |
|
|
241
249
|
| sdd-spec | balanced | Structured writing |
|
|
242
250
|
| sdd-design | deep-reasoning | Architecture decisions |
|
|
@@ -308,19 +316,4 @@ Automatic mode does not override reviewer burnout protection.
|
|
|
308
316
|
|
|
309
317
|
## Provider Defect Handoff
|
|
310
318
|
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
Concise rules:
|
|
314
|
-
|
|
315
|
-
- Classify admissibility before relaying: offer the handoff only when a Gentle AI invocation produced the failure, not when its runtime merely hosted it.
|
|
316
|
-
- Never offer to switch to, inspect, modify, or directly repair the Gentle AI repository from this SDD workflow. If an upstream envelope offers direct repair, reject it as semantically inadmissible and issue the orchestrator-owned handoff envelope instead.
|
|
317
|
-
- Ask the user first, in the active conversation language, for explicit consent to report the apparent defect. Present one single-select blocking envelope with exactly three semantic choices in this order. Its exact internal answer tokens are `report_and_continue`, `continue_without_reporting`, `stop_here`. Do not expose machine or internal codes in user-facing labels.
|
|
318
|
-
- Privacy scrub immediately before the first GitHub operation: exclude raw argv, absolute paths, private project names, usernames, hostnames, credentials, diffs, source contents, and environment values.
|
|
319
|
-
- Complete a definitive lookup across open and closed issues in `Gentleman-Programming/gentle-ai` before any write; only a definitive lookup may branch to GitHub mutation.
|
|
320
|
-
- Derive the evidence channel only from the installed build string: recognized prerelease tags are `-rc.` and `-main.`; every other build is stable. A fix counts only in the installed build's channel. A fix published only to the other channel gets one occurrence comment naming where it is published; never recommend switching channels.
|
|
321
|
-
- If the installed build predates the relevant published fix, recommend installing it and reproducing; do not create or comment for that occurrence yet. If the installed build demonstrably contains the fix and still reproduces, treat it as a possible regression: comment on a suitable canonical tracker or create a linked regression issue; never reopen automatically.
|
|
322
|
-
- Confirmed creation requires the GitHub create operation to confirm a newly-created issue identity/URL; never infer creation from output text alone.
|
|
323
|
-
- On search, comment, or creation failure/ambiguity/timeout/permission/unknown: perform no further GitHub mutation and no blind retry; preserve all consumer state, then execute the exact captured provider-owned decline invocation exactly once, validate it, re-enter native negotiated STATUS, and resume the already-held consumer continuation.
|
|
324
|
-
- Both continue choices execute that exact captured decline invocation exactly once; never synthesize the decline command, target, token, or consumer continuation from prose. If unavailable or ambiguous, fail closed.
|
|
325
|
-
- Do not invoke `gentle-ai review mode disable` at clone or global scope within this handoff. Do not turn RDD off or on within this handoff.
|
|
326
|
-
- Resume after an installed published fix or an explicit maintainer-authorized, documented native recovery or reset that the runtime contract supports; then re-enter through native status. Never resume against unpublished code.
|
|
319
|
+
When an SDD task encounters a possible Gentle AI provider defect, the full contract lives in `assets/orchestrator-delegation.md` under `#### Gentle AI Provider Defect Handoff (MANDATORY)`. This workflow intentionally provides no summary, alternate report route, or RDD lifecycle instruction.
|
|
@@ -15,8 +15,8 @@ Any phase that selects, continues, applies, verifies, syncs, or archives an SDD
|
|
|
15
15
|
|
|
16
16
|
## Native Engine
|
|
17
17
|
|
|
18
|
-
-
|
|
19
|
-
- For non-authoritative stores (`engram`, `none`, and `both` without an `openspec/` directory), do not treat
|
|
18
|
+
- For file-backed `openspec` or `both` sessions with an `openspec/` directory, use Gentle Pi's local SDD status engine as the artifact-state authority. It resolves the local artifact graph without consulting RDD authority or receipts.
|
|
19
|
+
- For non-authoritative stores (`engram`, `none`, and `both` without an `openspec/` directory), do not treat disk status output as authoritative; follow Engine Authority by Store below.
|
|
20
20
|
- Runtime-attempt authority is different from artifact dispatch: normal runtime-bearing OpenSpec and Engram continuations MUST bracket external execution with `gentle-ai sdd-attempt acquire|settle --cwd <repo> --change <change>`. Their bounded result contains only `proceed`, `blocked`, or `complete` plus an opaque continuation token when required, and MAY carry `settle_obligation` on a `proceed`. The Git-common-dir immutable chain remains the sole authority for ordinals, cumulative attempt/line budgets, runtime evidence, and atomic bound remediation.
|
|
21
21
|
- A phase actor launched BY a parent that already holds a `proceed`-state acquire for that exact work unit is a distinct call/process, not a fresh continuation: it MUST NOT `acquire` again blind. Colliding with its own parent's active attempt is not a genuine `blocked: active_attempt` (#2291). It authenticates as that SAME attempt by passing the parent's returned token on its own `acquire --token <token>` call: a token matching the ledger's live active attempt returns `proceed` with that same token and zero mutation, while a non-matching token gets the ordinary `blocked: active_attempt` naming the real active token.
|
|
22
22
|
- When `blockedReasons` is non-empty, do not proceed to terminal, archive, or apply work. Return or report `blockedReasons` and stop unless `nextRecommended` is `verify`, in which case verification may run only to remediate or refresh evidence for the blockers. When `nextRecommended` is `resolve-blockers`, always report `blockedReasons` and stop. When `nextRecommended` is a planning token (`propose`, `spec`, `design`, or `tasks`), launch the corresponding planning phase — missing planning artifacts are the expected output of those phases, not genuine blockers.
|
|
@@ -87,7 +87,7 @@ isNonAuthoritative: false # boolean; true when the native engine is not authori
|
|
|
87
87
|
|
|
88
88
|
## Task Ownership
|
|
89
89
|
|
|
90
|
-
|
|
90
|
+
New task checkboxes end with the terminal marker `<!-- sdd-owner: implementation -->`. An unmarked legacy checkbox is implementation-owned. Supported legacy non-implementation rows are informational only. Any line containing `sdd-owner` that is unsupported, duplicated, or non-terminal is malformed: add its exact line to `taskArtifactErrors` and `blockedReasons`, and count it as unresolved implementation work even when checked. `taskProgress` reports implementation work.
|
|
91
91
|
|
|
92
92
|
## Apply State
|
|
93
93
|
|
|
@@ -99,9 +99,9 @@ Each checkbox may end with one terminal marker: `<!-- sdd-owner: implementation
|
|
|
99
99
|
## Dependency States
|
|
100
100
|
|
|
101
101
|
- `apply` is `ready` only when specs, design, and tasks are available and task progress is not all done.
|
|
102
|
-
- `verify` is ready
|
|
102
|
+
- `verify` is ready after implementation completion when tasks are complete or apply-progress exists. RDD authority and receipts never gate the apply -> verify -> sync -> archive route. Unchecked implementation tasks remain CRITICAL blockers for full archive readiness.
|
|
103
103
|
- `sync` is `ready` only when verify-report exists and has no unresolved `FAIL`, `BLOCKED`, `CRITICAL`, or verification blockers. `engram`/`none` modes may mark sync `not_applicable`.
|
|
104
|
-
- `archive` is `ready` only when verify-report exists, sync is complete or not applicable, implementation tasks are complete
|
|
104
|
+
- `archive` is `ready` only when verify-report exists, sync is complete or not applicable, and implementation tasks are complete. CRITICAL verification issues have no override. Explicit recorded exceptions are limited to non-critical partial archives or stale-checkbox reconciliation when apply-progress/verify-report prove completion.
|
|
105
105
|
- `not_applicable`: emitted for non-authoritative stores (engram, none, and both when no `openspec/` directory exists) when `nextRecommended: "resolve-via-engram"` is active. `not_applicable` is NOT a gate failure — readiness must be resolved from Engram instead of from these fields.
|
|
106
106
|
|
|
107
107
|
## Action Context Guard
|
|
@@ -114,8 +114,8 @@ The orchestrator MUST carry `actionContext` into any phase launch.
|
|
|
114
114
|
|
|
115
115
|
## Engine Authority by Store
|
|
116
116
|
|
|
117
|
-
- `openspec` and `both` (when `openspec/` directory exists): the
|
|
118
|
-
- `engram`, `none`, and `both` (when `openspec/` directory does NOT exist): the
|
|
117
|
+
- `openspec` and `both` (when `openspec/` directory exists): the local SDD status engine resolves artifact state from disk and is authoritative. Phase executors must obey it.
|
|
118
|
+
- `engram`, `none`, and `both` (when `openspec/` directory does NOT exist): the local engine cannot read Engram artifacts. It returns `nextRecommended: "resolve-via-engram"` and empty `blockedReasons`. This output is **non-authoritative**. The orchestrator must resolve readiness directly from Engram using the Engram memory tools injected by the memory provider on the change topic keys (`sdd/{change-name}/proposal`, `sdd/{change-name}/spec`, etc.) instead of relying on the engine's dependency states. The `artifactStore` field still reflects the real chosen store value (e.g. `"both"`) and must not be rewritten.
|
|
119
119
|
|
|
120
120
|
## Native Runtime Attempt Authority
|
|
121
121
|
|
|
@@ -0,0 +1,42 @@
|
|
|
1
|
+
{
|
|
2
|
+
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
3
|
+
"$id": "https://gentle-ai.dev/contracts/review-integration/v1/schemas/transition-execution.schema.json",
|
|
4
|
+
"title": "Gentle AI Review Transition Execution",
|
|
5
|
+
"type": "object",
|
|
6
|
+
"additionalProperties": false,
|
|
7
|
+
"required": ["operation", "arguments", "preconditions", "binding"],
|
|
8
|
+
"properties": {
|
|
9
|
+
"operation": { "enum": ["review.start", "review.status", "review.recover", "review.repair", "review.validate"] },
|
|
10
|
+
"command": { "$comment": "The complete, literally runnable command line for this transition, e.g. \"gentle-ai review start --contract=... --target=...\". Operation alone is a dotted logical name; command is what a caller can paste. Argument words are the execute arguments' own tokens, in order, POSIX-shell-quoted only when a value would otherwise be word-split.", "type": "string", "minLength": 1, "pattern": "^gentle-ai review [a-z][a-z-]*" },
|
|
11
|
+
"arguments": { "type": "array", "items": { "$ref": "#/$defs/executable_transition_argument" } },
|
|
12
|
+
"selector_arguments": { "type": "array", "items": { "$ref": "#/$defs/transition_argument" } },
|
|
13
|
+
"preconditions": { "type": "array", "minItems": 1, "items": { "$ref": "#/$defs/transition_argument" } },
|
|
14
|
+
"binding": { "$ref": "#/$defs/transition_binding" },
|
|
15
|
+
"artifacts": { "type": "array", "items": { "$ref": "#/$defs/transition_artifact" } }
|
|
16
|
+
},
|
|
17
|
+
"$defs": {
|
|
18
|
+
"sha256": { "type": "string", "pattern": "^sha256:[0-9a-f]{64}$" },
|
|
19
|
+
"transition_argument": {
|
|
20
|
+
"$comment": "One argument of a transition. \"token\", when present, is the exact argv token rendering this argument for a command this product runs, e.g. \"--lineage=review-abc\". It is required on an execute argument (see executable_transition_argument) and present on the arguments of a collect input whose capture_operation names an operation this product performs, because those arguments are literally that command's flags. It is absent on preconditions, on selector_arguments, and on the arguments of an \"external.*\" capture operation, which are assertions, a normalized echo, and values to hand elsewhere rather than argv.",
|
|
21
|
+
"type": "object", "additionalProperties": false, "required": ["name", "value"],
|
|
22
|
+
"properties": { "name": { "type": "string", "pattern": "^[a-z0-9_-]+$" }, "value": { "type": "string", "minLength": 1 }, "token": { "type": "string", "minLength": 1 } }
|
|
23
|
+
},
|
|
24
|
+
"executable_transition_argument": {
|
|
25
|
+
"$comment": "One argv entry of an execute transition. Unlike preconditions and selector_arguments -- which are assertions and a normalized echo the product never tokenizes -- an execute argument is always literally executed, so its exact runnable token is required rather than optional.",
|
|
26
|
+
"allOf": [{ "$ref": "#/$defs/transition_argument" }],
|
|
27
|
+
"type": "object", "required": ["name", "value", "token"]
|
|
28
|
+
},
|
|
29
|
+
"transition_binding": {
|
|
30
|
+
"type": "object", "additionalProperties": false, "required": ["target_identity"],
|
|
31
|
+
"properties": { "lineage_id": { "type": "string", "pattern": "^[a-z0-9]+(?:-[a-z0-9]+)*$" }, "revision": { "$ref": "#/$defs/sha256" }, "target_identity": { "$ref": "#/$defs/sha256" }, "repository_context": { "type": "string", "pattern": "^rctx1_[0-9a-f]{64}$" } }
|
|
32
|
+
},
|
|
33
|
+
"transition_artifact": {
|
|
34
|
+
"type": "object", "additionalProperties": false, "required": ["schema", "capability", "sha256", "lineage_id", "target_identity", "lens", "selected_order", "subject_hash", "admission_decision"],
|
|
35
|
+
"properties": {
|
|
36
|
+
"schema": { "const": "gentle-ai.review-result-artifact/v2" }, "capability": { "const": "review.native_result_artifact" }, "sha256": { "$ref": "#/$defs/sha256" },
|
|
37
|
+
"lineage_id": { "type": "string", "pattern": "^[a-z0-9]+(?:-[a-z0-9]+)*$" }, "target_identity": { "$ref": "#/$defs/sha256" }, "lens": { "type": "string", "minLength": 1 }, "selected_order": { "type": "integer", "minimum": 0 },
|
|
38
|
+
"subject_hash": { "$ref": "#/$defs/sha256" }, "admission_decision": { "const": "completed" }
|
|
39
|
+
}
|
|
40
|
+
}
|
|
41
|
+
}
|
|
42
|
+
}
|
|
@@ -0,0 +1,66 @@
|
|
|
1
|
+
{
|
|
2
|
+
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
3
|
+
"$id": "https://gentle-ai.dev/contracts/review-integration/v2/schemas/last-event-closure.schema.json",
|
|
4
|
+
"title": "Gentle AI review terminal last-event capture response v1",
|
|
5
|
+
"type": "object",
|
|
6
|
+
"additionalProperties": false,
|
|
7
|
+
"required": ["schema", "operation", "lineage_id", "state", "store_revision"],
|
|
8
|
+
"allOf": [
|
|
9
|
+
{
|
|
10
|
+
"if": {"properties": {"operation": {"const": "review.capture-correction-plan"}}, "required": ["operation"]},
|
|
11
|
+
"then": {
|
|
12
|
+
"required": ["target_identity", "request_hash", "correction_lines"],
|
|
13
|
+
"not": {"required": ["action"]}
|
|
14
|
+
},
|
|
15
|
+
"else": {"required": ["action"]}
|
|
16
|
+
},
|
|
17
|
+
{
|
|
18
|
+
"if": {"properties": {"operation": {"enum": ["review/capture-result", "review.capture-refuter"]}, "state": {"const": "correction_required"}}, "required": ["operation", "state"]},
|
|
19
|
+
"then": {
|
|
20
|
+
"required": ["status_continuation"],
|
|
21
|
+
"properties": {
|
|
22
|
+
"status_continuation": {
|
|
23
|
+
"required": ["operation"],
|
|
24
|
+
"properties": {"operation": {"const": "review.status"}}
|
|
25
|
+
}
|
|
26
|
+
}
|
|
27
|
+
},
|
|
28
|
+
"else": {"not": {"required": ["status_continuation"]}}
|
|
29
|
+
}
|
|
30
|
+
],
|
|
31
|
+
"properties": {
|
|
32
|
+
"schema": {"const": "gentle-ai.review-last-event-closure/v1"},
|
|
33
|
+
"operation": {"enum": ["review/capture-result", "review.capture-correction-plan", "review.capture-refuter", "review/capture-validation"]},
|
|
34
|
+
"lineage_id": {"type": "string", "minLength": 1},
|
|
35
|
+
"target_identity": {"type": "string", "pattern": "^sha256:[0-9a-f]{64}$"},
|
|
36
|
+
"request_hash": {"type": "string", "pattern": "^sha256:[0-9a-f]{64}$"},
|
|
37
|
+
"correction_lines": {"type": "integer", "minimum": 1},
|
|
38
|
+
"state": {"enum": ["approved", "correction_required", "escalated"]},
|
|
39
|
+
"action": {"type": "string", "minLength": 1},
|
|
40
|
+
"status_continuation": {"$ref": "../../v1/schemas/transition-execution.schema.json"},
|
|
41
|
+
"store_revision": {"type": "string", "pattern": "^sha256:[0-9a-f]{64}$"},
|
|
42
|
+
"advisory_findings": {
|
|
43
|
+
"type": "object",
|
|
44
|
+
"additionalProperties": false,
|
|
45
|
+
"required": ["statement", "findings"],
|
|
46
|
+
"properties": {
|
|
47
|
+
"statement": {"type": "string", "minLength": 1},
|
|
48
|
+
"findings": {
|
|
49
|
+
"type": "array",
|
|
50
|
+
"items": {
|
|
51
|
+
"type": "object",
|
|
52
|
+
"additionalProperties": false,
|
|
53
|
+
"required": ["id", "severity", "disposition"],
|
|
54
|
+
"properties": {
|
|
55
|
+
"id": {"type": "string", "minLength": 1},
|
|
56
|
+
"lens": {"type": "string", "minLength": 1},
|
|
57
|
+
"location": {"type": "string", "minLength": 1},
|
|
58
|
+
"severity": {"type": "string", "minLength": 1},
|
|
59
|
+
"disposition": {"enum": ["informational", "follow_up", "refuted"]}
|
|
60
|
+
}
|
|
61
|
+
}
|
|
62
|
+
}
|
|
63
|
+
}
|
|
64
|
+
}
|
|
65
|
+
}
|
|
66
|
+
}
|
|
@@ -0,0 +1,14 @@
|
|
|
1
|
+
{
|
|
2
|
+
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
3
|
+
"$id": "https://gentle-ai.dev/contracts/review-integration/v2/schemas/opencode-provider-role.schema.json",
|
|
4
|
+
"title": "Gentle AI OpenCode transport provider-role capture acknowledgement",
|
|
5
|
+
"description": "The gentle-ai.opencode-review-provider-role/v1 envelope the OpenCode review transport returns after natively capturing one provider role result (refuter or targeted-validator). Derived from internal/cli/review_opencode_transport.go's openCodeProviderRoleResultEnvelope.",
|
|
6
|
+
"type": "object",
|
|
7
|
+
"additionalProperties": false,
|
|
8
|
+
"required": ["schema", "role", "captured"],
|
|
9
|
+
"properties": {
|
|
10
|
+
"schema": {"const": "gentle-ai.opencode-review-provider-role/v1"},
|
|
11
|
+
"role": {"enum": ["refuter", "targeted-validator"]},
|
|
12
|
+
"captured": {"const": true}
|
|
13
|
+
}
|
|
14
|
+
}
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
|
|
3
3
|
← [Back to README](../README.md)
|
|
4
4
|
|
|
5
|
-
U8 closed the U1-U7 slimming work.
|
|
5
|
+
U8 closed the U1-U7 slimming work. New ordinary review authority is native; Pi retains permanent consumer infrastructure and explicit graph-v1 Judgment Day. Delivery commands remain ordinary repository-policy operations, not review gates.
|
|
6
6
|
|
|
7
7
|
## Current Ownership
|
|
8
8
|
|
|
@@ -12,8 +12,7 @@ U8 closed the U1-U7 slimming work. Issue [#191](https://github.com/Gentleman-Pro
|
|
|
12
12
|
| Canonical consumer identities | Permanent Pi module `lib/review-canonical.ts` |
|
|
13
13
|
| Git common-directory and repository identity | Permanent Pi module `lib/review-repository.ts` |
|
|
14
14
|
| Immutable reviewer candidate views | Permanent Pi module `lib/review-candidate-view.ts` |
|
|
15
|
-
|
|
|
16
|
-
| Direct commit transaction and dangerous-command safety | Pi; independent of review authority |
|
|
15
|
+
| Dangerous-command safety | Pi; independent of review authority and delivery decisions |
|
|
17
16
|
| Explicit Judgment Day and historical graph semantic replay | Pi graph-v1 until a separately proven replacement exists |
|
|
18
17
|
| Historical graph receipt validation | Pi graph-v1 transaction, reachable only for historical graph authority and explicit Judgment Day |
|
|
19
18
|
|
|
@@ -43,7 +42,6 @@ The permanent modules have direct production consumers after #191:
|
|
|
43
42
|
| `review-canonical.ts` | `extensions/gentle-ai.ts` and eight live review modules |
|
|
44
43
|
| `review-repository.ts` | `extensions/gentle-ai.ts`, graph object store, legacy detector, snapshot, and transaction |
|
|
45
44
|
| `review-candidate-view.ts` | `extensions/gentle-ai.ts` |
|
|
46
|
-
| `review-publication-gate.ts` | `extensions/gentle-ai.ts` and graph-v1 receipt validation in `review-transaction.ts` |
|
|
47
45
|
|
|
48
46
|
The remaining ordinary reducer is not dead authority. Historical graph event replay calls it to validate semantic adjacency. Deleting it would weaken graph integrity even though controller mutation is read-only.
|
|
49
47
|
|
|
@@ -56,7 +54,7 @@ node scripts/measure-native-authority-slimming.mjs origin/main HEAD WORKTREE
|
|
|
56
54
|
git diff --shortstat origin/main..HEAD
|
|
57
55
|
git diff --shortstat HEAD
|
|
58
56
|
git diff --shortstat origin/main
|
|
59
|
-
wc -l docs/native-authority-architecture.md scripts/measure-native-authority-slimming.mjs
|
|
57
|
+
wc -l docs/native-authority-architecture.md scripts/measure-native-authority-slimming.mjs
|
|
60
58
|
```
|
|
61
59
|
|
|
62
60
|
The measurement script defines package footprint as unpacked bytes selected by `package.json#files` plus npm's always-included `package.json`, `README.md`, and `LICENSE`. Source LOC is physical lines in `extensions/**/*.ts`, `lib/**/*.ts`, `runtime/**/*.mjs`, and `scripts/**/*.mjs`. Test LOC is physical lines in `tests/**/*.ts` and `tests/**/*.mjs`.
|
|
@@ -74,10 +72,10 @@ The committed U1-U4 baseline is `origin/main..HEAD`. U5-U8 and #191 are in the u
|
|
|
74
72
|
| Diff boundary | Files | Additions | Deletions |
|
|
75
73
|
| --- | ---: | ---: | ---: |
|
|
76
74
|
| Committed U1-U4: `git diff --shortstat origin/main..HEAD` | 21 | 770 | 2,027 |
|
|
77
|
-
| Unstaged U5-#191, including
|
|
78
|
-
| Accumulated U1-#191, including
|
|
75
|
+
| Unstaged U5-#191, including two untracked delivery artifacts | 33 | 1,591 | 6,940 |
|
|
76
|
+
| Accumulated U1-#191, including two untracked delivery artifacts | 46 | 2,302 | 8,908 |
|
|
79
77
|
|
|
80
|
-
The two unit ranges are intentionally reported separately. `git diff --shortstat` excludes untracked files, so the architecture report
|
|
78
|
+
The two unit ranges are intentionally reported separately. `git diff --shortstat` excludes untracked files, so the architecture report and measurement script are outside the tracked shortstat totals. Unit-range additions and deletions are not arithmetically additive because U5-#191 also edits or removes paths already changed by U1-U4; the accumulated comparison is Git's final origin-to-worktree result.
|
|
81
79
|
|
|
82
80
|
## Retired Modules
|
|
83
81
|
|
|
@@ -114,10 +112,10 @@ The only platform-specific repository test is skipped outside Windows. U8 theref
|
|
|
114
112
|
|
|
115
113
|
## #191 Outcome
|
|
116
114
|
|
|
117
|
-
#191
|
|
115
|
+
Issue #191 removed Pi-owned delivery authorization and publication-target revalidation from ordinary review. The extension does not import a publication-gate module or consult review authority to decide commit, push, pull-request, or release delivery.
|
|
118
116
|
|
|
119
|
-
`review-transaction.ts`
|
|
117
|
+
`review-transaction.ts` retains its reducer, replay, object-store, lock, snapshot, and semantic-replay dependencies for explicit graph-v1 Judgment Day and historical compatibility; no additional module deletion is justified.
|
|
120
118
|
|
|
121
|
-
|
|
119
|
+
Review outcomes are informational: commit, push, PR, and release delivery follow ordinary repository policy. Dangerous-command safety and destructive-review consent remain independent.
|
|
122
120
|
|
|
123
121
|
← [Back to README](../README.md)
|