gentle-pi 2.2.0 → 2.3.0

package/tests/fixtures/devbinary/last-event-capture-correction-plan.captured.json

@@ -0,0 +1,10 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review.capture-correction-plan",
+  "lineage_id": "review-afeed0d5a9aa24a1",
+  "target_identity": "sha256:ccbd92bd891a944ceeb21be0982a5f0dc515ed94a0f15da0a64d21608329aa59",
+  "request_hash": "sha256:0f6dd21a64f76566fdcd8c8f4e87157e1658d207798c2dbd1510d7001af9d243",
+  "correction_lines": 2,
+  "state": "correction_required",
+  "store_revision": "sha256:5a5d22f4f65b0adeca5e2c3a3da0509ced6197a067aa7ffe4b9b040acad4194e"
+}

package/tests/fixtures/devbinary/last-event-capture-refuter-approved.captured.json

@@ -0,0 +1,20 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review.capture-refuter",
+  "lineage_id": "review-61da8af1a89ff96a",
+  "state": "approved",
+  "action": "the approved review completed on the last admitted event and burned; delivery follows ordinary repository policy",
+  "advisory_findings": {
+    "statement": "This review is approved and its receipt stands. Every finding listed here is non-blocking: none opened a correction, none reopens this review, and no correction transition is offered for this candidate. Treat them as separate later work, never as a reason to re-run review on this candidate.",
+    "findings": [
+      {
+        "id": "R3-001",
+        "lens": "reliability",
+        "location": "src/value.js:2",
+        "severity": "BLOCKER",
+        "disposition": "refuted"
+      }
+    ]
+  },
+  "store_revision": "sha256:05588b2784a07c5619af879b97f6e023e35f5112185b42c173ed8f5064cf1b34"
+}

package/tests/fixtures/devbinary/last-event-capture-refuter-correction-required.captured.json

@@ -0,0 +1,26 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review.capture-refuter",
+  "lineage_id": "review-2c1f3ae8139e6fe3",
+  "state": "correction_required",
+  "action": "candidate-caused severe findings require one bounded correction",
+  "status_continuation": {
+    "operation": "review.status",
+    "arguments": [
+      {"name": "cwd", "value": "/tmp/repository", "token": "--cwd=/tmp/repository"},
+      {"name": "contract", "value": "gentle-ai.review-integration/v2", "token": "--contract=gentle-ai.review-integration/v2"},
+      {"name": "next-transition", "value": "true", "token": "--next-transition=true"},
+      {"name": "lineage", "value": "review-2c1f3ae8139e6fe3", "token": "--lineage=review-2c1f3ae8139e6fe3"},
+      {"name": "agent", "value": "pi", "token": "--agent=pi"}
+    ],
+    "preconditions": [
+      {"name": "state", "value": "correction_required"}
+    ],
+    "binding": {
+      "lineage_id": "review-2c1f3ae8139e6fe3",
+      "revision": "sha256:de7f54f5c7eca7c1095ab6d8fcd8a3eb05f4a01733129d3e2fa0f32db30b5457",
+      "target_identity": "sha256:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
+    }
+  },
+  "store_revision": "sha256:de7f54f5c7eca7c1095ab6d8fcd8a3eb05f4a01733129d3e2fa0f32db30b5457"
+}

package/tests/fixtures/devbinary/last-event-capture-result-approved.captured.json

@@ -0,0 +1,8 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review/capture-result",
+  "lineage_id": "review-c7c923a031112dd7",
+  "state": "approved",
+  "action": "the approved review completed on the last admitted event and burned; delivery follows ordinary repository policy",
+  "store_revision": "sha256:108e0ba4f5af3f69b44d2fb1057a5054e968cc38f050d2e9a30f58c00bbf7e88"
+}

package/tests/fixtures/devbinary/last-event-capture-result-correction-required.captured.json

@@ -0,0 +1,26 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review/capture-result",
+  "lineage_id": "review-afeed0d5a9aa24a1",
+  "state": "correction_required",
+  "action": "candidate-caused severe findings require one bounded correction",
+  "status_continuation": {
+    "operation": "review.status",
+    "arguments": [
+      {"name": "cwd", "value": "/tmp/repository", "token": "--cwd=/tmp/repository"},
+      {"name": "contract", "value": "gentle-ai.review-integration/v2", "token": "--contract=gentle-ai.review-integration/v2"},
+      {"name": "next-transition", "value": "true", "token": "--next-transition=true"},
+      {"name": "lineage", "value": "review-afeed0d5a9aa24a1", "token": "--lineage=review-afeed0d5a9aa24a1"},
+      {"name": "agent", "value": "pi", "token": "--agent=pi"}
+    ],
+    "preconditions": [
+      {"name": "state", "value": "correction_required"}
+    ],
+    "binding": {
+      "lineage_id": "review-afeed0d5a9aa24a1",
+      "revision": "sha256:3c274f44e4d05c748bae28978396f28a4d833500b41f00942f315261e8bc9749",
+      "target_identity": "sha256:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+    }
+  },
+  "store_revision": "sha256:3c274f44e4d05c748bae28978396f28a4d833500b41f00942f315261e8bc9749"
+}

package/tests/fixtures/devbinary/last-event-capture-validation-approved.captured.json

@@ -0,0 +1,8 @@
+{
+  "schema": "gentle-ai.review-last-event-closure/v1",
+  "operation": "review/capture-validation",
+  "lineage_id": "review-afeed0d5a9aa24a1",
+  "state": "approved",
+  "action": "the approved review completed on the last admitted event and burned; delivery follows ordinary repository policy",
+  "store_revision": "sha256:dddb4347e0a391d434a95a2612f22a16a8d9cc5af03a8a7b8546c3936cf88043"
+}

package/tests/fixtures/devbinary/last-event-closure.provenance.md

@@ -0,0 +1,13 @@
+# Last-event closure fixture provenance
+
+Captured 2026-08-23 from `gentle-ai dev` at the maintainer-provided disposable sandbox candidate `gentle-ai-dev`.
+
+Commands were run against disposable Git repositories with isolated `HOME` and `TMPDIR` beneath `.scratch/issue-404-fixtures`:
+
+- `gentle-ai review start ... --contract=gentle-ai.review-integration/v2 --agent=pi --consent=relay`
+- `gentle-ai review capture-result ... --input=<reviewer-result>`
+- `gentle-ai review capture-correction-plan ... --correction-lines=2`
+- `gentle-ai review capture-refuter ... --agent=pi --execute=true`
+- `gentle-ai review capture-validation ... --agent=pi --execute=true`
+
+The sandbox was removed after the captures. The JSON fixtures are byte copies of the native stdout responses.

package/tests/fixtures/devbinary/review-acknowledged-v1.captured.json

@@ -0,0 +1,9 @@
+{
+  "schema": "gentle-ai.review-acknowledged/v1",
+  "operation": "review/acknowledge-approved",
+  "action": "acknowledged",
+  "lineage_id": "review-3ec95251db75f626",
+  "target_identity": "sha256:b505dcd8d82395c053c9786935e11e0e235cbdecca4f1f46f98c768ea6248d3d",
+  "consumed_revision": "sha256:9732b1c3526bfecd3851093239241145c970cc126acea59bfaf14133214b60ee",
+  "authority": "burned"
+}

package/tests/fixtures/devbinary/review-acknowledged.provenance.md

@@ -0,0 +1,31 @@
+# review-acknowledged/v1 fixture provenance
+
+`review-acknowledged-v1.captured.json` is a byte copy of the stdout that
+`gentle-ai review acknowledge-approved` printed when it burned one approved
+compact authority. gentle-ai #3947 (main commit bc9f74d2) made that command
+print this `gentle-ai.review-acknowledged/v1` envelope; every published
+release up to and including v2.5.0-rc.3 burns the same authority with EMPTY
+stdout (verified below).
+
+- Captured 2026-08-31T08:51:50Z with the installed `gentle-ai 2.5.0-main.bc9f74d2`
+  (`gentle-ai --version` banner) in a disposable Git repository under an isolated
+  `HOME`; RDD was enabled only in that isolated HOME
+  (`gentle-ai review mode enable --scope global`).
+- Candidate: one uncommitted line appended to a committed `README.md`
+  (`non_executable_only`, zero-lens, START closed `approved`).
+- Commands, each the exact vector the previous envelope returned
+  (`GENTLE_PI_REVIEW_RELAY_CONTRACT=gentle-pi.review-relay/v1` set for the Pi
+  transport handshake):
+  1. `gentle-ai review status --cwd <repo> --contract gentle-ai.review-integration/v2 --agent pi --next-transition`
+  2. `gentle-ai review start --cwd=<repo> --contract=gentle-ai.review-integration/v2 --target=sha256:b505dcd8… --projection=workspace --lineage=review-3ec95251db75f626 --agent=pi --consent=relay`
+  3. `gentle-ai review status … --lineage review-3ec95251db75f626 --next-transition` (offered `review.acknowledge-approved`)
+  4. `gentle-ai review acknowledge-approved --cwd=<repo> --lineage=review-3ec95251db75f626 --target=sha256:b505dcd8… --expected-revision=sha256:9732b1c3… --token=<provider-issued>` (exit 0, empty stderr; stdout is the fixture)
+- Replaying step 4 refused with exit 1, empty stdout, and the stderr line
+  `approved acknowledgement names no live compact authority; it was already acknowledged and burned, …` (unchanged refusal shape).
+- Pinned control: the same four steps against the pinned published
+  `gentle-ai 2.5.0-rc.3` binary (sha256 b69da0a51b03f326147498ae465fc1ec52eff8427d579964eefad714c3f9bd87,
+  the recorded asset digest) burned the authority with exit 0 and ZERO bytes on
+  stdout and stderr, which is the silent path `acknowledgeApproved` keeps
+  accepting byte-for-byte.
+
+The disposable repositories and HOME were removed after the captures.

package/tests/fixtures/devbinary/start-v3-zero-lens-closed.captured.json

@@ -0,0 +1,21 @@
+{
+  "schema": "gentle-ai.review-integration.start/v3",
+  "contract": "gentle-ai.review-integration/v2",
+  "operation": "review.start",
+  "action": "closed",
+  "lenses_required": false,
+  "lineage_id": "review-95b756a05f2e82b1",
+  "state": "approved",
+  "risk_level": "low",
+  "selected_lenses": [],
+  "projection": "workspace",
+  "changed_files": 1,
+  "changed_lines": 2,
+  "correction_budget": 1,
+  "risk_reasons": [
+    {
+      "code": "non_executable_only"
+    }
+  ],
+  "artifact_subjects": []
+}

package/tests/fixtures/native-review-cli/v2.5.0-rc.1/PROVENANCE.txt

@@ -0,0 +1,15 @@
+Captured from a real gentle-ai binary, not hand-authored.
+
+binary:  gentle-ai 2.5.0-rc.1.0.20260827194839-f654764e231f (published prerelease channel)
+date:    2026-08-28
+command: gentle-ai sdd-status agent-builder --cwd <repo> --json --instructions
+repo:    a gentle-ai checkout with an OpenSpec-backed change present
+
+Why this fixture exists: gentle-ai commit 3c4c7fb6 (2026-08-24, "refactor(sdd)!:
+replace status v1 with clean v2") moved SchemaVersion from 1 to 2. gentle-pi had
+no v2 decoder, so lib/native-review-cli.ts rejected every current status with
+IDENTITY_MISMATCH on `body.schemaVersion !== 1`.
+
+The v2 object shape is key-compatible with the v1 decoder's exactObject list:
+17 required keys plus the optional phaseInstructions. Only the version value and
+the widened artifactStore domain (which gains "hybrid") differ.

package/tests/gentle-ai-binary.test.ts

@@ -1,17 +1,23 @@
 import assert from "node:assert/strict";
 import { createHash } from "node:crypto";
-import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { chmod, mkdir, mkdtemp, rm, symlink, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
-import { basename, isAbsolute, join } from "node:path";
+import { basename, dirname, isAbsolute, join } from "node:path";
 import test from "node:test";
 import {
 	GENTLE_AI_BINARY_MISSING_CODE,
+	GENTLE_AI_DEV_BINARY_ENV,
 	GENTLE_AI_VERSION,
+	gentleAiDevBinaryRegistrationPath,
 	PackageLocalGentleAiBinaryMissingError,
+	registerGentleAiDevBinary,
 	resolveGentleAiBinary,
+	setGentleAiDevBinaryEnvironmentForTesting,
+	unregisterGentleAiDevBinary,
+	type GentleAiDevBinaryEnvironment,
 } from "../lib/gentle-ai-binary.ts";
-import { NativeReviewCliV213, createNativeReviewCli, type ExecFileAdapter } from "../lib/native-review-cli.ts";
+import { NativeReviewCliV216, createNativeReviewCli, type ExecFileAdapter } from "../lib/native-review-cli.ts";
 import { GENTLE_AI_WINDOWS_SOURCE_MODULE_CHECKSUM, resolveGentleAiReleaseAsset } from "../scripts/gentle-ai-installer.mjs";
 import { requireNativeBinary } from "./support/native-binary-gate.ts";
 
@@ -29,6 +35,47 @@ const nativeBinaryGate = requireNativeBinary({
 if (!nativeBinaryGate.run) console.log(`gentle-ai-binary: ${nativeBinaryGate.reason}`);
 const verifiedBinaryTest = nativeBinaryGate.run && process.platform !== "win32" ? test : test.skip;
 
+interface PinnedBinaryIsolation {
+	environment: GentleAiDevBinaryEnvironment;
+	savedEnvironmentValue: string | undefined;
+	savedRegistration: string | undefined;
+}
+
+let pinnedBinaryIsolation: PinnedBinaryIsolation | undefined;
+
+test.beforeEach((t) => {
+	const home = mkdtempSync(join(tmpdir(), "gentle-pi-pinned-binary-home-"));
+	const environment: GentleAiDevBinaryEnvironment = { env: { ...process.env }, home };
+	delete environment.env.GENTLE_PI_CONFIG_HOME;
+	const savedEnvironmentValue = environment.env[GENTLE_AI_DEV_BINARY_ENV];
+	const registrationPath = gentleAiDevBinaryRegistrationPath(environment);
+	const savedRegistration = existsSync(registrationPath)
+		? readFileSync(registrationPath, "utf8")
+		: undefined;
+
+	delete environment.env[GENTLE_AI_DEV_BINARY_ENV];
+	unregisterGentleAiDevBinary(environment);
+	setGentleAiDevBinaryEnvironmentForTesting(environment);
+	pinnedBinaryIsolation = { environment, savedEnvironmentValue, savedRegistration };
+
+	t.after(() => {
+		if (savedEnvironmentValue === undefined) {
+			delete environment.env[GENTLE_AI_DEV_BINARY_ENV];
+		} else {
+			environment.env[GENTLE_AI_DEV_BINARY_ENV] = savedEnvironmentValue;
+		}
+		if (savedRegistration === undefined) {
+			unregisterGentleAiDevBinary(environment);
+		} else {
+			mkdirSync(dirname(registrationPath), { recursive: true });
+			writeFileSync(registrationPath, savedRegistration);
+		}
+		setGentleAiDevBinaryEnvironmentForTesting(undefined);
+		pinnedBinaryIsolation = undefined;
+		rmSync(home, { recursive: true, force: true });
+	});
+});
+
 async function writeVerifiedBinary(packageRoot: string, platform = process.platform): Promise<string> {
 	const asset = resolveGentleAiReleaseAsset(platform, process.arch);
 	const binaryPath = join(packageRoot, ".gentle-ai", RUNTIME_DIRECTORY, asset.executable);
@@ -50,7 +97,7 @@ async function writeWindowsSourceBinary(packageRoot: string): Promise<{ binaryPa
 		method: "go-sumdb-source-build",
 		package: "github.com/gentleman-programming/gentle-ai/v2/cmd/gentle-ai",
 		module: "github.com/gentleman-programming/gentle-ai/v2",
-		tag: "v2.4.0",
+		tag: "v2.5.0",
 		architecture: process.arch === "x64" ? "x64" : "arm64",
 		binarySha256: createHash("sha256").update(binary).digest("hex"),
 		moduleChecksum: GENTLE_AI_WINDOWS_SOURCE_MODULE_CHECKSUM,
@@ -64,13 +111,34 @@ async function writeWindowsSourceBinary(packageRoot: string): Promise<{ binaryPa
 	return { binaryPath, manifestPath };
 }
 
-verifiedBinaryTest("runtime resolves an absolute package-local binary path without PATH fallback", async () => {
+verifiedBinaryTest("runtime resolves an absolute package-local binary path without PATH fallback or ambient dev contamination", async () => {
 	const packageRoot = await mkdtemp(join(tmpdir(), "gentle-pi-binary-"));
 	const executable = process.platform === "win32" ? "gentle-ai.exe" : "gentle-ai";
 	const binaryPath = await writeVerifiedBinary(packageRoot);
+	const devBinary = join(packageRoot, "maintainer-dev-binary");
+	await writeFile(devBinary, "maintainer dev binary");
+	if (process.platform !== "win32") await chmod(devBinary, 0o700);
+	const isolation = pinnedBinaryIsolation;
+	assert.ok(isolation, "the pinned-binary fixture must install its isolated environment");
+
+	const ambientValue = process.env[GENTLE_AI_DEV_BINARY_ENV];
+	process.env[GENTLE_AI_DEV_BINARY_ENV] = devBinary;
+	try {
+		assert.equal(resolveGentleAiBinary(packageRoot, process.platform), binaryPath, "a maintainer's ambient override must not contaminate a pinned-package case");
+	} finally {
+		if (ambientValue === undefined) delete process.env[GENTLE_AI_DEV_BINARY_ENV];
+		else process.env[GENTLE_AI_DEV_BINARY_ENV] = ambientValue;
+	}
+
+	isolation.environment.env[GENTLE_AI_DEV_BINARY_ENV] = devBinary;
+	assert.equal(resolveGentleAiBinary(packageRoot, process.platform), devBinary, "an explicit dev-binary test may opt in through the isolated environment seam");
+	delete isolation.environment.env[GENTLE_AI_DEV_BINARY_ENV];
+	registerGentleAiDevBinary(devBinary, isolation.environment);
+	assert.equal(resolveGentleAiBinary(packageRoot, process.platform), devBinary, "an explicit persistent dev registration may opt in through the isolated environment seam");
+	assert.equal(unregisterGentleAiDevBinary(isolation.environment), true);
 
 	const resolved = resolveGentleAiBinary(packageRoot, process.platform);
-	assert.equal(resolved, binaryPath);
+	assert.equal(resolved, binaryPath, "clearing the explicit registration restores the pinned resolver");
 	assert.equal(isAbsolute(resolved), true);
 	assert.equal(basename(resolved), executable);
 	assert.doesNotMatch(resolved, /(^|[/\\])PATH($|[/\\])/i);
@@ -124,7 +192,7 @@ test("runtime rejects an unverified binary, a symlinked manifest, and ambient ex
 	await writeFile(manifestTarget, `${JSON.stringify({ version: GENTLE_AI_VERSION, asset: `gentle-ai_${GENTLE_AI_VERSION}_${process.platform}_${process.arch === "x64" ? "amd64" : process.arch}.tar.gz`, assetSha256: "a".repeat(64), binarySha256 })}\n`);
 	await symlink(manifestTarget, manifestPath);
 	assert.throws(() => resolveGentleAiBinary(packageRoot, process.platform), /package-local-binary-missing/);
-	assert.throws(() => new NativeReviewCliV213(async () => VERSION, "gentle-ai"), /absolute package-local executable/);
+	assert.throws(() => new NativeReviewCliV216(async () => VERSION, "gentle-ai"), /absolute package-local executable/);
 });
 
 verifiedBinaryTest("runtime rejects malformed, unknown, wrong, and symlinked integrity paths", async () => {
@@ -224,16 +292,18 @@ verifiedBinaryTest("production native client never invokes a global gentle-ai ex
 	const calls: string[] = [];
 	const adapter: ExecFileAdapter = async (request) => {
 		calls.push(request.file);
-		if (request.arguments[0] === "version") return VERSION;
 		return {
 			...VERSION,
-			stdout: JSON.stringify({ operation: "review/start", lineage_id: "lineage", state: "reviewing", risk_level: "low", selected_lenses: [], changed_files: 0, changed_lines: 0, correction_budget: 0, action: "created", lenses_required: false, projection: "workspace" }),
+			stdout: readFileSync(join(import.meta.dirname, "..", "contracts", "review-integration", "v2", "fixtures", "status.fixture.json"), "utf8"),
 		};
 	};
 
-	await createNativeReviewCli(adapter, () => resolveGentleAiBinary(packageRoot, process.platform)).start({ cwd: packageRoot });
-	assert.deepEqual(calls, [binaryPath, binaryPath]);
+	await assert.rejects(
+		() => createNativeReviewCli(adapter, () => resolveGentleAiBinary(packageRoot, process.platform)).targetStatus!({ cwd: packageRoot, lineageId: "review-status-fixture" }),
+		/schema incompatible/,
+	);
+	assert.deepEqual(calls, [binaryPath]);
 	assert.ok(calls.every((file) => file !== "gentle-ai"));
-	assert.throws(() => new NativeReviewCliV213(adapter, "gentle-ai"), /absolute package-local executable/);
-	assert.throws(() => new NativeReviewCliV213(adapter, "./gentle-ai"), /absolute package-local executable/);
+	assert.throws(() => new NativeReviewCliV216(adapter, "gentle-ai"), /absolute package-local executable/);
+	assert.throws(() => new NativeReviewCliV216(adapter, "./gentle-ai"), /absolute package-local executable/);
 });