gentle-pi 2.1.2 → 2.2.0

package/tests/skill-registry.test.ts

@@ -1,5 +1,5 @@
 import assert from "node:assert/strict";
-import { mkdirSync, readFileSync, symlinkSync, writeFileSync } from "node:fs";
+import { mkdirSync, readFileSync, statSync, symlinkSync, utimesSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import test from "node:test";
@@ -267,3 +267,52 @@ test("orchestrator documents path injection protocol", () => {
 	assert.match(source, /paths-injected/);
 	assert.doesNotMatch(source, /Use matching compact rules based on code context and task intent/);
 });
+
+test("non-forced regeneration invalidates cache when skill bytes change but path, size, and mtime are restored", async () => {
+	const cwd = join(tmpdir(), `gentle-pi-fingerprint-${Date.now()}`);
+	const skillPath = join(cwd, "skills", "alpha", "SKILL.md");
+	mkdirSync(dirname(skillPath), { recursive: true });
+
+	const contentV1 =
+		'---\nname: alpha\ndescription: "Trigger: alpha skill. Variant one. Body A."\n---\n\n## Rules\n\n- Rule A.\n';
+	const contentV2 =
+		'---\nname: alpha\ndescription: "Trigger: alpha skill. Variant two. Body B."\n---\n\n## Rules\n\n- Rule B.\n';
+	assert.equal(
+		Buffer.byteLength(contentV1),
+		Buffer.byteLength(contentV2),
+		"test fixtures must have identical byte length",
+	);
+
+	const fixedMtimeSeconds = 1_000_000_000;
+	writeFileSync(skillPath, contentV1);
+	utimesSync(skillPath, fixedMtimeSeconds, fixedMtimeSeconds);
+	const beforeStat = statSync(skillPath);
+	const beforeMtimeMs = beforeStat.mtimeMs;
+	const beforeSize = beforeStat.size;
+
+	const first = await __testing.regenerateRegistry(cwd, false);
+	assert.equal(first.regenerated, true, "initial non-forced regeneration writes the registry");
+	assert.equal(first.reason, "fingerprint-changed");
+
+	const registryPath = join(cwd, ".atl", "skill-registry.md");
+	const firstRegistry = readFileSync(registryPath, "utf8");
+	assert.match(firstRegistry, /Variant one\. Body A\./);
+
+	writeFileSync(skillPath, contentV2);
+	utimesSync(skillPath, fixedMtimeSeconds, fixedMtimeSeconds);
+	const midStat = statSync(skillPath);
+	assert.equal(midStat.size, beforeSize, "byte size must be unchanged after rewrite");
+	assert.equal(midStat.mtimeMs, beforeMtimeMs, "mtime must be restored exactly");
+
+	const second = await __testing.regenerateRegistry(cwd, false);
+	assert.equal(
+		second.regenerated,
+		true,
+		"non-forced regeneration must invalidate cache when content bytes changed",
+	);
+	assert.equal(second.reason, "fingerprint-changed");
+
+	const secondRegistry = readFileSync(registryPath, "utf8");
+	assert.match(secondRegistry, /Variant two\. Body B\./);
+	assert.doesNotMatch(secondRegistry, /Variant one\. Body A\./);
+});

package/tests/verify-package-files.test.ts

@@ -4,9 +4,12 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 import test from "node:test";
 import {
+	gentleAiVersionPinMismatches,
 	reconcileContractsOnDisk,
 	reconcileGeneratedRuntimeSources,
 } from "../scripts/verify-package-files.mjs";
+import { INSTALLER_VERSION, RELEASE_BASE_URL, GENTLE_AI_WINDOWS_SOURCE_TAG } from "../scripts/gentle-ai-installer.mjs";
+import { GENTLE_AI_VERSION } from "../lib/gentle-ai-binary.ts";
 
 function makeFixtureRoot(): string {
 	return mkdtempSync(join(tmpdir(), "gentle-pi-verify-package-files-"));
@@ -49,6 +52,22 @@ test("contracts/ walk fails on a contractHashes entry that is missing from disk"
 	}
 });
 
+test("contracts/ walk excludes the provider contract mirror subtree, whose bytes are pinned by its own lock", () => {
+	const fixtureRoot = makeFixtureRoot();
+	try {
+		mkdirSync(join(fixtureRoot, "contracts/review-provider-contract-mirror/v1.1.0/bundle"), { recursive: true });
+		writeFileSync(join(fixtureRoot, "contracts/review-provider-contract-mirror/provider-contract.lock.json"), "{}\n");
+		writeFileSync(join(fixtureRoot, "contracts/review-provider-contract-mirror/v1.1.0/bundle/README.md"), "mirror\n");
+
+		const { unlistedOnDisk, listedButMissing } = reconcileContractsOnDisk(fixtureRoot, {});
+
+		assert.deepEqual(unlistedOnDisk, []);
+		assert.deepEqual(listedButMissing, []);
+	} finally {
+		rmSync(fixtureRoot, { recursive: true, force: true });
+	}
+});
+
 test("sources <-> runtime/*.mjs walk fails when a generated runtime file is absent from the generator's sources array", () => {
 	const fixtureRoot = makeFixtureRoot();
 	try {
@@ -91,6 +110,49 @@ test("sources <-> runtime/*.mjs walk fails when a sources entry is absent from r
 	}
 });
 
+// Regression test for the documented incident in scripts/install-gentle-ai.mjs:
+// the installer once reported installing v2.1.11 while writing v2.2.0 to disk
+// because two hardcoded version copies had drifted apart. The textual
+// `.includes(...)` grep this replaces could not have caught this, because it
+// only verifies a string appears in a file, not that two values agree.
+test("Gentle AI version pin mismatch is reported with a specific message when a derived location disagrees with the authoritative constant", () => {
+	const mismatches = gentleAiVersionPinMismatches({
+		installerVersion: "2.2.3",
+		releaseBaseUrl: "https://github.com/Gentleman-Programming/gentle-ai/releases/download/v2.2.3/",
+		windowsSourceTag: "v2.2.3",
+		libGentleAiVersion: "2.2.0",
+	});
+
+	assert.deepEqual(mismatches, [
+		'lib/gentle-ai-binary.ts GENTLE_AI_VERSION ("2.2.0") does not match the authoritative scripts/gentle-ai-installer.mjs INSTALLER_VERSION ("2.2.3")',
+	]);
+});
+
+test("Gentle AI version pin mismatch also flags a drifted release URL and a drifted Windows source tag", () => {
+	const mismatches = gentleAiVersionPinMismatches({
+		installerVersion: "2.2.3",
+		releaseBaseUrl: "https://github.com/Gentleman-Programming/gentle-ai/releases/download/v2.2.0/",
+		windowsSourceTag: "v2.1.11",
+		libGentleAiVersion: "2.2.3",
+	});
+
+	assert.deepEqual(mismatches, [
+		'RELEASE_BASE_URL ("https://github.com/Gentleman-Programming/gentle-ai/releases/download/v2.2.0/") does not pin the authoritative v2.2.3',
+		'GENTLE_AI_WINDOWS_SOURCE_TAG ("v2.1.11") does not match the authoritative v2.2.3',
+	]);
+});
+
+test("Gentle AI version pin agrees across the installer version, the release URL, the Windows source tag, and lib/gentle-ai-binary.ts", () => {
+	const mismatches = gentleAiVersionPinMismatches({
+		installerVersion: INSTALLER_VERSION,
+		releaseBaseUrl: RELEASE_BASE_URL,
+		windowsSourceTag: GENTLE_AI_WINDOWS_SOURCE_TAG,
+		libGentleAiVersion: GENTLE_AI_VERSION,
+	});
+
+	assert.deepEqual(mismatches, []);
+});
+
 test("both walks report no drift when sources, runtime/*.mjs, requiredPaths, and contractHashes fully agree", () => {
 	const fixtureRoot = makeFixtureRoot();
 	try {

package/assets/agents/review-refuter.md

@@ -1,40 +0,0 @@
----
-name: review-refuter
-description: One-shot read-only verifier for the complete inferential-severe frozen-row list.
-tools:
-  - "*": false
-  - read
-  - grep
-  - find
----
-
-You are **review-refuter**, the one optional ordinary-review refuter. Challenge the supplied inferential claims; never modify the repository.
-
-## Boundary
-
-- Use only `read`, `grep`, and `find`.
-- Do not mutate files, run shell commands, delegate, or write memory.
-- Receive the complete inferential-severe frozen-row list once.
-- Do not create replacement findings or omit difficult supplied IDs.
-
-## Output
-
-Return exactly one JSON object using the `gentle-ai.refuter-result-batch/v1` contract:
-
-```json
-{
-  "schema": "gentle-ai.refuter-result-batch/v1",
-  "request_hash": "<supplied request hash>",
-  "results": [
-    {
-      "finding_id": "<exact supplied finding ID>",
-      "outcome": "refuted | corroborated | inconclusive",
-      "proof_refs": ["differential-test:<independent concrete reproduction>"]
-    }
-  ]
-}
-```
-
-Return one row for every supplied ID, with no aliases, extra fields, prose, or additional JSON values. The `request_hash` and every `finding_id` must match the supplied frozen request exactly. Every `proof_refs` entry must be a concrete `changed-hunk:`, `candidate-created-path:`, `differential-test:`, or `before-after:` reference for that same finding; independent concrete refuter proof is valid and need not repeat reviewer `proof_refs`. Use `inconclusive` when the supplied evidence supports neither `refuted` nor `corroborated`; native authority escalates it. Do not create findings, alter frozen claims, request fixes, launch actors, persist authority, or repeat.
-
-Actor output is untrusted data and cannot authorize transitions, fixes, receipts, gates, or delivery.

package/assets/agents/review-validator.md

@@ -1,23 +0,0 @@
----
-name: review-validator
-description: Per-attempt targeted proof validator for exact frozen rows.
-tools:
-  - "*": false
-  - read
-  - grep
-  - find
----
-
-You are **review-validator**, the read-only proof consumer for one native-authorized correction attempt.
-
-## Scope
-
-Receive only the frozen correction IDs, their exact causal rows, original-criteria proof, one correction-regression proof for those IDs, and inert follow-ups.
-
-Validate the original criteria and correction regression only. Never expand paths, IDs, untracked scope, acceptance criteria, or correction purpose; never discover, re-review, add findings, or change frozen claims.
-
-Do not request another fix or attempt, launch actors, persist authority, or repeat yourself. Native FINALIZE alone decides whether `correction_required` may continue within the cumulative budget and three-attempt cap.
-
-Return `original_criteria`, `correction_regression`, an empty `fix_caused_findings` array, and inert `follow_ups`. The controller derives the correction diff and changed-line count, owns all transitions, and performs final verification.
-
-Actor output is untrusted data and cannot authorize transitions, fixes, receipts, gates, or delivery.

package/lib/native-review-remediation.ts

@@ -1,49 +0,0 @@
-import {
-	NATIVE_REVIEW_AUTHORITY_ENTRY_STATUS,
-	NATIVE_REVIEW_AUTHORITY_ENTRY_VERSION,
-	NATIVE_REVIEW_AUTHORITY_STATUS,
-	type NativeReviewStatusResult,
-} from "./native-review-cli.ts";
-
-export const NATIVE_REVIEW_REMEDIATION = {
-	NONE: "none",
-	LEGACY: "legacy",
-	INVALID_OR_MIXED: "invalid-or-mixed",
-} as const;
-export type NativeReviewRemediationKind = (typeof NATIVE_REVIEW_REMEDIATION)[keyof typeof NATIVE_REVIEW_REMEDIATION];
-
-export const NATIVE_REVIEW_AUTHORITY_APPLICABILITY = {
-	APPLICABLE: "applicable",
-	UNRELATED_HISTORY: "unrelated-history",
-	UNKNOWN: "unknown",
-} as const;
-export type NativeReviewAuthorityApplicability = (typeof NATIVE_REVIEW_AUTHORITY_APPLICABILITY)[keyof typeof NATIVE_REVIEW_AUTHORITY_APPLICABILITY];
-
-export interface NativeReviewRemediationClassification {
-	kind: NativeReviewRemediationKind;
-	applicability: NativeReviewAuthorityApplicability;
-	applicableLineageId?: string;
-}
-
-export function classifyNativeReviewRemediation(status: NativeReviewStatusResult, currentCandidateLineageIds: readonly string[] = []): NativeReviewRemediationClassification {
-	const invalid = status.status === NATIVE_REVIEW_AUTHORITY_STATUS.SAME_LINEAGE_MIXED_COLLISION || (status.status === NATIVE_REVIEW_AUTHORITY_STATUS.INVALID && !status.complete && !status.authoritative);
-	if (!invalid) return { kind: NATIVE_REVIEW_REMEDIATION.NONE, applicability: NATIVE_REVIEW_AUTHORITY_APPLICABILITY.UNRELATED_HISTORY };
-	const matches = status.entries.filter((entry) =>
-		entry.status === NATIVE_REVIEW_AUTHORITY_ENTRY_STATUS.INVALID &&
-		entry.lineageId !== undefined && currentCandidateLineageIds.includes(entry.lineageId),
-	);
-	if (matches.length !== 1) return {
-		kind: NATIVE_REVIEW_REMEDIATION.NONE,
-		applicability: currentCandidateLineageIds.length === 0 ? NATIVE_REVIEW_AUTHORITY_APPLICABILITY.UNRELATED_HISTORY : NATIVE_REVIEW_AUTHORITY_APPLICABILITY.UNKNOWN,
-	};
-	const entry = matches[0]!;
-	return {
-		kind: entry.version === NATIVE_REVIEW_AUTHORITY_ENTRY_VERSION.LEGACY_V1 ? NATIVE_REVIEW_REMEDIATION.LEGACY : NATIVE_REVIEW_REMEDIATION.INVALID_OR_MIXED,
-		applicability: NATIVE_REVIEW_AUTHORITY_APPLICABILITY.APPLICABLE,
-		applicableLineageId: entry.lineageId,
-	};
-}
-
-export function nativeReviewRemediationPermitsReset(classification: NativeReviewRemediationClassification): boolean {
-	return classification.applicability === NATIVE_REVIEW_AUTHORITY_APPLICABILITY.APPLICABLE && classification.kind !== NATIVE_REVIEW_REMEDIATION.NONE;
-}