gdharness 1.3.41 → 1.3.43

package/build/godot/operations/project_validation.gd

@@ -1,5 +1,4 @@
 extends RefCounted
-
 ## Whether a project is ready to run and export: its settings, main scene, imports, presets,
 ## scripts, references and signal connections, each named under checks_performed.
 
@@ -13,7 +12,8 @@ const GdhRead = preload("reading.gd")
 const GdhSceneConnections = preload("scene_connections.gd")
 const GdhScriptCheck = preload("script_check.gd")
 const CONNECTION_FIX: String = (
-	"Write the method or signal, or point the connection at the one that replaced it with" + " scene_signal"
+	"Write the method or signal, or point the connection at the one that replaced it with"
+	+ " scene_signal"
 )
 
 var _log: GdhLog
@@ -28,7 +28,9 @@ func validate_project(params: Dictionary) -> Dictionary:
 	var preset_name: String = str(params.get("preset", ""))
 	var include_suggestions: bool = GdhRead.as_bool(params.get("include_suggestions", true), true)
 
-	_log.info("Validating project" + (" for preset: " + preset_name if not preset_name.is_empty() else ""))
+	_log.info(
+		"Validating project" + (" for preset: " + preset_name if not preset_name.is_empty() else "")
+	)
 
 	var issues: Array[Dictionary] = []
 	var warnings: Array[Dictionary] = []
@@ -73,18 +75,24 @@ func validate_project(params: Dictionary) -> Dictionary:
 	# a scene using one fails to load in a run or an export.
 	checks_performed.append("imports")
 	var never: Array[String] = []
-	for path: String in _files.find_files_with_extensions("res://", GdhImportPipeline.IMPORTABLE_EXTENSIONS):
+	for path: String in _files.find_files_with_extensions(
+		"res://", GdhImportPipeline.IMPORTABLE_EXTENSIONS
+	):
 		if not FileAccess.file_exists(path + ".import"):
 			never.append(path)
 	if not never.is_empty():
 		never.sort()
-		warnings.append(
-			_finding(
-				"warning",
-				"imports",
-				GdhImportPipeline.never_imported_line(never),
-				"Run project_import reimport, or open the project in the editor, whose scan imports them",
-				include_suggestions
+		(
+			warnings
+			. append(
+				_finding(
+					"warning",
+					"imports",
+					GdhImportPipeline.never_imported_line(never),
+					"Run project_import reimport, or open the project in the editor, whose scan "
+					+ "imports them",
+					include_suggestions
+				)
 			)
 		)
 
@@ -106,33 +114,44 @@ func validate_project(params: Dictionary) -> Dictionary:
 		checks_performed.append("export_preset")
 		var named: Array[String] = GdhExportPresets.names()
 		if preset_name not in named:
-			issues.append(
-				_finding(
-					"error",
-					"export_preset",
-					(
-						"No export preset is named "
-						+ preset_name
-						+ (
-							": the project has none"
-							if named.is_empty()
-							else ": the presets are " + ", ".join(named)
-						)
-					),
-					"Pass one of the preset names, or add the preset with project_export add_preset",
-					include_suggestions
+			(
+				issues
+				. append(
+					_finding(
+						"error",
+						"export_preset",
+						(
+							"No export preset is named "
+							+ preset_name
+							+ (
+								": the project has none"
+								if named.is_empty()
+								else ": the presets are " + ", ".join(named)
+							)
+						),
+						"Pass one of the preset names, or add the preset with project_export "
+						+ "add_preset",
+						include_suggestions
+					)
 				)
 			)
 		else:
 			var gone: Array[String] = GdhExportPresets.missing_named(preset_name)
 			if not gone.is_empty():
-				warnings.append(
-					_finding(
-						"warning",
-						"export_preset_files",
-						"The preset %s names files that are not there: %s" % [preset_name, "; ".join(gone)],
-						"Add the files, or point the options at others with project_export set_preset",
-						include_suggestions
+				(
+					warnings
+					. append(
+						_finding(
+							"warning",
+							"export_preset_files",
+							(
+								"The preset %s names files that are not there: %s"
+								% [preset_name, "; ".join(gone)]
+							),
+							"Add the files, or point the options at others with project_export "
+							+ "set_preset",
+							include_suggestions
+						)
 					)
 				)
 
@@ -187,9 +206,13 @@ func validate_project(params: Dictionary) -> Dictionary:
 			file.close()
 
 			if "# TODO" in content or "# FIXME" in content:
-				script_issues.append({"path": script_path, "issue": "Contains TODO/FIXME comments"})
+				script_issues.append(
+					{ "path": script_path, "issue": "Contains TODO/FIXME comments" }
+				)
 			if "pass # TODO" in content:
-				script_issues.append({"path": script_path, "issue": "Contains unimplemented functions"})
+				script_issues.append(
+					{ "path": script_path, "issue": "Contains unimplemented functions" }
+				)
 
 	# Compiled by the server and handed in, as for the health check: a script the engine refuses
 	# stops the export's game at the first scene using it, which the comment check above never saw.
@@ -224,13 +247,17 @@ func validate_project(params: Dictionary) -> Dictionary:
 	# for never works, and the engine says so only while the game runs.
 	checks_performed.append("input_actions")
 	for entry: Dictionary in GdhInputActions.new(_log).undefined_in_scripts():
-		issues.append(
-			_finding(
-				"error",
-				"input_actions",
-				GdhInputActions.undefined_line(entry),
-				"Add it with project_settings add_input_action, or correct the name the script reads",
-				include_suggestions
+		(
+			issues
+			. append(
+				_finding(
+					"error",
+					"input_actions",
+					GdhInputActions.undefined_line(entry),
+					"Add it with project_settings add_input_action, or correct the name the script "
+					+ "reads",
+					include_suggestions
+				)
 			)
 		)
 
@@ -268,14 +295,14 @@ func validate_project(params: Dictionary) -> Dictionary:
 		# Said beside the count, so a project of four hundred scripts is not read as checked whole.
 		"scripts_total": script_files.size(),
 		"issue_count": issues.size(),
-		"warning_count": warnings.size()
+		"warning_count": warnings.size(),
 	}
 
 
 func _finding(
 	type: String, check: String, message: String, suggestion: String, include_suggestion: bool
 ) -> Dictionary:
-	var finding: Dictionary = {"type": type, "check": check, "message": message}
+	var finding: Dictionary = { "type": type, "check": check, "message": message }
 	if include_suggestion:
 		finding["suggestion"] = suggestion
 	return finding

package/build/godot/operations/property_paths.gd

@@ -1,11 +1,9 @@
 @tool
 extends RefCounted
-
 ## Where a property a tool writes lives: on the object given, on a resource built into it, or on an
 ## element of one of its lists that the write has to make first.
 
 const GdhRead = preload("reading.gd")
-
 const HEADINGS: int = PROPERTY_USAGE_CATEGORY | PROPERTY_USAGE_GROUP | PROPERTY_USAGE_SUBGROUP
 
 
@@ -95,11 +93,17 @@ static func _unlisted_in(items: Array, called: String, name: String, at: int) ->
 	var end: int = name.find("/", at + 1)
 	var index: String = name.substr(at + 1) if end < 0 else name.substr(at + 1, end - at - 1)
 	if items.is_empty():
-		return "%s holds no elements, so %s names none: give %s a whole list first." % [called, name, head]
+		return (
+			"%s holds no elements, so %s names none: give %s a whole list first."
+			% [called, name, head]
+		)
 	var last: int = items.size() - 1
 	if not index.is_valid_int():
 		return (
-			"%s is a list, so the step after it is the index of one of its elements, from 0 to %d, not %s."
+			(
+				"%s is a list, so the step after it is the index of one of its elements, from 0 to "
+				+ "%d, not %s."
+			)
 			% [called, last, index]
 		)
 	var place: int = index.to_int()
@@ -116,8 +120,8 @@ static func _unlisted_in(items: Array, called: String, name: String, at: int) ->
 	if end < 0:
 		return (
 			(
-				"%s/%d is an element of %s, which a path does not replace alone: give %s a whole list, or "
-				+ "write a property of the element, as %s/%d/<property>."
+				"%s/%d is an element of %s, which a path does not replace alone: give %s a whole "
+				+ "list, or write a property of the element, as %s/%d/<property>."
 			)
 			% [head, place, called, head, head, place]
 		)
@@ -197,12 +201,15 @@ static func grow(target: Object, name: String, called: String) -> String:
 				above if not above.is_empty() else called,
 				count,
 				element.replace("_", " "),
-				"" if count == 1 else "s"
+				"" if count == 1 else "s",
 			]
 		)
 		if index > count:
 			return (
-				"%s, and a new one goes after the last, so %s%d cannot be written yet: write %s%d first."
+				(
+					"%s, and a new one goes after the last, so %s%d cannot be written yet: write "
+					+ "%s%d first."
+				)
 				% [held, prefix, index, prefix, count]
 			)
 		if not adding.is_valid():
@@ -263,7 +270,10 @@ static func held_elsewhere(target: Object, name: String, home: String) -> String
 		var file: String = "" if held == null else held.resource_path.get_slice("::", 0)
 		if held != null and not held.is_built_in():
 			return (
-				"%s.%s is %s, a file of its own, so %s is written there, with resource_edit modify on %s."
+				(
+					"%s.%s is %s, a file of its own, so %s is written there, with resource_edit "
+					+ "modify on %s."
+				)
 				% [class_called(target), head, file, rest, file]
 			)
 		if held != null and not file.is_empty() and not home.is_empty() and file != home:
@@ -287,9 +297,9 @@ static func _built_in_elsewhere(
 			node = " on %s" % from.get_path_to(placed)
 	var text: String = (
 		(
-			"%s.%s is built into %s, so %s is written there, with scene_node set%s in %s, which changes "
-			+ "it wherever that scene is used. To change it here alone, give %s a %s of its own: a "
-			+ 'value with "_type" set to its class and its properties beside it.'
+			"%s.%s is built into %s, so %s is written there, with scene_node set%s in %s, which "
+			+ "changes it wherever that scene is used. To change it here alone, give %s a %s of "
+			+ 'its own: a value with "_type" set to its class and its properties beside it.'
 		)
 		% [class_called(target), head, file, rest, node, file, head, held.get_class()]
 	)