gdharness 1.2.42 → 1.3.0

package/build/godot/addons/gdharness_editor/bridge_client.gd

@@ -518,7 +518,7 @@ func _handle_message(json_string: String) -> void:
 
 
 ## Says [param tool_name] was not run because the editor is scanning or importing, for the server to
-## ask again once that is over. An older server reads it as an ordinary refusal.
+## ask again once that is over.
 func send_busy(request_id: String, tool_name: String) -> void:
 	_send_message(
 		{

package/build/godot/addons/gdharness_editor/property_values.gd

@@ -600,18 +600,13 @@ func shown(value: Variant) -> String:
 ## not mine". A tag that names a type but lacks the keys to build it is left unhandled on purpose,
 ## so the caller can still read it against the type the property declares.
 func _parse_tagged_dictionary(value: Dictionary) -> Array:
-	var type_tag: String = str(value.get("_type", value.get("type", "")))
+	var type_tag: String = str(value.get("_type", ""))
 	if type_tag == "Resource":
 		return _parse_resource_tag(value)
 
 	# The shared builder is the same one the answer was written by, so every shape it writes comes
-	# back as itself. `type` as the tag is read as `_type`: it is what these tools answered with
-	# before the serialisers were made one, and a caller who kept an answer can still send it.
-	var tagged: Dictionary = value
-	if not value.has("_type") and not type_tag.is_empty():
-		tagged = value.duplicate()
-		tagged["_type"] = type_tag
-	var rebuilt: Variant = _values.deserialize_value(tagged)
+	# back as itself.
+	var rebuilt: Variant = _values.deserialize_value(value)
 	if not rebuilt is Dictionary:
 		return [true, rebuilt]
 
@@ -660,7 +655,7 @@ func _parse_new_resource(type_tag: String, value: Dictionary) -> Array:
 	var wanted: Dictionary = {}
 	for key: Variant in value:
 		var property: String = str(key)
-		if property != "_type" and property != "type":
+		if property != "_type":
 			wanted[property] = value[key]
 	var refused: String = write_all(built, wanted)
 	if not refused.is_empty():

package/build/godot/addons/gdharness_editor/tools/resource_tools.gd

@@ -304,10 +304,10 @@ func read_resource(args: Dictionary) -> Dictionary:
 
 
 func create_shader(args: Dictionary) -> Dictionary:
-	var shader_path: String = _ensure_res_path(str(args.get("shaderPath", "")))
+	var shader_path: String = _ensure_res_path(str(args.get("resourcePath", "")))
 	var shader_type: String = str(args.get("shaderType", "canvas_item"))
 	if shader_path == "res://":
-		return {"ok": false, "error": "shaderPath is required"}
+		return {"ok": false, "error": "resourcePath is required"}
 	var taken: String = _taken(shader_path, "resource_edit op=create_shader", "Edit its text")
 	if not taken.is_empty():
 		return {"ok": false, "error": taken}
@@ -336,9 +336,9 @@ func create_shader(args: Dictionary) -> Dictionary:
 
 
 func create_tileset(args: Dictionary) -> Dictionary:
-	var tileset_path: String = _ensure_res_path(str(args.get("tilesetPath", "")))
+	var tileset_path: String = _ensure_res_path(str(args.get("resourcePath", "")))
 	if tileset_path == "res://":
-		return {"ok": false, "error": "tilesetPath is required"}
+		return {"ok": false, "error": "resourcePath is required"}
 	var taken: String = _taken(tileset_path, "resource_edit op=create_tileset")
 	if not taken.is_empty():
 		return {"ok": false, "error": taken}
@@ -478,7 +478,7 @@ func _source_ids(tile_set: TileSet) -> Array[int]:
 
 func set_tilemap_cells(args: Dictionary) -> Dictionary:
 	var scene_path: String = _ensure_res_path(str(args.get("scenePath", "")))
-	var node_path: String = str(args.get("tilemapNodePath", ""))
+	var node_path: String = str(args.get("nodePath", ""))
 	if scene_path == "res://":
 		return {"ok": false, "error": "scenePath is required"}
 
@@ -702,9 +702,9 @@ func _save_theme(theme: Theme, theme_path: String, item: String) -> String:
 
 
 func set_theme_color(args: Dictionary) -> Dictionary:
-	var theme_path: String = _ensure_res_path(str(args.get("themePath", "")))
+	var theme_path: String = _ensure_res_path(str(args.get("resourcePath", "")))
 	if theme_path == "res://":
-		return {"ok": false, "error": "themePath is required"}
+		return {"ok": false, "error": "resourcePath is required"}
 
 	var color_name: String = str(args.get("colorName", ""))
 	var control_type: String = str(args.get("controlType", ""))
@@ -745,9 +745,9 @@ func set_theme_color(args: Dictionary) -> Dictionary:
 
 
 func set_theme_font_size(args: Dictionary) -> Dictionary:
-	var theme_path: String = _ensure_res_path(str(args.get("themePath", "")))
+	var theme_path: String = _ensure_res_path(str(args.get("resourcePath", "")))
 	if theme_path == "res://":
-		return {"ok": false, "error": "themePath is required"}
+		return {"ok": false, "error": "resourcePath is required"}
 
 	var font_size_name: String = str(args.get("fontSizeName", ""))
 	var control_type: String = str(args.get("controlType", ""))

package/build/godot/addons/gdharness_editor/tools/scene_tools.gd

@@ -410,7 +410,7 @@ func duplicate_node(args: Dictionary) -> Dictionary:
 	var scene_path: String = _to_scene_res_path(project_path, str(args.get("scenePath", "")))
 	var node_path: String = str(args.get("nodePath", ""))
 	var new_name: String = str(args.get("newName", ""))
-	var parent_path: String = str(args.get("parentPath", ""))
+	var parent_path: String = str(args.get("parentNodePath", ""))
 
 	if node_path.is_empty() or new_name.is_empty():
 		return {"ok": false, "error": "Missing nodePath or newName"}

package/build/godot/addons/gdharness_runtime/runtime_autoload.gd

@@ -23,7 +23,7 @@ const Typing = preload("runtime_typing.gd")
 const Values = preload("runtime_values.gd")
 const Waits = preload("runtime_waits.gd")
 
-const PROTOCOL: int = 2
+const PROTOCOL: int = 3
 const DEFAULT_BIND_ADDRESS: String = "127.0.0.1"
 const BIND_ADDRESS_SETTING: String = "gdharness/runtime/bind_address"
 ## 0 asks the operating system for a free port, which is the default and what the server
@@ -502,7 +502,7 @@ func _announce(bind_address: String) -> void:
 	# Written whole under a name no server reads and moved into place, so no look ever meets
 	# the file empty: a server sweeping the directory between an open and a write took the
 	# announcement for a dead game's leftover, and the directory is shared by every server on
-	# the machine, older ones included.
+	# the machine.
 	var staged: String = path + ".tmp"
 	var file: FileAccess = FileAccess.open(staged, FileAccess.WRITE)
 	if file == null:

package/build/godot/addons/gdharness_runtime/runtime_capture.gd

@@ -36,6 +36,35 @@ func capture_viewport(params: Dictionary) -> Dictionary:
 	if not node is Viewport:
 		return {"type": "error", "message": "Node is not a Viewport: " + viewport_path}
 	var viewport: Viewport = node
+	# The root's own state is refused in _capture. Another window of the game's that is hidden or
+	# minimised holds no frame, and asking it for its image makes the engine log the empty read into
+	# the game's output, so the run would stop unclean for an error the capture raised.
+	if viewport is Window and viewport != _host.get_tree().root:
+		var window: Window = viewport
+		if not window.visible:
+			return {
+				"type": "error",
+				"message":
+				(
+					(
+						"The Window at %s is hidden, so nothing is drawn to it. Show it (its visible "
+						+ "property) and ask again."
+					)
+					% viewport_path
+				),
+			}
+		if not window.can_draw():
+			return {
+				"type": "error",
+				"message":
+				(
+					(
+						"Nothing is being drawn to the Window at %s, which is minimised. Restore it and "
+						+ "ask again."
+					)
+					% viewport_path
+				),
+			}
 	if not viewport is SubViewport:
 		return await _capture(viewport, params)
 	# Drawn now rather than taken as it stands. A SubViewport the game does not redraw every frame

package/build/godot/addons/gdharness_runtime/runtime_input.gd

@@ -284,7 +284,7 @@ func _glyph_of(keycode: Key, shifted: bool) -> int:
 ## `pressed` is how a caller asks for one half, the way a drag is made: true holds the button down,
 ## false lets go of one being held.
 func inject_mouse_click(params: Dictionary) -> Dictionary:
-	var point: Variant = Mouse.read_point(params, "x", "y", "position")
+	var point: Variant = Mouse.read_point(params, "x", "y")
 	if point is String:
 		return {"type": "error", "message": point}
 	var position: Vector2 = point
@@ -349,7 +349,7 @@ func inject_mouse_click(params: Dictionary) -> Dictionary:
 ## would have carried. A relative the caller gives is kept, since a game may want to read a motion
 ## the position does not show.
 func inject_mouse_motion(params: Dictionary) -> Dictionary:
-	var point: Variant = Mouse.read_point(params, "x", "y", "position")
+	var point: Variant = Mouse.read_point(params, "x", "y")
 	if point is String:
 		return {"type": "error", "message": point}
 	var position: Vector2 = point
@@ -358,11 +358,6 @@ func inject_mouse_motion(params: Dictionary) -> Dictionary:
 		relative = Vector2(
 			Read.as_float(params.get("relativeX", 0.0)), Read.as_float(params.get("relativeY", 0.0))
 		)
-	elif params.has("relative"):
-		var movement: Variant = Mouse.read_point(params, "relativeX", "relativeY", "relative")
-		if movement is String:
-			return {"type": "error", "message": movement}
-		relative = movement
 
 	var supplied: bool = _follow_in_the_window(position)
 	Input.parse_input_event(_motion(position, relative))

package/build/godot/addons/gdharness_runtime/runtime_mouse.gd

@@ -6,20 +6,12 @@ extends RefCounted
 const Read = preload("reading.gd")
 
 
-## A point the tool schema sends as two flat numbers, or the older form of one [x, y] value.
-## Answers a Vector2, or the String that says what was wrong with it.
-static func read_point(params: Dictionary, x_key: String, y_key: String, pair_key: String) -> Variant:
-	if params.has(x_key) and params.has(y_key):
-		return Vector2(Read.as_float(params[x_key]), Read.as_float(params[y_key]))
-	var raw: Variant = params.get(pair_key, Vector2.ZERO)
-	if raw is Vector2:
-		return raw
-	if raw is Array:
-		var pair: Array = raw
-		if pair.size() < 2:
-			return "%s array must contain [x, y]" % pair_key
-		return Vector2(Read.as_float(pair[0]), Read.as_float(pair[1]))
-	return "%s must be Vector2 or [x, y]" % pair_key
+## A point the tool schema sends as two flat numbers. Answers a Vector2, or the String that says
+## which was missing.
+static func read_point(params: Dictionary, x_key: String, y_key: String) -> Variant:
+	if not params.has(x_key) or not params.has(y_key):
+		return "%s and %s are both needed." % [x_key, y_key]
+	return Vector2(Read.as_float(params[x_key]), Read.as_float(params[y_key]))
 
 
 ## The points of a drag: x, y, then each of via, then toX, toY. Answers the String saying what is

package/build/godot/operations/property_values.gd

@@ -600,18 +600,13 @@ func shown(value: Variant) -> String:
 ## not mine". A tag that names a type but lacks the keys to build it is left unhandled on purpose,
 ## so the caller can still read it against the type the property declares.
 func _parse_tagged_dictionary(value: Dictionary) -> Array:
-	var type_tag: String = str(value.get("_type", value.get("type", "")))
+	var type_tag: String = str(value.get("_type", ""))
 	if type_tag == "Resource":
 		return _parse_resource_tag(value)
 
 	# The shared builder is the same one the answer was written by, so every shape it writes comes
-	# back as itself. `type` as the tag is read as `_type`: it is what these tools answered with
-	# before the serialisers were made one, and a caller who kept an answer can still send it.
-	var tagged: Dictionary = value
-	if not value.has("_type") and not type_tag.is_empty():
-		tagged = value.duplicate()
-		tagged["_type"] = type_tag
-	var rebuilt: Variant = _values.deserialize_value(tagged)
+	# back as itself.
+	var rebuilt: Variant = _values.deserialize_value(value)
 	if not rebuilt is Dictionary:
 		return [true, rebuilt]
 
@@ -660,7 +655,7 @@ func _parse_new_resource(type_tag: String, value: Dictionary) -> Array:
 	var wanted: Dictionary = {}
 	for key: Variant in value:
 		var property: String = str(key)
-		if property != "_type" and property != "type":
+		if property != "_type":
 			wanted[property] = value[key]
 	var refused: String = write_all(built, wanted)
 	if not refused.is_empty():

package/build/keeper.js

@@ -1428,17 +1428,23 @@ function recordAt(path) {
     return null;
   }
   const args = fields["arguments"];
+  const startedBy = fields["startedBy"];
+  const projectPath = fields["projectPath"];
+  const command = fields["command"];
+  if (typeof startedBy !== "number" || typeof projectPath !== "string" || projectPath === "" || typeof command !== "string" || !Array.isArray(args)) {
+    return null;
+  }
   return {
     pid,
     transcript,
     startedAt,
-    ...typeof fields["startedBy"] === "number" ? { startedBy: fields["startedBy"] } : {},
-    projectPath: typeof fields["projectPath"] === "string" ? fields["projectPath"] : "",
+    startedBy,
+    projectPath,
     ...typeof fields["servedBy"] === "string" && fields["servedBy"] !== "" ? { servedBy: fields["servedBy"] } : {},
     ...typeof fields["keeper"] === "string" && fields["keeper"] !== "" ? { keeper: fields["keeper"] } : {},
     ...typeof fields["profile"] === "string" && fields["profile"] !== "" ? { profile: fields["profile"] } : {},
-    arguments: Array.isArray(args) ? args.filter((value) => typeof value === "string") : [],
-    ...typeof fields["command"] === "string" ? { command: fields["command"] } : {},
+    arguments: args.filter((value) => typeof value === "string"),
+    command,
     ...typeof fields["exitCode"] === "number" ? { exitCode: fields["exitCode"] } : {},
     ...typeof fields["exitSignal"] === "string" ? { exitSignal: fields["exitSignal"] } : {},
     ...typeof fields["endedAt"] === "number" ? { endedAt: fields["endedAt"] } : {}

package/package.json

@@ -1,10 +1,9 @@
 {
   "name": "gdharness",
-  "version": "1.2.42",
+  "version": "1.3.0",
   "mcpName": "io.github.Aureliolo/gdharness",
   "description": "A harness for driving a Godot 4 project from an agent: editor addons, a runtime bridge into the running game, an MCP server in front of them, and a CLI that installs and diagnoses the Godot side.",
   "type": "module",
-  "main": "./build/index.js",
   "bin": {
     "gdharness": "build/cli.js"
   },