fraim-framework 2.0.65 → 2.0.67

package/dist/registry/ai-manager-rules/implement-phases/finalize.md

@@ -0,0 +1,177 @@
+# Phase: Finalize
+
+## INTENT
+To prepare the work for human review by updating issue labels, creating evidence documentation, and ensuring all artifacts are in place.
+
+## OUTCOME
+Work is ready for human review with:
+- Issue labels updated
+- Evidence document created
+- PR ready for review
+- All validation complete
+
+## PRINCIPLES
+- **Complete Documentation**: Evidence shows all work done
+- **Proper Labels**: Issue status reflects readiness
+- **Clear Communication**: PR and evidence are clear
+- **Ready for Review**: No blockers for human reviewer
+
+## RULES FOR THIS PHASE
+
+### Success Criteria
+Read `registry/rules/agent-success-criteria.md` via `get_fraim_file` for the complete framework. Focus on:
+- **Integrity** (honest documentation of all work completed)
+- **Completeness** (all finalization steps completed)
+
+### Simplicity Principles
+Read `registry/rules/simplicity.md` via `get_fraim_file` for complete guidelines. Key for finalization:
+- **Focus on the assigned issue only** - document only relevant work
+- **Clear communication** - evidence should be easy to understand
+
+### Git Operations (if needed)
+When using git commands directly (if MCP tools unavailable), read `registry/rules/git-safe-commands.md` via `get_fraim_file` to avoid interactive commands that hang agents.
+
+## WORKFLOW
+
+### Step 1: Update Issue Labels
+
+**Remove:**
+- `status:wip`
+
+**Add:**
+- `status:needs-review`
+
+**GitHub Repository Context:**
+Read `.fraim/config.json` for:
+- `git.repoOwner` - GitHub repository owner
+- `git.repoName` - GitHub repository name
+
+Use GitHub MCP tools to update labels.
+
+### Step 2: Create Evidence Document
+
+**File location:**
+```
+docs/evidence/{issue_number}-implementation-evidence.md
+```
+
+**Evidence document should include:**
+
+#### Summary
+- Issue number and title
+- Issue type (bug or feature)
+- Brief description of changes
+
+#### Implementation Details
+- What was implemented
+- Key files changed
+- Approach taken
+
+#### Testing
+- Tests created/modified
+- Test results (all passing)
+- Smoke test results
+- Regression test results
+
+#### Validation
+- How implementation was validated
+- Validation results
+- Screenshots/output (if applicable)
+
+#### Quality Checks
+- TypeScript compilation: ✅ Pass
+- All tests: ✅ Pass (X/X tests)
+- Code quality: ✅ Pass
+- Git status: ✅ Clean
+
+#### Design Feedback (if applicable)
+- Feedback items addressed
+- How each was resolved
+
+#### Phase Completion
+- All phases completed
+- Evidence from each phase
+- Any iterations or challenges
+
+### Step 3: Verify PR Exists
+
+The GitHub Action should have created a draft PR when you labeled the issue `phase:impl`.
+
+**Verify PR:**
+- PR exists for the feature branch
+- PR title reflects the issue
+- PR description includes context
+
+**If PR doesn't exist:**
+- Create PR manually
+- Link to issue
+- Add evidence document link
+
+### Step 4: Add PR Comment
+
+Add comment to PR with link to evidence:
+```
+Implementation complete. Evidence document: docs/evidence/{issue_number}-implementation-evidence.md
+
+All phases completed:
+✅ Scoping
+✅ Repro/Spike
+✅ Implementation
+✅ Validation
+✅ Smoke Tests
+✅ Regression Tests
+✅ Quality Review
+✅ Finalize
+
+Ready for human review.
+```
+
+### Step 5: Final Verification
+
+**Checklist:**
+- ✅ Issue labels updated
+- ✅ Evidence document created and complete
+- ✅ PR exists and is ready
+- ✅ PR comment added with evidence link
+- ✅ All tests passing
+- ✅ Git status clean
+
+## VALIDATION
+
+### Phase Complete When:
+- ✅ Issue has `status:needs-review` label
+- ✅ Issue does not have `status:wip` label
+- ✅ Evidence document exists and is complete
+- ✅ PR exists and is ready for review
+- ✅ PR has comment linking to evidence
+- ✅ All previous phases complete
+
+### Phase Incomplete If:
+- ❌ Labels not updated
+- ❌ Evidence document missing or incomplete
+- ❌ PR not ready
+- ❌ Previous phases not complete
+
+**Create evidence document:**
+```bash
+touch docs/evidence/{issue_number}-implementation-evidence.md
+```
+
+### Report Back:
+When you complete this phase, call:
+
+```javascript
+seekCoachingOnNextStep({
+  workflowType: "implement",
+  issueNumber: "{issue_number}",
+  currentPhase: "finalize", 
+  status: "complete",
+  evidence: {
+    labelsUpdated: "Issue has status:needs-review label",
+    evidenceDocument: "docs/evidence/456-implementation-evidence.md created",
+    prStatus: "PR ready for review",
+    prComment: "PR comment added with evidence link",
+    allPhasesComplete: "All implementation phases completed successfully"
+  }
+})
+```

package/dist/registry/ai-manager-rules/implement-phases/implement-code.md

@@ -0,0 +1,283 @@
+# Phase: Code
+
+## INTENT
+To write the minimal, testable code needed to fix the bug or implement the feature, following approved designs and established patterns.
+
+## OUTCOME
+Working implementation that:
+- Fixes the bug or implements the feature
+- Follows approved design/RFC
+- Includes comprehensive tests
+- Maintains code quality
+- Is ready for validation
+
+## 🎯 SUCCESS MINDSET
+
+**Your Goal**: Working application that users can actually use, not just passing tests.
+
+**Critical Success Factors**:
+- 🔍 **Manual validation is MANDATORY** - You WILL test in browser/API/CLI manually
+- ⚠️ **Every error must be investigated** - No assumptions, no "that's probably fine"
+- 🚫 **No placeholder code** - Implement complete solutions, no task placeholders or "for now" comments
+- 📊 **100% test success required** - 91% is failure, 99% is failure, only 100% is success
+- 🏗️ **Prototype-first** - Build simplest end-to-end solution, then engineer it properly
+
+## RULES FOR THIS PHASE
+
+### Success Criteria
+Read `registry/rules/agent-success-criteria.md` via `get_fraim_file` for the complete framework. Focus especially on:
+- **Integrity** (never claim tests pass if you didn't run them)
+- **Correctness** (follow architecture, tests must pass, no `any` types)
+- **Completeness** (implement everything in the issue description)
+
+### Simplicity Principles
+Read `registry/rules/simplicity.md` via `get_fraim_file` for complete guidelines. Critical for coding phase:
+- **Prototype-First Development**: Build simplest solution that works end-to-end, validate manually, then engineer correctly
+- **Manual Validation Required**: Test with browser/curl before creating automated tests
+- **Resource Waste Prevention**: Maximum 2 retries for expensive operations
+- **NEVER use placeholder comments** like "For now", "task placeholders", "fix-me notes"
+
+### Architecture Compliance
+Read `.fraim/config.json` for the architecture document path (`customizations.architectureDoc`), then read the local architecture document to understand the full architecture guidelines. Follow all architectural standards - no shortcuts.
+
+### Git Operations (if needed)
+When using git commands directly (if MCP tools unavailable), read `rules/git-safe-commands.md` via `get_fraim_file` to avoid interactive commands that hang agents.
+
+### Failure Handling
+- **If implementation fails**: Return to implement-scoping phase to re-understand requirements
+- **If tests fail**: Fix implementation until all tests pass
+- **If architecture violations**: Return to implement-scoping to understand constraints better
+
+## PRINCIPLES
+- **Design-Driven**: Follow approved RFCs and design documents
+- **Minimal Implementation**: Write only code needed for this issue
+- **Test-First**: Write tests before or alongside implementation
+- **Quality Focus**: Maintain code quality and follow patterns
+- **Complete**: All aspects of design/spec implemented
+
+## 📋 ENHANCED WORKFLOW
+
+### Step 1: Prototype-First Development
+
+**Build Simplest End-to-End Solution**:
+- Focus on getting something working, not perfect
+- Don't worry about code quality initially
+- Prove the approach works before optimizing
+- Get basic functionality working first
+
+**Manual Validation (CRITICAL)**:
+- Test every step manually using browser/curl/CLI
+- Verify each acceptance criteria works
+- Take screenshots/capture output as evidence
+- Fix any issues found immediately
+
+### Step 2: Review Design/Spec
+
+**For Bugs:**
+- Review bug description and repro test
+- Understand root cause
+- Plan minimal fix
+
+**For Features:**
+- Review approved RFC/design document
+- Review spike/POC findings (if applicable)
+- Understand all acceptance criteria
+- Plan implementation approach
+
+### Step 3: Check for Design and PR Feedback
+
+**CRITICAL**: Before implementing, check for feedback:
+- **Design Review Feedback**: `docs/evidence/{issue_number}-design-reviewer-feedback.md`
+- **Feature Review Feedback**: `docs/evidence/{issue_number}-feature-reviewer-feedback.md`
+- **PR Review Feedback**: `docs/evidence/{issue_number}-implement-feedback.md`
+
+**If any feedback exists:**
+- **MUST address all UNADDRESSED items** before proceeding
+- Update feedback files after addressing each item
+- Change status from UNADDRESSED to ADDRESSED with resolution details
+- Cannot skip or defer feedback items
+- Phase cannot complete until all feedback is addressed
+
+**PR Feedback File Format** (if exists):
+```markdown
+### Comment X - ADDRESSED
+- **Author**: reviewer_name
+- **Comment**: Original feedback
+- **Status**: ADDRESSED
+- **Resolution**: How you addressed this feedback
+```
+
+### Step 4: Implement Changes
+
+**For Bugs:**
+- Make minimal changes to fix the issue
+- Focus on root cause, not symptoms
+- Avoid unrelated changes
+- Keep diff small and focused
+
+**For Features:**
+- Implement all aspects from design/spec
+- Follow existing patterns and architecture
+- Create necessary files/modules
+- Implement all API contracts
+- Implement all data models
+- Implement all user interfaces
+- No placeholder code for core functionality
+
+### Step 5: Fix All Errors (MANDATORY)
+
+**Error Investigation Requirements**:
+- **Every error in logs must be investigated**
+- **No error is "expected" until proven**
+- **Fix root causes, not symptoms**
+- **Document why any remaining errors are acceptable**
+
+**Common Error Sources**:
+- Server startup errors
+- API connection errors
+- Database connection errors
+- TypeScript compilation errors
+- Test execution errors
+
+### Step 6: Write Comprehensive Tests
+
+**MANDATORY**: Every issue requires tests - no exceptions.
+
+**For Bugs:**
+- Verify repro test from implement-repro phase now passes
+- Add additional edge case tests if needed
+- Ensure tests cover the fix
+
+**For Features:**
+- Write tests for all acceptance criteria
+- Test main user scenarios
+- Test edge cases
+- Test error conditions
+- Read `.fraim/config.json` for the architecture document path (`customizations.architectureDoc`), then read the local architecture document to understand the full test architecture standards
+
+**Test Requirements:**
+- Use shared-server-utils.ts for server tests
+- Unique API keys per test
+- Proper cleanup in finally blocks
+- No individual server instances
+- Proper timeouts (5-10s for network calls)
+- Tests must validate real functionality, not mocks
+- No tests that default to passing
+
+**Test Tagging Guidelines:**
+Tag tests appropriately to ensure proper test suite execution:
+
+- **`smoke`**: Tag tests as "smoke" if they verify:
+  - Core system functionality (CLI commands, server startup, basic workflows)
+  - Critical user journeys (init, sync, basic operations)
+  - Integration points between major components
+  - Functionality that, if broken, would make the system unusable
+
+- **`integration`**: Tests that verify multiple components working together
+- **`unit`**: Tests that verify individual functions or classes in isolation
+- **`e2e`**: End-to-end tests that verify complete user workflows
+
+### Step 7: Basic Compilation Check
+
+**Verify code compiles:**
+
+**Build Commands**: Always check `.fraim/config.json` first for `customizations.validation.buildCommand`, use that if available, otherwise default to `npm run build`.
+
+**What to Look For**:
+- Exit code 0 (success)
+- No TypeScript compilation errors
+- Clean build output
+
+**Must exit with code 0** (no errors)
+
+If compilation fails:
+- Fix TypeScript errors
+- Re-compile
+- Iterate until clean
+
+**Note**: Full validation, testing, and manual verification will be handled in subsequent phases (implement-validate, implement-smoke, implement-regression).
+
+## 📸 EVIDENCE REQUIREMENTS
+
+You MUST provide concrete evidence for all claims:
+
+1. **Implementation Complete**: Code written per design/spec
+2. **Tests Written**: Comprehensive test coverage for new functionality
+3. **Compilation Success**: TypeScript compiles without errors
+4. **Basic Functionality**: Code implements the required features/fixes
+
+**Note**: Screenshots, manual validation, server logs, and API responses will be captured in the implement-validate phase.
+
+## VALIDATION
+
+### Phase Complete When:
+- ✅ Implementation complete per design/spec
+- ✅ (Bugs) Minimal, focused changes
+- ✅ (Features) All design aspects implemented
+- ✅ Tests written for new functionality
+- ✅ TypeScript compiles cleanly
+- ✅ Design feedback addressed (if applicable)
+- ✅ **PR feedback addressed** (if `docs/evidence/{issue_number}-implement-feedback.md` exists)
+- ✅ Code implements required features/fixes
+
+### Phase Incomplete If:
+- ❌ Design/spec not fully implemented
+- ❌ No tests written for new functionality
+- ❌ TypeScript compilation errors
+- ❌ Design feedback not addressed
+- ❌ **PR feedback not addressed** (UNADDRESSED items remain in feedback file)
+- ❌ Code doesn't implement required functionality
+
+### Report Back:
+When you complete this phase, call:
+
+```javascript
+seekMentoring({
+  workflowType: "implement",
+  issueNumber: "{issue_number}",
+  currentPhase: "implement-code", 
+  status: "complete",
+  findings: {
+    issueType: "bug", // or "feature" - Required for phase validation
+    evidence: "Brief summary of what you implemented and validated"
+  },
+  evidence: {
+    implementation: "Brief summary of what you implemented",
+    testsWritten: "Description of tests created for new functionality",
+    compilationStatus: "TypeScript compiles without errors",
+    feedbackAddressed: "All design/PR feedback addressed (if applicable)"
+  }
+})
+```
+
+If implementation incomplete, iterate:
+```javascript
+seekMentoring({
+  workflowType: "implement",
+  issueNumber: "{issue_number}",
+  currentPhase: "implement-code",
+  status: "incomplete", 
+  findings: {
+    issueType: "bug", // or "feature" - Required for phase validation
+    uncertainties: ["Issues encountered", "What needs to be fixed"]
+  }
+})
+```
+```
+
+## SCRIPTS
+
+**Run tests:**
+```bash
+npm test -- path/to/test.test.ts
+```
+
+**Compile TypeScript:**
+```bash
+npx tsc --noEmit --skipLibCheck
+```
+
+**Start dev server (for manual testing in validate phase):**
+```bash
+npm run dev
+```

package/dist/registry/ai-manager-rules/implement-phases/implement-completeness-review.md

@@ -0,0 +1,120 @@
+# Phase: Implement-Completeness-Review
+
+## INTENT
+To verify that all design aspects have been implemented and that the work fully addresses the requirements from the design document or issue specification.
+
+## OUTCOME
+Confirmation that:
+- All design aspects implemented
+- All acceptance criteria met
+- Implementation matches design specifications
+- Work is complete and ready for finalization
+
+## PRINCIPLES
+- **Design Fidelity**: Implementation must match design specifications
+- **Complete Coverage**: All design aspects must be addressed
+- **Evidence-Based**: Use existing comprehensive review workflows
+
+## WORKFLOW
+
+### Step 1: Check for PR Feedback to Address
+
+- Check for PR feedback file: `docs/evidence/{issue_number}-implement-feedback.md`
+- If feedback file exists, verify all comments have been addressed before proceeding
+
+**PR Feedback Validation:**
+- Read the feedback file to see all previous review rounds
+- Ensure all items marked as UNADDRESSED have been resolved
+- Update feedback file with ADDRESSED status and resolution details
+- Cannot proceed until all feedback items are properly addressed
+
+**Expected behavior:**
+- All UNADDRESSED items in feedback file must be resolved
+- Each resolved item should have detailed resolution explanation
+- Phase cannot complete with any remaining UNADDRESSED items
+
+### Step 2: Execute Design Review Workflow
+
+Use the comprehensive design validation workflow:
+- Read `registry/workflows/reviewer/review-implementation-vs-design-spec.md` via `get_fraim_file`
+- Follow the complete systematic review process
+- This workflow provides detailed checklists, validation steps, and templates
+- Works for both bugs and features - all should be reviewed against their design spec
+
+### Step 3: Execute Review Workflow
+
+**Follow the design review workflow completely:**
+- Use all the checklists provided
+- Execute all validation steps
+- Create feedback documents using the templates
+- Follow the iteration limits (max 3)
+
+### Step 4: Architecture Compliance
+
+Read `.fraim/config.json` for the architecture document path (`customizations.architectureDoc`), then read the local architecture document to understand the full architecture guidelines. Verify implementation follows all design standards.
+
+## VALIDATION
+
+### Phase Complete When:
+- ✅ PR comments addressed (if applicable)
+- ✅ PR comment verification script passes (if applicable)
+- ✅ Appropriate review workflow executed completely
+- ✅ All workflow checklists completed
+- ✅ All design aspects verified per workflow
+- ✅ Evidence quality meets workflow standards
+- ✅ Feedback documents created using workflow templates
+- ✅ Architecture compliance verified
+
+### Phase Incomplete If:
+- ❌ PR comments not properly addressed
+- ❌ PR comment verification script fails
+- ❌ Review workflow not followed completely
+- ❌ Workflow checklists incomplete
+- ❌ Design aspects not verified per workflow standards
+- ❌ Evidence quality insufficient per workflow criteria
+- ❌ Feedback documents missing or not using templates
+
+### Report Back:
+When you complete this phase, call:
+
+```javascript
+seekMentoring({
+  workflowType: "implement",
+  issueNumber: "{issue_number}",
+  currentPhase: "implement-completeness-review", 
+  status: "complete",
+  findings: {
+    issueType: "bug" // or "feature" - Required for phase validation
+  },
+  evidence: {
+    reviewWorkflowUsed: "review-implementation-vs-design-spec", // Which workflow was used
+    workflowChecklistsComplete: "YES", // All checklists from workflow completed?
+    designAspectsVerified: "YES", // All design aspects verified per workflow?
+    evidenceQualityMet: "YES", // Evidence meets workflow standards?
+    feedbackDocumentsCreated: "YES", // Feedback documents created using templates?
+    architectureCompliant: "YES", // Architecture compliance verified?
+    reviewDecision: "APPROVE", // APPROVE/REQUEST_CHANGES/REJECT per workflow
+    summary: "Completed systematic design review using comprehensive workflow. All design aspects verified and documented."
+  }
+})
+```
+
+If review reveals issues:
+```javascript
+seekMentoring({
+  workflowType: "implement",
+  issueNumber: "{issue_number}",
+  currentPhase: "implement-completeness-review", 
+  status: "incomplete",
+  findings: {
+    issueType: "bug" // or "feature" - Required for phase validation
+  },
+  evidence: {
+    reviewWorkflowUsed: "review-implementation-vs-design-spec",
+    reviewDecision: "REQUEST_CHANGES", // or "REJECT"
+    issuesFound: ["Missing test case X per workflow checklist", "Design requirement Y not implemented"],
+    feedbackDocumentLocation: "docs/evidence/{issue}-design-reviewer-feedback.md",
+    nextAction: "Implementation agent must address feedback per workflow iteration process"
+  }
+})
+```