fastify 5.0.0 → 5.2.0

package/test/route.7.test.js

@@ -2,11 +2,11 @@
 
 const stream = require('node:stream')
 const split = require('split2')
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const Fastify = require('..')
+const createError = require('@fastify/error')
 
-test("HEAD route should handle stream.on('error')", t => {
+test("HEAD route should handle stream.on('error')", (t, done) => {
   t.plan(6)
 
   const resStream = stream.Readable.from('Hello with error!')
@@ -31,23 +31,24 @@ test("HEAD route should handle stream.on('error')", t => {
 
   logStream.once('data', line => {
     const { message, stack } = expectedError
-    t.same(line.err, { type: 'Error', message, stack })
-    t.equal(line.msg, 'Error on Stream found for HEAD route')
-    t.equal(line.level, 50)
+    t.assert.deepStrictEqual(line.err, { type: 'Error', message, stack })
+    t.assert.strictEqual(line.msg, 'Error on Stream found for HEAD route')
+    t.assert.strictEqual(line.level, 50)
   })
 
   fastify.inject({
     method: 'HEAD',
     url: '/more-coffee'
   }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
-    t.equal(res.headers['content-type'], undefined)
+    t.assert.ifError(error)
+    t.assert.strictEqual(res.statusCode, 200)
+    t.assert.strictEqual(res.headers['content-type'], undefined)
+    done()
   })
 })
 
-test('HEAD route should be exposed by default', t => {
-  t.plan(7)
+test('HEAD route should be exposed by default', async t => {
+  t.plan(5)
 
   const resStream = stream.Readable.from('Hello with error!')
   const resJson = { hello: 'world' }
@@ -70,28 +71,24 @@ test('HEAD route should be exposed by default', t => {
     }
   })
 
-  fastify.inject({
+  let res = await fastify.inject({
     method: 'HEAD',
     url: '/without-flag'
-  }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
   })
+  t.assert.strictEqual(res.statusCode, 200)
 
-  fastify.inject({
+  res = await fastify.inject({
     method: 'HEAD',
     url: '/with-flag'
-  }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
-    t.equal(res.headers['content-type'], 'application/json; charset=utf-8')
-    t.equal(res.headers['content-length'], `${Buffer.byteLength(JSON.stringify(resJson))}`)
-    t.equal(res.body, '')
   })
+  t.assert.strictEqual(res.statusCode, 200)
+  t.assert.strictEqual(res.headers['content-type'], 'application/json; charset=utf-8')
+  t.assert.strictEqual(res.headers['content-length'], `${Buffer.byteLength(JSON.stringify(resJson))}`)
+  t.assert.strictEqual(res.body, '')
 })
 
-test('HEAD route should be exposed if route exposeHeadRoute is set', t => {
-  t.plan(7)
+test('HEAD route should be exposed if route exposeHeadRoute is set', async t => {
+  t.plan(5)
 
   const resBuffer = Buffer.from('I am a coffee!')
   const resJson = { hello: 'world' }
@@ -114,27 +111,23 @@ test('HEAD route should be exposed if route exposeHeadRoute is set', t => {
     }
   })
 
-  fastify.inject({
+  let res = await fastify.inject({
     method: 'HEAD',
     url: '/one'
-  }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
-    t.equal(res.headers['content-type'], 'application/octet-stream')
-    t.equal(res.headers['content-length'], `${resBuffer.byteLength}`)
-    t.equal(res.body, '')
   })
+  t.assert.strictEqual(res.statusCode, 200)
+  t.assert.strictEqual(res.headers['content-type'], 'application/octet-stream')
+  t.assert.strictEqual(res.headers['content-length'], `${resBuffer.byteLength}`)
+  t.assert.strictEqual(res.body, '')
 
-  fastify.inject({
+  res = await fastify.inject({
     method: 'HEAD',
     url: '/two'
-  }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 404)
   })
+  t.assert.strictEqual(res.statusCode, 404)
 })
 
-test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes (global)', t => {
+test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes (global)', (t, done) => {
   t.plan(6)
 
   const resBuffer = Buffer.from('I am a coffee!')
@@ -165,16 +158,17 @@ test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes
     method: 'HEAD',
     url: '/one'
   }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
-    t.equal(res.headers['content-type'], 'application/pdf')
-    t.equal(res.headers['content-length'], `${resBuffer.byteLength}`)
-    t.equal(res.headers['x-custom-header'], 'some-custom-header')
-    t.equal(res.body, '')
+    t.assert.ifError(error)
+    t.assert.strictEqual(res.statusCode, 200)
+    t.assert.strictEqual(res.headers['content-type'], 'application/pdf')
+    t.assert.strictEqual(res.headers['content-length'], `${resBuffer.byteLength}`)
+    t.assert.strictEqual(res.headers['x-custom-header'], 'some-custom-header')
+    t.assert.strictEqual(res.body, '')
+    done()
   })
 })
 
-test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes (route)', t => {
+test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes (route)', (t, done) => {
   t.plan(6)
 
   const fastify = Fastify()
@@ -205,16 +199,17 @@ test('Set a custom HEAD route before GET one without disabling exposeHeadRoutes
     method: 'HEAD',
     url: '/one'
   }, (error, res) => {
-    t.error(error)
-    t.equal(res.statusCode, 200)
-    t.equal(res.headers['content-type'], 'application/pdf')
-    t.equal(res.headers['content-length'], `${resBuffer.byteLength}`)
-    t.equal(res.headers['x-custom-header'], 'some-custom-header')
-    t.equal(res.body, '')
+    t.assert.ifError(error)
+    t.assert.strictEqual(res.statusCode, 200)
+    t.assert.strictEqual(res.headers['content-type'], 'application/pdf')
+    t.assert.strictEqual(res.headers['content-length'], `${resBuffer.byteLength}`)
+    t.assert.strictEqual(res.headers['x-custom-header'], 'some-custom-header')
+    t.assert.strictEqual(res.body, '')
+    done()
   })
 })
 
-test('HEAD routes properly auto created for GET routes when prefixTrailingSlash: \'no-slash\'', t => {
+test('HEAD routes properly auto created for GET routes when prefixTrailingSlash: \'no-slash\'', (t, done) => {
   t.plan(2)
 
   const fastify = Fastify()
@@ -234,8 +229,9 @@ test('HEAD routes properly auto created for GET routes when prefixTrailingSlash:
   }, { prefix: '/prefix' })
 
   fastify.inject({ url: '/prefix/prefix', method: 'HEAD' }, (err, res) => {
-    t.error(err)
-    t.equal(res.statusCode, 404)
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.statusCode, 404)
+    done()
   })
 })
 
@@ -262,9 +258,9 @@ test('HEAD routes properly auto created for GET routes when prefixTrailingSlash:
   const trailingSlashReply = await fastify.inject({ url: '/prefix/', method: 'HEAD' })
   const noneTrailingReply = await fastify.inject({ url: '/prefix', method: 'HEAD' })
 
-  t.equal(doublePrefixReply.statusCode, 404)
-  t.equal(trailingSlashReply.statusCode, 200)
-  t.equal(noneTrailingReply.statusCode, 200)
+  t.assert.strictEqual(doublePrefixReply.statusCode, 404)
+  t.assert.strictEqual(trailingSlashReply.statusCode, 200)
+  t.assert.strictEqual(noneTrailingReply.statusCode, 200)
 })
 
 test('GET route with body schema should throw', t => {
@@ -272,7 +268,7 @@ test('GET route with body schema should throw', t => {
 
   const fastify = Fastify()
 
-  t.throws(() => {
+  t.assert.throws(() => {
     fastify.route({
       method: 'GET',
       path: '/get',
@@ -283,7 +279,7 @@ test('GET route with body schema should throw', t => {
         reply.send({ hello: 'world' })
       }
     })
-  }, new Error('Body validation schema for GET:/get route is not supported!'))
+  }, createError('FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED', 'Body validation schema for GET:/get route is not supported!')())
 })
 
 test('HEAD route with body schema should throw', t => {
@@ -291,7 +287,7 @@ test('HEAD route with body schema should throw', t => {
 
   const fastify = Fastify()
 
-  t.throws(() => {
+  t.assert.throws(() => {
     fastify.route({
       method: 'HEAD',
       path: '/shouldThrow',
@@ -302,7 +298,7 @@ test('HEAD route with body schema should throw', t => {
         reply.send({ hello: 'world' })
       }
     })
-  }, new Error('Body validation schema for HEAD:/shouldThrow route is not supported!'))
+  }, createError('FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED', 'Body validation schema for HEAD:/shouldThrow route is not supported!')())
 })
 
 test('[HEAD, GET] route with body schema should throw', t => {
@@ -310,7 +306,7 @@ test('[HEAD, GET] route with body schema should throw', t => {
 
   const fastify = Fastify()
 
-  t.throws(() => {
+  t.assert.throws(() => {
     fastify.route({
       method: ['HEAD', 'GET'],
       path: '/shouldThrowHead',
@@ -321,7 +317,7 @@ test('[HEAD, GET] route with body schema should throw', t => {
         reply.send({ hello: 'world' })
       }
     })
-  }, new Error('Body validation schema for HEAD:/shouldThrowHead route is not supported!'))
+  }, createError('FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED', 'Body validation schema for HEAD:/shouldThrowHead route is not supported!')())
 })
 
 test('GET route with body schema should throw - shorthand', t => {
@@ -329,7 +325,7 @@ test('GET route with body schema should throw - shorthand', t => {
 
   const fastify = Fastify()
 
-  t.throws(() => {
+  t.assert.throws(() => {
     fastify.get('/shouldThrow', {
       schema: {
         body: {}
@@ -339,7 +335,7 @@ test('GET route with body schema should throw - shorthand', t => {
       reply.send({ hello: 'world' })
     }
     )
-  }, new Error('Body validation schema for GET:/shouldThrow route is not supported!'))
+  }, createError('FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED', 'Body validation schema for GET:/shouldThrow route is not supported!')())
 })
 
 test('HEAD route with body schema should throw - shorthand', t => {
@@ -347,7 +343,7 @@ test('HEAD route with body schema should throw - shorthand', t => {
 
   const fastify = Fastify()
 
-  t.throws(() => {
+  t.assert.throws(() => {
     fastify.head('/shouldThrow2', {
       schema: {
         body: {}
@@ -357,5 +353,5 @@ test('HEAD route with body schema should throw - shorthand', t => {
       reply.send({ hello: 'world' })
     }
     )
-  }, new Error('Body validation schema for HEAD:/shouldThrow2 route is not supported!'))
+  }, createError('FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED', 'Body validation schema for HEAD:/shouldThrow2 route is not supported!')())
 })

package/test/route.8.test.js

@@ -1,9 +1,8 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const sget = require('simple-get').concat
-const Fastify = require('../fastify')
+const Fastify = require('..')
 const {
   FST_ERR_INVALID_URL
 } = require('../lib/errors')
@@ -24,9 +23,9 @@ test('Request and Reply share the route options', async t => {
     url: '/',
     config,
     handler: (req, reply) => {
-      t.same(req.routeOptions, reply.routeOptions)
-      t.same(req.routeOptions.config, reply.routeOptions.config)
-      t.match(req.routeOptions.config, config, 'there are url and method additional properties')
+      t.assert.deepStrictEqual(req.routeOptions, reply.routeOptions)
+      t.assert.deepStrictEqual(req.routeOptions.config, reply.routeOptions.config)
+      t.assert.match(req.routeOptions.config, config, 'there are url and method additional properties')
 
       reply.send({ hello: 'world' })
     }
@@ -62,10 +61,10 @@ test('Will not try to re-createprefixed HEAD route if it already exists and expo
 
   await fastify.ready()
 
-  t.ok(true)
+  t.assert.ok(true)
 })
 
-test('route with non-english characters', t => {
+test('route with non-english characters', (t, done) => {
   t.plan(4)
 
   const fastify = Fastify()
@@ -75,16 +74,17 @@ test('route with non-english characters', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     sget({
       method: 'GET',
       url: getServerUrl(fastify) + encodeURI('/föö')
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.equal(body.toString(), 'here /föö')
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.strictEqual(body.toString(), 'here /föö')
+      done()
     })
   })
 })
@@ -96,7 +96,7 @@ test('invalid url attribute - non string URL', t => {
   try {
     fastify.get(/^\/(donations|skills|blogs)/, () => { })
   } catch (error) {
-    t.equal(error.code, FST_ERR_INVALID_URL().code)
+    t.assert.strictEqual(error.code, FST_ERR_INVALID_URL().code)
   }
 })
 
@@ -117,7 +117,7 @@ test('exposeHeadRoute should not reuse the same route option', async t => {
   })
 
   fastify.addHook('onRoute', function (routeOption) {
-    t.equal(routeOption.onRequest.length, 1)
+    t.assert.strictEqual(routeOption.onRequest.length, 1)
   })
 
   fastify.route({
@@ -140,7 +140,7 @@ test('using fastify.all when a catchall is defined does not degrade performance'
     fastify.all(`/${i}`, async (_, reply) => reply.json({ ok: true }))
   }
 
-  t.pass()
+  t.assert.ok("fastify.all doesn't degrade performance")
 })
 
 test('Adding manually HEAD route after GET with the same path throws Fastify duplicated route instance error', t => {
@@ -164,8 +164,70 @@ test('Adding manually HEAD route after GET with the same path throws Fastify dup
         reply.send({ hello: 'world' })
       }
     })
-    t.fail('Should throw fastify duplicated route declaration')
+    t.assert.fail('Should throw fastify duplicated route declaration')
   } catch (error) {
-    t.equal(error.code, 'FST_ERR_DUPLICATED_ROUTE')
+    t.assert.strictEqual(error.code, 'FST_ERR_DUPLICATED_ROUTE')
   }
 })
+
+test('Will pass onSend hook to HEAD method if exposeHeadRoutes is true /1', async (t) => {
+  t.plan(1)
+
+  const fastify = Fastify({ exposeHeadRoutes: true })
+
+  await fastify.register((scope, opts, next) => {
+    scope.route({
+      method: 'GET',
+      path: '/route',
+      handler: (req, reply) => {
+        reply.send({ ok: true })
+      },
+      onSend: (req, reply, payload, done) => {
+        reply.header('x-content-type', 'application/fastify')
+        done(null, payload)
+      }
+    })
+
+    next()
+  }, { prefix: '/prefix' })
+
+  await fastify.ready()
+
+  const result = await fastify.inject({
+    url: '/prefix/route',
+    method: 'HEAD'
+  })
+
+  t.assert.strictEqual(result.headers['x-content-type'], 'application/fastify')
+})
+
+test('Will pass onSend hook to HEAD method if exposeHeadRoutes is true /2', async (t) => {
+  t.plan(1)
+
+  const fastify = Fastify({ exposeHeadRoutes: true })
+
+  await fastify.register((scope, opts, next) => {
+    scope.route({
+      method: 'get',
+      path: '/route',
+      handler: (req, reply) => {
+        reply.send({ ok: true })
+      },
+      onSend: (req, reply, payload, done) => {
+        reply.header('x-content-type', 'application/fastify')
+        done(null, payload)
+      }
+    })
+
+    next()
+  }, { prefix: '/prefix' })
+
+  await fastify.ready()
+
+  const result = await fastify.inject({
+    url: '/prefix/route',
+    method: 'HEAD'
+  })
+
+  t.assert.strictEqual(result.headers['x-content-type'], 'application/fastify')
+})