fastify 5.0.0 → 5.2.0

package/test/http2/closing.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const { test } = require('node:test')
 const Fastify = require('../..')
 const http2 = require('node:http2')
 const { promisify } = require('node:util')
@@ -9,102 +9,94 @@ const { once } = require('node:events')
 const { buildCertificate } = require('../build-certificate')
 const { getServerUrl } = require('../helper')
 
-t.before(buildCertificate)
+test.before(buildCertificate)
 
-t.test('http/2 request while fastify closing', t => {
+test('http/2 request while fastify closing', (t, done) => {
   let fastify
   try {
     fastify = Fastify({
       http2: true
     })
-    t.pass('http2 successfully loaded')
+    t.assert.ok('http2 successfully loaded')
   } catch (e) {
-    t.fail('http2 loading failed', e)
+    t.assert.fail('http2 loading failed')
   }
 
   fastify.get('/', () => Promise.resolve({}))
 
+  t.after(() => { fastify.close() })
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
-
-    t.test('return 200', t => {
-      const url = getServerUrl(fastify)
-      const session = http2.connect(url, function () {
-        this.request({
-          ':method': 'GET',
-          ':path': '/'
-        }).on('response', headers => {
-          t.equal(headers[':status'], 503)
-          t.end()
-          this.destroy()
-        }).on('error', () => {
-          // Nothing to do here,
-          // we are not interested in this error that might
-          // happen or not
-        })
-        fastify.close()
+    t.assert.ifError(err)
+
+    const url = getServerUrl(fastify)
+    const session = http2.connect(url, function () {
+      this.request({
+        ':method': 'GET',
+        ':path': '/'
+      }).on('response', headers => {
+        t.assert.strictEqual(headers[':status'], 503)
+        done()
+        this.destroy()
+      }).on('error', () => {
+        // Nothing to do here,
+        // we are not interested in this error that might
+        // happen or not
       })
       session.on('error', () => {
         // Nothing to do here,
         // we are not interested in this error that might
         // happen or not
-        t.end()
+        done()
       })
+      fastify.close()
     })
-
-    t.end()
   })
 })
 
-t.test('http/2 request while fastify closing - return503OnClosing: false', t => {
+test('http/2 request while fastify closing - return503OnClosing: false', (t, done) => {
   let fastify
   try {
     fastify = Fastify({
       http2: true,
       return503OnClosing: false
     })
-    t.pass('http2 successfully loaded')
+    t.assert.ok('http2 successfully loaded')
   } catch (e) {
-    t.fail('http2 loading failed', e)
+    t.assert.fail('http2 loading failed')
   }
 
+  t.after(() => { fastify.close() })
+
   fastify.get('/', () => Promise.resolve({}))
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
-
-    t.test('return 200', t => {
-      const url = getServerUrl(fastify)
-      const session = http2.connect(url, function () {
-        this.request({
-          ':method': 'GET',
-          ':path': '/'
-        }).on('response', headers => {
-          t.equal(headers[':status'], 200)
-          t.end()
-          this.destroy()
-        }).on('error', () => {
-          // Nothing to do here,
-          // we are not interested in this error that might
-          // happen or not
-        })
-        fastify.close()
-      })
-      session.on('error', () => {
+    t.assert.ifError(err)
+    const url = getServerUrl(fastify)
+    const session = http2.connect(url, function () {
+      this.request({
+        ':method': 'GET',
+        ':path': '/'
+      }).on('response', headers => {
+        t.assert.strictEqual(headers[':status'], 200)
+        done()
+        this.destroy()
+      }).on('error', () => {
         // Nothing to do here,
         // we are not interested in this error that might
         // happen or not
-        t.end()
       })
+      fastify.close()
+    })
+    session.on('error', () => {
+      // Nothing to do here,
+      // we are not interested in this error that might
+      // happen or not
+      done()
     })
-
-    t.end()
   })
 })
 
-t.test('http/2 closes successfully with async await', async t => {
+test('http/2 closes successfully with async await', async t => {
   const fastify = Fastify({
     http2SessionTimeout: 100,
     http2: true
@@ -119,7 +111,7 @@ t.test('http/2 closes successfully with async await', async t => {
   await fastify.close()
 })
 
-t.test('https/2 closes successfully with async await', async t => {
+test('https/2 closes successfully with async await', async t => {
   const fastify = Fastify({
     http2SessionTimeout: 100,
     http2: true,
@@ -138,7 +130,7 @@ t.test('https/2 closes successfully with async await', async t => {
   await fastify.close()
 })
 
-t.test('http/2 server side session emits a timeout event', async t => {
+test('http/2 server side session emits a timeout event', async t => {
   let _resolve
   const p = new Promise((resolve) => { _resolve = resolve })
 
@@ -162,7 +154,7 @@ t.test('http/2 server side session emits a timeout event', async t => {
   }).end()
 
   const [headers] = await once(req, 'response')
-  t.equal(headers[':status'], 200)
+  t.assert.strictEqual(headers[':status'], 200)
   req.resume()
 
   // An error might or might not happen, as it's OS dependent.

package/test/http2/constraint.test.js

@@ -1,7 +1,6 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const Fastify = require('../..')
 const h2url = require('h2url')
 
@@ -9,10 +8,10 @@ const alpha = { res: 'alpha' }
 const beta = { res: 'beta' }
 
 const { buildCertificate } = require('../build-certificate')
-t.before(buildCertificate)
+test.before(buildCertificate)
 
-test('A route supports host constraints under http2 protocol and secure connection', (t) => {
-  t.plan(6)
+test('A route supports host constraints under http2 protocol and secure connection', async (t) => {
+  t.plan(5)
 
   let fastify
   try {
@@ -23,9 +22,9 @@ test('A route supports host constraints under http2 protocol and secure connecti
         cert: global.context.cert
       }
     })
-    t.pass('Key/cert successfully loaded')
+    t.assert.ok(true, 'Key/cert successfully loaded')
   } catch (e) {
-    t.fail('Key/cert loading failed', e)
+    t.assert.fail('Key/cert loading failed')
   }
 
   const constrain = 'fastify.dev'
@@ -53,60 +52,58 @@ test('A route supports host constraints under http2 protocol and secure connecti
       reply.code(200).send({ ...beta, hostname: req.hostname })
     }
   })
+  t.after(() => { fastify.close() })
 
-  fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+  await fastify.listen({ port: 0 })
 
-    t.test('https get request - no constrain', async (t) => {
-      t.plan(3)
+  await t.test('https get request - no constrain', async (t) => {
+    t.plan(3)
 
-      const url = `https://localhost:${fastify.server.address().port}`
-      const res = await h2url.concat({ url })
+    const url = `https://localhost:${fastify.server.address().port}`
+    const res = await h2url.concat({ url })
 
-      t.equal(res.headers[':status'], 200)
-      t.equal(res.headers['content-length'], '' + JSON.stringify(alpha).length)
-      t.same(JSON.parse(res.body), alpha)
-    })
-
-    t.test('https get request - constrain', async (t) => {
-      t.plan(3)
+    t.assert.strictEqual(res.headers[':status'], 200)
+    t.assert.strictEqual(res.headers['content-length'], '' + JSON.stringify(alpha).length)
+    t.assert.deepStrictEqual(JSON.parse(res.body), alpha)
+  })
 
-      const url = `https://localhost:${fastify.server.address().port}/beta`
-      const res = await h2url.concat({
-        url,
-        headers: {
-          ':authority': constrain
-        }
-      })
+  await t.test('https get request - constrain', async (t) => {
+    t.plan(3)
 
-      t.equal(res.headers[':status'], 200)
-      t.equal(res.headers['content-length'], '' + JSON.stringify(beta).length)
-      t.same(JSON.parse(res.body), beta)
+    const url = `https://localhost:${fastify.server.address().port}/beta`
+    const res = await h2url.concat({
+      url,
+      headers: {
+        ':authority': constrain
+      }
     })
 
-    t.test('https get request - constrain - not found', async (t) => {
-      t.plan(1)
+    t.assert.strictEqual(res.headers[':status'], 200)
+    t.assert.strictEqual(res.headers['content-length'], '' + JSON.stringify(beta).length)
+    t.assert.deepStrictEqual(JSON.parse(res.body), beta)
+  })
 
-      const url = `https://localhost:${fastify.server.address().port}/beta`
-      const res = await h2url.concat({
-        url
-      })
+  await t.test('https get request - constrain - not found', async (t) => {
+    t.plan(1)
 
-      t.equal(res.headers[':status'], 404)
+    const url = `https://localhost:${fastify.server.address().port}/beta`
+    const res = await h2url.concat({
+      url
     })
-    t.test('https get request - constrain - verify hostname and port from request', async (t) => {
-      t.plan(1)
-
-      const url = `https://localhost:${fastify.server.address().port}/hostname_port`
-      const res = await h2url.concat({
-        url,
-        headers: {
-          ':authority': constrain
-        }
-      })
-      const body = JSON.parse(res.body)
-      t.equal(body.hostname, constrain)
+
+    t.assert.strictEqual(res.headers[':status'], 404)
+  })
+  await t.test('https get request - constrain - verify hostname and port from request', async (t) => {
+    t.plan(1)
+
+    const url = `https://localhost:${fastify.server.address().port}/hostname_port`
+    const res = await h2url.concat({
+      url,
+      headers: {
+        ':authority': constrain
+      }
     })
+    const body = JSON.parse(res.body)
+    t.assert.strictEqual(body.hostname, constrain)
   })
 })

package/test/http2/head.test.js

@@ -1,35 +1,34 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const Fastify = require('../..')
 const h2url = require('h2url')
 const msg = { hello: 'world' }
 
-let fastify
-try {
-  fastify = Fastify({
-    http2: true
-  })
-  t.pass('http2 successfully loaded')
-} catch (e) {
-  t.fail('http2 loading failed', e)
-}
+test('http2 HEAD test', async (t) => {
+  let fastify
+  try {
+    fastify = Fastify({
+      http2: true
+    })
+    t.assert.ok(true, 'http2 successfully loaded')
+  } catch (e) {
+    t.assert.fail('http2 loading failed')
+  }
 
-fastify.all('/', function (req, reply) {
-  reply.code(200).send(msg)
-})
+  fastify.all('/', function (req, reply) {
+    reply.code(200).send(msg)
+  })
+  t.after(() => { fastify.close() })
 
-fastify.listen({ port: 0 }, err => {
-  t.error(err)
-  t.teardown(() => { fastify.close() })
+  await fastify.listen({ port: 0 })
 
-  test('http HEAD request', async (t) => {
+  await t.test('http HEAD request', async (t) => {
     t.plan(1)
 
     const url = `http://localhost:${fastify.server.address().port}`
     const res = await h2url.concat({ url, method: 'HEAD' })
 
-    t.equal(res.headers[':status'], 200)
+    t.assert.strictEqual(res.headers[':status'], 200)
   })
 })

package/test/http2/missing-http2-module.test.js

@@ -1,7 +1,6 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const proxyquire = require('proxyquire')
 const server = proxyquire('../../lib/server', { 'node:http2': null })
 const Fastify = proxyquire('../..', { './lib/server.js': server })
@@ -10,9 +9,9 @@ test('should throw when http2 module cannot be found', t => {
   t.plan(2)
   try {
     Fastify({ http2: true })
-    t.fail('fastify did not throw expected error')
+    t.assert.fail('fastify did not throw expected error')
   } catch (err) {
-    t.equal(err.code, 'FST_ERR_HTTP2_INVALID_VERSION')
-    t.equal(err.message, 'HTTP2 is available only from node >= 8.8.1')
+    t.assert.strictEqual(err.code, 'FST_ERR_HTTP2_INVALID_VERSION')
+    t.assert.strictEqual(err.message, 'HTTP2 is available only from node >= 8.8.1')
   }
 })

package/test/http2/plain.test.js

@@ -1,50 +1,50 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const Fastify = require('../..')
 const h2url = require('h2url')
 const msg = { hello: 'world' }
 
-let fastify
-try {
-  fastify = Fastify({
-    http2: true
+test('http2 plain test', async t => {
+  let fastify
+  try {
+    fastify = Fastify({
+      http2: true
+    })
+    t.assert.ok(true, 'http2 successfully loaded')
+  } catch (e) {
+    t.assert.fail('http2 loading failed')
+  }
+
+  fastify.get('/', function (req, reply) {
+    reply.code(200).send(msg)
   })
-  t.pass('http2 successfully loaded')
-} catch (e) {
-  t.fail('http2 loading failed', e)
-}
 
-fastify.get('/', function (req, reply) {
-  reply.code(200).send(msg)
-})
+  fastify.get('/host', function (req, reply) {
+    reply.code(200).send(req.host)
+  })
 
-fastify.get('/host', function (req, reply) {
-  reply.code(200).send(req.host)
-})
+  fastify.get('/hostname_port', function (req, reply) {
+    reply.code(200).send({ hostname: req.hostname, port: req.port })
+  })
 
-fastify.get('/hostname_port', function (req, reply) {
-  reply.code(200).send({ hostname: req.hostname, port: req.port })
-})
+  t.after(() => { fastify.close() })
 
-fastify.listen({ port: 0 }, err => {
-  t.error(err)
-  t.teardown(() => { fastify.close() })
+  await fastify.listen({ port: 0 })
 
-  test('http get request', async (t) => {
+  await t.test('http get request', async (t) => {
     t.plan(3)
 
     const url = `http://localhost:${fastify.server.address().port}`
     const res = await h2url.concat({ url })
 
-    t.equal(res.headers[':status'], 200)
-    t.equal(res.headers['content-length'], '' + JSON.stringify(msg).length)
+    t.assert.strictEqual(res.headers[':status'], 200)
+    t.assert.strictEqual(res.headers['content-length'], '' + JSON.stringify(msg).length)
 
-    t.same(JSON.parse(res.body), msg)
+    t.assert.deepStrictEqual(JSON.parse(res.body), msg)
   })
 
-  test('http host', async (t) => {
+  await t.test('http host', async (t) => {
     t.plan(1)
 
     const host = `localhost:${fastify.server.address().port}`
@@ -52,9 +52,9 @@ fastify.listen({ port: 0 }, err => {
     const url = `http://${host}/host`
     const res = await h2url.concat({ url })
 
-    t.equal(res.body, host)
+    t.assert.strictEqual(res.body, host)
   })
-  test('http hostname and port', async (t) => {
+  await t.test('http hostname and port', async (t) => {
     t.plan(2)
 
     const host = `localhost:${fastify.server.address().port}`
@@ -62,7 +62,7 @@ fastify.listen({ port: 0 }, err => {
     const url = `http://${host}/hostname_port`
     const res = await h2url.concat({ url })
 
-    t.equal(JSON.parse(res.body).hostname, host.split(':')[0])
-    t.equal(JSON.parse(res.body).port, parseInt(host.split(':')[1]))
+    t.assert.strictEqual(JSON.parse(res.body).hostname, host.split(':')[0])
+    t.assert.strictEqual(JSON.parse(res.body).port, parseInt(host.split(':')[1]))
   })
 })

package/test/http2/secure-with-fallback.test.js

@@ -1,17 +1,16 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const Fastify = require('../..')
 const h2url = require('h2url')
 const sget = require('simple-get').concat
 const msg = { hello: 'world' }
 
 const { buildCertificate } = require('../build-certificate')
-t.before(buildCertificate)
+test.before(buildCertificate)
 
-test('secure with fallback', (t) => {
-  t.plan(7)
+test('secure with fallback', async (t) => {
+  t.plan(6)
 
   let fastify
   try {
@@ -23,9 +22,9 @@ test('secure with fallback', (t) => {
         cert: global.context.cert
       }
     })
-    t.pass('Key/cert successfully loaded')
+    t.assert.ok(true, 'Key/cert successfully loaded')
   } catch (e) {
-    t.fail('Key/cert loading failed', e)
+    t.assert.fail('Key/cert loading failed')
   }
 
   fastify.get('/', function (req, reply) {
@@ -40,71 +39,72 @@ test('secure with fallback', (t) => {
     throw new Error('kaboom')
   })
 
-  fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+  t.after(() => { fastify.close() })
 
-    t.test('https get error', async (t) => {
-      t.plan(1)
+  await fastify.listen({ port: 0 })
 
-      const url = `https://localhost:${fastify.server.address().port}/error`
-      const res = await h2url.concat({ url })
+  await t.test('https get error', async (t) => {
+    t.plan(1)
 
-      t.equal(res.headers[':status'], 500)
-    })
+    const url = `https://localhost:${fastify.server.address().port}/error`
+    const res = await h2url.concat({ url })
+
+    t.assert.strictEqual(res.headers[':status'], 500)
+  })
 
-    t.test('https post', async (t) => {
-      t.plan(2)
-
-      const url = `https://localhost:${fastify.server.address().port}`
-      const res = await h2url.concat({
-        url,
-        method: 'POST',
-        body: JSON.stringify({ hello: 'http2' }),
-        headers: {
-          'content-type': 'application/json'
-        }
-      })
-
-      t.equal(res.headers[':status'], 200)
-      t.same(JSON.parse(res.body), { hello: 'http2' })
+  await t.test('https post', async (t) => {
+    t.plan(2)
+
+    const url = `https://localhost:${fastify.server.address().port}`
+    const res = await h2url.concat({
+      url,
+      method: 'POST',
+      body: JSON.stringify({ hello: 'http2' }),
+      headers: {
+        'content-type': 'application/json'
+      }
     })
 
-    t.test('https get request', async (t) => {
-      t.plan(3)
+    t.assert.strictEqual(res.headers[':status'], 200)
+    t.assert.deepStrictEqual(JSON.parse(res.body), { hello: 'http2' })
+  })
 
-      const url = `https://localhost:${fastify.server.address().port}`
-      const res = await h2url.concat({ url })
+  await t.test('https get request', async (t) => {
+    t.plan(3)
 
-      t.equal(res.headers[':status'], 200)
-      t.equal(res.headers['content-length'], '' + JSON.stringify(msg).length)
-      t.same(JSON.parse(res.body), msg)
-    })
+    const url = `https://localhost:${fastify.server.address().port}`
+    const res = await h2url.concat({ url })
 
-    t.test('http1 get request', t => {
-      t.plan(4)
-      sget({
-        method: 'GET',
-        url: 'https://localhost:' + fastify.server.address().port,
-        rejectUnauthorized: false
-      }, (err, response, body) => {
-        t.error(err)
-        t.equal(response.statusCode, 200)
-        t.equal(response.headers['content-length'], '' + body.length)
-        t.same(JSON.parse(body), { hello: 'world' })
-      })
+    t.assert.strictEqual(res.headers[':status'], 200)
+    t.assert.strictEqual(res.headers['content-length'], '' + JSON.stringify(msg).length)
+    t.assert.deepStrictEqual(JSON.parse(res.body), msg)
+  })
+
+  await t.test('http1 get request', (t, done) => {
+    t.plan(4)
+    sget({
+      method: 'GET',
+      url: 'https://localhost:' + fastify.server.address().port,
+      rejectUnauthorized: false
+    }, (err, response, body) => {
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.strictEqual(response.headers['content-length'], '' + body.length)
+      t.assert.deepStrictEqual(JSON.parse(body), { hello: 'world' })
+      done()
     })
+  })
 
-    t.test('http1 get error', (t) => {
-      t.plan(2)
-      sget({
-        method: 'GET',
-        url: 'https://localhost:' + fastify.server.address().port + '/error',
-        rejectUnauthorized: false
-      }, (err, response, body) => {
-        t.error(err)
-        t.equal(response.statusCode, 500)
-      })
+  await t.test('http1 get error', (t, done) => {
+    t.plan(2)
+    sget({
+      method: 'GET',
+      url: 'https://localhost:' + fastify.server.address().port + '/error',
+      rejectUnauthorized: false
+    }, (err, response, body) => {
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 500)
+      done()
     })
   })
 })