eslint 9.26.0 → 9.28.0

package/lib/types/rules.d.ts

@@ -619,7 +619,7 @@ export interface ESLintRules extends Linter.RulesRecord {
 	 * @see https://eslint.org/docs/latest/rules/curly
 	 */
 	curly: Linter.RuleEntry<
-		["all" | "multi" | "multi-line" | "multi-or-nest" | "consistent"]
+		["all"] | ["multi" | "multi-line" | "multi-or-nest", "consistent"?]
 	>;
 
 	/**
@@ -807,6 +807,10 @@ export interface ESLintRules extends Linter.RulesRecord {
 				 * @default false
 				 */
 				allowArrowFunctions: boolean;
+				/**
+				 * @default false
+				 */
+				allowTypeAnnotation: boolean;
 				overrides: {
 					namedExports: "declaration" | "expression" | "ignore";
 				};
@@ -1800,6 +1804,10 @@ export interface ESLintRules extends Linter.RulesRecord {
 					 * @default 3
 					 */
 					max: number;
+					/**
+					 * @default false
+					 */
+					countVoidThis: boolean;
 			  }>
 			| number,
 		]
@@ -2850,6 +2858,22 @@ export interface ESLintRules extends Linter.RulesRecord {
 				 * @default false
 				 */
 				detectObjects: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreEnums: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreNumericLiteralTypes: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreReadonlyClassProperties: boolean;
+				/**
+				 * @default false
+				 */
+				ignoreTypeIndexes: boolean;
 			}>,
 		]
 	>;
@@ -3558,13 +3582,26 @@ export interface ESLintRules extends Linter.RulesRecord {
 				/**
 				 * @default 'functions'
 				 */
-				hoist: "functions" | "all" | "never";
+				hoist:
+					| "functions"
+					| "all"
+					| "never"
+					| "types"
+					| "functions-and-types";
 				allow: string[];
 				/**
 				 * @since 8.10.0
 				 * @default false
 				 */
 				ignoreOnInitialization: boolean;
+				/**
+				 * @default true
+				 */
+				ignoreTypeValueShadow: boolean;
+				/**
+				 * @default true
+				 */
+				ignoreFunctionTypeParameterNameValueShadow: boolean;
 			}>,
 		]
 	>;
@@ -3710,6 +3747,14 @@ export interface ESLintRules extends Linter.RulesRecord {
 		]
 	>;
 
+	/**
+	 * Rule to disallow `let` or `var` variables that are read but never assigned.
+	 *
+	 * @since 9.27.0
+	 * @see https://eslint.org/docs/latest/rules/no-unassigned-vars
+	 */
+	"no-unassigned-vars": Linter.RuleEntry<[]>;
+
 	/**
 	 * Rule to disallow the use of undeclared variables unless mentioned in \/*global *\/ comments.
 	 *
@@ -4045,6 +4090,18 @@ export interface ESLintRules extends Linter.RulesRecord {
 					 * @default false
 					 */
 					allowNamedExports: boolean;
+					/**
+					 * @default true
+					 */
+					enums: boolean;
+					/**
+					 * @default true
+					 */
+					typedefs: boolean;
+					/**
+					 * @default true
+					 */
+					ignoreTypeReferences: boolean;
 			  }>
 			| "nofunc",
 		]
@@ -4130,7 +4187,13 @@ export interface ESLintRules extends Linter.RulesRecord {
 	 * @since 2.5.0
 	 * @see https://eslint.org/docs/latest/rules/no-useless-escape
 	 */
-	"no-useless-escape": Linter.RuleEntry<[]>;
+	"no-useless-escape": Linter.RuleEntry<
+		[
+			Partial<{
+				allowRegexCharacters: string[];
+			}>,
+		]
+	>;
 
 	/**
 	 * Rule to disallow renaming import, export, and destructured assignments to the same name.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "9.26.0",
+  "version": "9.28.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "type": "commonjs",
@@ -108,14 +108,13 @@
     "@eslint-community/regexpp": "^4.12.1",
     "@eslint/config-array": "^0.20.0",
     "@eslint/config-helpers": "^0.2.1",
-    "@eslint/core": "^0.13.0",
+    "@eslint/core": "^0.14.0",
     "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "9.26.0",
-    "@eslint/plugin-kit": "^0.2.8",
+    "@eslint/js": "9.28.0",
+    "@eslint/plugin-kit": "^0.3.1",
     "@humanfs/node": "^0.16.6",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@humanwhocodes/retry": "^0.4.2",
-    "@modelcontextprotocol/sdk": "^1.8.0",
     "@types/estree": "^1.0.6",
     "@types/json-schema": "^7.0.15",
     "ajv": "^6.12.4",
@@ -139,11 +138,10 @@
     "lodash.merge": "^4.6.2",
     "minimatch": "^3.1.2",
     "natural-compare": "^1.4.0",
-    "optionator": "^0.9.3",
-    "zod": "^3.24.2"
+    "optionator": "^0.9.3"
   },
   "devDependencies": {
-    "@arethetypeswrong/cli": "^0.17.0",
+    "@arethetypeswrong/cli": "^0.18.0",
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
     "@cypress/webpack-preprocessor": "^6.0.2",
@@ -172,10 +170,12 @@
     "fast-glob": "^3.2.11",
     "fs-teardown": "^0.1.3",
     "glob": "^10.0.0",
-    "globals": "^15.0.0",
+    "globals": "^16.2.0",
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
-    "jiti": "^2.1.0",
+    "jiti": "^2.2.0",
+    "jiti-v2.0": "npm:jiti@2.0.x",
+    "jiti-v2.1": "npm:jiti@2.1.x",
     "knip": "^5.32.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
@@ -197,7 +197,7 @@
     "recast": "^0.23.0",
     "regenerator-runtime": "^0.14.0",
     "semver": "^7.5.3",
-    "shelljs": "^0.9.0",
+    "shelljs": "^0.10.0",
     "sinon": "^11.0.0",
     "typescript": "^5.3.3",
     "webpack": "^5.23.0",

package/lib/config/flat-config-helpers.js

@@ -1,128 +0,0 @@
-/**
- * @fileoverview Shared functions to work with configs.
- * @author Nicholas C. Zakas
- */
-
-"use strict";
-
-//------------------------------------------------------------------------------
-// Typedefs
-//------------------------------------------------------------------------------
-
-/**
- * @import { RuleDefinition } from "@eslint/core";
- * @import { Linter } from "eslint";
- */
-
-//------------------------------------------------------------------------------
-// Private Members
-//------------------------------------------------------------------------------
-
-// JSON schema that disallows passing any options
-const noOptionsSchema = Object.freeze({
-	type: "array",
-	minItems: 0,
-	maxItems: 0,
-});
-
-//-----------------------------------------------------------------------------
-// Functions
-//-----------------------------------------------------------------------------
-
-/**
- * Parses a ruleId into its plugin and rule parts.
- * @param {string} ruleId The rule ID to parse.
- * @returns {{pluginName:string,ruleName:string}} The plugin and rule
- *      parts of the ruleId;
- */
-function parseRuleId(ruleId) {
-	let pluginName, ruleName;
-
-	// distinguish between core rules and plugin rules
-	if (ruleId.includes("/")) {
-		// mimic scoped npm packages
-		if (ruleId.startsWith("@")) {
-			pluginName = ruleId.slice(0, ruleId.lastIndexOf("/"));
-		} else {
-			pluginName = ruleId.slice(0, ruleId.indexOf("/"));
-		}
-
-		ruleName = ruleId.slice(pluginName.length + 1);
-	} else {
-		pluginName = "@";
-		ruleName = ruleId;
-	}
-
-	return {
-		pluginName,
-		ruleName,
-	};
-}
-
-/**
- * Retrieves a rule instance from a given config based on the ruleId.
- * @param {string} ruleId The rule ID to look for.
- * @param {Linter.Config} config The config to search.
- * @returns {RuleDefinition|undefined} The rule if found
- *      or undefined if not.
- */
-function getRuleFromConfig(ruleId, config) {
-	const { pluginName, ruleName } = parseRuleId(ruleId);
-
-	return config.plugins?.[pluginName]?.rules?.[ruleName];
-}
-
-/**
- * Gets a complete options schema for a rule.
- * @param {RuleDefinition} rule A rule object
- * @throws {TypeError} If `meta.schema` is specified but is not an array, object or `false`.
- * @returns {Object|null} JSON Schema for the rule's options. `null` if `meta.schema` is `false`.
- */
-function getRuleOptionsSchema(rule) {
-	if (!rule.meta) {
-		return { ...noOptionsSchema }; // default if `meta.schema` is not specified
-	}
-
-	const schema = rule.meta.schema;
-
-	if (typeof schema === "undefined") {
-		return { ...noOptionsSchema }; // default if `meta.schema` is not specified
-	}
-
-	// `schema:false` is an allowed explicit opt-out of options validation for the rule
-	if (schema === false) {
-		return null;
-	}
-
-	if (typeof schema !== "object" || schema === null) {
-		throw new TypeError("Rule's `meta.schema` must be an array or object");
-	}
-
-	// ESLint-specific array form needs to be converted into a valid JSON Schema definition
-	if (Array.isArray(schema)) {
-		if (schema.length) {
-			return {
-				type: "array",
-				items: schema,
-				minItems: 0,
-				maxItems: schema.length,
-			};
-		}
-
-		// `schema:[]` is an explicit way to specify that the rule does not accept any options
-		return { ...noOptionsSchema };
-	}
-
-	// `schema:<object>` is assumed to be a valid JSON Schema definition
-	return schema;
-}
-
-//-----------------------------------------------------------------------------
-// Exports
-//-----------------------------------------------------------------------------
-
-module.exports = {
-	parseRuleId,
-	getRuleFromConfig,
-	getRuleOptionsSchema,
-};

package/lib/config/rule-validator.js

@@ -1,199 +0,0 @@
-/**
- * @fileoverview Rule Validator
- * @author Nicholas C. Zakas
- */
-
-"use strict";
-
-//-----------------------------------------------------------------------------
-// Requirements
-//-----------------------------------------------------------------------------
-
-const ajvImport = require("../shared/ajv");
-const ajv = ajvImport();
-const {
-	parseRuleId,
-	getRuleFromConfig,
-	getRuleOptionsSchema,
-} = require("./flat-config-helpers");
-const ruleReplacements = require("../../conf/replacements.json");
-
-//-----------------------------------------------------------------------------
-// Helpers
-//-----------------------------------------------------------------------------
-
-/**
- * Throws a helpful error when a rule cannot be found.
- * @param {Object} ruleId The rule identifier.
- * @param {string} ruleId.pluginName The ID of the rule to find.
- * @param {string} ruleId.ruleName The ID of the rule to find.
- * @param {Object} config The config to search in.
- * @throws {TypeError} For missing plugin or rule.
- * @returns {void}
- */
-function throwRuleNotFoundError({ pluginName, ruleName }, config) {
-	const ruleId = pluginName === "@" ? ruleName : `${pluginName}/${ruleName}`;
-
-	const errorMessageHeader = `Key "rules": Key "${ruleId}"`;
-
-	let errorMessage = `${errorMessageHeader}: Could not find plugin "${pluginName}" in configuration.`;
-
-	const missingPluginErrorMessage = errorMessage;
-
-	// if the plugin exists then we need to check if the rule exists
-	if (config.plugins && config.plugins[pluginName]) {
-		const replacementRuleName = ruleReplacements.rules[ruleName];
-
-		if (pluginName === "@" && replacementRuleName) {
-			errorMessage = `${errorMessageHeader}: Rule "${ruleName}" was removed and replaced by "${replacementRuleName}".`;
-		} else {
-			errorMessage = `${errorMessageHeader}: Could not find "${ruleName}" in plugin "${pluginName}".`;
-
-			// otherwise, let's see if we can find the rule name elsewhere
-			for (const [otherPluginName, otherPlugin] of Object.entries(
-				config.plugins,
-			)) {
-				if (otherPlugin.rules && otherPlugin.rules[ruleName]) {
-					errorMessage += ` Did you mean "${otherPluginName}/${ruleName}"?`;
-					break;
-				}
-			}
-		}
-
-		// falls through to throw error
-	}
-
-	const error = new TypeError(errorMessage);
-
-	if (errorMessage === missingPluginErrorMessage) {
-		error.messageTemplate = "config-plugin-missing";
-		error.messageData = { pluginName, ruleId };
-	}
-
-	throw error;
-}
-
-/**
- * The error type when a rule has an invalid `meta.schema`.
- */
-class InvalidRuleOptionsSchemaError extends Error {
-	/**
-	 * Creates a new instance.
-	 * @param {string} ruleId Id of the rule that has an invalid `meta.schema`.
-	 * @param {Error} processingError Error caught while processing the `meta.schema`.
-	 */
-	constructor(ruleId, processingError) {
-		super(
-			`Error while processing options validation schema of rule '${ruleId}': ${processingError.message}`,
-			{ cause: processingError },
-		);
-		this.code = "ESLINT_INVALID_RULE_OPTIONS_SCHEMA";
-	}
-}
-
-//-----------------------------------------------------------------------------
-// Exports
-//-----------------------------------------------------------------------------
-
-/**
- * Implements validation functionality for the rules portion of a config.
- */
-class RuleValidator {
-	/**
-	 * Creates a new instance.
-	 */
-	constructor() {
-		/**
-		 * A collection of compiled validators for rules that have already
-		 * been validated.
-		 * @type {WeakMap}
-		 */
-		this.validators = new WeakMap();
-	}
-
-	/**
-	 * Validates all of the rule configurations in a config against each
-	 * rule's schema.
-	 * @param {Object} config The full config to validate. This object must
-	 *      contain both the rules section and the plugins section.
-	 * @returns {void}
-	 * @throws {Error} If a rule's configuration does not match its schema.
-	 */
-	validate(config) {
-		if (!config.rules) {
-			return;
-		}
-
-		for (const [ruleId, ruleOptions] of Object.entries(config.rules)) {
-			// check for edge case
-			if (ruleId === "__proto__") {
-				continue;
-			}
-
-			/*
-			 * If a rule is disabled, we don't do any validation. This allows
-			 * users to safely set any value to 0 or "off" without worrying
-			 * that it will cause a validation error.
-			 *
-			 * Note: ruleOptions is always an array at this point because
-			 * this validation occurs after FlatConfigArray has merged and
-			 * normalized values.
-			 */
-			if (ruleOptions[0] === 0) {
-				continue;
-			}
-
-			const rule = getRuleFromConfig(ruleId, config);
-
-			if (!rule) {
-				throwRuleNotFoundError(parseRuleId(ruleId), config);
-			}
-
-			// Precompile and cache validator the first time
-			if (!this.validators.has(rule)) {
-				try {
-					const schema = getRuleOptionsSchema(rule);
-
-					if (schema) {
-						this.validators.set(rule, ajv.compile(schema));
-					}
-				} catch (err) {
-					throw new InvalidRuleOptionsSchemaError(ruleId, err);
-				}
-			}
-
-			const validateRule = this.validators.get(rule);
-
-			if (validateRule) {
-				validateRule(ruleOptions.slice(1));
-
-				if (validateRule.errors) {
-					throw new Error(
-						`Key "rules": Key "${ruleId}":\n${validateRule.errors
-							.map(error => {
-								if (
-									error.keyword === "additionalProperties" &&
-									error.schema === false &&
-									typeof error.parentSchema?.properties ===
-										"object" &&
-									typeof error.params?.additionalProperty ===
-										"string"
-								) {
-									const expectedProperties = Object.keys(
-										error.parentSchema.properties,
-									).map(property => `"${property}"`);
-
-									return `\tValue ${JSON.stringify(error.data)} ${error.message}.\n\t\tUnexpected property "${error.params.additionalProperty}". Expected properties: ${expectedProperties.join(", ")}.\n`;
-								}
-
-								return `\tValue ${JSON.stringify(error.data)} ${error.message}.\n`;
-							})
-							.join("")}`,
-					);
-				}
-			}
-		}
-	}
-}
-
-exports.RuleValidator = RuleValidator;

package/lib/mcp/mcp-server.js

@@ -1,66 +0,0 @@
-/**
- * @fileoverview MCP Server for handling requests and responses to ESLint.
- * @author Nicholas C. Zakas
- */
-
-"use strict";
-
-//-----------------------------------------------------------------------------
-// Requirements
-//-----------------------------------------------------------------------------
-
-const { McpServer } = require("@modelcontextprotocol/sdk/server/mcp.js");
-const { z } = require("zod");
-const { ESLint } = require("../eslint");
-const pkg = require("../../package.json");
-
-//-----------------------------------------------------------------------------
-// Server
-//-----------------------------------------------------------------------------
-
-const mcpServer = new McpServer({
-	name: "ESLint",
-	version: pkg.version,
-});
-
-// Important: Cursor throws an error when `describe()` is used in the schema.
-const filePathsSchema = {
-	filePaths: z.array(z.string().min(1)).nonempty(),
-};
-
-//-----------------------------------------------------------------------------
-// Tools
-//-----------------------------------------------------------------------------
-
-mcpServer.tool(
-	"lint-files",
-	"Lint files using ESLint. You must provide a list of absolute file paths to the files you want to lint. The absolute file paths should be in the correct format for your operating system (e.g., forward slashes on Unix-like systems, backslashes on Windows).",
-	filePathsSchema,
-	async ({ filePaths }) => {
-		const eslint = new ESLint({
-			// enable lookup from file rather than from cwd
-			flags: ["unstable_config_lookup_from_file"],
-		});
-
-		const results = await eslint.lintFiles(filePaths);
-		const content = results.map(result => ({
-			type: "text",
-			text: JSON.stringify(result),
-		}));
-
-		content.unshift({
-			type: "text",
-			text: "Here are the results of running ESLint on the provided files:",
-		});
-		content.push({
-			type: "text",
-			text: "Do not automatically fix these issues. You must ask the user for confirmation before attempting to fix the issues found.",
-		});
-
-		return {
-			content,
-		};
-	},
-);
-
-module.exports = { mcpServer };