eslint 9.26.0 → 9.28.0

package/README.md

@@ -286,6 +286,11 @@ Josh Goldberg ✨
 <img src="https://github.com/Tanujkanti4441.png?s=75" width="75" height="75" alt="Tanuj Kanti's Avatar"><br />
 Tanuj Kanti
 </a>
+</td><td align="center" valign="top" width="11%">
+<a href="https://github.com/lumirlumir">
+<img src="https://github.com/lumirlumir.png?s=75" width="75" height="75" alt="루밀LuMir's Avatar"><br />
+루밀LuMir
+</a>
 </td></tr></tbody></table>
 
 ### Website Team
@@ -320,11 +325,11 @@ The following companies, organizations, and individuals support ESLint's ongoing
 to get your logo on our READMEs and [website](https://eslint.org/sponsors).
 
 <h3>Diamond Sponsors</h3>
-<p><a href="https://www.ag-grid.com/"><img src="https://images.opencollective.com/ag-grid/2c8d545/logo.png" alt="AG Grid" height="128"></a></p><h3>Platinum Sponsors</h3>
+<p><a href="https://www.ag-grid.com/"><img src="https://images.opencollective.com/ag-grid/bec0580/logo.png" alt="AG Grid" height="128"></a></p><h3>Platinum Sponsors</h3>
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a> <a href="https://www.airbnb.com/"><img src="https://images.opencollective.com/airbnb/d327d66/logo.png" alt="Airbnb" height="128"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://qlty.sh/"><img src="https://images.opencollective.com/qltysh/33d157d/logo.png" alt="Qlty Software" height="96"></a> <a href="https://trunk.io/"><img src="https://images.opencollective.com/trunkio/fb92d60/avatar.png" alt="trunk.io" height="96"></a> <a href="https://shopify.engineering/"><img src="https://avatars.githubusercontent.com/u/8085" alt="Shopify" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/e6d15e1/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/5c4fa84/logo.png" alt="Liftoff" height="64"></a> <a href="https://americanexpress.io"><img src="https://avatars.githubusercontent.com/u/3853301" alt="American Express" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nolebase.ayaka.io"><img src="https://avatars.githubusercontent.com/u/11081491" alt="Neko" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
+<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://www.crosswordsolver.org/anagram-solver/"><img src="https://images.opencollective.com/anagram-solver/2666271/logo.png" alt="Anagram Solver" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://nolebase.ayaka.io"><img src="https://avatars.githubusercontent.com/u/11081491" alt="Neko" height="32"></a> <a href="https://nx.dev"><img src="https://avatars.githubusercontent.com/u/23692104" alt="Nx" height="32"></a> <a href="https://opensource.mercedes-benz.com/"><img src="https://avatars.githubusercontent.com/u/34240465" alt="Mercedes-Benz Group" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="LambdaTest" height="32"></a></p>
 <h3>Technology Sponsors</h3>
 Technology sponsors allow us to use their products and services for free as part of a contribution to the open source ecosystem and our work.
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>

package/bin/eslint.js

@@ -157,19 +157,15 @@ ${getErrorMessage(error)}`;
 
 	// start the MCP server if `--mcp` is present
 	if (process.argv.includes("--mcp")) {
-		const { mcpServer } = require("../lib/mcp/mcp-server");
-		const {
-			StdioServerTransport,
-		} = require("@modelcontextprotocol/sdk/server/stdio.js");
-
-		await mcpServer.connect(new StdioServerTransport());
+		console.warn(
+			"You can also run this command directly using 'npx @eslint/mcp@latest'.",
+		);
 
-		// Note: do not use console.log() because stdout is part of the server transport
-		console.error(`ESLint MCP server is running. cwd: ${process.cwd()}`);
+		const spawn = require("cross-spawn");
 
-		process.on("SIGINT", () => {
-			mcpServer.close();
-			process.exitCode = 0;
+		spawn.sync("npx", ["@eslint/mcp@latest"], {
+			encoding: "utf8",
+			stdio: "inherit",
 		});
 		return;
 	}

package/conf/rule-type-list.json

@@ -69,7 +69,8 @@
       "removed": "space-in-brackets",
       "replacedBy": [
         { "rule": { "name": "object-curly-spacing" } },
-        { "rule": { "name": "array-bracket-spacing" } }
+        { "rule": { "name": "array-bracket-spacing" } },
+        { "rule": { "name": "computed-property-spacing" } }
       ]
     },
     {

package/lib/cli-engine/cli-engine.js

@@ -58,15 +58,15 @@ const validFixTypes = new Set(["directive", "problem", "suggestion", "layout"]);
 //------------------------------------------------------------------------------
 
 // For VSCode IntelliSense
-/** @typedef {import("../shared/types").ConfigData} ConfigData */
-/** @typedef {import("../shared/types").DeprecatedRuleInfo} DeprecatedRuleInfo */
-/** @typedef {import("../shared/types").LintMessage} LintMessage */
-/** @typedef {import("../shared/types").SuppressedLintMessage} SuppressedLintMessage */
-/** @typedef {import("../shared/types").ParserOptions} ParserOptions */
-/** @typedef {import("../shared/types").RuleConf} RuleConf */
-/** @typedef {import("../types").Rule.RuleModule} Rule */
+/** @typedef {import("../types").ESLint.ConfigData} ConfigData */
+/** @typedef {import("../types").ESLint.DeprecatedRuleUse} DeprecatedRuleInfo */
 /** @typedef {import("../types").ESLint.FormatterFunction} FormatterFunction */
+/** @typedef {import("../types").Linter.LintMessage} LintMessage */
+/** @typedef {import("../types").Linter.ParserOptions} ParserOptions */
 /** @typedef {import("../types").ESLint.Plugin} Plugin */
+/** @typedef {import("../types").Rule.RuleModule} Rule */
+/** @typedef {import("../types").Linter.RuleEntry} RuleConf */
+/** @typedef {import("../types").Linter.SuppressedLintMessage} SuppressedLintMessage */
 /** @typedef {ReturnType<CascadingConfigArrayFactory.getConfigArrayForFile>} ConfigArray */
 /** @typedef {ReturnType<ConfigArray.extractConfig>} ExtractedConfig */
 

package/lib/cli.js

@@ -40,12 +40,13 @@ const debug = require("debug")("eslint:cli");
 // Types
 //------------------------------------------------------------------------------
 
-/** @typedef {import("./eslint/eslint").ESLintOptions} ESLintOptions */
-/** @typedef {import("./eslint/eslint").LintMessage} LintMessage */
-/** @typedef {import("./eslint/eslint").LintResult} LintResult */
+/** @import { ESLintOptions } from "./eslint/eslint.js" */
+
 /** @typedef {import("./options").ParsedCLIOptions} ParsedCLIOptions */
-/** @typedef {import("./shared/types").ResultsMeta} ResultsMeta */
+/** @typedef {import("./types").Linter.LintMessage} LintMessage */
+/** @typedef {import("./types").ESLint.LintResult} LintResult */
 /** @typedef {import("./types").ESLint.Plugin} Plugin */
+/** @typedef {import("./types").ESLint.ResultsMeta} ResultsMeta */
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -438,10 +439,8 @@ const cli = {
 		debug("Using flat config?", usingFlatConfig);
 
 		if (allowFlatConfig && !usingFlatConfig) {
-			process.emitWarning(
-				"You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.",
-				"ESLintRCWarning",
-			);
+			const { WarningService } = require("./services/warning-service");
+			new WarningService().emitESLintRCWarning();
 		}
 
 		const CLIOptions = createCLIOptions(usingFlatConfig);
@@ -735,17 +734,21 @@ const cli = {
 				);
 			}
 
-			const unusedSuppressionsCount =
-				Object.keys(unusedSuppressions).length;
+			if (!options.passOnUnprunedSuppressions) {
+				const unusedSuppressionsCount =
+					Object.keys(unusedSuppressions).length;
 
-			if (unusedSuppressionsCount > 0) {
-				log.error(
-					"There are suppressions left that do not occur anymore. Consider re-running the command with `--prune-suppressions`.",
-				);
-				debug(JSON.stringify(unusedSuppressions, null, 2));
+				if (unusedSuppressionsCount > 0) {
+					log.error(
+						"There are suppressions left that do not occur anymore. Consider re-running the command with `--prune-suppressions`.",
+					);
+					debug(JSON.stringify(unusedSuppressions, null, 2));
+
+					return 2;
+				}
 			}
 
-			if (shouldExitForFatalErrors || unusedSuppressionsCount > 0) {
+			if (shouldExitForFatalErrors) {
 				return 2;
 			}
 

package/lib/config/config-loader.js

@@ -15,25 +15,25 @@ const findUp = require("find-up");
 const { pathToFileURL } = require("node:url");
 const debug = require("debug")("eslint:config-loader");
 const { FlatConfigArray } = require("./flat-config-array");
+const { WarningService } = require("../services/warning-service");
 
 //-----------------------------------------------------------------------------
 // Types
 //-----------------------------------------------------------------------------
 
-/**
- * @import { ConfigData, ConfigData as FlatConfigObject } from "../shared/types.js";
- */
+/** @typedef {import("../types").Linter.Config} Config */
 
 /**
  * @typedef {Object} ConfigLoaderOptions
  * @property {string|false|undefined} configFile The path to the config file to use.
  * @property {string} cwd The current working directory.
  * @property {boolean} ignoreEnabled Indicates if ignore patterns should be honored.
- * @property {FlatConfigArray} [baseConfig] The base config to use.
- * @property {Array<FlatConfigObject>} [defaultConfigs] The default configs to use.
+ * @property {Config|Array<Config>} [baseConfig] The base config to use.
+ * @property {Array<Config>} [defaultConfigs] The default configs to use.
  * @property {Array<string>} [ignorePatterns] The ignore patterns to use.
- * @property {FlatConfigObject|Array<FlatConfigObject>} [overrideConfig] The override config to use.
+ * @property {Config|Array<Config>} [overrideConfig] The override config to use.
  * @property {boolean} [hasUnstableNativeNodeJsTSConfigFlag] The flag to indicate whether the `unstable_native_nodejs_ts_config` flag is enabled.
+ * @property {WarningService} [warningService] The warning service to use.
  */
 
 //------------------------------------------------------------------------------
@@ -139,12 +139,13 @@ function isNativeTypeScriptSupportEnabled() {
  * @since 9.24.0
  */
 async function loadTypeScriptConfigFileWithJiti(filePath, fileURL, mtime) {
-	// eslint-disable-next-line no-use-before-define -- `ConfigLoader.loadJiti` can be overwritten for testing
-	const { createJiti } = await ConfigLoader.loadJiti().catch(() => {
-		throw new Error(
-			"The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it.",
-		);
-	});
+	const { createJiti, version: jitiVersion } =
+		// eslint-disable-next-line no-use-before-define -- `ConfigLoader.loadJiti` can be overwritten for testing
+		await ConfigLoader.loadJiti().catch(() => {
+			throw new Error(
+				"The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it.",
+			);
+		});
 
 	// `createJiti` was added in jiti v2.
 	if (typeof createJiti !== "function") {
@@ -157,11 +158,15 @@ async function loadTypeScriptConfigFileWithJiti(filePath, fileURL, mtime) {
 	 * Disabling `moduleCache` allows us to reload a
 	 * config file when the last modified timestamp changes.
 	 */
-
-	const jiti = createJiti(__filename, {
+	const jitiOptions = {
 		moduleCache: false,
-		interopDefault: false,
-	});
+	};
+
+	if (jitiVersion.startsWith("2.1.")) {
+		jitiOptions.interopDefault = false;
+	}
+
+	const jiti = createJiti(__filename, jitiOptions);
 	const config = await jiti.import(fileURL.href);
 
 	importedConfigFileModificationTime.set(filePath, mtime);
@@ -303,7 +308,9 @@ class ConfigLoader {
 	 * @param {ConfigLoaderOptions} options The options to use when loading configuration files.
 	 */
 	constructor(options) {
-		this.#options = options;
+		this.#options = options.warningService
+			? options
+			: { ...options, warningService: new WarningService() };
 	}
 
 	/**
@@ -394,8 +401,7 @@ class ConfigLoader {
 	 * This is the same logic used by the ESLint CLI executable to determine
 	 * configuration for each file it processes.
 	 * @param {string} filePath The path of the file or directory to retrieve config for.
-	 * @returns {Promise<ConfigData|undefined>} A configuration object for the file
-	 *      or `undefined` if there is no configuration data for the file.
+	 * @returns {Promise<FlatConfigArray>} A configuration object for the file.
 	 * @throws {Error} If no configuration for `filePath` exists.
 	 */
 	async loadConfigArrayForFile(filePath) {
@@ -415,8 +421,7 @@ class ConfigLoader {
 	 * This is the same logic used by the ESLint CLI executable to determine
 	 * configuration for each file it processes.
 	 * @param {string} dirPath The path of the directory to retrieve config for.
-	 * @returns {Promise<ConfigData|undefined>} A configuration object for the directory
-	 *      or `undefined` if there is no configuration data for the directory.
+	 * @returns {Promise<FlatConfigArray>} A configuration object for the directory.
 	 */
 	async loadConfigArrayForDirectory(dirPath) {
 		assertValidFilePath(dirPath);
@@ -440,8 +445,7 @@ class ConfigLoader {
 	 * intended to be used in locations where we know the config file has already
 	 * been loaded and we just need to get the configuration for a file.
 	 * @param {string} filePath The path of the file to retrieve a config object for.
-	 * @returns {ConfigData|undefined} A configuration object for the file
-	 *     or `undefined` if there is no configuration data for the file.
+	 * @returns {FlatConfigArray} A configuration object for the file.
 	 * @throws {Error} If `filePath` is not a non-empty string.
 	 * @throws {Error} If `filePath` is not an absolute path.
 	 * @throws {Error} If the config file was not already loaded.
@@ -460,8 +464,7 @@ class ConfigLoader {
 	 * intended to be used in locations where we know the config file has already
 	 * been loaded and we just need to get the configuration for a file.
 	 * @param {string} fileOrDirPath The path of the directory to retrieve a config object for.
-	 * @returns {ConfigData|undefined} A configuration object for the directory
-	 *     or `undefined` if there is no configuration data for the directory.
+	 * @returns {FlatConfigArray} A configuration object for the directory.
 	 * @throws {Error} If `dirPath` is not a non-empty string.
 	 * @throws {Error} If `dirPath` is not an absolute path.
 	 * @throws {Error} If the config file was not already loaded.
@@ -500,11 +503,12 @@ class ConfigLoader {
 
 	/**
 	 * Used to import the jiti dependency. This method is exposed internally for testing purposes.
-	 * @returns {Promise<Record<string, unknown>>} A promise that fulfills with a module object
-	 *      or rejects with an error if jiti is not found.
+	 * @returns {Promise<{createJiti: Function|undefined, version: string;}>} A promise that fulfills with an object containing the jiti module's createJiti function and version.
 	 */
-	static loadJiti() {
-		return import("jiti");
+	static async loadJiti() {
+		const { createJiti } = await import("jiti");
+		const version = require("jiti/package.json").version;
+		return { createJiti, version };
 	}
 
 	/**
@@ -567,6 +571,7 @@ class ConfigLoader {
 			overrideConfig,
 			hasUnstableNativeNodeJsTSConfigFlag = false,
 			defaultConfigs = [],
+			warningService,
 		} = options;
 
 		debug(
@@ -628,10 +633,7 @@ class ConfigLoader {
 			}
 
 			if (emptyConfig) {
-				globalThis.process?.emitWarning?.(
-					`Running ESLint with an empty config (from ${configFilePath}). Please double-check that this is what you want. If you want to run ESLint with an empty config, export [{}] to remove this warning.`,
-					"ESLintEmptyConfigWarning",
-				);
+				warningService.emitEmptyConfigWarning(configFilePath);
 			}
 		}
 
@@ -719,8 +721,11 @@ class LegacyConfigLoader extends ConfigLoader {
 	 * @param {ConfigLoaderOptions} options The options to use when loading configuration files.
 	 */
 	constructor(options) {
-		super(options);
-		this.#options = options;
+		const normalizedOptions = options.warningService
+			? options
+			: { ...options, warningService: new WarningService() };
+		super(normalizedOptions);
+		this.#options = normalizedOptions;
 	}
 
 	/**
@@ -789,8 +794,7 @@ class LegacyConfigLoader extends ConfigLoader {
 	 * This is the same logic used by the ESLint CLI executable to determine
 	 * configuration for each file it processes.
 	 * @param {string} dirPath The path of the directory to retrieve config for.
-	 * @returns {Promise<ConfigData|undefined>} A configuration object for the file
-	 *      or `undefined` if there is no configuration data for the file.
+	 * @returns {Promise<FlatConfigArray>} A configuration object for the file.
 	 */
 	async loadConfigArrayForDirectory(dirPath) {
 		assertValidFilePath(dirPath);
@@ -812,8 +816,7 @@ class LegacyConfigLoader extends ConfigLoader {
 	 * intended to be used in locations where we know the config file has already
 	 * been loaded and we just need to get the configuration for a file.
 	 * @param {string} dirPath The path of the directory to retrieve a config object for.
-	 * @returns {ConfigData|undefined} A configuration object for the file
-	 *     or `undefined` if there is no configuration data for the file.
+	 * @returns {FlatConfigArray} A configuration object for the file.
 	 * @throws {Error} If `dirPath` is not a non-empty string.
 	 * @throws {Error} If `dirPath` is not an absolute path.
 	 * @throws {Error} If the config file was not already loaded.