eslint 9.23.0 → 9.25.0

package/lib/rules/for-direction.js

@@ -15,7 +15,7 @@ const { getStaticValue } = require("@eslint-community/eslint-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "problem",
@@ -54,8 +54,8 @@ module.exports = {
 		/**
 		 * check the right side of the assignment
 		 * @param {ASTNode} update UpdateExpression to check
-		 * @param {int} dir expected direction that could either be turned around or invalidated
-		 * @returns {int} return dir, the negated dir, or zero if the counter does not change or the direction is not clear
+		 * @param {number} dir expected direction that could either be turned around or invalidated
+		 * @returns {number} return dir, the negated dir, or zero if the counter does not change or the direction is not clear
 		 */
 		function getRightDirection(update, dir) {
 			const staticValue = getStaticValue(
@@ -80,7 +80,7 @@ module.exports = {
 		 * check UpdateExpression add/sub the counter
 		 * @param {ASTNode} update UpdateExpression to check
 		 * @param {string} counter variable name to check
-		 * @returns {int} if add return 1, if sub return -1, if nochange, return 0
+		 * @returns {number} if add return 1, if sub return -1, if nochange, return 0
 		 */
 		function getUpdateDirection(update, counter) {
 			if (
@@ -101,7 +101,7 @@ module.exports = {
 		 * check AssignmentExpression add/sub the counter
 		 * @param {ASTNode} update AssignmentExpression to check
 		 * @param {string} counter variable name to check
-		 * @returns {int} if add return 1, if sub return -1, if nochange, return 0
+		 * @returns {number} if add return 1, if sub return -1, if nochange, return 0
 		 */
 		function getAssignmentDirection(update, counter) {
 			if (update.left.name === counter) {

package/lib/rules/func-call-spacing.js

@@ -16,7 +16,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/func-name-matching.js

@@ -49,7 +49,7 @@ function isModuleExports(pattern) {
 /**
  * Determines if a string name is a valid identifier
  * @param {string} name The string to be checked
- * @param {int} ecmaVersion The ECMAScript version if specified in the parserOptions config
+ * @param {number} ecmaVersion The ECMAScript version if specified in the parserOptions config
  * @returns {boolean} True if the string is a valid identifier
  */
 function isIdentifier(name, ecmaVersion) {
@@ -77,7 +77,7 @@ const optionsObject = {
 	additionalProperties: false,
 };
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/func-names.js

@@ -24,7 +24,7 @@ function isFunctionName(variable) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/func-style.js

@@ -8,7 +8,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/function-call-argument-newline.js

@@ -10,7 +10,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/function-paren-newline.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/generator-star-spacing.js

@@ -26,7 +26,7 @@ const OVERRIDE_SCHEMA = {
 	],
 };
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/getter-return.js

@@ -36,7 +36,7 @@ function isAnySegmentReachable(segments) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "problem",

package/lib/rules/global-require.js

@@ -53,7 +53,7 @@ function isShadowed(scope, node) {
 	);
 }
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/grouped-accessor-pairs.js

@@ -91,7 +91,7 @@ function isAccessorKind(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/guard-for-in.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/handle-callback-err.js

@@ -10,7 +10,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/id-blacklist.js

@@ -94,7 +94,7 @@ function isShorthandPropertyDefinition(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/id-denylist.js

@@ -83,7 +83,7 @@ function isPropertyNameInDestructuring(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/id-length.js

@@ -20,7 +20,7 @@ const {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/id-match.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/implicit-arrow-linebreak.js

@@ -10,7 +10,7 @@ const { isCommentToken, isNotOpeningParenToken } = require("./utils/ast-utils");
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/indent-legacy.js

@@ -20,7 +20,7 @@ const astUtils = require("./utils/ast-utils");
 //------------------------------------------------------------------------------
 // this rule has known coverage issues, but it's deprecated and shouldn't be updated in the future anyway.
 /* c8 ignore next */
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "layout",
@@ -302,9 +302,9 @@ module.exports = {
 
 		/**
 		 * Creates an error message for a line, given the expected/actual indentation.
-		 * @param {int} expectedAmount The expected amount of indentation characters for this line
-		 * @param {int} actualSpaces The actual number of indentation spaces that were found on this line
-		 * @param {int} actualTabs The actual number of indentation tabs that were found on this line
+		 * @param {number} expectedAmount The expected amount of indentation characters for this line
+		 * @param {number} actualSpaces The actual number of indentation spaces that were found on this line
+		 * @param {number} actualTabs The actual number of indentation tabs that were found on this line
 		 * @returns {string} An error message for this line
 		 */
 		function createErrorMessageData(
@@ -345,9 +345,9 @@ module.exports = {
 		/**
 		 * Reports a given indent violation
 		 * @param {ASTNode} node Node violating the indent rule
-		 * @param {int} needed Expected indentation character count
-		 * @param {int} gottenSpaces Indentation space count in the actual node/code
-		 * @param {int} gottenTabs Indentation tab count in the actual node/code
+		 * @param {number} needed Expected indentation character count
+		 * @param {number} gottenSpaces Indentation space count in the actual node/code
+		 * @param {number} gottenTabs Indentation tab count in the actual node/code
 		 * @param {Object} [loc] Error line and column location
 		 * @param {boolean} isLastNodeCheck Is the error for last node check
 		 * @returns {void}
@@ -449,7 +449,7 @@ module.exports = {
 		/**
 		 * Check indent for node
 		 * @param {ASTNode} node Node to check
-		 * @param {int} neededIndent needed indent
+		 * @param {number} neededIndent needed indent
 		 * @returns {void}
 		 */
 		function checkNodeIndent(node, neededIndent) {
@@ -502,7 +502,7 @@ module.exports = {
 		/**
 		 * Check indent for nodes list
 		 * @param {ASTNode[]} nodes list of node objects
-		 * @param {int} indent needed indent
+		 * @param {number} indent needed indent
 		 * @returns {void}
 		 */
 		function checkNodesIndent(nodes, indent) {
@@ -512,7 +512,7 @@ module.exports = {
 		/**
 		 * Check last node line indent this detects, that block closed correctly
 		 * @param {ASTNode} node Node to examine
-		 * @param {int} lastLineIndent needed indent
+		 * @param {number} lastLineIndent needed indent
 		 * @returns {void}
 		 */
 		function checkLastNodeLineIndent(node, lastLineIndent) {
@@ -542,7 +542,7 @@ module.exports = {
 		 * Check last node line indent this detects, that block closed correctly
 		 * This function for more complicated return statement case, where closing parenthesis may be followed by ';'
 		 * @param {ASTNode} node Node to examine
-		 * @param {int} firstLineIndent first line needed indent
+		 * @param {number} firstLineIndent first line needed indent
 		 * @returns {void}
 		 */
 		function checkLastReturnStatementLineIndent(node, firstLineIndent) {
@@ -583,7 +583,7 @@ module.exports = {
 		/**
 		 * Check first node line indent is correct
 		 * @param {ASTNode} node Node to examine
-		 * @param {int} firstLineIndent needed indent
+		 * @param {number} firstLineIndent needed indent
 		 * @returns {void}
 		 */
 		function checkFirstNodeLineIndent(node, firstLineIndent) {
@@ -1130,8 +1130,8 @@ module.exports = {
 		/**
 		 * Returns the expected indentation for the case statement
 		 * @param {ASTNode} node node to examine
-		 * @param {int} [providedSwitchIndent] indent for switch statement
-		 * @returns {int} indent size
+		 * @param {number} [providedSwitchIndent] indent for switch statement
+		 * @returns {number} indent size
 		 */
 		function expectedCaseIndent(node, providedSwitchIndent) {
 			const switchNode =

package/lib/rules/indent.js

@@ -505,7 +505,7 @@ const ELEMENT_LIST_SCHEMA = {
 	],
 };
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {
@@ -743,9 +743,9 @@ module.exports = {
 
 		/**
 		 * Creates an error message for a line, given the expected/actual indentation.
-		 * @param {int} expectedAmount The expected amount of indentation characters for this line
-		 * @param {int} actualSpaces The actual number of indentation spaces that were found on this line
-		 * @param {int} actualTabs The actual number of indentation tabs that were found on this line
+		 * @param {number} expectedAmount The expected amount of indentation characters for this line
+		 * @param {number} actualSpaces The actual number of indentation spaces that were found on this line
+		 * @param {number} actualTabs The actual number of indentation tabs that were found on this line
 		 * @returns {string} An error message for this line
 		 */
 		function createErrorMessageData(

package/lib/rules/init-declarations.js

@@ -44,10 +44,12 @@ function isInitialized(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",
+		dialects: ["typescript", "javascript"],
+		language: "javascript",
 
 		docs: {
 			description:
@@ -105,15 +107,34 @@ module.exports = {
 		const mode = context.options[0] || MODE_ALWAYS;
 		const params = context.options[1] || {};
 
+		// Track whether we're inside a declared namespace
+		let insideDeclaredNamespace = false;
+
 		//--------------------------------------------------------------------------
 		// Public API
 		//--------------------------------------------------------------------------
 
 		return {
+			TSModuleDeclaration(node) {
+				if (node.declare) {
+					insideDeclaredNamespace = true;
+				}
+			},
+
+			"TSModuleDeclaration:exit"(node) {
+				if (node.declare) {
+					insideDeclaredNamespace = false;
+				}
+			},
+
 			"VariableDeclaration:exit"(node) {
 				const kind = node.kind,
 					declarations = node.declarations;
 
+				if (node.declare || insideDeclaredNamespace) {
+					return;
+				}
+
 				for (let i = 0; i < declarations.length; ++i) {
 					const declaration = declarations[i],
 						id = declaration.id,

package/lib/rules/jsx-quotes.js

@@ -37,7 +37,7 @@ const QUOTE_SETTINGS = {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/key-spacing.js

@@ -144,7 +144,7 @@ function initOptions(toOptions, fromOptions) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {
@@ -489,7 +489,7 @@ module.exports = {
 		 * @param {ASTNode} property Key-value pair in an object literal.
 		 * @param {string} side Side being verified - either "key" or "value".
 		 * @param {string} whitespace Actual whitespace string.
-		 * @param {int} expected Expected whitespace length.
+		 * @param {number} expected Expected whitespace length.
 		 * @param {string} mode Value of the mode as "strict" or "minimum"
 		 * @returns {void}
 		 */
@@ -591,7 +591,7 @@ module.exports = {
 		 * Gets the number of characters in a key, including quotes around string
 		 * keys and braces around computed property keys.
 		 * @param {ASTNode} property Property of on object literal.
-		 * @returns {int} Width of the key.
+		 * @returns {number} Width of the key.
 		 */
 		function getKeyWidth(property) {
 			const startToken = sourceCode.getFirstToken(property);

package/lib/rules/keyword-spacing.js

@@ -75,7 +75,7 @@ function isCloseParenOfTemplate(token) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/line-comment-position.js

@@ -11,7 +11,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/linebreak-style.js

@@ -6,6 +6,14 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Typedefs
+//------------------------------------------------------------------------------
+
+/**
+ * @import { SourceRange } from "@eslint/core";
+ */
+
 //------------------------------------------------------------------------------
 // Requirements
 //------------------------------------------------------------------------------
@@ -16,7 +24,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {
@@ -70,7 +78,7 @@ module.exports = {
 
 		/**
 		 * Builds a fix function that replaces text at the specified range in the source text.
-		 * @param {int[]} range The range to replace
+		 * @param {SourceRange} range The range to replace
 		 * @param {string} text The text to insert.
 		 * @returns {Function} Fixer function
 		 * @private

package/lib/rules/lines-around-comment.js

@@ -53,7 +53,7 @@ function getCommentLineNums(comments) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/lines-around-directive.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "layout",

package/lib/rules/lines-between-class-members.js

@@ -30,7 +30,7 @@ const ClassMemberTypes = {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/logical-assignment-operators.js

@@ -220,7 +220,7 @@ function getLeftmostOperand(sourceCode, node) {
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-classes-per-file.js

@@ -12,7 +12,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-depth.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-len.js

@@ -64,7 +64,7 @@ const OPTIONS_OR_INTEGER_SCHEMA = {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {
@@ -125,8 +125,8 @@ module.exports = {
 		 * Computes the length of a line that may contain tabs. The width of each
 		 * tab will be the number of spaces to the next tab stop.
 		 * @param {string} line The line.
-		 * @param {int} tabWidth The width of each tab stop in spaces.
-		 * @returns {int} The computed line length.
+		 * @param {number} tabWidth The width of each tab stop in spaces.
+		 * @returns {number} The computed line length.
 		 * @private
 		 */
 		function computeLineLength(line, tabWidth) {

package/lib/rules/max-lines-per-function.js

@@ -65,7 +65,7 @@ function getCommentLineNumbers(comments) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-lines.js

@@ -28,7 +28,7 @@ function range(start, end) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-nested-callbacks.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-params.js

@@ -16,7 +16,7 @@ const { upperCaseFirst } = require("../shared/string-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/max-statements-per-line.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/max-statements.js

@@ -16,7 +16,7 @@ const { upperCaseFirst } = require("../shared/string-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",
@@ -92,8 +92,8 @@ module.exports = {
 		/**
 		 * Reports a node if it has too many statements
 		 * @param {ASTNode} node node to evaluate
-		 * @param {int} count Number of statements in node
-		 * @param {int} max Maximum number of statements allowed
+		 * @param {number} count Number of statements in node
+		 * @param {number} max Maximum number of statements allowed
 		 * @returns {void}
 		 * @private
 		 */

package/lib/rules/multiline-comment-style.js

@@ -11,7 +11,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/multiline-ternary.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {