eslint 9.23.0 → 9.25.0

package/lib/languages/js/source-code/source-code.js

@@ -511,8 +511,8 @@ class SourceCode extends TokenStore {
 	/**
 	 * Gets the source code for the given node.
 	 * @param {ASTNode} [node] The AST node to get the text for.
-	 * @param {int} [beforeCount] The number of characters before the node to retrieve.
-	 * @param {int} [afterCount] The number of characters after the node to retrieve.
+	 * @param {number} [beforeCount] The number of characters before the node to retrieve.
+	 * @param {number} [afterCount] The number of characters after the node to retrieve.
 	 * @returns {string} The text representing the AST node.
 	 * @public
 	 */
@@ -627,7 +627,7 @@ class SourceCode extends TokenStore {
 
 	/**
 	 * Gets the deepest node containing a range index.
-	 * @param {int} index Range index of the desired node.
+	 * @param {number} index Range index of the desired node.
 	 * @returns {ASTNode} The node if found or null if not found.
 	 * @public
 	 */

package/lib/languages/js/source-code/token-store/index.js

@@ -605,8 +605,8 @@ module.exports = class TokenStore {
 	/**
 	 * Gets all tokens that are related to the given node.
 	 * @param {ASTNode} node The AST node.
-	 * @param {int} [beforeCount=0] The number of tokens before the node to retrieve.
-	 * @param {int} [afterCount=0] The number of tokens after the node to retrieve.
+	 * @param {number} [beforeCount=0] The number of tokens before the node to retrieve.
+	 * @param {number} [afterCount=0] The number of tokens after the node to retrieve.
 	 * @returns {Token[]} Array of objects representing tokens.
 	 */
 	getTokens(node, beforeCount, afterCount) {
@@ -635,7 +635,7 @@ module.exports = class TokenStore {
 	 * Gets all of the tokens between two non-overlapping nodes.
 	 * @param {ASTNode|Token|Comment} left Node before the desired token range.
 	 * @param {ASTNode|Token|Comment} right Node after the desired token range.
-	 * @param {int} [padding=0] Number of extra tokens on either side of center.
+	 * @param {number} [padding=0] Number of extra tokens on either side of center.
 	 * @returns {Token[]} Tokens between left and right.
 	 */
 	getTokensBetween(left, right, padding) {

package/lib/linter/code-path-analysis/code-path-state.js

@@ -335,7 +335,7 @@ class ForLoopContext extends LoopContextBase {
 		this.updateSegments = null;
 
 		/**
-		 * The end of the update expresion. This may change during the lifetime
+		 * The end of the update expression. This may change during the lifetime
 		 * of the instance as we traverse the loop because some loops don't have
 		 * an update expression.
 		 * @type {Array<CodePathSegment>|null}

package/lib/linter/linter.js

@@ -81,7 +81,7 @@ const STEP_KIND_CALL = 2;
 /** @typedef {import("../shared/types").ParserOptions} ParserOptions */
 /** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
 /** @typedef {import("../shared/types").Processor} Processor */
-/** @typedef {import("../shared/types").Rule} Rule */
+/** @typedef {import("../types").Rule.RuleModule} Rule */
 /** @typedef {import("../shared/types").Times} Times */
 /** @typedef {import("@eslint/core").Language} Language */
 /** @typedef {import("@eslint/core").RuleSeverity} RuleSeverity */

package/lib/linter/node-event-generator.js

@@ -346,11 +346,13 @@ class NodeEventGenerator {
 	 * @returns {void}
 	 */
 	applySelectors(node, isExit) {
+		const nodeTypeKey = this.esqueryOptions?.nodeTypeKey || "type";
+
 		const selectorsByNodeType =
 			(isExit
 				? this.exitSelectorsByNodeType
 				: this.enterSelectorsByNodeType
-			).get(node.type) || [];
+			).get(node[nodeTypeKey]) || [];
 		const anyTypeSelectors = isExit
 			? this.anyTypeExitSelectors
 			: this.anyTypeEnterSelectors;

package/lib/linter/report-translator.js

@@ -133,7 +133,7 @@ function assertValidFix(fix) {
  * Compares items in a fixes array by range.
  * @param {Fix} a The first message.
  * @param {Fix} b The second message.
- * @returns {int} -1 if a comes before b, 1 if a comes after b, 0 if equal.
+ * @returns {number} -1 if a comes before b, 1 if a comes after b, 0 if equal.
  * @private
  */
 function compareFixesByRange(a, b) {

package/lib/linter/rule-fixer.js

@@ -4,6 +4,14 @@
  */
 "use strict";
 
+//------------------------------------------------------------------------------
+// Typedefs
+//------------------------------------------------------------------------------
+
+/**
+ * @import { SourceRange } from "@eslint/core";
+ */
+
 /* eslint class-methods-use-this: off -- Methods desired on instance */
 
 //------------------------------------------------------------------------------
@@ -18,7 +26,7 @@
 
 /**
  * Creates a fix command that inserts text at the specified index in the source text.
- * @param {int} index The 0-based index at which to insert the new text.
+ * @param {number} index The 0-based index at which to insert the new text.
  * @param {string} text The text to insert.
  * @returns {Object} The fix command.
  * @private
@@ -69,7 +77,7 @@ class RuleFixer {
 	/**
 	 * Creates a fix command that inserts text after the specified range in the source text.
 	 * The fix is not applied until applyFixes() is called.
-	 * @param {int[]} range The range to replace, first item is start of range, second
+	 * @param {SourceRange} range The range to replace, first item is start of range, second
 	 *      is end of range.
 	 * @param {string} text The text to insert.
 	 * @returns {Object} The fix command.
@@ -94,7 +102,7 @@ class RuleFixer {
 	/**
 	 * Creates a fix command that inserts text before the specified range in the source text.
 	 * The fix is not applied until applyFixes() is called.
-	 * @param {int[]} range The range to replace, first item is start of range, second
+	 * @param {SourceRange} range The range to replace, first item is start of range, second
 	 *      is end of range.
 	 * @param {string} text The text to insert.
 	 * @returns {Object} The fix command.
@@ -119,7 +127,7 @@ class RuleFixer {
 	/**
 	 * Creates a fix command that replaces text at the specified range in the source text.
 	 * The fix is not applied until applyFixes() is called.
-	 * @param {int[]} range The range to replace, first item is start of range, second
+	 * @param {SourceRange} range The range to replace, first item is start of range, second
 	 *      is end of range.
 	 * @param {string} text The text to insert.
 	 * @returns {Object} The fix command.
@@ -146,7 +154,7 @@ class RuleFixer {
 	/**
 	 * Creates a fix command that removes the specified range of text from the source.
 	 * The fix is not applied until applyFixes() is called.
-	 * @param {int[]} range The range to remove, first item is start of range, second
+	 * @param {SourceRange} range The range to remove, first item is start of range, second
 	 *      is end of range.
 	 * @returns {Object} The fix command.
 	 */

package/lib/linter/rules.js

@@ -16,7 +16,7 @@ const builtInRules = require("../rules");
 // Typedefs
 //------------------------------------------------------------------------------
 
-/** @typedef {import("../shared/types").Rule} Rule */
+/** @typedef {import("../types").Rule.RuleModule} Rule */
 
 //------------------------------------------------------------------------------
 // Public Interface

package/lib/linter/source-code-fixer.js

@@ -20,7 +20,7 @@ const BOM = "\uFEFF";
  * Compares items in a messages array by range.
  * @param {Message} a The first message.
  * @param {Message} b The second message.
- * @returns {int} -1 if a comes before b, 1 if a comes after b, 0 if equal.
+ * @returns {number} -1 if a comes before b, 1 if a comes after b, 0 if equal.
  * @private
  */
 function compareMessagesByFixRange(a, b) {
@@ -31,7 +31,7 @@ function compareMessagesByFixRange(a, b) {
  * Compares items in a messages array by line and column.
  * @param {Message} a The first message.
  * @param {Message} b The second message.
- * @returns {int} -1 if a comes before b, 1 if a comes after b, 0 if equal.
+ * @returns {number} -1 if a comes before b, 1 if a comes after b, 0 if equal.
  * @private
  */
 function compareMessagesByLocation(a, b) {

package/lib/linter/timing.js

@@ -15,7 +15,7 @@ const { startTime, endTime } = require("../shared/stats");
 /**
  * Align the string to left
  * @param {string} str string to evaluate
- * @param {int} len length of the string
+ * @param {number} len length of the string
  * @param {string} ch delimiter character
  * @returns {string} modified string
  * @private
@@ -28,7 +28,7 @@ function alignLeft(str, len, ch) {
 /**
  * Align the string to right
  * @param {string} str string to evaluate
- * @param {int} len length of the string
+ * @param {number} len length of the string
  * @param {string} ch delimiter character
  * @returns {string} modified string
  * @private

package/lib/options.js

@@ -62,6 +62,10 @@ const optionator = require("optionator");
  *      the linting operation to short circuit and not report any failures.
  * @property {string[]} _ Positional filenames or patterns
  * @property {boolean} [stats] Report additional statistics
+ * @property {boolean} [suppressAll] Suppress all error violations
+ * @property {string[]} [suppressRule] Suppress specific rules
+ * @property {string} [suppressionsLocation] Path to the suppressions file or directory
+ * @property {boolean} [pruneSuppressions] Prune unused suppressions
  */
 
 //------------------------------------------------------------------------------
@@ -410,6 +414,31 @@ module.exports = function (usingFlatConfig) {
 				description:
 					"Strategy to use for detecting changed files in the cache",
 			},
+			{
+				heading: "Suppressing Violations",
+			},
+			{
+				option: "suppress-all",
+				type: "Boolean",
+				default: "false",
+				description: "Suppress all violations",
+			},
+			{
+				option: "suppress-rule",
+				type: "[String]",
+				description: "Suppress specific rules",
+			},
+			{
+				option: "suppressions-location",
+				type: "path::String",
+				description: "Specify the location of the suppressions file",
+			},
+			{
+				option: "prune-suppressions",
+				type: "Boolean",
+				default: "false",
+				description: "Prune unused suppressions",
+			},
 			{
 				heading: "Miscellaneous",
 			},

package/lib/rule-tester/rule-tester.js

@@ -41,7 +41,7 @@ const { SourceCode } = require("../languages/js/source-code");
 
 /** @typedef {import("../shared/types").Parser} Parser */
 /** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
-/** @typedef {import("../shared/types").Rule} Rule */
+/** @typedef {import("../types").Rule.RuleModule} Rule */
 
 /**
  * A test case that is expected to pass lint.

package/lib/rules/accessor-pairs.js

@@ -141,7 +141,7 @@ function isPropertyDescriptor(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/array-bracket-newline.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/array-bracket-spacing.js

@@ -11,7 +11,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/array-callback-return.js

@@ -213,7 +213,7 @@ function curlyWrapFixer(sourceCode, node, fixer) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "problem",

package/lib/rules/array-element-newline.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/arrow-body-style.js

@@ -14,7 +14,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/arrow-parens.js

@@ -28,7 +28,7 @@ function hasBlockBody(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/arrow-spacing.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/block-scoped-var.js

@@ -8,7 +8,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/block-spacing.js

@@ -12,7 +12,7 @@ const util = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/brace-style.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/callback-return.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/camelcase.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/capitalized-comments.js

@@ -99,7 +99,7 @@ function createRegExpForIgnorePatterns(normalizedOptions) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/class-methods-use-this.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		dialects: ["javascript", "typescript"],
@@ -26,6 +26,7 @@ module.exports = {
 			{
 				enforceForClassFields: true,
 				exceptMethods: [],
+				ignoreOverrideMethods: false,
 			},
 		],
 
@@ -48,6 +49,12 @@ module.exports = {
 					enforceForClassFields: {
 						type: "boolean",
 					},
+					ignoreOverrideMethods: {
+						type: "boolean",
+					},
+					ignoreClassesWithImplements: {
+						enum: ["all", "public-fields"],
+					},
 				},
 				additionalProperties: false,
 			},
@@ -59,7 +66,11 @@ module.exports = {
 	},
 	create(context) {
 		const [options] = context.options;
-		const { enforceForClassFields } = options;
+		const {
+			enforceForClassFields,
+			ignoreOverrideMethods,
+			ignoreClassesWithImplements,
+		} = options;
 		const exceptMethods = new Set(options.exceptMethods);
 
 		const stack = [];
@@ -107,6 +118,20 @@ module.exports = {
 			}
 		}
 
+		/**
+		 * Check if the node's parent class implements any interfaces
+		 * @param {ASTNode} node node to check
+		 * @returns {boolean} True if parent class implements interfaces
+		 * @private
+		 */
+		function hasImplements(node) {
+			const classNode = node.parent.parent;
+			return (
+				classNode?.type === "ClassDeclaration" &&
+				classNode.implements?.length > 0
+			);
+		}
+
 		/**
 		 * Check if the node is an instance method not excluded by config
 		 * @param {ASTNode} node node to check
@@ -119,6 +144,25 @@ module.exports = {
 					return true;
 				}
 
+				if (ignoreOverrideMethods && node.override) {
+					return false;
+				}
+
+				if (ignoreClassesWithImplements) {
+					const implementsInterfaces = hasImplements(node);
+					if (implementsInterfaces) {
+						if (
+							ignoreClassesWithImplements === "all" ||
+							(ignoreClassesWithImplements === "public-fields" &&
+								node.key.type !== "PrivateIdentifier" &&
+								(!node.accessibility ||
+									node.accessibility === "public"))
+						) {
+							return false;
+						}
+					}
+				}
+
 				const hashIfNeeded =
 					node.key.type === "PrivateIdentifier" ? "#" : "";
 				const name =

package/lib/rules/comma-dangle.js

@@ -71,7 +71,7 @@ function normalizeOptions(optionValue, ecmaVersion) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/comma-spacing.js

@@ -11,7 +11,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/comma-style.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/complexity.js

@@ -19,7 +19,7 @@ const { upperCaseFirst } = require("../shared/string-utils");
 
 const THRESHOLD_DEFAULT = 20;
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/computed-property-spacing.js

@@ -11,7 +11,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/consistent-return.js

@@ -48,7 +48,7 @@ function isClassConstructor(node) {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/consistent-this.js

@@ -8,7 +8,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/constructor-super.js

@@ -129,7 +129,7 @@ class SegmentInfo {
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "problem",

package/lib/rules/curly.js

@@ -14,7 +14,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/default-case-last.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/default-case.js

@@ -10,7 +10,7 @@ const DEFAULT_COMMENT_PATTERN = /^no default$/iu;
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/default-param-last.js

@@ -18,7 +18,7 @@ function isRequiredParameter(node) {
 	);
 }
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		dialects: ["javascript", "typescript"],

package/lib/rules/dot-location.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/dot-notation.js

@@ -20,7 +20,7 @@ const validIdentifier = /^[a-zA-Z_$][a-zA-Z0-9_$]*$/u;
 // `null` literal must be handled separately.
 const literalTypesToCheck = new Set(["string", "boolean"]);
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",

package/lib/rules/eol-last.js

@@ -9,7 +9,7 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		deprecated: {

package/lib/rules/eqeqeq.js

@@ -15,7 +15,7 @@ const astUtils = require("./utils/ast-utils");
 // Rule Definition
 //------------------------------------------------------------------------------
 
-/** @type {import('../shared/types').Rule} */
+/** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		type: "suggestion",