eslint 9.21.0 → 9.23.0

package/lib/rules/default-case-last.js

@@ -11,34 +11,41 @@
 
 /** @type {import('../shared/types').Rule} */
 module.exports = {
-    meta: {
-        type: "suggestion",
-
-        docs: {
-            description: "Enforce `default` clauses in `switch` statements to be last",
-            recommended: false,
-            url: "https://eslint.org/docs/latest/rules/default-case-last"
-        },
-
-        schema: [],
-
-        messages: {
-            notLast: "Default clause should be the last clause."
-        }
-    },
-
-    create(context) {
-        return {
-            SwitchStatement(node) {
-                const cases = node.cases,
-                    indexOfDefault = cases.findIndex(c => c.test === null);
-
-                if (indexOfDefault !== -1 && indexOfDefault !== cases.length - 1) {
-                    const defaultClause = cases[indexOfDefault];
-
-                    context.report({ node: defaultClause, messageId: "notLast" });
-                }
-            }
-        };
-    }
+	meta: {
+		type: "suggestion",
+
+		docs: {
+			description:
+				"Enforce `default` clauses in `switch` statements to be last",
+			recommended: false,
+			url: "https://eslint.org/docs/latest/rules/default-case-last",
+		},
+
+		schema: [],
+
+		messages: {
+			notLast: "Default clause should be the last clause.",
+		},
+	},
+
+	create(context) {
+		return {
+			SwitchStatement(node) {
+				const cases = node.cases,
+					indexOfDefault = cases.findIndex(c => c.test === null);
+
+				if (
+					indexOfDefault !== -1 &&
+					indexOfDefault !== cases.length - 1
+				) {
+					const defaultClause = cases[indexOfDefault];
+
+					context.report({
+						node: defaultClause,
+						messageId: "notLast",
+					});
+				}
+			},
+		};
+	},
 };

package/lib/rules/default-case.js

@@ -12,88 +12,92 @@ const DEFAULT_COMMENT_PATTERN = /^no default$/iu;
 
 /** @type {import('../shared/types').Rule} */
 module.exports = {
-    meta: {
-        type: "suggestion",
-
-        defaultOptions: [{}],
-
-        docs: {
-            description: "Require `default` cases in `switch` statements",
-            recommended: false,
-            url: "https://eslint.org/docs/latest/rules/default-case"
-        },
-
-        schema: [{
-            type: "object",
-            properties: {
-                commentPattern: {
-                    type: "string"
-                }
-            },
-            additionalProperties: false
-        }],
-
-        messages: {
-            missingDefaultCase: "Expected a default case."
-        }
-    },
-
-    create(context) {
-        const [options] = context.options;
-        const commentPattern = options.commentPattern
-            ? new RegExp(options.commentPattern, "u")
-            : DEFAULT_COMMENT_PATTERN;
-
-        const sourceCode = context.sourceCode;
-
-        //--------------------------------------------------------------------------
-        // Helpers
-        //--------------------------------------------------------------------------
-
-        /**
-         * Shortcut to get last element of array
-         * @param {*[]} collection Array
-         * @returns {any} Last element
-         */
-        function last(collection) {
-            return collection.at(-1);
-        }
-
-        //--------------------------------------------------------------------------
-        // Public
-        //--------------------------------------------------------------------------
-
-        return {
-
-            SwitchStatement(node) {
-
-                if (!node.cases.length) {
-
-                    /*
-                     * skip check of empty switch because there is no easy way
-                     * to extract comments inside it now
-                     */
-                    return;
-                }
-
-                const hasDefault = node.cases.some(v => v.test === null);
-
-                if (!hasDefault) {
-
-                    let comment;
-
-                    const lastCase = last(node.cases);
-                    const comments = sourceCode.getCommentsAfter(lastCase);
-
-                    if (comments.length) {
-                        comment = last(comments);
-                    }
-
-                    if (!comment || !commentPattern.test(comment.value.trim())) {
-                        context.report({ node, messageId: "missingDefaultCase" });
-                    }
-                }
-            }
-        };
-    }
+	meta: {
+		type: "suggestion",
+
+		defaultOptions: [{}],
+
+		docs: {
+			description: "Require `default` cases in `switch` statements",
+			recommended: false,
+			url: "https://eslint.org/docs/latest/rules/default-case",
+		},
+
+		schema: [
+			{
+				type: "object",
+				properties: {
+					commentPattern: {
+						type: "string",
+					},
+				},
+				additionalProperties: false,
+			},
+		],
+
+		messages: {
+			missingDefaultCase: "Expected a default case.",
+		},
+	},
+
+	create(context) {
+		const [options] = context.options;
+		const commentPattern = options.commentPattern
+			? new RegExp(options.commentPattern, "u")
+			: DEFAULT_COMMENT_PATTERN;
+
+		const sourceCode = context.sourceCode;
+
+		//--------------------------------------------------------------------------
+		// Helpers
+		//--------------------------------------------------------------------------
+
+		/**
+		 * Shortcut to get last element of array
+		 * @param {*[]} collection Array
+		 * @returns {any} Last element
+		 */
+		function last(collection) {
+			return collection.at(-1);
+		}
+
+		//--------------------------------------------------------------------------
+		// Public
+		//--------------------------------------------------------------------------
+
+		return {
+			SwitchStatement(node) {
+				if (!node.cases.length) {
+					/*
+					 * skip check of empty switch because there is no easy way
+					 * to extract comments inside it now
+					 */
+					return;
+				}
+
+				const hasDefault = node.cases.some(v => v.test === null);
+
+				if (!hasDefault) {
+					let comment;
+
+					const lastCase = last(node.cases);
+					const comments = sourceCode.getCommentsAfter(lastCase);
+
+					if (comments.length) {
+						comment = last(comments);
+					}
+
+					if (
+						!comment ||
+						!commentPattern.test(comment.value.trim())
+					) {
+						context.report({
+							node,
+							messageId: "missingDefaultCase",
+						});
+					}
+				}
+			},
+		};
+	},
 };

package/lib/rules/default-param-last.js

@@ -5,59 +5,74 @@
 
 "use strict";
 
+/**
+ * Checks if node is required: i.e. does not have a default value or ? optional indicator.
+ * @param {ASTNode} node the node to be evaluated
+ * @returns {boolean} true if the node is required, false if not.
+ */
+function isRequiredParameter(node) {
+	return !(
+		node.type === "AssignmentPattern" ||
+		node.type === "RestElement" ||
+		node.optional
+	);
+}
+
 /** @type {import('../shared/types').Rule} */
 module.exports = {
-    meta: {
-        type: "suggestion",
-
-        docs: {
-            description: "Enforce default parameters to be last",
-            recommended: false,
-            frozen: true,
-            url: "https://eslint.org/docs/latest/rules/default-param-last"
-        },
-
-        schema: [],
-
-        messages: {
-            shouldBeLast: "Default parameters should be last."
-        }
-    },
-
-    create(context) {
-
-        /**
-         * Handler for function contexts.
-         * @param {ASTNode} node function node
-         * @returns {void}
-         */
-        function handleFunction(node) {
-            let hasSeenPlainParam = false;
-
-            for (let i = node.params.length - 1; i >= 0; i -= 1) {
-                const param = node.params[i];
-
-                if (
-                    param.type !== "AssignmentPattern" &&
-                    param.type !== "RestElement"
-                ) {
-                    hasSeenPlainParam = true;
-                    continue;
-                }
-
-                if (hasSeenPlainParam && param.type === "AssignmentPattern") {
-                    context.report({
-                        node: param,
-                        messageId: "shouldBeLast"
-                    });
-                }
-            }
-        }
-
-        return {
-            FunctionDeclaration: handleFunction,
-            FunctionExpression: handleFunction,
-            ArrowFunctionExpression: handleFunction
-        };
-    }
+	meta: {
+		dialects: ["javascript", "typescript"],
+		language: "javascript",
+		type: "suggestion",
+
+		docs: {
+			description: "Enforce default parameters to be last",
+			recommended: false,
+			frozen: true,
+			url: "https://eslint.org/docs/latest/rules/default-param-last",
+		},
+
+		schema: [],
+
+		messages: {
+			shouldBeLast: "Default parameters should be last.",
+		},
+	},
+
+	create(context) {
+		/**
+		 * Handler for function contexts.
+		 * @param {ASTNode} node function node
+		 * @returns {void}
+		 */
+		function handleFunction(node) {
+			let hasSeenRequiredParameter = false;
+
+			for (let i = node.params.length - 1; i >= 0; i -= 1) {
+				const current = node.params[i];
+				const param =
+					current.type === "TSParameterProperty"
+						? current.parameter
+						: current;
+
+				if (isRequiredParameter(param)) {
+					hasSeenRequiredParameter = true;
+					continue;
+				}
+
+				if (hasSeenRequiredParameter) {
+					context.report({
+						node: current,
+						messageId: "shouldBeLast",
+					});
+				}
+			}
+		}
+
+		return {
+			FunctionDeclaration: handleFunction,
+			FunctionExpression: handleFunction,
+			ArrowFunctionExpression: handleFunction,
+		};
+	},
 };

package/lib/rules/dot-location.js

@@ -14,113 +14,125 @@ const astUtils = require("./utils/ast-utils");
 
 /** @type {import('../shared/types').Rule} */
 module.exports = {
-    meta: {
-        deprecated: {
-            message: "Formatting rules are being moved out of ESLint core.",
-            url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
-            deprecatedSince: "8.53.0",
-            availableUntil: "10.0.0",
-            replacedBy: [
-                {
-                    message: "ESLint Stylistic now maintains deprecated stylistic core rules.",
-                    url: "https://eslint.style/guide/migration",
-                    plugin: {
-                        name: "@stylistic/eslint-plugin-js",
-                        url: "https://eslint.style/packages/js"
-                    },
-                    rule: {
-                        name: "dot-location",
-                        url: "https://eslint.style/rules/js/dot-location"
-                    }
-                }
-            ]
-        },
-        type: "layout",
-
-        docs: {
-            description: "Enforce consistent newlines before and after dots",
-            recommended: false,
-            url: "https://eslint.org/docs/latest/rules/dot-location"
-        },
-
-        schema: [
-            {
-                enum: ["object", "property"]
-            }
-        ],
-
-        fixable: "code",
-
-        messages: {
-            expectedDotAfterObject: "Expected dot to be on same line as object.",
-            expectedDotBeforeProperty: "Expected dot to be on same line as property."
-        }
-    },
-
-    create(context) {
-
-        const config = context.options[0];
-
-        // default to onObject if no preference is passed
-        const onObject = config === "object" || !config;
-
-        const sourceCode = context.sourceCode;
-
-        /**
-         * Reports if the dot between object and property is on the correct location.
-         * @param {ASTNode} node The `MemberExpression` node.
-         * @returns {void}
-         */
-        function checkDotLocation(node) {
-            const property = node.property;
-            const dotToken = sourceCode.getTokenBefore(property);
-
-            if (onObject) {
-
-                // `obj` expression can be parenthesized, but those paren tokens are not a part of the `obj` node.
-                const tokenBeforeDot = sourceCode.getTokenBefore(dotToken);
-
-                if (!astUtils.isTokenOnSameLine(tokenBeforeDot, dotToken)) {
-                    context.report({
-                        node,
-                        loc: dotToken.loc,
-                        messageId: "expectedDotAfterObject",
-                        *fix(fixer) {
-                            if (dotToken.value.startsWith(".") && astUtils.isDecimalIntegerNumericToken(tokenBeforeDot)) {
-                                yield fixer.insertTextAfter(tokenBeforeDot, ` ${dotToken.value}`);
-                            } else {
-                                yield fixer.insertTextAfter(tokenBeforeDot, dotToken.value);
-                            }
-                            yield fixer.remove(dotToken);
-                        }
-                    });
-                }
-            } else if (!astUtils.isTokenOnSameLine(dotToken, property)) {
-                context.report({
-                    node,
-                    loc: dotToken.loc,
-                    messageId: "expectedDotBeforeProperty",
-                    *fix(fixer) {
-                        yield fixer.remove(dotToken);
-                        yield fixer.insertTextBefore(property, dotToken.value);
-                    }
-                });
-            }
-        }
-
-        /**
-         * Checks the spacing of the dot within a member expression.
-         * @param {ASTNode} node The node to check.
-         * @returns {void}
-         */
-        function checkNode(node) {
-            if (!node.computed) {
-                checkDotLocation(node);
-            }
-        }
-
-        return {
-            MemberExpression: checkNode
-        };
-    }
+	meta: {
+		deprecated: {
+			message: "Formatting rules are being moved out of ESLint core.",
+			url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
+			deprecatedSince: "8.53.0",
+			availableUntil: "10.0.0",
+			replacedBy: [
+				{
+					message:
+						"ESLint Stylistic now maintains deprecated stylistic core rules.",
+					url: "https://eslint.style/guide/migration",
+					plugin: {
+						name: "@stylistic/eslint-plugin-js",
+						url: "https://eslint.style/packages/js",
+					},
+					rule: {
+						name: "dot-location",
+						url: "https://eslint.style/rules/js/dot-location",
+					},
+				},
+			],
+		},
+		type: "layout",
+
+		docs: {
+			description: "Enforce consistent newlines before and after dots",
+			recommended: false,
+			url: "https://eslint.org/docs/latest/rules/dot-location",
+		},
+
+		schema: [
+			{
+				enum: ["object", "property"],
+			},
+		],
+
+		fixable: "code",
+
+		messages: {
+			expectedDotAfterObject:
+				"Expected dot to be on same line as object.",
+			expectedDotBeforeProperty:
+				"Expected dot to be on same line as property.",
+		},
+	},
+
+	create(context) {
+		const config = context.options[0];
+
+		// default to onObject if no preference is passed
+		const onObject = config === "object" || !config;
+
+		const sourceCode = context.sourceCode;
+
+		/**
+		 * Reports if the dot between object and property is on the correct location.
+		 * @param {ASTNode} node The `MemberExpression` node.
+		 * @returns {void}
+		 */
+		function checkDotLocation(node) {
+			const property = node.property;
+			const dotToken = sourceCode.getTokenBefore(property);
+
+			if (onObject) {
+				// `obj` expression can be parenthesized, but those paren tokens are not a part of the `obj` node.
+				const tokenBeforeDot = sourceCode.getTokenBefore(dotToken);
+
+				if (!astUtils.isTokenOnSameLine(tokenBeforeDot, dotToken)) {
+					context.report({
+						node,
+						loc: dotToken.loc,
+						messageId: "expectedDotAfterObject",
+						*fix(fixer) {
+							if (
+								dotToken.value.startsWith(".") &&
+								astUtils.isDecimalIntegerNumericToken(
+									tokenBeforeDot,
+								)
+							) {
+								yield fixer.insertTextAfter(
+									tokenBeforeDot,
+									` ${dotToken.value}`,
+								);
+							} else {
+								yield fixer.insertTextAfter(
+									tokenBeforeDot,
+									dotToken.value,
+								);
+							}
+							yield fixer.remove(dotToken);
+						},
+					});
+				}
+			} else if (!astUtils.isTokenOnSameLine(dotToken, property)) {
+				context.report({
+					node,
+					loc: dotToken.loc,
+					messageId: "expectedDotBeforeProperty",
+					*fix(fixer) {
+						yield fixer.remove(dotToken);
+						yield fixer.insertTextBefore(property, dotToken.value);
+					},
+				});
+			}
+		}
+
+		/**
+		 * Checks the spacing of the dot within a member expression.
+		 * @param {ASTNode} node The node to check.
+		 * @returns {void}
+		 */
+		function checkNode(node) {
+			if (!node.computed) {
+				checkDotLocation(node);
+			}
+		}
+
+		return {
+			MemberExpression: checkNode,
+		};
+	},
 };