eslint 9.21.0 → 9.23.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +52 -48
- package/bin/eslint.js +92 -90
- package/conf/default-cli-options.js +22 -22
- package/conf/ecma-version.js +1 -1
- package/conf/globals.js +97 -98
- package/conf/replacements.json +24 -20
- package/conf/rule-type-list.json +88 -92
- package/lib/api.js +12 -12
- package/lib/cli-engine/cli-engine.js +828 -808
- package/lib/cli-engine/file-enumerator.js +381 -387
- package/lib/cli-engine/formatters/formatters-meta.json +16 -16
- package/lib/cli-engine/formatters/html.js +107 -99
- package/lib/cli-engine/formatters/json-with-metadata.js +5 -5
- package/lib/cli-engine/formatters/json.js +2 -2
- package/lib/cli-engine/formatters/stylish.js +96 -75
- package/lib/cli-engine/hash.js +1 -1
- package/lib/cli-engine/index.js +1 -1
- package/lib/cli-engine/lint-result-cache.js +144 -145
- package/lib/cli-engine/load-rules.js +16 -16
- package/lib/cli.js +541 -457
- package/lib/config/config-loader.js +648 -618
- package/lib/config/config.js +247 -221
- package/lib/config/default-config.js +54 -45
- package/lib/config/flat-config-array.js +167 -172
- package/lib/config/flat-config-helpers.js +65 -68
- package/lib/config/flat-config-schema.js +375 -368
- package/lib/config/rule-validator.js +139 -144
- package/lib/config-api.js +12 -0
- package/lib/eslint/eslint-helpers.js +709 -679
- package/lib/eslint/eslint.js +944 -886
- package/lib/eslint/index.js +2 -2
- package/lib/eslint/legacy-eslint.js +576 -532
- package/lib/languages/js/index.js +263 -264
- package/lib/languages/js/source-code/index.js +1 -1
- package/lib/languages/js/source-code/source-code.js +1129 -1054
- package/lib/languages/js/source-code/token-store/backward-token-comment-cursor.js +39 -35
- package/lib/languages/js/source-code/token-store/backward-token-cursor.js +35 -36
- package/lib/languages/js/source-code/token-store/cursor.js +36 -36
- package/lib/languages/js/source-code/token-store/cursors.js +80 -52
- package/lib/languages/js/source-code/token-store/decorative-cursor.js +17 -18
- package/lib/languages/js/source-code/token-store/filter-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/forward-token-comment-cursor.js +40 -32
- package/lib/languages/js/source-code/token-store/forward-token-cursor.js +40 -41
- package/lib/languages/js/source-code/token-store/index.js +592 -498
- package/lib/languages/js/source-code/token-store/limit-cursor.js +17 -18
- package/lib/languages/js/source-code/token-store/padded-token-cursor.js +23 -16
- package/lib/languages/js/source-code/token-store/skip-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/utils.js +63 -60
- package/lib/languages/js/validate-language-options.js +104 -89
- package/lib/linter/apply-disable-directives.js +467 -383
- package/lib/linter/code-path-analysis/code-path-analyzer.js +650 -672
- package/lib/linter/code-path-analysis/code-path-segment.js +215 -216
- package/lib/linter/code-path-analysis/code-path-state.js +2118 -2096
- package/lib/linter/code-path-analysis/code-path.js +307 -319
- package/lib/linter/code-path-analysis/debug-helpers.js +183 -163
- package/lib/linter/code-path-analysis/fork-context.js +296 -271
- package/lib/linter/code-path-analysis/id-generator.js +22 -23
- package/lib/linter/file-context.js +119 -120
- package/lib/linter/index.js +3 -3
- package/lib/linter/interpolate.js +16 -16
- package/lib/linter/linter.js +2402 -2044
- package/lib/linter/node-event-generator.js +284 -225
- package/lib/linter/report-translator.js +256 -219
- package/lib/linter/rule-fixer.js +122 -124
- package/lib/linter/rules.js +35 -35
- package/lib/linter/safe-emitter.js +18 -18
- package/lib/linter/source-code-fixer.js +94 -92
- package/lib/linter/timing.js +104 -101
- package/lib/linter/vfile.js +70 -73
- package/lib/options.js +375 -361
- package/lib/rule-tester/index.js +1 -1
- package/lib/rule-tester/rule-tester.js +1307 -1045
- package/lib/rules/accessor-pairs.js +297 -262
- package/lib/rules/array-bracket-newline.js +249 -237
- package/lib/rules/array-bracket-spacing.js +262 -223
- package/lib/rules/array-callback-return.js +401 -355
- package/lib/rules/array-element-newline.js +357 -312
- package/lib/rules/arrow-body-style.js +399 -280
- package/lib/rules/arrow-parens.js +205 -172
- package/lib/rules/arrow-spacing.js +168 -162
- package/lib/rules/block-scoped-var.js +124 -122
- package/lib/rules/block-spacing.js +185 -175
- package/lib/rules/brace-style.js +261 -198
- package/lib/rules/callback-return.js +202 -189
- package/lib/rules/camelcase.js +402 -391
- package/lib/rules/capitalized-comments.js +252 -231
- package/lib/rules/class-methods-use-this.js +179 -171
- package/lib/rules/comma-dangle.js +378 -345
- package/lib/rules/comma-spacing.js +192 -194
- package/lib/rules/comma-style.js +374 -315
- package/lib/rules/complexity.js +172 -168
- package/lib/rules/computed-property-spacing.js +235 -210
- package/lib/rules/consistent-return.js +180 -169
- package/lib/rules/consistent-this.js +166 -146
- package/lib/rules/constructor-super.js +411 -403
- package/lib/rules/curly.js +406 -331
- package/lib/rules/default-case-last.js +37 -30
- package/lib/rules/default-case.js +88 -84
- package/lib/rules/default-param-last.js +68 -53
- package/lib/rules/dot-location.js +121 -109
- package/lib/rules/dot-notation.js +191 -155
- package/lib/rules/eol-last.js +121 -119
- package/lib/rules/eqeqeq.js +167 -154
- package/lib/rules/for-direction.js +145 -120
- package/lib/rules/func-call-spacing.js +260 -230
- package/lib/rules/func-name-matching.js +292 -208
- package/lib/rules/func-names.js +164 -163
- package/lib/rules/func-style.js +158 -126
- package/lib/rules/function-call-argument-newline.js +151 -128
- package/lib/rules/function-paren-newline.js +348 -290
- package/lib/rules/generator-star-spacing.js +228 -209
- package/lib/rules/getter-return.js +207 -171
- package/lib/rules/global-require.js +84 -73
- package/lib/rules/grouped-accessor-pairs.js +169 -149
- package/lib/rules/guard-for-in.js +71 -62
- package/lib/rules/handle-callback-err.js +107 -102
- package/lib/rules/id-blacklist.js +181 -198
- package/lib/rules/id-denylist.js +167 -186
- package/lib/rules/id-length.js +196 -170
- package/lib/rules/id-match.js +343 -288
- package/lib/rules/implicit-arrow-linebreak.js +101 -78
- package/lib/rules/indent-legacy.js +1343 -1117
- package/lib/rules/indent.js +2271 -1758
- package/lib/rules/index.js +317 -292
- package/lib/rules/init-declarations.js +115 -106
- package/lib/rules/jsx-quotes.js +93 -81
- package/lib/rules/key-spacing.js +749 -632
- package/lib/rules/keyword-spacing.js +647 -604
- package/lib/rules/line-comment-position.js +141 -127
- package/lib/rules/linebreak-style.js +106 -105
- package/lib/rules/lines-around-comment.js +539 -447
- package/lib/rules/lines-around-directive.js +232 -202
- package/lib/rules/lines-between-class-members.js +304 -233
- package/lib/rules/logical-assignment-operators.js +581 -398
- package/lib/rules/max-classes-per-file.js +68 -67
- package/lib/rules/max-depth.js +145 -142
- package/lib/rules/max-len.js +472 -433
- package/lib/rules/max-lines-per-function.js +200 -175
- package/lib/rules/max-lines.js +157 -161
- package/lib/rules/max-nested-callbacks.js +101 -103
- package/lib/rules/max-params.js +77 -75
- package/lib/rules/max-statements-per-line.js +204 -197
- package/lib/rules/max-statements.js +167 -163
- package/lib/rules/multiline-comment-style.js +636 -478
- package/lib/rules/multiline-ternary.js +240 -175
- package/lib/rules/new-cap.js +232 -212
- package/lib/rules/new-parens.js +87 -78
- package/lib/rules/newline-after-var.js +286 -249
- package/lib/rules/newline-before-return.js +228 -221
- package/lib/rules/newline-per-chained-call.js +141 -126
- package/lib/rules/no-alert.js +89 -78
- package/lib/rules/no-array-constructor.js +121 -112
- package/lib/rules/no-async-promise-executor.js +29 -23
- package/lib/rules/no-await-in-loop.js +68 -70
- package/lib/rules/no-bitwise.js +123 -99
- package/lib/rules/no-buffer-constructor.js +54 -46
- package/lib/rules/no-caller.js +38 -32
- package/lib/rules/no-case-declarations.js +60 -56
- package/lib/rules/no-catch-shadow.js +75 -72
- package/lib/rules/no-class-assign.js +50 -47
- package/lib/rules/no-compare-neg-zero.js +61 -47
- package/lib/rules/no-cond-assign.js +147 -131
- package/lib/rules/no-confusing-arrow.js +97 -80
- package/lib/rules/no-console.js +201 -190
- package/lib/rules/no-const-assign.js +46 -40
- package/lib/rules/no-constant-binary-expression.js +499 -404
- package/lib/rules/no-constant-condition.js +157 -142
- package/lib/rules/no-constructor-return.js +48 -48
- package/lib/rules/no-continue.js +24 -26
- package/lib/rules/no-control-regex.js +124 -120
- package/lib/rules/no-debugger.js +27 -29
- package/lib/rules/no-delete-var.js +28 -28
- package/lib/rules/no-div-regex.js +46 -40
- package/lib/rules/no-dupe-args.js +67 -68
- package/lib/rules/no-dupe-class-members.js +92 -88
- package/lib/rules/no-dupe-else-if.js +99 -76
- package/lib/rules/no-dupe-keys.js +132 -109
- package/lib/rules/no-duplicate-case.js +49 -42
- package/lib/rules/no-duplicate-imports.js +178 -175
- package/lib/rules/no-else-return.js +429 -384
- package/lib/rules/no-empty-character-class.js +56 -49
- package/lib/rules/no-empty-function.js +126 -127
- package/lib/rules/no-empty-pattern.js +62 -57
- package/lib/rules/no-empty-static-block.js +36 -34
- package/lib/rules/no-empty.js +97 -85
- package/lib/rules/no-eq-null.js +36 -31
- package/lib/rules/no-eval.js +255 -249
- package/lib/rules/no-ex-assign.js +41 -38
- package/lib/rules/no-extend-native.js +160 -158
- package/lib/rules/no-extra-bind.js +200 -189
- package/lib/rules/no-extra-boolean-cast.js +397 -347
- package/lib/rules/no-extra-label.js +149 -130
- package/lib/rules/no-extra-parens.js +1653 -1324
- package/lib/rules/no-extra-semi.js +145 -143
- package/lib/rules/no-fallthrough.js +198 -156
- package/lib/rules/no-floating-decimal.js +73 -65
- package/lib/rules/no-func-assign.js +53 -54
- package/lib/rules/no-global-assign.js +77 -72
- package/lib/rules/no-implicit-coercion.js +348 -292
- package/lib/rules/no-implicit-globals.js +157 -134
- package/lib/rules/no-implied-eval.js +139 -111
- package/lib/rules/no-import-assign.js +144 -158
- package/lib/rules/no-inline-comments.js +100 -94
- package/lib/rules/no-inner-declarations.js +114 -100
- package/lib/rules/no-invalid-regexp.js +221 -189
- package/lib/rules/no-invalid-this.js +122 -116
- package/lib/rules/no-irregular-whitespace.js +265 -251
- package/lib/rules/no-iterator.js +28 -32
- package/lib/rules/no-label-var.js +58 -61
- package/lib/rules/no-labels.js +137 -132
- package/lib/rules/no-lone-blocks.js +126 -122
- package/lib/rules/no-lonely-if.js +107 -76
- package/lib/rules/no-loop-func.js +233 -212
- package/lib/rules/no-loss-of-precision.js +215 -200
- package/lib/rules/no-magic-numbers.js +245 -217
- package/lib/rules/no-misleading-character-class.js +498 -445
- package/lib/rules/no-mixed-operators.js +187 -181
- package/lib/rules/no-mixed-requires.js +252 -239
- package/lib/rules/no-mixed-spaces-and-tabs.js +133 -120
- package/lib/rules/no-multi-assign.js +45 -43
- package/lib/rules/no-multi-spaces.js +162 -142
- package/lib/rules/no-multi-str.js +41 -40
- package/lib/rules/no-multiple-empty-lines.js +195 -157
- package/lib/rules/no-native-reassign.js +89 -84
- package/lib/rules/no-negated-condition.js +78 -74
- package/lib/rules/no-negated-in-lhs.js +44 -42
- package/lib/rules/no-nested-ternary.js +32 -31
- package/lib/rules/no-new-func.js +70 -61
- package/lib/rules/no-new-native-nonconstructor.js +42 -38
- package/lib/rules/no-new-object.js +47 -47
- package/lib/rules/no-new-require.js +47 -46
- package/lib/rules/no-new-symbol.js +51 -49
- package/lib/rules/no-new-wrappers.js +42 -40
- package/lib/rules/no-new.js +27 -28
- package/lib/rules/no-nonoctal-decimal-escape.js +140 -120
- package/lib/rules/no-obj-calls.js +65 -52
- package/lib/rules/no-object-constructor.js +103 -96
- package/lib/rules/no-octal-escape.js +39 -42
- package/lib/rules/no-octal.js +31 -31
- package/lib/rules/no-param-reassign.js +234 -216
- package/lib/rules/no-path-concat.js +65 -66
- package/lib/rules/no-plusplus.js +59 -60
- package/lib/rules/no-process-env.js +48 -47
- package/lib/rules/no-process-exit.js +53 -49
- package/lib/rules/no-promise-executor-return.js +213 -181
- package/lib/rules/no-proto.js +25 -28
- package/lib/rules/no-prototype-builtins.js +145 -123
- package/lib/rules/no-redeclare.js +153 -151
- package/lib/rules/no-regex-spaces.js +182 -160
- package/lib/rules/no-restricted-exports.js +207 -184
- package/lib/rules/no-restricted-globals.js +110 -111
- package/lib/rules/no-restricted-imports.js +656 -536
- package/lib/rules/no-restricted-modules.js +221 -201
- package/lib/rules/no-restricted-properties.js +180 -152
- package/lib/rules/no-restricted-syntax.js +55 -51
- package/lib/rules/no-return-assign.js +54 -49
- package/lib/rules/no-return-await.js +147 -123
- package/lib/rules/no-script-url.js +51 -44
- package/lib/rules/no-self-assign.js +147 -145
- package/lib/rules/no-self-compare.js +62 -45
- package/lib/rules/no-sequences.js +134 -115
- package/lib/rules/no-setter-return.js +184 -151
- package/lib/rules/no-shadow-restricted-names.js +60 -45
- package/lib/rules/no-shadow.js +341 -315
- package/lib/rules/no-spaced-func.js +81 -76
- package/lib/rules/no-sparse-arrays.js +53 -58
- package/lib/rules/no-sync.js +60 -59
- package/lib/rules/no-tabs.js +82 -71
- package/lib/rules/no-template-curly-in-string.js +32 -31
- package/lib/rules/no-ternary.js +24 -28
- package/lib/rules/no-this-before-super.js +320 -318
- package/lib/rules/no-throw-literal.js +30 -35
- package/lib/rules/no-trailing-spaces.js +198 -190
- package/lib/rules/no-undef-init.js +75 -60
- package/lib/rules/no-undef.js +50 -47
- package/lib/rules/no-undefined.js +72 -74
- package/lib/rules/no-underscore-dangle.js +369 -326
- package/lib/rules/no-unexpected-multiline.js +111 -101
- package/lib/rules/no-unmodified-loop-condition.js +253 -253
- package/lib/rules/no-unneeded-ternary.js +211 -146
- package/lib/rules/no-unreachable-loop.js +144 -141
- package/lib/rules/no-unreachable.js +254 -247
- package/lib/rules/no-unsafe-finally.js +92 -84
- package/lib/rules/no-unsafe-negation.js +104 -82
- package/lib/rules/no-unsafe-optional-chaining.js +191 -177
- package/lib/rules/no-unused-expressions.js +177 -161
- package/lib/rules/no-unused-labels.js +138 -123
- package/lib/rules/no-unused-private-class-members.js +205 -181
- package/lib/rules/no-unused-vars.js +1668 -1448
- package/lib/rules/no-use-before-define.js +228 -230
- package/lib/rules/no-useless-assignment.js +589 -510
- package/lib/rules/no-useless-backreference.js +211 -192
- package/lib/rules/no-useless-call.js +57 -52
- package/lib/rules/no-useless-catch.js +39 -39
- package/lib/rules/no-useless-computed-key.js +143 -114
- package/lib/rules/no-useless-concat.js +64 -59
- package/lib/rules/no-useless-constructor.js +157 -110
- package/lib/rules/no-useless-escape.js +341 -290
- package/lib/rules/no-useless-rename.js +182 -155
- package/lib/rules/no-useless-return.js +343 -311
- package/lib/rules/no-var.js +232 -211
- package/lib/rules/no-void.js +49 -47
- package/lib/rules/no-warning-comments.js +190 -185
- package/lib/rules/no-whitespace-before-property.js +130 -114
- package/lib/rules/no-with.js +23 -25
- package/lib/rules/nonblock-statement-body-position.js +148 -129
- package/lib/rules/object-curly-newline.js +305 -264
- package/lib/rules/object-curly-spacing.js +359 -313
- package/lib/rules/object-property-newline.js +136 -105
- package/lib/rules/object-shorthand.js +606 -501
- package/lib/rules/one-var-declaration-per-line.js +103 -99
- package/lib/rules/one-var.js +652 -536
- package/lib/rules/operator-assignment.js +218 -160
- package/lib/rules/operator-linebreak.js +294 -250
- package/lib/rules/padded-blocks.js +345 -307
- package/lib/rules/padding-line-between-statements.js +442 -438
- package/lib/rules/prefer-arrow-callback.js +361 -312
- package/lib/rules/prefer-const.js +417 -376
- package/lib/rules/prefer-destructuring.js +300 -278
- package/lib/rules/prefer-exponentiation-operator.js +175 -132
- package/lib/rules/prefer-named-capture-group.js +152 -139
- package/lib/rules/prefer-numeric-literals.js +120 -112
- package/lib/rules/prefer-object-has-own.js +115 -81
- package/lib/rules/prefer-object-spread.js +212 -192
- package/lib/rules/prefer-promise-reject-errors.js +139 -121
- package/lib/rules/prefer-reflect.js +126 -106
- package/lib/rules/prefer-regex-literals.js +577 -465
- package/lib/rules/prefer-rest-params.js +78 -79
- package/lib/rules/prefer-spread.js +46 -43
- package/lib/rules/prefer-template.js +265 -194
- package/lib/rules/quote-props.js +372 -306
- package/lib/rules/quotes.js +373 -325
- package/lib/rules/radix.js +151 -135
- package/lib/rules/require-atomic-updates.js +315 -284
- package/lib/rules/require-await.js +143 -115
- package/lib/rules/require-unicode-regexp.js +281 -176
- package/lib/rules/require-yield.js +52 -53
- package/lib/rules/rest-spread-spacing.js +127 -115
- package/lib/rules/semi-spacing.js +280 -249
- package/lib/rules/semi-style.js +175 -133
- package/lib/rules/semi.js +455 -435
- package/lib/rules/sort-imports.js +305 -232
- package/lib/rules/sort-keys.js +218 -187
- package/lib/rules/sort-vars.js +126 -92
- package/lib/rules/space-before-blocks.js +198 -188
- package/lib/rules/space-before-function-paren.js +185 -165
- package/lib/rules/space-in-parens.js +358 -287
- package/lib/rules/space-infix-ops.js +236 -200
- package/lib/rules/space-unary-ops.js +355 -297
- package/lib/rules/spaced-comment.js +362 -318
- package/lib/rules/strict.js +264 -229
- package/lib/rules/switch-colon-spacing.js +129 -121
- package/lib/rules/symbol-description.js +44 -47
- package/lib/rules/template-curly-spacing.js +147 -141
- package/lib/rules/template-tag-spacing.js +97 -87
- package/lib/rules/unicode-bom.js +53 -55
- package/lib/rules/use-isnan.js +236 -205
- package/lib/rules/utils/ast-utils.js +2039 -1860
- package/lib/rules/utils/char-source.js +162 -155
- package/lib/rules/utils/fix-tracker.js +83 -80
- package/lib/rules/utils/keywords.js +59 -59
- package/lib/rules/utils/lazy-loading-rule-map.js +79 -76
- package/lib/rules/utils/regular-expressions.js +32 -24
- package/lib/rules/utils/unicode/index.js +4 -4
- package/lib/rules/utils/unicode/is-combining-character.js +1 -1
- package/lib/rules/utils/unicode/is-emoji-modifier.js +1 -1
- package/lib/rules/utils/unicode/is-regional-indicator-symbol.js +1 -1
- package/lib/rules/utils/unicode/is-surrogate-pair.js +1 -1
- package/lib/rules/valid-typeof.js +152 -110
- package/lib/rules/vars-on-top.js +151 -144
- package/lib/rules/wrap-iife.js +203 -190
- package/lib/rules/wrap-regex.js +69 -57
- package/lib/rules/yield-star-spacing.js +144 -133
- package/lib/rules/yoda.js +282 -271
- package/lib/services/parser-service.js +35 -35
- package/lib/services/processor-service.js +66 -73
- package/lib/shared/ajv.js +14 -14
- package/lib/shared/assert.js +3 -4
- package/lib/shared/ast-utils.js +7 -6
- package/lib/shared/deep-merge-arrays.js +24 -22
- package/lib/shared/directives.js +3 -2
- package/lib/shared/flags.js +46 -17
- package/lib/shared/logging.js +24 -25
- package/lib/shared/option-utils.js +43 -36
- package/lib/shared/runtime-info.js +136 -127
- package/lib/shared/serialization.js +27 -27
- package/lib/shared/severity.js +22 -22
- package/lib/shared/stats.js +5 -5
- package/lib/shared/string-utils.js +16 -16
- package/lib/shared/text-table.js +28 -27
- package/lib/shared/traverser.js +153 -146
- package/lib/types/config-api.d.ts +8 -0
- package/lib/types/index.d.ts +2010 -1559
- package/lib/types/rules.d.ts +5312 -0
- package/lib/types/use-at-your-own-risk.d.ts +32 -30
- package/lib/unsupported-api.js +5 -5
- package/messages/all-files-ignored.js +3 -3
- package/messages/all-matched-files-ignored.js +3 -3
- package/messages/config-file-missing.js +2 -2
- package/messages/config-plugin-missing.js +3 -3
- package/messages/config-serialize-function.js +9 -7
- package/messages/eslintrc-incompat.js +13 -15
- package/messages/eslintrc-plugins.js +3 -4
- package/messages/extend-config-missing.js +3 -3
- package/messages/failed-to-read-json.js +3 -3
- package/messages/file-not-found.js +3 -3
- package/messages/invalid-rule-options.js +2 -2
- package/messages/invalid-rule-severity.js +2 -2
- package/messages/no-config-found.js +3 -3
- package/messages/plugin-conflict.js +8 -8
- package/messages/plugin-invalid.js +3 -3
- package/messages/plugin-missing.js +3 -3
- package/messages/print-config-with-directory-path.js +2 -2
- package/messages/shared.js +6 -1
- package/messages/whitespace-found.js +3 -3
- package/package.json +22 -20
- package/lib/types/rules/best-practices.d.ts +0 -1143
- package/lib/types/rules/deprecated.d.ts +0 -252
- package/lib/types/rules/ecmascript-6.d.ts +0 -647
- package/lib/types/rules/index.d.ts +0 -50
- package/lib/types/rules/node-commonjs.d.ts +0 -171
- package/lib/types/rules/possible-errors.d.ts +0 -685
- package/lib/types/rules/strict-mode.d.ts +0 -38
- package/lib/types/rules/stylistic-issues.d.ts +0 -2043
- package/lib/types/rules/variables.d.ts +0 -234
@@ -4,17 +4,25 @@
|
|
4
4
|
"use strict";
|
5
5
|
|
6
6
|
const {
|
7
|
-
|
8
|
-
|
9
|
-
|
10
|
-
|
11
|
-
|
7
|
+
CALL,
|
8
|
+
CONSTRUCT,
|
9
|
+
ReferenceTracker,
|
10
|
+
getStaticValue,
|
11
|
+
getStringIfConstant,
|
12
12
|
} = require("@eslint-community/eslint-utils");
|
13
13
|
const { RegExpParser, visitRegExpAST } = require("@eslint-community/regexpp");
|
14
|
-
const {
|
14
|
+
const {
|
15
|
+
isCombiningCharacter,
|
16
|
+
isEmojiModifier,
|
17
|
+
isRegionalIndicatorSymbol,
|
18
|
+
isSurrogatePair,
|
19
|
+
} = require("./utils/unicode");
|
15
20
|
const astUtils = require("./utils/ast-utils.js");
|
16
21
|
const { isValidWithUnicodeFlag } = require("./utils/regular-expressions");
|
17
|
-
const {
|
22
|
+
const {
|
23
|
+
parseStringLiteral,
|
24
|
+
parseTemplateToken,
|
25
|
+
} = require("./utils/char-source");
|
18
26
|
|
19
27
|
//------------------------------------------------------------------------------
|
20
28
|
// Helpers
|
@@ -33,40 +41,39 @@ const { parseStringLiteral, parseTemplateToken } = require("./utils/char-source"
|
|
33
41
|
* @param {CharacterClassElement[]} nodes The node list to iterate character sequences.
|
34
42
|
* @returns {IterableIterator<Character[]>} The list of character sequences.
|
35
43
|
*/
|
36
|
-
function
|
37
|
-
|
38
|
-
|
39
|
-
|
40
|
-
|
41
|
-
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
52
|
-
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
|
59
|
-
|
60
|
-
|
61
|
-
|
62
|
-
|
63
|
-
|
64
|
-
|
65
|
-
|
66
|
-
|
67
|
-
|
68
|
-
|
69
|
-
}
|
44
|
+
function* iterateCharacterSequence(nodes) {
|
45
|
+
/** @type {Character[]} */
|
46
|
+
let seq = [];
|
47
|
+
|
48
|
+
for (const node of nodes) {
|
49
|
+
switch (node.type) {
|
50
|
+
case "Character":
|
51
|
+
seq.push(node);
|
52
|
+
break;
|
53
|
+
|
54
|
+
case "CharacterClassRange":
|
55
|
+
seq.push(node.min);
|
56
|
+
yield seq;
|
57
|
+
seq = [node.max];
|
58
|
+
break;
|
59
|
+
|
60
|
+
case "CharacterSet":
|
61
|
+
case "CharacterClass": // [[]] nesting character class
|
62
|
+
case "ClassStringDisjunction": // \q{...}
|
63
|
+
case "ExpressionCharacterClass": // [A--B]
|
64
|
+
if (seq.length > 0) {
|
65
|
+
yield seq;
|
66
|
+
seq = [];
|
67
|
+
}
|
68
|
+
break;
|
69
|
+
|
70
|
+
// no default
|
71
|
+
}
|
72
|
+
}
|
73
|
+
|
74
|
+
if (seq.length > 0) {
|
75
|
+
yield seq;
|
76
|
+
}
|
70
77
|
}
|
71
78
|
|
72
79
|
/**
|
@@ -75,7 +82,7 @@ function *iterateCharacterSequence(nodes) {
|
|
75
82
|
* @returns {boolean} `true` if the character node is a Unicode code point escape.
|
76
83
|
*/
|
77
84
|
function isUnicodeCodePointEscape(char) {
|
78
|
-
|
85
|
+
return /^\\u\{[\da-f]+\}$/iu.test(char.raw);
|
79
86
|
}
|
80
87
|
|
81
88
|
/**
|
@@ -83,115 +90,119 @@ function isUnicodeCodePointEscape(char) {
|
|
83
90
|
* @type {Record<string, (chars: Character[]) => IterableIterator<Character[]>>}
|
84
91
|
*/
|
85
92
|
const findCharacterSequences = {
|
86
|
-
|
87
|
-
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
|
93
|
-
|
94
|
-
|
95
|
-
|
96
|
-
|
97
|
-
|
98
|
-
|
99
|
-
|
100
|
-
|
101
|
-
|
102
|
-
|
103
|
-
|
104
|
-
|
105
|
-
|
106
|
-
|
107
|
-
|
108
|
-
|
109
|
-
|
110
|
-
|
111
|
-
|
112
|
-
|
113
|
-
|
114
|
-
|
115
|
-
|
116
|
-
|
117
|
-
|
118
|
-
|
119
|
-
|
120
|
-
|
121
|
-
|
122
|
-
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
131
|
-
|
132
|
-
|
133
|
-
|
134
|
-
|
135
|
-
|
136
|
-
|
137
|
-
|
138
|
-
|
139
|
-
|
140
|
-
|
141
|
-
|
142
|
-
|
143
|
-
|
144
|
-
|
145
|
-
|
146
|
-
|
147
|
-
|
148
|
-
|
149
|
-
|
150
|
-
|
151
|
-
|
152
|
-
|
153
|
-
|
154
|
-
|
155
|
-
|
156
|
-
|
157
|
-
|
158
|
-
|
159
|
-
|
160
|
-
|
161
|
-
|
162
|
-
|
163
|
-
|
164
|
-
|
165
|
-
|
166
|
-
|
167
|
-
|
168
|
-
|
169
|
-
|
170
|
-
|
171
|
-
|
172
|
-
|
173
|
-
|
174
|
-
|
175
|
-
|
176
|
-
|
177
|
-
|
178
|
-
|
179
|
-
|
180
|
-
|
181
|
-
|
182
|
-
|
183
|
-
|
184
|
-
|
185
|
-
|
186
|
-
|
187
|
-
|
188
|
-
|
189
|
-
|
190
|
-
|
191
|
-
|
192
|
-
|
193
|
-
|
194
|
-
|
93
|
+
*surrogatePairWithoutUFlag(chars) {
|
94
|
+
for (const [index, char] of chars.entries()) {
|
95
|
+
const previous = chars[index - 1];
|
96
|
+
|
97
|
+
if (
|
98
|
+
previous &&
|
99
|
+
char &&
|
100
|
+
isSurrogatePair(previous.value, char.value) &&
|
101
|
+
!isUnicodeCodePointEscape(previous) &&
|
102
|
+
!isUnicodeCodePointEscape(char)
|
103
|
+
) {
|
104
|
+
yield [previous, char];
|
105
|
+
}
|
106
|
+
}
|
107
|
+
},
|
108
|
+
|
109
|
+
*surrogatePair(chars) {
|
110
|
+
for (const [index, char] of chars.entries()) {
|
111
|
+
const previous = chars[index - 1];
|
112
|
+
|
113
|
+
if (
|
114
|
+
previous &&
|
115
|
+
char &&
|
116
|
+
isSurrogatePair(previous.value, char.value) &&
|
117
|
+
(isUnicodeCodePointEscape(previous) ||
|
118
|
+
isUnicodeCodePointEscape(char))
|
119
|
+
) {
|
120
|
+
yield [previous, char];
|
121
|
+
}
|
122
|
+
}
|
123
|
+
},
|
124
|
+
|
125
|
+
*combiningClass(chars, unfilteredChars) {
|
126
|
+
/*
|
127
|
+
* When `allowEscape` is `true`, a combined character should only be allowed if the combining mark appears as an escape sequence.
|
128
|
+
* This means that the base character should be considered even if it's escaped.
|
129
|
+
*/
|
130
|
+
for (const [index, char] of chars.entries()) {
|
131
|
+
const previous = unfilteredChars[index - 1];
|
132
|
+
|
133
|
+
if (
|
134
|
+
previous &&
|
135
|
+
char &&
|
136
|
+
isCombiningCharacter(char.value) &&
|
137
|
+
!isCombiningCharacter(previous.value)
|
138
|
+
) {
|
139
|
+
yield [previous, char];
|
140
|
+
}
|
141
|
+
}
|
142
|
+
},
|
143
|
+
|
144
|
+
*emojiModifier(chars) {
|
145
|
+
for (const [index, char] of chars.entries()) {
|
146
|
+
const previous = chars[index - 1];
|
147
|
+
|
148
|
+
if (
|
149
|
+
previous &&
|
150
|
+
char &&
|
151
|
+
isEmojiModifier(char.value) &&
|
152
|
+
!isEmojiModifier(previous.value)
|
153
|
+
) {
|
154
|
+
yield [previous, char];
|
155
|
+
}
|
156
|
+
}
|
157
|
+
},
|
158
|
+
|
159
|
+
*regionalIndicatorSymbol(chars) {
|
160
|
+
for (const [index, char] of chars.entries()) {
|
161
|
+
const previous = chars[index - 1];
|
162
|
+
|
163
|
+
if (
|
164
|
+
previous &&
|
165
|
+
char &&
|
166
|
+
isRegionalIndicatorSymbol(char.value) &&
|
167
|
+
isRegionalIndicatorSymbol(previous.value)
|
168
|
+
) {
|
169
|
+
yield [previous, char];
|
170
|
+
}
|
171
|
+
}
|
172
|
+
},
|
173
|
+
|
174
|
+
*zwj(chars) {
|
175
|
+
let sequence = null;
|
176
|
+
|
177
|
+
for (const [index, char] of chars.entries()) {
|
178
|
+
const previous = chars[index - 1];
|
179
|
+
const next = chars[index + 1];
|
180
|
+
|
181
|
+
if (
|
182
|
+
previous &&
|
183
|
+
char &&
|
184
|
+
next &&
|
185
|
+
char.value === 0x200d &&
|
186
|
+
previous.value !== 0x200d &&
|
187
|
+
next.value !== 0x200d
|
188
|
+
) {
|
189
|
+
if (sequence) {
|
190
|
+
if (sequence.at(-1) === previous) {
|
191
|
+
sequence.push(char, next); // append to the sequence
|
192
|
+
} else {
|
193
|
+
yield sequence;
|
194
|
+
sequence = chars.slice(index - 1, index + 2);
|
195
|
+
}
|
196
|
+
} else {
|
197
|
+
sequence = chars.slice(index - 1, index + 2);
|
198
|
+
}
|
199
|
+
}
|
200
|
+
}
|
201
|
+
|
202
|
+
if (sequence) {
|
203
|
+
yield sequence;
|
204
|
+
}
|
205
|
+
},
|
195
206
|
};
|
196
207
|
|
197
208
|
const kinds = Object.keys(findCharacterSequences);
|
@@ -208,19 +219,19 @@ const kinds = Object.keys(findCharacterSequences);
|
|
208
219
|
* @returns {{ value: any } | { regex: { pattern: string, flags: string } } | null} The static value of the node, or `null`.
|
209
220
|
*/
|
210
221
|
function getStaticValueOrRegex(node, initialScope) {
|
211
|
-
|
212
|
-
|
213
|
-
|
214
|
-
|
215
|
-
|
216
|
-
|
217
|
-
|
218
|
-
|
219
|
-
|
220
|
-
|
221
|
-
|
222
|
-
|
223
|
-
|
222
|
+
if (!node) {
|
223
|
+
return null;
|
224
|
+
}
|
225
|
+
if (node.type === "Literal" && node.regex) {
|
226
|
+
return { regex: node.regex };
|
227
|
+
}
|
228
|
+
|
229
|
+
const staticValue = getStaticValue(node, initialScope);
|
230
|
+
|
231
|
+
if (staticValue?.value instanceof RegExp) {
|
232
|
+
return null;
|
233
|
+
}
|
234
|
+
return staticValue;
|
224
235
|
}
|
225
236
|
|
226
237
|
/**
|
@@ -231,12 +242,12 @@ function getStaticValueOrRegex(node, initialScope) {
|
|
231
242
|
* @returns {boolean} Whether the specified regexpp character is represented as an acceptable escape sequence.
|
232
243
|
*/
|
233
244
|
function checkForAcceptableEscape(char, charSource) {
|
234
|
-
|
235
|
-
|
236
|
-
|
237
|
-
|
245
|
+
if (!charSource.startsWith("\\")) {
|
246
|
+
return false;
|
247
|
+
}
|
248
|
+
const match = /(?<=^\\+).$/su.exec(charSource);
|
238
249
|
|
239
|
-
|
250
|
+
return match?.[0] !== String.fromCodePoint(char.value);
|
240
251
|
}
|
241
252
|
|
242
253
|
/**
|
@@ -249,13 +260,13 @@ function checkForAcceptableEscape(char, charSource) {
|
|
249
260
|
* @returns {boolean} Whether the specified regexpp character is represented as an acceptable escape sequence.
|
250
261
|
*/
|
251
262
|
function checkForAcceptableEscapeInString(char, nodeSource, codeUnits) {
|
252
|
-
|
253
|
-
|
254
|
-
|
255
|
-
|
256
|
-
|
263
|
+
const firstIndex = char.start;
|
264
|
+
const lastIndex = char.end - 1;
|
265
|
+
const start = codeUnits[firstIndex].start;
|
266
|
+
const end = codeUnits[lastIndex].end;
|
267
|
+
const charSource = nodeSource.slice(start, end);
|
257
268
|
|
258
|
-
|
269
|
+
return checkForAcceptableEscape(char, charSource);
|
259
270
|
}
|
260
271
|
|
261
272
|
//------------------------------------------------------------------------------
|
@@ -264,274 +275,316 @@ function checkForAcceptableEscapeInString(char, nodeSource, codeUnits) {
|
|
264
275
|
|
265
276
|
/** @type {import('../shared/types').Rule} */
|
266
277
|
module.exports = {
|
267
|
-
|
268
|
-
|
269
|
-
|
270
|
-
|
271
|
-
|
272
|
-
|
273
|
-
|
274
|
-
|
275
|
-
|
276
|
-
|
277
|
-
|
278
|
-
|
279
|
-
|
280
|
-
|
281
|
-
|
282
|
-
|
283
|
-
|
284
|
-
|
285
|
-
|
286
|
-
|
287
|
-
|
288
|
-
|
289
|
-
|
290
|
-
|
291
|
-
|
292
|
-
|
293
|
-
|
294
|
-
|
295
|
-
|
296
|
-
|
297
|
-
|
298
|
-
|
299
|
-
|
300
|
-
|
301
|
-
|
302
|
-
|
303
|
-
|
304
|
-
|
305
|
-
|
306
|
-
|
307
|
-
|
308
|
-
|
309
|
-
|
310
|
-
|
311
|
-
|
312
|
-
|
313
|
-
|
314
|
-
|
315
|
-
|
316
|
-
|
317
|
-
|
318
|
-
|
319
|
-
|
320
|
-
|
321
|
-
|
322
|
-
|
323
|
-
|
324
|
-
|
325
|
-
|
326
|
-
|
327
|
-
|
328
|
-
|
329
|
-
|
330
|
-
|
331
|
-
|
332
|
-
|
333
|
-
|
334
|
-
|
335
|
-
|
336
|
-
|
337
|
-
|
338
|
-
|
339
|
-
|
340
|
-
|
341
|
-
|
342
|
-
|
343
|
-
|
344
|
-
|
345
|
-
|
346
|
-
|
347
|
-
|
348
|
-
|
349
|
-
|
350
|
-
|
351
|
-
|
352
|
-
|
353
|
-
|
354
|
-
|
355
|
-
|
356
|
-
|
357
|
-
|
358
|
-
|
359
|
-
|
360
|
-
|
361
|
-
|
362
|
-
|
363
|
-
|
364
|
-
|
365
|
-
|
366
|
-
|
367
|
-
|
368
|
-
|
369
|
-
|
370
|
-
|
371
|
-
|
372
|
-
|
373
|
-
|
374
|
-
|
375
|
-
|
376
|
-
|
377
|
-
|
378
|
-
|
379
|
-
|
380
|
-
|
381
|
-
|
382
|
-
|
383
|
-
|
384
|
-
|
385
|
-
|
386
|
-
|
387
|
-
|
388
|
-
|
389
|
-
|
390
|
-
|
391
|
-
|
392
|
-
|
393
|
-
|
394
|
-
|
395
|
-
|
396
|
-
|
397
|
-
|
398
|
-
|
399
|
-
|
400
|
-
|
401
|
-
|
402
|
-
|
403
|
-
|
404
|
-
|
405
|
-
|
406
|
-
|
407
|
-
|
408
|
-
|
409
|
-
|
410
|
-
|
411
|
-
|
412
|
-
|
413
|
-
|
414
|
-
|
415
|
-
|
416
|
-
|
417
|
-
|
418
|
-
|
419
|
-
|
420
|
-
|
421
|
-
|
422
|
-
|
423
|
-
|
424
|
-
|
425
|
-
|
426
|
-
|
427
|
-
|
428
|
-
|
429
|
-
|
430
|
-
|
431
|
-
|
432
|
-
|
433
|
-
|
434
|
-
|
435
|
-
|
436
|
-
|
437
|
-
|
438
|
-
|
439
|
-
|
440
|
-
|
441
|
-
|
442
|
-
|
443
|
-
|
444
|
-
|
445
|
-
|
446
|
-
|
447
|
-
|
448
|
-
|
449
|
-
|
450
|
-
|
451
|
-
|
452
|
-
|
453
|
-
|
454
|
-
|
455
|
-
|
456
|
-
|
457
|
-
|
458
|
-
|
459
|
-
|
460
|
-
|
461
|
-
|
462
|
-
|
463
|
-
|
464
|
-
|
465
|
-
|
466
|
-
|
467
|
-
|
468
|
-
|
469
|
-
|
470
|
-
|
471
|
-
|
472
|
-
|
473
|
-
|
474
|
-
|
475
|
-
|
476
|
-
|
477
|
-
|
478
|
-
|
479
|
-
|
480
|
-
|
481
|
-
|
482
|
-
|
483
|
-
|
484
|
-
|
485
|
-
|
486
|
-
|
487
|
-
|
488
|
-
|
489
|
-
|
490
|
-
|
491
|
-
|
492
|
-
|
493
|
-
|
494
|
-
|
495
|
-
|
496
|
-
|
497
|
-
|
498
|
-
|
499
|
-
|
500
|
-
|
501
|
-
|
502
|
-
|
503
|
-
|
504
|
-
|
505
|
-
|
506
|
-
|
507
|
-
|
508
|
-
|
509
|
-
|
510
|
-
|
511
|
-
|
512
|
-
|
513
|
-
|
514
|
-
|
515
|
-
|
516
|
-
|
517
|
-
|
518
|
-
|
519
|
-
|
520
|
-
|
521
|
-
|
522
|
-
|
523
|
-
|
524
|
-
|
525
|
-
|
526
|
-
|
527
|
-
|
528
|
-
|
529
|
-
|
530
|
-
|
531
|
-
|
532
|
-
|
533
|
-
|
534
|
-
|
535
|
-
|
536
|
-
|
278
|
+
meta: {
|
279
|
+
type: "problem",
|
280
|
+
|
281
|
+
docs: {
|
282
|
+
description:
|
283
|
+
"Disallow characters which are made with multiple code points in character class syntax",
|
284
|
+
recommended: true,
|
285
|
+
url: "https://eslint.org/docs/latest/rules/no-misleading-character-class",
|
286
|
+
},
|
287
|
+
|
288
|
+
hasSuggestions: true,
|
289
|
+
|
290
|
+
schema: [
|
291
|
+
{
|
292
|
+
type: "object",
|
293
|
+
properties: {
|
294
|
+
allowEscape: {
|
295
|
+
type: "boolean",
|
296
|
+
default: false,
|
297
|
+
},
|
298
|
+
},
|
299
|
+
additionalProperties: false,
|
300
|
+
},
|
301
|
+
],
|
302
|
+
|
303
|
+
messages: {
|
304
|
+
surrogatePairWithoutUFlag:
|
305
|
+
"Unexpected surrogate pair in character class. Use 'u' flag.",
|
306
|
+
surrogatePair: "Unexpected surrogate pair in character class.",
|
307
|
+
combiningClass: "Unexpected combined character in character class.",
|
308
|
+
emojiModifier: "Unexpected modified Emoji in character class.",
|
309
|
+
regionalIndicatorSymbol:
|
310
|
+
"Unexpected national flag in character class.",
|
311
|
+
zwj: "Unexpected joined character sequence in character class.",
|
312
|
+
suggestUnicodeFlag: "Add unicode 'u' flag to regex.",
|
313
|
+
},
|
314
|
+
},
|
315
|
+
create(context) {
|
316
|
+
const allowEscape = context.options[0]?.allowEscape;
|
317
|
+
const sourceCode = context.sourceCode;
|
318
|
+
const parser = new RegExpParser();
|
319
|
+
const checkedPatternNodes = new Set();
|
320
|
+
|
321
|
+
/**
|
322
|
+
* Verify a given regular expression.
|
323
|
+
* @param {Node} node The node to report.
|
324
|
+
* @param {string} pattern The regular expression pattern to verify.
|
325
|
+
* @param {string} flags The flags of the regular expression.
|
326
|
+
* @param {Function} unicodeFixer Fixer for missing "u" flag.
|
327
|
+
* @returns {void}
|
328
|
+
*/
|
329
|
+
function verify(node, pattern, flags, unicodeFixer) {
|
330
|
+
let patternNode;
|
331
|
+
|
332
|
+
try {
|
333
|
+
patternNode = parser.parsePattern(pattern, 0, pattern.length, {
|
334
|
+
unicode: flags.includes("u"),
|
335
|
+
unicodeSets: flags.includes("v"),
|
336
|
+
});
|
337
|
+
} catch {
|
338
|
+
// Ignore regular expressions with syntax errors
|
339
|
+
return;
|
340
|
+
}
|
341
|
+
|
342
|
+
let codeUnits = null;
|
343
|
+
|
344
|
+
/**
|
345
|
+
* Checks whether a specified regexpp character is represented as an acceptable escape sequence.
|
346
|
+
* For the purposes of this rule, an escape sequence is considered acceptable if it consists of one or more backslashes followed by the character being escaped.
|
347
|
+
* @param {Character} char Character to check.
|
348
|
+
* @returns {boolean} Whether the specified regexpp character is represented as an acceptable escape sequence.
|
349
|
+
*/
|
350
|
+
function isAcceptableEscapeSequence(char) {
|
351
|
+
if (node.type === "Literal" && node.regex) {
|
352
|
+
return checkForAcceptableEscape(char, char.raw);
|
353
|
+
}
|
354
|
+
if (node.type === "Literal" && typeof node.value === "string") {
|
355
|
+
const nodeSource = node.raw;
|
356
|
+
|
357
|
+
codeUnits ??= parseStringLiteral(nodeSource);
|
358
|
+
|
359
|
+
return checkForAcceptableEscapeInString(
|
360
|
+
char,
|
361
|
+
nodeSource,
|
362
|
+
codeUnits,
|
363
|
+
);
|
364
|
+
}
|
365
|
+
if (astUtils.isStaticTemplateLiteral(node)) {
|
366
|
+
const nodeSource = sourceCode.getText(node);
|
367
|
+
|
368
|
+
codeUnits ??= parseTemplateToken(nodeSource);
|
369
|
+
|
370
|
+
return checkForAcceptableEscapeInString(
|
371
|
+
char,
|
372
|
+
nodeSource,
|
373
|
+
codeUnits,
|
374
|
+
);
|
375
|
+
}
|
376
|
+
return false;
|
377
|
+
}
|
378
|
+
|
379
|
+
const foundKindMatches = new Map();
|
380
|
+
|
381
|
+
visitRegExpAST(patternNode, {
|
382
|
+
onCharacterClassEnter(ccNode) {
|
383
|
+
for (const unfilteredChars of iterateCharacterSequence(
|
384
|
+
ccNode.elements,
|
385
|
+
)) {
|
386
|
+
let chars;
|
387
|
+
|
388
|
+
if (allowEscape) {
|
389
|
+
// Replace escape sequences with null to avoid having them flagged.
|
390
|
+
chars = unfilteredChars.map(char =>
|
391
|
+
isAcceptableEscapeSequence(char) ? null : char,
|
392
|
+
);
|
393
|
+
} else {
|
394
|
+
chars = unfilteredChars;
|
395
|
+
}
|
396
|
+
for (const kind of kinds) {
|
397
|
+
const matches = findCharacterSequences[kind](
|
398
|
+
chars,
|
399
|
+
unfilteredChars,
|
400
|
+
);
|
401
|
+
|
402
|
+
if (foundKindMatches.has(kind)) {
|
403
|
+
foundKindMatches.get(kind).push(...matches);
|
404
|
+
} else {
|
405
|
+
foundKindMatches.set(kind, [...matches]);
|
406
|
+
}
|
407
|
+
}
|
408
|
+
}
|
409
|
+
},
|
410
|
+
});
|
411
|
+
|
412
|
+
/**
|
413
|
+
* Finds the report loc(s) for a range of matches.
|
414
|
+
* Only literals and expression-less templates generate granular errors.
|
415
|
+
* @param {Character[][]} matches Lists of individual characters being reported on.
|
416
|
+
* @returns {Location[]} locs for context.report.
|
417
|
+
* @see https://github.com/eslint/eslint/pull/17515
|
418
|
+
*/
|
419
|
+
function getNodeReportLocations(matches) {
|
420
|
+
if (
|
421
|
+
!astUtils.isStaticTemplateLiteral(node) &&
|
422
|
+
node.type !== "Literal"
|
423
|
+
) {
|
424
|
+
return matches.length ? [node.loc] : [];
|
425
|
+
}
|
426
|
+
return matches.map(chars => {
|
427
|
+
const firstIndex = chars[0].start;
|
428
|
+
const lastIndex = chars.at(-1).end - 1;
|
429
|
+
let start;
|
430
|
+
let end;
|
431
|
+
|
432
|
+
if (node.type === "TemplateLiteral") {
|
433
|
+
const source = sourceCode.getText(node);
|
434
|
+
const offset = node.range[0];
|
435
|
+
|
436
|
+
codeUnits ??= parseTemplateToken(source);
|
437
|
+
start = offset + codeUnits[firstIndex].start;
|
438
|
+
end = offset + codeUnits[lastIndex].end;
|
439
|
+
} else if (typeof node.value === "string") {
|
440
|
+
// String Literal
|
441
|
+
const source = node.raw;
|
442
|
+
const offset = node.range[0];
|
443
|
+
|
444
|
+
codeUnits ??= parseStringLiteral(source);
|
445
|
+
start = offset + codeUnits[firstIndex].start;
|
446
|
+
end = offset + codeUnits[lastIndex].end;
|
447
|
+
} else {
|
448
|
+
// RegExp Literal
|
449
|
+
const offset = node.range[0] + 1; // Add 1 to skip the leading slash.
|
450
|
+
|
451
|
+
start = offset + firstIndex;
|
452
|
+
end = offset + lastIndex + 1;
|
453
|
+
}
|
454
|
+
|
455
|
+
return {
|
456
|
+
start: sourceCode.getLocFromIndex(start),
|
457
|
+
end: sourceCode.getLocFromIndex(end),
|
458
|
+
};
|
459
|
+
});
|
460
|
+
}
|
461
|
+
|
462
|
+
for (const [kind, matches] of foundKindMatches) {
|
463
|
+
let suggest;
|
464
|
+
|
465
|
+
if (kind === "surrogatePairWithoutUFlag") {
|
466
|
+
suggest = [
|
467
|
+
{
|
468
|
+
messageId: "suggestUnicodeFlag",
|
469
|
+
fix: unicodeFixer,
|
470
|
+
},
|
471
|
+
];
|
472
|
+
}
|
473
|
+
|
474
|
+
const locs = getNodeReportLocations(matches);
|
475
|
+
|
476
|
+
for (const loc of locs) {
|
477
|
+
context.report({
|
478
|
+
node,
|
479
|
+
loc,
|
480
|
+
messageId: kind,
|
481
|
+
suggest,
|
482
|
+
});
|
483
|
+
}
|
484
|
+
}
|
485
|
+
}
|
486
|
+
|
487
|
+
return {
|
488
|
+
"Literal[regex]"(node) {
|
489
|
+
if (checkedPatternNodes.has(node)) {
|
490
|
+
return;
|
491
|
+
}
|
492
|
+
verify(node, node.regex.pattern, node.regex.flags, fixer => {
|
493
|
+
if (
|
494
|
+
!isValidWithUnicodeFlag(
|
495
|
+
context.languageOptions.ecmaVersion,
|
496
|
+
node.regex.pattern,
|
497
|
+
)
|
498
|
+
) {
|
499
|
+
return null;
|
500
|
+
}
|
501
|
+
|
502
|
+
return fixer.insertTextAfter(node, "u");
|
503
|
+
});
|
504
|
+
},
|
505
|
+
Program(node) {
|
506
|
+
const scope = sourceCode.getScope(node);
|
507
|
+
const tracker = new ReferenceTracker(scope);
|
508
|
+
|
509
|
+
/*
|
510
|
+
* Iterate calls of RegExp.
|
511
|
+
* E.g., `new RegExp()`, `RegExp()`, `new window.RegExp()`,
|
512
|
+
* `const {RegExp: a} = window; new a()`, etc...
|
513
|
+
*/
|
514
|
+
for (const { node: refNode } of tracker.iterateGlobalReferences(
|
515
|
+
{
|
516
|
+
RegExp: { [CALL]: true, [CONSTRUCT]: true },
|
517
|
+
},
|
518
|
+
)) {
|
519
|
+
let pattern, flags;
|
520
|
+
const [patternNode, flagsNode] = refNode.arguments;
|
521
|
+
const evaluatedPattern = getStaticValueOrRegex(
|
522
|
+
patternNode,
|
523
|
+
scope,
|
524
|
+
);
|
525
|
+
|
526
|
+
if (!evaluatedPattern) {
|
527
|
+
continue;
|
528
|
+
}
|
529
|
+
if (flagsNode) {
|
530
|
+
if (evaluatedPattern.regex) {
|
531
|
+
pattern = evaluatedPattern.regex.pattern;
|
532
|
+
checkedPatternNodes.add(patternNode);
|
533
|
+
} else {
|
534
|
+
pattern = String(evaluatedPattern.value);
|
535
|
+
}
|
536
|
+
flags = getStringIfConstant(flagsNode, scope);
|
537
|
+
} else {
|
538
|
+
if (evaluatedPattern.regex) {
|
539
|
+
continue;
|
540
|
+
}
|
541
|
+
pattern = String(evaluatedPattern.value);
|
542
|
+
flags = "";
|
543
|
+
}
|
544
|
+
|
545
|
+
if (typeof flags === "string") {
|
546
|
+
verify(patternNode, pattern, flags, fixer => {
|
547
|
+
if (
|
548
|
+
!isValidWithUnicodeFlag(
|
549
|
+
context.languageOptions.ecmaVersion,
|
550
|
+
pattern,
|
551
|
+
)
|
552
|
+
) {
|
553
|
+
return null;
|
554
|
+
}
|
555
|
+
|
556
|
+
if (refNode.arguments.length === 1) {
|
557
|
+
const penultimateToken =
|
558
|
+
sourceCode.getLastToken(refNode, {
|
559
|
+
skip: 1,
|
560
|
+
}); // skip closing parenthesis
|
561
|
+
|
562
|
+
return fixer.insertTextAfter(
|
563
|
+
penultimateToken,
|
564
|
+
astUtils.isCommaToken(penultimateToken)
|
565
|
+
? ' "u",'
|
566
|
+
: ', "u"',
|
567
|
+
);
|
568
|
+
}
|
569
|
+
|
570
|
+
if (
|
571
|
+
(flagsNode.type === "Literal" &&
|
572
|
+
typeof flagsNode.value === "string") ||
|
573
|
+
flagsNode.type === "TemplateLiteral"
|
574
|
+
) {
|
575
|
+
const range = [
|
576
|
+
flagsNode.range[0],
|
577
|
+
flagsNode.range[1] - 1,
|
578
|
+
];
|
579
|
+
|
580
|
+
return fixer.insertTextAfterRange(range, "u");
|
581
|
+
}
|
582
|
+
|
583
|
+
return null;
|
584
|
+
});
|
585
|
+
}
|
586
|
+
}
|
587
|
+
},
|
588
|
+
};
|
589
|
+
},
|
537
590
|
};
|