eslint 8.39.0 → 8.41.0

package/lib/rules/dot-location.js

@@ -19,7 +19,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent newlines before and after dots",
             recommended: false,
-            url: "https://eslint.org/docs/rules/dot-location"
+            url: "https://eslint.org/docs/latest/rules/dot-location"
         },
 
         schema: [
@@ -43,7 +43,7 @@ module.exports = {
         // default to onObject if no preference is passed
         const onObject = config === "object" || !config;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports if the dot between object and property is on the correct location.

package/lib/rules/dot-notation.js

@@ -28,7 +28,7 @@ module.exports = {
         docs: {
             description: "Enforce dot notation whenever possible",
             recommended: false,
-            url: "https://eslint.org/docs/rules/dot-notation"
+            url: "https://eslint.org/docs/latest/rules/dot-notation"
         },
 
         schema: [
@@ -59,7 +59,7 @@ module.exports = {
     create(context) {
         const options = context.options[0] || {};
         const allowKeywords = options.allowKeywords === void 0 || options.allowKeywords;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let allowPattern;
 

package/lib/rules/eol-last.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Require or disallow newline at the end of files",
             recommended: false,
-            url: "https://eslint.org/docs/rules/eol-last"
+            url: "https://eslint.org/docs/latest/rules/eol-last"
         },
 
         fixable: "whitespace",
@@ -40,7 +40,7 @@ module.exports = {
 
         return {
             Program: function checkBadEOF(node) {
-                const sourceCode = context.getSourceCode(),
+                const sourceCode = context.sourceCode,
                     src = sourceCode.getText(),
                     lastLine = sourceCode.lines[sourceCode.lines.length - 1],
                     location = {

package/lib/rules/eqeqeq.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Require the use of `===` and `!==`",
             recommended: false,
-            url: "https://eslint.org/docs/rules/eqeqeq"
+            url: "https://eslint.org/docs/latest/rules/eqeqeq"
         },
 
         schema: {
@@ -68,7 +68,7 @@ module.exports = {
     create(context) {
         const config = context.options[0] || "always";
         const options = context.options[1] || {};
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const nullOption = (config === "always")
             ? options.null || "always"

package/lib/rules/for-direction.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Enforce \"for\" loop update clause moving the counter in the right direction",
             recommended: true,
-            url: "https://eslint.org/docs/rules/for-direction"
+            url: "https://eslint.org/docs/latest/rules/for-direction"
         },
 
         fixable: null,

package/lib/rules/func-call-spacing.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Require or disallow spacing between function identifiers and their invocations",
             recommended: false,
-            url: "https://eslint.org/docs/rules/func-call-spacing"
+            url: "https://eslint.org/docs/latest/rules/func-call-spacing"
         },
 
         fixable: "whitespace",
@@ -73,7 +73,7 @@ module.exports = {
 
         const never = context.options[0] !== "always";
         const allowNewlines = !never && context.options[1] && context.options[1].allowNewlines;
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const text = sourceCode.getText();
 
         /**

package/lib/rules/func-name-matching.js

@@ -76,7 +76,7 @@ module.exports = {
         docs: {
             description: "Require function names to match the name of the variable or property to which they are assigned",
             recommended: false,
-            url: "https://eslint.org/docs/rules/func-name-matching"
+            url: "https://eslint.org/docs/latest/rules/func-name-matching"
         },
 
         schema: {

package/lib/rules/func-names.js

@@ -32,7 +32,7 @@ module.exports = {
         docs: {
             description: "Require or disallow named `function` expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/func-names"
+            url: "https://eslint.org/docs/latest/rules/func-names"
         },
 
         schema: {
@@ -69,7 +69,7 @@ module.exports = {
 
     create(context) {
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Returns the config option for the given node.

package/lib/rules/func-style.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Enforce the consistent use of either `function` declarations or expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/func-style"
+            url: "https://eslint.org/docs/latest/rules/func-style"
         },
 
         schema: [

package/lib/rules/function-call-argument-newline.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Enforce line breaks between arguments of a function call",
             recommended: false,
-            url: "https://eslint.org/docs/rules/function-call-argument-newline"
+            url: "https://eslint.org/docs/latest/rules/function-call-argument-newline"
         },
 
         fixable: "whitespace",
@@ -35,7 +35,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const checkers = {
             unexpected: {

package/lib/rules/function-paren-newline.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent line breaks inside function parentheses",
             recommended: false,
-            url: "https://eslint.org/docs/rules/function-paren-newline"
+            url: "https://eslint.org/docs/latest/rules/function-paren-newline"
         },
 
         fixable: "whitespace",
@@ -57,7 +57,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const rawOption = context.options[0] || "multiline";
         const multilineOption = rawOption === "multiline";
         const multilineArgumentsOption = rawOption === "multiline-arguments";

package/lib/rules/generator-star-spacing.js

@@ -33,7 +33,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent spacing around `*` operators in generator functions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/generator-star-spacing"
+            url: "https://eslint.org/docs/latest/rules/generator-star-spacing"
         },
 
         fixable: "whitespace",
@@ -102,7 +102,7 @@ module.exports = {
             };
         }(context.options[0] || {}));
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks if the given token is a star token or not.

package/lib/rules/getter-return.js

@@ -37,7 +37,7 @@ module.exports = {
         docs: {
             description: "Enforce `return` statements in getters",
             recommended: true,
-            url: "https://eslint.org/docs/rules/getter-return"
+            url: "https://eslint.org/docs/latest/rules/getter-return"
         },
 
         fixable: null,
@@ -64,7 +64,7 @@ module.exports = {
     create(context) {
 
         const options = context.options[0] || { allowImplicit: false };
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let funcInfo = {
             upper: null,

package/lib/rules/global-require.js

@@ -61,7 +61,7 @@ module.exports = {
         docs: {
             description: "Require `require()` calls to be placed at top-level module scope",
             recommended: false,
-            url: "https://eslint.org/docs/rules/global-require"
+            url: "https://eslint.org/docs/latest/rules/global-require"
         },
 
         schema: [],
@@ -71,7 +71,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
             CallExpression(node) {

package/lib/rules/grouped-accessor-pairs.js

@@ -98,7 +98,7 @@ module.exports = {
         docs: {
             description: "Require grouped accessor pairs in object literals and classes",
             recommended: false,
-            url: "https://eslint.org/docs/rules/grouped-accessor-pairs"
+            url: "https://eslint.org/docs/latest/rules/grouped-accessor-pairs"
         },
 
         schema: [
@@ -115,7 +115,7 @@ module.exports = {
 
     create(context) {
         const order = context.options[0] || "anyOrder";
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Reports the given accessor pair.

package/lib/rules/guard-for-in.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require `for-in` loops to include an `if` statement",
             recommended: false,
-            url: "https://eslint.org/docs/rules/guard-for-in"
+            url: "https://eslint.org/docs/latest/rules/guard-for-in"
         },
 
         schema: [],

package/lib/rules/handle-callback-err.js

@@ -22,7 +22,7 @@ module.exports = {
         docs: {
             description: "Require error handling in callbacks",
             recommended: false,
-            url: "https://eslint.org/docs/rules/handle-callback-err"
+            url: "https://eslint.org/docs/latest/rules/handle-callback-err"
         },
 
         schema: [
@@ -38,7 +38,7 @@ module.exports = {
     create(context) {
 
         const errorArgument = context.options[0] || "err";
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Checks if the given argument should be interpreted as a regexp pattern.

package/lib/rules/id-blacklist.js

@@ -121,7 +121,7 @@ module.exports = {
         docs: {
             description: "Disallow specified identifiers",
             recommended: false,
-            url: "https://eslint.org/docs/rules/id-blacklist"
+            url: "https://eslint.org/docs/latest/rules/id-blacklist"
         },
 
         schema: {
@@ -140,7 +140,7 @@ module.exports = {
 
         const denyList = new Set(context.options);
         const reportedNodes = new Set();
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let globalScope;
 

package/lib/rules/id-denylist.js

@@ -101,7 +101,7 @@ module.exports = {
         docs: {
             description: "Disallow specified identifiers",
             recommended: false,
-            url: "https://eslint.org/docs/rules/id-denylist"
+            url: "https://eslint.org/docs/latest/rules/id-denylist"
         },
 
         schema: {
@@ -121,7 +121,7 @@ module.exports = {
 
         const denyList = new Set(context.options);
         const reportedNodes = new Set();
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         let globalScope;
 

package/lib/rules/id-length.js

@@ -9,41 +9,8 @@
 //------------------------------------------------------------------------------
 // Requirements
 //------------------------------------------------------------------------------
-const GraphemeSplitter = require("grapheme-splitter");
 
-//------------------------------------------------------------------------------
-// Helpers
-//------------------------------------------------------------------------------
-
-/**
- * Checks if the string given as argument is ASCII or not.
- * @param {string} value A string that you want to know if it is ASCII or not.
- * @returns {boolean} `true` if `value` is ASCII string.
- */
-function isASCII(value) {
-    if (typeof value !== "string") {
-        return false;
-    }
-    return /^[\u0020-\u007f]*$/u.test(value);
-}
-
-/** @type {GraphemeSplitter | undefined} */
-let splitter;
-
-/**
- * Gets the length of the string. If the string is not in ASCII, counts graphemes.
- * @param {string} value A string that you want to get the length.
- * @returns {number} The length of `value`.
- */
-function getStringLength(value) {
-    if (isASCII(value)) {
-        return value.length;
-    }
-    if (!splitter) {
-        splitter = new GraphemeSplitter();
-    }
-    return splitter.countGraphemes(value);
-}
+const { getGraphemeCount } = require("../shared/string-utils");
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -57,7 +24,7 @@ module.exports = {
         docs: {
             description: "Enforce minimum and maximum identifier lengths",
             recommended: false,
-            url: "https://eslint.org/docs/rules/id-length"
+            url: "https://eslint.org/docs/latest/rules/id-length"
         },
 
         schema: [
@@ -169,7 +136,7 @@ module.exports = {
                 const name = node.name;
                 const parent = node.parent;
 
-                const nameLength = getStringLength(name);
+                const nameLength = getGraphemeCount(name);
 
                 const isShort = nameLength < minLength;
                 const isLong = nameLength > maxLength;

package/lib/rules/id-match.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require identifiers to match a specified regular expression",
             recommended: false,
-            url: "https://eslint.org/docs/rules/id-match"
+            url: "https://eslint.org/docs/latest/rules/id-match"
         },
 
         schema: [
@@ -67,7 +67,7 @@ module.exports = {
             onlyDeclarations = !!options.onlyDeclarations,
             ignoreDestructuring = !!options.ignoreDestructuring;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         let globalScope;
 
         //--------------------------------------------------------------------------

package/lib/rules/implicit-arrow-linebreak.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Enforce the location of arrow function bodies",
             recommended: false,
-            url: "https://eslint.org/docs/rules/implicit-arrow-linebreak"
+            url: "https://eslint.org/docs/latest/rules/implicit-arrow-linebreak"
         },
 
         fixable: "whitespace",
@@ -34,7 +34,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const option = context.options[0] || "beside";
 
         /**

package/lib/rules/indent-legacy.js

@@ -28,7 +28,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent indentation",
             recommended: false,
-            url: "https://eslint.org/docs/rules/indent-legacy"
+            url: "https://eslint.org/docs/latest/rules/indent-legacy"
         },
 
         deprecated: true,
@@ -206,7 +206,7 @@ module.exports = {
             ObjectExpression: 1
         };
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         if (context.options.length) {
             if (context.options[0] === "tab") {

package/lib/rules/indent.js

@@ -12,8 +12,6 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const { OrderedMap } = require("js-sdsl");
-
 const astUtils = require("./utils/ast-utils");
 
 //------------------------------------------------------------------------------
@@ -125,43 +123,48 @@ const KNOWN_NODES = new Set([
 
 
 /**
- * A mutable balanced binary search tree that stores (key, value) pairs. The keys are numeric, and must be unique.
- * This is intended to be a generic wrapper around a balanced binary search tree library, so that the underlying implementation
+ * A mutable map that stores (key, value) pairs. The keys are numeric indices, and must be unique.
+ * This is intended to be a generic wrapper around a map with non-negative integer keys, so that the underlying implementation
  * can easily be swapped out.
  */
-class BinarySearchTree {
+class IndexMap {
 
     /**
-     * Creates an empty tree
+     * Creates an empty map
+     * @param {number} maxKey The maximum key
      */
-    constructor() {
-        this._orderedMap = new OrderedMap();
-        this._orderedMapEnd = this._orderedMap.end();
+    constructor(maxKey) {
+
+        // Initializing the array with the maximum expected size avoids dynamic reallocations that could degrade performance.
+        this._values = Array(maxKey + 1);
     }
 
     /**
-     * Inserts an entry into the tree.
+     * Inserts an entry into the map.
      * @param {number} key The entry's key
      * @param {any} value The entry's value
      * @returns {void}
      */
     insert(key, value) {
-        this._orderedMap.setElement(key, value);
+        this._values[key] = value;
     }
 
     /**
-     * Finds the entry with the largest key less than or equal to the provided key
+     * Finds the value of the entry with the largest key less than or equal to the provided key
      * @param {number} key The provided key
-     * @returns {{key: number, value: *}|null} The found entry, or null if no such entry exists.
+     * @returns {*|undefined} The value of the found entry, or undefined if no such entry exists.
      */
-    findLe(key) {
-        const iterator = this._orderedMap.reverseLowerBound(key);
+    findLastNotAfter(key) {
+        const values = this._values;
 
-        if (iterator.equals(this._orderedMapEnd)) {
-            return {};
-        }
+        for (let index = key; index >= 0; index--) {
+            const value = values[index];
 
-        return { key: iterator.pointer[0], value: iterator.pointer[1] };
+            if (value) {
+                return value;
+            }
+        }
+        return void 0;
     }
 
     /**
@@ -171,26 +174,7 @@ class BinarySearchTree {
      * @returns {void}
      */
     deleteRange(start, end) {
-
-        // Exit without traversing the tree if the range has zero size.
-        if (start === end) {
-            return;
-        }
-        const iterator = this._orderedMap.lowerBound(start);
-
-        if (iterator.equals(this._orderedMapEnd)) {
-            return;
-        }
-
-        if (end > this._orderedMap.back()[0]) {
-            while (!iterator.equals(this._orderedMapEnd)) {
-                this._orderedMap.eraseElementByIterator(iterator);
-            }
-        } else {
-            while (iterator.pointer[0] < end) {
-                this._orderedMap.eraseElementByIterator(iterator);
-            }
-        }
+        this._values.fill(void 0, start, end);
     }
 }
 
@@ -252,14 +236,15 @@ class OffsetStorage {
      * @param {TokenInfo} tokenInfo a TokenInfo instance
      * @param {number} indentSize The desired size of each indentation level
      * @param {string} indentType The indentation character
+     * @param {number} maxIndex The maximum end index of any token
      */
-    constructor(tokenInfo, indentSize, indentType) {
+    constructor(tokenInfo, indentSize, indentType, maxIndex) {
         this._tokenInfo = tokenInfo;
         this._indentSize = indentSize;
         this._indentType = indentType;
 
-        this._tree = new BinarySearchTree();
-        this._tree.insert(0, { offset: 0, from: null, force: false });
+        this._indexMap = new IndexMap(maxIndex);
+        this._indexMap.insert(0, { offset: 0, from: null, force: false });
 
         this._lockedFirstTokens = new WeakMap();
         this._desiredIndentCache = new WeakMap();
@@ -267,7 +252,7 @@ class OffsetStorage {
     }
 
     _getOffsetDescriptor(token) {
-        return this._tree.findLe(token.range[0]).value;
+        return this._indexMap.findLastNotAfter(token.range[0]);
     }
 
     /**
@@ -388,37 +373,36 @@ class OffsetStorage {
          * * key: 820, value: { offset: 1, from: bazToken }
          *
          * To find the offset descriptor for any given token, one needs to find the node with the largest key
-         * which is <= token.start. To make this operation fast, the nodes are stored in a balanced binary
-         * search tree indexed by key.
+         * which is <= token.start. To make this operation fast, the nodes are stored in a map indexed by key.
          */
 
         const descriptorToInsert = { offset, from: fromToken, force };
 
-        const descriptorAfterRange = this._tree.findLe(range[1]).value;
+        const descriptorAfterRange = this._indexMap.findLastNotAfter(range[1]);
 
         const fromTokenIsInRange = fromToken && fromToken.range[0] >= range[0] && fromToken.range[1] <= range[1];
         const fromTokenDescriptor = fromTokenIsInRange && this._getOffsetDescriptor(fromToken);
 
-        // First, remove any existing nodes in the range from the tree.
-        this._tree.deleteRange(range[0] + 1, range[1]);
+        // First, remove any existing nodes in the range from the map.
+        this._indexMap.deleteRange(range[0] + 1, range[1]);
 
-        // Insert a new node into the tree for this range
-        this._tree.insert(range[0], descriptorToInsert);
+        // Insert a new node into the map for this range
+        this._indexMap.insert(range[0], descriptorToInsert);
 
         /*
          * To avoid circular offset dependencies, keep the `fromToken` token mapped to whatever it was mapped to previously,
          * even if it's in the current range.
          */
         if (fromTokenIsInRange) {
-            this._tree.insert(fromToken.range[0], fromTokenDescriptor);
-            this._tree.insert(fromToken.range[1], descriptorToInsert);
+            this._indexMap.insert(fromToken.range[0], fromTokenDescriptor);
+            this._indexMap.insert(fromToken.range[1], descriptorToInsert);
         }
 
         /*
          * To avoid modifying the offset of tokens after the range, insert another node to keep the offset of the following
          * tokens the same as it was before.
          */
-        this._tree.insert(range[1], descriptorAfterRange);
+        this._indexMap.insert(range[1], descriptorAfterRange);
     }
 
     /**
@@ -510,7 +494,7 @@ module.exports = {
         docs: {
             description: "Enforce consistent indentation",
             recommended: false,
-            url: "https://eslint.org/docs/rules/indent"
+            url: "https://eslint.org/docs/latest/rules/indent"
         },
 
         fixable: "whitespace",
@@ -703,9 +687,9 @@ module.exports = {
             }
         }
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const tokenInfo = new TokenInfo(sourceCode);
-        const offsets = new OffsetStorage(tokenInfo, indentSize, indentType === "space" ? " " : "\t");
+        const offsets = new OffsetStorage(tokenInfo, indentSize, indentType === "space" ? " " : "\t", sourceCode.text.length);
         const parameterParens = new WeakSet();
 
         /**

package/lib/rules/init-declarations.js

@@ -50,7 +50,7 @@ module.exports = {
         docs: {
             description: "Require or disallow initialization in variable declarations",
             recommended: false,
-            url: "https://eslint.org/docs/rules/init-declarations"
+            url: "https://eslint.org/docs/latest/rules/init-declarations"
         },
 
         schema: {

package/lib/rules/jsx-quotes.js

@@ -44,7 +44,7 @@ module.exports = {
         docs: {
             description: "Enforce the consistent use of either double or single quotes in JSX attributes",
             recommended: false,
-            url: "https://eslint.org/docs/rules/jsx-quotes"
+            url: "https://eslint.org/docs/latest/rules/jsx-quotes"
         },
 
         fixable: "whitespace",