eslint 8.39.0 → 8.41.0

package/lib/rules/valid-jsdoc.js

@@ -23,7 +23,7 @@ module.exports = {
         docs: {
             description: "Enforce valid JSDoc comments",
             recommended: false,
-            url: "https://eslint.org/docs/rules/valid-jsdoc"
+            url: "https://eslint.org/docs/latest/rules/valid-jsdoc"
         },
 
         schema: [
@@ -96,7 +96,7 @@ module.exports = {
 
         const options = context.options[0] || {},
             prefer = options.prefer || {},
-            sourceCode = context.getSourceCode(),
+            sourceCode = context.sourceCode,
 
             // these both default to true, so you have to explicitly make them false
             requireReturn = options.requireReturn !== false,

package/lib/rules/valid-typeof.js

@@ -16,7 +16,7 @@ module.exports = {
         docs: {
             description: "Enforce comparing `typeof` expressions against valid strings",
             recommended: true,
-            url: "https://eslint.org/docs/rules/valid-typeof"
+            url: "https://eslint.org/docs/latest/rules/valid-typeof"
         },
 
         hasSuggestions: true,
@@ -44,7 +44,7 @@ module.exports = {
 
         const VALID_TYPES = new Set(["symbol", "undefined", "object", "boolean", "number", "string", "function", "bigint"]),
             OPERATORS = new Set(["==", "===", "!=", "!=="]);
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
         const requireStringLiterals = context.options[0] && context.options[0].requireStringLiterals;
 
         let globalScope;

package/lib/rules/vars-on-top.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require `var` declarations be placed at the top of their containing scope",
             recommended: false,
-            url: "https://eslint.org/docs/rules/vars-on-top"
+            url: "https://eslint.org/docs/latest/rules/vars-on-top"
         },
 
         schema: [],

package/lib/rules/wrap-iife.js

@@ -45,7 +45,7 @@ module.exports = {
         docs: {
             description: "Require parentheses around immediate `function` invocations",
             recommended: false,
-            url: "https://eslint.org/docs/rules/wrap-iife"
+            url: "https://eslint.org/docs/latest/rules/wrap-iife"
         },
 
         schema: [
@@ -77,7 +77,7 @@ module.exports = {
         const style = context.options[0] || "outside";
         const includeFunctionPrototypeMethods = context.options[1] && context.options[1].functionPrototypeMethods;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Check if the node is wrapped in any (). All parens count: grouping parens and parens for constructs such as if()

package/lib/rules/wrap-regex.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require parenthesis around regex literals",
             recommended: false,
-            url: "https://eslint.org/docs/rules/wrap-regex"
+            url: "https://eslint.org/docs/latest/rules/wrap-regex"
         },
 
         schema: [],
@@ -29,7 +29,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         return {
 

package/lib/rules/yield-star-spacing.js

@@ -17,7 +17,7 @@ module.exports = {
         docs: {
             description: "Require or disallow spacing around the `*` in `yield*` expressions",
             recommended: false,
-            url: "https://eslint.org/docs/rules/yield-star-spacing"
+            url: "https://eslint.org/docs/latest/rules/yield-star-spacing"
         },
 
         fixable: "whitespace",
@@ -48,7 +48,7 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         const mode = (function(option) {
             if (!option || typeof option === "string") {

package/lib/rules/yoda.js

@@ -123,7 +123,7 @@ module.exports = {
         docs: {
             description: 'Require or disallow "Yoda" conditions',
             recommended: false,
-            url: "https://eslint.org/docs/rules/yoda"
+            url: "https://eslint.org/docs/latest/rules/yoda"
         },
 
         schema: [
@@ -162,7 +162,7 @@ module.exports = {
         const onlyEquality =
             context.options[1] && context.options[1].onlyEquality;
 
-        const sourceCode = context.getSourceCode();
+        const sourceCode = context.sourceCode;
 
         /**
          * Determines whether node represents a range test.

package/lib/shared/string-utils.js

@@ -5,6 +5,26 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const Graphemer = require("graphemer").default;
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+// eslint-disable-next-line no-control-regex -- intentionally including control characters
+const ASCII_REGEX = /^[\u0000-\u007f]*$/u;
+
+/** @type {Graphemer | undefined} */
+let splitter;
+
+//------------------------------------------------------------------------------
+// Public Interface
+//------------------------------------------------------------------------------
+
 /**
  * Converts the first letter of a string to uppercase.
  * @param {string} string The string to operate on
@@ -17,6 +37,24 @@ function upperCaseFirst(string) {
     return string[0].toUpperCase() + string.slice(1);
 }
 
+/**
+ * Counts graphemes in a given string.
+ * @param {string} value A string to count graphemes.
+ * @returns {number} The number of graphemes in `value`.
+ */
+function getGraphemeCount(value) {
+    if (ASCII_REGEX.test(value)) {
+        return value.length;
+    }
+
+    if (!splitter) {
+        splitter = new Graphemer();
+    }
+
+    return splitter.countGraphemes(value);
+}
+
 module.exports = {
-    upperCaseFirst
+    upperCaseFirst,
+    getGraphemeCount
 };

package/lib/shared/types.js

@@ -96,10 +96,12 @@ module.exports = {};
  * @property {number|undefined} column The 1-based column number.
  * @property {number} [endColumn] The 1-based column number of the end location.
  * @property {number} [endLine] The 1-based line number of the end location.
- * @property {boolean} fatal If `true` then this is a fatal error.
+ * @property {boolean} [fatal] If `true` then this is a fatal error.
  * @property {{range:[number,number], text:string}} [fix] Information for autofix.
  * @property {number|undefined} line The 1-based line number.
  * @property {string} message The error message.
+ * @property {string} [messageId] The ID of the message in the rule's meta.
+ * @property {(string|null)} nodeType Type of node
  * @property {string|null} ruleId The ID of the rule which makes this message.
  * @property {0|1|2} severity The severity of this message.
  * @property {Array<{desc?: string, messageId?: string, fix: {range: [number, number], text: string}}>} [suggestions] Information for suggestions.
@@ -110,10 +112,12 @@ module.exports = {};
  * @property {number|undefined} column The 1-based column number.
  * @property {number} [endColumn] The 1-based column number of the end location.
  * @property {number} [endLine] The 1-based line number of the end location.
- * @property {boolean} fatal If `true` then this is a fatal error.
+ * @property {boolean} [fatal] If `true` then this is a fatal error.
  * @property {{range:[number,number], text:string}} [fix] Information for autofix.
  * @property {number|undefined} line The 1-based line number.
  * @property {string} message The error message.
+ * @property {string} [messageId] The ID of the message in the rule's meta.
+ * @property {(string|null)} nodeType Type of node
  * @property {string|null} ruleId The ID of the rule which makes this message.
  * @property {0|1|2} severity The severity of this message.
  * @property {Array<{kind: string, justification: string}>} suppressions The suppression info.

package/lib/unsupported-api.js

@@ -12,7 +12,7 @@
 //-----------------------------------------------------------------------------
 
 const { FileEnumerator } = require("./cli-engine/file-enumerator");
-const { FlatESLint } = require("./eslint/flat-eslint");
+const { FlatESLint, shouldUseFlatConfig } = require("./eslint/flat-eslint");
 const FlatRuleTester = require("./rule-tester/flat-rule-tester");
 
 //-----------------------------------------------------------------------------
@@ -22,6 +22,7 @@ const FlatRuleTester = require("./rule-tester/flat-rule-tester");
 module.exports = {
     builtinRules: require("./rules"),
     FlatESLint,
+    shouldUseFlatConfig,
     FlatRuleTester,
     FileEnumerator
 };

package/messages/invalid-rule-options.js

@@ -0,0 +1,17 @@
+"use strict";
+
+const { stringifyValueForError } = require("./shared");
+
+module.exports = function({ ruleId, value }) {
+    return `
+Configuration for rule "${ruleId}" is invalid. Each rule must have a severity ("off", 0, "warn", 1, "error", or 2) and may be followed by additional options for the rule.
+
+You passed '${stringifyValueForError(value, 4)}', which doesn't contain a valid severity.
+
+If you're attempting to configure rule options, perhaps you meant:
+
+    "${ruleId}": ["error", ${stringifyValueForError(value, 8)}]
+
+See https://eslint.org/docs/latest/use/configure/rules#using-configuration-files for configuring rules.
+`.trimStart();
+};

package/messages/invalid-rule-severity.js

@@ -0,0 +1,13 @@
+"use strict";
+
+const { stringifyValueForError } = require("./shared");
+
+module.exports = function({ ruleId, value }) {
+    return `
+Configuration for rule "${ruleId}" is invalid. Expected severity of "off", 0, "warn", 1, "error", or 2.
+
+You passed '${stringifyValueForError(value, 4)}'.
+
+See https://eslint.org/docs/latest/use/configure/rules#using-configuration-files for configuring rules.
+`.trimStart();
+};

package/messages/shared.js

@@ -0,0 +1,18 @@
+/**
+ * @fileoverview Shared utilities for error messages.
+ * @author Josh Goldberg
+ */
+
+"use strict";
+
+/**
+ * Converts a value to a string that may be printed in errors.
+ * @param {any} value The invalid value.
+ * @param {number} indentation How many spaces to indent
+ * @returns {string} The value, stringified.
+ */
+function stringifyValueForError(value, indentation) {
+    return value ? JSON.stringify(value, null, 4).replace(/\n/gu, `\n${" ".repeat(indentation)}`) : `${value}`;
+}
+
+module.exports = { stringifyValueForError };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "8.39.0",
+  "version": "8.41.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -62,8 +62,8 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.4.0",
-    "@eslint/eslintrc": "^2.0.2",
-    "@eslint/js": "8.39.0",
+    "@eslint/eslintrc": "^2.0.3",
+    "@eslint/js": "8.41.0",
     "@humanwhocodes/config-array": "^0.11.8",
     "@humanwhocodes/module-importer": "^1.0.1",
     "@nodelib/fs.walk": "^1.2.8",
@@ -74,8 +74,8 @@
     "doctrine": "^3.0.0",
     "escape-string-regexp": "^4.0.0",
     "eslint-scope": "^7.2.0",
-    "eslint-visitor-keys": "^3.4.0",
-    "espree": "^9.5.1",
+    "eslint-visitor-keys": "^3.4.1",
+    "espree": "^9.5.2",
     "esquery": "^1.4.2",
     "esutils": "^2.0.2",
     "fast-deep-equal": "^3.1.3",
@@ -83,13 +83,12 @@
     "find-up": "^5.0.0",
     "glob-parent": "^6.0.2",
     "globals": "^13.19.0",
-    "grapheme-splitter": "^1.0.4",
+    "graphemer": "^1.4.0",
     "ignore": "^5.2.0",
     "import-fresh": "^3.0.0",
     "imurmurhash": "^0.1.4",
     "is-glob": "^4.0.0",
     "is-path-inside": "^3.0.3",
-    "js-sdsl": "^4.1.4",
     "js-yaml": "^4.1.0",
     "json-stable-stringify-without-jsonify": "^1.0.1",
     "levn": "^0.4.1",